Re: [libvirt] Printing runtime DAC seclabel in the XML

On Sat, Apr 23, 2016 at 01:10:01PM -0400, Cole Robinson wrote: On 04/22/2016 01:28 AM, Martin Kletzander wrote: On Thu, Apr 21, 2016 at 10:16:41AM -0400, Cole Robinson wrote: On 04/21/2016 06:08 AM, Martin Kletzander wrote: On Wed, Apr 20, 2016 at 07:57:05PM -0400, Cole Robinson wrote: I'm

[libvirt] [PATCH 0/4] network/nwfilter daemon reload fixes

Fix some issues with libvirtd reload (SIGHUP) handling in the network and nwfilter drivers Cole Robinson (4): network: Fix segfault on daemon reload nwfilter: Fix potential locking problems on ObjLoad failure nwfilter: Push configFile building into LoadConfig nwfilter: Save config to disk

[libvirt] [PATCH 1/4] network: Fix segfault on daemon reload

We will segfault of a daemon reload picks up a new network config that needs to be autostarted. We shouldn't be passing NULL for network_driver here. This seems like it was missed in the larger rework in commit 1009a61e --- src/network/bridge_driver.c | 2 +- 1 file changed, 1 insertion(+), 1

[libvirt] [PATCH 4/4] nwfilter: Save config to disk if we generated a UUID

libvirt-daemon-config-nwfilter will put a bunch of xml configs into /etc/libvirt/nwfilter. These configs don't hardcode a UUID and depends on libvirt to generate one. However the generated UUID is never saved to disk, unless the user manually calls Define. This makes daemon reload quite noisy

[libvirt] [PATCH 3/4] nwfilter: Push configFile building into LoadConfig

This matches the pattern used for network object APIs, and we want configDir in LoadConfig for upcoming patches --- src/conf/nwfilter_conf.c | 45 - 1 file changed, 24 insertions(+), 21 deletions(-) diff --git a/src/conf/nwfilter_conf.c

[libvirt] [PATCH 2/4] nwfilter: Fix potential locking problems on ObjLoad failure

In virNWFilterObjLoad we can still fail after virNWFilterObjAssignDef, but we don't unlock and free the created virNWFilterObjPtr in the cleanup path. The bit we are trying to do after AssignDef is just STRDUP in the configFile path. However caching the configFile in the NWFilterObj is largely

[libvirt] [PATCH 1/2] rpc: protocol: Clarify VIR_NET_ERROR usage with streams

The described protocol semantics really only apply to server initiated stream messages. Document the semantics for client messages. --- AFAICT, the only time a server will receive VIR_NET_ERROR stream message from a client is via an explicit virStreamAbort call (which hits

[libvirt] [PATCH 2/2] daemon: stream: Don't log error when client aborts

Every time a client aborts a stream via the virStreamAbort API, the daemon always logs an error like: error : daemonStreamHandleAbort:617 : stream aborted at client request For example, this message is logged any time the user disconnects from 'virsh console'. However this isn't really an

[libvirt] [PATCH v2] bhyve: implement domainShutdown

Bhyve supports ACPI shutdown by issuing SIGTERM signal to the bhyve process. Add the bhyveDomainShutdown() function and virBhyveProcessShutdown() helper function that just sends SIGTERM to VM's bhyve process. If a guest supports ACPI shutdown then process will be terminated and this event will be

Re: [libvirt] [libvirt-python][PATCH] sanitytest: Sanitize VIR_TYPED_PARAM_*

On 22.04.2016 13:55, Peter Krempa wrote: > On Fri, Apr 22, 2016 at 11:09:52 +0200, Michal Privoznik wrote: >> This test checks whether all enums that we produce in libvirt.py >> have some reasonable value. But because of some crazy backcompat >> we have the following in libvirt-domain.h: >> >>