Re: [libvirt] [PATCH 4/4] nwfilter: Save config to disk if we generated a UUID

On 04/24/2016 07:22 PM, Cole Robinson wrote: > libvirt-daemon-config-nwfilter will put a bunch of xml configs > into /etc/libvirt/nwfilter. These configs don't hardcode a UUID > and depends on libvirt to generate one. However the generated UUID > is never saved to disk, unless the user manually

Re: [libvirt] [PATCH 3/4] nwfilter: Push configFile building into LoadConfig

On 04/24/2016 07:22 PM, Cole Robinson wrote: > This matches the pattern used for network object APIs, and we want > configDir in LoadConfig for upcoming patches > --- > src/conf/nwfilter_conf.c | 45 - > 1 file changed, 24 insertions(+), 21

Re: [libvirt] [PATCH 2/4] nwfilter: Fix potential locking problems on ObjLoad failure

On 04/24/2016 07:22 PM, Cole Robinson wrote: > In virNWFilterObjLoad we can still fail after virNWFilterObjAssignDef, > but we don't unlock and free the created virNWFilterObjPtr in the > cleanup path. > > The bit we are trying to do after AssignDef is just STRDUP in the > configFile path.

Re: [libvirt] [PATCH 1/4] network: Fix segfault on daemon reload

On 04/24/2016 07:22 PM, Cole Robinson wrote: > We will segfault of a daemon reload picks up a new network config > that needs to be autostarted. We shouldn't be passing NULL for > network_driver here. This seems like it was missed in the larger > rework in commit 1009a61e > --- >

[libvirt] [PATCH] Fix minor typos in messages

Hi, Many thanks for reviewing this patch. Best regards, Yuri 0001-Fix-minor-typos-in-messages.patch Description: Binary data -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2] send default USB controller in xml to destination during migration

On 04/29/2016 10:01 AM, Shivaprasad G Bhat wrote: > The default USB controller is not sent to destination as the older versions > of libvirt(0.9.4 or earlier as I see in commit log of 409b5f54) didn't > support them. For some archs where the support started much later can > safely send the USB

[libvirt] [PATCH 1/2] qemu: Introduce qemuMonitorGetRTCTime

Signed-off-by: Michal Privoznik --- src/qemu/qemu_monitor.c | 11 +++ src/qemu/qemu_monitor.h | 3 +++ src/qemu/qemu_monitor_json.c | 45 src/qemu/qemu_monitor_json.h | 3 +++ 4 files changed, 62 insertions(+)

[libvirt] [PATCH 2/2] qemu: Refresh RTC adjustment on qemuProcessReconnect

https://bugzilla.redhat.com/show_bug.cgi?id=1139766 Thing is, for some reasons you can have your domain's RTC to be in something different than UTC. More weirdly, it's not only time zone what you can shift it of, but an arbitrary value. So, if domain is configured that way, libvirt will correctly

[libvirt] [PATCH 0/2] qemu: Refresh guest's RTC on daemon restart

Thing is, there are is an event that we use to keep our internal state in sync with qemu. If libvirtd is not running, our internal state gets out of sync. Therefore we must refresh it as soon as we are started. Michal Privoznik (2): qemu: Introduce qemuMonitorGetRTCTime qemu: Refresh RTC

Re: [libvirt] [PATCH 0/3] revert publicly visible parts of IP address "peer" patches

On Fri, Apr 29, 2016 at 12:04:28PM -0400, Laine Stump wrote: > Due to the feature not working, and a couple questions about the > design that haven't been resolved and may require publicly visible > changes, these patches temporarily revert the three patches that add > support for the ip element

Re: [libvirt] RFC filesystem pool proposal description.

28.04.2016 20:45, Maxim Nestratov пишет: 28.04.2016 20:29, Daniel P. Berrange пишет: On Thu, Apr 28, 2016 at 07:57:14PM +0300, Olga Krishtal wrote: In this proposal description we would like to introduce a separate pool type:fspool. Fspool provides and manages filesystems. Below are listed

[libvirt] [PATCH 3/3] Revert "libvirt domain xml allow to set peer address"

This reverts commit 690969af9ccdf9b2012b97af0462bae8e312c9c9, which added the domain config parts to support a "peer" attribute in domain interface elements. It's being removed temporarily for the release of libvirt 1.3.4 because the feature doesn't work, and there are concerns that it may need

[libvirt] [PATCH 2/3] Revert "lxc domain allow to set peer address"

This reverts commit afee47d07c521b4bb10a12e253a29363d16ab8f0, which added support to lxc for the "peer" attribute in domain interface elements. It's being removed temporarily for the release of libvirt 1.3.4 because the feature doesn't work, and there are concerns that it may need to be modified

[libvirt] [PATCH 1/3] Revert "qemu domain allow to set ip address, peer address and route"

This reverts commit 6e244c659fb004503fd2a94319dae8fa6fecf045, which added support to qemu for the "peer" attribute in domain interface elements. It's being removed temporarily for the release of libvirt 1.3.4 because the feature doesn't work, and there are concerns that it may need to be

[libvirt] [PATCH 0/3] revert publicly visible parts of IP address "peer" patches

Due to the feature not working, and a couple questions about the design that haven't been resolved and may require publicly visible changes, these patches temporarily revert the three patches that add support for the ip element "peer" attribute to qemu and lxc. (Note that I left in the patch that

[libvirt] [PATCH 2/1] storage: Merge into 1/1

As it turns out, trusting that being 0 means it wasn't provided isn't such a good idea. If someone provided a of 10 and of 0, then we need to honor it. So this patch which I'll merge into the previous patch will track when the XML is read if the allocation was provided or not. That way we can

[libvirt] [PATCH v2] send default USB controller in xml to destination during migration

The default USB controller is not sent to destination as the older versions of libvirt(0.9.4 or earlier as I see in commit log of 409b5f54) didn't support them. For some archs where the support started much later can safely send the USB controllers without this worry. So, send the controller to

Re: [libvirt] [PATCH] storage: Fix regression cloning volume into a logical pool

On 04/29/2016 08:35 AM, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1318993 > > Commit id 'dd519a294' caused a regression cloning a volume into a > logical pool by removing just the 'allocation' adjustment during > storageVolCreateXMLFrom. Combined with the change to not

[libvirt] [PATCH 0/3] Admin API: Add support for client disconnect

This series adds a simple support for a client force disconnect. As with the series about client identity retrieval, this series is rebased on listing clients due to some gendispatch stuff needed in all of them. To test it, you checkout my remote branch

[libvirt] [PATCH 3/3] virt-admin: Introduce client-disconnect command

Enable the client disconnect within virt-admin. Also, update the man page accordingly. Signed-off-by: Erik Skultety --- tools/virt-admin.c | 72 tools/virt-admin.pod | 16 2 files changed, 88 insertions(+)

[libvirt] [PATCH 1/3] admin: Introduce virAdmServerLookupClient

Just like with server-related APIs, before any of client-based APIs can be called, a reference to a client-side client object needs to be obtained. For this purpose, a lookup method should exist. Apart from the client retrieval logic, a new error code for non-existent client had to be added as

Re: [libvirt] [PATCH] storage: Fix regression cloning volume into a logical pool

On 04/29/2016 08:35 AM, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1318993 > > Commit id 'dd519a294' caused a regression cloning a volume into a > logical pool by removing just the 'allocation' adjustment during > storageVolCreateXMLFrom. Combined with the change to not

[libvirt] [PATCH 2/3] admin: Introduce virAdmClientClose API

Once we're able to list and identify all clients connected to a specific server, we can then support force-closing a connection. This patch introduces a simple API calling virNetServerClientClose on a specific client, which can be later extended easily, e.g. by sending an event once the client is

[libvirt] [PATCH 6/7] admin: Introduce virAdmClientGetInfo API

Expose a public API to retrieve some identity and connection information about a client connected to the specified server on daemon. The identity info retrieved is mostly connection transport dependent, i.e. there won't be any socket address returned for a local (UNIX socket) connection, while on

[libvirt] [PATCH 3/7] virnetsocket: Provide socket address format in a more standard form

Our socket address format is in a rather non-standard format and that is because sasl library requires the IP address and service to be delimited by a semicolon. The string form is a completely internal matter, however once the admin interfaces to retrieve client identity information are merged,

[libvirt] [PATCH 5/7] virnetserverclient: Add an internal method to retrieve client's identity

This method just aggregates various client object attributes, like socket address, connection type (RO/RW), and some TCP/TLS/UNIX identity in an atomic manner. Signed-off-by: Erik Skultety --- src/rpc/virnetserverclient.c | 26 ++

[libvirt] [PATCH 4/7] virneserverclient: Introduce virNetServerClientHasSASLSession

We do have a similar method, serving the same purpose, for TLS, but we lack one for SASL. So introduce one, in order for other modules to be able to find out, if a SASL session is active, or better said, that a SASL session exists at all. Signed-off-by: Erik Skultety ---

[libvirt] [PATCH 7/7] virt-admin: Introduce command client-info

Wire-up the client identity getter into virt-admin tool. This patch adjusts man-page accordingly. Signed-off-by: Erik Skultety --- tools/virt-admin.c | 91 ++ 1 file changed, 91 insertions(+) diff --git

[libvirt] [PATCH 0/7] Admin API: Add support for client identity info retrieval

This series adds support for client identity retrieval, i.e. information like remote IP (if connected remotely), uid,gid,pid, as well as username if connected locally and also information regarding authentication (if used). The series is rebased on the listing clients series, because it relies on

[libvirt] [PATCH 2/7] admin: include: Introduce some client's identity related typed params macros

This patch could easily be squashed with the virAdmClientGetInfo method introduced later one, but the idea was to split the logic to as many preferably independent patches as possible. As the subject hints, this patch defines some public typed params-related macros used within virAdmClientGetInfo

[libvirt] [PATCH 1/7] admin: Introduce virAdmServerLookupClient

Just like with server-related APIs, before any of client-based APIs can be called, a reference to a client-side client object needs to be obtained. For this purpose, a lookup method should exist. Apart from the client retrieval logic, a new error code for non-existent client had to be added as

[libvirt] [PATCH v3 4/6] docs: align spelling of S390

Signed-off-by: Boris Fiuczynski --- docs/formatdomain.html.in | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 81f4d48..936f2de 100644 --- a/docs/formatdomain.html.in +++

[libvirt] [PATCH v3 0/6] Add panic device support for S390

S390 architecture inherently provides a crash detection capability which has not been reflected in the domain xml. This series adds an s390 model to the panic device which does not allow an address to be specified and is by default created on S390 guests unless already provided. v3: * Merged S390

[libvirt] [PATCH v3 5/6] qemu: merge S390 and S390X default device creation

Signed-off-by: Boris Fiuczynski --- src/qemu/qemu_domain.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 4384c26..db58019 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@

[libvirt] [PATCH v3 6/6] qemu: fix error message for default panic device

Adding the default bus type ISA to the message. Signed-off-by: Boris Fiuczynski --- src/qemu/qemu_command.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 05071f0..916ae36 100644 ---

[libvirt] [PATCH v3 1/6] qemu: add panic device support for S390

If a panic device is being defined without a model in a domain the default value is always overwritten with model ISA. An ISA bus does not exist on S390 and therefore specifying a panic device results in an unsupported configuration. Since the S390 architecture inherently provides a crash

[libvirt] [PATCH v3 3/6] tests: add tests for panic device model s390

Signed-off-by: Boris Fiuczynski --- .../qemuxml2argv-s390-panic-address.xml| 26 +++ .../qemuxml2argv-s390-panic-missing.args | 25 +++ .../qemuxml2argv-s390-panic-missing.xml| 23 +

[libvirt] [PATCH v3 2/6] qemu: add default panic device to S390 guests

This patch adds by default a panic device with model s390 to S390 guests. Signed-off-by: Boris Fiuczynski --- src/qemu/qemu_domain.c | 6 +- tests/qemuargv2xmldata/qemuargv2xml-machine-aeskeywrap-off-argv.xml | 1 +

Re: [libvirt] [PATCH 1/2] virsh: Introduce virshDomainDetachInterface function.

On 04/28/2016 05:11 AM, Nitesh Konkar wrote: > virshDomainDetachInterface handles virsh interface > detach from the specified live/config domain xml. > > Signed-off-by: Nitesh Konkar > --- > tools/virsh-domain.c | 99 >

Re: [libvirt] [PATCH v3] tools: Fix connect command

On 04/28/2016 10:49 AM, Martin Kletzander wrote: > The man page says: "(Re)-Connect to the hypervisor. When the shell is > first started, this is automatically run with the URI parameter > requested by the "-c" option on the command line." However, if you run: > > virsh -c 'test://default'

Re: [libvirt] [PATCH 0/2] qemu: fixes for empty ejectable media drives

On 29.04.2016 14:02, Peter Krempa wrote: > Peter Krempa (2): > qemu: process: Refresh ejectable media tray state on VM start > qemu: hotplug: Skip waiting for tray opening if qemu doesn't notify us > > src/qemu/qemu_capabilities.c | 2 ++ > src/qemu/qemu_capabilities.h

[libvirt] [PATCH v2 5/9] rpc: virnetserver: Support retrieval of a list of clients

For now, the list copy is done simply by locking the whole server, walking the original and increasing the refcount on each object. We may want to change the list to a lockable object (like list of domains) later in the future if we discover some performance issues related to locking the whole

[libvirt] [PATCH v2 8/9] admin: Introduce listing clients

Finally add public method to retrieve the list of currently connected clients to a given server. Signed-off-by: Erik Skultety --- daemon/admin.c | 15 +++ daemon/admin_server.c | 23 +++ daemon/admin_server.h

[libvirt] [PATCH v2 2/9] rpc: virnetserverclient: Introduce new attribute conn_time to client

Besides ID, libvirt should provide several parameters to help the user distinguish two clients from each other. One of them is the connection timestamp. This patch also adds a testcase for proper JSON formatting of the new attribute too (proper formatting of older clients that did not support this

[libvirt] [PATCH v2 9/9] virt-admin: Introduce srv-clients-list command

Wire-up the public client listing API. Along with this change, a private time simple conversion method to interpret client's timestamp obtained from server has been added as well. Format used to for time output is as follows: -mm-DD HH:MM:SS+. Although libvirt exposes methods time-related

[libvirt] [PATCH v2 6/9] include: admin: export connection transport constants

We have to expose some constants, in order for the client object transport field to make sense. Signed-off-by: Erik Skultety --- include/libvirt/libvirt-admin.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/include/libvirt/libvirt-admin.h

[libvirt] [PATCH v2 4/9] rpc: gendispatch: Tune it to support client structure

Now that libvirt-admin supports another client-side object and provided that we want to generate as many both client-side and server-side RPC dispatchers, support for this needs to be added to gendispatch. Signed-off-by: Erik Skultety --- src/rpc/gendispatch.pl | 75

[libvirt] [PATCH v2 7/9] rpc: virnetserverclient: Implement client connection transport retrieval

Although we document 6 types of transport that we support, internally we can only differentiate between TCP, TLS, and UNIX transports only, since both SSH and libssh2 transports, due to using netcat, behave in the exactly the same way as a UNIX socket. Signed-off-by: Erik Skultety

[libvirt] [PATCH v2 3/9] admin: Introduce virAdmClient client-side object

Besides ID, the object also stores static data like connection transport and connection timestamp, since once obtained a list of all clients connected to a server, from user's perspective, it would be nice to know whether a given client is remote or local only and when did it connect to the

[libvirt] [PATCH v2 1/9] rpc: virnetserverclient: Identify clients by an integer ID

Admin API needs a way of addressing specific clients. Unlike servers, which we are happy to address by names both because its name reflects its purpose (to some extent) and we only have two of them (so far), naming clients doesn't make any sense, since a) each client is an anonymous, i.e. not

[libvirt] [PATCH v2 0/9] admin: Admin API: Introduce client listing API

v2: - gendispatch was modified to be able to generate more client related code - Martin noticed that I added avahi-related field into my tests which caused the tests to fail for him, since he doesn't compile with avahi - fixed - coverity complained that clts might be uninitialized when calling

[libvirt] [PATCH] storage: Fix regression cloning volume into a logical pool

https://bugzilla.redhat.com/show_bug.cgi?id=1318993 Commit id 'dd519a294' caused a regression cloning a volume into a logical pool by removing just the 'allocation' adjustment during storageVolCreateXMLFrom. Combined with the change to not require the new volume input XML to have a capacity

Re: [libvirt] [PATCH] send default USB controller in xml to destination during migration on PPC64

On 04/28/2016 03:05 AM, Shivaprasad bhat wrote: > Thanks Cole.. Here is the XML for a PPC64 guest. > https://paste.fedoraproject.org/360574/61826548/ > You can see the slot 1 is free as I unplugged a device there. > > On X86, Q35 seems to use the model ich9-ehci1 by default. So, may not be >

[libvirt] [PATCH 1/2] qemu: process: Refresh ejectable media tray state on VM start

Empty floppy drives start with tray in "open" state and libvirt did not refresh it after startup. The code that inserts media into the tray then waited until the tray was open before inserting the media and thus floppies could not be inserted. Resolves:

[libvirt] [PATCH 2/2] qemu: hotplug: Skip waiting for tray opening if qemu doesn't notify us

If qemu doesn't support DEVICE_TRAY_MOVED event the code that attempts to change media would attempt to re-eject the tray even if it wouldn't be notified when the tray opened. Add a capability bit and skip retrying for old qemus. --- src/qemu/qemu_capabilities.c | 2 ++

[libvirt] [PATCH 0/2] qemu: fixes for empty ejectable media drives

Peter Krempa (2): qemu: process: Refresh ejectable media tray state on VM start qemu: hotplug: Skip waiting for tray opening if qemu doesn't notify us src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_hotplug.c

Re: [libvirt] [PATCH 1/4] rpc: Don't leak fd via CreateXMLWithFiles

On 04/28/2016 02:55 AM, Pavel Hrdina wrote: > On Wed, Apr 27, 2016 at 06:33:58PM -0400, Cole Robinson wrote: >> From: Ben Gray >> >> FD passing APIs like CreateXMLWithFiles or OpenGraphicsFD will leak >> file descriptors. The user passes in an fd, which is dup()'d in >>

Re: [libvirt] [PATCH 1/2] configure: Improve --with-init-script=check

On Fri, 2016-04-29 at 09:14 +0200, Ján Tomko wrote: > > diff --git a/configure.ac b/configure.ac > > index de5f430..4b92e85 100644 > > --- a/configure.ac > > +++ b/configure.ac > > @@ -647,10 +647,19 @@ case "$with_init_script" in > >  none) > > ;; > >  check) > > -   if test

Re: [libvirt] [PATCH v2 1/3] qemuhotplugtest: Allow testing of live data

On Thu, Apr 28, 2016 at 04:43:40PM +0200, Martin Kletzander wrote: > For now, the test was dumping an XML of inactive domain (well, setting > the id to '-1' to be precise) when checking the results. This patch > enables future additions to test the live XML output as well. > > Signed-off-by:

Re: [libvirt] [PATCH 2/2] configure: Add systemd detection to --with-init-script=check

On Fri, Apr 29, 2016 at 09:24:19AM +0200, Ján Tomko wrote: On Thu, Apr 28, 2016 at 05:54:34PM +0200, Andrea Bolognani wrote: Most distributions, including RHEL, have switched to systemd, so it makes sense for it to be the preferred choice. From "preferred choice" I would expect

Re: [libvirt] [PATCH 0/6] qemu: Yet another set of fixes for the 'perf' event feature

On Wed, Apr 27, 2016 at 03:32:28PM +0200, Peter Krempa wrote: > More broken stuff ... sigh. > ACK and safe for freeze -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/3] qemu: Fix checks when changing disk media

On 28.04.2016 18:08, Peter Krempa wrote: > Few fields were missing and few fields can be actually changed. > > The last two patches actually fix > https://bugzilla.redhat.com/show_bug.cgi?id=1326660 since we reported > incorrect > error message. > > Peter Krempa (3): > qemu: domain: Fix error

Re: [libvirt] [PATCH 2/2] configure: Add systemd detection to --with-init-script=check

On Thu, Apr 28, 2016 at 05:54:34PM +0200, Andrea Bolognani wrote: > Most distributions, including RHEL, have switched to systemd, > so it makes sense for it to be the preferred choice. > >From "preferred choice" I would expect with_init_script=systemd is the default, but the patch actually does

Re: [libvirt] [PATCH 1/2] configure: Improve --with-init-script=check

On Thu, Apr 28, 2016 at 05:54:33PM +0200, Andrea Bolognani wrote: > If we didn't find a match, either because we're cross compiling > or because we're not building on RHEL, we won't install any > init script. > > Make sure this is reported correctly in the configure summary. > --- > configure.ac

Re: [libvirt] [PATCH v3 1/2] conf: Add support of zero-detection for disks

On Thu, Apr 28, 2016 at 16:56:55 +0200, Martin Kletzander wrote: > This option allows or disallows detection of zero-writes if it is set to > "on" or "off", respectively. It can be also set to "unmap" in which > case it will try discarding that part of image based on the value of the > "discard"