On Thu, May 05, 2016 at 05:56:55PM +0200, Michal Privoznik wrote:
> Fron c3bd0019c0e on instead of creating the following path for
> cgroups:
>
> /sys/fs/cgroupX/$name.libvirt-$driver
>
> we generate rather more verbose one:
>
> /sys/fs/cgroupX/$driver-$id-$name.libvirt-$driver
>
> where $n
On 04/18/2016 02:01 PM, Kothapally Madhu Pavan wrote:
> When we try to detach a network device without specifying
> the mac address, random mac address is generated. As the
> generated mac address will not be available in the running
> vm, detaching device will fail erroring out "error:
> operati
On 04/13/2016 11:14 AM, Martin Kletzander wrote:
> v5:
> - Just a rebase, plus v4 had some hunk in that didn't belong there so
>this one's cleaner to look at
> - https://www.redhat.com/archives/libvir-list/2016-March/msg01436.html
>
> v4:
> - Added test case without "heads="
> - Don't co
Partial fix for:
https://bugzilla.redhat.com/show_bug.cgi?id=1182074
If they're available and we need to pass secrets to qemu, then use the
qemu domain secret object in order to pass the secrets for RBD volumes
instead of passing the base64 encoded secret on the command line.
The goal is to make
New APIs:
qemuDomainGetIVKeyAlias:
Generate/return the secret object alias for an initialization
vector (IV) secret info type. This will be saved in the secret
info block. This will be called from qemuDomainSecretIVSetup.
qemuDomainSecretHaveEncrypt: (private)
Boolean function
v2 here:
http://www.redhat.com/archives/libvir-list/2016-May/msg00067.html
First 6 patches from v2 were pushed since they were ACK'd
I modified the 7th patch to add the ATTRIBUTE_UNUSED to the static
functions qemuDomainSecretHaveEncypt and qemuDomainSecretIVSetup and
merged in the HAVE_GNUTLS_CI
On Fri, 2016-01-29 at 01:32 -0500, Shivaprasad G Bhat wrote:
> The nodeinfo output was fixed earlier to reflect the actual cpus available in
> KVM mode on PPC64. The earlier fixes covered the aspect of not making a host
> look overcommitted when its not. The current fixes are aimed at helping the
>
Michal Privoznik wrote:
> On 04.05.2016 13:50, Roman Bogorodskiy wrote:
> > Hi,
> >
> > I'd like to introduce Fabian Freyer (CCed), he's taking part in Google
> > Support of Code this year within FreeBSD organization and his project is
> > called "Improving libvirt support for bhyve".
>
> Hey,
On Wed, Apr 27, 2016 at 06:34:01PM -0400, Cole Robinson wrote:
> This removes the opencoded payload freeing in the client, to use
> the shared virNetMessageClearPayload call. Two changes:
>
> - ClearPayload sets nfds=0, which fixes a potential crash if
> an error path called virNetMessageFree/Cl
On Wed, Apr 27, 2016 at 06:34:00PM -0400, Cole Robinson wrote:
> Set all counters to 0. This doesn't impact current users, but
> future users will want this
> ---
ACK
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Wed, Apr 27, 2016 at 06:33:59PM -0400, Cole Robinson wrote:
> Handles freeing the buffer and fds, but not the message details.
> Use it to drop some duplicate code.
> ---
ACK
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Thu, May 05, 2016 at 05:41:45PM +0100, Daniel P. Berrange wrote:
> On Thu, May 05, 2016 at 12:39:24PM -0400, Cole Robinson wrote:
> > On 05/05/2016 12:20 PM, Pavel Hrdina wrote:
> > > This config option is broken, it will generate unix socket even if
> > > attribute 'listen' or listen element is
Signed-off-by: Jiri Denemark
---
.../domaincaps-qemu_2.6.0-1.xml| 63
.../domaincaps-qemu_2.6.0-2.xml| 63
.../domaincaps-qemu_2.6.0-3.xml| 67 ++
.../domaincaps-qemu_2.6.0-4.
We will need to use the formatter directly for testing QEMU capabilities
code.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_capabilities.c | 32 ++--
1 file changed, 22 insertions(+), 10 deletions(-)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabil
Signed-off-by: Jiri Denemark
---
.../qemucapabilitiesdata/caps_1.2.2-1.x86_64.caps | 234 ++---
.../qemucapabilitiesdata/caps_1.3.1-1.x86_64.caps | 266 +++
.../qemucapabilitiesdata/caps_1.4.2-1.x86_64.caps | 268 +++
.../qemucapabilitiesdata/caps_1.5.3-1.x86_64
Enhance the test to cover all capabilities we probe for rather than
testing the flags only.
Signed-off-by: Jiri Denemark
---
.../domaincaps-qemu_1.6.50-1.xml | 1 +
.../qemucapabilitiesdata/caps_1.2.2-1.x86_64.caps | 42 ++
.../qemucapabilitiesdata/caps_1.3.1-1.x8
Signed-off-by: Jiri Denemark
---
tests/domaincapstest.c | 2 +-
.../{caps_1.2.2-1.x86_64.caps => caps_1.2.2-1.x86_64.xml} | 0
.../{caps_1.3.1-1.x86_64.caps => caps_1.3.1-1.x86_64.xml} | 0
.../{caps_1.4.2-1.x86_64.caps
In other tests we use "expected" and "actual" to refer to the expected
outcome of the tested API and the result we got, respectively.
Signed-off-by: Jiri Denemark
---
tests/qemucapabilitiestest.c | 31 ---
1 file changed, 16 insertions(+), 15 deletions(-)
diff --git
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_capabilities.c | 4 ++--
src/qemu/qemu_capspriv.h | 9 +
2 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 862aed0..b6d1f5e 100644
--- a/src/qemu/qemu_capabil
Jiri Denemark (12):
tests: Refactor domaincapstest
qemucapabilitiestest: Prepare for testing non-x86_64 archs
qemu: Separate formatting from saving into caps cache
qemu: Export caps cache APIs for tests
qemucapabilitiestest: Uses consistent names
qemucapabilitiestest: Reindent *.caps fi
Signed-off-by: Jiri Denemark
---
tests/domaincapsschemadata/domaincaps-qemu_1.6.50-1.xml | 2 +-
tests/domaincapstest.c | 17 ++---
2 files changed, 15 insertions(+), 4 deletions(-)
diff --git a/tests/domaincapsschemadata/domaincaps-qemu_1.6.50-1.xml
Signed-off-by: Jiri Denemark
---
tests/domaincapstest.c | 8 +++--
...{caps_1.2.2-1.caps => caps_1.2.2-1.x86_64.caps} | 0
...1.2.2-1.replies => caps_1.2.2-1.x86_64.replies} | 0
...{caps_1.3.1-1.caps => caps_1.3.1-1.x86_64.caps} | 0
...1.3.1-1.replies => caps_1.3
The test was just a big mess passing callbacks and their data through
data for another callback.
Signed-off-by: Jiri Denemark
---
tests/domaincapstest.c | 176 ++---
1 file changed, 93 insertions(+), 83 deletions(-)
diff --git a/tests/domaincapstest.c
The flags should follow the order in which they are defined in
virQEMUCaps enum.
Signed-off-by: Jiri Denemark
---
tests/qemucapabilitiesdata/caps_1.5.3-1.x86_64.caps | 2 +-
tests/qemucapabilitiesdata/caps_1.6.0-1.x86_64.caps | 2 +-
tests/qemucapabilitiesdata/caps_1.6.50-1.x86_64.caps | 2 +-
On Thu, May 05, 2016 at 12:39:24PM -0400, Cole Robinson wrote:
> On 05/05/2016 12:20 PM, Pavel Hrdina wrote:
> > This config option is broken, it will generate unix socket even if
> > attribute 'listen' or listen element is specified.
> >
> > Also following commit will makes this option obsolete.
SRIOV VFs used in macvtap passthrough mode can take advantage of the
SRIOV card's transparent vlan tagging. All the code was there to set
the vlan tag, and it has been used for SRIOV VFs used for hostdev
interfaces for several years, but for some reason, the vlan tag for
macvtap passthrough devices
On 05/05/2016 12:20 PM, Pavel Hrdina wrote:
> This config option is broken, it will generate unix socket even if
> attribute 'listen' or listen element is specified.
>
> Also following commit will makes this option obsolete.
>
> Signed-off-by: Pavel Hrdina
IMO this is not acceptable. For one, t
We support omitting listen attribute of graphics element so we should
also support omitting address attribute of listen element. This patch
also updates libvirt to always add a listen element into domain XML
except for VNC graphics if socket attribute is specified.
Signed-off-by: Pavel Hrdina
--
This new listen type is currently supported only by spice graphics.
It's introduced to make it easier and clearer specify to not listen
anywhere in order to start a guest with OpenGL support.
The old way to do this was set spice graphics autoport='no' and don't
specify any ports. The new way is t
We cannot change ports for running domain and we should error out if
autoport is enabled.
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_hotplug.c | 13 +
.../qemuhotplug-graphics-spice-listen-network.xml | 2 +-
2 files changed, 6 insert
Introduce a new listen type that will be used to tell a graphics device
to listen on unix socket and use it for VNC graphics instead of socket
attribute. The socket attribute will remain in the XML for backward
compatibility.
Since old libvirt supports 'socket' attribute inside 'graphics' element
If socket attribute is present we start VNC that listens only on that
unix socket. This makes the parser behave the same way as we actually
use the socket attribute.
Signed-off-by: Pavel Hrdina
---
src/conf/domain_conf.c| 8
.../genericxml2xm
This config option is broken, it will generate unix socket even if
attribute 'listen' or listen element is specified.
Also following commit will makes this option obsolete.
Signed-off-by: Pavel Hrdina
---
src/qemu/libvirtd_qemu.aug | 1 -
src/qemu/qemu.conf
Signed-off-by: Pavel Hrdina
---
docs/formatdomain.html.in | 2 +-
src/conf/domain_conf.c | 33 +++--
src/qemu/qemu_command.c| 134 +++--
src/qemu/qemu_migration.c | 41 +++
Move the compatibility code out of virDomainGraphicsListensParseXML()
into virDomainGraphicsListenDefParseXML(). This also fixes a small
inconsistency between the code and error message itself.
Before this patch we would search first listen element that is
type='address' to validate listen and ad
Signed-off-by: Pavel Hrdina
---
src/conf/domain_conf.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 9dae85d..72ab2d7 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -10707,10 +10707,9 @@
virDoma
This patch series improves the way how different listen types can be specified
and also introduce a new listen types for graphics devices.
First improvement is to move ports auto of graphics element into listen element
with type address or network. This is a first step to make the code
listen-dri
Signed-off-by: Pavel Hrdina
---
src/conf/domain_conf.c | 2 ++
src/conf/domain_conf.h | 14 +++---
src/libxl/libxl_conf.c | 8
src/qemu/qemu_command.c | 14 +-
4 files changed, 30 insertions(+), 8 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domai
Add a new capability to detect support of unix sockets for spice
graphics.
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
2 files changed, 3 insertions(+)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index c2b
Signed-off-by: Pavel Hrdina
---
.../generic-graphics-vnc-listen-attr-only.xml | 28
...generic-graphics-vnc-listen-element-minimal.xml | 30 ++
...ic-graphics-vnc-listen-element-with-address.xml | 30 ++
.../generic-graphics-vnc-ma
Move adding the config listen type=address if there is none in
qemuProcessPrepareDomain and move check for multiple listens to
qemuProcessStartValidate.
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_process.c | 75 -
1 file changed, 55 insertions(+
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_driver.c | 12
src/qemu/qemu_process.c | 13 +
tests/qemuxml2argvdata/qemuxml2argv-controller-order.args | 2 +-
tests/qemuxml2argvdata/qemuxml2argv-h
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_hotplug.c | 33 +
1 file changed, 17 insertions(+), 16 deletions(-)
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index 03e5309..97f4152 100644
--- a/src/qemu/qemu_hotplug.c
+++ b/src/qemu/qemu_hotplug
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_driver.c | 6 +++---
src/qemu/qemu_process.c | 29 -
src/qemu/qemu_process.h | 3 +++
3 files changed, 30 insertions(+), 8 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 3d0c7c8..396e64c
On Thu, May 05, 2016 at 09:51:22AM -0600, Eric Blake wrote:
> On 05/05/2016 09:32 AM, Daniel P. Berrange wrote:
> > On Thu, Apr 28, 2016 at 12:05:12PM +0200, Michal Privoznik wrote:
> >> This is kind of a hacky approach to the following problem, but so
> >> far I am unable to come up with anything
On Thu, Apr 28, 2016 at 12:04:47PM +0200, Michal Privoznik wrote:
> So, after couple of sleepless nights and headaches I'm proud to
> announce that finally got this working.
>
>
> What?
> Our regular streams that are can be used to transfer disk images
> for domains are unaware of any sparseness.
On 04.05.2016 13:50, Roman Bogorodskiy wrote:
> Hi,
>
> I'd like to introduce Fabian Freyer (CCed), he's taking part in Google
> Support of Code this year within FreeBSD organization and his project is
> called "Improving libvirt support for bhyve".
Hey, that's awesome! I wasn't aware that somebo
Fron c3bd0019c0e on instead of creating the following path for
cgroups:
/sys/fs/cgroupX/$name.libvirt-$driver
we generate rather more verbose one:
/sys/fs/cgroupX/$driver-$id-$name.libvirt-$driver
where $name is optional and included iff contains allowed chars.
See original commit for more
On 05/05/2016 09:32 AM, Daniel P. Berrange wrote:
> On Thu, Apr 28, 2016 at 12:05:12PM +0200, Michal Privoznik wrote:
>> This is kind of a hacky approach to the following problem, but so
>> far I am unable to come up with anything better. On some
>> occasions (esp. when dealing with regular files)
On Thu, Apr 28, 2016 at 12:05:12PM +0200, Michal Privoznik wrote:
> This is kind of a hacky approach to the following problem, but so
> far I am unable to come up with anything better. On some
> occasions (esp. when dealing with regular files) libvirt_iohelper
> is spawned to prefetch data for us.
>> qemuBuildiSCSICommandLine: (private)
>> Required for iSCSI since qemu only processes the "user=" and
>> "password-secret=" options for an "-iscsi" entry. At some point
>> in a future release, qemu may support those options on the -drive
>> command line for iscsi devices. The
On 04/28/2016 04:04 AM, Michal Privoznik wrote:
> Even though there's no way how to make stream seekable right now,
s/how //
> it is going to be soon. We need to track this info so that we
> don't send virStreamSkip to a client that did not want it or vice
> versa.
>
> Signed-off-by: Michal Priv
On 05/05/2016 08:37 AM, Eric Blake wrote:
>> /**
>> + * virStreamSkip:
>> + * @stream: pointer to the stream object
>> + * @offset: number of bytes to skip
>> + *
>> + * Skip @offset bytes in the stream. This is useful when there's
>> + * no actual data in the stream, just a hole. If that's the c
On 04/28/2016 04:04 AM, Michal Privoznik wrote:
> This has no real added value right now,
> but is going to be very helpful later.
>
> Signed-off-by: Michal Privoznik
> ---
> src/remote/remote_driver.c | 6 --
> src/rpc/gendispatch.pl | 2 +-
> src/rpc/virnetclientstream.c | 6 +-
On 04/28/2016 06:04 AM, Michal Privoznik wrote:
> So, after couple of sleepless nights and headaches I'm proud to
> announce that finally got this working.
>
>
> What?
> Our regular streams that are can be used to transfer disk images
> for domains are unaware of any sparseness. Therefore they
On 04/28/2016 04:04 AM, Michal Privoznik wrote:
> These functions will be called to determine whether underlying
s/whether/whether the/
> file that stream is transferring is currently in a data or hole.
s/stream/the stream/
>
> While virStreamRegisterInData is exposed, virStreamInData does
> n
On 04/28/2016 04:04 AM, Michal Privoznik wrote:
> The former is a public API and registers a callback that
> will be called whenever the other side of a stream calls
> virStreamSkip. The latter is a wrapper that actually calls
> the callback. It is not made public as it is intended to be
> used pur
On 04/28/2016 04:04 AM, Michal Privoznik wrote:
> This API can be used to tell the other side of the stream to skip
> some bytes in the stream. This can be used to create a sparse
> file on the receiving side of a stream.
>
> It takes just one argument @offset, which says how big the hole
> is. Si
Forwarding to devel-list.
Julio Cesar Faracco
-- Forwarded message --
From: Julio Faracco
Date: 2016-05-04 12:37 GMT-03:00
Subject: Dump network traffic from each VM.
To: libvirt-us...@redhat.com
Hi guys,
Does anybody know how to dump the network trafic from each virtual
mach
On 05/05/16 14:13, Peter Krempa wrote:
> On Thu, May 05, 2016 at 13:49:24 +0200, Erik Skultety wrote:
>> Unlike the previous commit, we do actually support one client-side only flag
>> VIR_CONNECT_NO_ALIASES, so besides removing the check for flags this flag
>> has to be masked out before sending a
On Thu, May 05, 2016 at 13:49:24 +0200, Erik Skultety wrote:
> Unlike the previous commit, we do actually support one client-side only flag
> VIR_CONNECT_NO_ALIASES, so besides removing the check for flags this flag
> has to be masked out before sending a message to the daemon, otherwise it
> would
Flags checking should be done solely on the daemon side and therefore such
checks need to be removed from public APIs.
Erik Skultety (2):
admin: Remove flags checking from public API entry points
admin: Remove flags checking from virAdmConnectOpen public API
src/admin/admin_remote.c | 2 +-
Due to compatibility reasons these should be checked on the server side.
Signed-off-by: Erik Skultety
---
src/libvirt-admin.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/src/libvirt-admin.c b/src/libvirt-admin.c
index 4ad816b..d7a66ff 100644
--- a/src/libvirt-admin.c
+++ b/src/libvir
Unlike the previous commit, we do actually support one client-side only flag
VIR_CONNECT_NO_ALIASES, so besides removing the check for flags this flag
has to be masked out before sending a message to the daemon, otherwise it
would trigger an error when checking flags on the daemon side.
Signed-off
On Thu, May 05, 2016 at 01:11:45PM +0200, Michal Privoznik wrote:
> On 04.05.2016 18:17, Daniel P. Berrange wrote:
> > Both RHEL and Fedora build with the storage driver and
> > most of its sub-drivers enabled at all times.
> >
> > Signed-off-by: Daniel P. Berrange
> > ---
> > libvirt.spec.in |
On 04.05.2016 18:17, Daniel P. Berrange wrote:
> Both RHEL and Fedora build with the storage driver and
> most of its sub-drivers enabled at all times.
>
> Signed-off-by: Daniel P. Berrange
> ---
> libvirt.spec.in | 86
> +
> 1 file change
On 04.05.2016 18:17, Daniel P. Berrange wrote:
> Cole previously suggested that we should simplify the
> RPM spec by removing conditionals that we never need
> to toggle for RHEL / Fedora builds, rather than having
> conditionals for every single feature that exists.
>
> This series does just that
On 05/05/16 12:26, Michal Privoznik wrote:
> On 05.05.2016 11:05, Erik Skultety wrote:
>> On 05/05/16 09:30, Michal Privoznik wrote:
>>> I've noticed this while trying to compile libvirt on my arm box.
>>>
>>> CC rpc/libvirt_net_rpc_server_la-virnetserverclient.lo
>>> rpc/virnetserverclient
[...]
>> diff --git a/configure.ac b/configure.ac
>> index 88e2e20..3cabd5e 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -1264,6 +1264,7 @@ if test "x$with_gnutls" != "xno"; then
>>]])
>>
>>AC_CHECK_FUNCS([gnutls_rnd])
>> + AC_CHECK_FUNCS([gnutls_cipher_encrypt])
>
> This c
On Thu, May 05, 2016 at 12:22:02PM +0200, Michal Privoznik wrote:
> On 05.05.2016 10:48, Erik Skultety wrote:
> >>> +
> >>> +/**
> >>> + * virAdmClientClose:
> >>> + * @client: a valid client object reference
> >>> + * @flags: extra flags; not used yet, so callers should always pass 0
> >>> + *
> >
On 05.05.2016 11:05, Erik Skultety wrote:
> On 05/05/16 09:30, Michal Privoznik wrote:
>> I've noticed this while trying to compile libvirt on my arm box.
>>
>> CC rpc/libvirt_net_rpc_server_la-virnetserverclient.lo
>> rpc/virnetserverclient.c: In function 'virNetServerClientNewPostExecRest
On 05.05.2016 10:48, Erik Skultety wrote:
>>> +
>>> +/**
>>> + * virAdmClientClose:
>>> + * @client: a valid client object reference
>>> + * @flags: extra flags; not used yet, so callers should always pass 0
>>> + *
>>> + * Close @client's connection to daemon forcefully.
>>> + *
>>> + * Returns 0
On Thu, 2016-05-05 at 11:00 +0200, Peter Krempa wrote:
> >
> > But if we don't change 'virsh maxvcpus --type kvm' to report
> > the computed limit, instead of just the KVM limit as it does
> > now, the problem reported by Shivaprasad will still exist...
>
> I think that should be fixed by documen
On Mon, May 02, 2016 at 05:51:15PM -0400, John Ferlan wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1182074
>
> If they're available and we need to pass secrets to qemu, then use the
> qemu domain secret object in order to pass the secrets for iSCSI and
> RBD volumes instead of passing plai
On Mon, May 02, 2016 at 05:51:14PM -0400, John Ferlan wrote:
> New APIs:
>
> qemuDomainGetIVKeyAlias:
> Generate/return the secret object alias for an initialization
> vector (IV) secret info type. This will be saved in the secret
> info block. This will be called from qemuDomainSecr
On Mon, May 02, 2016 at 05:51:13PM -0400, John Ferlan wrote:
> Add the data structure and infrastructure to support an initialization
> vector (IV) secrets. The IV secret generation will need to have access
> to the domain private master key, so let's make sure the prepare disk
> and hostdev functi
On Mon, May 02, 2016 at 05:51:12PM -0400, John Ferlan wrote:
> Create helper API's in order to build the network URI as shortly we will
> be adding a new SecretInfo type
>
> Signed-off-by: John Ferlan
> ---
> src/qemu/qemu_command.c | 90
> +
> 1
On Mon, May 02, 2016 at 05:51:11PM -0400, John Ferlan wrote:
> Rather than need to call qemuDomainSecretDestroy after any call to
> qemuProcessLaunch, let's do the destroy in qemuProcessLaunch since
> that's where command line is eventually generated and processed. Once
> it's generated, we can cle
On Mon, May 02, 2016 at 05:51:10PM -0400, John Ferlan wrote:
> Commit id '40d8e2ba3' added the function to qemuProcessStart because
> in order to set up some secrets in the future we will need the master
> key. However, since the previous patch split the master key creation
> into two parts (create
On Mon, May 02, 2016 at 05:51:08PM -0400, John Ferlan wrote:
> >From a review after push, add the "_TYPE" into the name.
>
> Also use qemuDomainSecretInfoType in the struct rather than int
> with the comment field containing the struct name
>
> Signed-off-by: John Ferlan
> ---
> src/qemu/qemu_d
On Mon, May 02, 2016 at 05:51:09PM -0400, John Ferlan wrote:
> A recent review of related changes noted that we should split the creation
> (or generation) of the master key into the qemuProcessPrepareDomain and leave
> the writing of the master key for qemuProcessPrepareHost.
>
> Made the adjustm
On 05/05/16 09:30, Michal Privoznik wrote:
> I've noticed this while trying to compile libvirt on my arm box.
>
> CC rpc/libvirt_net_rpc_server_la-virnetserverclient.lo
> rpc/virnetserverclient.c: In function 'virNetServerClientNewPostExecRestart':
> rpc/virnetserverclient.c:516:45: error:
On 05/05/16 09:30, Michal Privoznik wrote:
> In this function, @id is defined as unsigned long long. When
> passing this variable to virJSONValueObjectGetNumberUlong(),
> well address of this variable, it's typecasted to ull*. There
> is no need for that. It's a same story with @nrequests_max.
>
>
On Thu, May 05, 2016 at 10:39:56 +0200, Andrea Bolognani wrote:
> On Thu, 2016-05-05 at 10:00 +0200, Jiri Denemark wrote:
> > >
> > > I guess we could skip all the details and just give the user
> > >
> > >
> > >
> > > so they don't have to implement the logic themselves. But
> > > reporting
>> +
>> +/**
>> + * virAdmClientClose:
>> + * @client: a valid client object reference
>> + * @flags: extra flags; not used yet, so callers should always pass 0
>> + *
>> + * Close @client's connection to daemon forcefully.
>> + *
>> + * Returns 0 if the daemon's connection with @client was closed
On Thu, 2016-05-05 at 10:00 +0200, Jiri Denemark wrote:
> >
> > I guess we could skip all the details and just give the user
> >
> >
> >
> > so they don't have to implement the logic themselves. But
> > reporting the KVM limits without taking QEMU limits into
> > consideration is not the way
Signed-off-by: Jiri Denemark
---
Pushed as trivial. I forgot to squash this into the patch which adds
qemucapsprobe :(
.gitignore | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/.gitignore b/.gitignore
index ba537d8..fc21bad 100644
--- a/.gitignore
+++ b/.gitignore
@@ -159
On Thu, May 05, 2016 at 09:11:54 +0200, Peter Krempa wrote:
> On Wed, May 04, 2016 at 17:09:51 +0200, Jiri Denemark wrote:
> > json_reformat uses two spaces for when indenting nested objects, let's
> > do the same. The result of virJSONValueToString will be exactly the same
> > as json_reformat wou
On Thu, May 05, 2016 at 09:34:21 +0200, Andrea Bolognani wrote:
> On Thu, 2016-05-05 at 08:52 +0200, Jiri Denemark wrote:
> > On Wed, May 04, 2016 at 19:27:41 +0200, Andrea Bolognani wrote:
> > >
> > > How about something like
> > >
> > >
> > >
> > > 96
> > > 2048
> > >
>
On Thu, 2016-05-05 at 08:52 +0200, Jiri Denemark wrote:
> On Wed, May 04, 2016 at 19:27:41 +0200, Andrea Bolognani wrote:
> >
> > How about something like
> >
> >
> >
> > 96
> > 2048
> >
> >
> > 255
> >
> >
>
> No, domcapabilities are bound to an arch/
Roman Bogorodskiy wrote:
> Move all the UML driver related routines into m4/virt-driver-uml.m4.
> ---
> configure.ac | 28 ++--
> m4/virt-driver-uml.m4 | 47 +++
> 2 files changed, 49 insertions(+), 26 deletions(-)
>
In this function, @id is defined as unsigned long long. When
passing this variable to virJSONValueObjectGetNumberUlong(),
well address of this variable, it's typecasted to ull*. There
is no need for that. It's a same story with @nrequests_max.
Signed-off-by: Michal Privoznik
---
src/rpc/virnetse
I've noticed this while trying to compile libvirt on my arm box.
CC rpc/libvirt_net_rpc_server_la-virnetserverclient.lo
rpc/virnetserverclient.c: In function 'virNetServerClientNewPostExecRestart':
rpc/virnetserverclient.c:516:45: error: cast increases required alignment of
target type [-
*** BLURB HERE ***
Michal Privoznik (2):
virNetServerClientNewPostExecRestart: Drop useless typecasts
virNetServerClientNewPostExecRestart: Avoid align problems
src/rpc/virnetserverclient.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
--
2.8.1
--
libvir-list mailing li
---
m4/virt-driver-uml.m4 | 8
1 file changed, 8 insertions(+)
diff --git a/m4/virt-driver-uml.m4 b/m4/virt-driver-uml.m4
index 4132315..d6bbdc1 100644
--- a/m4/virt-driver-uml.m4
+++ b/m4/virt-driver-uml.m4
@@ -23,6 +23,14 @@ AC_DEFUN([LIBVIRT_DRIVER_CHECK_UML],[
[add UML suppo
Move all the UML driver related routines into m4/virt-driver-uml.m4.
---
configure.ac | 28 ++--
m4/virt-driver-uml.m4 | 47 +++
2 files changed, 49 insertions(+), 26 deletions(-)
create mode 100644 m4/virt-driver-uml.m4
On Wed, May 04, 2016 at 17:09:52 +0200, Jiri Denemark wrote:
> Adding new *.replies files for qemucapabilitiestest or updating the
> files when libvirt adds an additional QMP command into the probing
> process is quite painful. The goal of the new qemucapsprobe command is
> to make this process as
On Wed, May 04, 2016 at 17:09:51 +0200, Jiri Denemark wrote:
> json_reformat uses two spaces for when indenting nested objects, let's
> do the same. The result of virJSONValueToString will be exactly the same
> as json_reformat would produce.
>
> Signed-off-by: Jiri Denemark
> ---
I guess it's g
98 matches
Mail list logo