Re: [libvirt] [PATCH] libxl: fix vm lock overwritten bug

On 05/10/2016 12:18 AM, Wang Yufei wrote: > In libxl driver we do virObjectRef in libxlDomainObjBeginJob, > If virCondWaitUntil failed, it goes to error, do virObjectUnref, > There's a chance that someone undefine the vm at the same time, > and refs unref to zero, vm is freed in

[libvirt] [PATCH] libxl: fix default vram setting for implicit video device

Commit 6879be48 moved adding of an implicit video device after XML parsing. As a result, libxlDomainDeviceDefPostParse() is no longer called to set the default vram when adding an implicit device. Commit 6879be48 assumes virDomainVideoDefaultRAM() will set the default vram, but it returns 0 if the

Re: [libvirt] [PATCH 3/5] domaincaps: Report graphics spiceGL

On 05/10/2016 11:50 AM, Daniel P. Berrange wrote: > On Tue, May 10, 2016 at 11:26:29AM -0400, Cole Robinson wrote: >> On 05/10/2016 05:10 AM, Daniel P. Berrange wrote: >>> On Mon, May 09, 2016 at 06:53:01PM -0400, Cole Robinson wrote: On 05/09/2016 09:48 AM, Daniel P. Berrange wrote: >>> >>>

Re: [libvirt] [PATCH] headers: Remove unnecessary keyword extern from function declaration

On 05/10/2016 09:49 AM, Erik Skultety wrote: > Usage of this keyword in front of function declaration that is exported via a > header file is unnecessary, since internally, this has been the default for > most > compilers for quite some time. > > Signed-off-by: Erik Skultety

Re: [libvirt] [PATCH 3/4] tests: Prepare to have different usable GIC versions

On 05/10/2016 08:46 AM, Andrea Bolognani wrote: > Now that we choose the GIC version based on hardware features when > no element has been provided, we need a way to fake the GIC > capabilities of the host. > > Update the qemuxml2argv and qemuxml2xml tests to allow this. > --- >

Re: [libvirt] [PATCH 1/4] qemu: Automatically choose usable GIC version

On 05/10/2016 08:46 AM, Andrea Bolognani wrote: > When the element in not present in the domain XML, use the > domain capabilities to figure out what GIC version is usable and > choose that one automatically. > > This allows guests to be created on hardware that only supports > GIC v3 without

Re: [libvirt] [PATCH 2/2] Use virGetLastErrorMessage()

On 05/10/2016 08:16 AM, Jovanka Gulicoska wrote: > virGetLastErrorMessage() in daemon, examples,bhyve, lxc, > logging, locking, libvirt, libxl, lxc, rpc, storage, > uml, and util. > > Fix syntax error in tests. Patches should be individually clean, so the test fixup should have been squashed

Re: [libvirt] [PATCH 1/2] tests: use virGetLastErrorMessage()

On 05/10/2016 08:16 AM, Jovanka Gulicoska wrote: > --- > tests/commandtest.c | 81 > ++-- > tests/libvirtdconftest.c | 26 ++--- > tests/openvzutilstest.c | 7 +--- > tests/securityselinuxlabeltest.c | 6 +-- >

[libvirt] Error in `virsh': corrupted double-linked list while running virsh domstate

Hello all, We've been using libvirt for years and it works great, however we just hit a bug. This is running libvirt-1.2.17-13.el7_2.4, however strangely, we had the same backtrace on a complete difference system in a different data center using version libvirt-1.2.17-13.el7_2.3. Both traces

Re: [libvirt] [PATCH 0/2] *** use virGetLastErrorMessage ***

On 05/10/2016 08:16 AM, Jovanka Gulicoska wrote: > *** BLURB HERE *** > > Jovanka Gulicoska (2): > tests: use virGetLastErrorMessage() > Use virGetLastErrorMessage() Like Erik pointed out, you missed the blurb, and the subject shouldn't contain ***. Look to the list traffic for examples of

Re: [libvirt] [RFC PATCH 0/2] nodeinfo: PPC64: Fix topology and siblings info on capabilities and nodeinfo

On 05/05/2016 02:48 PM, Andrea Bolognani wrote: > On Fri, 2016-01-29 at 01:32 -0500, Shivaprasad G Bhat wrote: >> The nodeinfo output was fixed earlier to reflect the actual cpus available in >> KVM mode on PPC64. The earlier fixes covered the aspect of not making a host >> look overcommitted when

Re: [libvirt] libvirt should not disable auto_login of iscsi-targets that are *not* used by libvirt

On 05/01/2016 01:10 PM, Fritz Elfert wrote: > Hi, Cole Robinson asked me to post the attached patch here. > For more info, see https://bugzilla.redhat.com/show_bug.cgi?id=1331552 > > Cheers > -Fritz > > > > -- > libvir-list mailing list > libvir-list@redhat.com >

[libvirt] adding a new libvirt xml element for File Descriptor backed memory for use with vhost-user

Hi I work mostly in OpenStack on enabling ovs with dpdk. When deploying vms on host running ovs with dpdk vms are booted utilizing Vhost-user interfaces. Qemu support creating vms with vhost-user network interfaces as of v2.1. Libvirt currently has support for requesting the use of vhost-user

Re: [libvirt] [PATCH 1/2] xenFormatNet: correct `type=netfront' to 'type=vif' to match libxl

On 04/21/2016 12:10 PM, Chunyan Liu wrote: > According to current xl.cfg docs and xl codes, it uses type=vif > instead of type=netfront. > > Currently after domxml-to-native, libvirt xml model=netfront will be > converted to xl type=netfront. This has no problem before, xen codes > for a long

Re: [libvirt] [PATCH 0/2] correct libxl config file convert

On 04/21/2016 12:10 PM, Chunyan Liu wrote: > Correct libxl config file type=vif handling. > FWIW, Tested-by: Joao Martins Just detected tiny nitpicks in patch 1, but overall looks good. BTW in testing this I found out a bug in domxml-to-native with xen-xm, so will

Re: [libvirt] [PATCH 0/3] libxl: support Xen migration stream V2

Ján Tomko wrote: > On Mon, May 02, 2016 at 07:01:16PM -0600, Jim Fehlig wrote: >> Hi all, >> >> This patch adds support for Xen migration stream V2 to the libvirt >> libxl driver. In the process it fixes save/restore and migration >> tests in OSSTest, which have been failing since libvirt commit

[libvirt] [PATCH] docs: Fix disk "volume" description

Missing a close single quote and a 'be' before used. Signed-off-by: John Ferlan --- Pushed as trivial. docs/formatdomain.html.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index

Re: [libvirt] [PATCH] qemu: Add extra checks for secret destroy API's

On 05/10/2016 02:52 PM, John Ferlan wrote: Remove the possibility that a NULL hostdev->privateData or a disk->privateData could crash libvirtd by checking for NULL before dereferencing for the secinfo structure in the qemuDomainSecret{Disk|Hostdev}Destroy functions. The hostdevPriv could be NULL

[libvirt] [PATCH] qemu: Add extra checks for secret destroy API's

Remove the possibility that a NULL hostdev->privateData or a disk->privateData could crash libvirtd by checking for NULL before dereferencing for the secinfo structure in the qemuDomainSecret{Disk|Hostdev}Destroy functions. The hostdevPriv could be NULL if qemuProcessNetworkPrepareDevices adds a

Re: [libvirt] [PATCH] util: set vlan tag for macvtap passthrough mode on SRIOV VFs

On 05/06/2016 03:26 PM, John Ferlan wrote: On 05/05/2016 12:39 PM, Laine Stump wrote: SRIOV VFs used in macvtap passthrough mode can take advantage of the SRIOV card's transparent vlan tagging. All the code was there to set the vlan tag, and it has been used for SRIOV VFs used for hostdev

[libvirt] [PATCH sandbox] pkgconfig: remove non-existent requirement on 'sandbox-2.0'

From: Gary Tierney $ pkg-config --cflags libvirt-sandbox-1.0 Package sandbox-2.0 was not found in the pkg-config search path. Perhaps you should add the directory containing `sandbox-2.0.pc' to the PKG_CONFIG_PATH environment variable Package 'sandbox-2.0', required by

Re: [libvirt] NFS over AF_VSOCK in

On Tue, May 10, 2016 at 13:04:20 +0100, Stefan Hajnoczi wrote: > On Tue, May 10, 2016 at 08:26:30AM +0200, Jiri Denemark wrote: > > On Mon, May 09, 2016 at 16:57:17 +0100, Stefan Hajnoczi wrote: > > > virtio-vsock support has been added to the nfs-ganesha NFS server. I'm > > > currently working

Re: [libvirt] [Qemu-devel] [PATCH 8/9] target-i386: Use "-" instead of "_" on all feature names

On Tue, May 10, 2016 at 17:19:51 +0200, Igor Mammedov wrote: > On Fri, 6 May 2016 15:11:31 -0300 > Eduardo Habkost wrote: > > > This makes the feature name tables in feature_word_info all match > > the actual QOM property names we use. > > > > This will make the

[libvirt] [PATCH v2] storage: Fix regression cloning volume into a logical pool

https://bugzilla.redhat.com/show_bug.cgi?id=1318993 Commit id 'dd519a294' caused a regression cloning a volume into a logical pool by removing just the 'allocation' adjustment during storageVolCreateXMLFrom. Combined with the change to not require the new volume input XML to have a capacity

Re: [libvirt] [PATCH 0/2] *** use virGetLastErrorMessage ***

On 05/10/2016 11:44 AM, Erik Skultety wrote: > On 10/05/16 14:16, Jovanka Gulicoska wrote: >> *** BLURB HERE *** >> > > Hi, thank you for patches :), just a small advice to the future, we tend > to write a couple of words/sentences, instead of the "BLURB HERE", what > the series actually does.

Re: [libvirt] [PATCH 8/8] Revert "conf: Validate disk lun using correct types"

On 05/10/2016 07:15 AM, John Ferlan wrote: > > > On 05/10/2016 03:30 AM, Ján Tomko wrote: >> On Mon, May 09, 2016 at 11:57:20AM -0400, Cole Robinson wrote: >>> On 05/09/2016 04:59 AM, Peter Krempa wrote: On Fri, May 06, 2016 at 11:19:05 -0400, John Ferlan wrote: > > > On

Re: [libvirt] [PATCH 8/8] Revert "conf: Validate disk lun using correct types"

On 05/10/2016 03:30 AM, Ján Tomko wrote: > On Mon, May 09, 2016 at 11:57:20AM -0400, Cole Robinson wrote: >> On 05/09/2016 04:59 AM, Peter Krempa wrote: >>> On Fri, May 06, 2016 at 11:19:05 -0400, John Ferlan wrote: > --- > src/conf/domain_conf.c | 22 -- >

Re: [libvirt] [PATCH] qemu.conf: spaces correction

On Tue, 2016-05-10 at 17:23 +0200, Ján Tomko wrote: > On Mon, May 09, 2016 at 02:21:53PM +0200, poma wrote: > > > > > > libvirt/qemu.conf: spaces correction > > > > --- > >  src/qemu/qemu.conf | 42 +- > >  1 file changed, 21 insertions(+), 21 deletions(-)

Re: [libvirt] [PATCH] qemu.conf: spaces correction

On Tue, May 10, 2016 at 11:58:59AM -0400, Cole Robinson wrote: > On 05/10/2016 11:56 AM, Michal Privoznik wrote: > > On 10.05.2016 17:23, Ján Tomko wrote: > >> On Mon, May 09, 2016 at 02:21:53PM +0200, poma wrote: > >>> > >>> libvirt/qemu.conf: spaces correction > >>> > >>> --- > >>>

Re: [libvirt] [PATCH] qemu.conf: spaces correction

On Tue, May 10, 2016 at 05:23:29PM +0200, Ján Tomko wrote: > On Mon, May 09, 2016 at 02:21:53PM +0200, poma wrote: > > > > libvirt/qemu.conf: spaces correction > > > > --- > > src/qemu/qemu.conf | 42 +- > > 1 file changed, 21 insertions(+), 21

Re: [libvirt] [PATCH] qemu.conf: spaces correction

On 05/10/2016 11:56 AM, Michal Privoznik wrote: > On 10.05.2016 17:23, Ján Tomko wrote: >> On Mon, May 09, 2016 at 02:21:53PM +0200, poma wrote: >>> >>> libvirt/qemu.conf: spaces correction >>> >>> --- >>> src/qemu/qemu.conf | 42 +- >>> 1 file changed, 21

Re: [libvirt] [PATCH] qemu.conf: spaces correction

On 10.05.2016 17:23, Ján Tomko wrote: > On Mon, May 09, 2016 at 02:21:53PM +0200, poma wrote: >> >> libvirt/qemu.conf: spaces correction >> >> --- >> src/qemu/qemu.conf | 42 +- >> 1 file changed, 21 insertions(+), 21 deletions(-) >> >> @@ -285,11 +285,11

Re: [libvirt] [PATCH 3/5] domaincaps: Report graphics spiceGL

On Tue, May 10, 2016 at 11:26:29AM -0400, Cole Robinson wrote: > On 05/10/2016 05:10 AM, Daniel P. Berrange wrote: > > On Mon, May 09, 2016 at 06:53:01PM -0400, Cole Robinson wrote: > >> On 05/09/2016 09:48 AM, Daniel P. Berrange wrote: > > > > IMHO it is a total failure if we require the

Re: [libvirt] [PATCH 0/2] *** use virGetLastErrorMessage ***

On 10/05/16 14:16, Jovanka Gulicoska wrote: > *** BLURB HERE *** > Hi, thank you for patches :), just a small advice to the future, we tend to write a couple of words/sentences, instead of the "BLURB HERE", what the series actually does. Also, the subject could be slightly more verbose and the

[libvirt] [PATCH] virt-aa-helper: fix clang build

Clang complains about wrong argument type: libvirt/src/security/virt-aa-helper.c:174:11: error: absolute value function 'abs' given an argument of type 'long' but has parameter of type 'int' which may cause truncation of value [-Werror,-Wabsolute-value] idx = abs(pos - orig);

Re: [libvirt] [PATCH 3/5] domaincaps: Report graphics spiceGL

On 05/10/2016 05:10 AM, Daniel P. Berrange wrote: > On Mon, May 09, 2016 at 06:53:01PM -0400, Cole Robinson wrote: >> On 05/09/2016 09:48 AM, Daniel P. Berrange wrote: > > IMHO it is a total failure if we require the application to extend its > parser every time we add a new enum to the domain

[libvirt] [PATCH v2 1/3] tests: Introduce global mock library

The intent is that this library is going to be called every time to check if we are not touching anything outside srcdir or builddir. Signed-off-by: Michal Privoznik --- cfg.mk| 2 +- tests/Makefile.am | 13 +++- tests/testutils.c | 9 +++

[libvirt] [PATCH v2 3/3] tests: Introduce check-file-access.pl

This script will check output generated by virtestmock against a white list. All non matching records found are printed out. So far, the white list is rather sparse at the moment. This test should be ran only after all other tests finished, and should cleanup the temporary file before their

[libvirt] [PATCH v2 2/3] virtestmock: Print invalid file accesses into a file

All the accesses to files outside our build or source directories are now identified and appended into a file for later processing. The location of the file that contains all the records can be controlled via VIR_TEST_FILE_ACCESS env variable and defaults to abs_builddir "/test_file_access.txt".

[libvirt] [PATCH v2 0/3] Introduce big test mock

v2 of: https://www.redhat.com/archives/libvir-list/2016-April/msg01410.html diff to v1: - I've pushed the first patch of the original series - Rebased onto current master (as Jirka's introduction of qemucapsprobe made my patches not applicable). Michal Privoznik (3): tests: Introduce global

Re: [libvirt] [PATCH] qemu.conf: spaces correction

On Mon, May 09, 2016 at 02:21:53PM +0200, poma wrote: > > libvirt/qemu.conf: spaces correction > > --- > src/qemu/qemu.conf | 42 +- > 1 file changed, 21 insertions(+), 21 deletions(-) > > @@ -285,11 +285,11 @@ > > > # The default format for

Re: [libvirt] [PATCH 3/9] target-i386: Call cpu_exec_init() on realize

On Fri, 6 May 2016 15:11:26 -0300 Eduardo Habkost wrote: > QOM instance_init functions are not supposed to have any side-effects, > as new objects may be created at any moment for querying property > information (see qmp_device_list_properties()). > > Calling

Re: [libvirt] [PATCH 8/9] target-i386: Use "-" instead of "_" on all feature names

On Fri, 6 May 2016 15:11:31 -0300 Eduardo Habkost wrote: > This makes the feature name tables in feature_word_info all match > the actual QOM property names we use. > > This will make the command-line interface more consistent, > allowing the QOM property names to be used

Re: [libvirt] [Qemu-devel] [PATCH 2/9] target-i386: Move TCG initialization to realize time

On Fri, 6 May 2016 15:11:25 -0300 Eduardo Habkost wrote: > QOM instance_init functions are not supposed to have any side-effects, > as new objects may be created at any moment for querying property > information (see qmp_device_list_properties()). > > Move TCG

Re: [libvirt] [PATCH 1/9] target-i386: Move TCG initialization check to tcg_x86_init()

On Fri, 6 May 2016 15:11:24 -0300 Eduardo Habkost wrote: > Instead of requiring cpu.c to check if TCG was already initialized, > simply let the function be called multiple times. > > Suggested-by: Igor Mammedov > Signed-off-by: Eduardo Habkost

Re: [libvirt] [PATCH 0/7] Introduce APIs to get/set client processing controls

On 10/05/16 16:36, Michal Privoznik wrote: > On 10.04.2016 19:56, Erik Skultety wrote: >> > > D'oh! Code has diverged too much to apply these cleanly. Can you please > rebase and resend? > > Michal > I forgot about this series when reposting the other rebased ones :/, I will respin a freshly

Re: [libvirt] [PATCH 0/7] Introduce APIs to get/set client processing controls

On 10.04.2016 19:56, Erik Skultety wrote: > D'oh! Code has diverged too much to apply these cleanly. Can you please rebase and resend? Michal -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH REPOST 0/2] Admin API: Add support for client disconnect

On 05/05/16 07:43, Michal Privoznik wrote: > On 04.05.2016 16:46, Erik Skultety wrote: >> Rebased version of >> https://www.redhat.com/archives/libvir-list/2016-April/msg01987.html >> onto current HEAD to resolve some rebase conflicts. The original patch 1/3 >> was >> dropped, since it has

Re: [libvirt] [PATCH 2/2] admin: Remove flags checking from virAdmConnectOpen public API

On 10/05/16 15:17, Michal Privoznik wrote: > On 05.05.2016 13:49, Erik Skultety wrote: >> Unlike the previous commit, we do actually support one client-side only flag >> VIR_CONNECT_NO_ALIASES, so besides removing the check for flags this flag >> has to be masked out before sending a message to

[libvirt] [PATCH] headers: Remove unnecessary keyword extern from function declaration

Usage of this keyword in front of function declaration that is exported via a header file is unnecessary, since internally, this has been the default for most compilers for quite some time. Signed-off-by: Erik Skultety --- src/conf/capabilities.h | 28

Re: [libvirt] [PATCH] qemu.conf: spaces correction

On 09.05.2016 14:21, poma wrote: > > libvirt/qemu.conf: spaces correction > > --- > src/qemu/qemu.conf | 42 +- > 1 file changed, 21 insertions(+), 21 deletions(-) Okay. But what I'd like you to do is: 1) Explain in commit message why are you doing this

Re: [libvirt] [PATCH 2/1] storage: Merge into 1/1

On Tue, May 10, 2016 at 07:20:09 -0400, John Ferlan wrote: > On 04/29/2016 11:34 AM, John Ferlan wrote: > > As it turns out, trusting that being 0 means it wasn't > > provided isn't such a good idea. > > > > If someone provided a of 10 and of 0, then > > we need to honor it. > > > > So this

[libvirt] [PATCH 1/3] storage: Need to clear pool prior to calling the refreshPool

Prior to calling the 'refreshPool' during CreatePool or UploadPool operations, we need to clear the pool; otherwise, the pool will have duplicated entries. Signed-off-by: John Ferlan --- src/storage/storage_driver.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[libvirt] [PATCH 3/3] storage: Fix virStorageBackendDiskDeleteVol for device mapper

Commit id 'df1011ca8' modified virStorageBackendDiskDeleteVol to use "dmsetup remove --force" to remove the volume, but left things in an inconsistent state since the partition still existed on the disk and only the device mapper device (/dev/dm-#) was removed. Prior to commit '1895b421' (or

[libvirt] [PATCH 2/3] storage: Fix algorithm generating path names for devmapper

https://bugzilla.redhat.com/show_bug.cgi?id=1265694 Commit id '020135dc' didn't quite get the algorithm correct when a device mapper source ended with a non numeric value (e.g. ends with an alphabet value). This patch modifies the 'part_separator' logic to add the "p" separator to the attempted

[libvirt] [PATCH 0/3] Patches for some device mapper multipath issues

Patch 1 just makes sure that prior to calling refreshPool we make sure to clear the objects; otherwise, the refresh code will duplicate. Text within patch 3 seems to indicate that entries were showing up more than once - although those may be bug related. In any case, although perhaps not

Re: [libvirt] [PATCH 8/8] Revert "conf: Validate disk lun using correct types"

On Fri, May 06, 2016 at 11:19:05 -0400, John Ferlan wrote: > > > On 05/02/2016 10:32 AM, Peter Krempa wrote: > > This reverts commit c79ebf53b5fe0a33bf407b3bcb49e3a27ec97eb4. > > > > We can't just add checks to the XML parser once we've accepted such > > configuration in the past. > > --- > >

Re: [libvirt] [PATCH 2/2] admin: Remove flags checking from virAdmConnectOpen public API

On 05.05.2016 13:49, Erik Skultety wrote: > Unlike the previous commit, we do actually support one client-side only flag > VIR_CONNECT_NO_ALIASES, so besides removing the check for flags this flag > has to be masked out before sending a message to the daemon, otherwise it > would trigger an error

Re: [libvirt] [PATCH 1/2] admin: Remove flags checking from public API entry points

On 05.05.2016 13:49, Erik Skultety wrote: > Due to compatibility reasons these should be checked on the server side. > > Signed-off-by: Erik Skultety > --- > src/libvirt-admin.c | 5 - > 1 file changed, 5 deletions(-) > > diff --git a/src/libvirt-admin.c

Re: [libvirt] [PATCH] libxl: fix vm lock overwritten bug

On 10.05.2016 08:18, Wang Yufei wrote: > In libxl driver we do virObjectRef in libxlDomainObjBeginJob, > If virCondWaitUntil failed, it goes to error, do virObjectUnref, > There's a chance that someone undefine the vm at the same time, > and refs unref to zero, vm is freed in

[libvirt] [PATCH 3/4] tests: Prepare to have different usable GIC versions

Now that we choose the GIC version based on hardware features when no element has been provided, we need a way to fake the GIC capabilities of the host. Update the qemuxml2argv and qemuxml2xml tests to allow this. --- tests/qemuxml2argvtest.c | 77 ++-

[libvirt] [PATCH 2/4] qemu: Add virQEMUCapsSetGICCapabilities()

For use in the test suite. --- src/qemu/qemu_capabilities.c | 29 + src/qemu/qemu_capabilities.h | 5 + 2 files changed, 30 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 1bddf43..f0f641d 100644 ---

[libvirt] [PATCH 4/4] tests: Try different usable GIC versions

The only case where the hardware capabilities influence the result is when no element was provided. The test programs now ensure both that the correct GIC version is picked in that case, and that hardware capabilities are not taken into account when the user has already picked a GIC version. ---

[libvirt] [PATCH 1/4] qemu: Automatically choose usable GIC version

When the element in not present in the domain XML, use the domain capabilities to figure out what GIC version is usable and choose that one automatically. This allows guests to be created on hardware that only supports GIC v3 without having to update virt-manager and similar tools. Keep using

[libvirt] [PATCH 0/4] Automatically choose usable GIC version

Currently, if no GIC version has been provided by the user, libvirt will default to GIC v2. This is a problem when trying to create new guests on hardware that only supports GIC v3 guests: QEMU will refuse to start a GIC v2 guest, and guest installation will abort immediately. This series

[libvirt] [PATCH 2/2] Use virGetLastErrorMessage()

virGetLastErrorMessage() in daemon, examples,bhyve, lxc, logging, locking, libvirt, libxl, lxc, rpc, storage, uml, and util. Fix syntax error in tests. --- daemon/libvirtd.c | 8 ++-- examples/object-events/event-test.c | 9 +++-- src/bhyve/bhyve_driver.c|

[libvirt] [PATCH 0/2] *** use virGetLastErrorMessage ***

*** BLURB HERE *** Jovanka Gulicoska (2): tests: use virGetLastErrorMessage() Use virGetLastErrorMessage() -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 1/2] tests: use virGetLastErrorMessage()

--- tests/commandtest.c | 81 ++-- tests/libvirtdconftest.c | 26 ++--- tests/openvzutilstest.c | 7 +--- tests/securityselinuxlabeltest.c | 6 +-- tests/securityselinuxtest.c | 6 +-- tests/virpolkittest.c

Re: [libvirt] NFS over AF_VSOCK in

On Tue, May 10, 2016 at 08:26:30AM +0200, Jiri Denemark wrote: > On Mon, May 09, 2016 at 16:57:17 +0100, Stefan Hajnoczi wrote: > > virtio-vsock support has been added to the nfs-ganesha NFS server. I'm > > currently working on upstreaming virtio-vsock into Linux and QEMU. I > > also have

Re: [libvirt] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions

On Tue, May 10, 2016 at 08:32:53AM +0200, David Hildenbrand wrote: > > > > Yes, I think so. However to really make good hints, upper layers would > > > most > > > likely need more information about the exact problem with a property - > > > maybe something like an enum value per problematic

Re: [libvirt] NFS over AF_VSOCK in

On Mon, May 09, 2016 at 05:18:42PM +0100, Daniel P. Berrange wrote: > On Mon, May 09, 2016 at 04:57:17PM +0100, Stefan Hajnoczi wrote: > > virtio-vsock support has been added to the nfs-ganesha NFS server. I'm > > currently working on upstreaming virtio-vsock into Linux and QEMU. I > > also have

Re: [libvirt] [Qemu-devel] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions

On Tue, May 10, 2016 at 10:23:16AM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Mon, May 09, 2016 at 09:20:15AM -0600, Eric Blake wrote: > >> On 05/06/2016 12:11 PM, Eduardo Habkost wrote: > >> > Extend query-cpu-definitions schema to allow it to return

Re: [libvirt] [PATCH] Introduce Smack security driver for Libvirt

On Thu, Apr 14, 2016 at 07:47:23PM +, Randy Aybar (raybar) wrote: > First time RFC/mailing list/community submission/etc. so please > forgive if not in the appropriate format. Thanks for taking the time to submit this, and sorry for not giving feedback on it sooner. Next time feel free to

Re: [libvirt] [PATCH 2/1] storage: Merge into 1/1

On 04/29/2016 11:34 AM, John Ferlan wrote: > As it turns out, trusting that being 0 means it wasn't > provided isn't such a good idea. > > If someone provided a of 10 and of 0, then > we need to honor it. > > So this patch which I'll merge into the previous patch will track > when the XML

Re: [libvirt] [PATCH 8/8] Revert "conf: Validate disk lun using correct types"

On 05/10/2016 03:30 AM, Ján Tomko wrote: > On Mon, May 09, 2016 at 11:57:20AM -0400, Cole Robinson wrote: >> On 05/09/2016 04:59 AM, Peter Krempa wrote: >>> On Fri, May 06, 2016 at 11:19:05 -0400, John Ferlan wrote: On 05/02/2016 10:32 AM, Peter Krempa wrote: > This reverts

Re: [libvirt] [PATCH 0/3] libxl: support Xen migration stream V2

On Mon, May 02, 2016 at 07:01:16PM -0600, Jim Fehlig wrote: > Hi all, > > This patch adds support for Xen migration stream V2 to the libvirt > libxl driver. In the process it fixes save/restore and migration > tests in OSSTest, which have been failing since libvirt commit > e7440656. > > Patch1

Re: [libvirt] [PATCH REPOST 04/38] virlog: Export virLogOutputPtr through header

On 10/05/16 02:08, Cole Robinson wrote: > On 05/04/2016 10:30 AM, Erik Skultety wrote: >> It needs to be exported, since some caller might (for some reason) want to >> create a logging output without calling the parser which does this. Also, >> some methods will use virLogOutputPtr as data type

Re: [libvirt] [PATCH 3/5] domaincaps: Report graphics spiceGL

On Mon, May 09, 2016 at 06:53:01PM -0400, Cole Robinson wrote: > On 05/09/2016 09:48 AM, Daniel P. Berrange wrote: > > Yeah, I find flat modelling quite desirable, because the relationships > > between attributes will certainly grow quite complicate, and they do > > not neccessarily form a nice

Re: [libvirt] [PATCH 4/4] qemu_hotplug: fix checking graphics ports

On Mon, May 09, 2016 at 09:24:13PM -0400, Cole Robinson wrote: > On 05/09/2016 09:48 AM, Pavel Hrdina wrote: > > We cannot change ports for running domain and we should error out if > > autoport is enabled. > > > > Signed-off-by: Pavel Hrdina > > --- > >

Re: [libvirt] [Qemu-devel] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions

On Tue, May 10, 2016 at 10:23:16 +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Mon, May 09, 2016 at 09:20:15AM -0600, Eric Blake wrote: > >> On 05/06/2016 12:11 PM, Eduardo Habkost wrote: > >> > Extend query-cpu-definitions schema to allow it to return

Re: [libvirt] [Qemu-devel] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions

Eduardo Habkost writes: > On Mon, May 09, 2016 at 09:20:15AM -0600, Eric Blake wrote: >> On 05/06/2016 12:11 PM, Eduardo Habkost wrote: >> > Extend query-cpu-definitions schema to allow it to return two new >> > optional fields: "runnable" and "unavailable-features". >> >

[libvirt] [PATCH] qemu-agent: remove redundant comments

From: Chen Hanxiao Signed-off-by: Chen Hanxiao --- src/qemu/qemu_agent.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c index c55f304..20597b4 100644 --- a/src/qemu/qemu_agent.c +++

Re: [libvirt] [PATCH 8/8] Revert "conf: Validate disk lun using correct types"

On Mon, May 09, 2016 at 11:57:20AM -0400, Cole Robinson wrote: > On 05/09/2016 04:59 AM, Peter Krempa wrote: > > On Fri, May 06, 2016 at 11:19:05 -0400, John Ferlan wrote: > >> > >> > >> On 05/02/2016 10:32 AM, Peter Krempa wrote: > >>> This reverts commit c79ebf53b5fe0a33bf407b3bcb49e3a27ec97eb4.

Re: [libvirt] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions

> > Yes, I think so. However to really make good hints, upper layers would most > > likely need more information about the exact problem with a property - > > maybe something like an enum value per problematic property. > > (UNAVAILABLE_FEATURE, VALUE_TOO_BIG, VALUE_TOO_SMALL, UNSUPPORTED_VALUE)

Re: [libvirt] NFS over AF_VSOCK in

On Mon, May 09, 2016 at 16:57:17 +0100, Stefan Hajnoczi wrote: > virtio-vsock support has been added to the nfs-ganesha NFS server. I'm > currently working on upstreaming virtio-vsock into Linux and QEMU. I > also have patches for the Linux NFS client and server. Just out of curiosity are you

[libvirt] [PATCH] libxl: fix vm lock overwritten bug

In libxl driver we do virObjectRef in libxlDomainObjBeginJob, If virCondWaitUntil failed, it goes to error, do virObjectUnref, There's a chance that someone undefine the vm at the same time, and refs unref to zero, vm is freed in libxlDomainObjBeginJob. But the vm outside function is not Null, we