[libvirt] [PATCH v3 1/1] perf: add support to perf event for MBM

Some Intel processor families (e.g. the Intel Xeon processor E5 v3 family) introduced some RDT (Resource Director Technology) features to monitor or control shared resource. Among these features, MBM (Memory Bandwidth Monitoring), which is build on the CMT (Cache Monitoring Technology)

Re: [libvirt] [PATCH 2/2] libxl: support hotplug USB host device

>>> On 5/13/2016 at 07:20 AM, in message <57350fa5.3070...@suse.com>, Jim Fehlig wrote: > Chunyan Liu wrote: > > Support hot attach/detach a USB host device to guest. > > Curretnly libxl only supports xen PV guest, and only > > s/Curretnly/Currently/ > > > supports

Re: [libvirt] [PATCH 1/2] libxl: support creating guest with USB hostdev

>>> On 5/13/2016 at 06:56 AM, in message <57350a36.3070...@suse.com>, Jim Fehlig wrote: > Chunyan Liu wrote: > > Support creating guest with USB host device in config file. > > Currently libxl only supports xen PV guest, and only supports > > specifying USB host device by

Re: [libvirt] [PATCH 1/2] xenFormatNet: correct `type=netfront' to 'type=vif' to match libxl

>>> On 5/12/2016 at 11:00 PM, in message <57349a91.50...@oracle.com>, Joao >>> Martins wrote: > On 05/12/2016 12:54 AM, Jim Fehlig wrote: > > On 04/21/2016 05:10 AM, Chunyan Liu wrote: > >> According to current xl.cfg docs and xl codes, it uses type=vif > >>

Re: [libvirt] [PATCH 2/2] libxl: support hotplug USB host device

Chunyan Liu wrote: > Support hot attach/detach a USB host device to guest. > Curretnly libxl only supports xen PV guest, and only s/Curretnly/Currently/ > supports specifying USB host device by 'bus number' > and 'device number'. > > Signed-off-by: Chunyan Liu > --- >

Re: [libvirt] [PATCH 1/2] libxl: support creating guest with USB hostdev

Chunyan Liu wrote: > Support creating guest with USB host device in config file. > Currently libxl only supports xen PV guest, and only supports > specifying USB host device by 'bus number' and 'device number'. It would be nice to have an example of xl.cfg(5) usbdev= configuration and the

Re: [libvirt] [PATCH 0/2] libxl: support pvusb

Chunyan Liu wrote: > This patch series is to support pvusb in libxl driver. > > Chunyan Liu (2): > libxl: support creating guest with USB hostdev > libxl: support hotplug USB host device This series should also include support for converting domXML USB config to/from xl.cfg(5) in

Re: [libvirt] [PATCH] network: log error when is requested for hostdev interfaces

On 05/12/2016 01:54 AM, Peter Krempa wrote: On Wed, May 11, 2016 at 12:18:51 -0400, Laine Stump wrote: This would previously be silently ignored. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1319044 --- src/network/bridge_driver.c | 25 +

Re: [libvirt] [PATCH 1/2] xenFormatNet: correct `type=netfront' to 'type=vif' to match libxl

Joao Martins wrote: > On 05/12/2016 12:54 AM, Jim Fehlig wrote: >> On 04/21/2016 05:10 AM, Chunyan Liu wrote: >>> According to current xl.cfg docs and xl codes, it uses type=vif >>> instead of type=netfront. >>> >>> Currently after domxml-to-native, libvirt xml model=netfront will be >>> converted

Re: [libvirt] [PATCH] Fix tests to include video ram size

Ján Tomko wrote: > My commit 3e42867 started filling out the video size in post-parse, > but did not adjust the tests. > --- > Pushed under the build breaker rule. > > tests/sexpr2xmldata/sexpr2xml-curmem.xml| 2 +- > tests/sexpr2xmldata/sexpr2xml-fv-autoport.xml

[libvirt] [PATCH 1/2] libxl: don't attempt to probe a non-existent emulator

When probing the with '-help' to determine if it is the old qemu, errors are reported if the emulator doesn't exist libvirt: error : internal error: Child process (/usr/lib/xen/bin/qemu-dm -help) unexpected exit status 127: libvirt: error : cannot execute binary /usr/lib/xen/bin/qemu-dm: No

[libvirt] [PATCH 0/2] libxl: A few more fixes related to vram

Commit 3e428670 broke the xlconfigtests, which commit 96b21fb0 mostly fixed. I found that running 'make check' on a machine with Xen installed (/usr/lib/xen/bin/qemu-{dm,system-i386} exists) failed. Test files containing /usr/lib/xen/bin/qemu-dm resulted in vram being set to the lower default

[libvirt] [PATCH 2/2] xlconfigtests: use qemu-xen in all test data files

Some of the test configuration files in tests/xlconfigdata use the old qemu-dm as the emulator. Many of the configuration features tested (spice, rbd, multi-usb) are not even usable with the old qemu. Change these files to use the new qemu-xen (also known as qemu upstream) emulator. Note: This

Re: [libvirt] Need to re-work final "peer address" patches and re-push them

On 05/12/2016 05:12 AM, Daniel P. Berrange wrote: On Wed, May 11, 2016 at 11:57:36AM -0400, Laine Stump wrote: I reverted these three patches that introduced and enabled a "peer" attribute for type='ethernet' interface elements prior to the release of 1.3.4 with the intent of fixing/re-posting

Re: [libvirt] Need to re-work final "peer address" patches and re-push them

On 05/12/2016 04:41 AM, Daniel P. Berrange wrote: On Thu, May 12, 2016 at 10:31:34AM +0200, Andrea Bolognani wrote: Is there any real chance the "prefix" attribute will need to be specified for the host as well? Because in that case we would clearly have to go with "hostPrefix", and using

Re: [libvirt] adding a new libvirt xml element for File Descriptor backed memory for use with vhost-user

> -Original Message- > From: Daniel P. Berrange [mailto:berra...@redhat.com] > Sent: Thursday, May 12, 2016 5:28 PM > To: Mooney, Sean K > Cc: libvir-list@redhat.com > Subject: Re: [libvirt] adding a new libvirt xml element for File > Descriptor backed memory

Re: [libvirt] adding a new libvirt xml element for File Descriptor backed memory for use with vhost-user

On Thu, May 12, 2016 at 04:00:29PM +, Mooney, Sean K wrote: > > > Today it is possible to use Libvirt to spawn a vm without hugepage > > > memory and a file descriptor backed memdev Via the use of the > > qemu:commandline element. > > > > > > > > > > > > > > > > > > > >

Re: [libvirt] adding a new libvirt xml element for File Descriptor backed memory for use with vhost-user

Hi Daniel Thanks for your response. Comments inline. Regards Sean. > -Original Message- > From: Daniel P. Berrange [mailto:berra...@redhat.com] > Sent: Wednesday, May 11, 2016 10:44 AM > To: Mooney, Sean K > Cc: libvir-list@redhat.com > Subject: Re: [libvirt]

Re: [libvirt] [PATCH 1/4] qemu: Automatically choose usable GIC version

On Tue, 2016-05-10 at 18:42 -0400, Cole Robinson wrote: > >  > > +if (virQEMUCapsFillDomainCaps(caps, qemuCaps, NULL, 0) < 0) > > +goto cleanup; > > + > > +gic = &(caps->gic); > > + > > +/* Pick the best GIC version from those available */ > > +if

Re: [libvirt] [PATCH v3 2/4] tests: Introduce global mock library

On 12.05.2016 17:30, Michal Privoznik wrote: > On 12.05.2016 16:34, Peter Krempa wrote: >> On Thu, May 12, 2016 at 14:36:22 +0200, Michal Privoznik wrote: >>> The intent is that this library is going to be called every time >>> to check if we are not touching anything outside srcdir or >>>

[libvirt] [PATCH v2] secret: Alter virSecretGetSecretString

Rather than returning a "char *" indicating perhaps some sized set of characters that is NUL terminated, alter the function to return 0 or -1 for success/failure and add two parameters to handle returning the buffer and it's size. The function no longer encodes the returned secret, rather it

Re: [libvirt] [PATCH v3 2/4] tests: Introduce global mock library

On 12.05.2016 16:34, Peter Krempa wrote: > On Thu, May 12, 2016 at 14:36:22 +0200, Michal Privoznik wrote: >> The intent is that this library is going to be called every time >> to check if we are not touching anything outside srcdir or >> builddir. >> >> Signed-off-by: Michal Privoznik

Re: [libvirt] [PATCH] qemu: domain: Fix name of macro defining AES IV length

On 05/12/2016 11:15 AM, Peter Krempa wrote: > The initialization vector is a technical term by itself different from > the key. > --- > src/qemu/qemu_domain.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Whoops - sorry, I thought I removed that too ACK John -- libvir-list

Re: [libvirt] [Xen-devel] [PATCH 1/3] libxl: switch to using libxl_domain_create_restore from v4.4 API

Olaf Hering wrote: > On Wed, May 11, Jim Fehlig wrote: > >> https://www.redhat.com/archives/libvir-list/2016-May/msg00686.html > > Perhaps configure.ac should be changed to reject libxl upfront. Yes, good idea. > It looks > like the assignment of LIBXL_CFLAGS should be moved up, so that >

[libvirt] [PATCH v3 14/14] vnc: add support for listen type none

Signed-off-by: Pavel Hrdina --- docs/formatdomain.html.in | 3 ++- src/conf/domain_conf.c| 3 ++- src/qemu/qemu_command.c | 3 +++ 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index d217ae0..d1d5915

[libvirt] [PATCH v3 01/14] graphics: don't parse listens if socket attribute is present

If socket attribute is present we start VNC that listens only on that unix socket. This makes the parser behave the same way as we actually use the socket attribute. Signed-off-by: Pavel Hrdina --- src/conf/domain_conf.c| 8

[libvirt] [PATCH v3 04/14] domain_conf: cleanup virDomainGraphicsListenDefParseXML

Signed-off-by: Pavel Hrdina --- src/conf/domain_conf.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 1f202dc..a1048a7 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -10724,10

[libvirt] [PATCH v3 02/14] domain_conf: parse listen attribute while parsing listen elements

Move the compatibility code out of virDomainGraphicsListensParseXML() into virDomainGraphicsListenDefParseXML(). This also fixes a small inconsistency between the code and error message itself. Before this patch we would search first listen element that is type='address' to validate listen and

[libvirt] [PATCH v3 03/14] graphics: make address attribute for listen type='address' optional

We support omitting listen attribute of graphics element so we should also support omitting address attribute of listen element. This patch also updates libvirt to always add a listen element into domain XML except for VNC graphics if socket attribute is specified. Signed-off-by: Pavel Hrdina

[libvirt] [PATCH v3 12/14] spice: introduce spice_auto_unix_socket config option

Signed-off-by: Pavel Hrdina --- src/qemu/libvirtd_qemu.aug | 1 + src/qemu/qemu.conf | 11 +++ src/qemu/qemu_conf.c | 1 + src/qemu/qemu_conf.h | 1 +

[libvirt] [PATCH v3 07/14] qemu_capabilites: add QEMU_CAPS_SPICE_UNIX

Add a new capability to detect support of unix sockets for spice graphics. Signed-off-by: Pavel Hrdina --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + 2 files changed, 3 insertions(+) diff --git a/src/qemu/qemu_capabilities.c

[libvirt] [PATCH v3 00/14] improve graphics listen configuration

This patch series improves the way how different listen types can be specified and also introduce a new listen types for graphics devices. First improvement is to move ports out of graphics element into listen element with type address or network. This is a first step to make the code

[libvirt] [PATCH] qemu: domain: Fix name of macro defining AES IV length

The initialization vector is a technical term by itself different from the key. --- src/qemu/qemu_domain.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h index 331ade0..dd90e67 100644 --- a/src/qemu/qemu_domain.h +++

[libvirt] [PATCH v3 11/14] tests: cleanup vnc auto socket test

Commit 55320c23 introduced a new test for VNC to test if vnc_auto_unix_socket is set in qemu.conf, but forget to enable it in qemuxml2argvtest.c. This patch also moves the code in qemuxml2xmltest.c next to other VNC tests. Signed-off-by: Pavel Hrdina ---

[libvirt] [PATCH v3 13/14] spice: introduce listen type none

This new listen type is currently supported only by spice graphics. It's introduced to make it easier and clearer specify to not listen anywhere in order to start a guest with OpenGL support. The old way to do this was set spice graphics autoport='no' and don't specify any ports. The new way is

[libvirt] [PATCH v3 10/14] qemu_process: separate graphics socket and address generation

Signed-off-by: Pavel Hrdina --- src/qemu/qemu_process.c | 123 ++-- 1 file changed, 77 insertions(+), 46 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 3d78455..21c2db2 100644 ---

[libvirt] [PATCH v3 06/14] graphics: introduce listen type=socket and use it for VNC

Introduce a new listen type that will be used to tell a graphics device to listen on unix socket and use it for VNC graphics instead of socket attribute. The socket attribute will remain in the XML for backward compatibility. Since old libvirt supports 'socket' attribute inside 'graphics'

[libvirt] [PATCH v3 09/14] spice: add support for listen type socket

Signed-off-by: Pavel Hrdina --- docs/formatdomain.html.in | 2 +- src/conf/domain_conf.c | 33 -- src/qemu/qemu_command.c| 120 - src/qemu/qemu_migration.c

[libvirt] [PATCH v3 08/14] qemu_command: refactor spice channel code

This prepares the code for other listen types. Signed-off-by: Pavel Hrdina --- src/qemu/qemu_command.c | 57 ++--- 1 file changed, 26 insertions(+), 31 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c

Re: [libvirt] [PATCH] libxl: fix default vram setting for implicit video device

On 05/11/2016 11:21 PM, Jim Fehlig wrote: > On 05/11/2016 05:22 AM, Joao Martins wrote: >> On 05/11/2016 06:01 AM, Jim Fehlig wrote: >>> Commit 6879be48 moved adding of an implicit video device after XML >>> parsing. As a result, libxlDomainDeviceDefPostParse() is no longer >>> called to set the

Re: [libvirt] [PATCH 1/2] xenFormatNet: correct `type=netfront' to 'type=vif' to match libxl

On 05/12/2016 12:54 AM, Jim Fehlig wrote: > On 04/21/2016 05:10 AM, Chunyan Liu wrote: >> According to current xl.cfg docs and xl codes, it uses type=vif >> instead of type=netfront. >> >> Currently after domxml-to-native, libvirt xml model=netfront will be >> converted to xl type=netfront. This

Re: [libvirt] [PATCH v3 2/4] tests: Introduce global mock library

On Thu, May 12, 2016 at 14:36:22 +0200, Michal Privoznik wrote: > The intent is that this library is going to be called every time > to check if we are not touching anything outside srcdir or > builddir. > > Signed-off-by: Michal Privoznik > --- > cfg.mk|

Re: [libvirt] [PATCH 3/4] tests: Prepare to have different usable GIC versions

On Tue, 2016-05-10 at 18:45 -0400, Cole Robinson wrote: > On 05/10/2016 08:46 AM, Andrea Bolognani wrote: > > > > Now that we choose the GIC version based on hardware features when > > no element has been provided, we need a way to fake the GIC > > capabilities of the host. > > > > Update the

[libvirt] [PATCH 2/2] tests: Adding option for xml2sexpr-disk-block data test.

There is no XML data file that is using option for disk. It is a good opportunity to test/check this option for Xen. The same for network options. Signed-off-by: Julio Faracco --- tests/xml2sexprdata/xml2sexpr-disk-block.xml | 1 + 1 file changed, 1 insertion(+) diff

Re: [libvirt] [Qemu-devel] [RFC 12/42] pc: initialize legacy hotplug only for 2.6 and older machine types

On Thu, 12 May 2016 15:27:04 +0200 Peter Krempa wrote: > On Thu, May 12, 2016 at 15:20:51 +0200, Igor Mammedov wrote: > > On Thu, 12 May 2016 13:04:23 +0200 > > Peter Krempa wrote: > > > > > On Thu, May 12, 2016 at 07:52:23 -0300, Eduardo Habkost

[libvirt] [PATCH 1/2] tests: Adding option for xml2sexpr-net-bridge data test.

There is no XML data file that is using option for network. It is a good opportunity to test/check this option for Xen. Signed-off-by: Julio Faracco --- tests/xml2sexprdata/xml2sexpr-net-bridged.xml | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [libvirt] [PATCH v3 1/4] virfile: Introduce virFileRemoveLastComponent

On Thu, May 12, 2016 at 14:36:21 +0200, Michal Privoznik wrote: > Move some parts of virStorageFileRemoveLastPathComponent > into a separate function so they can be reused. > > Signed-off-by: Michal Privoznik > --- > src/libvirt_private.syms | 1 + > src/util/virfile.c

Re: [libvirt] [RFC 12/42] pc: initialize legacy hotplug only for 2.6 and older machine types

On Thu, May 12, 2016 at 15:20:51 +0200, Igor Mammedov wrote: > On Thu, 12 May 2016 13:04:23 +0200 > Peter Krempa wrote: > > > On Thu, May 12, 2016 at 07:52:23 -0300, Eduardo Habkost wrote: > > > I don't think we should do that, unless users already had time to > > > update

Re: [libvirt] [RFC 12/42] pc: initialize legacy hotplug only for 2.6 and older machine types

On Thu, 12 May 2016 13:04:23 +0200 Peter Krempa wrote: > On Thu, May 12, 2016 at 07:52:23 -0300, Eduardo Habkost wrote: > > I don't think we should do that, unless users already had time to > > update their scripts and libvirt had time to implement code > > supporting the new

Re: [libvirt] [PATCH 2/3] secret: Alter virSecretGetSecretString

On Thu, May 12, 2016 at 08:39:28 -0400, John Ferlan wrote: > On 05/12/2016 08:26 AM, Peter Krempa wrote: > > On Thu, May 12, 2016 at 07:49:31 -0400, John Ferlan wrote: > >> Rather than returning a "char *" indicating perhaps some sized set of > >> characters that is NUL terminated, return the

Re: [libvirt] [PATCH v2 2/3] virtestmock: Print invalid file accesses into a file

On Thu, May 12, 2016 at 14:33:08 +0200, Michal Privoznik wrote: > On 11.05.2016 17:15, Peter Krempa wrote: > > On Tue, May 10, 2016 at 17:24:13 +0200, Michal Privoznik wrote: [...] > >> +static void > >> +printFile(const char *output, > >> + const char *file) > >> +{ > >> +FILE *fp;

Re: [libvirt] [PATCH v2 1/3] tests: Introduce global mock library

On Thu, May 12, 2016 at 14:33:19 +0200, Michal Privoznik wrote: > On 11.05.2016 16:50, Peter Krempa wrote: > > On Tue, May 10, 2016 at 17:24:12 +0200, Michal Privoznik wrote: > >> The intent is that this library is going to be called every time > >> to check if we are not touching anything outside

[libvirt] [PATCH] Fix tests to include video ram size

My commit 3e42867 started filling out the video size in post-parse, but did not adjust the tests. --- Pushed under the build breaker rule. tests/sexpr2xmldata/sexpr2xml-curmem.xml| 2 +- tests/sexpr2xmldata/sexpr2xml-fv-autoport.xml | 2 +-

[libvirt] [PATCH v3 3/4] virtestmock: Print invalid file accesses into a file

All the accesses to files outside our build or source directories are now identified and appended into a file for later processing. The location of the file that contains all the records can be controlled via VIR_TEST_FILE_ACCESS env variable and defaults to abs_builddir "/test_file_access.txt".

Re: [libvirt] [PATCH 2/3] secret: Alter virSecretGetSecretString

On 05/12/2016 08:26 AM, Peter Krempa wrote: > On Thu, May 12, 2016 at 07:49:31 -0400, John Ferlan wrote: >> Rather than returning a "char *" indicating perhaps some sized set of >> characters that is NUL terminated, return the value as "uint8_t *" >> indicating a stream of raw bytes. In doing

[libvirt] [PATCH v3 1/4] virfile: Introduce virFileRemoveLastComponent

Move some parts of virStorageFileRemoveLastPathComponent into a separate function so they can be reused. Signed-off-by: Michal Privoznik --- src/libvirt_private.syms | 1 + src/util/virfile.c| 17 + src/util/virfile.h| 1 +

Re: [libvirt] [PATCH 3/3] qemu: Change from SecretIV or _IV to SecretAES or _AES

On Thu, May 12, 2016 at 07:49:32 -0400, John Ferlan wrote: > The preferred name will be AES not IV, change current references > > Signed-off-by: John Ferlan > --- > src/qemu/qemu_command.c | 4 ++-- > src/qemu/qemu_domain.c | 6 +++--- > src/qemu/qemu_domain.h | 14

[libvirt] [PATCH v3 4/4] tests: Introduce check-file-access.pl

This script will check output generated by virtestmock against a white list. All non matching records found are printed out. So far, the white list is rather sparse at the moment. This test should be ran only after all other tests finished, and should cleanup the temporary file before their

[libvirt] [PATCH v3 2/4] tests: Introduce global mock library

The intent is that this library is going to be called every time to check if we are not touching anything outside srcdir or builddir. Signed-off-by: Michal Privoznik --- cfg.mk| 2 +- tests/Makefile.am | 13 +++- tests/testutils.c | 9 +++

[libvirt] [PATCH v3 0/4] Introduce big test mock

diff to v2: - Peter's review suggestions worked in Note that patch 2/4 is ACKed already, but without the rest it makes no sense, so I've not pushed it yet and sending it here for completeness. Michal Privoznik (4): virfile: Introduce virFileRemoveLastComponent tests: Introduce global mock

Re: [libvirt] [PATCH v2 2/3] virtestmock: Print invalid file accesses into a file

On 11.05.2016 17:15, Peter Krempa wrote: > On Tue, May 10, 2016 at 17:24:13 +0200, Michal Privoznik wrote: >> All the accesses to files outside our build or source directories >> are now identified and appended into a file for later processing. >> The location of the file that contains all the

Re: [libvirt] [PATCH v2 3/3] tests: Introduce check-file-access.pl

On 12.05.2016 09:09, Peter Krempa wrote: > On Tue, May 10, 2016 at 17:24:14 +0200, Michal Privoznik wrote: >> This script will check output generated by virtestmock against a >> white list. All non matching records found are printed out. So >> far, the white list is rather sparse at the moment. >>

Re: [libvirt] [PATCH v2 1/3] tests: Introduce global mock library

On 11.05.2016 16:50, Peter Krempa wrote: > On Tue, May 10, 2016 at 17:24:12 +0200, Michal Privoznik wrote: >> The intent is that this library is going to be called every time >> to check if we are not touching anything outside srcdir or >> builddir. >> >> Signed-off-by: Michal Privoznik

Re: [libvirt] [PATCH v4 4/6] Add GVirConfigDomainHostdevPci

Looks I never answered this one. On Tue, Apr 26, 2016 at 05:04:30PM +0100, Zeeshan Ali (Khattak) wrote: > >> +const gchar > >> *gvir_config_domain_hostdev_pci_get_rom_file(GVirConfigDomainHostdevPci > >> *hostdev) > >> +{ > >> +return

Re: [libvirt] [PATCH 2/3] secret: Alter virSecretGetSecretString

On Thu, May 12, 2016 at 07:49:31 -0400, John Ferlan wrote: > Rather than returning a "char *" indicating perhaps some sized set of > characters that is NUL terminated, return the value as "uint8_t *" > indicating a stream of raw bytes. In doing so, we also need to return > the size of the secret

Re: [libvirt] [PATCH 1/3] util: Introduce virBufferEscapeSizedBuf

On Thu, May 12, 2016 at 07:49:30 -0400, John Ferlan wrote: > Soon we will need to escape a buffer string that cannot use strlen, so > introduce this API to allow printing/escaping of the entire buffer. > > Signed-off-by: John Ferlan > --- > src/libvirt_private.syms | 1 + >

Re: [libvirt] [PATCH v2 05/12] graphics: move port definition to listen element

On Thu, May 12, 2016 at 01:23:18PM +0200, Christophe Fergeau wrote: > On Wed, May 11, 2016 at 05:08:24PM +0200, Pavel Hrdina wrote: > > So far we have only two listen types that supports only address:port > > method, but in the future we may want to add a new different listen > > type, for example

[libvirt] [PATCH 0/3] Secrets adjustments

Fallout from review of v3 of the IV Secrets: http://www.redhat.com/archives/libvir-list/2016-May/msg00444.html Add a new buffer escape API to handle printing a sized buffer Alter the existing fetch, store, and printing of the secret to be a "uint8_t *" rather than "(unsigned) char *". Change

[libvirt] [PATCH 3/3] qemu: Change from SecretIV or _IV to SecretAES or _AES

The preferred name will be AES not IV, change current references Signed-off-by: John Ferlan --- src/qemu/qemu_command.c | 4 ++-- src/qemu/qemu_domain.c | 6 +++--- src/qemu/qemu_domain.h | 14 +++--- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git

Re: [libvirt] [PATCH v2 12/12] spice: introduce listen type none

On Wed, May 11, 2016 at 05:08:31PM +0200, Pavel Hrdina wrote: > This new listen type is currently supported only by spice graphics. > It's introduced to make it easier and clearer specify to not listen > anywhere in order to start a guest with OpenGL support. > > The old way to do this was set

[libvirt] [PATCH 1/3] util: Introduce virBufferEscapeSizedBuf

Soon we will need to escape a buffer string that cannot use strlen, so introduce this API to allow printing/escaping of the entire buffer. Signed-off-by: John Ferlan --- src/libvirt_private.syms | 1 + src/util/virbuffer.c | 54

[libvirt] [PATCH 2/3] secret: Alter virSecretGetSecretString

Rather than returning a "char *" indicating perhaps some sized set of characters that is NUL terminated, return the value as "uint8_t *" indicating a stream of raw bytes. In doing so, we also need to return the size of the secret returned. Alter the callers to handle the adjusted model.

Re: [libvirt] [PATCH v2 12/12] spice: introduce listen type none

On Thu, May 12, 2016 at 08:43:38AM +0200, Pavel Hrdina wrote: > > > @@ -21630,8 +21661,6 @@ virDomainGraphicsDefFormat(virBufferPtr buf, > > > } > > > > > > for (i = 0; i < def->nListens; i++) { > > > -if (def->listens[i].type == VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NONE) > > > -

Re: [libvirt] [PATCH v2 11/12] spice: introduce spice_auto_unix_socket config option

On Wed, May 11, 2016 at 05:08:30PM +0200, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > src/qemu/qemu.conf | 11 +++ > src/qemu/qemu_conf.c | 1 + > src/qemu/qemu_conf.h

Re: [libvirt] [PATCH 0/3] Fix default vram setting for libxl

On Thu, May 12, 2016 at 10:30:24 +0200, Ján Tomko wrote: > On Wed, May 11, 2016 at 03:47:06PM -0600, Jim Fehlig wrote: > > On 05/11/2016 04:57 AM, Ján Tomko wrote: > > > An alternative to > > > https://www.redhat.com/archives/libvir-list/2016-May/msg00700.html > > >

Re: [libvirt] [PATCH v2 08/12] spice: add support for listen type socket

On Thu, May 12, 2016 at 01:17:54PM +0200, Christophe Fergeau wrote: > Hey, > > On Wed, May 11, 2016 at 05:08:27PM +0200, Pavel Hrdina wrote: > > @@ -7665,40 +7694,12 @@ > > qemuBuildGraphicsSPICECommandLine(virQEMUDriverConfigPtr cfg, > > break; > > > > case

Re: [libvirt] [PATCH v2 06/12] graphics: introduce listen type=socket and use it for VNC

On Thu, May 12, 2016 at 01:06:41PM +0200, Christophe Fergeau wrote: > Hey, > > On Wed, May 11, 2016 at 05:08:25PM +0200, Pavel Hrdina wrote: > > Introduce a new listen type that will be used to tell a graphics device > > to listen on unix socket and use it for VNC graphics instead of socket > >

Re: [libvirt] [PATCH v2 05/12] graphics: move port definition to listen element

On Wed, May 11, 2016 at 05:08:24PM +0200, Pavel Hrdina wrote: > So far we have only two listen types that supports only address:port > method, but in the future we may want to add a new different listen > type, for example socket. > > This patch moves the ports values out of graphics unions into

Re: [libvirt] [PATCH v2 08/12] spice: add support for listen type socket

Hey, On Wed, May 11, 2016 at 05:08:27PM +0200, Pavel Hrdina wrote: > @@ -7665,40 +7694,12 @@ > qemuBuildGraphicsSPICECommandLine(virQEMUDriverConfigPtr cfg, > break; > > case VIR_DOMAIN_GRAPHICS_SPICE_CHANNEL_MODE_INSECURE: > -if (glisten->port <= 0) { > -

Re: [libvirt] [Qemu-devel] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions

On Thu, May 12, 2016 at 09:19:48AM +0200, Jiri Denemark wrote: > On Wed, May 11, 2016 at 16:35:50 -0300, Eduardo Habkost wrote: > > # @CpuDefinitionInfo: > > # > > # Virtual CPU definition. > > # > > # @name: the name of the CPU definition > > # @runnable: #optional. whether the CPU model us

Re: [libvirt] [PATCH v2 06/12] graphics: introduce listen type=socket and use it for VNC

Hey, On Wed, May 11, 2016 at 05:08:25PM +0200, Pavel Hrdina wrote: > Introduce a new listen type that will be used to tell a graphics device > to listen on unix socket and use it for VNC graphics instead of socket > attribute. The socket attribute will remain in the XML for backward >

Re: [libvirt] [RFC 12/42] pc: initialize legacy hotplug only for 2.6 and older machine types

On Thu, May 12, 2016 at 07:52:23 -0300, Eduardo Habkost wrote: > I don't think we should do that, unless users already had time to > update their scripts and libvirt had time to implement code > supporting the new method. > > I believe libvirt (and people's scripts) use maxcpus only when > they

Re: [libvirt] [RFC 12/42] pc: initialize legacy hotplug only for 2.6 and older machine types

On Thu, May 12, 2016 at 12:29:55PM +0200, Igor Mammedov wrote: > On Thu, 12 May 2016 10:07:03 +0300 > "Michael S. Tsirkin" wrote: > > > On Wed, May 11, 2016 at 08:28:59PM -0300, Eduardo Habkost wrote: > > > On Thu, May 12, 2016 at 12:51:55AM +0300, Michael S. Tsirkin wrote: >

Re: [libvirt] [PATCH] schemas: Improve outdated comment

On Thu, May 12, 2016 at 12:26:07 +0200, Christophe Fergeau wrote: > --- ACK signature.asc Description: Digital signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [RFC 12/42] pc: initialize legacy hotplug only for 2.6 and older machine types

On Thu, 12 May 2016 10:05:54 +0300 "Michael S. Tsirkin" wrote: > On Wed, May 11, 2016 at 08:36:00PM -0300, Eduardo Habkost wrote: > > On Wed, May 11, 2016 at 03:50:39PM +0200, Igor Mammedov wrote: > > > On Tue, 10 May 2016 17:24:14 -0300 > > > Eduardo Habkost

[libvirt] [PATCH] schemas: Improve outdated comment

--- docs/schemas/domaincommon.rng | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng index 273715c..8798001 100644 --- a/docs/schemas/domaincommon.rng +++ b/docs/schemas/domaincommon.rng @@ -2622,10 +2622,7 @@

Re: [libvirt] [PATCH 1/1] perf: add support to perf event for MBM

> -Original Message- > From: Peter Krempa [mailto:pkre...@redhat.com] > Sent: Thursday, May 12, 2016 4:31 PM > To: Ren, Qiaowei > Cc: libvir-list@redhat.com; berra...@redhat.com > Subject: Re: [libvirt] [PATCH 1/1] perf: add support to perf event for MBM > > On

Re: [libvirt] Need to re-work final "peer address" patches and re-push them

On Wed, May 11, 2016 at 11:57:36AM -0400, Laine Stump wrote: > I reverted these three patches that introduced and enabled a "peer" > attribute for type='ethernet' interface elements prior to the release > of 1.3.4 with the intent of fixing/re-posting them after release, but forgot > until today:

Re: [libvirt] Need to re-work final "peer address" patches and re-push them

On Thu, 2016-05-12 at 09:41 +0100, Daniel P. Berrange wrote: > On Thu, May 12, 2016 at 10:31:34AM +0200, Andrea Bolognani wrote: > > > > On Thu, 2016-05-12 at 09:58 +0200, Jiri Denemark wrote: > > > > > > On Wed, May 11, 2016 at 11:57:36 -0400, Laine Stump wrote: > > > > > > > > > > > > I

Re: [libvirt] Need to re-work final "peer address" patches and re-push them

On Thu, May 12, 2016 at 10:31:34 +0200, Andrea Bolognani wrote: > On Thu, 2016-05-12 at 09:58 +0200, Jiri Denemark wrote: > > On Wed, May 11, 2016 at 11:57:36 -0400, Laine Stump wrote: > > > > > > I reverted these three patches that introduced and enabled a "peer"  > > > attribute for

Re: [libvirt] docs: Change or update the hacking page

On Thu, May 12, 2016 at 10:35:54AM +0200, Andrea Bolognani wrote: > On Wed, 2016-05-11 at 10:01 -0400, Cole Robinson wrote: > > On 05/11/2016 02:04 AM, Nishith Shah wrote: > > > > > > Hi everyone, sorry about the empty message above, I was typing and I > > > pressed > > > the wrong set of keys.

Re: [libvirt] Need to re-work final "peer address" patches and re-push them

On Thu, May 12, 2016 at 10:31:34AM +0200, Andrea Bolognani wrote: > On Thu, 2016-05-12 at 09:58 +0200, Jiri Denemark wrote: > > On Wed, May 11, 2016 at 11:57:36 -0400, Laine Stump wrote: > > > > > > I reverted these three patches that introduced and enabled a "peer"  > > > attribute for

Re: [libvirt] docs: Change or update the hacking page

On Wed, 2016-05-11 at 10:01 -0400, Cole Robinson wrote: > On 05/11/2016 02:04 AM, Nishith Shah wrote: > > > > Hi everyone, sorry about the empty message above, I was typing and I pressed > > the wrong set of keys. > > > > So, I was going through the contributor guidelines page[1], and after > >

Re: [libvirt] Need to re-work final "peer address" patches and re-push them

On Thu, 2016-05-12 at 09:58 +0200, Jiri Denemark wrote: > On Wed, May 11, 2016 at 11:57:36 -0400, Laine Stump wrote: > > > > I reverted these three patches that introduced and enabled a "peer"  > > attribute for type='ethernet' interface elements prior to the  > > release of 1.3.4 with the

Re: [libvirt] [PATCH 0/3] Fix default vram setting for libxl

On Wed, May 11, 2016 at 03:47:06PM -0600, Jim Fehlig wrote: > On 05/11/2016 04:57 AM, Ján Tomko wrote: > > An alternative to > > https://www.redhat.com/archives/libvir-list/2016-May/msg00700.html > > 1462942877-31516-1-git-send-email-jfeh...@suse.com > > > > This series adds a call to

Re: [libvirt] [PATCH 1/1] perf: add support to perf event for MBM

On Thu, May 12, 2016 at 14:55:16 +0800, Qiaowei Ren wrote: > Some Intel processor families (e.g. the Intel Xeon processor E5 v3 > family) introduced some RDT (Resource Director Technology) features > to monitor or control shared resource. Among these features, MBM > (Memory Bandwidth Monitoring),

Re: [libvirt] Need to re-work final "peer address" patches and re-push them

On Wed, May 11, 2016 at 11:57:36 -0400, Laine Stump wrote: > I reverted these three patches that introduced and enabled a "peer" > attribute for type='ethernet' interface elements prior to the > release of 1.3.4 with the intent of fixing/re-posting them after > release, but forgot until today:

[libvirt] [PATCH] qemuxml2argvtest: uncoditionally mock NUMA routines

Currently, qemuxml2argvmock.c only mocks virNumaNodeIsAvailable(), and only if libvirt was built with NUMA support. This causes some test failures where NUMA is involved. For example, memory-hotplug-dimm fails because it goes all they way down to qemuBuildMemoryBackendStr() that calls

Re: [libvirt] [Qemu-devel] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions

Eduardo Habkost writes: > On Wed, May 11, 2016 at 09:11:33AM +0200, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > On Tue, May 10, 2016 at 10:23:16AM +0200, Markus Armbruster wrote: >> >> Eduardo Habkost writes: >> >>

Re: [libvirt] Introducing Fabian Freyer (GSoC 2016 student)

On Thu, 2016-05-12 at 05:35 +0200, Fabian Freyer wrote: >  > On that note, I have my first question: in the virHypervisorDriver > struct for different drivers, fields are commented by a version number. > For patches, what version number should be added there? I assume the > upcoming release

  1   2   >