Re: [libvirt] [PATCH V2 2/4] libxl: support hotplug USB host device

2016-05-22 Thread Chun Yan Liu
>>> On 5/20/2016 at 06:32 PM, in message <573ee7c3.7000...@oracle.com>, Joao Martins wrote: > On 05/19/2016 09:14 AM, Chunyan Liu wrote: > > Support hot attach/detach a USB host device to guest. > > Curretnly libxl only supports xen PV guest, and only > > supports

Re: [libvirt] [PATCH] libxl: add .domainInterfaceAddresses

2016-05-22 Thread Chun Yan Liu
>>> On 5/17/2016 at 11:46 PM, in message <2fa0cb6f-ea83-d6f3-18f8-51a671574...@laine.org>, Laine Stump wrote: > On 05/16/2016 06:05 PM, Jim Fehlig wrote: > > Chun Yan Liu wrote: > > On 5/14/2016 at 07:47 AM, in message <5736677d.8030...@suse.com>, Jim > > Fehlig >

Re: [libvirt] [PATCH] util: compilation fix if build without GNUTLS library

2016-05-22 Thread Cole Robinson
On 05/22/2016 10:23 AM, John Ferlan wrote: > > > On 05/21/2016 10:22 AM, Mikhail Feoktistov wrote: >> --- >> src/util/vircrypto.c | 13 +++-- >> 1 file changed, 7 insertions(+), 6 deletions(-) >> > > Ugh... Sorry about this - forgot about the unused attributes > > I should have just

[libvirt] [PATCH 1/4] util: Add range parameters to virRandomBytes

2016-05-22 Thread John Ferlan
Add a minval and maxval range for acceptible values from /dev/urandom Signed-off-by: John Ferlan --- src/util/vircrypto.c | 2 +- src/util/virrandom.c | 13 ++--- src/util/virrandom.h | 3 ++- src/util/viruuid.c | 2 +- tests/qemuxml2argvmock.c |

[libvirt] [PATCH 0/4] Couple of random and crypto adjustments

2016-05-22 Thread John Ferlan
Patches 1&2 alter the virRandomBytes to accomodate the lone holdout code that was using /dev/urandom directly to add a range of bytes that are acceptible returns for the caller. Patches 3&4 modify the virCryptoEncryptData algorithm to "A" (hopefully) build right in a non gnutls environment and

[libvirt] [PATCH 4/4] util: Adjust virCryptoEncryptData code to use macros

2016-05-22 Thread John Ferlan
Will make it easier to add new key lengths Signed-off-by: John Ferlan --- src/util/vircrypto.c | 50 +++--- 1 file changed, 27 insertions(+), 23 deletions(-) diff --git a/src/util/vircrypto.c b/src/util/vircrypto.c index

[libvirt] [PATCH 2/4] storage: Use virRandomBytes for virStorageGenerateQcowPassphrase

2016-05-22 Thread John Ferlan
Use the common API Signed-off-by: John Ferlan --- src/storage/storage_backend.c | 10 +++--- src/util/virstorageencryption.c | 42 +++-- src/util/virstorageencryption.h | 4 ++-- 3 files changed, 24 insertions(+), 32 deletions(-)

[libvirt] [PATCH 3/4] util: Alter virCryptoEncryptData for non GNUTLS builds

2016-05-22 Thread John Ferlan
Rather than intermixing the ATTRIBUTE_UNUSED - use HAVE_GNUTLS_CIPHER_ENCRYPT for the whole function instead. Signed-off-by: John Ferlan --- src/util/vircrypto.c | 36 +--- 1 file changed, 25 insertions(+), 11 deletions(-) diff --git

Re: [libvirt] [PATCH] util: compilation fix if build without GNUTLS library

2016-05-22 Thread John Ferlan
On 05/21/2016 10:22 AM, Mikhail Feoktistov wrote: > --- > src/util/vircrypto.c | 13 +++-- > 1 file changed, 7 insertions(+), 6 deletions(-) > Ugh... Sorry about this - forgot about the unused attributes I should have just gone with the entire function w/ the

Re: [libvirt] [PATCH] util: compilation fix if build without GNUTLS library

2016-05-22 Thread Roman Bogorodskiy
Mikhail Feoktistov wrote: > --- > src/util/vircrypto.c | 13 +++-- > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/src/util/vircrypto.c b/src/util/vircrypto.c > index 5183d49..4f288f0 100644 > --- a/src/util/vircrypto.c > +++ b/src/util/vircrypto.c > @@ -24,6 +24,7