[libvirt] [PATCH 1/3] qemu: driver: Move around code to avoid need to rollback

2016-05-24 Thread Peter Krempa
qemuDomainChangeDiskLive rolled back few changes to the disk definition if changing of the media failed. This can be avoided by moving some code around. --- src/qemu/qemu_driver.c | 18 -- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/src/qemu/qemu_driver.c

[libvirt] [PATCH 2/3] qemu: driver: Remove unnecessary cleanup label from qemuDomainChangeDiskLive

2016-05-24 Thread Peter Krempa
--- src/qemu/qemu_driver.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 895e926..6f5712d 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -7655,13 +7655,12 @@

[libvirt] [PATCH 3/3] qemu: driver: Allow disk update of startupPolicy/snapshot for all disks

2016-05-24 Thread Peter Krempa
The libvirt internal bits can be changed for disks that don't otherwise support changing media. Remove the switch statement and allow changes of non-source data for all disks. --- src/qemu/qemu_driver.c | 55 +- 1 file changed, 23 insertions(+), 32

[libvirt] [PATCH 0/3] qemu: Allow update of certain disk options during runtime

2016-05-24 Thread Peter Krempa
Until this series it was possible to update floppies and cdroms only. With this you can update startup policy and snapshot behavior for regular disks too. Peter Krempa (3): qemu: driver: Move around code to avoid need to rollback qemu: driver: Remove unnecessary cleanup label from

Re: [libvirt] [PATCH] libxl: add .domainInterfaceAddresses

2016-05-24 Thread Jim Fehlig
On 05/22/2016 09:34 PM, Chun Yan Liu wrote: > On 5/17/2016 at 11:46 PM, in message > <2fa0cb6f-ea83-d6f3-18f8-51a671574...@laine.org>, Laine Stump > > wrote: >> On 05/16/2016 06:05 PM, Jim Fehlig wrote: >>> Chun Yan Liu wrote: >>> On 5/14/2016 at 07:47 AM, in message

Re: [libvirt] [PATCH] libxl: default to qemu driver for network disks

2016-05-24 Thread Jim Fehlig
On 05/23/2016 04:01 PM, Jim Fehlig wrote: > Xen only supports network-based disks with the qemu (aka qdisk) driver. > Set the driverName to 'qemu' in libxlDomainDeviceDefPostParse() if > not already set. When starting a domain with network-based disks, > ensure the driverName is 'qemu'. FYI, I've

Re: [libvirt] [PATCH 0/2] Add virFirmware object for use by driver config

2016-05-24 Thread Jim Fehlig
Hi All, Any comments to this approach of enabling some code sharing between qemu and libxl? Regards, Jim On 05/18/2016 10:38 AM, Jim Fehlig wrote: > While refreshing and testing my series to add domain capabilities > and UEFI support to the libxl driver [1], I realized it would be > useful to

Re: [libvirt] [PATCH] xenconfig: xm: check for driver on disk format

2016-05-24 Thread Jim Fehlig
On 05/24/2016 04:56 AM, Joao Martins wrote: > When reviewing libxl vif typename series[0] I found out a bug s/out// > on xen-xm formatter where this "virsh domxml-to-native xen-xm file.xml" s/this// > can lead to a NULL dereference if the disk driver isn't specified. > Fix this by checking for

[libvirt] [PATCH v2 3/3] lxc: Fix lxcDomainDestroyFlags endjob processing

2016-05-24 Thread John Ferlan
Commit id '15ccb0dbf' added job functions for the lxc driver; however, for shutdown and nonpersistent path, the vm was removed from the domain object list and the vm pointer cleared before the endjob. Adjust the code to perform the endjob first and then perform the ObjListRemove as long as the vm

[libvirt] [PATCH v2 2/3] qemu: Remove unused persistentAddrs

2016-05-24 Thread John Ferlan
Based on some digital archaeology performed by jtomko, it's been determined that the persistentAddrs variable is no longer necessary... The variable was added by: commit 141dea6bc7222107c2357acb68066baea5b26df3 CommitDate: 2010-02-12 17:25:52 + Add persistence of PCI addresses to QEMU

[libvirt] [PATCH v2 0/3] Fix a couple of recently found coverity issues

2016-05-24 Thread John Ferlan
v1: http://www.redhat.com/archives/libvir-list/2016-May/msg01611.html Although initially ACK'd by Erik, Jan pointed out something with one of the patches and well this just lagged on my todo list. Since then a change was made to lxc_driver.c (commit id '306b3a850') which caused a merge conflict.

[libvirt] [PATCH v2 1/3] qemu: Remove dead code

2016-05-24 Thread John Ferlan
Since commit id '20a0fa8e' removed the QEMU_CAPS_DEVICE, Coverity notes that it's no longer possible to have 'addrs' be NULL when checking for a live domain since qemuDomainPCIAddressSetCreate would have jumped to cleanup if addrs was NULL. Signed-off-by: John Ferlan ---

Re: [libvirt] [PATCH] lxc: support

2016-05-24 Thread Laine Stump
On 05/24/2016 12:33 PM, Laine Stump wrote: On 05/18/2016 07:37 AM, Vasiliy Tolstov wrote: 2016-05-17 17:39 GMT+03:00 Laine Stump : Rather than me spending time adding something to my patches that will just be superceded by another patch immediately, I would rather just do it

[libvirt] [PATCH] Oracle VirtualBox 5 support for libvirt

2016-05-24 Thread Martin Pietsch
This patch adds the support of Oracle VirtualBox 5 to libvirt. libvirt-vbox5-support.patch.xz Description: application/xz -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] lxc: support

2016-05-24 Thread Laine Stump
On 05/18/2016 07:37 AM, Vasiliy Tolstov wrote: 2016-05-17 17:39 GMT+03:00 Laine Stump : Rather than me spending time adding something to my patches that will just be superceded by another patch immediately, I would rather just do it the way everyone wants to begin with. Since

Re: [libvirt] [PATCH v2 2/2] conf: nodedev: Set PCI_PHYSICAL_FUNCTION flag more carefully

2016-05-24 Thread Laine Stump
On 05/24/2016 07:11 AM, Andrea Bolognani wrote: Instead of setting the flag before parsing the PCI address, set it afterwards. This ensure we can never end up in a situation where the flag has been set but pci_dev.physical_function has not been filled in. --- src/conf/node_device_conf.c | 4

Re: [libvirt] [PATCH v2 1/2] Document virPCIGetPhysicalFunction() and fix its callers

2016-05-24 Thread Laine Stump
On 05/24/2016 07:11 AM, Andrea Bolognani wrote: Commit c8b1a83605e4 changed the function, making it impossible for callers to be able to tell whether a non-negative return value means "physical function address found and parsed correctly" or "couldn't find corresponding physical function". The

Re: [libvirt] [PATCH] lxc: completely rework reference counting

2016-05-24 Thread Michal Privoznik
On 20.05.2016 17:17, Katerina Koukiou wrote: > This patch follows the pattern used in qemu driver regarding > reference counting. > It changes lxcDomObjFromDomain() to ref the domain (using > virDomainObjListFindByUUIDRef()) and adds virDomainObjEndAPI() which > should be the only function in

[libvirt] [PATCH v5 0/6] [REPOST] introduce new listen types for graphics

2016-05-24 Thread Pavel Hrdina
There is no change since v4 [1], I've only rebased patches that are still waiting for review and removed the ones that are already pushed. [1] Pavel Hrdina (6): graphics: introduce listen type socket and use it for VNC

[libvirt] [PATCH v5 3/6] spice: add support for listen type socket

2016-05-24 Thread Pavel Hrdina
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1335832 Signed-off-by: Pavel Hrdina --- docs/formatdomain.html.in | 2 +- src/conf/domain_conf.c | 31 src/qemu/qemu_command.c

[libvirt] [PATCH v5 1/6] graphics: introduce listen type socket and use it for VNC

2016-05-24 Thread Pavel Hrdina
Introduce a new listen type that will be used to tell a graphics device to listen on unix socket and use it for VNC graphics instead of socket attribute. The socket attribute will remain in the XML for backward compatibility. Since old libvirt supports 'socket' attribute inside 'graphics'

[libvirt] [PATCH v5 4/6] spice: introduce spice_auto_unix_socket config option

2016-05-24 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- src/qemu/libvirtd_qemu.aug | 1 + src/qemu/qemu.conf | 11 +++ src/qemu/qemu_conf.c | 1 + src/qemu/qemu_conf.h | 1 +

[libvirt] [PATCH v5 5/6] spice: introduce listen type none

2016-05-24 Thread Pavel Hrdina
This new listen type is currently supported only by spice graphics. It's introduced to make it easier and clearer specify to not listen anywhere in order to start a guest with OpenGL support. The old way to do this was set spice graphics autoport='no' and don't specify any ports. The new way is

[libvirt] [PATCH v5 2/6] qemu_capabilites: add QEMU_CAPS_SPICE_UNIX

2016-05-24 Thread Pavel Hrdina
Add a new capability to detect support of unix sockets for spice graphics. Signed-off-by: Pavel Hrdina --- src/qemu/qemu_capabilities.c | 3 +++ src/qemu/qemu_capabilities.h | 3 +++ tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml | 1

[libvirt] [PATCH v5 6/6] vnc: add support for listen type none

2016-05-24 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- docs/formatdomain.html.in | 3 ++- src/conf/domain_conf.c | 3 ++- src/qemu/qemu_command.c| 3 +++ .../qemuxml2argv-graphics-vnc-none.args| 20

Re: [libvirt] [PATCH v3 13/13] Enable PCI Multifunction hotplug/unplug

2016-05-24 Thread Nikunj A Dadhania
Shivaprasad G Bhat writes: > The flow is to parse and create a list of devices and pass onto the > hotplug functions. > > The patch also removes all checks forbidding the multifunction hotplug. > > Signed-off-by: Shivaprasad G Bhat > --- >

Re: [libvirt] [PATCH] lxc: use job functions in lxcDomainLxcOpenNamespace & lxcDomainSendProcessSignal

2016-05-24 Thread Michal Privoznik
On 20.05.2016 17:15, Katerina Koukiou wrote: > Use the recently added job functions in lxcDomainLxcOpenNamespace, > lxcDomainSendProcessSignal. > > Signed-off-by: Katerina Koukiou > --- > src/lxc/lxc_driver.c | 31 --- > 1 file changed, 24

Re: [libvirt] [PATCH v3 12/13] Pass virDomainDeviceDefListPtr to hotplug functions

2016-05-24 Thread Nikunj A Dadhania
Shivaprasad G Bhat writes: > This actually does all the things as though there were more than one > device in list. > > Signed-off-by: Shivaprasad G Bhat > --- > src/qemu/qemu_domain.c | 50 +++--- > src/qemu/qemu_domain.h

[libvirt] [PATCH v2] qemucapstest: replace caps-1.6.50 with updated caps-1.7.0

2016-05-24 Thread Pavel Hrdina
The qemu-1.6.50 is a beta before the new minor version, let's replace it with the release qemu-1.7.0. Signed-off-by: Pavel Hrdina --- tests/domaincapsschemadata/qemu_1.6.50.x86_64.xml | 78 - tests/domaincapsschemadata/qemu_1.7.0.x86_64.xml | 78 +

Re: [libvirt] [PATCH 10/10] qemucapstest: remove data for qemu-1.6.50

2016-05-24 Thread Pavel Hrdina
On Tue, May 24, 2016 at 02:21:54PM +0200, Jiri Denemark wrote: > On Mon, May 23, 2016 at 09:41:46 +0200, Pavel Hrdina wrote: > > This is not a release version and replacing it with qemu-1.6.1 doesn't > > make sense because there was no difference in replies between those two > > versions. I've

Re: [libvirt] [PATCH v3 11/13] Move the detach of PCI device to the beginnging of live hotplug

2016-05-24 Thread Nikunj A Dadhania
Shivaprasad G Bhat writes: > The hostdevices are the only devices which have dependencies > outside of themselves such that, other functions of the PCI > card should also have been detached from host driver before > attempting the hotplug. > > This patch moves the

Re: [libvirt] [PATCH 09/10] qemucapstest: update caps for qemu-2.6.0

2016-05-24 Thread Jiri Denemark
On Mon, May 23, 2016 at 09:41:45 +0200, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > tests/domaincapsschemadata/qemu_2.6.0.x86_64.xml |2 +- > .../qemucapabilitiesdata/caps_2.6.0.x86_64.replies | 1877 > >

Re: [libvirt] [PATCH 08/10] qemucapstest: update caps for qemu-2.5.0

2016-05-24 Thread Jiri Denemark
On Mon, May 23, 2016 at 09:41:44 +0200, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > .../qemucapabilitiesdata/caps_2.5.0.x86_64.replies | 1587 > +++- > tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml | 14 +- > 2 files changed, 906

Re: [libvirt] [PATCH 8/9] target-i386: Use "-" instead of "_" on all feature names

2016-05-24 Thread Igor Mammedov
On Tue, 24 May 2016 09:34:05 -0300 Eduardo Habkost wrote: > On Tue, May 24, 2016 at 02:17:03PM +0200, Igor Mammedov wrote: > > On Fri, 6 May 2016 15:11:31 -0300 > > Eduardo Habkost wrote: > > > > > This makes the feature name tables in

[libvirt] [PATCH 3/7] qemu: Move and rename qemuDomainCheckEjectableMedia to qemuProcessRefreshDisks

2016-05-24 Thread Peter Krempa
Move it to a more sane place since it's refreshing data about disks. --- src/qemu/qemu_hotplug.c | 48 src/qemu/qemu_hotplug.h | 3 --- src/qemu/qemu_migration.c | 2 +- src/qemu/qemu_process.c | 56 ---

[libvirt] [PATCH 2/7] qemu: Extract more information about qemu drives

2016-05-24 Thread Peter Krempa
Extract whether a given drive has a tray and whether there is no image inserted. Negative logic for the image insertion is chosen so that the flag is set only if we are certain of the fact. --- src/qemu/qemu_domain.h | 2 ++ src/qemu/qemu_monitor_json.c | 12 +++-

[libvirt] [PATCH 5/7] qemu: hotplug: Extract code for waiting for tray eject

2016-05-24 Thread Peter Krempa
The code grew rather convoluted. Extract it to a separate function. --- src/qemu/qemu_hotplug.c | 85 ++--- 1 file changed, 46 insertions(+), 39 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 286a4a4..4c3f7da 100644

[libvirt] [PATCH 7/7] qemu: hotplug: wait for the tray to eject only for drives with a tray

2016-05-24 Thread Peter Krempa
Use the detected tray presence flag to trigger the tray waiting code only if the given storage device in qemu reports to have a tray. This is necessary as the floppy device lost it's tray as of qemu commit: commit abb3e55b5b718d6392441f56ba0729a62105ac56 Author: Max Reitz

[libvirt] [PATCH 4/7] qemu: process: Fix and improve disk data extraction

2016-05-24 Thread Peter Krempa
Extract information for all disks and update tray state and source only for removable drives. Additionally store whether a drive is removable and whether it has a tray. --- src/qemu/qemu_domain.h | 4 src/qemu/qemu_monitor.c | 18 -- src/qemu/qemu_monitor.h | 3 ---

[libvirt] [PATCH 6/7] qemu: hotplug: Fix error reported when cdrom tray is locked

2016-05-24 Thread Peter Krempa
Commit 1fad65d49aae364576bd91352a001249510f8d4e used a really big hammer and overwrote the error message that might be reported by qemu if the tray is locked. Fix it by reporting the error only if no error is currently set. Error after commit mentioned above: error: internal error: timed out

[libvirt] [PATCH 0/7] qemu: Fix removable devices without a tray

2016-05-24 Thread Peter Krempa
Peter Krempa (7): qemu: Move struct qemuDomainDiskInfo to qemu_domain.h qemu: Extract more information about qemu drives qemu: Move and rename qemuDomainCheckEjectableMedia to qemuProcessRefreshDisks qemu: process: Fix and improve disk data extraction qemu: hotplug: Extract code for

[libvirt] [PATCH 1/7] qemu: Move struct qemuDomainDiskInfo to qemu_domain.h

2016-05-24 Thread Peter Krempa
--- src/qemu/qemu_conf.h| 7 --- src/qemu/qemu_domain.h | 7 +++ tests/qemumonitorjsontest.c | 2 +- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/qemu/qemu_conf.h b/src/qemu/qemu_conf.h index a714b84..1fdef70 100644 --- a/src/qemu/qemu_conf.h +++

Re: [libvirt] [PATCH 06/10] qemucapstest: update caps for qemu-2.1.1

2016-05-24 Thread Jiri Denemark
On Mon, May 23, 2016 at 09:41:42 +0200, Pavel Hrdina wrote: > --- > .../qemucapabilitiesdata/caps_2.1.1.x86_64.replies | 665 > - > tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml | 2 - > 2 files changed, 381 insertions(+), 286 deletions(-) ACK Jirka -- libvir-list

Re: [libvirt] [PATCH 07/10] qemucapstest: update caps for qemu-2.4.0

2016-05-24 Thread Jiri Denemark
On Mon, May 23, 2016 at 09:41:43 +0200, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > .../qemucapabilitiesdata/caps_2.4.0.x86_64.replies | 411 > - > tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml | 1 + > 2 files changed, 228

Re: [libvirt] [PATCH 05/10] qemucapstest: update caps for qemu-1.6.0

2016-05-24 Thread Jiri Denemark
On Mon, May 23, 2016 at 09:41:41 +0200, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > .../qemucapabilitiesdata/caps_1.6.0.x86_64.replies | 5244 > ++-- > tests/qemucapabilitiesdata/caps_1.6.0.x86_64.xml |5 +- > 2 files changed, 2682

Re: [libvirt] [PATCH 04/10] qemucapstest: update caps for qemu-1.5.3

2016-05-24 Thread Jiri Denemark
On Mon, May 23, 2016 at 09:41:40 +0200, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > .../qemucapabilitiesdata/caps_1.5.3.x86_64.replies | 5245 > ++-- > tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml |4 + > 2 files changed, 2696

Re: [libvirt] [PATCH 03/10] qemucapstest: update caps for qemu-1.4.2

2016-05-24 Thread Jiri Denemark
On Mon, May 23, 2016 at 09:41:39 +0200, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > .../qemucapabilitiesdata/caps_1.4.2.x86_64.replies | 4050 > ++-- > tests/qemucapabilitiesdata/caps_1.4.2.x86_64.xml |5 +- > 2 files changed, 2067

Re: [libvirt] [PATCH 01/10] qemucapstest: update caps for qemu-1.2.2

2016-05-24 Thread Jiri Denemark
On Mon, May 23, 2016 at 09:41:37 +0200, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > .../qemucapabilitiesdata/caps_1.2.2.x86_64.replies | 3483 > ++-- > tests/qemucapabilitiesdata/caps_1.2.2.x86_64.xml |2 - > 2 files changed, 1770

Re: [libvirt] [PATCH 02/10] qemucapstest: update caps for qemu-1.3.1

2016-05-24 Thread Jiri Denemark
On Mon, May 23, 2016 at 09:41:38 +0200, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > .../qemucapabilitiesdata/caps_1.3.1.x86_64.replies | 3943 > ++-- > tests/qemucapabilitiesdata/caps_1.3.1.x86_64.xml |5 +- > 2 files changed, 2017

Re: [libvirt] [PATCH 8/9] target-i386: Use "-" instead of "_" on all feature names

2016-05-24 Thread Eduardo Habkost
On Tue, May 24, 2016 at 02:17:03PM +0200, Igor Mammedov wrote: > On Fri, 6 May 2016 15:11:31 -0300 > Eduardo Habkost wrote: > > > This makes the feature name tables in feature_word_info all match > > the actual QOM property names we use. > > > > This will make the

Re: [libvirt] [PATCH] nwfilter: fix lock order deadlock

2016-05-24 Thread Maxim Nestratov
24.05.2016 13:56, Stefan Berger пишет: On 05/24/2016 03:22 AM, Maxim Nestratov wrote: 20.04.2016 22:04, Stefan Berger пишет: On 04/20/2016 12:06 PM, Laine Stump wrote: On 04/19/2016 05:45 PM, Cole Robinson wrote: On 04/09/2016 12:14 PM, Maxim Nestratov wrote: Below is backtraces of two

Re: [libvirt] [PATCH 10/10] qemucapstest: remove data for qemu-1.6.50

2016-05-24 Thread Jiri Denemark
On Mon, May 23, 2016 at 09:41:46 +0200, Pavel Hrdina wrote: > This is not a release version and replacing it with qemu-1.6.1 doesn't > make sense because there was no difference in replies between those two > versions. I've used qemu-1.6.0 in appropriate places. Well, 1.6.50 is a git snapshot

Re: [libvirt] [PATCH 8/9] target-i386: Use "-" instead of "_" on all feature names

2016-05-24 Thread Igor Mammedov
On Fri, 6 May 2016 15:11:31 -0300 Eduardo Habkost wrote: > This makes the feature name tables in feature_word_info all match > the actual QOM property names we use. > > This will make the command-line interface more consistent, > allowing the QOM property names to be used

Re: [libvirt] [PATCH v3 03/13] Introduce PCI Multifunction device parser

2016-05-24 Thread Nikunj A Dadhania
Shivaprasad G Bhat writes: > This patch just introduces the parser function used by > the later patches. The parser disallows hostdevices to be > used with other virtio devices simultaneously. > > Signed-off-by: Shivaprasad G Bhat > --- >

Re: [libvirt] [PATCH] maint: fix syntax-check sc_prohibit_int_ijk exclude rule

2016-05-24 Thread Pavel Hrdina
On Tue, May 24, 2016 at 11:42:11AM +0200, Andrea Bolognani wrote: > On Tue, 2016-05-24 at 09:41 +0200, Pavel Hrdina wrote: > > This fixes the "include/" path, we need to create a regex for the whole path > > because we are matching the whole line. > > > > Signed-off-by: Pavel Hrdina

Re: [libvirt] [PATCH 2/2] makefile: fix build on systems where gnutls is not in /usr/include

2016-05-24 Thread Pavel Hrdina
On Tue, May 24, 2016 at 11:16:17AM +0200, Michal Privoznik wrote: > On 23.05.2016 17:39, Michal Privoznik wrote: > > On 23.05.2016 17:06, Pavel Hrdina wrote: > >> On Mon, May 23, 2016 at 04:42:43PM +0200, Michal Privoznik wrote: > >>> On 23.05.2016 10:18, Pavel Hrdina wrote: > We need to

Re: [libvirt] [PATCH 1/2] nodedev: sysfs: Set PCI_PHYSICAL_FUNCTION flag more carefully

2016-05-24 Thread Andrea Bolognani
On Mon, 2016-05-23 at 15:21 -0400, Laine Stump wrote: > On 05/23/2016 07:53 AM, Andrea Bolognani wrote: > >  > > The flag was set if virPCIGetPhysicalFunction() did not return > > an error; unfortunately, the 'physfn' sysfs file not being > > present is not considered an error, which means that

[libvirt] [PATCH v2 0/2] Don't crash in virNodeDeviceDefFormat()

2016-05-24 Thread Andrea Bolognani
Changes from [v1]: * fix all callers of virPCIGetPhysicalFunction() * document virPCIGetPhysicalFunction() [v1] https://www.redhat.com/archives/libvir-list/2016-May/msg01681.html Andrea Bolognani (2): Document virPCIGetPhysicalFunction() and fix its callers conf: nodedev: Set

[libvirt] [PATCH v2 2/2] conf: nodedev: Set PCI_PHYSICAL_FUNCTION flag more carefully

2016-05-24 Thread Andrea Bolognani
Instead of setting the flag before parsing the PCI address, set it afterwards. This ensure we can never end up in a situation where the flag has been set but pci_dev.physical_function has not been filled in. --- src/conf/node_device_conf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[libvirt] [PATCH v2 1/2] Document virPCIGetPhysicalFunction() and fix its callers

2016-05-24 Thread Andrea Bolognani
Commit c8b1a83605e4 changed the function, making it impossible for callers to be able to tell whether a non-negative return value means "physical function address found and parsed correctly" or "couldn't find corresponding physical function". The important difference between the two being that,

Re: [libvirt] [PATCH] nwfilter: fix lock order deadlock

2016-05-24 Thread Stefan Berger
On 05/24/2016 03:22 AM, Maxim Nestratov wrote: 20.04.2016 22:04, Stefan Berger пишет: On 04/20/2016 12:06 PM, Laine Stump wrote: On 04/19/2016 05:45 PM, Cole Robinson wrote: On 04/09/2016 12:14 PM, Maxim Nestratov wrote: Below is backtraces of two deadlocked threads: thread #1:

[libvirt] [PATCH] xenconfig: xm: check for driver on disk format

2016-05-24 Thread Joao Martins
When reviewing libxl vif typename series[0] I found out a bug on xen-xm formatter where this "virsh domxml-to-native xen-xm file.xml" can lead to a NULL dereference if the disk driver isn't specified. Fix this by checking for driver before writing/testing it down. [0]

Re: [libvirt] [PATCH] maint: fix syntax-check sc_prohibit_int_ijk exclude rule

2016-05-24 Thread Andrea Bolognani
On Tue, 2016-05-24 at 09:41 +0200, Pavel Hrdina wrote: > This fixes the "include/" path, we need to create a regex for the whole path > because we are matching the whole line. > > Signed-off-by: Pavel Hrdina > --- > > I'm surprised that it even worked so far.  I've noticed

[libvirt] Plan for the next release

2016-05-24 Thread Daniel Veillard
I will be travelling end of this week and most of next week, but I think we can still try to get a release for June 1st, I suggest: - enter freeze this Thrusday 26 - Push an rc2 over the week-end - try to push the 1.3.5 release on Wed June 1st I hope this works for everybody !

Re: [libvirt] [PATCH 2/2] makefile: fix build on systems where gnutls is not in /usr/include

2016-05-24 Thread Michal Privoznik
On 23.05.2016 17:39, Michal Privoznik wrote: > On 23.05.2016 17:06, Pavel Hrdina wrote: >> On Mon, May 23, 2016 at 04:42:43PM +0200, Michal Privoznik wrote: >>> On 23.05.2016 10:18, Pavel Hrdina wrote: We need to append GNUTLS_CFLAGS while building utils because virtcrypto is using it.

[libvirt] [PATCH] maint: fix syntax-check sc_prohibit_int_ijk exclude rule

2016-05-24 Thread Pavel Hrdina
This fixes the "include/" path, we need to create a regex for the whole path because we are matching the whole line. Signed-off-by: Pavel Hrdina --- I'm surprised that it even worked so far. I've noticed this after system update few days ago. cfg.mk | 2 +- 1 file

Re: [libvirt] [PATCH] nwfilter: fix lock order deadlock

2016-05-24 Thread Maxim Nestratov
20.04.2016 22:04, Stefan Berger пишет: On 04/20/2016 12:06 PM, Laine Stump wrote: On 04/19/2016 05:45 PM, Cole Robinson wrote: On 04/09/2016 12:14 PM, Maxim Nestratov wrote: Below is backtraces of two deadlocked threads: thread #1: virDomainConfVMNWFilterTeardown