Re: [libvirt] [PATCH] maint: update to latest gnulib

On 05/26/2016 09:52 AM, Eric Blake wrote: > Pulls in several portability fixes, including the fact that gnulib > now only works on platforms with two's complement signed integers. > Also makes for a smaller delta on the next update (we are waiting > on a license change to unsetenv for the sake of

[libvirt] [PATCH 2/3] storage: Split out setting default secret for encryption

Split the qcow setting of encryption secrets into a helper Signed-off-by: John Ferlan --- src/storage/storage_backend_fs.c | 79 +--- 1 file changed, 49 insertions(+), 30 deletions(-) diff --git a/src/storage/storage_backend_fs.c

[libvirt] [PATCH 3/3] storage: Split out a helper for encryption checks

Split out a helper from virStorageBackendCreateQemuImgCmdFromVol to check the encryption - soon a new encryption sheriff will be patroling and that'll mean all sorts of new checks. Signed-off-by: John Ferlan --- src/storage/storage_backend.c | 80

[libvirt] [PATCH 1/3] util: Clean up code formatting in virstorageencryption

Bring style more in line with more recent code. Signed-off-by: John Ferlan --- src/util/virstorageencryption.c | 58 +++-- 1 file changed, 27 insertions(+), 31 deletions(-) diff --git a/src/util/virstorageencryption.c

[libvirt] [PATCH 0/3] Clean up some virstorageencryption code

While working through adding luks support for libvirt, I have a few patches that aren't really germane to adding support and rather than drop a large patch series when I'm done - I figured I'd post a few adjustments. In the long run the encryption code probably doesn't work, but I'm trying to

[libvirt] New account at Wiki

Hello! Can I have an account for wiki? I ask here because I am following http://wiki.libvirt.org/page/Main_Page#libvirt_Wiki preferred username: arjamizo Thanks! BR Artur -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv2] network: Added hook for network modification event

On 05/25/2016 08:21 AM, Khramov Anton wrote: > From: Anton Khramov > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1181539 > --- > docs/hooks.html.in | 2 ++ > src/network/bridge_driver.c | 5 + > src/util/virhook.c | 3 ++- >

Re: [libvirt] [PATCH v2] esx: do not store escaped password in esxVI_Context.

On 26.05.2016 17:30, Dawid Zamirski wrote: > This patch fixes an issue where screenshot API call was failing when > the esx/vcenter password contains special characters such as > apostrophee. The reason for failures was that passwords were escaped > for XML and stored in esxVI_Context which was

[libvirt] [libvirt-perl][PATCH 0/2] Catch up with latest libvirt

Two public constants are to be introduced in libvirt. While touching that are of code, update documentation to a constant of the same origin. Michal Privoznik (2): Add PERF_PARAM_MBML and PERF_PARAM_MBMT constants Expand description for PERF_PARAM_CMT constant Changes| 1 +

[libvirt] [libvirt-perl][PATCH 2/2] Expand description for PERF_PARAM_CMT constant

Signed-off-by: Michal Privoznik --- lib/Sys/Virt/Domain.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/Sys/Virt/Domain.pm b/lib/Sys/Virt/Domain.pm index 0a5e89f..6655b49 100644 --- a/lib/Sys/Virt/Domain.pm +++ b/lib/Sys/Virt/Domain.pm @@

Re: [libvirt] [PATCH] testutils.c: unsetenv() iff platform has it

On 26.05.2016 17:54, Eric Blake wrote: > On 05/26/2016 09:40 AM, Michal Privoznik wrote: >> I've encountered the following problem (introduced by 6326865e): >> >> ../../tests/testutils.c: In function 'virtTestRun': >> ../../tests/testutils.c:289:5: error: implicit declaration of function >>

[libvirt] [libvirt-perl][PATCH 1/2] Add PERF_PARAM_MBML and PERF_PARAM_MBMT constants

Signed-off-by: Michal Privoznik --- Changes| 1 + Virt.xs| 2 ++ lib/Sys/Virt/Domain.pm | 12 3 files changed, 15 insertions(+) diff --git a/Changes b/Changes index 45c49f2..8a94eb1 100644 --- a/Changes +++ b/Changes @@ -3,6

Re: [libvirt] [PATCH] testutils.c: unsetenv() iff platform has it

On 05/26/2016 09:40 AM, Michal Privoznik wrote: > I've encountered the following problem (introduced by 6326865e): > > ../../tests/testutils.c: In function 'virtTestRun': > ../../tests/testutils.c:289:5: error: implicit declaration of function > 'unsetenv' [-Werror=implicit-function-declaration]

[libvirt] [PATCH] maint: update to latest gnulib

Pulls in several portability fixes, including the fact that gnulib now only works on platforms with two's complement signed integers. Also makes for a smaller delta on the next update (we are waiting on a license change to unsetenv for the sake of mingw). * .gnulib: Update to latest. * bootstrap:

[libvirt] [PATCH] testutils.c: unsetenv() iff platform has it

I've encountered the following problem (introduced by 6326865e): ../../tests/testutils.c: In function 'virtTestRun': ../../tests/testutils.c:289:5: error: implicit declaration of function 'unsetenv' [-Werror=implicit-function-declaration] unsetenv("VIR_TEST_MOCK_TESTNAME"); Apparently,

[libvirt] [PATCH v2] esx: do not store escaped password in esxVI_Context.

This patch fixes an issue where screenshot API call was failing when the esx/vcenter password contains special characters such as apostrophee. The reason for failures was that passwords were escaped for XML and stored in esxVI_Context which was then passed to raw CURL API calls where the password

[libvirt] [PATCH v2 12/19] tests: Rename virtTestDifferenceFullNoRegenerate.

This function doesn't follow our convention of naming functions. --- tests/qemuxml2xmltest.c | 6 +++--- tests/testutils.c | 16 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c index 7b01587..ebf5a99 100644

[libvirt] [PATCH v2 11/19] tests: Rename virtTestQuiesceLibvirtErrors to virTestQuiesceLibvirtErrors.

This function doesn't follow our convention of naming functions. --- tests/esxutilstest.c| 2 +- tests/metadatatest.c| 2 +- tests/objecteventtest.c | 2 +- tests/sockettest.c | 2 +- tests/testutils.c | 2 +- tests/testutils.h | 2 +- tests/utiltest.c| 2 +- 7

[libvirt] [PATCH v2 04/19] tests: Rename virtTestCompareToFile to virTestCompareToFile.

This function doesn't follow our convention of naming functions. --- tests/bhyvexml2argvtest.c| 6 +++--- tests/cputest.c | 2 +- tests/domaincapstest.c | 2 +- tests/lxcconf2xmltest.c | 2 +- tests/networkxml2conftest.c | 2 +-

[libvirt] [PATCH v2 16/19] tests: Rename virtTestCaptureProgramOutput to virTestCaptureProgramOutput.

This function doesn't follow our convention of naming functions. --- tests/testutils.c | 8 tests/testutils.h | 2 +- tests/virshtest.c | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/testutils.c b/tests/testutils.c index 39a..32a7ee2 100644 ---

[libvirt] [PATCH v2 10/19] tests: Rename virtTestUseTerminalColors to virTestUseTerminalColors.

This function doesn't follow our convention of naming functions. --- tests/testutils.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/testutils.c b/tests/testutils.c index ee13ab1..a8cb2f6 100644 --- a/tests/testutils.c +++ b/tests/testutils.c @@ -89,7 +89,7 @@

[libvirt] [PATCH v2 09/19] tests: Rename virtTestLogContentAndReset to virTestLogContentAndReset.

This function doesn't follow our convention of naming functions. --- tests/cputest.c | 4 ++-- tests/qemuargv2xmltest.c | 2 +- tests/qemuxml2argvtest.c | 4 ++-- tests/testutils.c| 2 +- tests/testutils.h| 2 +- 5 files changed, 7 insertions(+), 7 deletions(-) diff

[libvirt] [PATCH v2 14/19] tests: Rename virtTestCaptureProgramExecChild to virTestCaptureProgramExecChild.

This function doesn't follow our convention of naming functions. --- tests/testutils.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/testutils.c b/tests/testutils.c index b97e97a..34f2410 100644 --- a/tests/testutils.c +++ b/tests/testutils.c @@ -351,8 +351,8 @@

[libvirt] [PATCH v2 05/19] Rename virtTestDifferenceFull to virTestDifferenceFull.

This function doesn't follow our convention of naming functions. --- tests/domainsnapshotxml2xmltest.c | 2 +- tests/interfacexml2xmltest.c | 2 +- tests/nodedevxml2xmltest.c| 2 +- tests/qemuhotplugtest.c | 6 +++--- tests/testutils.c | 16

[libvirt] [PATCH v2 13/19] tests: Rename virtTestDifferenceFullInternal to virTestDifferenceFullInternal.

This function doesn't follow our convention of naming functions. --- tests/testutils.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/tests/testutils.c b/tests/testutils.c index 79981fe..b97e97a 100644 --- a/tests/testutils.c +++ b/tests/testutils.c @@

[libvirt] [PATCH v2 07/19] tests: Rename virtTest00MActive to virTest00MActive.

This function doesn't follow our convention of naming functions. --- tests/qemuargv2xmltest.c | 2 +- tests/qemuxml2argvtest.c | 2 +- tests/testutils.c| 2 +- tests/testutils.h| 2 +- tests/virfirewalltest.c | 8 5 files changed, 8 insertions(+), 8 deletions(-) diff

[libvirt] [PATCH v2 17/19] tests: Rename virtTestCounterNext to virTestCounterNext.

This function doesn't follow our convention of naming functions. --- tests/qemucommandutiltest.c | 2 +- tests/testutils.c | 6 +++--- tests/testutils.h | 2 +- tests/virbitmaptest.c | 2 +- tests/virfiletest.c | 2 +- tests/virstoragetest.c | 2 +- 6 files

[libvirt] [PATCH v2 06/19] tests: Rename virtTestClearCommandPath to virTestClearCommandPath.

This function doesn't follow our convention of naming functions. --- tests/networkxml2firewalltest.c | 2 +- tests/nwfilterebiptablestest.c | 14 +++--- tests/nwfilterxml2firewalltest.c | 2 +- tests/testutils.c| 2 +- tests/testutils.h| 2 +- 5

[libvirt] [PATCH v2 03/19] Rename virtTestLoadFile to virTestLoadFile.

This function doesn't follow our convention of naming functions. --- tests/domainsnapshotxml2xmltest.c | 4 ++-- tests/interfacexml2xmltest.c | 2 +- tests/lxcconf2xmltest.c | 2 +- tests/networkxml2xmlupdatetest.c | 2 +- tests/nodedevxml2xmltest.c| 2 +-

[libvirt] [PATCH v2 18/19] tests: Rename virtTestErrorFuncQuiet to virTestErrorFuncQuiet.

This function doesn't follow our convention of naming functions. --- tests/testutils.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/testutils.c b/tests/testutils.c index a979f63..5cff5d8 100644 --- a/tests/testutils.c +++ b/tests/testutils.c @@ -719,8 +719,8 @@

[libvirt] [PATCH v2 08/19] tests: Rename virtTestCounterReset to virTestCounterReset.

This function doesn't follow our convention of naming functions. --- tests/qemucommandutiltest.c | 2 +- tests/testutils.c | 6 +++--- tests/testutils.h | 2 +- tests/virbitmaptest.c | 2 +- tests/virfiletest.c | 2 +- tests/virstoragetest.c | 2 +- 6 files

[libvirt] [PATCH v2 15/19] tests: Rename virtTestDifferenceBin to virTestDifferenceBin.

This function doesn't follow our convention of naming functions. --- tests/testutils.c | 8 tests/testutils.h | 8 tests/virnetmessagetest.c | 6 +++--- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/tests/testutils.c b/tests/testutils.c index

[libvirt] [PATCH v2 02/19] Rename virtTestDifference to virTestDifference.

This function doesn't follow our convention of naming functions. --- tests/commandtest.c| 16 tests/esxutilstest.c | 8 tests/jsontest.c | 6 +++--- tests/nwfilterebiptablestest.c | 14 +++--- tests/openvzutilstest.c|

[libvirt] [PATCH v2 00/19] Drop virt prefix from tests.

Replacig virt prefix with vir prefix in tests. It was suggested on wikipage: http://wiki.libvirt.org/page/BiteSizedTasks#Rename_test_suite_routines_from_virtTest.2A_to_virTest.2A Tomáš Ryšavý (19): tests: Rename virtTestRun to virTestRun. Rename virtTestDifference to virTestDifference.

[libvirt] [PATCH v2 19/19] tests: Rename virtTestMain to virTestMain.

This function doesn't follow our convention of naming functions. --- tests/testutils.c | 8 tests/testutils.h | 12 ++-- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/tests/testutils.c b/tests/testutils.c index 5cff5d8..bc17ea7 100644 --- a/tests/testutils.c

[libvirt] [PATCH] unsetenv: relax to LGPLv2+

Especially since setenv is also LGPLv2+, and it makes sense for the two modules to stay in sync. Signed-off-by: Eric Blake --- Libvirt wants LGPLv2+ when it uses gnulib, and recently ran into a problem where it can use the setenv module for mingw but not the unsetenv module.

Re: [libvirt] [PATCH] qemu: Fix error message when PCI bridge has index <= bus

On Thu, 2016-05-26 at 09:51 -0400, Laine Stump wrote: > On 05/23/2016 12:00 PM, Andrea Bolognani wrote: > >  > > Commit ff2126225df0 changed the error message to be more > > detailed about the failure at hand; however, while the new > > error message claims that "bus must be <= index", the error >

Re: [libvirt] inconsistent handling of "qemu64" CPU model

On 05/26/2016 04:41 AM, Jiri Denemark wrote: The qemu64 CPU model contains svm and thus libvirt will always consider it incompatible with any Intel CPUs (which have vmx instead of svm). On the other hand, QEMU by default ignores features that are missing in the host CPU and has no problem using

Re: [libvirt] [PATCH] qemu: Fix error message when PCI bridge has index <= bus

On 05/23/2016 12:00 PM, Andrea Bolognani wrote: Commit ff2126225df0 changed the error message to be more detailed about the failure at hand; however, while the new error message claims that "bus must be <= index", the error message is displayed if "idx <= addr->bus", ie. when bus is bigger than

Re: [libvirt] [PATCH 8/8] lxc: use job functions in lxcDomain* functions that perform modify actions.

On Tue, May 17, 2016 at 12:36:54AM +0300, Katerina Koukiou wrote: > Use the recently added job functions and unlock the virDomainObj while > performing the respective modify operation. > This commit affects lxcDomain{DestroyFlags, Reboot, SetBlkioParameters, > SetMemoryParameters, SetMetadata,

Re: [libvirt] [PATCH] daemon: cleanup state drivers in order reverse to init order

On 05/26/2016 03:56 AM, Nikolay Shirokovskiy wrote: > Ping. Cole ACKed already, probably patch need extra reviwers. > Sorry I thought you had commit access... I've pushed now Thanks, Cole > On 17.05.2016 14:44, Nikolay Shirokovskiy wrote: >> This patch aims to fix observed crash on daemon

Re: [libvirt] [PATCH 3/3] esx: use newer virtualHW version for 5.1+ hosts

2016-05-23 23:22 GMT+02:00 Dawid Zamirski : > This is because there's a known issue where ESX will refuse to attach > drives bigger than 4TB when virtualHW < 9. Therefore, to avoid that > use the higher virtualHW for hosts that support it. > > --- >

[libvirt] [PATCH 4/4] vz: return correct result for unimplemented ChangeState actions

Map PRL_ERR_UNIMPLEMENTED to VIR_ERR_OPERATION_INVALID Signed-off-by: Maxim Nestratov --- src/vz/vz_sdk.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c index bad4ddd..94ed35e 100644 --- a/src/vz/vz_sdk.c +++ b/src/vz/vz_sdk.c @@

[libvirt] [PATCH 0/4] vz: error processing fixes

Maxim Nestratov (4): vz: remove unused macro logPrlEventError vz: return event error code in logPrlEventErrorHelper and use it vz: fix getJobResultHelper vz: return correct result for unimplemented ChangeState actions src/vz/vz_sdk.c | 20 +++- 1 file changed, 11

[libvirt] [PATCH 2/4] vz: return event error code in logPrlEventErrorHelper and use it

If PrlEvent_GetErrCode returns an error code this is what we should use as an error code for the whole action Signed-off-by: Maxim Nestratov --- src/vz/vz_sdk.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/vz/vz_sdk.c

Re: [libvirt] inconsistent handling of "qemu64" CPU model

On Wed, May 25, 2016 at 23:13:24 -0600, Chris Friesen wrote: > Hi, > > If I don't specify a virtual CPU model, it appears to give me a "qemu64" CPU, > and /proc/cpuinfo in the guest instance looks something like this: > > processor 0 > vendor_id GenuineIntel > cpu family 6 > model 6 > model

[libvirt] [PATCH 3/4] vz: fix getJobResultHelper

when additional information is asked PrlJob_GetError an error PRL_ERR_NO_DATA should not be treated as error Signed-off-by: Maxim Nestratov --- src/vz/vz_sdk.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c index

[libvirt] [PATCH 1/4] vz: remove unused macro logPrlEventError

Signed-off-by: Maxim Nestratov --- src/vz/vz_sdk.c | 4 1 file changed, 4 deletions(-) diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c index 7eb78ca..e5c56a5 100644 --- a/src/vz/vz_sdk.c +++ b/src/vz/vz_sdk.c @@ -138,10 +138,6 @@ logPrlEventErrorHelper(PRL_HANDLE

Re: [libvirt] inconsistent handling of "qemu64" CPU model

On Wed, May 25, 2016 at 11:13:24PM -0600, Chris Friesen wrote: [...] > However, if I explicitly specify a custom CPU model of "qemu64" the > instance refuses to boot and I get a log saying: [Not a direct answer to the exact issue you're facing, but a related issue that is being investigated

Re: [libvirt] [PATCH 2/3] esx: Add VMCI device for virtualHW >= 7

2016-05-23 23:22 GMT+02:00 Dawid Zamirski : > This patch fixes an issue where vMotion fails when VMCI device is not > present in the vmx file. > --- > src/vmx/vmx.c | 2 ++ > tests/xml2vmxdata/xml2vmx-fusion-in-the-wild-1.vmx | 1 + >

Re: [libvirt] Question on output of virsh capabilities

On Thu, May 26, 2016 at 16:44:47 +0800, Eli Qiao wrote: > hi > I am confused by the libvirt's "virsh capabilities" > > help said: > >DESCRIPTION > Returns capabilities of hypervisor/driver. > I got follow outtput of a host. > > >x86_64 >Broadwell-noTSX >

Re: [libvirt] [PATCH 1/3] esx: add pciBridge devices when SCSI is used

2016-05-23 23:22 GMT+02:00 Dawid Zamirski : > When a SCSI controller is present, ESX adds several pciBridge devices > to vmx file. This fixes an error message where it refuses to create VM > due to not enough PCI devices available. This applies only to virtualHW > version >=

[libvirt] Question on output of virsh capabilities

hi I am confused by the libvirt's "virsh capabilities" help said: DESCRIPTION Returns capabilities of hypervisor/driver. I got follow outtput of a host. x86_64 Broadwell-noTSX Intel

Re: [libvirt] [PATCH] daemon: cleanup state drivers in order reverse to init order

Ping. Cole ACKed already, probably patch need extra reviwers. On 17.05.2016 14:44, Nikolay Shirokovskiy wrote: > This patch aims to fix observed crash on daemon shutdown. Main thread is in > the process of state drivers cleanup, network driver is cleaned up and > qemu driver is not yet. Meanwhile

Re: [libvirt] [PATCH 00/19] Drop virt prefix from tests

On Wed, May 25, 2016 at 03:08:24PM +0200, Tomáš Ryšavý wrote: > Replacig virt prefix with vir prefix in tests. It was suggested on wikipage: A lot of patches have a wrong indentation after the rename. Fix that please and send a v2. Thanks, Pavel -- libvir-list mailing list

Re: [libvirt] [PATCH] esx: do not store escaped password in esxVI_Context.

2016-05-23 23:32 GMT+02:00 Dawid Zamirski : > This patch fixes an issue where screenshot API call was failing when > the esx/vcenter password contains special characters such as > apostrophee. The reason for failures was that passwords were escaped > for XML and stored in