[libvirt] [PATCH 1/1] perf: add more perf events support

2016-05-30 Thread Qiaowei Ren
With current perf framework, this patch adds support to more perf events, including cache missing, cache peference, cpu cycles, instrction, etc.. Signed-off-by: Qiaowei Ren --- include/libvirt/libvirt-domain.h | 39 src/libvirt-domain.c

Re: [libvirt] [ovs-dev] [PATCH v2 2/2] netdev-dpdk: Support user-defined socket attribs

2016-05-30 Thread Ansis Atteka
On Mon, May 30, 2016 at 12:29 AM, Christian Ehrhardt wrote: > On Tue, May 24, 2016 at 4:10 PM, Aaron Conole wrote: > >> Daniele Di Proietto writes: >> >> > Hi Aaron, >> > >> > I'm still a little bit nervous about

Re: [libvirt] [PATCH 0/2] Yet another round of build fixes

2016-05-30 Thread Michal Privoznik
On 30.05.2016 16:56, Peter Krempa wrote: > On Mon, May 30, 2016 at 15:53:08 +0200, Michal Privoznik wrote: >> After these regular errors, I still cannot build cleanly: >> >> ../../src/conf/domain_conf.c: In function 'virDomainChrPreAlloc': >> ../../src/conf/domain_conf.c:14109:57: error: potential

Re: [libvirt] [PATCH 0/2] Yet another round of build fixes

2016-05-30 Thread Peter Krempa
On Mon, May 30, 2016 at 15:53:08 +0200, Michal Privoznik wrote: > After these regular errors, I still cannot build cleanly: > > ../../src/conf/domain_conf.c: In function 'virDomainChrPreAlloc': > ../../src/conf/domain_conf.c:14109:57: error: potential null pointer > dereference

[libvirt] [PATCH] virsh: domdisplay: if listen is 0.0.0.0 or [::] print address from URI

2016-05-30 Thread Pavel Hrdina
Currently if a guest has listen address 0.0.0.0 or [::] and you run "virsh domdisplay $domain" you always get "spice://localhost:$port". We want to print better address if someone is connected from a different computer using "virsh -c qemu+ssh://some.host/system". This patch fixes the behavior

Re: [libvirt] [PATCH] conf: Skip MAC checks when using an auto-generated one during detach-device

2016-05-30 Thread Michal Privoznik
On 30.05.2016 14:09, Kothapally Madhu Pavan wrote: > When we try to detach a network device without specifying the > mac address, random mac address is generated. As the generated > mac address will not be available in the running vm, detaching > device will fail erroring out "error: operation

[libvirt] [PATCH 0/2] Yet another round of build fixes

2016-05-30 Thread Michal Privoznik
After these regular errors, I still cannot build cleanly: ../../src/conf/domain_conf.c: In function 'virDomainChrPreAlloc': ../../src/conf/domain_conf.c:14109:57: error: potential null pointer dereference [-Werror=null-dereference] return VIR_REALLOC_N(*arrPtr, *cntPtr + 1);

[libvirt] [PATCH 1/2] apibuild: Substitute only pure number tokens

2016-05-30 Thread Michal Privoznik
In 38df47c9af1 I've tried to prepare our apibuild.py script for change made in 0628f3498ce (1U << 31). What I've done in the former commit was to replace \d+U in parsed tokens with \d. Problem was, my regular expression there was not quite right as it also translated VIR_123U_VAL into VIR_123_VAL.

[libvirt] [PATCH 2/2] virSocketAddrIsPrivate: Work on 32bits platforms

2016-05-30 Thread Michal Privoznik
Yet another one of those where signed int (or long int) is not enough. And useless to as we're aiming at unsigned anyway. ../../src/util/virsocketaddr.c: In function 'virSocketAddrIsPrivate': ../../src/util/virsocketaddr.c:289:45: error: result of '192l << 24' requires 33 bits to represent, but

[libvirt] [PATCH] conf: Skip MAC checks when using an auto-generated one during detach-device

2016-05-30 Thread Kothapally Madhu Pavan
When we try to detach a network device without specifying the mac address, random mac address is generated. As the generated mac address will not be available in the running vm, detaching device will fail erroring out "error: operation failed: no device matching mac address xx:xx:xx:xx:xx:xx

Re: [libvirt] [PATCH 1/3] docs: Teach apibuild to deal with (1U << 31) too

2016-05-30 Thread Michal Privoznik
On 30.05.2016 13:20, Peter Krempa wrote: > On Mon, May 30, 2016 at 12:56:31 +0200, Peter Krempa wrote: >> On Mon, May 30, 2016 at 09:31:00 +0200, Michal Privoznik wrote: > > [...] > >> I was worried that it might mangle aliases for other enums containing >> numbers followed by a capital U but I

Re: [libvirt] [PATCH 1/3] docs: Teach apibuild to deal with (1U << 31) too

2016-05-30 Thread Peter Krempa
On Mon, May 30, 2016 at 12:56:31 +0200, Peter Krempa wrote: > On Mon, May 30, 2016 at 09:31:00 +0200, Michal Privoznik wrote: [...] > I was worried that it might mangle aliases for other enums containing > numbers followed by a capital U but I didn't manage to break it. Humm. I actually didn't

Re: [libvirt] [PATCH 0/3] Couple of build fixes

2016-05-30 Thread Peter Krempa
On Mon, May 30, 2016 at 09:30:59 +0200, Michal Privoznik wrote: > I've noticed couple of build failures with a bleeding edge gcc. Looks like you like to bleed :) ACK series. signature.asc Description: Digital signature -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH 1/3] docs: Teach apibuild to deal with (1U << 31) too

2016-05-30 Thread Peter Krempa
On Mon, May 30, 2016 at 09:31:00 +0200, Michal Privoznik wrote: > The apibuild script is a terrifying beast that parses some source > files of ours and produces an XML representation of them. When it > comes to parsing enums we have in some header files, it tries to > be clever and detect a value

Re: [libvirt] [Qemu-devel] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions

2016-05-30 Thread Markus Armbruster
Eduardo Habkost writes: > Just noticed that I hadn't replied to this yet. Sorry for the > long delay! > > On Thu, May 12, 2016 at 09:46:25AM +0200, Markus Armbruster wrote: >> Eduardo Habkost writes: > [...] >> > ## >> > # @CpuDefinitionInfo: >> > # >>

Re: [libvirt] [PATCH 8/9] target-i386: Use "-" instead of "_" on all feature names

2016-05-30 Thread Igor Mammedov
On Fri, 27 May 2016 17:32:34 -0300 Eduardo Habkost wrote: > On Tue, May 24, 2016 at 03:22:27PM +0200, Igor Mammedov wrote: > > On Tue, 24 May 2016 09:34:05 -0300 > > Eduardo Habkost wrote: > > > > > On Tue, May 24, 2016 at 02:17:03PM +0200, Igor

Re: [libvirt] [PATCH] Removed function virDomainDefNewFull.

2016-05-30 Thread Ján Tomko
On Fri, May 27, 2016 at 04:20:09PM +0200, Tomáš Ryšavý wrote: > The function virDomainDefNewFull() in src/conf/domain_conf.c was a thin > wrapper around virDomainDefNew() that was only used in a few places in > the code. The function was removed and the callers were re-implemented. > --- What is

[libvirt] [PATCH] qemu_process: print generic error if qemu exit without printing any error

2016-05-30 Thread Pavel Hrdina
In this case we would print only the libvirt part of error message without any explanation what happened: "error: internal error: process exited while connecting to monitor:" Let's print a generic error if this happens. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1335617

[libvirt] [PATCH 2/3] Turn 1<<31 into 1U<<31

2016-05-30 Thread Michal Privoznik
Apparently, 1 << 31 is signed which in turn does not fit into a signed integer variable: ../../include/libvirt/libvirt-domain.h:1881:57: error: result of '1 << 31' requires 33 bits to represent, but 'int' only has 32 bits [-Werror=shift-overflow=]

[libvirt] [PATCH 3/3] build: use gnulib's unsetenv

2016-05-30 Thread Michal Privoznik
Now that gnulib has lifted it's licensing of unsetenv, we should use it. Just like we use its counterpart - setenv, already. Signed-off-by: Michal Privoznik --- bootstrap.conf | 1 + 1 file changed, 1 insertion(+) diff --git a/bootstrap.conf b/bootstrap.conf index

[libvirt] [PATCH 0/3] Couple of build fixes

2016-05-30 Thread Michal Privoznik
I've noticed couple of build failures with a bleeding edge gcc. Here are fixes to some of them. Michal Privoznik (3): docs: Teach apibuild to deal with (1U << 31) too Turn 1<<31 into 1U<<31 build: use gnulib's unsetenv bootstrap.conf | 1 + docs/apibuild.py

[libvirt] [PATCH 1/3] docs: Teach apibuild to deal with (1U << 31) too

2016-05-30 Thread Michal Privoznik
The apibuild script is a terrifying beast that parses some source files of ours and produces an XML representation of them. When it comes to parsing enums we have in some header files, it tries to be clever and detect a value that an enum member has (or if it is an alias for a different member).