On Wed, Jun 08, 2016 at 10:01:34PM +0200, Olaf Hering wrote:
> On Mon, Jun 06, Ján Tomko wrote:
>
> > virNetDevGetEthtoolGFeatures(virBitmapPtr bitmap ATTRIBUTE_UNUSED,
> > - const char *ifname ATTRIBUTE_UNUSED)
> > + int fd ATTRIBUTE_UNUSED
On Wed, Jun 08, 2016 at 14:41:37 +0200, Jiri Denemark wrote:
> The actual CPU model in the data files is Penryn which makes the file
> name look rather strange. Well, one of them contains Nehalem, but that's
> a bug which will be fixed in the following patch.
>
> Signed-off-by: Jiri Denemark
> --
On Wed, Jun 08, 2016 at 14:41:35 +0200, Jiri Denemark wrote:
> Implemented in QEMU by commit 28b8e4d0bf93ba176b4b7be819d537383c5a9060.
>
> Signed-off-by: Jiri Denemark
> ---
> src/cpu/cpu_map.xml | 5 +
[...]
>
> diff --git a/src/cpu/cpu_map.xml b/src/cpu/c
On Wed, Jun 08, 2016 at 14:41:34 +0200, Jiri Denemark wrote:
> This was implemented in QEMU by commit 0bb0b2d2fe7f645dda.
>
> Signed-off-by: Jiri Denemark
> ---
> src/cpu/cpu_map.xml | 14 ++
[...]
ACK
--
libvir-list mailing list
libvir-list@redhat.c
On Wed, Jun 08, 2016 at 14:41:31 +0200, Jiri Denemark wrote:
> This patch makes our CPUID handling code up-to-date with the current
> specification found in
>
> Intel® 64 and IA-32 Architectures Developer's Manual: Vol. 2A
> http://www.intel.com/content/www/us/en/processors/architectures-software-
I'm reposting this series because I got the following two error messages from
the redhat.com MX:
libvir-list@redhat.com
SMTP error from remote mail server after RCPT TO::
host mx1.redhat.com [209.132.183.28]: 554 5.7.1 :
Recipient address rejected: Access denied
: host int-mx.corp.r
A simple getopt-based argument parser is added for the /usr/sbin/bhyve command,
loosely based on its argument parser, which reads the following from the bhyve
command line string:
* vm name
* number of vcpus
* memory size
* the time offset (UTC or localtime). This includes a capability check to se
A simple getopt-based argument parser is added for the /usr/sbin/bhyveload
command, loosely based on its argument parser.
The boot disk is guessed by iterating over all
disks and matching their sources. If any non-default arguments are found,
def->os.bootloaderArgs is set accordingly, and the boot
Unconditionally use gnulib's getopt module. This is needed by the bhyve driver
to provide a reentrant interface for getopt.
---
bootstrap.conf | 1 +
m4/virt-driver-bhyve.m4 | 3 +++
2 files changed, 4 insertions(+)
diff --git a/bootstrap.conf b/bootstrap.conf
index 0db6b62..edea8c3 1006
Several gnulib headers rely on feature.h being included by ctype.h to provide
__GNUC_PREREQ, but on systems without glibc, this is not provided. In these
cases __GNUC_PREREQ gets redefined to 0, which causes build errors from checks
in src/internal.h.
Therefore, define __GNUC_PREREQ as early as pos
FYI, there seems to be a problem withint-mx.corp.redhat.com. It failed to post
0/6 and 3/6 with
550 5.1.1 ... User unknown (in reply to RCPT TO command)
I'm rather reluctant to spam the list by resending the series.
Regards,
Jim
On 06/08/2016 05:23 PM, Jim Fehlig wrote:
> The virQEMUDriverConf
On 06/04/2016 08:46 PM, Martin Kletzander wrote:
> Signed-off-by: Martin Kletzander
> ---
> src/qemu/qemu_capabilities.c | 3 +++
> src/qemu/qemu_capabilities.h | 3 +++
> src/qemu/qemu_command.c| 11 +
> tests/qe
On 06/04/2016 08:46 PM, Martin Kletzander wrote:
> This option allows or disallows detection of zero-writes if it is set to
> "on" or "off", respectively. It can be also set to "unmap" in which
> case it will try discarding that part of image based on the value of the
> "discard" option.
>
> Si
The virQEMUDriverConfig object contains lists of
loader:nvram pairs to advertise firmwares supported by
by the driver, and qemu_conf.c contains code to populate
the lists, all of which is useful for other drivers too.
To avoid code duplication, introduce a virFirmware object
to encapsulate firmwar
Prefer firmwares specified via --with-loader-nvram configure
option. If none are specified, use the Xen-provided default
firmwares found in LIBXL_FIRMWARE_DIR.
Signed-off-by: Jim Fehlig
---
src/libxl/libxl_conf.c | 21 +
src/libxl/libxl_conf.h | 4
2 files changed, 25 i
Add domain capabilities for PV and HVM domains.
Signed-off-by: Jim Fehlig
---
src/libxl/libxl_capabilities.c | 140 +
src/libxl/libxl_capabilities.h | 7 ++
src/libxl/libxl_driver.c | 74 +++
tests/Makefile.am
Add support to xenconfig for conversion of xl.cfg(5) bios config
to/from libvirt domXml config. SeaBIOS is the default
for HVM guests using upstream QEMU. ROMBIOS is the default when
using the old qemu-dm. This patch allows specifying OVMF as an
alternate firmware.
Example xl.cfg:
bios = "ovmf"
On 06/08/2016 02:21 AM, Rudy Zhang wrote:
> Add new function about block backup, it supports the drive-backup function
> in qemu, it supports three modes: full, top, incremental.
>
Cheers Rudy!
I assume you've CC'd me as I authored a lot of the incremental backup
infrastructure in QEMU. I'm no
On 06/08/2016 12:21 AM, Rudy Zhang wrote:
> For Backuping the disk image.
>
> It supports tree backup mode: full, top, incremental.
> Incremental backup mode must do full or top backup first,
> and it exists dirty bitmap to trace io.
>
> Signed-off-by: longyou
> ---
> +++ b/src/remote/remote_dr
Hello everyone,
Let me introduce myself - I'm Tomasz Flendrich and I'm a Google Summer
of Code student from University of Wrocław, Poland.
My goal is to create a generic address allocator (for PCI, virtio,
SCSI, etc.), because current handling of addresses has its flaws:
sometimes addresses aren'
On Mon, Jun 06, Ján Tomko wrote:
> virNetDevGetEthtoolGFeatures(virBitmapPtr bitmap ATTRIBUTE_UNUSED,
> - const char *ifname ATTRIBUTE_UNUSED)
> + int fd ATTRIBUTE_UNUSED,
> + struct ifreq *ifr ATTRIBUGE_UNUSED)
On 06/08/2016 07:14 AM, Pavel Hrdina wrote:
> Currently if a guest has listen address 0.0.0.0 or [::] and you run
> "virsh domdisplay $domain" you always get "spice://localhost:$port".
>
> We want to print better address if someone is connected from a different
> computer using "virsh -c qemu+ss
Signed-off-by: Pavel Hrdina
---
docs/formatdomain.html.in | 3 ++-
src/conf/domain_conf.c | 3 ++-
src/qemu/qemu_command.c| 3 +++
.../qemuxml2argv-graphics-vnc-none.args| 20 +++
.../qemux
This new listen type is currently supported only by spice graphics.
It's introduced to make it easier and clearer specify to not listen
anywhere in order to start a guest with OpenGL support.
The old way to do this was set spice graphics autoport='no' and don't
specify any ports. The new way is t
This moves the socket generation if "vnc_auto_unix_socket" is set.
It also fixes a bug with this config option that we should auto-generate
socket path only if listen type is address and there is no address
specified.
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu.conf | 6 +++---
src/qemu
VNC graphics already supports sockets but only via 'socket' attribute.
This patch coverts that attribute into listen type 'socket'.
For backward compatibility we need to handle listen type 'socket' and 'socket'
attribute properly to support old XMLs and new XMLs. If both are provided they
have to
On 05/26/2016 11:02 AM, Tomáš Ryšavý wrote:
> This function doesn't follow our convention of naming functions.
> ---
> tests/testutils.c | 8
> tests/testutils.h | 12 ++--
> 2 files changed, 10 insertions(+), 10 deletions(-)
>
ACK 13-19
Using cscope and searching on 'virtTe
Signed-off-by: Pavel Hrdina
---
src/qemu/libvirtd_qemu.aug | 1 +
src/qemu/qemu.conf | 11 +++
src/qemu/qemu_conf.c | 1 +
src/qemu/qemu_conf.h | 1 +
src/qemu/qemu_process.c
Changes in v6:
- patch 1 from v5 is split into paches 1-5
Pavel Hrdina (10):
qemu_command: move websocket code into else part for address listen
vnc: rename socketAutogenerated to socketFromConfig
vnc: move generation of socket path to qemuProcessGraphicsSetupListen
graphics: introduce
Even though it's auto-generated it's based on qemu.conf option and listen type
address already uses "fromConfig" to carry this information. Following commits
will convert the socket to listen element so this rename is required because
there will be also an option to get socket auto-generated indep
Add a new capability to detect support of unix sockets for spice
graphics.
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml | 1 +
tests/qemucapabiliti
Signed-off-by: Pavel Hrdina
---
docs/formatdomain.html.in | 8 ++
docs/schemas/domaincommon.rng | 10
src/conf/domain_conf.c| 60 +--
src/conf/domain_conf.h| 6 +
src/libvirt_private.syms | 1 +
src/qemu/qemu_hot
There is no need to check again for vnc socket.
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_command.c | 17 -
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index b5d84e6..8523992 100644
--- a/src/qemu/qemu_comman
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1335832
Signed-off-by: Pavel Hrdina
---
docs/formatdomain.html.in | 2 +-
src/conf/domain_conf.c | 31
src/qemu/qemu_command.c| 56
On Wed, Jun 08, 2016 at 14:41:33 +0200, Jiri Denemark wrote:
> As a side effect this changes the order of CPU features in XMLs
> generated by libvirt, but that's not a big deal since the order there is
> insignificant.
>
> Signed-off-by: Jiri Denemark
> ---
ACK
--
libvir-list mailing list
libvi
On 05/26/2016 11:02 AM, Tomáš Ryšavý wrote:
> This function doesn't follow our convention of naming functions.
> ---
> tests/qemuxml2xmltest.c | 6 +++---
> tests/testutils.c | 16
You forgot tests/testutils.h
> 2 files changed, 11 insertions(+), 11 deletions(-)
>
I f
On Wed, Jun 08, 2016 at 14:41:32 +0200, Jiri Denemark wrote:
> For two reasons:
> - 0x0001 is very similar to 0x8001, but 0x01 is visually
> different
> - 0x01 format is consistent with CPUID manual
>
> Signed-off-by: Jiri Denemark
> ---
> src/cpu/cpu_map.xml | 158
> +
On 05/26/2016 11:02 AM, Tomáš Ryšavý wrote:
> This function doesn't follow our convention of naming functions.
> ---
> tests/esxutilstest.c| 2 +-
> tests/metadatatest.c| 2 +-
> tests/objecteventtest.c | 2 +-
> tests/sockettest.c | 2 +-
> tests/testutils.c | 2 +-
> tests/t
On Wed, Jun 08, 2016 at 02:55:24PM +, Ashish Mittal wrote:
> Thanks Daniel!
>
> I also sent a path on top of libvirt master using "git send-email" as
> directed on libvirt.org. That patch is much more cleaner. (1) does not
> have storage pool changes since OpenFlame does not use storage pools
On Wed, Jun 08, 2016 at 14:41:30 +0200, Jiri Denemark wrote:
> CPUID instruction normally takes its parameter from EAX, but sometimes
> ECX is used as an additional parameter. This patch prepares the x86 CPU
> driver code for the new 'ecx_in' CPUID parameter.
>
> Signed-off-by: Jiri Denemark
> --
Thanks Daniel!
I also sent a path on top of libvirt master using "git send-email" as
directed on libvirt.org. That patch is much more cleaner. (1) does not
have storage pool changes since OpenFlame does not use storage pools
(yet). (2) Uses the new encrypted secret passing as the others have done.
On Wed, Jun 08, 2016 at 15:38:06 +0100, Daniel Berrange wrote:
> While all Fedora systems should have a crypto policy config
> file that defines @SYSTEM policy. You never know, however,
> if someone has done a peculiar Fedora build / install that
> does not setup the crypto policy. As a protection
On Wed, Jun 08, 2016 at 14:41:29 +0200, Jiri Denemark wrote:
> Signed-off-by: Jiri Denemark
> ---
> .../qemumonitorjson-getcpu-ecx.data| 7 +++
> .../qemumonitorjson-getcpu-ecx.json| 57
> ++
> tests/qemumonitorjsontest.c
On Wed, Jun 08, 2016 at 04:35:25PM +0200, Ján Tomko wrote:
> Jump to cleanup if virAsprintf fails.
> ---
> tests/virschematest.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
ACK
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-li
While all Fedora systems should have a crypto policy config
file that defines @SYSTEM policy. You never know, however,
if someone has done a peculiar Fedora build / install that
does not setup the crypto policy. As a protection measure
we should tell gnutls to automatically fallback to NORMAL
if @S
Jump to cleanup if virAsprintf fails.
---
tests/virschematest.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/virschematest.c b/tests/virschematest.c
index c173037..f15e2ab 100644
--- a/tests/virschematest.c
+++ b/tests/virschematest.c
@@ -117,23 +117,23 @@ testSche
On 05/26/2016 11:01 AM, Tomáš Ryšavý wrote:
> This function doesn't follow our convention of naming functions.
> ---
> tests/bhyvexml2argvtest.c | 2 +-
> tests/bhyvexml2xmltest.c | 2 +-
> tests/commandtest.c| 4 +--
> tests/cputest.c|
On Tue, Jun 07, 2016 at 08:54:56PM +, Ashish Mittal wrote:
> Hi,
>
> This is a patch review request in response to the following bugzilla:
> Bug 1341866 RFE: Request to upstream libvirt dependencies for qemu
> based network block driver from Veritas
Great, thanks for moving the discu
On Wed, Jun 08, 2016 at 10:22:55 +0200, Jiri Denemark wrote:
> Signed-off-by: Jiri Denemark
> ---
> tests/cputest.c | 1 +
> tests/cputestdata/x86-cpuid-Xeon-X5460-guest.xml | 21 ++
> tests/cputestdata/x86-cpuid-Xeon-X5460-host.xml | 21
On Wed, Jun 08, 2016 at 10:22:26 +0200, Jiri Denemark wrote:
> So far we only test CPUID -> CPU def conversion on artificial CPUID data
> computed from another CPU def. This patch adds the infrastructure to
> test this conversion on real data gathered from a host CPU and two
> helper scripts for ad
On 06/08/2016 09:20 AM, Jovanka Gulicoska wrote:
> ---
> src/node_device/node_device_hal.c | 27 ++-
> 1 file changed, 18 insertions(+), 9 deletions(-)
>
> diff --git a/src/node_device/node_device_hal.c
> b/src/node_device/node_device_hal.c
> index 6ddfad0..2718706 100644
From: Derbyshev Dmitry
To collect all balloon statistics for all guests it was necessary to make
several libvirt requests (one per VE).
This patch allows doing this via qemuConnectGetAllDomainStats in one request.
Changes:
* qemuDomainMemoryStats became a helper function which calls
qemuDomain
From: Derbyshev Dmitry
'memtotal' in virtio drivers and qemu corresponds to 'available' in libvirt.
Because of that, 'stat-available-memory' is renamed into 'usable'.
Balloon statistics are not reported in hrf, so no modifications are made in
qemu_monitor_text.c.
Signed-off-by: Derbyshev Dmitry
From: Derbyshev Dmitry
QEMU reports timestamp and available along with other memory statistics.
This information was not saved into domain statistics.
Also, to collect all balloon statistics for all guests it was necessary to make
several libvirt requests (one per VE).
Last patch allows doing th
From: Derbyshev Dmitry
QEMU reports timestamp along with other memory statistics, but this information
is not saved into domain statistics.
It could be useful to determine if the data reported is fresh or not.
Balloon statistics are not reported in hrf, so no modifications are made in
qemu_moni
On Wed, Jun 08, 2016 at 10:22:25 +0200, Jiri Denemark wrote:
> The internal features are only used in explicit checks with
> cpuHasFeature. Loading them into the CPU map is dangerous since the
> features may accidentally be reported to users when decoding CPUID data.
>
> Signed-off-by: Jiri Denema
On Wed, Jun 08, 2016 at 08:45:21AM -0400, John Ferlan wrote:
>
>
> On 06/06/2016 04:08 AM, Ján Tomko wrote:
> > In a few API implementations, we use virDomainLiveConfigHelperMethod
> > to check the VIR_DOMAIN_AFFECT_* flags (and change the flags variable
> > to either AFFECT_LIVE or AFFECT_CONFIG
On Wed, Jun 08, 2016 at 10:22:24 +0200, Jiri Denemark wrote:
> virCPUData and struct ppc64_model structures contained a pointer to
> virCPUppc64Data, which was not very nice since the real data were
> accessible by yet another level of pointers from virCPUppc64Data.
>
> Signed-off-by: Jiri Denemar
On Wed, Jun 08, 2016 at 10:22:23 +0200, Jiri Denemark wrote:
> virCPUData, virCPUx86Feature, and virCPUx86Model all contained a pointer
> to virCPUx86Data, which was not very nice since the real CPUID data were
> accessible by yet another pointer from virCPUx86Data. Moreover, using
> virCPUx86Data
---
src/node_device/node_device_hal.c | 27 ++-
1 file changed, 18 insertions(+), 9 deletions(-)
diff --git a/src/node_device/node_device_hal.c
b/src/node_device/node_device_hal.c
index 6ddfad0..2718706 100644
--- a/src/node_device/node_device_hal.c
+++ b/src/node_device/
On Wed, Jun 08, 2016 at 10:22:22 +0200, Jiri Denemark wrote:
> The current version uses the first JSON reply from the file as monitor
> greeting. With the new parameter the caller can now request a simple
> test monitor to be created, which uses an artificial greeting and uses
> all JSON strings fr
On Wed, Jun 08, 2016 at 10:22:21 +0200, Jiri Denemark wrote:
> Signed-off-by: Jiri Denemark
> ---
> tests/qemumonitortestutils.c | 24
> tests/qemumonitortestutils.h | 4 ++--
> 2 files changed, 14 insertions(+), 14 deletions(-)
ACK
--
libvir-list mailing list
libvir-l
On Wed, Jun 08, 2016 at 10:22:20 +0200, Jiri Denemark wrote:
> It's a convenient wrapper around qemuMonitorTestNew which feeds the test
> monitor with QMP replies from a specified file.
>
> Signed-off-by: Jiri Denemark
> ---
> tests/qemucapabilitiestest.c | 57 +--
On Wed, Jun 08, 2016 at 10:22:19 +0200, Jiri Denemark wrote:
> This patch splits qemuMonitorJSONGetCPUx86Data in three functions:
>
> - qemuMonitorJSONCheckCPUx86 checks if QEMU supports reporting CPUID
> features for a guest CPU
>
> - qemuMonitorJSONParseCPUx86Features parses CPUID features fr
On 06/06/2016 04:08 AM, Ján Tomko wrote:
> In a few API implementations, we use virDomainLiveConfigHelperMethod
> to check the VIR_DOMAIN_AFFECT_* flags (and change the flags variable
> to either AFFECT_LIVE or AFFECT_CONFIG if AFFECT_CURRENT was requested)
> and optionally give us a pointer to t
On 06/06/2016 04:08 AM, Ján Tomko wrote:
> Instead of virDomainLiveConfigHelperMethod.
> ---
> src/lxc/lxc_driver.c | 18 +-
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c
> index c39b4b4..00b4df2 100644
> --- a/src
On 06/06/2016 04:08 AM, Ján Tomko wrote:
> On LXC domain startup we have already called virDomainObjSetDefTransient
> to fill vm->newDef.
>
> There is no need to call virDomainLiveConfigHelperMethod which has the
> ability to fill newDef if it's NULL.
> ---
> src/lxc/lxc_driver.c | 13 +++--
On 06/06/2016 04:08 AM, Ján Tomko wrote:
> On LXC domain startup we have already called virDomainObjSetDefTransient
> to fill vm->newDef.
>
> There is no need to call virDomainLiveConfigHelperMethod which has the
> ability to fill newDef if it's NULL.
> ---
> src/lxc/lxc_driver.c | 26 +
The CPU model was implemented in QEMU by commit TBD (it's on x86-next
branch waiting for a pull request).
The change to i7-5600U is wrong since it's a 5th generation CPU, i.e.,
Broadwell rather than Skylake, but that's just the result of our CPU
detection code (which will be fixed by a later patch
This patch makes our CPUID handling code up-to-date with the current
specification found in
Intel® 64 and IA-32 Architectures Developer's Manual: Vol. 2A
http://www.intel.com/content/www/us/en/processors/architectures-software-developer-manuals.html
Signed-off-by: Jiri Denemark
---
src/cpu/cpu_
Our current detection code uses just the number of CPU features which
need to be added/removed from the CPU model to fully describe the CPUID
data. The smallest number wins. But this may sometimes generate wrong
results as one can see from the fixed test cases. This patch modifies
the algorithm to
As a side effect this changes the order of CPU features in XMLs
generated by libvirt, but that's not a big deal since the order there is
insignificant.
Signed-off-by: Jiri Denemark
---
src/cpu/cpu_map.xml| 118 ++---
tests/cputestdata/x86-cpuid-A10
The actual CPU model in the data files is Penryn which makes the file
name look rather strange. Well, one of them contains Nehalem, but that's
a bug which will be fixed in the following patch.
Signed-off-by: Jiri Denemark
---
tests/cputest.c
Signed-off-by: Jiri Denemark
---
.../qemumonitorjson-getcpu-ecx.data| 7 +++
.../qemumonitorjson-getcpu-ecx.json| 57 ++
tests/qemumonitorjsontest.c| 1 +
3 files changed, 65 insertions(+)
create mode 100644 tests/qemu
For two reasons:
- 0x0001 is very similar to 0x8001, but 0x01 is visually
different
- 0x01 format is consistent with CPUID manual
Signed-off-by: Jiri Denemark
---
src/cpu/cpu_map.xml | 158 ++--
1 file changed, 79 insertions(+), 79 deleti
CPUID instruction normally takes its parameter from EAX, but sometimes
ECX is used as an additional parameter. This patch prepares the x86 CPU
driver code for the new 'ecx_in' CPUID parameter.
Signed-off-by: Jiri Denemark
---
src/cpu/cpu_x86.c | 52 +-
Implemented in QEMU by commit 28b8e4d0bf93ba176b4b7be819d537383c5a9060.
Signed-off-by: Jiri Denemark
---
src/cpu/cpu_map.xml | 5 +
tests/cputestdata/x86-cpuid-Core-i5-2500-guest.xml | 1 +
tests/cputestdata/x86-cpuid-Core-i5-2500-host.xml| 1 +
tests/c
This series applies on top of "Another round of CPU driver patches" I
sent earlier today.
Jiri Denemark (10):
qemumonitorjsontest: Add getcpu test data
cpu_x86: Prepare for ecx_in CPUID parameter
cpu_x86: Add full support for ecx_in CPUID parameter
cpu: Shorten eax_in values in CPU map
c
This was implemented in QEMU by commit 0bb0b2d2fe7f645dda.
Signed-off-by: Jiri Denemark
---
src/cpu/cpu_map.xml | 14 ++
tests/cputestdata/x86-cpuid-Core-i5-2500-guest.xml | 1 +
tests/cputestdata/x86-cpuid-Core-i5-2500-host.xml | 1 +
tests/cpute
On Wed, Jun 08, 2016 at 10:22:18 +0200, Jiri Denemark wrote:
> CPUID instruction normally takes its parameter from EAX, but sometimes
> ECX is used as an additional parameter. Let's rename 'function' to
> 'eax_in' in preparation for adding 'ecx_in'.
>
> Signed-off-by: Jiri Denemark
> ---
> src/c
On Wed, Jun 08, 2016 at 10:22:17 +0200, Jiri Denemark wrote:
> A CPU data XML file already contains the architecture, let the parser
> use it to detect which CPU driver should be used to parse the rest of
> the file.
>
> Signed-off-by: Jiri Denemark
> ---
> src/cpu/cpu.c | 54 +++
On Wed, Jun 08, 2016 at 11:07:16AM +0100, Daniel P. Berrange wrote:
[...]
> > situation, but that's just a matter of plumbing I think.)
> >
> > The options we've come up with, broadly, are as follows:
> >
> > 1. Try to use the existing syslog facilities
> >
> > 2. Re-purpose one of our existing
On Wed, Jun 08, 2016 at 13:53:05 +0200, Michal Privoznik wrote:
> Problem is, localtime_r() returns a pointer to converted time or
> NULL in case of an error. But checking the glibc sources, error
> will occur iff a NULL has been passed as an either of arguments
> the function takes. But GCC fails
On 06/08/2016 04:10 AM, Ján Tomko wrote:
On Wed, Jun 08, 2016 at 08:49:37AM +0200, Peter Krempa wrote:
On Tue, Jun 07, 2016 at 20:07:28 +0200, Ján Tomko wrote:
Store all the data related to RNG validation in one structure to
allow splitting virXMLValidateAgainstSchema.
---
src/util/virxml.c |
On Wed, Jun 08, 2016 at 10:22:16 +0200, Jiri Denemark wrote:
> The formatter uses /cpudata/cpuid elements and the parser should really
> do the same.
>
> Signed-off-by: Jiri Denemark
> ---
> src/cpu/cpu_x86.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
ACK
--
libvir-list mailin
On Wed, Jun 08, 2016 at 10:22:15 +0200, Jiri Denemark wrote:
> When computing CPU data for a given guest CPU we should set CPUID vendor
> bits appropriately so that we don't lose the vendor when transforming
> CPU data back to XML description.
>
> Signed-off-by: Jiri Denemark
> ---
> src/cpu/cpu
Problem is, localtime_r() returns a pointer to converted time or
NULL in case of an error. But checking the glibc sources, error
will occur iff a NULL has been passed as an either of arguments
the function takes. But GCC fails to see that:
../../tools/virsh-network.c: In function 'cmdNetworkDHCPLe
On Wed, Jun 08, 2016 at 12:37:36 +0200, Pavel Hrdina wrote:
> Resolves: Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1335617
s/^Resolves: //
>
> Signed-off-by: Pavel Hrdina
> ---
> src/qemu/qemu_process.c | 7 +--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a
On Wed, Jun 08, 2016 at 12:37:35 +0200, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
> ---
> src/qemu/qemu_monitor.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c
> index 597307f..3524d22 100644
> --- a/src/qemu/
On Wed, Jun 08, 2016 at 13:14:00 +0200, Pavel Hrdina wrote:
> Currently if a guest has listen address 0.0.0.0 or [::] and you run
> "virsh domdisplay $domain" you always get "spice://localhost:$port".
>
> We want to print better address if someone is connected from a different
> computer using "vi
We use libxml2 APIs in the test (e.g. xmlFreeDoc) but not link
with -lxml2 which can cause problems:
/usr/bin/ld: virschematest.o: undefined reference to symbol
'xmlFreeDoc@@LIBXML2_2.4.30'
//usr/lib/x86_64-linux-gnu/libxml2.so.2: error adding symbols: DSO missing from
command line
collect2: err
On Mon, Jun 06, 2016 at 16:09:03 +0100, Daniel Berrange wrote:
> In Fedora >= 21, there is a new crypto priority framework
> that sets TLS policies globally for all apps. To activate
> this with GNUTLS we must request "@SYSTEM" instead of
> the traditional "NORMAL" string. The '@' causes gnutls tod
On Mon, Jun 06, 2016 at 16:09:02 +0100, Daniel Berrange wrote:
> Support reading the TLS priority from the client configuration
> file via the "tls_priority" config option, eg
>
> $ cat $HOME/.config/libvirt/libvirt.conf
> tls_priority="NORMAL:-VERS-SSL3.0"
>
> Signed-off-by: Daniel P. Berrange
On Mon, Jun 06, 2016 at 16:09:01 +0100, Daniel Berrange wrote:
> The virConnectOpenInternal method opens the libvirt client
> config file and uses it to resolve things like URI aliases.
>
> There may be driver specific things that are useful to
> store in the config file too, so rather than have t
On Mon, Jun 06, 2016 at 16:09:00 +0100, Daniel Berrange wrote:
> Add support for a "tls_priority" URI parameter in remote
> driver URIs. eg
>
> qemu+tls://localhost/session?tls_priority=NORMAL:-VERS-SSL3.0
>
> Signed-off-by: Daniel P. Berrange
> ---
> docs/remote.html.in| 13 ++
Currently if a guest has listen address 0.0.0.0 or [::] and you run
"virsh domdisplay $domain" you always get "spice://localhost:$port".
We want to print better address if someone is connected from a different
computer using "virsh -c qemu+ssh://some.host/system". This patch fixes the
behavior of
On Mon, Jun 06, 2016 at 16:08:59 +0100, Daniel Berrange wrote:
> Add a "tls_priority" config option to /etc/libvirt/libvirtd.conf
> to allow the administrator to override the built-in default
> setting. This only affects the server side configuration.
>
> Signed-off-by: Daniel P. Berrange
> ---
>
On Wed, Jun 08, 2016 at 12:58:05PM +0200, Peter Krempa wrote:
> On Mon, Jun 06, 2016 at 16:08:57 +0100, Daniel Berrange wrote:
> > Currently libvirt calls gnutls_set_default_priority()
> > which on old systems resolves to "NORMAL" while new
> > systems it resolves to "@SYSTEM". Either way, this
> >
On Mon, Jun 06, 2016 at 16:08:58 +0100, Daniel Berrange wrote:
> Extend the virNetTLSContextNew* constructors to allow
> the TLS priority string to be passed in, overriding the
> compile time default.
>
> Signed-off-by: Daniel P. Berrange
> ---
> daemon/libvirtd.c| 2 ++
> src/remot
On Mon, Jun 06, 2016 at 16:08:57 +0100, Daniel Berrange wrote:
> Currently libvirt calls gnutls_set_default_priority()
> which on old systems resolves to "NORMAL" while new
> systems it resolves to "@SYSTEM". Either way, this
> is a global default that is identical across all apps.
>
> We want to
1 - 100 of 166 matches
Mail list logo
