Re: [libvirt] [PATCH 1/6] extend usb controller model to support xen pvusb

>>> On 6/14/2016 at 01:27 PM, in message <575f95c4.4080...@suse.com>, Juergen >>> Gross wrote: > On 14/06/16 07:02, Jim Fehlig wrote: > > On 06/12/2016 10:53 AM, Chunyan Liu wrote: > >> According to libxl implementation, it supports pvusb > >> controller of version 1.1 and version 2.0, and

Re: [libvirt] [PATCH] cputest: Get rid of the array of test functions

On Thu, Jun 09, 2016 at 13:19:31 +0200, Jiri Denemark wrote: > Signed-off-by: Jiri Denemark > --- > tests/cputest.c | 134 > +--- > 1 file changed, 51 insertions(+), 83 deletions(-) ACK -- libvir-list mailing list libvir-list@redhat.com https

Re: [libvirt] [PATCH] Bump release to 2.0.0 and document release schedule & versioning

On Mon, Jun 13, 2016 at 18:34:48 +0100, Daniel P. Berrange wrote: > This bumps the release number of 2.0.0, to reflect the switch to > a new time based release versioning scheme. The downloads page > is updated to describe our policies for release schedules and > release version numbering > > The

Re: [libvirt] [PATCH V3 4/6] libxl: implement connectGetDomainCapabilities

Jim Fehlig wrote: > Add domain capabilities for PV and HVM domains. > > Signed-off-by: Jim Fehlig > --- > > V3: > - Change introduction of connectGetDomainCapabilities to 1.3.6 > > src/libxl/libxl_capabilities.c | 140 > + > src/libxl/libxl_capabilit

[libvirt] [PATCH] Fix build without xen

Commit 11567cf66f36 introduced an include which will only work when building with xen (particularly libxl). However, that file is supposed to be includable from anywhere (as with other testutils* files. Signed-off-by: Martin Kletzander --- Pushed under the build-breaker rule. tests/testutilsxe

Re: [libvirt] [PATCH] Bump release to 2.0.0 and document release schedule & versioning

On Mon, Jun 13, 2016 at 18:34:48 +0100, Daniel P. Berrange wrote: > This bumps the release number of 2.0.0, to reflect the switch to > a new time based release versioning scheme. The downloads page > is updated to describe our policies for release schedules and > release version numbering > > The

Re: [libvirt] [PATCH v2 0/6] Introducing storage pool lifecycle event APIs

On Mon, Jun 13, 2016 at 13:35:04 -0400, Cole Robinson wrote: > On 06/13/2016 12:38 PM, Jovanka Gulicoska wrote: [...] > > I just reviewed the diff between v1 and v2 and made a couple small changes, > diff attached. I copied the docstring from the network events since your > version still had sev

Re: [libvirt] [PATCH v2 6/6] event-test: support storage lifecycle event APIs

On Mon, Jun 13, 2016 at 18:38:43 +0200, Jovanka Gulicoska wrote: > --- > examples/object-events/event-test.c | 46 > - > 1 file changed, 45 insertions(+), 1 deletion(-) [...] > @@ -899,6 +933,7 @@ main(int argc, char **argv) > virConnectPtr dconn = NULL;

Re: [libvirt] [PATCH v2 5/6] storage: implement storage lifecycle event APIs

On Mon, Jun 13, 2016 at 18:38:42 +0200, Jovanka Gulicoska wrote: > Implement storage pool event callbacks for START, STOP, DEFINE, UNDEFINED > and REFRESHED in functions when a storage pool is created/started/stopped > etc. accordingly > --- > src/storage/storage_driver.c | 110 >

Re: [libvirt] Switch to a time based version number rule

On Mon, Jun 13, 2016 at 05:55:57PM +0100, Daniel P. Berrange wrote: On Mon, Jun 13, 2016 at 04:01:56PM +0200, Martin Kletzander wrote: On Mon, Jun 13, 2016 at 01:56:54PM +0100, Daniel P. Berrange wrote: > Currently libvirt uses a 3 digit version number, except when it uses > a 4 digit version nu

Re: [libvirt] [PATCH v2 4/6] remote: implement storage lifecycle event APIs

On Mon, Jun 13, 2016 at 18:38:41 +0200, Jovanka Gulicoska wrote:a It may be worth noting that along with the lifecycle event this patch also implements all the dispatching stuff for events in the storage driver. It may be also worth splitting those two additions but I'm not going to insist. > --

Re: [libvirt] [PATCH 1/6] extend usb controller model to support xen pvusb

On 14/06/16 07:02, Jim Fehlig wrote: > On 06/12/2016 10:53 AM, Chunyan Liu wrote: >> According to libxl implementation, it supports pvusb >> controller of version 1.1 and version 2.0, and it >> supports two types of backend, 'pvusb' (dom0 backend) >> and 'qusb' (qemu backend). > > IIUC, the pvusb

[libvirt] [PATCH] virt-host-validate: fix build with clang

Building with clang 3.8 triggers the following error: CC virt_host_validate-virt-host-validate-qemu.o virt-host-validate-qemu.c:36:11: error: initializing 'char *' with an expression of type 'const char *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]

Re: [libvirt] [PATCH 1/6] extend usb controller model to support xen pvusb

On 06/12/2016 10:53 AM, Chunyan Liu wrote: > According to libxl implementation, it supports pvusb > controller of version 1.1 and version 2.0, and it > supports two types of backend, 'pvusb' (dom0 backend) > and 'qusb' (qemu backend). IIUC, the pvusb backend has not gained any traction in the kern

Re: [libvirt] [PATCH v2 2/6] conf: add storage_event handling

On Mon, Jun 13, 2016 at 18:38:39 +0200, Jovanka Gulicoska wrote: > Add storage event handling infrastructure to storage_event.[ch], following > the network_event.[ch] pattern. > --- > src/Makefile.am | 5 + > src/conf/storage_conf.h | 4 + > src/conf/storage_event.c | 237 >

Re: [libvirt] [PATCH v2 1/6] Introduce storage lifecycle event APIs

On Mon, Jun 13, 2016 at 18:38:38 +0200, Jovanka Gulicoska wrote: > Storage pool lifecycle event API entry points for registering and > deregistering > storage pool events, as well as types of events associated with storage pools. > These entry points will be used for implementing asynchronous life

[libvirt] [PATCH 6/6] qemu: Add the ability to hotplug the TLS X.509 environment

If the incoming XML defined a path to a TLS X.509 certificate environment, add the necessary 'tls-creds-x509' object to the VIR_DOMAIN_CHR_TYPE_TCP character device. Signed-off-by: John Ferlan --- src/qemu/qemu_command.c | 69 +++- src/qemu/qemu_comma

[libvirt] [PATCH 4/6] conf: Add new tlsx509 attribute for tcp chardev

Add the domain rng, parse, and format of a new XML element "tlsx509": The attribute for the element will contain a path to an X.509 certificate credential directory to be passed along to the hypervisor to process. Signed-off-by: John Ferlan --- docs/formatdomain.html.in

[libvirt] [PATCH 5/6] qemu: Add support for TLS X.509 path

When building a chardev device string for tcp, add the necessary pieces to access provide the TLS X.509 path to qemu. This includes generating the 'tls-creds-x509' object and then adding the 'tls-creds' parameter to the VIR_DOMAIN_CHR_TYPE_TCP command line. Since this is providing a new file whic

[libvirt] [PATCH 3/6] qemu: Refactor qemuDomainAttachChrDevice error paths

Refactor the error paths for attaching char device (it's about to be more complicated). Signed-off-by: John Ferlan --- src/qemu/qemu_hotplug.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 5815

[libvirt] [PATCH 1/6] caps: Add capability for tls-x509-creds

Add the capability flag and checks for the qemu object 'tls-creds-x509' Signed-off-by: John Ferlan --- src/qemu/qemu_capabilities.c| 2 ++ src/qemu/qemu_capabilities.h| 1 + tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml| 1 + tes

[libvirt] [PATCH 0/6] Some patches for native TLS encrypted chardev TCP support

Not fully complete yet as I need the key secret from the LUKS encryption support series; however, I figured I would post what I have that is at least "separable". This set of patches is in support of: https://bugzilla.redhat.com/show_bug.cgi?id=1300776 What's missing is the ability to provide an

[libvirt] [PATCH 2/6] docs: Clarify chardev protocol

Add a slight clarification to usage of "telnet", "telnets", or "tls" as the protocol type value. Signed-off-by: John Ferlan --- docs/formatdomain.html.in | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index fb3

[libvirt] [PATCH 15/19] encryption: Add luks parsing for storageencryption

Add parse and format of the luks/key secret including tests for volume XML parsing. Signed-off-by: John Ferlan --- docs/formatsecret.html.in | 7 +++- docs/formatstorageencryption.html.in | 24 +++- docs/schemas/storagecommon.rng

[libvirt] [PATCH 13/19] util: Add 'luks' to the FileTypeInfo

Add the ability to detect a luks encrypted device. This also adding new 16 bit big/little endian macros since the version of a luks device is stored in a uint16_t. Signed-off-by: John Ferlan --- src/util/virendian.h | 24 src/util/virstoragefile.c | 38

[libvirt] [PATCH 12/19] util: Modify the FileTypeInfo for meta data checks

Currently the assumption is there is one type of disk encryption - in some qcow format which is old and crusty... But there's a new sheriff in town known as 'luks' and we'll need to handle that shortly Signed-off-by: John Ferlan --- src/util/virstoragefile.c | 54

[libvirt] [PATCH 19/19] qemu: Add luks support for domain disk

Generate the luks command line using the AES secret key to encrypt the luks secret. A luks secret object will be in addition to a an AES secret. Add tests for sample output Signed-off-by: John Ferlan --- src/qemu/qemu_command.c| 12 ++-- src/qemu/qemu_domain.c

[libvirt] [PATCH 14/19] conf: Add new secret type "key"

Add a new secret type known as "key" - it will handle adding the secret objects that need a key (or passphrase), such as will soon be the case for a luks volume for both storage driver create and libvirt domain usage. Signed-off-by: John Ferlan --- docs/aclpolkit.html.in | 4 +++ d

[libvirt] [PATCH 16/19] encryption: Add and to encryption

For a luks device, allow the configuration of a specific cipher to be used for encrypting the volume. Signed-off-by: John Ferlan --- docs/formatstorageencryption.html.in | 78 - docs/schemas/storagecommon.rng | 44 ++- src/conf/domain_conf.c

[libvirt] [PATCH 05/19] secret: Move virStorageSecretType and rename

Move the enum into a new src/util/virsecret.h, rename it to be virSecretLookupType. Add a src/util/virsecret.h in order to perform a couple of simple operations on the secret XML and virSecretLookupTypeDef for clearing and copying. This includes quite a bit of collateral damage, but the goal is to

[libvirt] [PATCH 11/19] util: Add 'usage' for encryption

In order to use more common code and set up for a future type, modify the encryption secret to allow the "usage" attribute or the "uuid" attribute to define the secret. The "usage" in the case of a volume secret would be the path to the volume. This code will make use of the virSecretParseSecret co

[libvirt] [PATCH 18/19] qemu: Add new secret info type

Add 'encinfo' to the extended disk structure. This will contain the encryption secret (if present). Signed-off-by: John Ferlan --- src/qemu/qemu_domain.c | 1 + src/qemu/qemu_domain.h | 5 + 2 files changed, 6 insertions(+) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index

[libvirt] [PATCH 17/19] storage: Add support to create a luks volume

If the volume xml was looking to create a luks volume take the necessary steps in order to make that happen. The processing will be: 1. create a temporary file in the storage pool target path 1a. the file name will either be $volname_$UUID.tmp or $volname_$USAGE.tmp depending on how the

[libvirt] [PATCH 04/19] storage: Use virSecretGetSecretString

Rather than inline code secret lookup for rbd/iscsi, use the common function. Signed-off-by: John Ferlan --- src/Makefile.am | 1 + src/storage/storage_backend_iscsi.c | 49 + src/storage/storage_backend_rbd.c | 48 +++---

[libvirt] [PATCH 06/19] util: Move and rename virStorageAuthDefParseSecret

Move to virsecret.c and rename to virSecretParseSecret. Also convert to usage xmlNodePtr and virXMLPropString rather than virXPathString. Signed-off-by: John Ferlan --- po/POTFILES.in| 1 + src/libvirt_private.syms | 1 + src/util/virsecret.c | 44

[libvirt] [PATCH 02/19] storage: Create helper to set backing for CreateQemuImg code

Create a helper virStorageBackendCreateQemuImgSetBacking to perform the backing store set Signed-off-by: John Ferlan --- src/storage/storage_backend.c | 116 +++--- 1 file changed, 64 insertions(+), 52 deletions(-) diff --git a/src/storage/storage_backend.c b

[libvirt] [PATCH 10/19] tests: Adjust tests for encrypted storage

Make them work again... The xml2xml had been working, but the xml2argv were not working. Making the xml2argv work required a few adjustments to the xml to update to more recent times. Signed-off-by: John Ferlan --- .../qemuxml2argv-encrypted-disk.args | 26 +-

[libvirt] [PATCH 03/19] storage: Create helper to set options for CreateQemuImg code

Create a helper virStorageBackendCreateQemuImgSetOptions to set either the qemu-img -o options or the previous mechanism using -F Signed-off-by: John Ferlan --- src/storage/storage_backend.c | 30 +- 1 file changed, 21 insertions(+), 9 deletions(-) diff --git a/src/s

[libvirt] [PATCH 01/19] storage: Adjust qemu-img switches check

Since we support QEMU 0.12 and later, checking for support of specific flags added prior to that isn't necessary. Thus start with the base of having the "-o options" available for the qemu-img create option and then determine whether we have the compat option for qcow2 files (which would be necess

[libvirt] [PATCH 08/19] qemu: Change protocol parameter for secret setup

Rather than assume/pass the protocol to the qemuDomainSecretPlainSetup and qemuDomainSecretAESSetup, determine and pass the secretUsageType which is then used in the virSecretGetSecretString call For the two callers that convert from virStorageNetProtocol, add a new helper qemuDomainSecretProtocol

[libvirt] [PATCH 07/19] util: Introduce virSecretFormatSecret

Add utility to format the virSecretLookupTypeDefPtr in XML Signed-off-by: John Ferlan --- src/libvirt_private.syms | 1 + src/util/virsecret.c | 26 ++ src/util/virsecret.h | 3 +++ src/util/virstoragefile.c | 19 +-- 4 files changed, 31 inser

[libvirt] [PATCH 09/19] qemu: Remove authdef from secret setup

Rather than pass authdef, pass the 'authdef->username' and the '&authdef->secdef' Note that a username may be NULL. Signed-off-by: John Ferlan --- src/qemu/qemu_domain.c | 37 ++--- 1 file changed, 22 insertions(+), 15 deletions(-) diff --git a/src/qemu/qemu_dom

[libvirt] [PATCH 00/19] Add support for LUKS encrypted devices

See RFC: http://www.redhat.com/archives/libvir-list/2016-June/msg00312.html For: https://bugzilla.redhat.com/show_bug.cgi?id=1301021 Changes since RFC: 1. Address Dan's comment regarding providing secinfo objects for both secret for RBD as well as secret for LUKS 2. Remove code from secret/

Re: [libvirt] [PATCH v5 0/2] Add support for zero-write detection

On 06/10/2016 06:12 PM, Martin Kletzander wrote: > v5: > - Reword documentation > - Use detect_zeroes=on if it is unmap but discard=ignore > - Use detect-zeroes on qemu cmdline instead of detect_zeroes > > v4: > - Changed docs per Peter's review > - https://www.redhat.com/archives/libvir-li

Re: [libvirt] [ruby-libvirt 2/2] Add volume upload example

On Sun, Jun 12, 2016 at 7:33 AM, Guido Günther wrote: > --- > examples/upload_volume.rb | 36 > 1 file changed, 36 insertions(+) > create mode 100644 examples/upload_volume.rb > > That example is great, thanks. I cleaned it up a little bit, moved it into do

Re: [libvirt] [PATCH V3 0/6] libxl: Add support for UEFI using OVMF

On 06/13/2016 03:29 AM, Michal Privoznik wrote: > On 11.06.2016 00:34, Jim Fehlig wrote: >> This is essentially a V3 of >> >> https://www.redhat.com/archives/libvir-list/2016-April/msg01358.html >> >> To avoid code duplication in that series, I proposed adding >> a virFirmware object that could be

Re: [libvirt] [PATCH v2 0/6] Introducing storage pool lifecycle event APIs

On 06/13/2016 01:35 PM, Cole Robinson wrote: > On 06/13/2016 12:38 PM, Jovanka Gulicoska wrote: >> Changes follow comments on v1 patches. >> >> Introducing implementation of storage pool event APIs. Code changes >> follow network event APIs. >> >> Implemented functions: virStoragePoolEventRegisterA

Re: [libvirt] Switch to a time based version number rule

On Mon, Jun 13, 2016 at 01:33:22PM -0400, Cole Robinson wrote: > On 06/13/2016 01:09 PM, Andrea Bolognani wrote: > > On Mon, 2016-06-13 at 17:58 +0100, Daniel P. Berrange wrote: > >>> If we really want to go time-based, why don't we keep it > >>> really straightforward and predictable and do > >>>

[libvirt] [PATCH] Bump release to 2.0.0 and document release schedule & versioning

This bumps the release number of 2.0.0, to reflect the switch to a new time based release versioning scheme. The downloads page is updated to describe our policies for release schedules and release version numbering The stable release docs are changed to reflect the fact that the stable version nu

Re: [libvirt] [PATCH v2 0/6] Introducing storage pool lifecycle event APIs

On 06/13/2016 12:38 PM, Jovanka Gulicoska wrote: > Changes follow comments on v1 patches. > > Introducing implementation of storage pool event APIs. Code changes > follow network event APIs. > > Implemented functions: virStoragePoolEventRegisterAny(), > virStoragePoolEventDeregisterAny(), virStor

Re: [libvirt] Switch to a time based version number rule

On Mon, Jun 13, 2016 at 07:09:49PM +0200, Andrea Bolognani wrote: > On Mon, 2016-06-13 at 17:58 +0100, Daniel P. Berrange wrote: > > > If we really want to go time-based, why don't we keep it > > > really straightforward and predictable and do > > >  > > >   July 2016 -> 2016.7.0 > > >   August

Re: [libvirt] Switch to a time based version number rule

On 06/13/2016 01:09 PM, Andrea Bolognani wrote: > On Mon, 2016-06-13 at 17:58 +0100, Daniel P. Berrange wrote: >>> If we really want to go time-based, why don't we keep it >>> really straightforward and predictable and do >>> >>>July 2016 -> 2016.7.0 >>>August 2016 -> 2016.8.0 >>>

Re: [libvirt] [PATCH] virt-host-validate: improve tests for arm/aarch64

On Fri, 2016-06-03 at 15:53 +0300, Riku Voipio wrote: > ARM/Aarch64 /proc/cpuinfo has no virtualization related flags. > Refactor the Qemu/KVM test a bit: >  > 1) run the "for hardware virtualization" test only on plaforms with known >cpuinfo flags (x86, s390) > 2) test for /dev/kvm also on pla

Re: [libvirt] Switch to a time based version number rule

On Mon, 2016-06-13 at 17:58 +0100, Daniel P. Berrange wrote: > > If we really want to go time-based, why don't we keep it > > really straightforward and predictable and do > >  > >   July 2016 -> 2016.7.0 > >   August 2016   -> 2016.8.0 > >   ... > >   January 2017  -> 2017.1.0 > >   February 2

Re: [libvirt] Switch to a time based version number rule

On Mon, Jun 13, 2016 at 06:57:01PM +0200, Andrea Bolognani wrote: > On Mon, 2016-06-13 at 17:42 +0100, Daniel P. Berrange wrote: > > On Mon, Jun 13, 2016 at 06:36:50PM +0200, Andrea Bolognani wrote: > > >  > > > On Mon, 2016-06-13 at 13:56 +0100, Daniel P. Berrange wrote: > > > >  > > > > I venture

Re: [libvirt] Switch to a time based version number rule

On Mon, 2016-06-13 at 17:42 +0100, Daniel P. Berrange wrote: > On Mon, Jun 13, 2016 at 06:36:50PM +0200, Andrea Bolognani wrote: > >  > > On Mon, 2016-06-13 at 13:56 +0100, Daniel P. Berrange wrote: > > >  > > > I venture to suggest that the reasons for switching from feature to > > > time based re

Re: [libvirt] Switch to a time based version number rule

On Mon, Jun 13, 2016 at 04:01:56PM +0200, Martin Kletzander wrote: > On Mon, Jun 13, 2016 at 01:56:54PM +0100, Daniel P. Berrange wrote: > > Currently libvirt uses a 3 digit version number, except when it uses > > a 4 digit version number. We have the following rules > > > > - major - no one has

Re: [libvirt] Switch to a time based version number rule

On Mon, Jun 13, 2016 at 11:12:34AM -0400, John Ferlan wrote: > > > On 06/13/2016 08:56 AM, Daniel P. Berrange wrote: > > Currently libvirt uses a 3 digit version number, except when it uses > > a 4 digit version number. We have the following rules > > > > - major - no one has any clue about wh

Re: [libvirt] [PATCH python 2/2] event-test: Add storage pool lifecycle event tests

On 06/11/2016 01:43 PM, Jovanka Gulicoska wrote: > --- > examples/event-test.py | 18 ++ > 1 file changed, 18 insertions(+) > > diff --git a/examples/event-test.py b/examples/event-test.py > index f96c917..241369b 100755 > --- a/examples/event-test.py > +++ b/examples/event-test.p

Re: [libvirt] [PATCH python 1/2] Python binding for storage pool lifecycle events API

On 06/11/2016 01:43 PM, Jovanka Gulicoska wrote: > --- > generator.py | 2 + > libvirt-override-virConnect.py | 35 ++ > libvirt-override.c | 153 > + > sanitytest.py | 3 +- > 4 files changed, 192

Re: [libvirt] Switch to a time based version number rule

On Mon, Jun 13, 2016 at 06:36:50PM +0200, Andrea Bolognani wrote: > On Mon, 2016-06-13 at 13:56 +0100, Daniel P. Berrange wrote: > > I venture to suggest that the reasons for switching from feature to > > time based release schedules, also apply to version numbers. IOW we > > should switch to a tim

[libvirt] [PATCH v2 4/6] remote: implement storage lifecycle event APIs

--- daemon/libvirtd.h| 2 + daemon/remote.c | 201 ++- src/remote/remote_driver.c | 128 +++ src/remote/remote_protocol.x | 43 - src/remote_protocol-structs | 16 5 files changed, 388 inse

[libvirt] [PATCH v2 6/6] event-test: support storage lifecycle event APIs

--- examples/object-events/event-test.c | 46 - 1 file changed, 45 insertions(+), 1 deletion(-) diff --git a/examples/object-events/event-test.c b/examples/object-events/event-test.c index c1ff4a7..a951230 100644 --- a/examples/object-events/event-test.c +++ b

[libvirt] [PATCH v2 2/6] conf: add storage_event handling

Add storage event handling infrastructure to storage_event.[ch], following the network_event.[ch] pattern. --- src/Makefile.am | 5 + src/conf/storage_conf.h | 4 + src/conf/storage_event.c | 237 +++ src/conf/storage_event.h | 60

[libvirt] [PATCH v2 5/6] storage: implement storage lifecycle event APIs

Implement storage pool event callbacks for START, STOP, DEFINE, UNDEFINED and REFRESHED in functions when a storage pool is created/started/stopped etc. accordingly --- src/storage/storage_driver.c | 110 +++ 1 file changed, 110 insertions(+) diff --git a/s

[libvirt] [PATCH v2 3/6] test: implement storage lifecycle event APIs

Also includes unittests for storage pool lifecycle events API --- src/test/test_driver.c | 71 +++ tests/objecteventtest.c | 177 2 files changed, 248 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c inde

[libvirt] [PATCH v2 1/6] Introduce storage lifecycle event APIs

Storage pool lifecycle event API entry points for registering and deregistering storage pool events, as well as types of events associated with storage pools. These entry points will be used for implementing asynchronous lifecycle events. Storage pool API: virConnectStoragePoolEventRegisterAny vir

[libvirt] [PATCH v2 0/6] Introducing storage pool lifecycle event APIs

Changes follow comments on v1 patches. Introducing implementation of storage pool event APIs. Code changes follow network event APIs. Implemented functions: virStoragePoolEventRegisterAny(), virStoragePoolEventDeregisterAny(), virStoragePoolLifeCycleEventNew(), introduced STARTED, STOPPED, DEFINE

Re: [libvirt] Switch to a time based version number rule

On Mon, 2016-06-13 at 13:56 +0100, Daniel P. Berrange wrote: > I venture to suggest that the reasons for switching from feature to > time based release schedules, also apply to version numbers. IOW we > should switch to a time based version number change rule, instead of > a feature based version n

Re: [libvirt] Switch to a time based version number rule

On 06/13/2016 08:56 AM, Daniel P. Berrange wrote: > Currently libvirt uses a 3 digit version number, except when it uses > a 4 digit version number. We have the following rules > > - major - no one has any clue about when we should bump this > - minor - bump this when some "significant"[*] f

[libvirt] [PATCH] qemu: Shorten domain name for watchdog coredump

Similarly to commit d294f6b0dff7, if the name is long enough, the filename can be longer than filesystem's limit. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1334237 Signed-off-by: Martin Kletzander --- src/qemu/qemu_driver.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-)

Re: [libvirt] [PATCH V3 5/6] xenconfig: support bios=ovmf xl.cfg

On 06/13/2016 03:33 AM, Michal Privoznik wrote: > On 11.06.2016 00:34, Jim Fehlig wrote: >> Add support to xenconfig for conversion of xl.cfg(5) bios config >> to/from libvirt domXml config. SeaBIOS is the default >> for HVM guests using upstream QEMU. ROMBIOS is the default when >> using the old

Re: [libvirt] Question about virtio-pci in Aarch64

On 06/12/2016 10:08 PM, Kevin Zhao wrote: > Hi Cole, > Thanks for your kindly help. > > On 13 June 2016 at 06:21, Cole Robinson > wrote: > > On 06/12/2016 10:29 AM, Kevin Zhao wrote: > > Hi Cole && All, > > Nice meeting you in the libvirt mail-li

Re: [libvirt] Switch to a time based version number rule

On Mon, Jun 13, 2016 at 01:56:54PM +0100, Daniel P. Berrange wrote: Currently libvirt uses a 3 digit version number, except when it uses a 4 digit version number. We have the following rules - major - no one has any clue about when we should bump this - minor - bump this when some "significant

Re: [libvirt] RFC: New CPU hot(un)plug API and XML

On Mon, Jun 13, 2016 at 02:48:51PM +0200, Peter Krempa wrote: Hi list, I'm planing on adding API that will be used instead of virDomainSetVcpus and will allow a more granular control of which virtual CPUs are enabled for a guest. The new approach will allow to use cpu hotplug properly with NUMA

[libvirt] [PATCH] qemu: Obtain job before checking if domain is live

Since obtaining a job can wait for another job to finish, the state might change in the meantime. And checking it more than once is pointless. Signed-off-by: Martin Kletzander --- src/qemu/qemu_driver.c | 36 +++- 1 file changed, 15 insertions(+), 21 deletions(-)

[libvirt] [PATCH] qemu: Allow ACPI shutdown only for running domains

If the domain is not running, but for example the CPUs are stopped, the ACPI event gets queued and resume of the domain will just shut it off. https://bugzilla.redhat.com/show_bug.cgi?id=1216281 Signed-off-by: Martin Kletzander --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+),

Re: [libvirt] Switch to a time based version number rule

On Mon, Jun 13, 2016 at 13:56:54 +0100, Daniel P. Berrange wrote: > So what I'm suggesting is that we adopt the following rule > > - major: bumped for the first release of each year > - minor: bumped for every major release > - micro: bumped for stable branch releases > > Rather than wait unti

Re: [libvirt] Question about virtio-pci in Aarch64

Hi Cole, Thanks for your kindly help. On 13 June 2016 at 06:21, Cole Robinson wrote: > On 06/12/2016 10:29 AM, Kevin Zhao wrote: > > Hi Cole && All, > > Nice meeting you in the libvirt mail-list. Greetings from Linaro !!! > > I am Kevin Zhao from Linaro and working for OpenStack o

Re: [libvirt] Libvirt multi queue support

Michal Privoznik redhat.com> writes: > > On 21.08.2013 07:31, Naor Shlomo wrote: > > Hello experts, > > > > > > > > Could anyone please tell me if Multi Queue it fully supported in Libvirt > > and if so what version contains it? > > > > Do you mean multiqueue network? It's supported from 1

[libvirt] Question about virtio-pci in Aarch64

Hi Cole && All, Nice meeting you in the libvirt mail-list. Greetings from Linaro !!! I am Kevin Zhao from Linaro and working for OpenStack on Aarch64. Nowadays I find that the default "virtio" bus is "virtio-mmio" , not "virtio-pci". Since virtio-mmio do not has the host plugged function

[libvirt] Switch to a time based version number rule

Currently libvirt uses a 3 digit version number, except when it uses a 4 digit version number. We have the following rules - major - no one has any clue about when we should bump this - minor - bump this when some "significant"[*] features appear - micro - bump this on each new release - e

[libvirt] RFC: New CPU hot(un)plug API and XML

Hi list, I'm planing on adding API that will be used instead of virDomainSetVcpus and will allow a more granular control of which virtual CPUs are enabled for a guest. The new approach will allow to use cpu hotplug properly with NUMA guests as the old APIs would not allow adding CPUs to very spec

Re: [libvirt] [PATCH] libxl: fix vm lock overwritten bug

On 12.06.2016 12:30, Wang Yufei wrote: > In libxl driver we do virObjectRef in libxlDomainObjBeginJob, > If virCondWaitUntil failed, it goes to error, do virObjectUnref, > There's a chance that someone undefine the vm at the same time, > and refs unref to zero, vm is freed in libxlDomainObjBeginJob

Re: [libvirt] [PATCH] virt-host-validate: improve tests for arm/aarch64

On 03.06.2016 14:53, Riku Voipio wrote: > ARM/Aarch64 /proc/cpuinfo has no virtualization related flags. > Refactor the Qemu/KVM test a bit: > > 1) run the "for hardware virtualization" test only on plaforms with known >cpuinfo flags (x86, s390) > 2) test for /dev/kvm also on platforms where n

Re: [libvirt] [GSoC] Abstracting device address allocation

On Mon, Jun 13, 2016 at 04:44:53AM +0200, Tomasz Flendrich wrote: Thank you for your input, I really appreciate it. My goal was to define a data structure with a minimal set of features that would make sense and could be further developed. I know of a few problems with PCI address allocation,

Re: [libvirt] [PATCH] tests: fix CPUID detection tests compilation failure

On Mon, Jun 13, 2016 at 10:11:41 +0100, Wei Liu wrote: > In 3704b9003 ("tests: Add CPU detection tests"), a macro called > DO_TEST_CPUID_JSON is added. But it took only two arguments when QEMU > or YAJL is not set. > > Fix it by adding a third argument. Shouldn't have any effect because > that mac

[libvirt] [PATCH] sasl auth：add default mapping of credentials to machines

hi,all: in production environment, it is important to keep safe. libvirt does automatic validation, but it needs to set up mapping for each machine. this patch is to add default certificate mapping , make it easy in lange scale environment. maybe another way is using regex to do exact matc

Re: [libvirt] [PATCH] virt-login-shell: mark as Linux only

Daniel P. Berrange wrote: > On Sun, Jun 12, 2016 at 12:11:09PM +0300, Roman Bogorodskiy wrote: > > Currently, virt-login-shell is not allowed to build on Windows. > > Howerver, as it's designed around LXC, it does not make sense to > > build it on anything but Linux, so make the check strickter

Re: [libvirt] Bump tar format?

On Mon, 2016-06-13 at 09:57 +0100, Daniel P. Berrange wrote: > > Since RHEL5 support has been dropped for a while now, maybe it's time to > > revisit changing the tar format > > Yep, IIUC we should be fine for require pax support for the vintage of > Linux we required.  *BSD should be fine too, so

Re: [libvirt] [PATCH V3 5/6] xenconfig: support bios=ovmf xl.cfg

On 11.06.2016 00:34, Jim Fehlig wrote: > Add support to xenconfig for conversion of xl.cfg(5) bios config > to/from libvirt domXml config. SeaBIOS is the default > for HVM guests using upstream QEMU. ROMBIOS is the default when > using the old qemu-dm. This patch allows specifying OVMF as an > alt

Re: [libvirt] [PATCH V3 0/6] libxl: Add support for UEFI using OVMF

On 11.06.2016 00:34, Jim Fehlig wrote: > This is essentially a V3 of > > https://www.redhat.com/archives/libvir-list/2016-April/msg01358.html > > To avoid code duplication in that series, I proposed adding > a virFirmware object that could be used by multiple drivers > > https://www.redhat.com/a

[libvirt] [PATCH] tests: fix CPUID detection tests compilation failure

In 3704b9003 ("tests: Add CPU detection tests"), a macro called DO_TEST_CPUID_JSON is added. But it took only two arguments when QEMU or YAJL is not set. Fix it by adding a third argument. Shouldn't have any effect because that macro compiles to nothing. Signed-off-by: Wei Liu --- Cc: Jiri Denem

Re: [libvirt] [PATCH 4/4] bhyve: fix bhyvexml2arg test

On Sun, Jun 12, 2016 at 11:10:40AM +0300, Roman Bogorodskiy wrote: > Don't use duplicating target dev names. > --- > tests/bhyvexml2argvdata/bhyvexml2argv-bhyveload-bootorder.xml | 2 +- > tests/bhyvexml2argvdata/bhyvexml2argv-bhyveload-bootorder1.xml | 2 +- > tests/bhyvexml2argvdata/bhyvexml2ar

Re: [libvirt] [PATCH 3/4] bhyve: add missing virhost(cpu|mem).h headers

On Sun, Jun 12, 2016 at 11:10:39AM +0300, Roman Bogorodskiy wrote: > --- > src/bhyve/bhyve_driver.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c > index 6d21c2e..4ed5702 100644 > --- a/src/bhyve/bhyve_driver.c > +++ b/src/bhyve/bhy

Re: [libvirt] [PATCH 2/4] hostcpu: fix build on FreeBSD

On Sun, Jun 12, 2016 at 11:10:38AM +0300, Roman Bogorodskiy wrote: > * Fix misspelt function name: > s/virHostCPUGetStatsFreebsd/virHostCPUGetStatsFreeBSD/ > * Mark the first argument to virHostCPUGetInfo with ATTRIBUTE_UNUSED >as it's not actually used on non-Linux > --- > src/util/virh

Re: [libvirt] Bump tar format?

On Sat, Jun 11, 2016 at 10:14:11AM -0400, Cole Robinson wrote: > This issue appeared again: > On 07/22/2015 11:57 AM, Eric Blake wrote: > > On 07/22/2015 08:44 AM, Andrea Bolognani wrote: > >> 1. rename the test case, making it shorter; > > > > Works if we can do it, but I agree we should add a

Re: [libvirt] [PATCH 1/4] nodeinfo: fix build on non-Linux

On Sun, Jun 12, 2016 at 11:10:37AM +0300, Roman Bogorodskiy wrote: > SYSFS_SYSTEM_PATH is only defined for Linux, however it's used outside > of #ifdef __linux__ code, e.g. as the first argument to > nodeCapsInitNUMAFake(). > > But as this argument's value is used on Linux only, it's safe to defin

Re: [libvirt] [PATCH] virt-login-shell: mark as Linux only

On Sun, Jun 12, 2016 at 12:11:09PM +0300, Roman Bogorodskiy wrote: > Currently, virt-login-shell is not allowed to build on Windows. > Howerver, as it's designed around LXC, it does not make sense to > build it on anything but Linux, so make the check strickter and allow to > enable it on Linux onl