[libvirt] is there a plan to support internal-rbd-snapshot?

hi, is there a plan to support internal-rbd-snapshot? any one is responsible for it? thanks-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/4] Move ccwaddrs and pciaddrs to domainDef

> Apologies if I'm missing something, I didn't look too closely at this series, > however have you seen this thread? > > http://www.redhat.com/archives/libvir-list/2016-May/msg01071.html I haven’t noticed that some work has been done on that, thank you! > My understanding of the current code is

Re: [libvirt] [PATCH 1/1] perf: add more perf events support

> -Original Message- > From: libvir-list-boun...@redhat.com [mailto:libvir-list-boun...@redhat.com] > On Behalf Of Ren, Qiaowei > Sent: Sunday, June 12, 2016 10:14 AM > To: Peter Krempa > Cc: libvir-list@redhat.com > Subject: Re: [libvirt] [PATCH 1/1] perf: add more

Re: [libvirt] [PATCH RFC] libxl: set serial source path for console type=serial

Joao Martins wrote: > Guests use a (and sometimes pair) to represent > the console. On the callback that is called when console is brought up > (NB: before domain starts), we fill the path of the console element with > the appropriate "/dev/pts/X". For PV guests it all works fine, although > for

[libvirt] [PATCH 1/3] qmp: Add query-host-cpu command

The command can be used to return host-specific CPU capabilities information. Signed-off-by: Eduardo Habkost --- include/sysemu/arch_init.h | 1 + qapi-schema.json | 36 qmp-commands.hx | 6 ++

[libvirt] [PATCH 0/3] qmp: query-host-cpu command

Add QMP command to allow management software to query for CPU information for the running host. The data returned by the command is in the form of a dictionary of QOM properties. This series depends on the "Add runnability info to query-cpu-definitions" series I sent 2 weeks ago. Git tree:

[libvirt] [PATCH 3/3] target-i386: Implement arch_query_host_cpu_info()

Return information on the host CPU using the "host" CPU model. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 64 +++ 1 file changed, 64 insertions(+) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index

[libvirt] [PATCH 2/3] target-i386: Introduce x86_cpu_load_host_data() function

The code that loads host-specific information inside x86_cpu_realizefn() will be reused by the implementation of query-host-cpu, so move it to a separate function. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 23 --- 1 file changed, 16

Re: [libvirt] [Qemu-devel] [PATCH v2 0/6] Add runnability info to query-cpu-definitions

Ping? No other feedback on this? On Mon, Jun 06, 2016 at 05:05:37PM -0300, Eduardo Habkost wrote: > This series extends query-cpu-definitions to include an extra > field: "unavailable-features". The new field can be used to find > out reasons that prevent the CPU model from running in the >

[libvirt] [PATCH] conf: limit chassisNr, and busNr to a minimum value of 1, not 0

In the case of chassisNr (used to set chassis_nr of a pci-bridge controller), 0 is reserved for / used by the pci[e]-root bus. In the base of busNr, a value of 0 would mean that the root bus had no places available to plug in new buses, including the pxb itself (the documentation I wrote for pxb

[libvirt] [PATCH RFC] libxl: set serial source path for console type=serial

Guests use a (and sometimes pair) to represent the console. On the callback that is called when console is brought up (NB: before domain starts), we fill the path of the console element with the appropriate "/dev/pts/X". For PV guests it all works fine, although for HVM guests it doesn't.

Re: [libvirt] [PATCH] storage: Fix several issues with transient pool cleanup

On 06/20/2016 12:18 PM, Jovanka Gulicoska wrote: > There are several cases where we do not handle transient pool destroy > and cleanup correctly. For example: > > https://bugzilla.redhat.com/show_bug.cgi?id=1227475 > > Move the pool cleanup logic to a new function storagePoolSetInactive and >

Re: [libvirt] [PATCH 3/3] vsh: remove namespace poisoning

On 06/20/2016 11:28 AM, Ján Tomko wrote: We already have a syntax-check to prohibit direct use of these allocation functions. Yep. This was added in commit d9adac in 2010, well before we had such syntax rules, but it's pointless now. ACK. --- tools/vsh.c | 6 -- tools/vsh.h | 10

Re: [libvirt] [PATCH 2/3] vbox: remove duplicate macros

On 06/20/2016 11:28 AM, Ján Tomko wrote: There is a definiton of VIR_FROM_THIS just two lines above. The rest is defined in vbox_common.h. --- src/vbox/vbox_driver.c | 2 -- src/vbox/vbox_network.c | 43 --- 2 files changed, 45 deletions(-) ACK.

Re: [libvirt] [PATCH] virsh: introduce name-uuid for list command

On 06/20/2016 10:51 AM, Chen Hanxiao wrote: > > At 2016-06-20 21:38:42, "Peter Krempa" wrote: >> On Mon, Jun 20, 2016 at 19:22:45 +0800, Chen Hanxiao wrote: >>> >>> At 2016-06-15 17:36:05, "Chen Hanxiao" wrote: From: Chen Hanxiao

Re: [libvirt] [PATCH 1/3] Remove unused SOL_NETLINK macro

On 06/20/2016 11:28 AM, Ján Tomko wrote: Introduced by commit d575679, unused at the time. --- src/util/virnetlink.c | 4 1 file changed, 4 deletions(-) diff --git a/src/util/virnetlink.c b/src/util/virnetlink.c index 5491ece..513f36e 100644 --- a/src/util/virnetlink.c +++

[libvirt] [PATCH] storage: Fix several issues with transient pool cleanup

There are several cases where we do not handle transient pool destroy and cleanup correctly. For example: https://bugzilla.redhat.com/show_bug.cgi?id=1227475 Move the pool cleanup logic to a new function storagePoolSetInactive and use it consistently. --- src/storage/storage_driver.c | 38

Re: [libvirt] [PATCH v3 4/4] util: Make failure to get supplementary group list for a uid non-fatal

On Mon, Jun 20, 2016 at 08:10:10 -0400, John Ferlan wrote: > > > On 06/17/2016 09:44 AM, Peter Krempa wrote: > > Since introduction of the DAC security driver we've documented that > > seclabels with a leading + can be used with numerical uid. This would > > not work though with the rest of

[libvirt] [PATCH 2/3] vbox: remove duplicate macros

There is a definiton of VIR_FROM_THIS just two lines above. The rest is defined in vbox_common.h. --- src/vbox/vbox_driver.c | 2 -- src/vbox/vbox_network.c | 43 --- 2 files changed, 45 deletions(-) diff --git a/src/vbox/vbox_driver.c

[libvirt] [PATCH 0/3] Remove unused macros

Ján Tomko (3): Remove unused SOL_NETLINK macro vbox: remove duplicate macros vsh: remove namespace poisoning src/util/virnetlink.c | 4 src/vbox/vbox_driver.c | 2 -- src/vbox/vbox_network.c | 43 --- tools/vsh.c | 6 --

[libvirt] [PATCH 1/3] Remove unused SOL_NETLINK macro

Introduced by commit d575679, unused at the time. --- src/util/virnetlink.c | 4 1 file changed, 4 deletions(-) diff --git a/src/util/virnetlink.c b/src/util/virnetlink.c index 5491ece..513f36e 100644 --- a/src/util/virnetlink.c +++ b/src/util/virnetlink.c @@ -42,10 +42,6 @@ #include

[libvirt] [PATCH 3/3] vsh: remove namespace poisoning

We already have a syntax-check to prohibit direct use of these allocation functions. --- tools/vsh.c | 6 -- tools/vsh.h | 10 -- 2 files changed, 16 deletions(-) diff --git a/tools/vsh.c b/tools/vsh.c index 8649305..2b78919 100644 --- a/tools/vsh.c +++ b/tools/vsh.c @@ -71,9 +71,6

Re: [libvirt] [PATCH 2/6] tests: mock gnutls_dh_params_generate2

On Fri, Jun 17, 2016 at 20:04:37 +0200, Ján Tomko wrote: > This function generates some big random numbers. > > Cache the result and supply it to any subsequent generate2 calls. > --- > tests/virnettlscontexttest.c | 2 +- > tests/virnettlssessiontest.c | 2 +- > tests/virrandommock.c|

Re: [libvirt] [PATCH 6/6] Mark virsh-optparse as expensive

On Fri, Jun 17, 2016 at 20:04:41 +0200, Ján Tomko wrote: > --- > tests/virsh-optparse | 2 ++ > 1 file changed, 2 insertions(+) ACK -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 3/6] Introduce virsh self-test

On Fri, Jun 17, 2016 at 20:04:38 +0200, Ján Tomko wrote: > A new hidden command for virsh that will iterate over > all command groups and commands and print help for every single one. > > This involves running vshCmddefOptParse so we can get an error if > one of the command's option structure is

Re: [libvirt] [PATCH 4/6] Remove virsh-synopsis

On Fri, Jun 17, 2016 at 20:04:39 +0200, Ján Tomko wrote: > This tests checks that the first word after SYNOPSIS > in virsh help ${command} output is ${command}. > > This was only good to check that the command option structures > are valid, which is now served by 'virsh self-test'. > --- >

[libvirt] [PATCH 7/7] add VirtualBox 5 support to vbox_storage.c

add VirtualBox 5 support to vbox_storage.c From 7baa733a9eef6b084728e4705c3e738ae66f9f77 Mon Sep 17 00:00:00 2001 From: Martin Pietsch Date: Sun, 19 Jun 2016 15:19:04 +0200 Subject: [PATCH 7/7] add VirtualBox 5 support to vbox_storage.c --- src/vbox/vbox_storage.c

[libvirt] [PATCH 6/7] add VirtualBox 5 support to vbox_common.h

add VirtualBox 5 support to vbox_common.h From ddafff36a0a629fa3e9deddf7ee4533bbf320e9e Mon Sep 17 00:00:00 2001 From: Martin Pietsch Date: Sun, 19 Jun 2016 15:09:03 +0200 Subject: [PATCH 6/7] add VirtualBox 5 support to vbox_common.h --- src/vbox/vbox_common.h |

[libvirt] [PATCH 5/7] append vbox_V5_0.c and vbox_CAPI_v5_0.h to src/Makefile.am

append vbox_V5_0.c and vbox_CAPI_v5_0.h to src/Makefile.am From 4cc0c754aeb889517f603641f2965a071d22e61d Mon Sep 17 00:00:00 2001 From: Martin Pietsch Date: Sun, 19 Jun 2016 15:00:05 +0200 Subject: [PATCH 5/7] append vbox_V5_0.c and vbox_CAPI_v5_0.h to

[libvirt] [PATCH 4/7] add vbox_V5_0.c for libvirt support of VirtualBox 5

add vbox_V5_0.c for libvirt support of VirtualBox 5 From 61fe1b371d8aa4adc21c329e1d6c5e112cc3af4f Mon Sep 17 00:00:00 2001 From: Martin Pietsch Date: Sun, 19 Jun 2016 14:56:39 +0200 Subject: [PATCH 4/7] add vbox_V5_0.c for libvirt support of VirtualBox 5 ---

[libvirt] [PATCH 3/7] add VirtualBox5 support to vbox_uniformed_api.h

add VirtualBox5 support to vbox_uniformed_api.h From 81250fafc8f0a1eee05a994e6373cc9cfe19d723 Mon Sep 17 00:00:00 2001 From: Martin Pietsch Date: Sun, 19 Jun 2016 14:50:23 +0200 Subject: [PATCH 3/7] add VirtualBox5 support to vbox_uniformed_api.h ---

Re: [libvirt] [PATCH 5/6] Drop virrandomtest

On Fri, Jun 17, 2016 at 20:04:40 +0200, Ján Tomko wrote: > This test only checks if mocking of virRandomBytes works correctly. > > Drop it to avoid infinite recursion by testing the test suite. > --- > tests/Makefile.am | 5 --- > tests/virrandomtest.c | 86 >

[libvirt] [PATCH 2/7] add VirtualBox 5 support to vbox_tmpl.c

add VirtualBox 5 support to vbox_tmpl.c From 96a6fbaf8bcc6b8ee4e91b23bb5b1f04f2a94a5d Mon Sep 17 00:00:00 2001 From: Martin Pietsch Date: Sun, 19 Jun 2016 14:28:25 +0200 Subject: [PATCH 2/7] add VirtualBox 5 support to vbox_tmpl.c --- src/vbox/vbox_tmpl.c | 84

[libvirt] [PATCH 1/7] add VirtualBox 5 C API to libvirt

add VirtualBox 5 C API to libvirt ý7zXZæÖ´F!
ÏXÌë×Qð
]#‰æöß(vŒã C{ôö— D£xÔ<¨ ,}{ôBa}œ(ÈÝV’"~[FdŸ x€D‡ø¯3`Y™9ö©¹.¹n–J> 8.ÔGrá3£ð*1²ƒ× ʒáfl›³[¤œ’¶m· SÆ¿ÄïŒÀlúAû|mGÞÉf¾OWÁ§W«mV,“œ:7‘

Re: [libvirt] [PATCH] virsh: introduce name-uuid for list command

At 2016-06-20 21:38:42, "Peter Krempa" wrote: >On Mon, Jun 20, 2016 at 19:22:45 +0800, Chen Hanxiao wrote: >> >> At 2016-06-15 17:36:05, "Chen Hanxiao" wrote: >> >From: Chen Hanxiao >> > >> >This patch will show both name and

[libvirt] [PATCH 2/7] lib: Add API to query guest vcpu info using guest agent

Add a rather universal API implemented via typed params that will allow to query the guest agent for the state and possibly other aspects of guest vcpus. --- include/libvirt/libvirt-domain.h | 5 src/driver-hypervisor.h | 7 + src/libvirt-domain.c | 56

[libvirt] [PATCH 6/7] qemu: Implement virDomainGetGuestVcpus

Allow gathering available vcpu ids, their state and offlinability via the qemu guest agent. The maximum id was chosen arbitrarily and ought to be enough for everybody. --- src/qemu/qemu_driver.c | 114 + 1 file changed, 114 insertions(+) diff --git

[libvirt] [PATCH 3/7] lib: Add API to set individual vcpu usage in the guest via guest agent

To allow finer-grained control of vcpu state using guest agent this API can be used to individually set the state of the vCPU. This will allow to better control NUMA enabled guests and/or test various vCPU configurations. --- include/libvirt/libvirt-domain.h | 5 src/driver-hypervisor.h

[libvirt] [PATCH 4/7] virsh: Add command 'guestvcpus' implementing virDomain(GS)etGuestVcpus

Add a straightforward implementation for using the new APIs. --- tools/virsh-domain.c | 93 tools/virsh.pod | 10 ++ 2 files changed, 103 insertions(+) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index bd6db47..ff2305f

[libvirt] [PATCH 7/7] qemu: Implement virDomainSetGuestVcpus

Allow modification of specific vCPU states via the guest agent. --- src/qemu/qemu_driver.c | 83 ++ 1 file changed, 83 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 5b96ad8..4bd8c92 100644 ---

[libvirt] [PATCH 5/7] qemu: agent: Make setting of vcpus more robust

Documentation for the "guest-set-vcpus" command describes a proper algorithm how to set vcpus. This patch makes the following changes: - state of cpus that has not changed is not updated - if the command was partially successful the command is re-tried with the rest of the arguments to get a

[libvirt] [PATCH 1/7] rpcgen: Add support for generating funcs returning alloc'd typed params

Since it's rather tedious to write the dispatchers for functions that return an array of typed parameters (which are rather common) let's add some rpcgen code to generate them. --- src/remote/remote_protocol.x | 5 + src/rpc/gendispatch.pl | 45

[libvirt] [PATCH 0/7] Add APIs for individual vCPU state modification using the guest agent

As a first step, add the guest-agent part. The real hotplug stuff will follow shortly. Please note that the setter API will be used as template for the real stuff too. Peter Krempa (7): rpcgen: Add support for generating funcs returning alloc'd typed params lib: Add API to query guest

[libvirt] [PATCH 6/7] Add SASL to virNetSocket{Local, Remote}AddrString

Rename them to virNetSocket{Local,Remote}AddrStringSASL to make their format more obvious. --- src/libvirt_remote.syms | 4 ++-- src/rpc/virnetclient.c | 4 ++-- src/rpc/virnetserverclient.c | 4 ++-- src/rpc/virnetsocket.c | 4 ++-- src/rpc/virnetsocket.h | 4 ++--

[libvirt] [PATCH 3/7] Introduce virNetServerClientRemoteAddrStringURI

Use it in virNetServerClientGetInfo to switch back to using the URI-format (separated by ':') instead of the SASL format (separated by ';'). Also use it in the error message reported byvirNetServerAddClient. --- src/libvirt_remote.syms | 1 + src/rpc/virnetserver.c | 2 +-

[libvirt] [PATCH 1/7] Revert "virnetsocket: Provide socket address format in a more standard form"

This partially reverts commit 9b45c9f049a7e9b6c1abfa6988b63b760714e169. It changed the default format of socket address from the one SASL requires, but did not adjust all the callers. It also removed the test coverage for it. Revert most of the changes except the virSocketAddrFormatFull support

[libvirt] [PATCH 5/7] virNetSocket: rename AddrStr to AddrStrSASL

Make it more obvious that these are in the SASL format. --- src/rpc/virnetsocket.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/rpc/virnetsocket.c b/src/rpc/virnetsocket.c index f10b62b..00dc417 100644 --- a/src/rpc/virnetsocket.c +++

[libvirt] [PATCH 2/7] Introduce virNetSocketRemoteAddrStringURI

Add a test case to virnetsockettest. --- src/libvirt_remote.syms | 1 + src/rpc/virnetsocket.c | 10 ++ src/rpc/virnetsocket.h | 1 + tests/virnetsockettest.c | 10 ++ 4 files changed, 22 insertions(+) diff --git a/src/libvirt_remote.syms b/src/libvirt_remote.syms index

[libvirt] [PATCH 7/7] Rename virNetServerClient*AddrString

Add SASL at the end to make the format obvious. --- daemon/remote.c | 4 ++-- src/libvirt_remote.syms | 4 ++-- src/rpc/virnetserverclient.c | 4 ++-- src/rpc/virnetserverclient.h | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/daemon/remote.c

[libvirt] [PATCH 0/7] Fix SASL authentication regression

Introduced by commit 9b45c9f, released in v1.3.5. https://bugzilla.redhat.com/show_bug.cgi?id=1345743 Ján Tomko (7): Revert "virnetsocket: Provide socket address format in a more standard form" Introduce virNetSocketRemoteAddrStringURI Introduce virNetServerClientRemoteAddrStringURI

[libvirt] [PATCH 4/7] virnetsockettest: fix error messages

--- tests/virnetsockettest.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/virnetsockettest.c b/tests/virnetsockettest.c index 8cd8ede..4d78d27 100644 --- a/tests/virnetsockettest.c +++ b/tests/virnetsockettest.c @@ -271,7 +271,7 @@ static int

Re: [libvirt] [PATCH 0/2] Fix leak and labels in virDomainGraphicsListensParseXML

ACK series -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 1/7] domain_conf: Validate redirdev after parsing

On 20.06.2016 10:32, Ján Tomko wrote: > On Fri, Jun 10, 2016 at 05:32:55PM +0200, Michal Privoznik wrote: >> There's currently just one limitation: redirdevs that want to go >> on USB bus require a USB controller, surprisingly. >> At the same time, since I'm using virDomainDefHasUSB() in this >>

Re: [libvirt] gnulib and 32-bit libvirt build, rpl_canonicalize_file_name

Ján Tomko writes ("Re: [libvirt] gnulib and 32-bit libvirt build, rpl_canonicalize_file_name"): > This has been fixed in gnulib already: > http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=246b3b2 > commit 246b3b28808ee5f4664be674dce573af9497fc7a > Author: Eric Blake

Re: [libvirt] [PATCH] virsh: introduce name-uuid for list command

On Mon, Jun 20, 2016 at 19:22:45 +0800, Chen Hanxiao wrote: > > At 2016-06-15 17:36:05, "Chen Hanxiao" wrote: > >From: Chen Hanxiao > > > >This patch will show both name and UUID of domain: > > > > IdName State

[libvirt] [PATCH 1/2] conf: Fix memory leak in graphics XML parser

When loading status XMLs with following graphics definition: libvirtd would leak a few bytes: 10 bytes in 1 blocks are definitely lost in loss record 71 of 1,127 at 0x4C2C000: malloc (vg_replace_malloc.c:299) by 0x6789298: xmlStrndup (in /usr/lib64/libxml2.so.2.9.4) by

[libvirt] [PATCH 0/2] Fix leak and labels in virDomainGraphicsListensParseXML

Peter Krempa (2): conf: Fix memory leak in graphics XML parser conf: Fix label name in virDomainGraphicsListensParseXML src/conf/domain_conf.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) -- 2.8.3 -- libvir-list mailing list libvir-list@redhat.com

[libvirt] [PATCH 2/2] conf: Fix label name in virDomainGraphicsListensParseXML

Use 'cleanup' since it's also used on success. --- src/conf/domain_conf.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 0b642a1..f208682 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@

Re: [libvirt] [PATCH 0/4] Move ccwaddrs and pciaddrs to domainDef

On 06/19/2016 08:18 PM, Tomasz Flendrich wrote: > This patch depends on another one, because it was created on top > of the changes in the other one. Link to the dependency: > https://www.redhat.com/archives/libvir-list/2016-June/msg01227.html > > This is the next patch of the ongoing process of

Re: [libvirt] [PATCH] util: fix a typo

On Mon, 2016-06-20 at 19:52 +0800, Chen Hanxiao wrote: > From: Chen Hanxiao > > s/succcess/success > > Signed-off-by: Chen Hanxiao > --- >  src/util/virfile.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [libvirt] [PATCH] docs: virsh: Added note for the dump command

On Mon, Jun 20, 2016 at 01:34:28PM +0200, jsuch...@redhat.com wrote: From: Jaroslav Suchanek Feel free to fix your git send-email settings if you used that to send the patch, or otherwise fix your MUA or whatever you used. Crash dump in a old kvmdump format is being

[libvirt] [PATCH] util: fix a typo

From: Chen Hanxiao s/succcess/success Signed-off-by: Chen Hanxiao --- src/util/virfile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virfile.c b/src/util/virfile.c index 9d460b9..f47bf39 100644 ---

Re: [libvirt] [PATCH v3 2/4] tools: virt-login-shell: Fix cut'n'paste mistake in error message

On Fri, Jun 17, 2016 at 03:44:10PM +0200, Peter Krempa wrote: > Whine about 'allowed_users' having wrong format rather than 'shell' > --- > tools/virt-login-shell.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) ACK -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH v3 4/4] util: Make failure to get supplementary group list for a uid non-fatal

On 06/17/2016 09:44 AM, Peter Krempa wrote: > Since introduction of the DAC security driver we've documented that > seclabels with a leading + can be used with numerical uid. This would > not work though with the rest of libvirt if the uid was not actually > used in the system as we'd fail when

Re: [libvirt] [PATCH v3 1/4] tools: virt-login-shell: Fix group list bounds checking

On Fri, Jun 17, 2016 at 03:44:09PM +0200, Peter Krempa wrote: > The list certainly isn't zero terminated and it would isallow usage of s/isallow/disallow/ > group 'root'. Pass in the array size and match against it. > --- > tools/virt-login-shell.c | 7 --- > 1 file changed, 4

Re: [libvirt] gnulib and 32-bit libvirt build, rpl_canonicalize_file_name

On Mon, Jun 20, 2016 at 12:37:23PM +0100, Ian Jackson wrote: The Xen Project's automated test (CI) system has reported a build failure in libvirt; libvirt uses gnulib. osstest has bisected it to a specific gnulib commit. (Email from osstest is quoted below.) The error message is:

[libvirt] gnulib and 32-bit libvirt build, rpl_canonicalize_file_name

The Xen Project's automated test (CI) system has reported a build failure in libvirt; libvirt uses gnulib. osstest has bisected it to a specific gnulib commit. (Email from osstest is quoted below.) The error message is: ../gnulib/lib/.libs/libgnu.a(canonicalize-lgpl.o): In function

[libvirt] [PATCH] docs: virsh: Added note for the dump command

From: Jaroslav Suchanek Crash dump in a old kvmdump format is being obsolete and cannot be loaded and processed by crash utility since its version 6.1.0. A --memory-only option is required in order to produce valid ELF file which can be later processed by the crash utility.

Re: [libvirt] [PATCH] virsh: introduce name-uuid for list command

At 2016-06-15 17:36:05, "Chen Hanxiao" wrote: >From: Chen Hanxiao > >This patch will show both name and UUID of domain: > > IdName State UUID >

Re: [libvirt] [PATCH] virsh migrate: Fix positional parameters

On Mon, Jun 20, 2016 at 10:31:32AM +0200, Jiri Denemark wrote: > Thanks to our smart option parser which automatically assigns positional > parameters the following (previously working) command fails: > > virsh migrate test qemu+ssh://1.2.3.4/system tcp://1.2.3.4/ > error: invalid

Re: [libvirt] [PATCH] virsh migrate: Fix positional parameters

On Mon, 2016-06-20 at 10:31 +0200, Jiri Denemark wrote: > Thanks to our smart option parser which automatically assigns positional > parameters the following (previously working) command fails: > > virsh migrate test qemu+ssh://1.2.3.4/system tcp://1.2.3.4/ > error: invalid argument:

Re: [libvirt] [PATCH 1/6] Remove virsh-all

On Fri, Jun 17, 2016 at 20:04:36 +0200, Ján Tomko wrote: > Since e8ac4a7 this test wastes some CPU cycles by blindly trying to > run almost every virsh command, blindly throwing away the output > and the return value and returning success if 'virsh help' successfully > returned at least one

[libvirt] [PATCH 2/2] vz: add vzDomainGetJobStats

Signed-off-by: Nikolay Shirokovskiy --- src/vz/vz_driver.c | 71 ++ 1 file changed, 71 insertions(+) diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c index 7be2a5a..8141a90 100644 --- a/src/vz/vz_driver.c +++

[libvirt] [PATCH 0/2] vz: add getting job info for migration

Nikolay Shirokovskiy (2): vz: add getting job info for migration vz: add vzDomainGetJobStats src/vz/vz_driver.c | 113 + src/vz/vz_sdk.c| 31 +++ src/vz/vz_utils.c | 42 src/vz/vz_utils.h | 17

[libvirt] [PATCH 1/2] vz: add getting job info for migration

Unfortunately vz sdk do not provide detail information on migration progress, only progress percentage. Thus vz driver provides percents instead of bytes in data fields of virDomainJobInfoPtr. Signed-off-by: Nikolay Shirokovskiy --- src/vz/vz_driver.c | 42

[libvirt] [PATCH 0/7] *** Add VirtualBox 5 support to libvirt ***

*** BLURB HERE *** Martin Pietsch (7): add VirtualBox 5 C API to libvirt add VirtualBox 5 support to vbox_tmpl.c add VirtualBox5 support to vbox_uniformed_api.h add vbox_V5_0.c for libvirt support of VirtualBox 5 append vbox_V5_0.c and vbox_CAPI_v5_0.h to src/Makefile.am add

Re: [libvirt] [PATCH] vz: handle gracefully races on undefining domain

On 20.06.2016 10:40, Nikolay Shirokovskiy wrote: > This patch is not critical but nice to have. The original motivation > was error message in logs on undefining domain thru vz driver. > Undefine procedure drops domain lock while waiting for detaching > disks vz sdk call. Meanwhile vz sdk

Re: [libvirt] [PATCH v2] maint: Switch to xz compressed PAX release archives

On Wed, Jun 15, 2016 at 10:31:16AM -0400, Laine Stump wrote: On 06/15/2016 09:03 AM, Andrea Bolognani wrote: This allows us to produce releases that are roughly a third in size, have no limitation on path length, and are still readable by all supported platforms. --- I just want to point out

Re: [libvirt] [PATCH v2 1/7] domain_conf: Validate redirdev after parsing

On Fri, Jun 10, 2016 at 05:32:55PM +0200, Michal Privoznik wrote: There's currently just one limitation: redirdevs that want to go on USB bus require a USB controller, surprisingly. At the same time, since I'm using virDomainDefHasUSB() in this new validator function, it has to be moved a few

[libvirt] [PATCH] virsh migrate: Fix positional parameters

Thanks to our smart option parser which automatically assigns positional parameters the following (previously working) command fails: virsh migrate test qemu+ssh://1.2.3.4/system tcp://1.2.3.4/ error: invalid argument: Unsupported compression method 'tcp://1.2.3.4/' We need to make

Re: [libvirt] [PATCH] qemu: Don't use legacy USB for aarch64 mach-virt guests

On Sat, 2016-06-18 at 10:12 +0200, Andrew Jones wrote: > > > ACK from me. > > > > Great, thanks! I'll wait for Drew's thumbs up before > > actually pushing this, though. > > Thumbs up. > > -usb should probably even be removed from QEMU. The help > text says > >  -usbenable the USB driver

[libvirt] [PATCH] vz: handle gracefully races on undefining domain

This patch is not critical but nice to have. The original motivation was error message in logs on undefining domain thru vz driver. Undefine procedure drops domain lock while waiting for detaching disks vz sdk call. Meanwhile vz sdk event domain-config-changed arrives, its handler finds domain

Re: [libvirt] [PATCH 14/17] Assign addresses to USB devices

On Fr, 2016-06-17 at 20:07 +0200, Ján Tomko wrote: > Automatically assign addresses to USB devices. > > Just like reserving, this is only done for newly defined domains. What happens if I add a device to a guest (using virsh edit)? cheers, Gerd -- libvir-list mailing list

Re: [libvirt] [PATCH 11/17] Add functions for adding USB controllers to addrs

Hi, > +case VIR_DOMAIN_CONTROLLER_MODEL_USB_NEC_XHCI: > +return 4; That one is configurable via "ports=...": cheers, Gerd -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 3/3] KVM: VMX: enable guest access to LMCE related MSRs

On 20/06/2016 03:49, Haozhong Zhang wrote: > Thanks for the explanation! > > If we disable LMCE in QEMU by default (even for -cpu host), will it > still be a problem? That is, > > - pc-2.7 can continue to run on old kernels unless users explicitly > require LMCE > > - existing libvirt VM

Re: [libvirt] [PATCH 04/17] Add a test for long USB port paths

On Fr, 2016-06-17 at 20:07 +0200, Ján Tomko wrote: > For some reason, we support up to four levels of nested USB devices > in the guest. FYI: The reason is simply that usb is specified that way. You can't chain usb hubs endlessly. cheers, Gerd -- libvir-list mailing list

Re: [libvirt] [PATCH] qemu_hotplug: Use a helper variable consistently

On Sun, Jun 19, 2016 at 02:46:40PM +0200, Tomasz Flendrich wrote: --- src/qemu/qemu_hotplug.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) ACK && Pushed. Congratulations on your first patch! signature.asc Description: Digital signature -- libvir-list mailing list