Re: [libvirt] [PATCH v3 05/10] encryption: Add and to encryption

On Fri, Jun 24, 2016 at 04:53:34PM -0400, John Ferlan wrote: For a luks device, allow the configuration of a specific cipher to be used for encrypting the volume. Signed-off-by: John Ferlan --- docs/formatstorageencryption.html.in | 83 -

Re: [libvirt] [PATCH v3 04/10] encryption: Add luks parsing for storageencryption

On Fri, Jun 24, 2016 at 04:53:33PM -0400, John Ferlan wrote: Add parse and format of the luks/passphrase secret including tests for volume XML parsing. Signed-off-by: John Ferlan --- docs/formatsecret.html.in | 7 +++-

Re: [libvirt] [PATCH v3 03/10] util: Add 'usage' for encryption

On Fri, Jun 24, 2016 at 04:53:32PM -0400, John Ferlan wrote: In order to use more common code and set up for a future type, modify the encryption secret to allow the "usage" attribute or the "uuid" attribute to define the secret. The "usage" in the case of a volume secret would be the path to

Re: [libvirt] [PATCH v3 02/10] conf: Add new secret type "passphrase"

On Fri, Jun 24, 2016 at 04:53:31PM -0400, John Ferlan wrote: Add a new secret type known as "passphrase" - it will handle adding the secret objects that need a passphrase without a specific username. The format is: ... ... mumblyfratz Signed-off-by: John Ferlan

Re: [libvirt] [PATCH v3 01/10] conf: No need to check for usage fields during Format

On Fri, Jun 24, 2016 at 04:53:30PM -0400, John Ferlan wrote: Since the virSecretDefParseUsage ensures each of the fields is present, no need to check during virSecretDefFormatUsage Additionally, virBufferEscapeString is a no-op with a NULL argument. Signed-off-by: John Ferlan

[libvirt] 答复: how to make syntax-check on tar-tall released-version

>> Hi all: >> I downloaded libvirt v1.3.4 from http://libvirt.org/sources, and try to >make syntax-check inside the code tree. >> But I encounted with many problems, first, I need to have file .gitignore >and directory .git, and then have gnulib, many problems still comes out after >that.

Re: [libvirt] [PATCH 2/3] cpu: Drop generic driver

On Fri, Jun 24, 2016 at 23:50:43 +0200, Pavel Hrdina wrote: > On Fri, Jun 24, 2016 at 07:36:01PM +0200, Jiri Denemark wrote: > > Pretending (partial) support for something we don't understand is risky. > > Reporting a failure is much better. > > I agree that pretending support is risky, but I'm

Re: [libvirt] [PATCH v2 1/1] cpu_map.xml: add cmt/mbm feature to x86

On Fri, Jun 24, 2016 at 08:44:50 +0800, Qiaowei Ren wrote: > Some Intel processor families (e.g. the Intel Xeon processor E5 v3 > family) introduced some PQos (Platform Qos) features, including CMT > (Cache Monitoring technology) and MBM (Memory Bandwidth Monitoring), > to monitor or control

Re: [libvirt] [PATCH 1/3] cpu: Consolidate ARM drivers

On Fri, Jun 24, 2016 at 23:51:35 +0200, Pavel Hrdina wrote: > On Fri, Jun 24, 2016 at 07:36:00PM +0200, Jiri Denemark wrote: > > Both ARM and AArch64 drivers are exactly the same (modulo function > > names). Let's use just one driver for all ARM architectures. > > > > Signed-off-by: Jiri Denemark

Re: [libvirt] [PATCH 3/3] cpu: Drop NR_DRIVERS macro

On Fri, Jun 24, 2016 at 07:36:02PM +0200, Jiri Denemark wrote: > Signed-off-by: Jiri Denemark > --- ACK -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 1/3] cpu: Consolidate ARM drivers

On Fri, Jun 24, 2016 at 07:36:00PM +0200, Jiri Denemark wrote: > Both ARM and AArch64 drivers are exactly the same (modulo function > names). Let's use just one driver for all ARM architectures. > > Signed-off-by: Jiri Denemark > --- ACK -- libvir-list mailing list

Re: [libvirt] [PATCH 2/3] cpu: Drop generic driver

On Fri, Jun 24, 2016 at 07:36:01PM +0200, Jiri Denemark wrote: > Pretending (partial) support for something we don't understand is risky. > Reporting a failure is much better. I agree that pretending support is risky, but I'm not sure about this. For example it seems that someone uses libvirt on

[libvirt] [PATCH v3 05/10] encryption: Add and to encryption

For a luks device, allow the configuration of a specific cipher to be used for encrypting the volume. Signed-off-by: John Ferlan --- docs/formatstorageencryption.html.in | 83 - docs/schemas/storagecommon.rng | 44 ++-

[libvirt] [PATCH v3 06/10] storage: Add support to create a luks volume

Partially resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1301021 If the volume xml was looking to create a luks volume take the necessary steps in order to make that happen. The processing will be: 1. create a temporary file in the storage driver state dir path 1a. the file name will

[libvirt] [PATCH v3 02/10] conf: Add new secret type "passphrase"

Add a new secret type known as "passphrase" - it will handle adding the secret objects that need a passphrase without a specific username. The format is: ... ... mumblyfratz Signed-off-by: John Ferlan --- docs/aclpolkit.html.in

[libvirt] [PATCH v3 00/10] Add support for LUKS encrypted devices

v2: http://www.redhat.com/archives/libvir-list/2016-June/msg01691.html Changes since v2 (all as a result of code review) Patch 1: New as a result of review comment regarding virSecretDefFormatUsage Patch 2: Change "id" to "name", fixed the html.in, remove whitespice, generated patch 1

[libvirt] [PATCH v3 07/10] qemu: Introduce helper qemuDomainSecretDiskCapable

Introduce a helper to help determine if a disk src could be possibly used for a disk secret... Going to need this for hot unplug. Signed-off-by: John Ferlan --- src/qemu/qemu_domain.c | 20 +++- src/qemu/qemu_domain.h | 3 +++ 2 files changed, 18

[libvirt] [PATCH v3 04/10] encryption: Add luks parsing for storageencryption

Add parse and format of the luks/passphrase secret including tests for volume XML parsing. Signed-off-by: John Ferlan --- docs/formatsecret.html.in | 7 +++- docs/formatstorageencryption.html.in | 26 -

[libvirt] [PATCH v3 10/10] qemu: Add luks support for domain disk

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1301021 Generate the luks command line using the AES secret key to encrypt the luks secret. A luks secret object will be in addition to a an AES secret. For hotplug, check if the encinfo exists and if so, add the AES secret for the passphrase

[libvirt] [PATCH v3 03/10] util: Add 'usage' for encryption

In order to use more common code and set up for a future type, modify the encryption secret to allow the "usage" attribute or the "uuid" attribute to define the secret. The "usage" in the case of a volume secret would be the path to the volume. This code will make use of the

[libvirt] [PATCH v3 09/10] qemu: Alter the qemuDomainGetSecretAESAlias to add new arg

Soon we will be adding luks encryption support. Since a volume could require both a luks secret and a secret to give to the server to use of the device, alter the alias generation to create a slightly different alias so that we don't have two objects with the same alias. Signed-off-by: John

[libvirt] [PATCH v3 08/10] qemu: Add secinfo for hotplug virtio disk

Commit id 'a1344f70a' added AES secret processing for RBD when starting up a guest. As such, when the hotplug code calls qemuDomainSecretDiskPrepare an AES secret could be added to the disk about to be hotplugged. If an AES secret was added, then the hotplug code would need to generate the secret

[libvirt] [PATCH v3 01/10] conf: No need to check for usage fields during Format

Since the virSecretDefParseUsage ensures each of the fields is present, no need to check during virSecretDefFormatUsage Signed-off-by: John Ferlan --- src/conf/secret_conf.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git

Re: [libvirt] Plans for next release 2.0.0

On 06/22/2016 04:02 AM, Daniel Veillard wrote: > So based on the new numbering scheme we should push 2.0.0 at the > end of the month. Due to travel and move, I am tempted to enter the > freeze on next Sunday (or Monday) to try to push for the release on > Friday 1st or the week-end. > >

Re: [libvirt] [PATCH 24/28] conf: allow setting peer address in element of

On 06/24/2016 03:59 PM, Laine Stump wrote: > On 06/24/2016 09:29 AM, John Ferlan wrote: >> >> On 06/22/2016 01:37 PM, Laine Stump wrote: >>> From: Vasiliy Tolstov >>> >>> The peer attribute is used to set the property of the same name in the >>> interface IP info: >>> >>>

Re: [libvirt] [PATCH 14/28] util: move IP route & address object-related functions to virnetdevip.c

On 06/24/2016 04:23 PM, Laine Stump wrote: > On 06/24/2016 07:11 AM, John Ferlan wrote: >> >> On 06/22/2016 01:37 PM, Laine Stump wrote: >>> These functions all need to be called from a utility function that >>> must be located in the util directory, so we move them all into >>>

Re: [libvirt] [PATCH v2 14/15] qemu: Add secinfo for hotplug virtio disk

On 06/24/2016 08:51 AM, Peter Krempa wrote: > On Thu, Jun 23, 2016 at 13:29:10 -0400, John Ferlan wrote: >> Commit id 'a1344f70a' added AES secret processing for RBD when starting >> up a guest. As such, when the hotplug code calls qemuDomainSecretDiskPrepare >> an AES secret could be added to

Re: [libvirt] [PATCH 14/28] util: move IP route & address object-related functions to virnetdevip.c

On 06/24/2016 07:11 AM, John Ferlan wrote: On 06/22/2016 01:37 PM, Laine Stump wrote: These functions all need to be called from a utility function that must be located in the util directory, so we move them all into util/virnetdevip.[ch] now that it exists. Function and struct names were

Re: [libvirt] [PATCH 12/28] conf/openvz: eliminate incorrect/undocumented use of

On 06/24/2016 03:35 PM, Laine Stump wrote: On 06/23/2016 06:14 PM, John Ferlan wrote: On 06/22/2016 01:37 PM, Laine Stump wrote: When support for was added in commit 9a4b705f back in 2010, it erroneously looked at for a user-specified guest-side interface name. This was never documented

Re: [libvirt] [PATCH 11/28] qemu: eliminate memory leaks when converting NetDefs to type='ethernet'

On 06/24/2016 03:27 PM, Laine Stump wrote: On 06/23/2016 05:59 PM, John Ferlan wrote: On 06/22/2016 01:37 PM, Laine Stump wrote: in qemuConnectDomainXMLToNative. This function was only accounting for about 1/10 of all the allocated items in the NetDef prior to memseting it to all 0's. On top

Re: [libvirt] [PATCH 24/28] conf: allow setting peer address in element of

On 06/24/2016 09:29 AM, John Ferlan wrote: On 06/22/2016 01:37 PM, Laine Stump wrote: From: Vasiliy Tolstov The peer attribute is used to set the property of the same name in the interface IP info: ... ... Note that this element is used to set

Re: [libvirt] [PATCH 20/28] lxc: move debug/error log when adding IP addresses to virNetDevIPAddrAdd

On 06/24/2016 08:43 AM, John Ferlan wrote: On 06/22/2016 01:37 PM, Laine Stump wrote: It makes more sense to have the logging at the lower level so other callers can share the goodness. While removing so much stuff from / touching so many lines in lxcContainerRenameAndEnableInterfaces()

Re: [libvirt] [PATCH 12/28] conf/openvz: eliminate incorrect/undocumented use of

On 06/23/2016 06:14 PM, John Ferlan wrote: On 06/22/2016 01:37 PM, Laine Stump wrote: When support for was added in commit 9a4b705f back in 2010, it erroneously looked at for a user-specified guest-side interface name. This was never documented though. (that attribute already existed at the

Re: [libvirt] [PATCH 11/28] qemu: eliminate memory leaks when converting NetDefs to type='ethernet'

On 06/23/2016 05:59 PM, John Ferlan wrote: On 06/22/2016 01:37 PM, Laine Stump wrote: in qemuConnectDomainXMLToNative. This function was only accounting for about 1/10 of all the allocated items in the NetDef prior to memseting it to all 0's. On top of that, it was going to great pains to

[libvirt] [PATCH] util: fix build in virNetDevTapGetRealDeviceName

Commit e81de04c switched virNetDevTapGetRealDeviceName() to use virDirOpen() instead of opendir(), however it mistakenly dropped DIR *dirp declaration, so restore that to fix build. --- Pushed under the build-breaker rule. src/util/virnetdevtap.c | 1 + 1 file changed, 1 insertion(+) diff --git

[libvirt] [PATCH 2/3] examples: admin: Add some examples for the new admin APIs

Some of the examples make use of asprintf and strtol functions (to keep things simple) which are prohibited to use within our code (enforced by syntax-check). Therefore besides adding some examples, this patch also updates cfg.mk to exclude examples directory from asprintf and strtol rules, as

[libvirt] [PATCH 3/3] spec: distribute admin API within libvirt-client package

With respect to to the following thread https://www.redhat.com/archives/libvir-list/2016-June/msg01822.html, until we introduce a new rpm package '-libs' that would allow us to drop daemon's dependency on the client package, distribute admin API related stuff within the client package (since it's

[libvirt] [PATCH 1/3] admin: enable both admin API functionality and tarball distribution

This patch enables admin socket creation in daemon's code, bumps the library version in libvirt_admin_public.syms, and performs all necessary modifications to our makefiles so that admin API can finally be included in the tarball, and eventually become part of an rpm package (a patch later in this

[libvirt] [PATCH 0/3] Enable admin API functionality and tar distribution

Finally enable admin API in our code and start distributing it both via a tarball and as part of an rpm package. I also added some usage examples, however the html documentation is missing, because of our current xsl stylesheet, more specifically because of how xsltproc works. It takes a

Re: [libvirt] [PATCH python] Add support for storage pool refesh callback

On 06/24/2016 01:38 PM, Daniel P. Berrange wrote: > Signed-off-by: Daniel P. Berrange > --- > examples/event-test.py | 6 - > libvirt-override-virConnect.py | 10 > libvirt-override.c | 54 > ++ > 3

[libvirt] [PATCH python] Add support for storage pool refesh callback

Signed-off-by: Daniel P. Berrange --- examples/event-test.py | 6 - libvirt-override-virConnect.py | 10 libvirt-override.c | 54 ++ 3 files changed, 69 insertions(+), 1 deletion(-) diff --git

[libvirt] [PATCH 1/3] cpu: Consolidate ARM drivers

Both ARM and AArch64 drivers are exactly the same (modulo function names). Let's use just one driver for all ARM architectures. Signed-off-by: Jiri Denemark --- src/Makefile.am | 1 - src/cpu/cpu.c | 2 - src/cpu/cpu_aarch64.c | 133

[libvirt] [PATCH 0/3] Drop some useless CPU code

Jiri Denemark (3): cpu: Consolidate ARM drivers cpu: Drop generic driver cpu: Drop NR_DRIVERS macro po/POTFILES.in| 1 - src/Makefile.am | 2 - src/cpu/cpu.c | 16 ++-- src/cpu/cpu_aarch64.c | 133 - src/cpu/cpu_aarch64.h | 31 ---

[libvirt] [PATCH 2/3] cpu: Drop generic driver

Pretending (partial) support for something we don't understand is risky. Reporting a failure is much better. Signed-off-by: Jiri Denemark --- po/POTFILES.in| 1 - src/Makefile.am | 1 - src/cpu/cpu.c | 13 ++- src/cpu/cpu_generic.c | 226

[libvirt] [PATCH 3/3] cpu: Drop NR_DRIVERS macro

Signed-off-by: Jiri Denemark --- src/cpu/cpu.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/cpu/cpu.c b/src/cpu/cpu.c index c8d50e7..11a68f0 100644 --- a/src/cpu/cpu.c +++ b/src/cpu/cpu.c @@ -35,7 +35,6 @@ #include "util/virstring.h"

[libvirt] [PATCH 0/2] util: Small cleanups

What it says on the tin. Andrea Bolognani (2): util: Drop obsolete compatibility code util: Only define /dev/kvm path once src/util/virhostcpu.c | 18 +++--- 1 file changed, 3 insertions(+), 15 deletions(-) -- 2.7.4 -- libvir-list mailing list libvir-list@redhat.com

[libvirt] [PATCH 1/2] util: Drop obsolete compatibility code

All operating system releases we support include these definitions. --- src/util/virhostcpu.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/src/util/virhostcpu.c b/src/util/virhostcpu.c index fed5be7..a34d983 100644 --- a/src/util/virhostcpu.c +++ b/src/util/virhostcpu.c @@

[libvirt] [PATCH 2/2] util: Only define /dev/kvm path once

Remove the local kvmpath variable from virHostCPUGetThreadsPerSubcore() and use the global KVM_DEVICE define instead. --- src/util/virhostcpu.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/util/virhostcpu.c b/src/util/virhostcpu.c index a34d983..055fa1f 100644

Re: [libvirt] [PATCH] Promote storage pool refresh lifecycle event to top level event

On Fri, Jun 24, 2016 at 01:12:40PM -0400, Cole Robinson wrote: > On 06/24/2016 12:38 PM, Daniel P. Berrange wrote: > > The VIR_STORAGE_POOL_EVENT_REFRESHED constant does not > > reflect any change in the lifecycle of the storage pool. > > > > It should thus not be part of the storage pool

Re: [libvirt] [PATCH v2 3/3] Document to not rely on virConnectGetMaxVcpus API

On Fri, 2016-06-24 at 20:34 +0530, Shivaprasad G Bhat wrote: > The API virConnectGetMaxVcpus doesn't really reflect the actual usable number > of cpus as the maximum limits can be different for kvm and/or qemu. So update > the documentation to use virConnectGetDomainCapabilities() instead. > >

Re: [libvirt] [PATCH 25/28] conf: support host-side IP/route information in

On 06/24/2016 11:19 AM, Laine Stump wrote: > On 06/24/2016 09:48 AM, John Ferlan wrote: >> [...] >>> +virDomainNetDefValidate(const virDomainNetDef *net) >>> +{ >>> +if ((net->hostIP.nroutes || net->hostIP.nips) && >>> +net->type != VIR_DOMAIN_NET_TYPE_ETHERNET) { >>> +

Re: [libvirt] [PATCH v2 2/3] qemu: check the kvm host cpu max limits in virConnectGetDomainCapabilities

On Fri, 2016-06-24 at 20:34 +0530, Shivaprasad G Bhat wrote: > The qemu limit and host limit both should be considered for > the domain vcpu max limits. >  > Signed-off-by: Shivaprasad G Bhat > --- >  src/qemu/qemu_capabilities.c |   11 --- >  

Re: [libvirt] [PATCH] Promote storage pool refresh lifecycle event to top level event

On Fri, Jun 24, 2016 at 01:12:40PM -0400, Cole Robinson wrote: > On 06/24/2016 12:38 PM, Daniel P. Berrange wrote: > > The VIR_STORAGE_POOL_EVENT_REFRESHED constant does not > > reflect any change in the lifecycle of the storage pool. > > > > It should thus not be part of the storage pool

[libvirt] [PATCH v2 2/2] virsh: enable --table with --name or --uuid

From: Chen Hanxiao remove restrictions of --table with --name or --uid. Signed-off-by: Chen Hanxiao --- tools/virsh-domain-monitor.c | 46 +++- 1 file changed, 41 insertions(+), 5 deletions(-) diff --git

[libvirt] [PATCH v2 0/2] virsh expand virsh list command options

Chen Hanxiao (2): virsh: allow both --uuid and --name at same cmd virsh: enable --table with --name or --uuid tools/virsh-domain-monitor.c | 56 +--- 1 file changed, 47 insertions(+), 9 deletions(-) -- 2.5.0 -- libvir-list mailing list

[libvirt] [PATCH v2 1/2] virsh: allow both --uuid and --name at same cmd

From: Chen Hanxiao virsh # list --uuid --name c749c765a0-25e7-40d0-964f-dac99724b32c f23 918f1dd6-b19f-412b-ba17-d113bad89af8 Signed-off-by: Chen Hanxiao --- v2: drop uuid-name option, enable both --uuid and --name

Re: [libvirt] [PATCH] Promote storage pool refresh lifecycle event to top level event

On 06/24/2016 12:38 PM, Daniel P. Berrange wrote: > The VIR_STORAGE_POOL_EVENT_REFRESHED constant does not > reflect any change in the lifecycle of the storage pool. > > It should thus not be part of the storage pool lifecycle > event set, but rather be a top level event in its own > right. Thus

Re: [libvirt] [PATCH 03/28] global: consistently use IP rather than Ip in identifiers

On 06/23/2016 04:25 PM, John Ferlan wrote: On 06/22/2016 01:37 PM, Laine Stump wrote: I'm tired of mistyping this all the time, so let's do it the same all the time (similar to how we changed all "Pci" to "PCI" awhile back). (NB: I've left alone some things in the esx and vbox drivers because

Re: [libvirt] [PATCH python v4 1/7] Introduce storage lifecycle event APIs

On 06/24/2016 12:31 PM, Daniel P. Berrange wrote: > On Thu, Jun 16, 2016 at 10:08:55AM +0200, Jovanka Gulicoska wrote: >> Storage pool lifecycle event API entry points for registering and >> deregistering >> storage pool events, as well as types of events associated with storage >> pools. >>

Re: [libvirt] [PATCH v2 1/3] Rename kvmGetMaxVCPUs() to virHostCPUGetKVMMaxVCPUs()

On Fri, 2016-06-24 at 20:33 +0530, Shivaprasad G Bhat wrote: > -/* add definitions missing in older linux/kvm.h */ > -#ifndef KVMIO > -# define KVMIO 0xAE > -#endif > -#ifndef KVM_CHECK_EXTENSION > -# define KVM_CHECK_EXTENSION   _IO(KVMIO,   0x03) > -#endif > -#ifndef KVM_CAP_NR_VCPUS > -#

[libvirt] [PATCH] Promote storage pool refresh lifecycle event to top level event

The VIR_STORAGE_POOL_EVENT_REFRESHED constant does not reflect any change in the lifecycle of the storage pool. It should thus not be part of the storage pool lifecycle event set, but rather be a top level event in its own right. Thus we introduce VIR_STORAGE_POOL_EVENT_ID_REFRESH to replace it.

Re: [libvirt] [PATCH] Allow custom metadata in network configuration XML

On 06/24/2016 07:01 AM, Peter Krempa wrote: On Wed, Jun 22, 2016 at 16:05:50 -0600, Brnadon Bennett wrote: From: Brandon Bennett This replicates the metadata field found in the domain configuration and adds it to the network configuration XML. Just a few notes

Re: [libvirt] [PATCH v2 11/15] storage: Add support to create a luks volume

On 06/24/2016 10:48 AM, Peter Krempa wrote: > On Thu, Jun 23, 2016 at 13:29:07 -0400, John Ferlan wrote: >> Partially resolves: >> https://bugzilla.redhat.com/show_bug.cgi?id=1301021 >> >> If the volume xml was looking to create a luks volume take the necessary >> steps in order to make that

Re: [libvirt] [PATCH python v4 1/7] Introduce storage lifecycle event APIs

On Thu, Jun 16, 2016 at 10:08:55AM +0200, Jovanka Gulicoska wrote: > Storage pool lifecycle event API entry points for registering and > deregistering > storage pool events, as well as types of events associated with storage pools. > These entry points will be used for implementing asynchronous

Re: [libvirt] [PATCH v2 09/15] encryption: Add and to encryption

On 06/24/2016 10:10 AM, Peter Krempa wrote: > On Thu, Jun 23, 2016 at 13:29:05 -0400, John Ferlan wrote: >> For a luks device, allow the configuration of a specific cipher to be >> used for encrypting the volume. >> >> Signed-off-by: John Ferlan >> --- >>

Re: [libvirt] [PATCH] daemon: Drop dependency on libvirt-admin.so

On Fri, Jun 24, 2016 at 04:11:52PM +0100, Daniel P. Berrange wrote: > On Fri, Jun 24, 2016 at 05:04:30PM +0200, Michal Privoznik wrote: > > On 24.06.2016 16:06, Daniel P. Berrange wrote: > > > On Fri, Jun 24, 2016 at 03:59:38PM +0200, Michal Privoznik wrote: > > >> On 24.06.2016 15:33, Daniel P.

Re: [libvirt] [PATCH] Drop virStorageBackendLogicalMatchPoolSource

On Wed, Jun 22, 2016 at 07:03:46AM -0400, John Ferlan wrote: On 06/17/2016 11:16 AM, Ján Tomko wrote: On Thu, Jun 16, 2016 at 07:44:05AM -0400, John Ferlan wrote: On 06/16/2016 06:03 AM, Ján Tomko wrote: On Wed, Jun 15, 2016 at 06:45:59PM -0400, John Ferlan wrote: On 06/15/2016 01:19

[libvirt] [PATCH 0/2] Make a generic version of virDomainDefMetadataSanitize()

Peter pointed out that Brandon's patch to add metadata to the network XML should "sanitize" it (to remove duplicate namespaces) in the same manner as we do (thanks to Peter!) for the domain metadata. In order to make that simpler, I made a patch that turns virDomainDefMetadataSanitize() into the

[libvirt] [PATCH 1/2] util: new function virXMLNodeSanitizeNamespaces()

This is a generic version of virDomainDefMetadataSanitize() - the same functionality is now needed for network metadata. --- src/libvirt_private.syms | 1 + src/util/virxml.c| 52 src/util/virxml.h| 2 ++ 3 files changed, 55

Re: [libvirt] [PATCH] sasl auth：add default mapping of credentials to machines

On Thu, Jun 16, 2016 at 07:32:54PM +0800, longguang.yue wrote: > this patch is for help document > > thanks very much > > > > > At 2016-06-16 17:39:12, "Daniel P. Berrange" wrote: > >On Mon, Jun 13, 2016 at 05:58:06PM +0800, longguang.yue wrote: > >> From

[libvirt] [PATCH 2/2] qemu: use virXMLNodeSanitizeNamespaces()

Replace the virDomainDef-specific virDomainDefMetadataSanitize() with virXMLNodeSanitizeNamespaces(). --- src/conf/domain_conf.c | 56 ++ 1 file changed, 2 insertions(+), 54 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c

Re: [libvirt] [PATCH v2 08/15] encryption: Add luks parsing for storageencryption

On 06/24/2016 09:45 AM, Peter Krempa wrote: > On Thu, Jun 23, 2016 at 13:29:04 -0400, John Ferlan wrote: >> Add parse and format of the luks/passphrase secret including tests for >> volume XML parsing. >> >> Signed-off-by: John Ferlan >> --- >> docs/formatsecret.html.in

Re: [libvirt] [PATCH 1/3] Replace some uses STREQLEN with STRPREFIX

On Fri, 2016-06-24 at 15:00 +0200, Ján Tomko wrote: > Do not call it with a magic constant matching the length > of the pattern. > --- > src/qemu/qemu_command.c | 2 +- > src/storage/storage_backend_iscsi.c | 2 +- > src/storage/storage_backend_scsi.c | 2 +- >

Re: [libvirt] [PATCH] conf: Allow disks with identical WWN or serial

On Fri, Jun 24, 2016 at 05:18:25PM +0200, Peter Krempa wrote: > On Fri, Jun 24, 2016 at 16:12:58 +0100, Daniel Berrange wrote: > > On Fri, Jun 24, 2016 at 05:07:43PM +0200, Peter Krempa wrote: > > > Disallowing them broke a use case of testing multipath configurations > > > for storage. The

Re: [libvirt] [PATCH 25/28] conf: support host-side IP/route information in

On 06/24/2016 09:48 AM, John Ferlan wrote: On 06/22/2016 01:37 PM, Laine Stump wrote: This is non-intuitively placed as a sub-element of , because it will be used to configure the interface that is named in (which is the interface on the host-side). (The already-existing configuration for the

Re: [libvirt] [PATCH] conf: Allow disks with identical WWN or serial

On Fri, Jun 24, 2016 at 16:12:58 +0100, Daniel Berrange wrote: > On Fri, Jun 24, 2016 at 05:07:43PM +0200, Peter Krempa wrote: > > Disallowing them broke a use case of testing multipath configurations > > for storage. The original intent was added as it made it impossible to > > use certain

Re: [libvirt] [PATCH] daemon: Drop dependency on libvirt-admin.so

On Fri, 2016-06-24 at 17:04 +0200, Michal Privoznik wrote: > On 24.06.2016 16:06, Daniel P. Berrange wrote: > > On Fri, Jun 24, 2016 at 03:59:38PM +0200, Michal Privoznik wrote: > > > On 24.06.2016 15:33, Daniel P. Berrange wrote: > > > > On Fri, Jun 24, 2016 at 03:12:23PM +0200, Michal Privoznik

Re: [libvirt] [PATCH] conf: Allow disks with identical WWN or serial

On Fri, Jun 24, 2016 at 05:07:43PM +0200, Peter Krempa wrote: > Disallowing them broke a use case of testing multipath configurations > for storage. The original intent was added as it made it impossible to > use certain /dev/disk-by... links. > > Resolves:

Re: [libvirt] [PATCH] daemon: Drop dependency on libvirt-admin.so

On Fri, Jun 24, 2016 at 05:04:30PM +0200, Michal Privoznik wrote: > On 24.06.2016 16:06, Daniel P. Berrange wrote: > > On Fri, Jun 24, 2016 at 03:59:38PM +0200, Michal Privoznik wrote: > >> On 24.06.2016 15:33, Daniel P. Berrange wrote: > >>> On Fri, Jun 24, 2016 at 03:12:23PM +0200, Michal

[libvirt] [PATCH] conf: Allow disks with identical WWN or serial

Disallowing them broke a use case of testing multipath configurations for storage. The original intent was added as it made it impossible to use certain /dev/disk-by... links. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1349895 --- src/conf/domain_conf.c | 14 -- 1 file

[libvirt] [PATCH v2 3/3] Document to not rely on virConnectGetMaxVcpus API

The API virConnectGetMaxVcpus doesn't really reflect the actual usable number of cpus as the maximum limits can be different for kvm and/or qemu. So update the documentation to use virConnectGetDomainCapabilities() instead. Signed-off-by: Shivaprasad G Bhat ---

Re: [libvirt] [PATCH] daemon: Drop dependency on libvirt-admin.so

On 24.06.2016 16:06, Daniel P. Berrange wrote: > On Fri, Jun 24, 2016 at 03:59:38PM +0200, Michal Privoznik wrote: >> On 24.06.2016 15:33, Daniel P. Berrange wrote: >>> On Fri, Jun 24, 2016 at 03:12:23PM +0200, Michal Privoznik wrote: Currently, the daemon requires libvirt-admin.so because

[libvirt] [PATCH v2 2/3] qemu: check the kvm host cpu max limits in virConnectGetDomainCapabilities

The qemu limit and host limit both should be considered for the domain vcpu max limits. Signed-off-by: Shivaprasad G Bhat --- src/qemu/qemu_capabilities.c | 11 --- src/qemu/qemu_capabilities.h |3 ++- src/qemu/qemu_driver.c |2 +-

[libvirt] [PATCH v2 0/3] Fix the domain capabilities wrt maxvcpus

This series drops the suggested cpu in the domcapabilties output which was implemented in previous version. So, this has just the fix for the domcapabililties output wrt maxvcpus. I'll follow up this series with suggested cpus and the virsh maxvcpus fix. The previous version is available here.

[libvirt] [PATCH v2 1/3] Rename kvmGetMaxVCPUs() to virHostCPUGetKVMMaxVCPUs()

This kvmGetMaxVCPUs() needs to be used at two different places so move it to utils with appropriate name and mark it as private global now. Signed-off-by: Shivaprasad G Bhat --- src/libvirt_private.syms |1 + src/qemu/qemu_driver.c | 52

Re: [libvirt] [PATCH v2 06/15] util: Modify the FileTypeInfo to add a version size

[...] >> >>> @@ -635,13 +637,25 @@ virStorageFileMatchesVersion(int format, >>> if (fileTypeInfo[format].versionOffset == -2) >>> return true; > > So you would like to see: > > if (fileTypeInfo[format].versionSize == 0) > return false; > Sent before I thought about

Re: [libvirt] [PATCH 0/4] Fix the domain capabilities wrt maxvcpus

On 06/22/2016 08:55 PM, Andrea Bolognani wrote: On Wed, 2016-06-15 at 09:54 +, Shivaprasad G Bhat wrote: This series addresses the comments to my patch in http://www.redhat.com/archives/libvir-list/2016-May/msg00218.html The v2 got quite a lot of criticism to not to change the

Re: [libvirt] [PATCH v2 06/15] util: Modify the FileTypeInfo to add a version size

On 06/24/2016 09:28 AM, Peter Krempa wrote: > On Thu, Jun 23, 2016 at 13:29:02 -0400, John Ferlan wrote: >> The version field historically has been a 4 byte data; however, an upcoming >> new type will use a 2 byte version. So let's adjust for that now. >> >> Signed-off-by: John Ferlan

Re: [libvirt] [PATCH v2 11/15] storage: Add support to create a luks volume

On Thu, Jun 23, 2016 at 13:29:07 -0400, John Ferlan wrote: > Partially resolves: > https://bugzilla.redhat.com/show_bug.cgi?id=1301021 > > If the volume xml was looking to create a luks volume take the necessary > steps in order to make that happen. > > The processing will be: > 1. create a

Re: [libvirt] [PATCH v2 04/15] util: Add 'usage' for encryption

On 06/24/2016 09:25 AM, Peter Krempa wrote: > On Thu, Jun 23, 2016 at 13:29:00 -0400, John Ferlan wrote: >> In order to use more common code and set up for a future type, modify the >> encryption secret to allow the "usage" attribute or the "uuid" attribute >> to define the secret. The "usage"

[libvirt] [PATCH 9/9] vz: add ACL checks to API calls

vzDomainMigrateConfirm3Params is whitelisted. Otherwise we need to move removing domain from domain list from perform to confirm step. This would further imply adding a flag and check that migration is in progress to prohibit mistakenly (maliciously) removing domains on confirm step. vz version

[libvirt] [PATCH 8/9] remote: rename protocol names for close callbacks

This way we make naming consistent to API calls and make subsequent ACL checks possible (otherwise ACL check would discover name discrepancies). Signed-off-by: Nikolay Shirokovskiy --- daemon/remote.c | 4 ++-- src/remote/remote_driver.c | 4 ++--

[libvirt] [PATCH 5/9] vz: add missing flagged versions of API functions

Signed-off-by: Nikolay Shirokovskiy --- src/vz/vz_driver.c | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c index 72774ae..9c93db1 100644 --- a/src/vz/vz_driver.c +++

[libvirt] [PATCH 4/9] vz: factor out converting block stats to params

This action deserves its own function and makes main API call structure much cleaner. Signed-off-by: Nikolay Shirokovskiy --- src/vz/vz_driver.c | 61 -- 1 file changed, 36 insertions(+), 25 deletions(-) diff

[libvirt] [PATCH 1/9] vz: expand start/stop/... APIs for ACL checks

The original motivation is to expand API calls like start/stop etc so that the ACL checks could be added. But this patch has its own befenits. 1. functions like prlsdkStart/Stop use common routine to wait for job without domain lock. They become more self contained and do not return

[libvirt] [PATCH 7/9] vz: prepare migration for ACL checks

ACL check on perform step should be in API call itself to make ACL checking script pass. Thus we need to reorganize code to obtain domain object in perform API itself. Most of this is straight forward, the only nuance is dropping locks on lengthy remote operations. The other motivation is to

[libvirt] [PATCH 3/9] vz: factor out block stats impl

Now we can use intended ACL check for both API calls. Signed-off-by: Nikolay Shirokovskiy --- src/vz/vz_driver.c | 45 +++-- 1 file changed, 31 insertions(+), 14 deletions(-) diff --git a/src/vz/vz_driver.c

[libvirt] [PATCH 0/9] add ACL checks to vz driver

First (patches 1 - 8) prepare driver to add checks. Nikolay Shirokovskiy (9): vz: expand start/stop/... APIs for ACL checks vz: implement plain create API thru createFlags instead of visa versa vz: factor out block stats impl vz: factor out converting block stats to params vz: add

[libvirt] [PATCH 2/9] vz: implement plain create API thru createFlags instead of visa versa

Signed-off-by: Nikolay Shirokovskiy --- src/vz/vz_driver.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c index 0079384..8e39a5d 100644 --- a/src/vz/vz_driver.c +++ b/src/vz/vz_driver.c @@

[libvirt] [PATCH 6/9] vz: expand setting memory API calls

We need it to prepare the calls for ACL checks otherwise ACL checking script will fail. Signed-off-by: Nikolay Shirokovskiy --- src/vz/vz_driver.c | 85 -- 1 file changed, 50 insertions(+), 35 deletions(-) diff

  1   2   >