Re: [libvirt] [PATCH 22/28] util: provide default destination IP in alternate virNetDevIPRouteAdd()

2016-06-26 Thread Laine Stump
On 06/24/2016 09:08 AM, John Ferlan wrote: On 06/22/2016 01:37 PM, Laine Stump wrote: The version of virNetDevIPRouteAdd() has a bit of code to create the appropriate "0.0.0.0" or "::" virSocketAddr when the addr passed in is NULL or invalid, but the alternate implementation (used on platforms

Re: [libvirt] [PATCH 20/28] lxc: move debug/error log when adding IP addresses to virNetDevIPAddrAdd

2016-06-26 Thread Laine Stump
On 06/24/2016 03:55 PM, Laine Stump wrote: +VIR_DEBUG("Adding IP address %s/%d%s%s%s%s to %s", ipStr, prefix, + peerStr ? " peer " : "", peerStr ? peerStr : "", + bcastStr ? " bcast " : "", bcastStr ? bcastStr : "", + ifname); + NULLSTR() or perhaps

Re: [libvirt] [PATCH 15/28] conf: single object containing list of IP addresses, list of routes

2016-06-26 Thread Laine Stump
On 06/24/2016 08:04 AM, John Ferlan wrote: [...] The second cup of caffeine finally started flowing through the veins... and of course I'm on patch 19... use static int ATTRIBUTE_UNUSED virDomainxxx() Of course! I too was too sleep deprived to consider that might work for a static function

[libvirt] [PATCH v4 10/10] qemu: Add luks support for domain disk

2016-06-26 Thread John Ferlan
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1301021 Generate the luks command line using the AES secret key to encrypt the luks secret. A luks secret object will be in addition to a an AES secret. For hotplug, check if the encinfo exists and if so, add the AES secret for the passphrase

[libvirt] [PATCH v4 08/10] qemu: Add secinfo for hotplug virtio disk

2016-06-26 Thread John Ferlan
Commit id 'a1344f70a' added AES secret processing for RBD when starting up a guest. As such, when the hotplug code calls qemuDomainSecretDiskPrepare an AES secret could be added to the disk about to be hotplugged. If an AES secret was added, then the hotplug code would need to generate the secret

[libvirt] [PATCH v4 06/10] storage: Add support to create a luks volume

2016-06-26 Thread John Ferlan
Partially resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1301021 If the volume xml was looking to create a luks volume take the necessary steps in order to make that happen. The processing will be: 1. create a temporary file in the storage driver state dir path 1a. the file name will

Re: [libvirt] [PATCH v3 10/10] qemu: Add luks support for domain disk

2016-06-26 Thread John Ferlan
On 06/25/2016 03:07 AM, Ján Tomko wrote: > On Fri, Jun 24, 2016 at 04:53:39PM -0400, John Ferlan wrote: >> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1301021 >> >> Generate the luks command line using the AES secret key to encrypt the >> luks secret. A luks secret object will be in

Re: [libvirt] [PATCH v3 08/10] qemu: Add secinfo for hotplug virtio disk

2016-06-26 Thread John Ferlan
On 06/25/2016 02:43 AM, Ján Tomko wrote: > On Fri, Jun 24, 2016 at 04:53:37PM -0400, John Ferlan wrote: >> Commit id 'a1344f70a' added AES secret processing for RBD when starting >> up a guest. As such, when the hotplug code calls >> qemuDomainSecretDiskPrepare >> an AES secret could be added to

Re: [libvirt] [PATCH v3 06/10] storage: Add support to create a luks volume

2016-06-26 Thread John Ferlan
On 06/25/2016 02:18 AM, Ján Tomko wrote: > On Fri, Jun 24, 2016 at 04:53:35PM -0400, John Ferlan wrote: >> Partially resolves: >> https://bugzilla.redhat.com/show_bug.cgi?id=1301021 >> >> If the volume xml was looking to create a luks volume take the necessary >> steps in order to make that

[libvirt] Entering freeze for libvirt-2.0.0

2016-06-26 Thread Daniel Veillard
As planned the Release candidate 1 of libvirt 2.0.0 is tagged in git, I have made signed tarball and rpms available at the usual place: ftp://libvirt.org/libvirt/ Seems to work just fine in my limited testing, but there is a number of packaging changes and we need to look for issues that