Doing an XPath query for every single 'function' element in the
file is inefficient.
Since the XML file is generated by another of our build scripts
(apibuild.py, using Python's standard 'output.write' XML library),
just find the function name->file mapping by a regex upfront.
---
bootstrap.conf
This lets perl cache the regex.
Even though there are only eight groups, the speedup is more than that.
---
docs/hvsupport.pl | 33 -
1 file changed, 16 insertions(+), 17 deletions(-)
diff --git a/docs/hvsupport.pl b/docs/hvsupport.pl
index 80a6f80..31821ad 100755
This speeds up the whole script almost twice.
---
docs/hvsupport.pl | 1 +
1 file changed, 1 insertion(+)
diff --git a/docs/hvsupport.pl b/docs/hvsupport.pl
index 31821ad..8b2f8c6 100755
--- a/docs/hvsupport.pl
+++ b/docs/hvsupport.pl
@@ -209,6 +209,7 @@ foreach my $src (@srcs) {
my $impl;
This reduces the script execution time from 14.7s to 60 ms.
Since this was by far the longest taking target from the docs/ directory
and make does not parallelize across Makefiles, the savings are similar
for a complete build from a fresh git checkout.
The second patch shaves off 8.2s, the third 6
The code for parsing the different public syms files only differs
in the filenames and version prefix.
Unify it to a single subroutine.
---
docs/hvsupport.pl | 168 --
1 file changed, 50 insertions(+), 118 deletions(-)
diff --git a/docs/hvsuppo
On Tue, Jun 28, 2016 at 11:17:35PM +0200, Jiri Denemark wrote:
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_command.c | 75 ++---
1 file changed, 34 insertions(+), 41 deletions(-)
@@ -8030,7 +8025,7 @@ qemuBuildNetCommandLine(virCommandPtr cmd,
i
On Wed, Jun 29, 2016 at 08:07:29 +0200, Ján Tomko wrote:
> On Tue, Jun 28, 2016 at 02:43:59PM +0200, Peter Krempa wrote:
> >Some code paths already assume that it is allocated since it was always
> >allocated by virDomainPerfDefParseXML. Move allocation to
>
> Shouldn't we rather fix those code pa
On Tue, Jun 28, 2016 at 02:43:59PM +0200, Peter Krempa wrote:
Some code paths already assume that it is allocated since it was always
allocated by virDomainPerfDefParseXML. Move allocation to
Shouldn't we rather fix those code paths?
virDomainDefNew would get ridiculously long if we started as
virNetServerClientGetInfo returns the client's remote address
as a string, which is a part of the client object.
Use VIR_STRDUP to make a copy which can be freely accessed
even after the virNetServerClient object is unlocked.
---
daemon/admin_server.c| 3 ++-
src/rpc/virnetserverclient.c
---
tests/Makefile.am | 23 ++-
.../bhyveargv2xmldata/bhyveargv2xml-acpiapic.args | 9 +
tests/bhyveargv2xmldata/bhyveargv2xml-acpiapic.xml | 20 ++
tests/bhyveargv2xmldata/bhyveargv2xml-ahci-hd.args | 8 +
tests/bhyveargv2xmldata/bhyveargv2xml-ahci-hd.xml
A simple getopt-based argument parser is added for the /usr/sbin/bhyveload
command, loosely based on its argument parser.
The boot disk is guessed by iterating over all
disks and matching their sources. If any non-default arguments are found,
def->os.bootloaderArgs is set accordingly, and the bo
A simpe getopt-based argument parser is added for the /usr/sbin/bhyve command,
loosely based on its argument parser, which reads the following from the bhyve
command line string:
* vm name
* number of vcpus
* memory size
* the time offset (UTC or localtime)
* features:
* acpi
* ioapic: While
First, remove escaped newlines and split up the string into an argv-list for
the bhyve and loader commands, respectively. This is done by iterating over the
string splitting it by newlines, and then re-iterating over each line,
splitting it by spaces.
Since this code reuses part of the code of qem
Unconditionally use gnulib's getopt module. This is needed by the bhyve driver
to provide a reentrant interface for getopt.
---
bootstrap.conf | 1 +
m4/virt-driver-bhyve.m4 | 3 +++
2 files changed, 4 insertions(+)
diff --git a/bootstrap.conf b/bootstrap.conf
index 0db6b62..edea8c3 10
(resent due to mail client line mangling)
Several gnulib headers rely on features.h being included by ctype.h to provide
__GNUC_PREREQ, but on systems without glibc, this is not provided. In these
cases __GNUC_PREREQ gets redefined to 0, which causes build errors from checks
in src/internal.h.
The
Several gnulib headers rely on features.h being included by ctype.h to
provide
__GNUC_PREREQ, but on systems without glibc, this is not provided. In these
cases __GNUC_PREREQ gets redefined to 0, which causes build errors from
checks
in src/internal.h.
Therefore, define __GNUC_PREREQ as early as po
Differences to v3:
functional changes:
- Throw an error when there is no bhyverun command (bhyve_argv == NULL)
- Parse the memory size in the same way bhyve does it, and adapt the
relevant
code (vm_parse_memsize) from the FreeBSD source tree.
Here I'm a bit unsure about attribution;
On 06/24/2016 12:44 PM, Chen Hanxiao wrote:
> From: Chen Hanxiao
>
> virsh # list --uuid --name
> c749c765a0-25e7-40d0-964f-dac99724b32c
> f23 918f1dd6-b19f-412b-ba17-d113bad89af8
>
The actual output is reversed - perhaps a late change not properly
reflected in the /commit message...
On 06/24/2016 12:44 PM, Chen Hanxiao wrote:
> From: Chen Hanxiao
>
> remove restrictions of --table with --name or --uid.
I think what you're trying to do is allow --uuid to be printed in the
--table output. I don't htink --name should be mentioned/modified.
>
> Signed-off-by: Chen Hanxiao
Jiri Denemark (2):
qemu: Use bootindex whenever possible
qemu: Drop emitBootindex parameter
src/qemu/qemu_command.c| 89 ++
.../qemuxml2argv-boot-menu-enable-bootindex.args | 23 ++
.../qemuxml2argv-boot-menu-enable-bootindex.xml| 28 +
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_command.c | 75 ++---
1 file changed, 34 insertions(+), 41 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index ecfc447..3898ed7 100644
--- a/src/qemu/qemu_command.c
+++ b/src/
I'm not sure why our code claimed "-boot menu=on" cannot be used in
combination with per-device bootindex, but it was proved wrong about
four years ago by commit 8c952908. Let's always use bootindex when QEMU
supports it.
https://bugzilla.redhat.com/show_bug.cgi?id=1323085
Signed-off-by: Jiri Den
On Tue, 28 Jun 2016 14:39:22 -0400
Laine Stump wrote:
> On 06/28/2016 01:39 PM, Jim Fehlig wrote:
> > After updating the dom0 kernel on one of my Xen test hosts, I noticed
> > problems with PCI hostdev management. E.g
> >
> > # virsh nodedev-detach pci__07_10_1
> > error: Failed to detach de
From: Markus Rothe
https://bugzilla.redhat.com/show_bug.cgi?id=1350523
---
setup.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/setup.py b/setup.py
index 099b1e0..a4cfb88 100755
--- a/setup.py
+++ b/setup.py
@@ -28,6 +28,8 @@ _pkgcfg = -1
def get_pkgcfg(do_fail=True):
global _pkg
"Daniel P. Berrange" writes:
> Adding Alex & Bandan, since they signed off the kernel patch which
> broke things.
>
> On Tue, Jun 28, 2016 at 11:39:59AM -0600, Jim Fehlig wrote:
>> After updating the dom0 kernel on one of my Xen test hosts, I noticed
>> problems with PCI hostdev management. E.g
>
On 06/28/2016 01:39 PM, Jim Fehlig wrote:
After updating the dom0 kernel on one of my Xen test hosts, I noticed
problems with PCI hostdev management. E.g
# virsh nodedev-detach pci__07_10_1
error: Failed to detach device pci__07_10_1
error: Failed to add PCI device ID '8086 1520' to pci
On 06/28/2016 02:18 PM, John Ferlan wrote:
>
>
> On 06/23/2016 12:27 PM, Cole Robinson wrote:
>> The generic event infrastructure has the notion of lookup-by-uuid
>> baked into the API, but not all objects have a uuid (nodedev,
>> interfaces).
>>
>> This series enables callers to specify a string
On 06/23/2016 12:27 PM, Cole Robinson wrote:
> The generic event infrastructure has the notion of lookup-by-uuid
> baked into the API, but not all objects have a uuid (nodedev,
> interfaces).
>
> This series enables callers to specify a string key for match
> purposes. Existing users of the bina
On 06/23/2016 12:27 PM, Cole Robinson wrote:
> This allows event implementations to match on something other
> than an object's uuid, like nodedev or interface objects which
> don't have a uuid.
> ---
> src/conf/domain_event.c | 11 +--
> src/conf/network_event.c| 4 +++-
Adding Alex & Bandan, since they signed off the kernel patch which
broke things.
On Tue, Jun 28, 2016 at 11:39:59AM -0600, Jim Fehlig wrote:
> After updating the dom0 kernel on one of my Xen test hosts, I noticed
> problems with PCI hostdev management. E.g
>
> # virsh nodedev-detach pci__07_1
After updating the dom0 kernel on one of my Xen test hosts, I noticed problems
with PCI hostdev management. E.g
# virsh nodedev-detach pci__07_10_1
error: Failed to detach device pci__07_10_1
error: Failed to add PCI device ID '8086 1520' to pciback: File exists
It turns out there was a
>>> On 27.06.16 at 18:54, wrote:
> Jim Fehlig writes ("Re: [libvirt] [Xen-devel] Fixing libvirt's libxl driver
> breakage -- where to define LIBXL_API_VERSION?"):
>> On 06/27/2016 10:12 AM, Ian Jackson wrote:
>> > Does libvirt have stable release branches ? One approach would be to
>> > have oss
Seems a backport miss. An extra member is passed to struct
virLXCBasicMountInfo.
Signed-off-by: Yang hongyang
---
src/lxc/lxc_container.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c
index 28dabec..1c65fa9 100644
---
On 06/23/2016 06:47 AM, Ján Tomko wrote:
>
>
>
>
> results in:
>
> -device intel-iommu
Might be nice to add a bit more "meat" to the commit message.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1235580
> ---
> src/qemu/qemu_command.c| 30
> ++
On 06/23/2016 06:47 AM, Ján Tomko wrote:
> Check whether QEMU supports -device intel-iommu
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1235580
> ---
> src/qemu/qemu_capabilities.c | 2 ++
> src/qemu/qemu_capabilities.h | 1 +
> tests/qemucapabilitiesd
On 06/23/2016 06:47 AM, Ján Tomko wrote:
> A device with an attribude 'model'.
Attribute
>
> intel-iommu is accepted so far:
>
>
> ...
>
>
>
The text reads like it already exists, but we're adding the XML here.
> https://bugzilla.redhat.com/show_bug.cgi?id=1235580
> ---
> docs/sche
On Tue, Jun 28, 2016 at 10:01:19AM -0400, Cole Robinson wrote:
> On 06/28/2016 09:28 AM, Daniel P. Berrange wrote:
> > On Tue, Jun 28, 2016 at 02:45:15PM +0200, Jiri Denemark wrote:
> >> Setting an empty vnc_password in qemu.conf is documented as a way to
> >> disable VNC access, but QEMU does not
On 06/28/2016 09:28 AM, Daniel P. Berrange wrote:
> On Tue, Jun 28, 2016 at 02:45:15PM +0200, Jiri Denemark wrote:
>> Setting an empty vnc_password in qemu.conf is documented as a way to
>> disable VNC access, but QEMU does not seem to behave like that. Let's
>> enforce the behavior by setting pass
On Mon, Jun 27, 2016 at 07:21:12 +, Ren, Qiaowei wrote:
> Hi Peter,
>
> According to your comment, I updated the XML documentation and post new
> version here. Do you have any more comments?
It's still missing changes to the example file
tests/genericxml2xmlindata/generic-perf.xml
I also wi
On 28.06.2016 15:21, John Ferlan wrote:
>
>
> On 06/28/2016 09:02 AM, Michal Privoznik wrote:
>> https://bugzilla.redhat.com/show_bug.cgi?id=1316370
>>
>> Consider the following disk for a domain:
>>
>>
>>
>>
>>
>>
>> > startupPolicy='optional'/>
>>
On Tue, Jun 28, 2016 at 02:45:15PM +0200, Jiri Denemark wrote:
> Setting an empty vnc_password in qemu.conf is documented as a way to
> disable VNC access, but QEMU does not seem to behave like that. Let's
> enforce the behavior by setting password expiration to "now".
Hmm, i wonder when they regr
On Tue, Jun 28, 2016 at 03:03:15PM +0200, Michal Privoznik wrote:
> On 28.06.2016 13:48, Daniel P. Berrange wrote:
> > On Tue, Jun 28, 2016 at 01:43:56PM +0200, Michal Privoznik wrote:
> >> When working with typed params calling pure free() over an array
> >> of params is not enough. Some items in
On 06/28/2016 09:02 AM, Michal Privoznik wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1316370
>
> Consider the following disk for a domain:
>
>
>
>
>
>
>startupPolicy='optional'/>
>
>
>
>
>
> Now, startupPolicy is cur
28.06.2016 1:10, Laine Stump пишет:
On 06/27/2016 02:23 PM, Olga Krishtal wrote:
Patch fixes vz build after changes in IP-related netdev
functions(cf0568b0, fbc1843d).
Sorry about that. I *thought* I had searched in the drivers I couldn't
build. (BTW, I tried downloading and installing the p
On 28.06.2016 13:48, Daniel P. Berrange wrote:
> On Tue, Jun 28, 2016 at 01:43:56PM +0200, Michal Privoznik wrote:
>> When working with typed params calling pure free() over an array
>> of params is not enough. Some items in the array may be type of
>> string in which case they have a pointer to an
https://bugzilla.redhat.com/show_bug.cgi?id=1316370
Consider the following disk for a domain:
Now, startupPolicy is currently not allowed for iscsi disks, so
one would expect an error message to be thrown. But what a
surprise is
Some code paths already assume that it is allocated since it was always
allocated by virDomainPerfDefParseXML. Move allocation to
virDomainDefNew to handle cases that don't go through the XML parser.
This fixes crash when attempting to connect to an existing process via
virDomainQemuAttach.
Resol
Setting an empty vnc_password in qemu.conf is documented as a way to
disable VNC access, but QEMU does not seem to behave like that. Let's
enforce the behavior by setting password expiration to "now".
Note, this has no effect on setting an empty //graphics@passwd in
domain XML. Users may use //gra
On 28/06/16 14:00, Erik Skultety wrote:
> On 28/06/16 13:05, Jaroslav Suchanek wrote:
>> Reorder code for setting default log level from cmdline prior
>> initialization of log outputs. Thus the --verbose option is reflected.
>>
>> This resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1325072
>
https://bugzilla.redhat.com/show_bug.cgi?id=1046833
Signed-off-by: Jiri Denemark
---
docs/formatdomain.html.in | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index f660aa6..b0b2f82 100644
--- a/docs/formatdomain.ht
On 28/06/16 13:05, Jaroslav Suchanek wrote:
> Reorder code for setting default log level from cmdline prior
> initialization of log outputs. Thus the --verbose option is reflected.
>
> This resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1325072
> ---
>
> Notes:
> v2: moving up the cmdl
On Tue, Jun 28, 2016 at 01:43:56PM +0200, Michal Privoznik wrote:
> When working with typed params calling pure free() over an array
> of params is not enough. Some items in the array may be type of
> string in which case they have a pointer to an allocated memory
> too. Therefore we should use vir
On Tue, Jun 28, 2016 at 01:43:55PM +0200, Michal Privoznik wrote:
> The libvirt-domain.h header file suggests using virTypedParameter
> as virMemoryParameter is just ancient alias for it.
>
> Signed-off-by: Michal Privoznik
> ---
> Virt.xs | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletio
On Tue, Jun 28, 2016 at 01:43:54PM +0200, Michal Privoznik wrote:
> There's no functional change, this is just a cosmetic fix.
>
> Signed-off-by: Michal Privoznik
> ---
> Virt.xs | 50 +-
> 1 file changed, 25 insertions(+), 25 deletions(-)
ACK
Re
When working with typed params calling pure free() over an array
of params is not enough. Some items in the array may be type of
string in which case they have a pointer to an allocated memory
too. Therefore we should use virTypedParamsFree() which does all
the necessary.
Moreover, some methods (s
The libvirt-domain.h header file suggests using virTypedParameter
as virMemoryParameter is just ancient alias for it.
Signed-off-by: Michal Privoznik
---
Virt.xs | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Virt.xs b/Virt.xs
index 99ab150..cf4e5bc 100644
--- a/Virt.x
I've noticed these while trying to write support for the new
libvirt APIs (but Dan was quicker :-)).
Michal Privoznik (3):
Prefer virTypedParameterPtr over virTypedParameter *
get/set_memory_parameters: Favour virTypedParameter over
virMemoryParameter
Substitute Safefree with virTypedPar
There's no functional change, this is just a cosmetic fix.
Signed-off-by: Michal Privoznik
---
Virt.xs | 50 +-
1 file changed, 25 insertions(+), 25 deletions(-)
diff --git a/Virt.xs b/Virt.xs
index aed7f6f..99ab150 100644
--- a/Virt.xs
+++ b/Virt
On Tue, Jun 28, 2016 at 01:01:17PM +0200, Martin Kletzander wrote:
> On Tue, Jun 28, 2016 at 09:57:20AM +0100, Daniel P. Berrange wrote:
> > On Tue, Jun 28, 2016 at 10:49:33AM +0200, Martin Kletzander wrote:
> > > On Tue, Jun 28, 2016 at 10:12:01AM +0200, Martin Kletzander wrote:
> > > > On Mon, Ju
Reorder code for setting default log level from cmdline prior
initialization of log outputs. Thus the --verbose option is reflected.
This resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1325072
---
Notes:
v2: moving up the cmdline override for default logging level also
for the
On Tue, Jun 28, 2016 at 09:57:20AM +0100, Daniel P. Berrange wrote:
On Tue, Jun 28, 2016 at 10:49:33AM +0200, Martin Kletzander wrote:
On Tue, Jun 28, 2016 at 10:12:01AM +0200, Martin Kletzander wrote:
> On Mon, Jun 27, 2016 at 02:28:39PM -0400, Cole Robinson wrote:
> > Similar to what virsh and
Jan Beulich writes ("Re: [libvirt] [Xen-devel] Fixing libvirt's libxl driver
breakage -- where to define LIBXL_API_VERSION?"):
> On 27.06.16 at 18:54, wrote:
> > OK. Thanks for the feedback. I'll go ahead with my plan with the
> > git commit ids named in my earlier email.
>
> The only (hopeful
On Thu, Jun 23, 2016 at 01:25:29PM +0100, Jaroslav Safka wrote:
> Add conversion from xml to argv for subelements
> source,access and allocation of
>
> This change introduces support for preallocated
> shared file descriptor based memory backing.
> It allows vhost-user to be used without hugepage
On Thu, Jun 23, 2016 at 01:25:28PM +0100, Jaroslav Safka wrote:
> Add three new elements in memoryBacking and
> enable their parsing.
> (without converting to argv yet)
>
>
>
>
>
>
This is all fine since it matches what we discussed previously in
the context of Nova. For benefit of oth
On Tue, Jun 28, 2016 at 10:49:33AM +0200, Martin Kletzander wrote:
> On Tue, Jun 28, 2016 at 10:12:01AM +0200, Martin Kletzander wrote:
> > On Mon, Jun 27, 2016 at 02:28:39PM -0400, Cole Robinson wrote:
> > > Similar to what virsh and virt-login-shell do
> > >
> > > https://bugzilla.redhat.com/sho
On Tue, Jun 28, 2016 at 10:12:01AM +0200, Martin Kletzander wrote:
On Mon, Jun 27, 2016 at 02:28:39PM -0400, Cole Robinson wrote:
Similar to what virsh and virt-login-shell do
https://bugzilla.redhat.com/show_bug.cgi?id=1350315
---
I can't actually reproduce the bug, the backtrace is similar to
On 28/06/16 10:12, Martin Kletzander wrote:
> On Mon, Jun 27, 2016 at 02:28:39PM -0400, Cole Robinson wrote:
>> Similar to what virsh and virt-login-shell do
>>
>> https://bugzilla.redhat.com/show_bug.cgi?id=1350315
>> ---
>> I can't actually reproduce the bug, the backtrace is similar to
>> 97973e
---
Pushed as trivial.
src/vz/vz_sdk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c
index 7e75e44..ae218e9 100644
--- a/src/vz/vz_sdk.c
+++ b/src/vz/vz_sdk.c
@@ -829,7 +829,7 @@ prlsdkGetNetAddresses(PRL_HANDLE sdknet, virDomainNetDefPtr
n
On Mon, Jun 27, 2016 at 02:28:39PM -0400, Cole Robinson wrote:
Similar to what virsh and virt-login-shell do
https://bugzilla.redhat.com/show_bug.cgi?id=1350315
---
I can't actually reproduce the bug, the backtrace is similar to
97973ebb7 which added the same fix for virt-login-shell, and
that c
69 matches
Mail list logo
