[libvirt] [PATCH] usb: allow host devices to be specified by port

2016-07-05 Thread Thomas Hebb
Previously, only VID/PID and bus/device matching were supported. Neither of these provide a stable and persistent way of assigning a guest a specific host device out of several with the same VID and PID, as device numbers change on every enumeration. Add a third method of matching, bus/port,

Re: [libvirt] [PATCH v3 02/10] conf: Add new secret type "passphrase"

2016-07-05 Thread Daniel P. Berrange
On Tue, Jul 05, 2016 at 10:44:30AM -0400, John Ferlan wrote: > > > >>> Ok, so for LUKS i'd expect us to continue to just use the existing > >>> USAGE_TYPE_VOLUME we already have for this purpose. > >>> > >> > >> That then requires the "usage" of a in the domain xml to list > >> the volume path.

Re: [libvirt] [PATCH v3 02/10] conf: Add new secret type "passphrase"

2016-07-05 Thread John Ferlan
>>> Ok, so for LUKS i'd expect us to continue to just use the existing >>> USAGE_TYPE_VOLUME we already have for this purpose. >>> >> >> That then requires the "usage" of a in the domain xml to list >> the volume path. So rather than: >> >> >> >> >> >> it'd be: >> >>

Re: [libvirt] [PATCH v3 02/10] conf: Add new secret type "passphrase"

2016-07-05 Thread Daniel P. Berrange
On Tue, Jul 05, 2016 at 10:16:10AM -0400, John Ferlan wrote: > > > On 07/05/2016 09:37 AM, Daniel P. Berrange wrote: > > On Tue, Jul 05, 2016 at 09:33:30AM -0400, John Ferlan wrote: > >> > >> > >> On 07/04/2016 09:42 AM, Daniel P. Berrange wrote: > >>> On Fri, Jun 24, 2016 at 04:53:31PM -0400,

Re: [libvirt] [PATCH v3 02/10] conf: Add new secret type "passphrase"

2016-07-05 Thread John Ferlan
On 07/05/2016 09:37 AM, Daniel P. Berrange wrote: > On Tue, Jul 05, 2016 at 09:33:30AM -0400, John Ferlan wrote: >> >> >> On 07/04/2016 09:42 AM, Daniel P. Berrange wrote: >>> On Fri, Jun 24, 2016 at 04:53:31PM -0400, John Ferlan wrote: Add a new secret type known as "passphrase" - it will

Re: [libvirt] [PATCH 2/2] qemu: generate -display none

2016-07-05 Thread Daniel P. Berrange
On Tue, Jul 05, 2016 at 03:52:09PM +0200, Paolo Bonzini wrote: > > > On 05/07/2016 14:59, Daniel P. Berrange wrote: > > > if (!def->ngraphics) { > > > -virCommandAddArg(cmd, "-nographic"); > > > +if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_DISPLAY)) { > > > +

Re: [libvirt] [PATCH 2/2] qemu: generate -display none

2016-07-05 Thread Paolo Bonzini
On 05/07/2016 14:59, Daniel P. Berrange wrote: > > if (!def->ngraphics) { > > -virCommandAddArg(cmd, "-nographic"); > > +if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_DISPLAY)) { > > +virCommandAddArg(cmd, "-display"); > > +virCommandAddArg(cmd, "none"); > >

Re: [libvirt] [PATCH v3 02/10] conf: Add new secret type "passphrase"

2016-07-05 Thread Daniel P. Berrange
On Tue, Jul 05, 2016 at 09:33:30AM -0400, John Ferlan wrote: > > > On 07/04/2016 09:42 AM, Daniel P. Berrange wrote: > > On Fri, Jun 24, 2016 at 04:53:31PM -0400, John Ferlan wrote: > >> Add a new secret type known as "passphrase" - it will handle adding the > >> secret objects that need a

Re: [libvirt] [PATCH v3 02/10] conf: Add new secret type "passphrase"

2016-07-05 Thread John Ferlan
On 07/04/2016 09:42 AM, Daniel P. Berrange wrote: > On Fri, Jun 24, 2016 at 04:53:31PM -0400, John Ferlan wrote: >> Add a new secret type known as "passphrase" - it will handle adding the >> secret objects that need a passphrase without a specific username. >> >> The format is: >> >> >>

[libvirt] [PATCH v6 2/5] qemu: expand domain memory statistics with 'usable'

2016-07-05 Thread Derbyshev Dmitriy
From: Derbyshev Dmitry Currently 'memtotal' in virtio drivers and qemu corresponds to 'available' in libvirt. Because of that we introduce libvirt 'usable' parameter, which maps to 'stat-available-memory' balloon statistics. As balloon statistics isn't reported in hmp,

[libvirt] [PATCH v6 4/5] qemu: split qemuDomainMemoryStats into internal and external functions

2016-07-05 Thread Derbyshev Dmitriy
From: Derbyshev Dmitry Is necessary to call it from other contexts, such as qemuDomainGetStatsBalloon. Signed-off-by: Derbyshev Dmitry --- src/qemu/qemu_driver.c | 55 -- 1 file changed, 35

[libvirt] [PATCH v6 5/5] qemu: return balloon statistics when all domain statistics reported

2016-07-05 Thread Derbyshev Dmitriy
From: Derbyshev Dmitry To collect all balloon statistics for all guests it was necessary to make several libvirt requests. Now it's possible to get all balloon statiscs via single connectGetAllDomainStats call. Signed-off-by: Derbyshev Dmitry

[libvirt] [PATCH v6 1/5] virsh: Add balloon stats description to .pod

2016-07-05 Thread Derbyshev Dmitriy
From: Derbyshev Dmitry Description for existing balloon stats was missing for dommemstat. Signed-off-by: Derbyshev Dmitry --- tools/virsh.pod | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/tools/virsh.pod

[libvirt] [PATCH v6 3/5] qemu: expand domain memory statistics with 'last-update' timestamp

2016-07-05 Thread Derbyshev Dmitriy
From: Derbyshev Dmitry QEMU reports timestamp along with other memory statistics, but this information is not reported by libvirt statistics API. It could be useful to determine if the data reported is fresh or not. Signed-off-by: Derbyshev Dmitry

[libvirt] [PATCH v6 0/5] qemu: expand domain memory statistics

2016-07-05 Thread Derbyshev Dmitriy
From: Derbyshev Dmitry QEMU reports timestamp and available along with other memory statistics. This information was not saved into domain statistics. Also, to collect all balloon statistics for all guests it was necessary to make several libvirt requests (one per VE).

Re: [libvirt] [PATCH 2/2] qemu: generate -display none

2016-07-05 Thread Daniel P. Berrange
On Tue, Jul 05, 2016 at 02:35:28PM +0200, Paolo Bonzini wrote: > This is preferrable to -nographic which (in addition to disabling > graphics output) redirects the serial port to stdio and on OpenBIOS > enables the firmware's serial console. > > Signed-off-by: Paolo Bonzini

[libvirt] [PATCH 1/2] qemu: detect -display

2016-07-05 Thread Paolo Bonzini
Add a new capability for the -display command line option, which has been present since QEMU 1.0. Signed-off-by: Paolo Bonzini --- src/qemu/qemu_capabilities.c| 4 src/qemu/qemu_capabilities.h| 1 +

[libvirt] [PATCH 0/2] qemu: use -display none instead of -nographic

2016-07-05 Thread Paolo Bonzini
-display none is preferrable to -nographic which (in addition to disabling graphics output) redirects the serial port to stdio and on OpenBIOS enables the firmware's serial console. Paolo Bonzini (2): qemu: detect -display qemu: generate -display none src/qemu/qemu_capabilities.c

[libvirt] [PATCH 2/2] qemu: generate -display none

2016-07-05 Thread Paolo Bonzini
This is preferrable to -nographic which (in addition to disabling graphics output) redirects the serial port to stdio and on OpenBIOS enables the firmware's serial console. Signed-off-by: Paolo Bonzini --- src/qemu/qemu_command.c| 7 -

[libvirt] [PATCH 0/2] qemu: Fix SPICE migration with incorrect URI

2016-07-05 Thread Jiri Denemark
https://bugzilla.redhat.com/show_bug.cgi?id=1151723 Jiri Denemark (2): qemu: Properly reset spiceMigration flag qemu: Drop useless SPICE migration code src/qemu/qemu_domain.c| 1 + src/qemu/qemu_migration.c | 12 2 files changed, 1 insertion(+), 12 deletions(-) -- 2.9.0

[libvirt] [PATCH 2/2] qemu: Drop useless SPICE migration code

2016-07-05 Thread Jiri Denemark
The spiceMigration flag will never be true if there is no SPICE graphics configured for the domain. https://bugzilla.redhat.com/show_bug.cgi?id=1151723 Signed-off-by: Jiri Denemark --- src/qemu/qemu_migration.c | 12 1 file changed, 12 deletions(-) diff --git

[libvirt] [PATCH 1/2] qemu: Properly reset spiceMigration flag

2016-07-05 Thread Jiri Denemark
Otherwise migration during which we didn't send client_migrate_info QMP command will get stuck waiting for SPICE migration to finish if libvirtd sent the QMP command in a previous migration attempt. https://bugzilla.redhat.com/show_bug.cgi?id=1151723 Signed-off-by: Jiri Denemark