These tests verify that qemu hotplug is working properly with ccw
devices. There are both simple tests and more complex ones,
like adding a second ccw device or removing the first out of two ccw
devices.
---
tests/qemuhotplugtest.c | 37 +
1 file changed, 37 ins
---
.../qemuhotplug-ccw-virtio-1-explicit-reverse.xml | 8 +++
.../qemuhotplug-ccw-virtio-1-explicit.xml | 8 +++
.../qemuhotplug-ccw-virtio-2-explicit.xml | 8 +++
.../qemuhotplug-ccw-virtio-2.xml | 8 +++
.../qemuhotplug-ccw-virtio.xml
These changes require another patch, or else there would be conflicts:
[libvirt] [PATCH 0/3] Clean up qemuhotplugtest xml files
https://www.redhat.com/archives/libvir-list/2016-July/msg00202.html
Hotplugging ccw devices was previously not tested, so I decided
to add some testcases because I plan
This patch adds virConnectGetDomainCapabilities support for bhyve.
---
src/bhyve/bhyve_capabilities.c | 26
src/bhyve/bhyve_capabilities.h | 5
src/bhyve/bhyve_driver.c | 56 ++
3 files changed, 87 insertions(+)
diff --git
First, remove escaped newlines and split up the string into an argv-list for
the bhyve and loader commands, respectively. This is done by iterating over the
string splitting it by newlines, and then re-iterating over each line,
splitting it by spaces.
Since this code reuses part of the code of qem
---
tests/Makefile.am | 23 ++-
.../bhyveargv2xmldata/bhyveargv2xml-acpiapic.args | 9 +
tests/bhyveargv2xmldata/bhyveargv2xml-acpiapic.xml | 20 ++
tests/bhyveargv2xmldata/bhyveargv2xml-ahci-hd.args | 8 +
tests/bhyveargv2xmldata/bhyveargv2xml-ahci-hd.xml
A simpe getopt-based argument parser is added for the /usr/sbin/bhyve command,
loosely based on its argument parser, which reads the following from the bhyve
command line string:
* vm name
* number of vcpus
* memory size
* the time offset (UTC or localtime)
* features:
* acpi
* ioapic: While t
Several gnulib headers rely on features.h being included by ctype.h to provide
__GNUC_PREREQ, but on systems without glibc, this is not provided. In these
cases __GNUC_PREREQ gets redefined to 0, which causes build errors from checks
in src/internal.h.
Therefore, define __GNUC_PREREQ as early as po
Differences to v4:
- fixed various memory leaks
- various style improvements by Roman Bogorodskiy and fixes for his comments
on v4
Link to v4:
https://www.redhat.com/archives/libvir-list/2016-June/msg02138.html
Link to v3:
https://www.redhat.com/archives/libvir-list/2016-June/msg
Unconditionally use gnulib's getopt module. This is needed by the bhyve driver
to provide a reentrant interface for getopt.
---
bootstrap.conf | 1 +
m4/virt-driver-bhyve.m4 | 3 +++
po/POTFILES.in | 1 +
3 files changed, 5 insertions(+)
diff --git a/bootstrap.conf b/bootstrap.c
A simple getopt-based argument parser is added for the /usr/sbin/bhyveload
command, loosely based on its argument parser.
The boot disk is guessed by iterating over all
disks and matching their sources. If any non-default arguments are found,
def->os.bootloaderArgs is set accordingly, and the boot
On some systems perl is not necessarily in /usr/bin/perl. Use the perl version
in the PATH instead.
---
tests/test-wrap-argv.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/test-wrap-argv.pl b/tests/test-wrap-argv.pl
index d66f5b4..b053f28 100755
--- a/tests/test-wrap-
On Thu, 2016-07-07 at 17:41 +0200, Jaroslav Suchanek wrote:
> Follow the same logic for adding qemu user also for kvm and qemu groups. As
> is described in https://fedoraproject.org/wiki/Packaging:UsersAndGroups
> document there should be preallocated UIDs and GIDs for libvirt. A check for
> requir
On 07.07.2016 15:41, Peter Krempa wrote:
> Status XML tests were done by prepending a constant string to an
> existing XML. With the planned changes the header will depend on data
> present in the definition rather than just on the data that was parsed.
>
> The first dynamic element in the header
On 07.07.2016 15:41, Peter Krempa wrote:
> Allow to store driver specific data on a per-vcpu basis.
>
> Move of the virDomainDef*Vcpus* functions was necessary as
> virDomainXMLOptionPtr was declared below this block and I didn't want to
> split the function headers.
> ---
> src/conf/domain_conf.
On 07.07.2016 15:40, Peter Krempa wrote:
> Cleanups and improvements that will make adding the new vCPU hotplug that was
> recently added to qemu easier.
>
> Peter Krempa (11):
> conf: Annotate that private data for objects are not copied
> conf: Extract code formatting vCPU info
> conf: Ren
Implement support for "virsh cpu-compare" so that we can calculate
common cpu element between a pool of hosts, which had a requirement
of providing host cpu description.
Signed-off-by: Joao Martins
---
src/libxl/libxl_driver.c | 38 ++
1 file changed, 38 inser
Parse libxl_hwcaps accounting for versions for Xen 4.4.
libxl_hwcaps is a set of cpuid leaves output that is described in [0] or
[1] in Xen 4.7. This is a collection of CPUID leaves that are we version
in libvirt whenever leaves are reordered or added. Thus we keep the
common ones in one struct and
Hey!
This series is the RFC I mentioned in cpu map discussion for libxl[0].
That is to implement host.cpu element in caps,by getting topology and xen
hwcaps parsing done, followed by having cpu-{compare,baseline} and get cpu
models APIs implemented. Last thing missing I think it would be to
libxl_
Useful for libvirt users (e.g. virt-manager) to extract CPU map
described model names. However setting of cpuid is not
yet implemented.
Signed-off-by: Joao Martins
---
src/libxl/libxl_driver.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/src/libxl/libxl_driver.c b/src/lib
Refactor code from hwcaps to its own helper namely
libxlCapsInitCPU to handle all host cpu related operations.
Signed-off-by: Joao Martins
---
src/libxl/libxl_capabilities.c | 46 +-
1 file changed, 37 insertions(+), 9 deletions(-)
diff --git a/src/libxl/
Akin to previous commit but for "virsh cpu-baseline" which
computes a baseline CPU for a set of host cpu elements.
Signed-off-by: Joao Martins
---
src/libxl/libxl_driver.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_drive
An error in virHostCPUGetKVMMaxVCPUs() means we've been unable
to access /dev/kvm, or we're running on a platform that doesn't
support KVM in the first place.
If that's the case, we shouldn't ignore the error and report
domcapabilities even though we know the user won't be able to
start any KVM gu
All Linux releases we support (RHEL6 era) include these
definitions.
---
src/util/virhostcpu.c | 11 ---
1 file changed, 11 deletions(-)
diff --git a/src/util/virhostcpu.c b/src/util/virhostcpu.c
index a33932f..8a8bda8 100644
--- a/src/util/virhostcpu.c
+++ b/src/util/virhostcpu.c
@@ -65,
Rebased on top of current master.
Previous attempt:
https://www.redhat.com/archives/libvir-list/2016-June/msg02037.html
Andrea Bolognani (3):
util: hostcpu: Add virHostCPUGetKVMMaxVCPUs() stub
util: hostcpu: Drop obsolete compatibility code
qemu: capabilities: Make virHostCPUGetKVMMaxVC
If we don't HAVE_LINUX_KVM_H, we can't query /dev/kvm to discover
the limits on the number of vCPUs, so we report an error and
return a negative value instead.
---
src/util/virhostcpu.c | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/src/util/virhostcpu.c b/src/
Playing directly with our live definition, updating it, and reverting it
back once we are done is very nice and it's quite dangerous too. Let's
just make a copy of the domain definition if needed and do all tricks on
the copy.
https://bugzilla.redhat.com/show_bug.cgi?id=1320470
Signed-off-by: Jir
https://bugzilla.redhat.com/show_bug.cgi?id=1320470
Jiri Denemark (2):
qemu: Copy complete domain def in qemuDomainDefFormatBuf
qemu: Drop default channel path during migration
src/conf/domain_conf.c | 10 +++---
src/qemu/qemu_domain.c | 87 +-
Migration to an older libvirt (pre v1.3.0-175-g7140807) is broken
because older versions of libvirt generated different channel paths and
they didn't drop the default paths when parsing domain XMLs. We'd get
such a nice error message:
internal error: process exited while connecting to monitor:
On 07/08/2016 09:08 AM, Cedric Bosdonnat wrote:
> Hello Joao!
>
> On Thu, 2016-07-07 at 16:20 +0100, Joao Martins wrote:
>> FYI I too am working on guest config work and have an RFC wrt to
>> libvirt host
>> cpu detection. Perhaps we could joint work on this?
>
> I started looking at the host c
On 08.07.2016 16:38, Peter Krempa wrote:
[snip]
>>>
>> Right, I can add another API to retrieve only the states, still using
>> the same monitor interface. I didn't want to break policy (in fact I
>> wasn't aware of that particular one), apologies.
>
> Well, there isn't much of a policy at this po
On Fri, Jul 08, 2016 at 16:33:59 +0200, Viktor Mihajlovski wrote:
> On 08.07.2016 15:54, Peter Krempa wrote:
> > On Fri, Jul 08, 2016 at 15:39:00 +0200, Boris Fiuczynski wrote:
> >> From: Viktor Mihajlovski
> >>
> >> Currently, the virVcpuInfo returned by virDomainGetVcpus() will always
> >> repor
On 08.07.2016 15:54, Peter Krempa wrote:
> On Fri, Jul 08, 2016 at 15:39:00 +0200, Boris Fiuczynski wrote:
>> From: Viktor Mihajlovski
>>
>> Currently, the virVcpuInfo returned by virDomainGetVcpus() will always
>> report a state of VIR_VCPU_RUNNING for each defined domain vcpu even if
>> the vcpu
On 07.07.2016 15:27, Martin Kletzander wrote:
> Initially posted in order to achieve something else, but that got
> rejected, so at least the cleanup part of it could make it in.
>
> The previous versions (whose goal was something completely idfferent) are
> here:
>
> - https://www.redhat.com/a
On 07/07/2016 11:59, Michal Privoznik wrote:
> BTW: there are lots of '-nographic' in our
> tests/qemuxml2argvdata/qemuxml2argv-*.args files, do we want to update
> those to have '-display none' instead?
Possibly, but to do that you'd have to add the capability to all the
tests. It would be irr
On Fri, Jul 08, 2016 at 15:39:00 +0200, Boris Fiuczynski wrote:
> From: Viktor Mihajlovski
>
> Currently, the virVcpuInfo returned by virDomainGetVcpus() will always
> report a state of VIR_VCPU_RUNNING for each defined domain vcpu even if
> the vcpu is currently in the halted state.
>
> As the
From: Viktor Mihajlovski
Currently, the virVcpuInfo returned by virDomainGetVcpus() will always
report a state of VIR_VCPU_RUNNING for each defined domain vcpu even if
the vcpu is currently in the halted state.
As the monitor interface is in fact reporting the accurate state, it is
rather easy t
In the file, there are couple of 'if-else' occurrences that just
hurt my eyes. For instance, multiline expression should be
wrapped in curly braces, if one side of 'else' has curly braces
the other one should have them too, and so on.
Signed-off-by: Michal Privoznik
---
examples/libvirt.php | 10
Signed-off-by: Michal Privoznik
---
examples/index.php | 12 +++-
examples/libvirt.php | 5 +
2 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/examples/index.php b/examples/index.php
index dbaa1bf..bdeb506 100644
--- a/examples/index.php
+++ b/examples/index.php
@@ -
So we have this special class Libvirt implemented in
examples/libvirt.php. It's aim is to wrap some low-level libvirt
APIs into slightly more advanced methods. Now, when instantiating
the class, connection URI can be passed in which case the class
will connect to it right in the constructor. Howeve
Signed-off-by: Michal Privoznik
---
examples/libvirt.php | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/examples/libvirt.php b/examples/libvirt.php
index c30f06a..96aac6e 100644
--- a/examples/libvirt.php
+++ b/examples/libvirt.php
@@ -502,12 +502,13 @@ class Libvirt {
This file is just one class wrapping some libvirt APIs. However,
its formatting is just messy. Resolve this. Best viewed with:
git show --ignore-space-change
Signed-off-by: Michal Privoznik
---
examples/libvirt.php | 2308 +-
1 file changed, 115
Signed-off-by: Michal Privoznik
---
.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/.gitignore b/.gitignore
index 927a4db..8c52e3f 100644
--- a/.gitignore
+++ b/.gitignore
@@ -33,6 +33,7 @@ autom4te.cache/
m4/*
src/*.so
stamp-h1
+tags
tools/generate-api-docs
libvirt-php-*.tar.
The majority of the code has opening curly brace at the very same
line as the function declaration. Except for the two:
_set_last_error() and set_logfile(). Fix them.
Signed-off-by: Michal Privoznik
---
examples/libvirt.php | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git
Le sigh. There's too much in this patch, I know. But hey, have
you seen the code? It was terrible. Now it's at least slightly
better readable.
Signed-off-by: Michal Privoznik
---
examples/index.php | 1333 ++--
1 file changed, 657 insertions(+), 67
Signed-off-by: Michal Privoznik
---
examples/libvirt.php | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/examples/libvirt.php b/examples/libvirt.php
index 14436d8..2cab7a8 100644
--- a/examples/libvirt.php
+++ b/examples/libvirt.php
@@ -210,9 +210,9 @@ class Libvirt {
Signed-off-by: Michal Privoznik
---
examples/libvirt.php | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/examples/libvirt.php b/examples/libvirt.php
index 96aac6e..32d8314 100644
--- a/examples/libvirt.php
+++ b/examples/libvirt.php
@@ -456,12 +456,16 @@ class Libvirt {
It's not . Hawk.
Signed-off-by: Michal Privoznik
---
examples/header.php | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/header.php b/examples/header.php
index c944da0..14d45d9 100644
--- a/examples/header.php
+++ b/examples/header.php
@@ -4,4 +4,4 @@
| Virtual net
This is for examples/ reformat mostly. But there are some other fixes too.
BTW: This is pushed, so if you have any objections - patches are welcome :)
Michal Privoznik (14):
gitignore: Ignore tags file
configure: Provide default for php-confdir
libvirt-php.spec.in: Honour php-{extensiondir,
We use some really weird logic to get the directory where
libvirt-php.ini should go. We try to parse 'php-config
--configure' output. However, it may happen, that we learn
nothing from that. If that's the case, we should provide some
sensible default, /etc/php.d/ for instance.
Signed-off-by: Micha
Signed-off-by: Michal Privoznik
---
configure.ac | 2 ++
examples/index.php | 6 ++---
examples/libvirt.php | 68
libvirt-php.spec.in | 1 +
m4/virt-php-extension.m4 | 35 +
5 files changed, 75
So while we have the ability to specify where the module should
be installed, we are not doing so in the spec file. It's not very
wise.
Signed-off-by: Michal Privoznik
---
libvirt-php.spec.in | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/libvirt-php.spec.in b/libvirt-
A bool 'report' has been introduced in various functions, which when set
to true will produce the error it is suppposed to produce, and when
false, will suppress the error. These functions are used in the next
patch for auto-completion.
Signed-off-by: Nishith Shah
---
tools/vsh.c | 33 ++
Decompose vshCmddefOptParse into two helper functions, vshCmddefOptFill
and vshCmddefCheckInternals.
vshCmddefCheckInternals checks if the internal command definitions are
correct or not.
vshCmddefOptFill keeps track of the required options and mandatory
arguments through opts_required and opts_n
This series of patches are meant to improve existing auto-complete
functionality in virsh.
The first patch breaks vshCmddefOptParse into two smaller functions, for
use later in the third patch.
The second patch simply changes the types of variables used in existing
readline generators.
The third
The new function works as expected, and matches the current level of
autocomplete offered, along with several other improvements like quotes
handling, multiple command completion and space handling. Now, it is easy
to introduce options completer here.
Signed-off-by: Nishith Shah
---
tools/vsh.c
Use unsigned int for array indexes and size_t for length variables.
Signed-off-by: Nishith Shah
---
tools/vsh.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tools/vsh.c b/tools/vsh.c
index dcf99f2..c5d7578 100644
--- a/tools/vsh.c
+++ b/tools/vsh.c
@@ -2537,7 +2537,8
On Wed, Jul 06, 2016 at 12:11:35 +0200, Pavel Hrdina wrote:
> On Tue, Jul 05, 2016 at 10:17:38AM +0200, Jiri Denemark wrote:
> > https://bugzilla.redhat.com/show_bug.cgi?id=1151723
> >
>
> ACK series
Pushed, thanks.
Jirka
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.co
Since return code is checked globally at the end of the function, let's
make sure that we set it correctly at any point.
This fixes a regression introduced in commit 0aa19f35 where the first
command to eject changeable media would fail unconditionally.
Signed-off-by: Bjoern Walk
Reviewed-by: Bor
On Wed, Jul 06, 2016 at 10:11:18PM +0100, Zeeshan Ali (Khattak) wrote:
> On Thu, May 12, 2016 at 1:28 PM, Christophe Fergeau
> wrote:
> > Looks I never answered this one.
> >
> > On Tue, Apr 26, 2016 at 05:04:30PM +0100, Zeeshan Ali (Khattak) wrote:
> >> >> +const gchar
> >> >> *gvir_config_doma
Hello Joao!
On Thu, 2016-07-07 at 16:20 +0100, Joao Martins wrote:
> FYI I too am working on guest config work and have an RFC wrt to
> libvirt host
> cpu detection. Perhaps we could joint work on this?
I started looking at the host cpu detection yesterday, but it seems the libxl
hw_map bits ar
61 matches
Mail list logo
