[libvirt] [PATCH v2 07/10] add qemuDomainPCIAddrSetCreateFromDomain

The address sets (pci, ccw, virtio serial) are currently cached in qemu private data, but all the information required to recreate these sets is in the domain definition. Therefore I am removing the redundant data and adding a way to recalculate these sets. Add a function that calculates the pci

[libvirt] [PATCH v2 04/10] Add qemuDomainCCWAddrSetCreateFromDomain

The address sets (pci, ccw, virtio serial) are currently cached in qemu private data, but all the information required to recreate these sets is in the domain definition. Therefore I am removing the redundant data and adding a way to recalculate these sets. Add a function that calculates the ccw

[libvirt] [PATCH v2 06/10] qemu: remove ccwaddrs caching

Dropping the caching of ccw address set. The cached set is not required anymore, because the set is now being recalculated from the domain definition on demand, so the cache can be deleted. --- src/qemu/qemu_domain.c | 1 - src/qemu/qemu_domain.h | 1 -

[libvirt] [PATCH v2 02/10] qemu_hotplug: generate vioserial address list on demand

Dropping the caching of virtio serial address set. Instead of using the cached address set, a function in qemu_hotplug.c now recalculates it on demand. Credit goes to Cole Robinson. --- src/qemu/qemu_hotplug.c | 38 ++ 1 file changed, 26 insertions(+), 12

[libvirt] [PATCH v2 10/10] Remove unused functions that release addresses

Since address sets are now recalculated on demand instead of being cached, there's no need for functions that release addresses. --- src/conf/domain_addr.c | 100 --- src/conf/domain_addr.h | 16 src/libvirt_private.syms | 3 -- 3 files

[libvirt] [PATCH v2 09/10] qemu: remove pciaddrs caching

The cached pci address set is not required anymore, because the set is now being recalculated from the domain definition on demand, so the cache can be deleted. --- src/qemu/qemu_domain.c | 1 - src/qemu/qemu_domain.h | 1 - src/qemu/qemu_domain_address.c | 16 +++-

[libvirt] [PATCH v2 00/10] Remove caching of address sets

From: Tomasz Flendrich These patches delete the caching of pci, virtioSerial and ccw address sets. I am deleting them, because they can be recalculated from the domain definition, and there's no point in keeping redundant data, especially because handling a

[libvirt] [PATCH v2 08/10] qemu_hotplug: generate pci address list on demand

Dropping the caching of pci address set. Instead of using the cached address set, functions in qemu_hotplug.c now recalculate it on demand. --- src/qemu/qemu_domain_address.c | 6 -- src/qemu/qemu_hotplug.c| 47 +++--- 2 files changed, 39

[libvirt] [PATCH v2 05/10] qemu_hotplug: generate ccw address list on demand

Dropping the caching of ccw address set. Instead of using the cached address set, functions in qemu_hotplug.c now recalculate it on demand. --- src/qemu/qemu_hotplug.c | 26 +- 1 file changed, 21 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_hotplug.c

[libvirt] [PATCH v2 01/10] add virDomainVirtioSerialAddrSetCreateFromDomain

The address sets (pci, ccw, virtio serial) are currently cached in qemu private data, but all the information required to recreate these sets is in the domain definition. Therefore I am removing the redundant data and adding a way to recalculate these sets. Add a function that calculates the

[libvirt] [PATCH v2 03/10] qemu: remove vioserialaddrs caching

Dropping the caching of virtio serial address set. The cached set is not required anymore, because the set is now being recalculated from the domain definition on demand, so the cache can be deleted. Credit goes to Cole Robinson. --- src/qemu/qemu_domain.c | 1 - src/qemu/qemu_domain.h

Re: [libvirt] [PATCH v4] libxl: implement virDomainBlockStats

On 07/20/2016 04:48 PM, Joao Martins wrote: > Introduce initial support for domainBlockStats API call that > allow us to query block device statistics. openstack nova > uses this API call to query block statistics, alongside > virDomainMemoryStats and virDomainInterfaceStats. Note that > this

Re: [libvirt] [PATCH v2] qemuhotplugtest: Add tests for ccw devices

On Thu, Jul 21, 2016 at 08:38:17PM +0200, Tomasz Flendrich wrote: […] But the problem is that you are not checking any assignment. The code is not executed at all. That's because you specify 'target dev=' from which we're trying to guess the right address. Because

[libvirt] [PATCH v3] qemuhotplugtest: Add tests for ccw devices

There's a plan to rework the address handling, so testcases that verify hotplugging ccw devices will help in avoiding regression. In this commit, some files are duplicated because of the way qemuhotplug.c calculates the expected xml filenames. I plan on changing that to explicitly stating the

Re: [libvirt] [PATCHv5 2/5] Add GVirConfigDomainHostdev

On Fri, Jul 22, 2016 at 01:34:09PM +0100, Zeeshan Ali (Khattak) wrote: > > Thanks. If there is a way to also set the address to send emails to, > I'll gladly drop my commands (actually they are git aliases). That's git config sendemail.to f...@example.com Christophe signature.asc Description:

Re: [libvirt] [PATCH] nodedev: Add retry logic to read fibre channel files

On Fri, Jul 22, 2016 at 09:14:50AM -0400, John Ferlan wrote: > > ping. Even if the answer is - let's not fix this... I don't think we want todo this. The method where you're putting the sleep(1) is called from the libvirt main event loop. So that's going to add major stalls in processing other

Re: [libvirt] [PATCH] qemu: hotplug: fix changeable media ejection

John Ferlan [2016-07-22, 12:58PM +0200]: [...] Ahh - the success case. I was reading as the failure and goto case probably because of the commit message. Yeah, I probably should have explained this explicitly in the commit message, sorry about that. So ACK to the patch

Re: [libvirt] [PATCH] nodedev: Add retry logic to read fibre channel files

ping. Even if the answer is - let's not fix this... Tks - John On 06/29/2016 05:43 PM, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1319544 > > During processing of a vport_create event, udevEventHandleCallback > will call udevProcessSCSIHost to read the fibre channel

[libvirt] [libvirt-glib v7 4/5] gconfig: Add GVirConfigDomainAddressPci getters

From: Christophe Fergeau They will be useful to do more checks in the GVirDomainDeviceHostdev unit test. --- .../libvirt-gconfig-domain-address-pci.c | 45 ++ .../libvirt-gconfig-domain-address-pci.h | 5 +++

[libvirt] [libvirt-glib v7 3/5] gconfig: Add GVirConfigDomainHostdevPci

Add API to read and write PCI hostdev nodes. --- libvirt-gconfig/Makefile.am| 2 + .../libvirt-gconfig-domain-hostdev-pci.c | 232 + .../libvirt-gconfig-domain-hostdev-pci.h | 81 +++

[libvirt] [libvirt-glib v7 2/5] gconfig: Add GVirConfigDomainHostdev

Add API to read and write domain/devices/hostdev nodes. This patch only adds the baseclass and hence is not useful on it's own. A more specific subclass to represent PCI devices will be added in a following patch. --- libvirt-gconfig/Makefile.am| 2 +

[libvirt] [libvirt-glib v7 1/5] gconfig: Add gvir_config_object_has_child

From: Christophe Fergeau --- libvirt-gconfig/libvirt-gconfig-object-private.h | 2 ++ libvirt-gconfig/libvirt-gconfig-object.c | 13 + 2 files changed, 15 insertions(+) diff --git a/libvirt-gconfig/libvirt-gconfig-object-private.h

[libvirt] [libvirt-glib v7 5/5] tests: Add test for GVirConfigDomainHostdevPci API

--- tests/test-gconfig.c| 43 + tests/xml/gconfig-domain-device-pci-hostdev.xml | 11 +++ 2 files changed, 54 insertions(+) create mode 100644 tests/xml/gconfig-domain-device-pci-hostdev.xml diff --git a/tests/test-gconfig.c

Re: [libvirt] [PATCH 1/2] qemu: attempt to delete disk when SCSI attach failed

On Fri, Jul 22, 2016 at 01:42:44PM +0200, Peter Krempa wrote: > On Fri, Jul 22, 2016 at 12:08:45 +0200, Guido Günther wrote: > > We have a qemuMonitorDriveDel now so use it > > --- > > src/qemu/qemu_hotplug.c | 9 + > > 1 file changed, 5 insertions(+), 4 deletions(-) > > > > diff --git

Re: [libvirt] [PATCHv5 2/5] Add GVirConfigDomainHostdev

Hi, On Fri, Jul 22, 2016 at 10:27 AM, Christophe Fergeau wrote: > On Thu, Jul 21, 2016 at 06:11:36PM +0100, Zeeshan Ali (Khattak) wrote: >> Hi, >> >> On Mon, Jul 18, 2016 at 3:54 PM, Christophe Fergeau >> wrote: >> > Please add a gconfig: prefix to the

Re: [libvirt] [PATCH] qemu: bugfix: don't fail if disk media removed on second attempt

fixed another way in https://www.redhat.com/archives/libvir-list/2016-July/msg00208.html, so closed On 29.06.2016 15:22, Nikolay Shirokovskiy wrote: > Signed-off-by: Nikolay Shirokovskiy > --- > src/qemu/qemu_hotplug.c | 8 > 1 file changed, 4

Re: [libvirt] [PATCH] virt-aa-helper: Make help output match option name

On 07/22/2016 06:09 AM, Guido Günther wrote: > --- > src/security/virt-aa-helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c > index bdead57..49e12b9 100644 > --- a/src/security/virt-aa-helper.c > +++

Re: [libvirt] [PATCH 0/2] Invoke drive_del on failute to attach disks

On 07/22/2016 06:08 AM, Guido Günther wrote: > There is a drive_del in QEMU so we should use it. > > Guido Günther (2): > qemu: attempt to delete disk when SCSI attach failed > qemu: attempt to delete disk when USB mass storage attach failed > > src/qemu/qemu_hotplug.c | 24

Re: [libvirt] [PATCH 1/2] qemu: attempt to delete disk when SCSI attach failed

On Fri, Jul 22, 2016 at 12:08:45 +0200, Guido Günther wrote: > We have a qemuMonitorDriveDel now so use it > --- > src/qemu/qemu_hotplug.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c > index e8a30d5..6232a0e

Re: [libvirt] [PATCH] qemu: hotplug: fix changeable media ejection

On 07/21/2016 07:43 AM, Bjoern Walk wrote: > John Ferlan [2016-07-21, 12:23PM +0200]: >> >> >> On 07/08/2016 06:30 AM, Bjoern Walk wrote: >>> Since return code is checked globally at the end of the function, let's >>> make sure that we set it correctly at any point. >>> >>>

Re: [libvirt] [PATCH v3] util: systemd: Define MSG_NOSIGNAL if needed

On 22 Jul 2016, at 10:13, Daniel P. Berrange wrote: > On Wed, Jul 20, 2016 at 03:11:51PM +0100, Justin Clift wrote: >> On 20 Jul 2016, at 14:46, Andrea Bolognani wrote: >>> The symbol being missing has been reported as causing build >>> failures on OS X.

Re: [libvirt] [PATCH v3 0/3] qemu: add support for multiple gluster hosts/servers

On Fri, Jul 22, 2016 at 15:14:47 +0530, Prasanna Kalever wrote: > On Fri, Jul 22, 2016 at 2:03 PM, Peter Krempa wrote: > > On Fri, Jul 22, 2016 at 13:50:28 +0530, Prasanna Kumar Kalever wrote: > >> These series of patches are rebased on latest master; > >> The dependent QEMU

[libvirt] [PATCH 2/2] qemu: attempt to delete disk when USB mass storage attach failed

We have a qemuMonitorDriveDel now so use it --- src/qemu/qemu_hotplug.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 6232a0e..87c208b 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c

[libvirt] [PATCH 1/2] qemu: attempt to delete disk when SCSI attach failed

We have a qemuMonitorDriveDel now so use it --- src/qemu/qemu_hotplug.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index e8a30d5..6232a0e 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@

[libvirt] [PATCH 0/2] Invoke drive_del on failute to attach disks

There is a drive_del in QEMU so we should use it. Guido Günther (2): qemu: attempt to delete disk when SCSI attach failed qemu: attempt to delete disk when USB mass storage attach failed src/qemu/qemu_hotplug.c | 24 1 file changed, 16 insertions(+), 8 deletions(-)

[libvirt] [PATCH] virt-aa-helper: Make help output match option name

--- src/security/virt-aa-helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index bdead57..49e12b9 100644 --- a/src/security/virt-aa-helper.c +++ b/src/security/virt-aa-helper.c @@ -107,7 +107,7 @@

Re: [libvirt] [PATCH v3 1/3] storage: add gluster backend initialization support for multiple servers

On Fri, Jul 22, 2016 at 01:50:29PM +0530, Prasanna Kumar Kalever wrote: > This patch adds support for initialization of gluster backend > with multiple servers which acts as gluster volfile servers for > the gluster storage backend. > > This will help in achieving high availability of gluster

Re: [libvirt] [PATCH v3 0/3] qemu: add support for multiple gluster hosts/servers

On Fri, Jul 22, 2016 at 2:03 PM, Peter Krempa wrote: > On Fri, Jul 22, 2016 at 13:50:28 +0530, Prasanna Kumar Kalever wrote: >> These series of patches are rebased on latest master; >> The dependent QEMU patches are now merged on master targeting for 2.7 > > I actually started

Re: [libvirt] [PATCHv5 2/5] Add GVirConfigDomainHostdev

On Thu, Jul 21, 2016 at 06:11:36PM +0100, Zeeshan Ali (Khattak) wrote: > Hi, > > On Mon, Jul 18, 2016 at 3:54 PM, Christophe Fergeau > wrote: > > Please add a gconfig: prefix to the subject line. > > I have a custom git command to add 'libvirt-glib' prefix but I keep >

Re: [libvirt] [PATCH 2/2] schema: fix resolved interfaces of network type

On Wed, Jul 20, 2016 at 03:11:46PM +0300, Nikolay Shirokovskiy wrote: > This patch reflects cases when element and its > subelement for network type are formated based on actual type resolved > from referenced network instead of original one. networkAllocateActualDevice > and

Re: [libvirt] [PATCH 1/2] schema: add missed alias element to memory device

On Wed, Jul 20, 2016 at 03:11:45PM +0300, Nikolay Shirokovskiy wrote: > --- > docs/schemas/domaincommon.rng | 3 +++ > 1 file changed, 3 insertions(+) ACK Regards, Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o-

Re: [libvirt] [PATCH] lxc: Don't crash by forgetting to ref transient domains

On Wed, Jul 20, 2016 at 02:56:41PM +0200, Martin Kletzander wrote: > So commit 306b3a8504 tried mimicking behaviour of commit 540c339a25, but > added a virObjectRef(vm) only after virDomainObjListAdd() in > lxcDomainDefineXMLFlags() and not in lxcDomainCreateXMLWithFiles(). > That way undefining a

Re: [libvirt] [PATCH v3] util: systemd: Define MSG_NOSIGNAL if needed

On Wed, Jul 20, 2016 at 03:11:51PM +0100, Justin Clift wrote: > On 20 Jul 2016, at 14:46, Andrea Bolognani wrote: > > The symbol being missing has been reported as causing build > > failures on OS X. If it's not already defined, define it to > > zero so that it won't have any

Re: [libvirt] [PATCH v3] util: systemd: Define MSG_NOSIGNAL if needed

On Wed, Jul 20, 2016 at 03:46:56PM +0200, Andrea Bolognani wrote: > The symbol being missing has been reported as causing build > failures on OS X. If it's not already defined, define it to > zero so that it won't have any effect. > --- > Changes from v2: > > * define MSG_NOSIGNAL to zero if

Re: [libvirt] [PATCH RFC 0/5] lxc: Add save/restore support to lxc driver

On Thu, Jul 21, 2016 at 03:37:22PM +, Katerina Koukiou wrote: > This patch series adds support for saving an running lxc domain's state into > files with lxcDomainSave and restore afterwards from files with > lxcDomainRestore. > Usage: virsh save [domain-name] [domain-id or domain-uuid]

Re: [libvirt] [PATCH RFC 5/5] lxc: adds save and restore support

On Thu, Jul 21, 2016 at 03:37:27PM +, Katerina Koukiou wrote: > Add support for saving an lxc domain's state into files with lxcDomainSave > and restore from file with lxcDomainRestore. > Usage: virsh save [domain-name] [domain-id or domain-uuid] [directory name] > > Signed-off-by: Katerina

Re: [libvirt] [PATCH RFC 4/5] lxc: adjusted libvirt-lxc process to add restore mode to it.

On Thu, Jul 21, 2016 at 03:37:26PM +, Katerina Koukiou wrote: > When doing lxc migration or simply restoring the container from a > saved state, we need restore the container from CRIU img files that > we have stored in disk. In this patch, we should extend > lxcContainerStart into a more

Re: [libvirt] [PATCH RFC 3/5] lxc: adds checkpoint and restore helper functions

On Thu, Jul 21, 2016 at 03:37:25PM +, Katerina Koukiou wrote: > This patch adds some helper functions for checkpointing/restoring > linux containers. We use CRIU binary. > > Signed-off-by: Katerina Koukiou > --- > po/POTFILES.in | 1 + > src/Makefile.am| 3

Re: [libvirt] [PATCH RFC 2/5] lxc: make container's init process session leader

On Thu, Jul 21, 2016 at 03:37:24PM +, Katerina Koukiou wrote: > This patch forces container's init process, to become a session leader, > that is its session ID is made the same as its process ID. > That might seem unnecessary in general, but if we want to checkpoint a > container with CRIU,

Re: [libvirt] [PATCH v3 0/3] qemu: add support for multiple gluster hosts/servers

On Fri, Jul 22, 2016 at 13:50:28 +0530, Prasanna Kumar Kalever wrote: > These series of patches are rebased on latest master; > The dependent QEMU patches are now merged on master targeting for 2.7 I actually started implementing this already. The precursor for this series is the JSON backing

Re: [libvirt] [PATCH RFC 1/5] Include criu support in autotools

On Thu, Jul 21, 2016 at 03:37:23PM +, Katerina Koukiou wrote: > Check for CRIU binary in autotools. This binary is needed > for checkpointing/restoring linux containers. > > Signed-off-by: Katerina Koukiou > --- > configure.ac | 8 > 1 file changed, 8

Re: [libvirt] [PATCH v3 2/3] qemu: add support for multiple gluster hosts/servers

On Fri, Jul 22, 2016 at 01:50:30PM +0530, Prasanna Kumar Kalever wrote: > This patch adds support for gluster specific JSON formatter functionality > > currently libvirt has the capability to parse only one host and convert that > into URI formatted string, with the help of this patch libvirt

[libvirt] [PATCH v3 1/3] storage: add gluster backend initialization support for multiple servers

This patch adds support for initialization of gluster backend with multiple servers which acts as gluster volfile servers for the gluster storage backend. This will help in achieving high availability of gluster backend connectivity via libgfapi i.e. when the first volfile server fails, then

[libvirt] [PATCH v3 0/3] qemu: add support for multiple gluster hosts/servers

These series of patches are rebased on latest master; The dependent QEMU patches are now merged on master targeting for 2.7 Prasanna Kumar Kalever (3): storage: add gluster backend initialization support for multiple servers qemu: add support for multiple gluster hosts/servers util:

[libvirt] [PATCH v3 2/3] qemu: add support for multiple gluster hosts/servers

This patch adds support for gluster specific JSON formatter functionality currently libvirt has the capability to parse only one host and convert that into URI formatted string, with the help of this patch libvirt will be able to parse multiple hosts from the domain xml and can convert that into

[libvirt] [PATCH v3 3/3] util: add backing store parser support for gluster protocol

This patch adds support for gluster specific JSON parser functionality This will help in parsing the backing store which uses JSON syntax and update the meta-data in the domain specific objects while taking snapshots which inturn helps in successful creation/updation of backing store information