[libvirt] [PATCH] libxl: add serial list support

Add support for multi serial devices, after this patch virsh can be used to connect different serial devices of running domains. E.g. vish # console --devname serial Signed-off-by: Bob Liu --- src/libxl/libxl_conf.c | 25 ++--- src/libxl/libxl_domain.c

[libvirt] [PATCH] libxl: allow libxl to calculate shadow mem requirements

Long, long ago before libxl_get_required_shadow_memory() was made publicly available, its code was copied to the libxl driver for calculating shadow memory requirements of HVM domains. Long ago, libxl_get_required_shadow_memory() was exported in libxl_utils.h and included in xen-devel packages

[libvirt] [PATCH 0/2] Rework qemuhotplugtest

This series requires another one: https://www.redhat.com/archives/libvir-list/2016-July/msg01205.html Tomasz Flendrich (2): qemuhotplugtest: handle xml files more precisely qemuhotplugtest: change indentation tests/qemuhotplugtest.c| 254 +++--

[libvirt] [PATCH 2/2] qemuhotplugtest: change indentation

--- tests/qemuhotplugtest.c | 96 - 1 file changed, 64 insertions(+), 32 deletions(-) diff --git a/tests/qemuhotplugtest.c b/tests/qemuhotplugtest.c index c6f055e..296994c 100644 --- a/tests/qemuhotplugtest.c +++ b/tests/qemuhotplugtest.c @@

[libvirt] [PATCH 1/2] qemuhotplugtest: handle xml files more precisely

In qemuhotplugtest.c, the way xml files with domain and device definitions were handled was very unintuitive. Because of this, creating new tests was troublesome. Sometimes, you were forced to create duplicates of files. I modified the tests to explicitly state the three xml files: the domain

Re: [libvirt] [PATCH 0/2] Add ability to set specific IOThread scheduler quota/period

On 25.07.2016 23:42, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1356937 > > > John Ferlan (2): > conf: Add IOThread quota and period scheduler/cputune defs > qemu: Add support to get/set IOThread period and quota cgroup values > > docs/formatdomain.html.in

Re: [libvirt] [PATCH python 2/2] event-test: Add node device lifecycle event tests

On 08/01/2016 08:16 AM, Marc Hartmayer wrote: > On Thu, Jul 28, 2016 at 02:14 PM +0200, Jovanka Gulicoska > wrote: >> --- >> examples/event-test.py | 16 >> 1 file changed, 16 insertions(+) >> >> diff --git a/examples/event-test.py

Re: [libvirt] [PATCH 0/2] Add ability to set specific IOThread scheduler quota/period

ping? Thanks - John On 07/25/2016 05:42 PM, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1356937 > > > John Ferlan (2): > conf: Add IOThread quota and period scheduler/cputune defs > qemu: Add support to get/set IOThread period and quota cgroup values > >

Re: [libvirt] [PATCH 0/5] Introduce NVDIMM support

On Mon, Aug 01, 2016 at 05:10:04PM +0200, Michal Privoznik wrote: > NVDIMM was introduced to qemu in v2.6.0-rc0~248^2~25. So it's > been a while since then. > > It's not the next big thing, but it is very interesting feature > enabling higher performance as reading/writing to the module (and >

[libvirt] [PATCH python] Post-release version bump to 2.2.0

--- Pushed as trivial setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.py b/setup.py index 647529b..240e796 100755 --- a/setup.py +++ b/setup.py @@ -307,7 +307,7 @@ class my_clean(clean): _c_modules, _py_modules = get_module_lists() setup(name =

[libvirt] [PATCH] remote: Fix indentation of the remote protocol structs check file

--- Pushed under the build-breaker rule. src/remote_protocol-structs | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/remote_protocol-structs b/src/remote_protocol-structs index 0e66fc5..24401d1 100644 --- a/src/remote_protocol-structs +++

Re: [libvirt] [PATCH] tests: Make schema test fail on XML schema errors

On Tue, Aug 02, 2016 at 09:19:07AM +0200, Peter Krempa wrote: Failure to parse the schema file would not trigger a test suite failure. In addition to making the test fail it's necessary to split up the parsing of the schema file into a separate test. This is necessary as the XML validator uses

Re: [libvirt] [PATCHv3 2b/9] qemu: Use qemuAliasFromDisk to generate drive alias

On Mon, Aug 01, 2016 at 08:29:10AM -0400, John Ferlan wrote: The qemuDomainSnapshotCreateSingleDiskActive open coded generating the disk drive alias. Let's use the common function. Signed-off-by: John Ferlan --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+),

Re: [libvirt] [PATCH v2 2/3] virsh: qemu-monitor-command: Don't print extra newline with --pretty

On Mon, Aug 01, 2016 at 01:34:56PM +0200, Peter Krempa wrote: The prettified JSON string already contains a newline so don't print another one. This allows to pipe the json output (in conjunction with the --quiet option) to files without having to truncate them afterwards. ---

Re: [libvirt] [PATCHv3 2c/9] qemu: Use qemuAliasFromDisk instead of qemuDeviceDriveHostAlias

On Mon, Aug 01, 2016 at 08:48:27AM -0400, John Ferlan wrote: Since we already have a function that will generate the drivestr from the alias, let's use it and remove the qemuDeviceDriveHostAlias. Move the QEMU_DRIVE_HOST_PREFIX definition into qemu_alias.h. Also alter qemuAliasFromDisk to use

Re: [libvirt] [PATCHv3 2a/9] qemu: Remove generation of drive alias from qcow passphrase backends

On Mon, Aug 01, 2016 at 08:23:37AM -0400, John Ferlan wrote: Rather than pass the disks[i]->info.alias to qemuMonitorSetDrivePassphrase and then generate the "drive-%s" alias from that, let's use qemuAliasFromDisk prior to the call to generate the drive alias and then pass that along thus

Re: [libvirt] Release of libvirt-2.1.0

On 2 Aug 2016, at 09:57, Daniel Veillard wrote: > Sorry I didn't push an rc2 on Friday, finishing my move, but not seeing any > issue raised by rc1, I though it was better to push the final release now and > free > up the tree for pending development. As a result 2.1.0 is

Re: [libvirt] [PATCH v2 0/3] libxl hooks

On Tue, 2016-08-02 at 08:56 -0400, John Ferlan wrote: > > On 07/28/2016 05:57 AM, Cédric Bosdonnat wrote: > > Hey there! > > > > Diffs to v1: > > * move the ret = 0 to the proper patch > > * fix typos as pointed by Joao > > * use ignore_value where needed > > > > Cédric Bosdonnat (3): > >

Re: [libvirt] [PATCH v2] qemu: set fake reboot flag only in acpi mode

On 07/16/2016 08:35 AM, John Ferlan wrote: > > > On 07/14/2016 07:08 AM, Nikolay Shirokovskiy wrote: >> First this fixes the same issue as e2b86f580. Only difference is >> that reboot is done via shutdown function with reboot semantics. >> >> Second 8be502fd tells us that we need to always set

Re: [libvirt] [PATCH glib] Delete the manually written python binding

Acked-by: Christophe Fergeau On Tue, Aug 02, 2016 at 02:34:33PM +0100, Daniel P. Berrange wrote: > The python binding only supports python2, only supports > 1 single API in libvirt-glib and has not even been enabled > in RPM builds since Fedora 15. Any distro these days

Re: [libvirt] [PATCH v2 2/3] libxl: fix segfault in libxlReconnectDomain

On 28.07.2016 11:57, Cédric Bosdonnat wrote: > In case of error, libxlReconnectDomain may call > virDomainObjListRemoveLocked. However it has no local reference on > the domain object, leading to segfault. Get a reference to the domain > object at the start of the function and release it at the

Re: [libvirt] [PATCH v2 3/3] libxl: add hooks support

On 28.07.2016 11:57, Cédric Bosdonnat wrote: > Introduce libxl hook and use it for start, prepare, started, > stop, stopped, migrate events. > --- > docs/hooks.html.in | 53 ++-- > src/libxl/libxl_domain.c| 74 >

Re: [libvirt] [PATCH v2 0/3] libxl hooks

On 28.07.2016 11:57, Cédric Bosdonnat wrote: > Hey there! > > Diffs to v1: > * move the ret = 0 to the proper patch > * fix typos as pointed by Joao > * use ignore_value where needed > > Cédric Bosdonnat (3): > libxl: add a flag to mark guests as tainted by a hook > libxl: fix segfault

[libvirt] [PATCH glib] Delete the manually written python binding

The python binding only supports python2, only supports 1 single API in libvirt-glib and has not even been enabled in RPM builds since Fedora 15. Any distro these days should have gobject introspection and pygobject available, so there's no compelling reason to continue to have the python binding

[libvirt] [PATCH 0/2] Fixes for broken build

Pushed under the build breaker rule John Ferlan (2): libxl: Fix broken build from libxlDomainCleanup libxl: Fix broken build attach/detach controller device src/libxl/libxl_domain.c | 2 +- src/libxl/libxl_driver.c | 4 2 files changed, 5 insertions(+), 1 deletion(-) -- 2.7.4 --

[libvirt] [PATCH 2/2] libxl: Fix broken build attach/detach controller device

Commit id '44304c6eb' added the API libxlDomainAttachControllerDevice inside a conditional LIBXL_HAVE_PVUSB, but called that function outside the conditional in libxlDomainAttachDeviceLive. Similarly, the API libxlDomainDetachControllerDevice was added inside a conditional LIBXL_HAVE_PVUSB, but

[libvirt] [PATCH 1/2] libxl: Fix broken build from libxlDomainCleanup

Commit id '7d3b2eb5' missed a closing parenthesis on the ignore_value macro, causing the failure Signed-off-by: John Ferlan --- src/libxl/libxl_domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c

Re: [libvirt] [PATCH V2 3/7] libxl: support usb controller hotplug

On 06/15/2016 02:00 AM, Chunyan Liu wrote: > Support USB controller hot-plug and hot-unplug. > > #virsh attach-device dom usbctrl.xml > #virsh detach-device dom usbctrl.xml > usbctrl.xml example: > > > Signed-off-by: Chunyan Liu > --- > src/libxl/libxl_driver.c | 144 >

Re: [libvirt] [PATCH 0/5] admin: Fix updating of the client limits

On 30/07/16 15:44, John Ferlan wrote: > > > On 07/20/2016 06:53 AM, Erik Skultety wrote: >> This series slightly refactors the code in virnetserver.c in order to resolve >> https://bugzilla.redhat.com/show_bug.cgi?id=1357776. The problem resides in >> updating of the client limits which even

Re: [libvirt] [PATCH v2 0/3] libxl hooks

On 07/28/2016 05:57 AM, Cédric Bosdonnat wrote: > Hey there! > > Diffs to v1: > * move the ret = 0 to the proper patch > * fix typos as pointed by Joao > * use ignore_value where needed > > Cédric Bosdonnat (3): > libxl: add a flag to mark guests as tainted by a hook > libxl: fix

Re: [libvirt] [PATCH V2 7/7] qemuDomainDeviceDefPostParse: add USB controller model check

On Wed, 2016-06-15 at 14:00 +0800, Chunyan Liu wrote: > To sync with virDomainControllerModelUSB, we add two models > in qemuControllerModelUSB 'qusb1' and 'qusb2', but those > models are not supported in qemu driver. So add check in > device post parse to report errors if 'qusb1' and 'qusb2' >

Re: [libvirt] [PATCH V2 1/7] extend usb controller model to support xen pvusb

On Wed, 2016-06-15 at 14:00 +0800, Chunyan Liu wrote: > According to libxl implementation, it supports pvusb > controller of version 1.1 and version 2.0, and it > supports two types of backend, 'pvusb' (dom0 backend) > and 'qusb' (qemu backend). But currently pvusb backend > is not checked in yet.

Re: [libvirt] [PATCH V2 5/7] xenconfig: add conversion of usb controller config to and from xml

On Wed, 2016-06-15 at 14:00 +0800, Chunyan Liu wrote: Missing a commit description, even a short one to say we're adding USB controller conversion to and from libxl's config files. > Signed-off-by: Chunyan Liu > --- > Changes: > drop pvusb1 and pvusb2 models > >

Re: [libvirt] [PATCH V2 6/7] xlconfigtest: add test for usb controller conversion

On Wed, 2016-06-15 at 14:00 +0800, Chunyan Liu wrote: > Signed-off-by: Chunyan Liu > --- > Changes: > drop pvusb items > > tests/xlconfigdata/test-usbctrl.cfg | 13 + > tests/xlconfigdata/test-usbctrl.xml | 31 +++ > tests/xlconfigtest.c

Re: [libvirt] [PATCH V2 4/7] libxl: check available controller and port when hotplugging USB device

On Wed, 2016-06-15 at 14:00 +0800, Chunyan Liu wrote: > When hotplug a USB device, check if there is available controller typos: When hotplugging a USB device, check if there is an available controller > and port, if not, automatically create a USB controller of version > 2.0 and 8 ports. > >

Re: [libvirt] [PATCH V2 2/7] libxl: support USB controllers in creation time

On Wed, 2016-06-15 at 14:00 +0800, Chunyan Liu wrote: > To support USB Controller in xen guest domains, just add > USB controller in domain config xml as following: > > > Signed-off-by: Chunyan Liu > --- > Changes: > drop pvusb1 and pvusb2 models > > src/libxl/libxl_conf.c |

Re: [libvirt] [PATCH V2 3/7] libxl: support usb controller hotplug

On Wed, 2016-06-15 at 14:00 +0800, Chunyan Liu wrote: > Support USB controller hot-plug and hot-unplug. > > #virsh attach-device dom usbctrl.xml > #virsh detach-device dom usbctrl.xml > usbctrl.xml example: > > > Signed-off-by: Chunyan Liu > --- > src/libxl/libxl_driver.c

Re: [libvirt] [PATCH] qemu: only report errno in trace message on failure

On 02.08.2016 12:48, Daniel P. Berrange wrote: > Avoid reporting a stale errno value when the syscall succeeds, > instead always pass 0. > > Signed-off-by: Daniel P. Berrange > --- > src/qemu/qemu_monitor.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >

[libvirt] [PATCH] Post-release version bump to 2.2.0

Signed-off-by: Michal Privoznik --- Pushed under trivial rule. configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 2c81c95..8d7d63e 100644 --- a/configure.ac +++ b/configure.ac @@ -16,7 +16,7 @@ dnl You should

[libvirt] [PATCH] qemu: only report errno in trace message on failure

Avoid reporting a stale errno value when the syscall succeeds, instead always pass 0. Signed-off-by: Daniel P. Berrange --- src/qemu/qemu_monitor.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c

Re: [libvirt] [PATCH 2/5] Introduce SMM feature

On 08/02/16 10:58, Michal Privoznik wrote: > On 01.08.2016 21:10, Laszlo Ersek wrote: >> On 08/01/16 19:05, Gerd Hoffmann wrote: >>> Hi, >>> If it does, then the host kernel should be 4.4 or later. (If we want to capture version numbers, then for each minor release, the latest patch

Re: [libvirt] [PATCH 2/5] Introduce SMM feature

On 01.08.2016 21:10, Laszlo Ersek wrote: > On 08/01/16 19:05, Gerd Hoffmann wrote: >> Hi, >> >>> If it does, then the host kernel should be 4.4 or later. (If we want to >>> capture version numbers, then for each minor release, the latest patch >>> level should be required: 4.4.16, 4.5.7, 4.6.5,

[libvirt] Release of libvirt-2.1.0

Sorry I didn't push an rc2 on Friday, finishing my move, but not seeing any issue raised by rc1, I though it was better to push the final release now and free up the tree for pending development. As a result 2.1.0 is tagged in git and I pushed signed tarbal and rpms to the usual place:

[libvirt] [PATCH] tests: Make schema test fail on XML schema errors

Failure to parse the schema file would not trigger a test suite failure. In addition to making the test fail it's necessary to split up the parsing of the schema file into a separate test. This is necessary as the XML validator uses libvirt errors to report problems parsing of the actual schema

Re: [libvirt] [PATCH] Fix unbalanced quotation marks in messages

On Tue, Aug 02, 2016 at 10:00:24AM +0300, Yuri Chornoivan wrote: Hi, Thanks for reviewing this minor patch that fixes some glitches found while translating libvirt. Best regards, Yuri From 0b3c80adeaa7f109074b54a154d68567ea1e7cc0 Mon Sep 17 00:00:00 2001 From: Yuri Chornoivan

[libvirt] [PATCH] Fix unbalanced quotation marks in messages

Hi, Thanks for reviewing this minor patch that fixes some glitches found while translating libvirt. Best regards, Yuri>From 0b3c80adeaa7f109074b54a154d68567ea1e7cc0 Mon Sep 17 00:00:00 2001 From: Yuri Chornoivan Date: Tue, 2 Aug 2016 09:48:37 +0300 Subject: [PATCH] Fix