Re: [libvirt] [PATCH] libxl: fix unused functions

Michal Privoznik wrote: > On 14.08.2016 04:37, Roman Bogorodskiy wrote: > > Commit eee7bd4e introduced two functions: libxlDiskPathToID and > > libxlDiskSectorSize. > > > > However, as they're used only by code under #ifdef __linux__, > > on non-Linux platforms it results in errors similar to

Re: [libvirt] [PATCH] tests: fix domaincapstest linking for libxl

Michal Privoznik wrote: > On 15.08.2016 01:25, Roman Bogorodskiy wrote: > > Commit 11567cf added some libxl tests into domaincapstest and > > added libvirt_driver_libxl_impl.la to domaincapstest_LDADD. > > > > This causes link fail on systems without GNU regex implementation: > > > >

Re: [libvirt] problem with rbd auth after switch to secret objects

On 08/15/2016 03:38 PM, John Ferlan wrote: > > On 08/10/2016 06:01 PM, Jim Fehlig wrote: >> Hi John, >> >> I've been having problems with rbd auth since the change to using qemu's >> secret >> objects. E.g. when hotplugging disk config >> >> >> >> >

Re: [libvirt] problem with rbd auth after switch to secret objects

On 08/10/2016 06:01 PM, Jim Fehlig wrote: > Hi John, > > I've been having problems with rbd auth since the change to using qemu's > secret > objects. E.g. when hotplugging disk config > > > >name="volumes/volume-f9c33a0a-5313-44fc-9624-c3b09ed21a57"> > > > > > >

[libvirt] [PATCH] vz: getting bus type for containers

We should query bus type for containers too, like for VM. In openstack we add volume disk like SCSI, so we can't hardcode SATA bus. --- src/vz/vz_sdk.c | 32 +--- 1 file changed, 13 insertions(+), 19 deletions(-) diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c index

[libvirt] [PATCH 1/2] conf: free the ports array of a USB hub

The array needs to be freed too, not just its members. https://bugzilla.redhat.com/show_bug.cgi?id=1366097 --- src/conf/domain_addr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/conf/domain_addr.c b/src/conf/domain_addr.c index c533edb..c9cddac 100644 --- a/src/conf/domain_addr.c +++

[libvirt] [PATCH 2/2] conf: report an error message for non-existing USB hubs

If any of the devices referenced a USB hub that does not exist, defining the domain would either fail with: error: An error occurred, but the cause is unknown (if only the last hub in the path is missing) or crash. Return a proper error instead of crashing.

[libvirt] [PATCH 0/2] USB address assignment fixes

Ján Tomko (2): conf: free the ports array of a USB hub conf: report an error message for non-existing USB hubs src/conf/domain_addr.c| 9 + .../qemuxml2argv-usb-hub-nonexistent.xml | 19 +++ tests/qemuxml2argvtest.c

Re: [libvirt] [PATCH 1/2] conf: Provide error on undefined iothreadsched entry

On 08/15/2016 11:07 AM, Peter Krempa wrote: > On Mon, Aug 15, 2016 at 10:55:33 -0400, John Ferlan wrote: >> When commit id '6dfb4507' refactored where the iothreadsched data was >> stored, the error message for when the virDomainIOThreadIDFind failed >> to find an iothreadid ("iothreadsched

Re: [libvirt] [PATCH 1/2] conf: Provide error on undefined iothreadsched entry

On Mon, Aug 15, 2016 at 10:55:33 -0400, John Ferlan wrote: > When commit id '6dfb4507' refactored where the iothreadsched data was > stored, the error message for when the virDomainIOThreadIDFind failed > to find an iothreadid ("iothreadsched attribute 'iothreads' uses > undefined iothread ids")

Re: [libvirt] [PATCH 2/2] conf: Provide error on undefined vcpusched entry

On Mon, Aug 15, 2016 at 10:55:34 -0400, John Ferlan wrote: > Commit id '9cc931f0b' removed the error message; however, it was reachable > via the virsh edit of a domain and attempting to add a vcpusched element > for "undefined" vcpu values. Without the error, the generic message > "An error

Re: [libvirt] [PATCH] lxc: don't try to reference NULL when mounting filesystems

On Mon, Aug 15, 2016 at 12:38:30 +0100, Daniel Berrange wrote: > > > > > > would lead to lxcContainerMountAllFS calling STRPREFIX > on a NLL pointer because it failed to check if fs->src->path > was non-NULL. This is a regression caused by > > commit

[libvirt] [PATCH 2/2] conf: Provide error on undefined vcpusched entry

Commit id '9cc931f0b' removed the error message; however, it was reachable via the virsh edit of a domain and attempting to add a vcpusched element for "undefined" vcpu values. Without the error, the generic message "An error occurred, but the cause is unknown" is displayed. This is similar to

[libvirt] [PATCH 0/2] Restore error messages for {iothread|vcpu}sched id out of range.

These patches will restore error messages indicating the vcpu or iothread range(s) for vcpusched or iothreadsched are invalid rather than just quietly ignoring. If someone for some unknown reason had hand edited their domain prior to starting libvirt, they'll at least get a message indicating that

[libvirt] [PATCH 1/2] conf: Provide error on undefined iothreadsched entry

When commit id '6dfb4507' refactored where the iothreadsched data was stored, the error message for when the virDomainIOThreadIDFind failed to find an iothreadid ("iothreadsched attribute 'iothreads' uses undefined iothread ids") was lost. This led to the possibility that someone would try to use

Re: [libvirt] [PATCH 1/3] Introduce node device update event as top level event

On 08/11/2016 11:15 AM, Jovanka Gulicoska wrote: > Also includes node device update event implementation for udev > backend. > Hmm, because of the way nodedev-event and event-test.c are implemented, looks like this throws some errors via the verify() and VIR_ENUM_IMPL sanity checking. So looks

Re: [libvirt] [PATCH] virsh: Fix core for cmdSecretGetValue

On 15.08.2016 14:02, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1366611 > > When commit id 'cb2e3e50' reworked the cmdSecretGetValue call to use > VIR_DISPOSE_STRING for base64, it neglected to initialize the base64 > value to NULL since the cleanup: label could be reached

[libvirt] [PATCH] virsh: Fix core for cmdSecretGetValue

https://bugzilla.redhat.com/show_bug.cgi?id=1366611 When commit id 'cb2e3e50' reworked the cmdSecretGetValue call to use VIR_DISPOSE_STRING for base64, it neglected to initialize the base64 value to NULL since the cleanup: label could be reached prior to the base64 value being set or not. This

Re: [libvirt] Drop support for old libvirt versions?

On Mon, 2016-08-15 at 09:39 +0100, Daniel P. Berrange wrote: > > My interpretation was that Andrea is suggesting two things: > >  > > 1) remove any code within libvirt that maintains compatibility when a > > contemporary libvirtd (or application using contemporary libvirt client > > library) is

Re: [libvirt] [PATCH] libxl: fix unused functions

On 14.08.2016 04:37, Roman Bogorodskiy wrote: > Commit eee7bd4e introduced two functions: libxlDiskPathToID and > libxlDiskSectorSize. > > However, as they're used only by code under #ifdef __linux__, > on non-Linux platforms it results in errors similar to this: > > CC

Re: [libvirt] [PATCH] tests: fix domaincapstest linking for libxl

On 15.08.2016 01:25, Roman Bogorodskiy wrote: > Commit 11567cf added some libxl tests into domaincapstest and > added libvirt_driver_libxl_impl.la to domaincapstest_LDADD. > > This causes link fail on systems without GNU regex implementation: > > gmake[2]: Entering directory

[libvirt] [PATCH] lxc: don't try to reference NULL when mounting filesystems

would lead to lxcContainerMountAllFS calling STRPREFIX on a NLL pointer because it failed to check if fs->src->path was non-NULL. This is a regression caused by commit da665fbd4858890fbb3bbf5da2a7b6ca37bb3220 Author: Olga Krishtal Date: Thu Jul

[libvirt] [PATCH 4/5] qemu_process: graphics: reserve port only if listen type is address or network

Signed-off-by: Pavel Hrdina --- src/qemu/qemu_process.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index d61f704..b3c6400 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -4009,6

[libvirt] [PATCH 5/5] qemu_process: graphics: setup listen types before ports are reserved/allocated

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1364843 Signed-off-by: Pavel Hrdina --- src/qemu/qemu_process.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index b3c6400..2b857bb

[libvirt] [PATCH 1/5] qemu_process: graphics: ref driver config only in function where it is used

Signed-off-by: Pavel Hrdina

[libvirt] [PATCH 3/5] qemu_process: graphics: extract for loop out of qemuProcessGraphicsReservePorts

Signed-off-by: Pavel Hrdina --- src/qemu/qemu_process.c | 58 + 1 file changed, 30 insertions(+), 28 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index f813bae..d61f704 100644 ---

[libvirt] [PATCH 2/5] qemu_process: graphics: extract port allocation into function

Signed-off-by: Pavel Hrdina --- src/qemu/qemu_process.c | 61 - 1 file changed, 40 insertions(+), 21 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 26aef5e..f813bae 100644 ---

[libvirt] [PATCH 0/5] graphics cleanup and bug fix

Pavel Hrdina (5): qemu_process: graphics: ref driver config only in function where it is used qemu_process: graphics: extract port allocation into function qemu_process: graphics: extract for loop out of qemuProcessGraphicsReservePorts qemu_process: graphics: reserve port only if

Re: [libvirt] [PATCHv3 04/11] Add virtio revision attribute to controllers

On 08/12/2016 04:59 PM, Ján Tomko wrote: On Fri, Aug 12, 2016 at 10:47:13AM +0200, Cornelia Huck wrote: On Thu, 11 Aug 2016 16:17:10 +0200 Ján Tomko wrote: On Thu, Aug 11, 2016 at 02:31:55PM +0100, Daniel P. Berrange wrote: >On Thu, Aug 11, 2016 at 03:25:53PM +0200, Ján

Re: [libvirt] Drop support for old libvirt versions?

On Sat, Aug 13, 2016 at 02:03:39PM -0400, Laine Stump wrote: > On 08/13/2016 09:24 AM, Martin Kletzander wrote: > > On Sat, Aug 13, 2016 at 10:16:03AM +0200, Michal Privoznik wrote: > > > On 12.08.2016 18:25, Andrea Bolognani wrote: > > > > > > > > > > > > > > I like the idea. I mean, the less