[libvirt] [PATCH 0/3] Fix qemu's tap device online status

These patches are all closely related, but each fixes a different problem, so they each should be in a separate patch. These all came out of Vasiliy's report that type='ethernet tap devices were all offline and didn't have their IP address or routes added. He sent a patch (which was an expanded

[libvirt] [PATCH 2/3] qemu: remove unnecessary setting of tap device online state

The linkstate setting of an is only meant to change the online status reported to the guest system by the emulated network device driver in qemu, but when support for auto-creating tap devices for was added in commit 9717d6, a chunk of code was also added to qemuDomainChangeNetLinkState() that

[libvirt] [PATCH 1/3] qemu: fix ethernet network type ip/route assign

From: Vasiliy Tolstov The call to virNetDevIPInfoAddToDev() that sets up tap device IP addresses and routes was somehow incorrectly placed in qemuInterfaceStopDevice() instead of qemuInterfaceStartDevice(). This fixes that error by moving the call to

[libvirt] [PATCH 3/3] qemu: set tap device online for type='ethernet'

When support for auto-creating tap devices was added to in commit 9717d6, the code assumed that virNetDevTapCreate() would honor the *_CREATE_IFUP flag that is supported by virNetDevTapCreateInBridgePort(). That isn't the case - the latter function performs several operations, and one of them is

[libvirt] [PATCH v2] tests: fix segfault in objecteventtest

Test 12 from objecteventtest (createXML add event) segaults on FreeBSD with bus error. At some point it calls testNodeDeviceDestroy() from the test driver. And it fails when it tries to unlock the device in the "out:" label of this function. Unlocking fails because the previous step was a call

[libvirt] [PATCH] Delete extra wrap after vol-reisize error

This patch is to delete the extra wrap "\n" after failed vol-reisize error, both "Failed to change size of volume to" and "Failed to change size of volume by". For error with wrap, there will be an extra wrap between two errors, such as: (1)# virsh vol-resize --pool default --vol vol-test 5M

Re: [libvirt] [PATCH] remove the dead code this patch is to remove the dead code Signed-off-by: JieWang <wangji...@huawei.com>

Thank you! This is my first time to commit patch, I'll do better next time. :) On 2016/8/22 20:46, Martin Kletzander wrote: > On Mon, Aug 22, 2016 at 01:30:08PM +0100, Richard W.M. Jones wrote: >> On Mon, Aug 22, 2016 at 08:17:37PM +0800, JieWang wrote: >>> Signed-off-by: JieWang

Re: [libvirt] [PATCH 0/7] fspool: backend directory

On Fri, Aug 19, 2016 at 06:03:28PM +0300, Olga Krishtal wrote: > Hi everyone, we would like to propose the first implementation of fspool > with directory backend. > > Filesystem pools is a facility to manage filesystems resources similar > to how storage pools manages volume resources.

Re: [libvirt] [PATCH 7/7] virsh: filesystem pools commands

On Fri, Aug 19, 2016 at 06:03:35PM +0300, Olga Krishtal wrote: > Signed-off-by: Nikolay Shirokovskiy > --- > po/POTFILES.in |2 + > tools/Makefile.am|4 + > tools/virsh-fspool.c | 1728 > ++ >

Re: [libvirt] [PATCH 6/7] fspool: default implementation of filesystem pools

On Fri, Aug 19, 2016 at 06:03:34PM +0300, Olga Krishtal wrote: > Implementation is backend base as in case of storage pools. > This patch adds directory backend which is nothing more > than managing directories inside another one as starting > point. > > Signed-off-by: Nikolay Shirokovskiy

Re: [libvirt] [PATCH 5/7] remote: filesystem pools driver implementation

On Fri, Aug 19, 2016 at 06:03:33PM +0300, Olga Krishtal wrote: > Signed-off-by: Nikolay Shirokovskiy > --- > daemon/libvirtd.c| 10 + > daemon/remote.c | 35 +++ > src/driver.h | 1 + > src/remote/remote_driver.c | 72

Re: [libvirt] [PATCH 4/7] fspools: acl support for filesystem pools

On Fri, Aug 19, 2016 at 06:03:32PM +0300, Olga Krishtal wrote: > Signed-off-by: Nikolay Shirokovskiy > --- > src/access/viraccessdriver.h | 12 > src/access/viraccessdrivernop.c| 19 ++ > src/access/viraccessdriverpolkit.c | 47 ++ >

Re: [libvirt] [PATCH 3/7] fspools: configuration and internal representation

On Fri, Aug 19, 2016 at 06:03:31PM +0300, Olga Krishtal wrote: > Signed-off-by: Nikolay Shirokovskiy > --- > po/POTFILES.in |1 + > src/Makefile.am |5 + > src/conf/fs_conf.c | 1624 > ++ >

Re: [libvirt] [PATCH 1/7] fspool: introduce filesystem pools API

On Fri, Aug 19, 2016 at 06:03:29PM +0300, Olga Krishtal wrote: > API follows the API of storage pools closely in parts which > do not differ for filesystems. > > Signed-off-by: Nikolay Shirokovskiy > --- > include/libvirt/libvirt-fs.h | 273 >

[libvirt] [PATCH] Avoid segfault in virt-aa-helper when handling read-only mount filesystems

This patch fixes a segfault in virt-aa-helper caused by attempting to modify a string literal in situ. It is triggered when a domain has a with type='mount' configured readonly, and libvirt is using the AppArmor security driver for sVirt confinement. --- Existing code seems to use

Re: [libvirt] [Qemu-devel] [RFC] libvirt vGPU QEMU integration

On Thu, Aug 18, 2016 at 09:41:59AM -0700, Neo Jia wrote: > Hi libvirt experts, > > I am starting this email thread to discuss the potential solution / proposal > of > integrating vGPU support into libvirt for QEMU. > > Some quick background, NVIDIA is implementing a VFIO based mediated device >

Re: [libvirt] [PATCH v3 24/24] qemu: hotplug: Add support for VCPU unplug

On Wed, Aug 24, 2016 at 21:33:21 +0200, Ján Tomko wrote: > On Wed, Aug 24, 2016 at 09:35:40AM -0400, Peter Krempa wrote: > >This patch removes the old vcpu unplug code completely and replaces it > >with the new code using device_del. The old hotplug code basically never > >worked with any recent

Re: [libvirt] [PATCH] storage_backend_rbd: fix typos

On 24.08.2016 09:25, Chen Hanxiao wrote: > From: Chen Hanxiao > > s/failed/failed to > > Signed-off-by: Chen Hanxiao > --- > src/storage/storage_backend_rbd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [libvirt] [PATCH v3 24/24] qemu: hotplug: Add support for VCPU unplug

On Wed, Aug 24, 2016 at 09:35:40AM -0400, Peter Krempa wrote: This patch removes the old vcpu unplug code completely and replaces it with the new code using device_del. The old hotplug code basically never worked with any recent qemu and thus is useless. As the new code is using device_del all

Re: [libvirt] [PATCH v3 23/24] qemu: hotplug: Allow marking unplugged devices by alias

On Wed, Aug 24, 2016 at 09:35:39AM -0400, Peter Krempa wrote: Add a overlay function that takes the alias directly rather than extracting it from a device info. --- src/qemu/qemu_hotplug.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) ACK Jan signature.asc

Re: [libvirt] [PATCH v3 22/24] qemu: Use modern vcpu hotplug approach if possible

On Wed, Aug 24, 2016 at 09:35:38AM -0400, Peter Krempa wrote: To allow unplugging the vcpus, hotplugging of vcpus on platforms which require to plug multiple logical vcpus at once or plugging them in an arbitrary order it's necessary to use the new device_add interface for vcpu hotplug. This

Re: [libvirt] [PATCH] qemu: fix ethernet network type ip/route assign

On 08/24/2016 12:09 PM, Vasiliy Tolstov wrote: IP and routes assigenment incorrectly placed on device stop. This is fixing it, also change device state according to xml. Note that as i know in linux routes can't be created on device that does not up. Signed-off-by: Vasiliy Tolstov

Re: [libvirt] Plans for next release

On 08/24/2016 11:08 AM, Michal Privoznik wrote: On 24.08.2016 11:28, Daniel Veillard wrote: So if we want a 2.2.0 release around Sep 1st, I suggest entering freeze this Friday probably at the end of the day (european time), then push the rc2 next Tuesday for a release on Thursday, hope

Re: [libvirt] [PATCH 0/3] virsh: Option completers and small improvements/fixes for autocomplete

On Wed, Aug 24, 2016 at 9:54 PM, Michal Privoznik wrote: > On 20.08.2016 07:52, Nishith Shah wrote: > > This series introduces option completers and adds some minor improvements > > and fixes(not bugs per se, just better/sane behavior) in > vshReadlineParse. > > > > The

Re: [libvirt] Plans for next release

On Wed, Aug 24, 2016 at 05:08:17PM +0200, Michal Privoznik wrote: > On 24.08.2016 11:28, Daniel Veillard wrote: > > So if we want a 2.2.0 release around Sep 1st, I suggest entering freeze > > this Friday > > probably at the end of the day (european time), then push the rc2 next > > Tuesday for

Re: [libvirt] [PATCH 3/3] virsh: use vshError consistently after virBufferError checks

I guess you meant "If virBufferError() reports an error, then vshError() is needed to report the error situation instead of a simple vshPrint()." :-) Had me confused for a bit there. Nishith On Wed, Aug 24, 2016 at 7:44 PM, Pino Toscano wrote: > If virBufferError()

Re: [libvirt] [PATCH] tests: fix segault in objecteventtest

Michal Privoznik wrote: > On 24.08.2016 12:55, Roman Bogorodskiy wrote: > > Test 12 from objecteventtest (createXML add event) segaults on FreeBSD > > with bus error. > > > > At some point it calls testNodeDeviceDestroy() from the test driver. And > > it fails when it tries to unlock the

Re: [libvirt] [PATCH] tests: fix segault in objecteventtest

On 24.08.2016 12:55, Roman Bogorodskiy wrote: > Test 12 from objecteventtest (createXML add event) segaults on FreeBSD > with bus error. > > At some point it calls testNodeDeviceDestroy() from the test driver. And > it fails when it tries to unlock the device in the "out:" label of this >

Re: [libvirt] [PATCH 0/3] virsh: Option completers and small improvements/fixes for autocomplete

On 20.08.2016 07:52, Nishith Shah wrote: > This series introduces option completers and adds some minor improvements > and fixes(not bugs per se, just better/sane behavior) in vshReadlineParse. > > The first patch introduces the usage of option completers to auto-complete > arguments for a

Re: [libvirt] [PATCH] Fix remote_protocol-structs after recent commit

On Wed, Aug 24, 2016 at 19:11:21 +0300, Maxim Nestratov wrote: > 23-Aug-16 22:49, Peter Krempa пишет: > > > Commit 0adc9d26ae0cfbb4aa227e89424f3d48bb977da0 broke the build since > > remote_protocol-structs was not updated. > > --- > > > > Pushed under the build-breaker rule. > > Oops. Sorry.

Re: [libvirt] [PATCH v3 03/24] qemu: caps: Add capability for query-hotpluggable-cpus command

On Wed, 2016-08-24 at 16:05 +0200, Ján Tomko wrote: > On Wed, Aug 24, 2016 at 09:35:19AM -0400, Peter Krempa wrote: > >  > > --- > >  > > Notes: > >v2: > >- already ACKed > >  > > src/qemu/qemu_capabilities.c | 2 ++ > > src/qemu/qemu_capabilities.h |

Re: [libvirt] [PATCH] Fix remote_protocol-structs after recent commit

23-Aug-16 22:49, Peter Krempa пишет: Commit 0adc9d26ae0cfbb4aa227e89424f3d48bb977da0 broke the build since remote_protocol-structs was not updated. --- Pushed under the build-breaker rule. Oops. Sorry. I wonder how I missed this... Maxim -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH 0/3] Misc virsh improvements

On 24.08.2016 16:14, Pino Toscano wrote: > Hi, > > this series provides small improvements for virsh. > > The patches are sent as single series as some of the changes would > conflict if sent as different patches. > > Thanks, > > > Pino Toscano (3): > virsh: respect -q/--quiet more >

Re: [libvirt] [PATCH v3 21/24] qemu: command: Add support for sparse vcpu topologies

On Wed, Aug 24, 2016 at 09:35:37AM -0400, Peter Krempa wrote: Add support for using the new approach to hotplug vcpus using device_add during startup of qemu to allow sparse vcpu topologies. There are a few limitations imposed by qemu on the supported configuration: - vcpu0 needs to be always

Re: [libvirt] [PATCH v3 20/24] qemu: process: Copy final vcpu order information into the vcpu definition

On Wed, Aug 24, 2016 at 09:35:36AM -0400, Peter Krempa wrote: The vcpu order information is extracted only for hotpluggable entities, while vcpu definitions belonging to the same hotpluggable entity need to all share the order information. We also can't overwrite it right away in the vcpu info

Re: [libvirt] [PATCH v3 17/24] conf: Add XML for individual vCPU hotplug

On Wed, Aug 24, 2016 at 09:35:33AM -0400, Peter Krempa wrote: Individual vCPU hotplug requires us to track the state of any vCPU. To allow this add the following XML: ... 3 ... The 'enabled' attribute allows to control the state of the vcpu. 'hotpluggable' controls whether

Re: [libvirt] Plans for next release

On 24.08.2016 11:28, Daniel Veillard wrote: > So if we want a 2.2.0 release around Sep 1st, I suggest entering freeze > this Friday > probably at the end of the day (european time), then push the rc2 next > Tuesday for a > release on Thursday, > > hope this works for everybody, Nearly

Re: [libvirt] [PATCH v3 16/24] util: Extract and rename qemuDomainDelCgroupForThread to virCgroupDelThread

On Wed, Aug 24, 2016 at 09:35:32AM -0400, Peter Krempa wrote: --- src/libvirt_private.syms | 1 + src/qemu/qemu_driver.c | 27 +++ src/util/vircgroup.c | 20 src/util/vircgroup.h | 4 4 files changed, 28 insertions(+), 24 deletions(-)

Re: [libvirt] [PATCH v3 14/24] qemu: domain: Extract cpu-hotplug related data

On Wed, Aug 24, 2016 at 09:35:30AM -0400, Peter Krempa wrote: Now that the monitor code gathers all the data we can extract it to relevant places either in the definition or the private data of a vcpu. As only thread id is broken for TCG guests we may extract the rest of the data and just skip

Re: [libvirt] [PATCH v3 10/24] tests: cpu-hotplug: Add data for x86 hotplug with 11+ vcpus

On Wed, Aug 24, 2016 at 09:35:26AM -0400, Peter Krempa wrote: During review it was reported that adding at least 11 vcpus creates a collision of prefixes in the monitor matching algorithm. Add a test case to verify that the problem won't happen. --- .../qemumonitorjson-cpuinfo-x86-full-cpus.json

[libvirt] [PATCH 2/3] virsh: avoid i18n puzzle

Use the full versions of the message, instead of composing a base message with what was updated; the change makes the messages properly translatable, since different parts of a sentence might need different declensions for example. --- tools/virsh-network.c | 18 ++ 1 file

Re: [libvirt] [libvirt-python][PATCH] PyArg_ParseTuple: Provide correct function names

On Wed, Aug 24, 2016 at 12:35:31PM +0200, Michal Privoznik wrote: > Currently, we parse arguments passed to a python function by > calling PyArg_ParseTuple(). It takes what's called format string > which is something like printf's format string (not that %s would > work for PyArg_ParseTuple).

[libvirt] [PATCH 0/3] Misc virsh improvements

Hi, this series provides small improvements for virsh. The patches are sent as single series as some of the changes would conflict if sent as different patches. Thanks, Pino Toscano (3): virsh: respect -q/--quiet more virsh: avoid i18n puzzle virsh: use vshError consistently after

[libvirt] [PATCH 1/3] virsh: respect -q/--quiet more

Turn various vshPrint() informative messages into vshPrintExtra(), so they are not printed when requesting the quiet mode; neither XML/info outputs nor the results of commands are affected. Also change the expected outputs of the virsh-undefine test, since virsh is invoked in quiet mode there.

[libvirt] [PATCH 3/3] virsh: use vshError consistently after virBufferError checks

If virBufferError() reports an error, then vshError() is needed to report the error situation instead of a simple vshError(). --- tools/virsh-domain.c | 12 ++-- tools/virsh-pool.c | 2 +- tools/virsh-volume.c | 2 +- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git

Re: [libvirt] [PATCH 00/41] Enhance guest CPU configuration code

On Fri, Aug 12, 2016 at 15:32:54 +0200, Jiri Denemark wrote: > This patch series does several things: > > - fixes tests to avoid relying on bugs in our code > - adds support for advertising supported CPU modes and models in domain > capabilities > - starts adding better and higher level APIs to

Re: [libvirt] [PATCH v3 03/24] qemu: caps: Add capability for query-hotpluggable-cpus command

On Wed, Aug 24, 2016 at 09:35:19AM -0400, Peter Krempa wrote: --- Notes: v2: - already ACKed src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml | 1 + 3 files changed, 4

Re: [libvirt] [PATCH v3 02/24] qemu: monitor: Return struct from qemuMonitor(Text|Json)QueryCPUs

On Wed, Aug 24, 2016 at 09:35:18AM -0400, Peter Krempa wrote: Prepare to extract more data by returning a array of structs rather than *an array just an array of thread ids. Additionally report fatal errors separately from qemu not being able to produce data. --- Notes: v3: - fixed

Re: [libvirt] [PATCH v3 01/24] qemu: monitor: Return structures from qemuMonitorGetCPUInfo

On Wed, Aug 24, 2016 at 09:35:17AM -0400, Peter Krempa wrote: The function will gradually add more returned data. Return a struct for every vCPU containing the data. --- Notes: v2: - already ACKed src/qemu/qemu_domain.c | 25 +- src/qemu/qemu_monitor.c | 57

Re: [libvirt] [PATCH v2 08/23] qemu: monitor: Add algorithm for combining query-(hotpluggable-)-cpus data

On Tue, Aug 23, 2016 at 17:54:51 +0530, Shivaprasad G Bhat wrote: > On 08/19/2016 08:08 PM, Peter Krempa wrote: [...] > > +/* match entries from query cpus to the output array taking into > > account > > + * multi-vcpu objects */ > > +for (j = 0; j < ncpuentries; j++) { > > +

[libvirt] [PATCH v3 24/24] qemu: hotplug: Add support for VCPU unplug

This patch removes the old vcpu unplug code completely and replaces it with the new code using device_del. The old hotplug code basically never worked with any recent qemu and thus is useless. As the new code is using device_del all the implications of using it are present. Contrary to the device

[libvirt] [PATCH v3 21/24] qemu: command: Add support for sparse vcpu topologies

Add support for using the new approach to hotplug vcpus using device_add during startup of qemu to allow sparse vcpu topologies. There are a few limitations imposed by qemu on the supported configuration: - vcpu0 needs to be always present and not hotpluggable - non-hotpluggable cpus need to be

[libvirt] [PATCH v3 23/24] qemu: hotplug: Allow marking unplugged devices by alias

Add a overlay function that takes the alias directly rather than extracting it from a device info. --- src/qemu/qemu_hotplug.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 00e4a75..31ef22f 100644 ---

[libvirt] [PATCH v3 20/24] qemu: process: Copy final vcpu order information into the vcpu definition

The vcpu order information is extracted only for hotpluggable entities, while vcpu definitions belonging to the same hotpluggable entity need to all share the order information. We also can't overwrite it right away in the vcpu info detection code as the order is necessary to add the hotpluggable

[libvirt] [PATCH v3 12/24] tests: cpu-hotplug: Add data for ppc64 out-of-order hotplug

Test the algorithm that extracts the order in which the vcpu entries were plugged in on a sample of data created by plugging in vcpus arbitrarily. --- Notes: v2: - already acked ...mumonitorjson-cpuinfo-ppc64-hotplug-4-cpus.json | 221 +

[libvirt] [PATCH v3 22/24] qemu: Use modern vcpu hotplug approach if possible

To allow unplugging the vcpus, hotplugging of vcpus on platforms which require to plug multiple logical vcpus at once or plugging them in an arbitrary order it's necessary to use the new device_add interface for vcpu hotplug. This patch adds support for the device_add interface using the old

Re: [libvirt] [PATCH] qemu: fix ethernet network type ip/route assign

2016-08-24 19:09 GMT+03:00 Vasiliy Tolstov : > IP and routes assigenment incorrectly placed on device stop. > This is fixing it, also change device state according to xml. > Note that as i know in linux routes can't be created on device that does > not up. Forget please,

[libvirt] [PATCH v3 17/24] conf: Add XML for individual vCPU hotplug

Individual vCPU hotplug requires us to track the state of any vCPU. To allow this add the following XML: ... 3 ... The 'enabled' attribute allows to control the state of the vcpu. 'hotpluggable' controls whether given vcpu can be hotplugged and 'order' allows to

[libvirt] [PATCH v3 18/24] qemu: migration: Prepare for non-contiguous vcpu configurations

Introduce a new migration cookie flag that will be used for any configurations that are not compatible with libvirt that would not support the specific vcpu hotplug approach. This will make sure that old libvirt does not fail to reproduce the configuration correctly. --- Notes: v2: -

[libvirt] [PATCH v3 10/24] tests: cpu-hotplug: Add data for x86 hotplug with 11+ vcpus

During review it was reported that adding at least 11 vcpus creates a collision of prefixes in the monitor matching algorithm. Add a test case to verify that the problem won't happen. --- .../qemumonitorjson-cpuinfo-x86-full-cpus.json | 104 +++

[libvirt] [PATCH v3 19/24] qemu: command: Add helper to convert vcpu definition to JSON props

For use on the monitor we need to format certain parts of the vcpu private definition into a JSON object. Add a helper. --- Notes: v2: - already ACKed src/qemu/qemu_command.c | 30 ++ src/qemu/qemu_command.h | 3 +++ 2 files changed, 33 insertions(+) diff

[libvirt] [PATCH v3 11/24] tests: cpu-hotplug: Add data for ppc64 platform including hotplug

Power 8 platform's basic hotpluggable unit is a core rather than a thread for x86_64 family. This introduces most of the complexity of the matching code and thus needs to be tested. The test data contain data captured from in-order cpu hotplug and unplug operations. --- Notes: v2: -

[libvirt] [PATCH v3 15/24] qemu: domain: Prepare for VCPUs vanishing while libvirt is not running

Similarly to devices the guest may allow unplug of the VCPU if libvirt is down. To avoid problems, refresh the vcpu state on reconnect. Don't mess with the vcpu state otherwise. --- Notes: v2: already ACKed src/qemu/qemu_domain.c | 9 - src/qemu/qemu_domain.h | 3 ++-

[libvirt] [PATCH v3 16/24] util: Extract and rename qemuDomainDelCgroupForThread to virCgroupDelThread

--- src/libvirt_private.syms | 1 + src/qemu/qemu_driver.c | 27 +++ src/util/vircgroup.c | 20 src/util/vircgroup.h | 4 4 files changed, 28 insertions(+), 24 deletions(-) diff --git a/src/libvirt_private.syms

[libvirt] [PATCH v3 14/24] qemu: domain: Extract cpu-hotplug related data

Now that the monitor code gathers all the data we can extract it to relevant places either in the definition or the private data of a vcpu. As only thread id is broken for TCG guests we may extract the rest of the data and just skip assigning of the thread id. In case where qemu would allow cpu

[libvirt] [PATCH v3 08/24] qemu: monitor: Add algorithm for combining query-(hotpluggable-)-cpus data

For hotplug purposes it's necessary to retrieve data using query-hotpluggable-cpus while the old query-cpus API report thread IDs and order of hotplug. This patch adds code that merges the data using a rather non-trivial algorithm and fills the data to the qemuMonitorCPUInfo structure for adding

[libvirt] [PATCH v3 01/24] qemu: monitor: Return structures from qemuMonitorGetCPUInfo

The function will gradually add more returned data. Return a struct for every vCPU containing the data. --- Notes: v2: - already ACKed src/qemu/qemu_domain.c | 25 +- src/qemu/qemu_monitor.c | 57 +++--

[libvirt] [PATCH v3 00/24] qemu: Add support for new vcpu hotplug and unplug

v3 fixes stuff pointed out in reviews for v2: - more than 10 vcpus problem (patch 8 and new patch 10 adding tests) - few typos and other problems and stuff found while testing: - ordering function for qsort being broken (patch 21) You can fetch the changes at: git fetch

[libvirt] [PATCH v3 09/24] tests: Add test infrastructure for qemuMonitorGetCPUInfo

As the combination algorithm is rather complex and ugly it's necessary to make sure it works properly. Add test suite infrastructure for testing it along with a basic test based on x86_64 platform. --- Notes: v2: - shortened very long line - already ACKed

[libvirt] [PATCH v3 04/24] qemu: Forbid config when topology based cpu count doesn't match the config

As of qemu commit: commit a32ef3bfc12c8d0588f43f74dcc5280885bbdb30 Author: Thomas Huth Date: Wed Jul 22 15:59:50 2015 +0200 vl: Add another sanity check to smp_parse() function v2.4.0-952-ga32ef3b configuration where the maximum CPU count doesn't match the topology is

[libvirt] [PATCH v3 06/24] qemu: monitor: Extract QOM path from query-cpus reply

To allow matching up the data returned by query-cpus to entries in the query-hotpluggable-cpus reply for CPU hotplug it's necessary to extract the QOM path as it's the only link between the two. --- Notes: v2: - fixed commit message - already ACKed src/qemu/qemu_monitor.c | 7

[libvirt] [PATCH v3 05/24] qemu: capabilities: Extract availability of new cpu hotplug for machine types

QEMU reports whether 'query-hotpluggable-cpus' is supported for a given machine type. Extract and cache the information using the capability cache. When copying the capabilities for a new start of qemu, mask out the presence of QEMU_CAPS_QUERY_HOTPLUGGABLE_CPUS if the machine type doesn't support

[libvirt] [PATCH v3 02/24] qemu: monitor: Return struct from qemuMonitor(Text|Json)QueryCPUs

Prepare to extract more data by returning a array of structs rather than just an array of thread ids. Additionally report fatal errors separately from qemu not being able to produce data. --- Notes: v3: - fixed uninitialized variable in tests v2: - initialized ncpus in

[libvirt] [PATCH v3 07/24] qemu: monitor: Add support for calling query-hotpluggable-cpus

Add support for retrieving information regarding hotpluggable cpu units supported by qemu. Data returned by the command carries information needed to figure out the granularity of hotplug, the necessary cpu type name and the topology information. Note that qemu doesn't specify any particular

[libvirt] [PATCH v3 13/24] tests: cpu-hotplug: Add data for ppc64 without threads enabled

The reported data is unusual so add it to the test suite. --- Notes: v2: - already ACKed ...umonitorjson-cpuinfo-ppc64-no-threads-cpus.json | 77 + ...nitorjson-cpuinfo-ppc64-no-threads-hotplug.json | 125 +

[libvirt] [PATCH v3 03/24] qemu: caps: Add capability for query-hotpluggable-cpus command

--- Notes: v2: - already ACKed src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml | 1 + 3 files changed, 4 insertions(+) diff --git a/src/qemu/qemu_capabilities.c

[libvirt] [PATCH v2] qemu: fix ip/route assigning on ethernet device

After investigation, i found that ips and routes incorrectly assigning on device deletion. Also after libvirt create tap device it does not up. Vasiliy Tolstov (1): qemu: fix ethernet network type ip/route assign src/qemu/qemu_interface.c | 23 ++- 1 file changed, 18

[libvirt] [PATCH] qemu: fix ethernet network type ip/route assign

IP and routes assigenment incorrectly placed on device stop. This is fixing it, also change device state according to xml. Note that as i know in linux routes can't be created on device that does not up. Signed-off-by: Vasiliy Tolstov --- src/qemu/qemu_interface.c | 23

Re: [libvirt] [PATCH] qemu: fix ethernet network type ip/route assign

On Wed, Aug 24, 2016 at 06:40:59PM +0300, Vasiliy Tolstov wrote: > IP and routes assigenment incorrectly placed on device stop. > This is fixing it, also change device state according to xml. > Note that as i know in linux routes can't be created on device that does > not up. > > Signed-off-by:

[libvirt] [PATCH] qemu: fix ip/route assigning on ethernet device

After investigation, i found that ips and routes incorrectly assigning on device deletion. Also after libvirt create tap device it does not up. Vasiliy Tolstov (1): qemu: fix ethernet network type ip/route assign src/qemu/qemu_interface.c | 23 ++- 1 file changed, 18

[libvirt] [PATCH] qemu: fix ethernet network type ip/route assign

IP and routes assigenment incorrectly placed on device stop. This is fixing it, also change device state according to xml. Note that as i know in linux routes can't be created on device that does not up. Signed-off-by: Vasiliy Tolstov --- src/qemu/qemu_interface.c | 23

[libvirt] [PATCH] tests: fix segault in objecteventtest

Test 12 from objecteventtest (createXML add event) segaults on FreeBSD with bus error. At some point it calls testNodeDeviceDestroy() from the test driver. And it fails when it tries to unlock the device in the "out:" label of this function. Unlocking fails because the previous step was a call

Re: [libvirt] libvirt-python virNodeGetInfo returns None

On 23.08.2016 13:03, Christian Loehle wrote: > I'm trying to use virt-manager with a custom libvirt hypervisor driver. Wow, custom hypervisor driver? Sounds interesting - for what hypervisor it is? > My current problem is that virt-manager closes the connection because > virNodeGetInfo(the

[libvirt] [libvirt-python][PATCH] PyArg_ParseTuple: Provide correct function names

Currently, we parse arguments passed to a python function by calling PyArg_ParseTuple(). It takes what's called format string which is something like printf's format string (not that %s would work for PyArg_ParseTuple). Okay, maybe that wasn't the best example. Anyway, at the end of the format

[libvirt] Plans for next release

So if we want a 2.2.0 release around Sep 1st, I suggest entering freeze this Friday probably at the end of the day (european time), then push the rc2 next Tuesday for a release on Thursday, hope this works for everybody, Daniel -- Daniel Veillard | Open Source and Standards, Red Hat

[libvirt] [PATCH] storage_backend_rbd: fix typos

From: Chen Hanxiao s/failed/failed to Signed-off-by: Chen Hanxiao --- src/storage/storage_backend_rbd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/storage/storage_backend_rbd.c b/src/storage/storage_backend_rbd.c

Re: [libvirt] Does libvirt live migration have error handling on port bind failure

On Wed, Aug 24, 2016 at 2:37 AM, Michal Privoznik wrote: > On 23.08.2016 08:57, Prasanna Kalever wrote: >> On Tue, Aug 23, 2016 at 4:10 AM, Michal Privoznik >> wrote: >>> On 17.08.2016 11:02, Prasanna Kalever wrote: [ oops! apologies, my previous