Re: [libvirt] [PATCH 6/6] conf: Fix build with picky GCC

On Thu, Aug 25, 2016 at 18:42:50 -0400, Peter Krempa wrote: > ../../src/conf/domain_conf.c:4425:21: error: potential null pointer > dereference [-Werror=null-dereference] > switch (vcpu->hotpluggable) { > ^~ > --- > src/conf/domain_conf.c | 4 > 1 fi

Re: [libvirt] [PATCH 2/6] qemu: driver: Fix qemuDomainHelperGetVcpus for sparse vcpu topologies

On Thu, Aug 25, 2016 at 18:42:46 -0400, Peter Krempa wrote: > ce43cca0e refactored the helper to prepare it for sparse topologies but > forgot to fix the iterator used to fill the structures. This would > result into a weirdly sparse populated array and possible out of bounds > access and crash onc

Re: [libvirt] [PATCH 3/6] doc: clarify documentation for vcpu order

On Thu, Aug 25, 2016 at 18:42:47 -0400, Peter Krempa wrote: > Make it clear that vcpu order is valid for online vcpus only and state > that it has to be specified for all vcpus or not provided at all. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1370043 > --- > docs/formatdomain.html

Re: [libvirt] [PATCH 1/6] virsh: vcpuinfo: Report vcpu number from the structure rather than it's position

On Thu, Aug 25, 2016 at 18:42:45 -0400, Peter Krempa wrote: > virVcpuInfo contains the vcpu number that the data refers to. Report > what's returned by the daemon rather than the sequence number as with > sparse vcpu topologies they won't match. > --- > tools/virsh-domain.c | 3 ++- > 1 file chang

Re: [libvirt] [PATCH 2/3] qemu: remove unnecessary setting of tap device online state

On 08/25/2016 04:55 AM, Sascha Silbe wrote: Dear Laine, Laine Stump writes: The linkstate setting of an is only meant to change the online status reported to the guest system by the emulated network device driver in qemu, but when support for auto-creating tap devices for was added in commi

Re: [libvirt] [PATCH 0/3] Fix qemu's tap device online status

On 08/25/2016 01:57 AM, Laine Stump wrote: These patches are all closely related, but each fixes a different problem, so they each should be in a separate patch. These all came out of Vasiliy's report that type='ethernet tap devices were all offline and didn't have their IP address or routes add

[libvirt] [PATCH 6/6] conf: Fix build with picky GCC

../../src/conf/domain_conf.c:4425:21: error: potential null pointer dereference [-Werror=null-dereference] switch (vcpu->hotpluggable) { ^~ --- src/conf/domain_conf.c | 4 1 file changed, 4 insertions(+) diff --git a/src/conf/domain_conf.c b/src/con

[libvirt] [PATCH 5/6] qemu: driver: Validate configuration when setting maximum vcpu count

Setting vcpu count when cpu topology is specified may result into an invalid configuration. Since the topology can't be modified, reject the setting if it doesn't match the requested topology. This will allow fixing the topology in case it was broken. Partially fixes: https://bugzilla.redhat.com/s

[libvirt] [PATCH 4/6] conf: Don't validate vcpu count in XML parser

Validating the vcpu count is more intricate and doing it in the XML parser will make previously valid configs (with older qemus) vanish. Now that we have the validation callbacks we can do it in a more appropriate place. This basically reverts commit b54de0830a. Partially resolves: https://bugzi

[libvirt] [PATCH 3/6] doc: clarify documentation for vcpu order

Make it clear that vcpu order is valid for online vcpus only and state that it has to be specified for all vcpus or not provided at all. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1370043 --- docs/formatdomain.html.in | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff -

[libvirt] [PATCH 0/6] Fix a few issues introduced by adding vcpu hotplug

Peter Krempa (6): virsh: vcpuinfo: Report vcpu number from the structure rather than it's position qemu: driver: Fix qemuDomainHelperGetVcpus for sparse vcpu topologies doc: clarify documentation for vcpu order conf: Don't validate vcpu count in XML parser qemu: driver: Validate confi

[libvirt] [PATCH 1/6] virsh: vcpuinfo: Report vcpu number from the structure rather than it's position

virVcpuInfo contains the vcpu number that the data refers to. Report what's returned by the daemon rather than the sequence number as with sparse vcpu topologies they won't match. --- tools/virsh-domain.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/virsh-domain.c b/

[libvirt] [PATCH 2/6] qemu: driver: Fix qemuDomainHelperGetVcpus for sparse vcpu topologies

ce43cca0e refactored the helper to prepare it for sparse topologies but forgot to fix the iterator used to fill the structures. This would result into a weirdly sparse populated array and possible out of bounds access and crash once sparse vcpu topologies were allowed. Resolves: https://bugzilla.r

Re: [libvirt] [PATCH 3/3] qemu: set tap device online for type='ethernet'

2016-08-25 8:58 GMT+03:00 Laine Stump : > When support for auto-creating tap devices was added to type='ethernet'> in commit 9717d6, the code assumed that > virNetDevTapCreate() would honor the *_CREATE_IFUP flag that is > supported by virNetDevTapCreateInBridgePort(). That isn't the case - > the

Re: [libvirt] [PATCH 2/3] qemu: remove unnecessary setting of tap device online state

2016-08-25 8:57 GMT+03:00 Laine Stump : > The linkstate setting of an is only meant to change the > online status reported to the guest system by the emulated network > device driver in qemu, but when support for auto-creating tap devices > for was added in commit 9717d6, a chunk of > code was al

Re: [libvirt] [PATCH 2/3] qemu: remove unnecessary setting of tap device online state

On 08/25/2016 03:49 PM, Vasiliy Tolstov wrote: 25 Авг 2016 г. 21:38 пользователь "Laine Stump" > написал: > > On 08/25/2016 02:19 PM, Vasiliy Tolstov wrote: >> >> 25 Авг 2016 г. 19:18 пользователь "Laine Stump" > написал: >> > >> > On 08/25/2016

Re: [libvirt] [PATCH 2/3] qemu: remove unnecessary setting of tap device online state

25 Авг 2016 г. 21:38 пользователь "Laine Stump" написал: > > On 08/25/2016 02:19 PM, Vasiliy Tolstov wrote: >> >> 25 Авг 2016 г. 19:18 пользователь "Laine Stump" написал: >> > >> > On 08/25/2016 05:42 AM, Vasiliy Tolstov wrote: >> >> >> >> 25 Авг 2016 г. 12:34 пользователь Vasiliy Tolstov написа

Re: [libvirt] [PATCH 2/3] qemu: remove unnecessary setting of tap device online state

On 08/25/2016 02:19 PM, Vasiliy Tolstov wrote: 25 Авг 2016 г. 19:18 пользователь "Laine Stump" > написал: > > On 08/25/2016 05:42 AM, Vasiliy Tolstov wrote: >> >> 25 Авг 2016 г. 12:34 пользователь Vasiliy Tolstov mailto:v.tols...@selfip.ru>> написал: >> > >> > 25 Авг 2

Re: [libvirt] [PATCH 2/3] qemu: remove unnecessary setting of tap device online state

25 Авг 2016 г. 19:18 пользователь "Laine Stump" написал: > > On 08/25/2016 05:42 AM, Vasiliy Tolstov wrote: >> >> 25 Авг 2016 г. 12:34 пользователь Vasiliy Tolstov написал: >> > >> > 25 Авг 2016 г. 8:58 пользователь "Laine Stump" написал: >> > > >> > > The linkstate setting of an is only meant

Re: [libvirt] [PATCH 2/3] qemu: remove unnecessary setting of tap device online state

On 08/25/2016 05:42 AM, Vasiliy Tolstov wrote: 25 Авг 2016 г. 12:34 пользователь Vasiliy Tolstov > написал: > > 25 Авг 2016 г. 8:58 пользователь "Laine Stump" > написал: > > > > The linkstate setting of an is only meant to change the > > onl

Re: [libvirt] [PATCH 2/3] qemu: remove unnecessary setting of tap device online state

On 08/25/2016 05:41 AM, Vasiliy Tolstov wrote: 25 Авг 2016 г. 8:58 пользователь "Laine Stump" > написал: > > The linkstate setting of an is only meant to change the > online status reported to the guest system by the emulated network > device driver in qemu, I need to

Re: [libvirt] [PATCH] qemu: fix ethernet network type ip/route assign

2016-08-25 18:17 GMT+03:00 Laine Stump : > Until now, linkstate has always been used to control the online status of > the emulated NIC in the guest, and the tap device has always been IFF_UP > (and for a good reason. See my reply to you in the thread for my patches for > more details...) Yes, i

Re: [libvirt] [Qemu-devel] [RFC] libvirt vGPU QEMU integration

On 08/24/2016 06:29 PM, Daniel P. Berrange wrote: On Thu, Aug 18, 2016 at 09:41:59AM -0700, Neo Jia wrote: Hi libvirt experts, I am starting this email thread to discuss the potential solution / proposal of integrating vGPU support into libvirt for QEMU. Some quick background, NVIDIA is implem

Re: [libvirt] [PATCH] qemu: fix ethernet network type ip/route assign

On 08/25/2016 02:59 AM, Vasiliy Tolstov wrote: May be I miss something but in you patch you always up tap device, but if I create domain with link down in XML this not right. What do you think? Until now, linkstate has always been used to control the online status of the emulated NIC in th

[libvirt] [PATCH 1/2] vz: implicitly support additional migration flags

* Added VIR_MIGRATE_LIVE, VIR_MIGRATE_UNDEFINE_SOURCE and VIR_MIGRATE_PERSIST_DEST to supported migration flags Signed-off-by: Pavel Glushchak --- src/vz/vz_driver.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c index b34fe33

[libvirt] [PATCH 2/2] vz: added VIR_MIGRATE_PARAM_BANDWIDTH param handling

libvirt-python passes parameter bandwidth = 0 by default. This means that bandwidth is unlimited. VZ driver doesn't support bandwidth rate limiting, but we still need to handle it and fail if bandwidth > 0. Signed-off-by: Pavel Glushchak --- src/vz/vz_driver.c | 12 1 file changed,

[libvirt] [PATCH] Bypass caching in saving VM memory upon external memory snapshot.

From: Fuweiwei Currently in qemu-kvm platform, the process of making an external memory snapshot is based on the "migration-to-file" sheme. It will use the system cache to speed up dumping. However, it will make external disk snapshots afterwards, which must wait for the completion of flushing

[libvirt] [PATCH 1/2] vz: implicitly support additional migration flags

* Added VIR_MIGRATE_LIVE, VIR_MIGRATE_UNDEFINE_SOURCE and VIR_MIGRATE_PERSIST_DEST to supported migration flags Signed-off-by: Pavel Glushchak --- src/vz/vz_driver.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c index b34fe33

[libvirt] [PATCH 2/2] vz: added VIR_MIGRATE_PARAM_BANDWIDTH param handling

libvirt-python passes parameter bandwidth = 0 by default. This means that bandwidth is unlimited. VZ driver doesn't support bandwidth rate limiting, but we still need to handle it and fail if bandwidth > 0. Signed-off-by: Pavel Glushchak --- src/vz/vz_driver.c | 12 1 file changed,

Re: [libvirt] [PATCH v1] qemu-migration: Disallow migration of read only disk

Oh, sorry, had this on my todo list and somehow missed it. This looks ok, in my case read-only device is not part of migrate-disks parameter, so everything should be all right. Thanks for testing it! Kind Regards, Pawel Koniszewski > -Original Message- > From: Jason J. Herne [mailto:jj

Re: [libvirt] [PATCH v1] qemu-migration: Disallow migration of read only disk

On 08/17/2016 05:10 PM, Jason J. Herne wrote: On 08/11/2016 08:57 AM, Corey S McQuay wrote: On 08/10/2016 09:16 AM, Koniszewski, Pawel wrote: -Original Message- From: libvir-list-boun...@redhat.com [mailto:libvir-list- boun...@redhat.com] On Behalf Of Corey S. McQuay Sent: Friday, Augu

Re: [libvirt] [PATCH] Bypass caching in saving VM memory upon external memory snapshot.

On Thu, Aug 25, 2016 at 07:46:01AM +, fuweiwei wrote: > From: Fuweiwei > > Currently in qemu-kvm platform, the process of making an external memory > snapshot is based on the "migration-to-file" sheme. It will use the system > cache to speed up dumping. However, it will make external disk s

Re: [libvirt] [PATCH 0/7] fspool: backend directory

On Thu, Aug 25, 2016 at 02:03:01PM +0300, Olga Krishtal wrote: > On 25/08/16 04:14, Daniel P. Berrange wrote: > > On Fri, Aug 19, 2016 at 06:03:28PM +0300, Olga Krishtal wrote: > > > Hi everyone, we would like to propose the first implementation of fspool > > > with directory backend. > > > > > >

Re: [libvirt] [PATCH 0/7] fspool: backend directory

On 25/08/16 04:14, Daniel P. Berrange wrote: On Fri, Aug 19, 2016 at 06:03:28PM +0300, Olga Krishtal wrote: Hi everyone, we would like to propose the first implementation of fspool with directory backend. Filesystem pools is a facility to manage filesystems resources similar to how storage pool

Re: [libvirt] [PATCH 6/7] fspool: default implementation of filesystem pools

On 25/08/16 04:12, Daniel P. Berrange wrote: On Fri, Aug 19, 2016 at 06:03:34PM +0300, Olga Krishtal wrote: Implementation is backend base as in case of storage pools. This patch adds directory backend which is nothing more than managing directories inside another one as starting point. Signed-

Re: [libvirt] [PATCH 7/7] virsh: filesystem pools commands

On 25/08/16 04:13, Daniel P. Berrange wrote: On Fri, Aug 19, 2016 at 06:03:35PM +0300, Olga Krishtal wrote: Signed-off-by: Nikolay Shirokovskiy --- po/POTFILES.in |2 + tools/Makefile.am|4 + tools/virsh-fspool.c | 1728 ++

Re: [libvirt] [PATCH 3/7] fspools: configuration and internal representation

On 25/08/16 04:07, Daniel P. Berrange wrote: On Fri, Aug 19, 2016 at 06:03:31PM +0300, Olga Krishtal wrote: Signed-off-by: Nikolay Shirokovskiy --- po/POTFILES.in |1 + src/Makefile.am |5 + src/conf/fs_conf.c | 1624 +

Re: [libvirt] [PATCH 1/7] fspool: introduce filesystem pools API

On 25/08/16 04:00, Daniel P. Berrange wrote: On Fri, Aug 19, 2016 at 06:03:29PM +0300, Olga Krishtal wrote: API follows the API of storage pools closely in parts which do not differ for filesystems. Signed-off-by: Nikolay Shirokovskiy --- include/libvirt/libvirt-fs.h | 273 ++

Re: [libvirt] [PATCH 2/3] qemu: remove unnecessary setting of tap device online state

25 Авг 2016 г. 12:34 пользователь Vasiliy Tolstov написал: > > 25 Авг 2016 г. 8:58 пользователь "Laine Stump" написал: > > > > The linkstate setting of an is only meant to change the > > online status reported to the guest system by the emulated network > > device driver in qemu, > > I need to s

Re: [libvirt] [PATCH 2/3] qemu: remove unnecessary setting of tap device online state

25 Авг 2016 г. 8:58 пользователь "Laine Stump" написал: > > The linkstate setting of an is only meant to change the > online status reported to the guest system by the emulated network > device driver in qemu, I need to set host side status of interface. Without this live migration with dinamic

Re: [libvirt] [PATCH] vz: update domain cache after device updates

On 25.08.2016 11:33, Nikolay Shirokovskiy wrote: --- src/vz/vz_driver.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c index b34fe33..f223794 100644 --- a/src/vz/vz_driver.c +++ b/src/vz/vz_driver.c @@ -1694,6 +1694,9 @@ static int vzDomainUpdat

[libvirt] [PATCH] vz: update domain cache after device updates

--- src/vz/vz_driver.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c index b34fe33..f223794 100644 --- a/src/vz/vz_driver.c +++ b/src/vz/vz_driver.c @@ -1694,6 +1694,9 @@ static int vzDomainUpdateDeviceFlags(virDomainPtr domain, if (prlsdkUpdat

Re: [libvirt] [PATCH v2] qemu: neglect cur_balloon in supplied xml

On 30.07.2016 16:04, John Ferlan wrote: > s/$subj/qemu: Filter cur_balloon ABI check for certain transactions > > On 06/09/2016 10:32 AM, Nikolay Shirokovskiy wrote: >> cur_balloon value can change in between preparing external config and >> using it in operations like save and migrate. As a res

Re: [libvirt] [PATCH 2/3] qemu: remove unnecessary setting of tap device online state

Dear Laine, Laine Stump writes: > The linkstate setting of an is only meant to change the > online status reported to the guest system by the emulated network > device driver in qemu, but when support for auto-creating tap devices > for was added in commit 9717d6, a chunk of Typo: the commit

Re: [libvirt] [PATCH] vz: getting bus type for containers

On 15.08.2016 19:02, Mikhail Feoktistov wrote: > We should query bus type for containers too, like for VM. > In openstack we add volume disk like SCSI, so we can't > hardcode SATA bus. > --- > src/vz/vz_sdk.c | 32 +--- > 1 file changed, 13 insertions(+), 19 deletions

Re: [libvirt] [PATCH] qemu: fix ethernet network type ip/route assign

25 Авг 2016 г. 9:00 пользователь "Laine Stump" написал: > > On 08/24/2016 02:32 PM, Laine Stump wrote: >> >> On 08/24/2016 12:09 PM, Vasiliy Tolstov wrote: >>> >>> IP and routes assigenment incorrectly placed on device stop. >>> This is fixing it, also change device state according to xml. >>> Not