Re: [libvirt] [RFC v2] libvirt vGPU QEMU integration

2016-09-20 Thread Alex Williamson
On Wed, 21 Sep 2016 04:10:53 + "Tian, Kevin" wrote: > > From: Kirti Wankhede [mailto:kwankh...@nvidia.com] > > Sent: Wednesday, September 21, 2016 12:23 AM > > > > > > On 9/20/2016 8:13 PM, Alex Williamson wrote: > > > On Tue, 20 Sep 2016 19:51:58 +0530 > > > Kirti Wankhede wrote: > > >

Re: [libvirt] [RFC v2] libvirt vGPU QEMU integration

2016-09-20 Thread Alex Williamson
On Wed, 21 Sep 2016 03:56:21 + "Tian, Kevin" wrote: > > From: Kirti Wankhede [mailto:kwankh...@nvidia.com] > > Sent: Tuesday, September 20, 2016 10:22 PM > > >> > > >> 'max_instance': > > >> Read-Only file. Mandatory. > > >> Returns integer. Returns maximum mdev device could be cre

Re: [libvirt] [RFC v2] libvirt vGPU QEMU integration

2016-09-20 Thread Tian, Kevin
> From: Kirti Wankhede [mailto:kwankh...@nvidia.com] > Sent: Wednesday, September 21, 2016 12:23 AM > > > On 9/20/2016 8:13 PM, Alex Williamson wrote: > > On Tue, 20 Sep 2016 19:51:58 +0530 > > Kirti Wankhede wrote: > > > >> On 9/20/2016 3:06 AM, Alex Williamson wrote: > >>> On Tue, 20 Sep 2016

Re: [libvirt] [RFC v2] libvirt vGPU QEMU integration

2016-09-20 Thread Tian, Kevin
> From: Kirti Wankhede [mailto:kwankh...@nvidia.com] > Sent: Tuesday, September 20, 2016 10:22 PM > >> > >> 'max_instance': > >> Read-Only file. Mandatory. > >> Returns integer. Returns maximum mdev device could be created > >> at the moment when this file is read. This count would be upda

Re: [libvirt] [PATCH rfc v2 0/8] fspool: backend directory

2016-09-20 Thread John Ferlan
On 09/15/2016 03:32 AM, Olga Krishtal wrote: > Hi everyone, we would like to propose the first implementation of fspool > with directory backend. > > Filesystem pools is a facility to manage filesystems resources similar > to how storage pools manages volume resources. Furthermore new API follow

Re: [libvirt] [PATCH v1 3/4] xenconfig: channels conversion support

2016-09-20 Thread Jim Fehlig
Joao Martins wrote: > On 09/20/2016 04:04 AM, Jim Fehlig wrote: >> On 09/16/2016 05:43 PM, Joao Martins wrote: >>> Add support for formating/parsing libxl channels. >>> >>> Syntax on xen libxl goes as following: >>> channel=["connection=pty|socket,path=/path/to/socket,name=XXX",...] >>> >>> Signed-

Re: [libvirt] [PATCH v2] storage: vz storage pool support

2016-09-20 Thread John Ferlan
On 07/14/2016 01:13 PM, Olga Krishtal wrote: > This patch supports pool and volume management within Virtuozzo Storage. > Virtuozzo Storage is a highly-available distributed software defined storage > with built-in replication and disaster recovery. From client's point of > view it looks like net

Re: [libvirt] [PATCH v1 1/4] conf: add xen type for channels

2016-09-20 Thread Jim Fehlig
Joao Martins wrote: > On 09/19/2016 11:29 PM, Jim Fehlig wrote: >> On 09/16/2016 05:43 PM, Joao Martins wrote: >>> So far only guestfwd and virtio were supported. Add an additional >>> for Xen as libxl channels create Xen console visible to the guest. >>> >>> Signed-off-by: Joao Martins >>> --- >>

[libvirt] [PATCH v3 18/18] [RFC] qemu: try to put ich9 sound device at 00:1B.0

2016-09-20 Thread Laine Stump
Real Q35 hardware has an ICH9 chip that includes several integrated devices at particular addresses (see the file docs/q35-chipset.cfg in the qemu source). libvirt already attempts to put the first two sets of ich9 USB2 controllers it finds at 00:1D.* and 00:1A.* to match the real hardware. This pa

[libvirt] [PATCH v3 15/18] qemu: auto-add pcie-root-port/dmi-to-pci-bridge controllers as needed

2016-09-20 Thread Laine Stump
Previously libvirt would only add pci-bridge devices automatically when an address was requested for a device that required a legacy PCI slot and none was available. This patch expands that support to dmi-to-pci-bridge (which is needed in order to add a pci-bridge on a machine with a pcie-root), an

[libvirt] [PATCH v3 09/18] qemu: set/use info->pciConnectFlags during qemuDomainAssignDevicePCISlots

2016-09-20 Thread Laine Stump
Set pciConnectFlags in each device's DeviceInfo prior to assigning PCI addresses, and then use those flags later when actually assigning the addresses with qemuDomainPCIAddressReserveNextAddr() (rather than scattering the logic about which devices need which type of slot all over the place). --- s

[libvirt] [PATCH v3 17/18] qemu: add a USB3 controller to Q35 domains by default

2016-09-20 Thread Laine Stump
Previously we added a set of EHCI+UHCI controllers to Q35 machines to mimic real hardware as closely as possible, but recent discussions have pointed out that the nec-usb-xhci (USB3) controller is much more virtualization-friendly (uses less CPU), so this patch switches the default for Q35 machinet

[libvirt] [PATCH v3 13/18] qemu: assign nec-xhci (USB3) controller to a PCIe address when appropriate

2016-09-20 Thread Laine Stump
The nec-usb-xhci device (which is a USB3 controller) has always presented itself as a PCI device when plugged into a legacy PCI slot, and a PCIe device when plugged into a PCIe slot, but libvirt has always auto-assigned it to a PCI slot. This patch changes that behavior to auto-assign to a PCIe sl

[libvirt] [PATCH v3 11/18] qemu: assign virtio devices to PCIe slot when appropriate

2016-09-20 Thread Laine Stump
libvirt previously assigned nearly all devices to a "hotpluggable" legacy PCI slot even on machines with a PCIe root bus (and even though most such machines don't even support hotplug on legacy PCI slots!) Forcing all devices onto legacy PCI slots means that the domain will need a dmi-to-pci-bridge

[libvirt] [PATCH v3 12/18] qemu: assign e1000e network devices to PCIe slots when appropriate

2016-09-20 Thread Laine Stump
The e1000e is an emulated network device based on the Intel 82574, present in qemu 2.7.0 and later. Among other differences from the e1000, it presents itself as a PCIe device rather than legacy PCI. In order to get it assigned to a PCIe controller, this patch updates the flags setting for network

[libvirt] [PATCH v3 16/18] qemu: don't force-add a dmi-to-pci-bridge just on principle

2016-09-20 Thread Laine Stump
Now the a dmi-to-pci-bridge is automatically added just as it's needed (when a pci-bridge is being added), we no longer have any need to force-add one to every single Q35 domain. --- src/qemu/qemu_domain.c | 12 tests/qemuxml2argvdata/qemuxml2argv-pcie-root.args |

[libvirt] [PATCH v3 14/18] qemu: only force an available legacy-PCI slot on domains with pci-root

2016-09-20 Thread Laine Stump
Andrea had the right idea when he disabled the "reserve an extra unused slot" bit for aarch64/virt. For *any* PCI Express-based machine, it is pointless since 1) an extra legacy-PCI slot can't be used for hotplug, since hotplug into legacy PCI slots doesn't work on PCI Express machinetypes, and 2)

[libvirt] [PATCH v3 03/18] qemu: new functions qemuDomainMachineHasPCI[e]Root()

2016-09-20 Thread Laine Stump
These functions provide a simple one line method of learning if the current domain has a pci-root or pcie-root bus. --- src/qemu/qemu_domain.c | 28 src/qemu/qemu_domain.h | 2 ++ 2 files changed, 30 insertions(+) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_d

[libvirt] [PATCH v3 08/18] qemu: replace calls to virDomainPCIAddressReserveNext*() with static function

2016-09-20 Thread Laine Stump
An upcoming commit will remove the "flag" argument from all the calls to reserve the next available address|slot, but I don't want to change the arguments in the hypervisor-agnostic virDomainPCIAddressReserveNext*() functions, so this patch places a simple qemu-specific wrapper around those functio

[libvirt] [PATCH v3 05/18] conf: new function virDomainPCIAddressReserveNextAddr()

2016-09-20 Thread Laine Stump
There is an existing virDomainPCIAddressReserveNextSlot() which will reserve all functions of the next available PCI slot. One place in the qemu PCI address assignment code requires reserving a *single* function of the next available PCI slot. This patch modifies and renames virDomainPCIAddressRese

[libvirt] [PATCH v3 04/18] qemu: new functions qemuDomainDeviceConnectFlags*()

2016-09-20 Thread Laine Stump
The lowest level function of this trio aims to be the ultimate authority for the virDomainPCIConnectFlags to use for any given device using a particular arch/machinetype/qemu-binary. qemuDomainDeviceConnectFlagsInternal() returns the flags qemuDomainDeviceConnectFlags() sets info->pciConnectFlags

[libvirt] [PATCH v3 10/18] qemu: set/use proper pciConnectFlags during hotplug

2016-09-20 Thread Laine Stump
Before now, all the qemu hotplug functions assumed that all devices to be hotplugged were legacy PCI endpoint devices (VIR_PCI_CONNECT_TYPE_PCI_DEVICE). This worked out "okay", because all devices *are* legacy PCI endpoint devices on x86/440fx machinetypes, and hotplug didn't work properly on machi

[libvirt] [PATCH v3 07/18] conf: make virDomainPCIAddressGetNextSlot() a local static function

2016-09-20 Thread Laine Stump
This function is no longer needed outside of domain_addr.c. --- src/conf/domain_addr.c | 2 +- src/conf/domain_addr.h | 5 - src/libvirt_private.syms | 1 - 3 files changed, 1 insertion(+), 7 deletions(-) diff --git a/src/conf/domain_addr.c b/src/conf/domain_addr.c index f735fb4..be42f15

[libvirt] [PATCH v3 01/18] conf: restrict what type of buses will accept a pci-bridge

2016-09-20 Thread Laine Stump
A pci-bridge has *almost* the same rules as a legacy PCI endpoint device for where it can be automatically connected, and until now both had been considered identical. There is one pairing that is okay when specifically requested by the user (i.e. manual assignment), but we want to avoid it when au

[libvirt] [PATCH v3 02/18] qemu: replace a lot of "def->controllers[i]" with equivalent "cont"

2016-09-20 Thread Laine Stump
There's no functional change here. This pointer was just used so many times that the extra long lines became annoying. --- src/qemu/qemu_domain_address.c | 100 + 1 file changed, 51 insertions(+), 49 deletions(-) diff --git a/src/qemu/qemu_domain_address.c

[libvirt] [PATCH v3 00/18] Use mode PCIe less legacy PCI

2016-09-20 Thread Laine Stump
(this time with auto-root-port-add goodness!) Last month I posted a short patch series that attempted to auto-assign addresses on PCI Express controllers to devices that were PCI Express devices. https://www.redhat.com/archives/libvir-list/2016-August/msg00732.html In particular, it would assi

[libvirt] [PATCH v3 06/18] qemu: use virDomainPCIAddressReserveNextAddr in qemuDomainAssignDevicePCISlots

2016-09-20 Thread Laine Stump
instead of calling virDomainPCIAddressGetNextSlot() (which I want to turn into a local static in domain_addr.c). --- src/qemu/qemu_domain_address.c | 31 +-- 1 file changed, 13 insertions(+), 18 deletions(-) diff --git a/src/qemu/qemu_domain_address.c b/src/qemu/qemu_d

Re: [libvirt] [PATCH v3 4/5] qmp: Add runnability information to query-cpu-definitions

2016-09-20 Thread Eduardo Habkost
On Tue, Sep 20, 2016 at 01:25:06PM -0500, Eric Blake wrote: > On 09/19/2016 02:42 PM, Eduardo Habkost wrote: > > Add a new optional field to query-cpu-definitions schema: > > "unavailable-features". It will contain a list of QOM properties > > that prevent the CPU model from running in the current

[libvirt] [PATCH] config-post.h:fix a typo

2016-09-20 Thread Nitesh Konkar
Signed-off-by: Nitesh Konkar --- config-post.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config-post.h b/config-post.h index dd69197..6eb63db 100644 --- a/config-post.h +++ b/config-post.h @@ -20,7 +20,7 @@ * Since virt-login-shell will be setuid, we must do everything

Re: [libvirt] [PATCH v3 4/5] qmp: Add runnability information to query-cpu-definitions

2016-09-20 Thread Eric Blake
On 09/19/2016 02:42 PM, Eduardo Habkost wrote: > Add a new optional field to query-cpu-definitions schema: > "unavailable-features". It will contain a list of QOM properties > that prevent the CPU model from running in the current host. > > Cc: David Hildenbrand > Cc: Michael Mueller > Cc: Chris

Re: [libvirt] [PATCH v1 1/4] conf: add xen type for channels

2016-09-20 Thread Joao Martins
On 09/19/2016 11:29 PM, Jim Fehlig wrote: > On 09/16/2016 05:43 PM, Joao Martins wrote: >> So far only guestfwd and virtio were supported. Add an additional >> for Xen as libxl channels create Xen console visible to the guest. >> >> Signed-off-by: Joao Martins >> --- >> docs/schemas/domaincommon.

Re: [libvirt] [PATCH v1 3/4] xenconfig: channels conversion support

2016-09-20 Thread Joao Martins
On 09/20/2016 04:04 AM, Jim Fehlig wrote: > On 09/16/2016 05:43 PM, Joao Martins wrote: >> Add support for formating/parsing libxl channels. >> >> Syntax on xen libxl goes as following: >> channel=["connection=pty|socket,path=/path/to/socket,name=XXX",...] >> >> Signed-off-by: Joao Martins >> ---

Re: [libvirt] [Qemu-devel] [RFC v2] libvirt vGPU QEMU integration

2016-09-20 Thread Paolo Bonzini
On 20/09/2016 17:14, Daniel P. Berrange wrote: > Any VM which > uses the separate namespace is tainted, which means if theres a bug > report we'll require the reported to remove whatever config caused > the tainting and then reproduce the problem. > > If the vendor specific mdev parameters are t

Re: [libvirt] [RFC v2] libvirt vGPU QEMU integration

2016-09-20 Thread Alex Williamson
On Tue, 20 Sep 2016 21:53:16 +0530 Kirti Wankhede wrote: > On 9/20/2016 8:13 PM, Alex Williamson wrote: > > On Tue, 20 Sep 2016 19:51:58 +0530 > > Kirti Wankhede wrote: > > > >> On 9/20/2016 3:06 AM, Alex Williamson wrote: > >>> On Tue, 20 Sep 2016 02:05:52 +0530 > >>> Kirti Wankhede wrote

Re: [libvirt] [Qemu-devel] [RFC v2] libvirt vGPU QEMU integration

2016-09-20 Thread Daniel P. Berrange
On Tue, Sep 20, 2016 at 10:01:18PM +0530, Kirti Wankhede wrote: > > > On 9/20/2016 8:44 PM, Daniel P. Berrange wrote: > > On Tue, Sep 20, 2016 at 05:05:43PM +0200, Paolo Bonzini wrote: > >> > >> > >> On 20/09/2016 16:58, Daniel P. Berrange wrote: > > As I've said in my earlier reply - libvirt

Re: [libvirt] [Qemu-devel] [RFC v2] libvirt vGPU QEMU integration

2016-09-20 Thread Daniel P. Berrange
On Tue, Sep 20, 2016 at 10:12:20PM +0530, Kirti Wankhede wrote: > > > On 9/20/2016 10:06 PM, Daniel P. Berrange wrote: > > On Tue, Sep 20, 2016 at 10:01:18PM +0530, Kirti Wankhede wrote: > >> > >> > >> On 9/20/2016 8:44 PM, Daniel P. Berrange wrote: > >>> On Tue, Sep 20, 2016 at 05:05:43PM +0200,

Re: [libvirt] [Qemu-devel] [RFC v2] libvirt vGPU QEMU integration

2016-09-20 Thread Kirti Wankhede
On 9/20/2016 10:06 PM, Daniel P. Berrange wrote: > On Tue, Sep 20, 2016 at 10:01:18PM +0530, Kirti Wankhede wrote: >> >> >> On 9/20/2016 8:44 PM, Daniel P. Berrange wrote: >>> On Tue, Sep 20, 2016 at 05:05:43PM +0200, Paolo Bonzini wrote: On 20/09/2016 16:58, Daniel P. Berrange wro

Re: [libvirt] [Qemu-devel] [RFC v2] libvirt vGPU QEMU integration

2016-09-20 Thread Daniel P. Berrange
On Tue, Sep 20, 2016 at 10:01:18PM +0530, Kirti Wankhede wrote: > > > On 9/20/2016 8:44 PM, Daniel P. Berrange wrote: > > On Tue, Sep 20, 2016 at 05:05:43PM +0200, Paolo Bonzini wrote: > >> > >> > >> On 20/09/2016 16:58, Daniel P. Berrange wrote: > > As I've said in my earlier reply - libvirt

Re: [libvirt] [Qemu-devel] [RFC v2] libvirt vGPU QEMU integration

2016-09-20 Thread Kirti Wankhede
On 9/20/2016 8:44 PM, Daniel P. Berrange wrote: > On Tue, Sep 20, 2016 at 05:05:43PM +0200, Paolo Bonzini wrote: >> >> >> On 20/09/2016 16:58, Daniel P. Berrange wrote: > As I've said in my earlier reply - libvirt will *NOT* support passing > arbitrary vendor specific parameters as a blob

Re: [libvirt] [RFC v2] libvirt vGPU QEMU integration

2016-09-20 Thread Kirti Wankhede
On 9/20/2016 8:13 PM, Alex Williamson wrote: > On Tue, 20 Sep 2016 19:51:58 +0530 > Kirti Wankhede wrote: > >> On 9/20/2016 3:06 AM, Alex Williamson wrote: >>> On Tue, 20 Sep 2016 02:05:52 +0530 >>> Kirti Wankhede wrote: >>> Hi libvirt experts, 'create': Write-o

Re: [libvirt] [PATCH v2] qemu-migration: Disallow migration of read only disk

2016-09-20 Thread Daniel P. Berrange
On Tue, Sep 20, 2016 at 05:49:17PM +0200, Peter Krempa wrote: > On Tue, Sep 20, 2016 at 15:21:16 +0100, Daniel Berrange wrote: > > On Tue, Sep 20, 2016 at 03:53:16PM +0200, Peter Krempa wrote: > > > On Tue, Sep 20, 2016 at 09:40:22 -0400, Corey S. McQuay wrote: > > > > Currently Libvirt allows atte

Re: [libvirt] [RFC PATCH] Use disable-modern=on for disk device='lun'

2016-09-20 Thread Laine Stump
On 09/20/2016 08:57 AM, Daniel P. Berrange wrote: On Tue, Sep 20, 2016 at 02:21:49PM +0200, Ján Tomko wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1365823 For virtio-blk, scsi=on has been deprecated in virtio-1, so no longer works with with a virtio-blk-pci device with machine types newe

Re: [libvirt] [PATCH v2] qemu-migration: Disallow migration of read only disk

2016-09-20 Thread Peter Krempa
On Tue, Sep 20, 2016 at 15:21:16 +0100, Daniel Berrange wrote: > On Tue, Sep 20, 2016 at 03:53:16PM +0200, Peter Krempa wrote: > > On Tue, Sep 20, 2016 at 09:40:22 -0400, Corey S. McQuay wrote: > > > Currently Libvirt allows attempts to migrate read only disks. Qemu cannot > > > handle this as rea

Re: [libvirt] [Qemu-devel] [RFC v2] libvirt vGPU QEMU integration

2016-09-20 Thread Daniel P. Berrange
On Tue, Sep 20, 2016 at 05:05:43PM +0200, Paolo Bonzini wrote: > > > On 20/09/2016 16:58, Daniel P. Berrange wrote: > > > > As I've said in my earlier reply - libvirt will *NOT* support passing > > > > arbitrary vendor specific parameters as a blob via the XML. Everything > > > > that appears in

Re: [libvirt] [PATCH v7 2/5] conf: Introduce {default|chardev}_tls_x509_secret_uuid

2016-09-20 Thread John Ferlan
On 09/20/2016 08:52 AM, Daniel P. Berrange wrote: > On Tue, Sep 20, 2016 at 08:26:55AM -0400, John Ferlan wrote: >> >> >> On 09/19/2016 10:53 AM, Daniel P. Berrange wrote: >>> On Mon, Sep 19, 2016 at 10:39:21AM -0400, John Ferlan wrote: Add a new qemu.conf variables to store the UUID for the

Re: [libvirt] [Qemu-devel] [RFC v2] libvirt vGPU QEMU integration

2016-09-20 Thread Paolo Bonzini
On 20/09/2016 16:58, Daniel P. Berrange wrote: > > > As I've said in my earlier reply - libvirt will *NOT* support passing > > > arbitrary vendor specific parameters as a blob via the XML. Everything > > > that appears in the XML must be *fully* specified and explicitly > > > represented in the X

Re: [libvirt] [Qemu-devel] [RFC v2] libvirt vGPU QEMU integration

2016-09-20 Thread Daniel P. Berrange
On Tue, Sep 20, 2016 at 04:49:09PM +0200, Paolo Bonzini wrote: > > > On 20/09/2016 16:41, Daniel P. Berrange wrote: > > As I've said in my earlier reply - libvirt will *NOT* support passing > > arbitrary vendor specific parameters as a blob via the XML. Everything > > that appears in the XML must

Re: [libvirt] [PATCH] qemuDomainOpenGraphics: Start job early

2016-09-20 Thread Michal Privoznik
On 20.09.2016 15:33, Jiri Denemark wrote: > Checking if a domain's definition or if it is active before we got a job > is pointless since the domain might have changed in the meantime. > > Luckily libvirtd didn't crash when the API tried to talk to an inactive > domain: > > debug : qemuDomainObjB

Re: [libvirt] [RFC v2] libvirt vGPU QEMU integration

2016-09-20 Thread Alex Williamson
On Tue, 20 Sep 2016 20:05:01 +0530 Kirti Wankhede wrote: > On 9/20/2016 3:55 AM, Alex Williamson wrote: > > On Mon, 19 Sep 2016 23:50:56 +0200 > > Paolo Bonzini wrote: > > > >> On 19/09/2016 23:36, Alex Williamson wrote: > >>> On Tue, 20 Sep 2016 02:05:52 +0530 > >>> Kirti Wankhede wrote:

Re: [libvirt] [Qemu-devel] [RFC v2] libvirt vGPU QEMU integration

2016-09-20 Thread Paolo Bonzini
On 20/09/2016 16:41, Daniel P. Berrange wrote: > As I've said in my earlier reply - libvirt will *NOT* support passing > arbitrary vendor specific parameters as a blob via the XML. Everything > that appears in the XML must be *fully* specified and explicitly > represented in the XML as a distinc

Re: [libvirt] [Qemu-devel] [RFC v2] libvirt vGPU QEMU integration

2016-09-20 Thread Daniel P. Berrange
On Tue, Sep 20, 2016 at 08:05:01PM +0530, Kirti Wankhede wrote: > > > On 9/20/2016 3:55 AM, Alex Williamson wrote: > > On Mon, 19 Sep 2016 23:50:56 +0200 > > Paolo Bonzini wrote: > > > >> On 19/09/2016 23:36, Alex Williamson wrote: > >>> On Tue, 20 Sep 2016 02:05:52 +0530 > >>> Kirti Wankhede

Re: [libvirt] [RFC v2] libvirt vGPU QEMU integration

2016-09-20 Thread Alex Williamson
On Tue, 20 Sep 2016 19:51:58 +0530 Kirti Wankhede wrote: > On 9/20/2016 3:06 AM, Alex Williamson wrote: > > On Tue, 20 Sep 2016 02:05:52 +0530 > > Kirti Wankhede wrote: > > > >> Hi libvirt experts, > >> > >> Thanks for valuable input on v1 version of RFC. > >> > >> Quick brief, VFIO based med

Re: [libvirt] [RFC v2] libvirt vGPU QEMU integration

2016-09-20 Thread Kirti Wankhede
On 9/20/2016 3:55 AM, Alex Williamson wrote: > On Mon, 19 Sep 2016 23:50:56 +0200 > Paolo Bonzini wrote: > >> On 19/09/2016 23:36, Alex Williamson wrote: >>> On Tue, 20 Sep 2016 02:05:52 +0530 >>> Kirti Wankhede wrote: 'fb_length': Read-only file. Mandatory. Returns {K

Re: [libvirt] [RFC v2] libvirt vGPU QEMU integration

2016-09-20 Thread Kirti Wankhede
On 9/20/2016 3:06 AM, Alex Williamson wrote: > On Tue, 20 Sep 2016 02:05:52 +0530 > Kirti Wankhede wrote: > >> Hi libvirt experts, >> >> Thanks for valuable input on v1 version of RFC. >> >> Quick brief, VFIO based mediated device framework provides a way to >> virtualize their devices without

Re: [libvirt] [PATCH v2] qemu-migration: Disallow migration of read only disk

2016-09-20 Thread Daniel P. Berrange
On Tue, Sep 20, 2016 at 03:53:16PM +0200, Peter Krempa wrote: > On Tue, Sep 20, 2016 at 09:40:22 -0400, Corey S. McQuay wrote: > > Currently Libvirt allows attempts to migrate read only disks. Qemu cannot > > handle this as read only > > disks cannot be written to on the destination system. The en

Re: [libvirt] [PATCH] virtlogd: Don't stop or restart along with libvirtd

2016-09-20 Thread Andrea Bolognani
On Tue, 2016-09-20 at 14:35 +0100, Daniel P. Berrange wrote: > ACK Pushed, thanks. > FYI, systemd docs say >  >PartOf= >Configures dependencies similar to Requires=, but limited to >stopping and restarting of units. When systemd stops or restarts >the u

Re: [libvirt] [PATCH v2] qemu-migration: Disallow migration of read only disk

2016-09-20 Thread Peter Krempa
On Tue, Sep 20, 2016 at 09:40:22 -0400, Corey S. McQuay wrote: > Currently Libvirt allows attempts to migrate read only disks. Qemu cannot > handle this as read only > disks cannot be written to on the destination system. The end result is a > cryptic error message > and a failed migration. This

[libvirt] [PATCH 0/9] Couple of migration fixes

2016-09-20 Thread Michal Privoznik
Looks like nobody tried migrations lately. I just did and found interesting bug. On the destination qemu binary was at different path. So I've dumped domain XML I was trying ti migrate and just changed the emulator path. All of a sudden I observed plenty of errors. Problem is that whilst parsing th

[libvirt] [PATCH 2/9] conf: Introduce virDomainDefParseStringOpaque

2016-09-20 Thread Michal Privoznik
This function allows callers to pass arbitrary pointer to domain def parse callback. Signed-off-by: Michal Privoznik --- src/conf/domain_conf.c | 37 ++--- src/conf/domain_conf.h | 11 +++ src/libvirt_private.syms | 2 ++ 3 files changed, 43 insertion

[libvirt] [PATCH 1/9] conf: Introduce virDomainDefPostParseOpaque

2016-09-20 Thread Michal Privoznik
Some callers might want to pass yet another pointer to opaque data to post parse callbacks. The driver generic one is not enough because two threads executing post parse callback might want see different data (e.g. domain object pointer that domain def belongs to). Signed-off-by: Michal Privoznik

[libvirt] [PATCH 5/9] qemuDomainDeviceDefPostParse: Fetch caps from domain object

2016-09-20 Thread Michal Privoznik
Just like we did two commits ago, don't try to fetch capabilities for non-existing binary. Re-use the ones we have for running domain. Signed-off-by: Michal Privoznik --- src/qemu/qemu_domain.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_domain

[libvirt] [PATCH 9/9] conf: Skip post parse callbacks when creating copy

2016-09-20 Thread Michal Privoznik
When creating a copy of virDomainDef we save ourselves the trouble of writing deep-copy functions and just format and parse back domain/device XML. However, the XML we are parsing was already fully formatted - there is no reason to run post parse callbacks (which fill in blanks - there are none!).

[libvirt] [PATCH 4/9] conf: Extend virDomainDeviceDefPostParse for parseOpaque

2016-09-20 Thread Michal Privoznik
Just like virDomainDefPostParseCallback has gained new parseOpaque argument, we need to follow the logic with virDomainDeviceDefPostParse. Signed-off-by: Michal Privoznik --- src/bhyve/bhyve_domain.c | 3 ++- src/conf/domain_conf.c | 13 + src/conf/domain_conf.h | 8 +

[libvirt] [PATCH 3/9] qemuDomainDefPostParse: Fetch qemuCaps from domain object

2016-09-20 Thread Michal Privoznik
We can't rely on def->emulator path. It may be provided by user as we give them opportunity to provide their own XML for migration. Therefore the path may point to just whatever binary (or even to a non-existent file). Moreover, this path is meant for destination, but the capabilities lookup is don

[libvirt] [PATCH 8/9] domain_conf: Introduce VIR_DOMAIN_DEF_PARSE_SKIP_POST_PARSE

2016-09-20 Thread Michal Privoznik
This is an internal flag that prevents our two entry points to XML parsing (virDomainDefParse and virDomainDeviceDefParse) from running post parse callbacks. This is expected to be used in cases when we already have full domain/device XML and we are just parsing it back (i.e. virDomainDefCopy or vi

[libvirt] [PATCH 7/9] qemuDomainDefAssignAddresses: Fetch caps from domain object

2016-09-20 Thread Michal Privoznik
Just like we did two commits ago, don't try to fetch capabilities for non-existing binary. Re-use the ones we have for running domain. Signed-off-by: Michal Privoznik --- src/qemu/qemu_domain.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_do

[libvirt] [PATCH 6/9] conf: Extend virDomainDefAssignAddressesCallback for parseOpaque

2016-09-20 Thread Michal Privoznik
Signed-off-by: Michal Privoznik --- src/conf/domain_conf.c | 3 ++- src/conf/domain_conf.h | 8 ++-- src/qemu/qemu_domain.c | 3 ++- 3 files changed, 10 insertions(+), 4 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index a4bc33f..89a3f62 100644 --- a/src/conf/dom

[libvirt] [PATCH] qemuDomainOpenGraphics: Start job early

2016-09-20 Thread Jiri Denemark
Checking if a domain's definition or if it is active before we got a job is pointless since the domain might have changed in the meantime. Luckily libvirtd didn't crash when the API tried to talk to an inactive domain: debug : qemuDomainObjBeginJobInternal:2914 : Started job: modify (async=no

[libvirt] [PATCH v2] qemu-migration: Disallow migration of read only disk

2016-09-20 Thread Corey S. McQuay
Currently Libvirt allows attempts to migrate read only disks. Qemu cannot handle this as read only disks cannot be written to on the destination system. The end result is a cryptic error message and a failed migration. This patch causes migration to fail earlier and provides a meaningful error

Re: [libvirt] [PATCH v1 0/4] libxl: channels support

2016-09-20 Thread Joao Martins
On 09/20/2016 01:14 PM, Michal Privoznik wrote: > On 20.09.2016 13:57, Joao Martins wrote: >> On 09/20/2016 11:54 AM, Michal Privoznik wrote: >>> On 20.09.2016 12:43, Joao Martins wrote: On 09/20/2016 05:14 AM, Michal Privoznik wrote: > On 20.09.2016 00:04, Jim Fehlig wrote: >> On 09/1

Re: [libvirt] [PATCH] virtlogd: Don't stop or restart along with libvirtd

2016-09-20 Thread Daniel P. Berrange
On Tue, Sep 20, 2016 at 03:29:59PM +0200, Andrea Bolognani wrote: > Commit 839a060 tied the lifecycle of virtlogd more > closely to that of libvirtd. Unfortunately, while starting > virtlogd when libvirtd is started is definitely a good idea, > restarting virtlogd or shutting it down at any time ou

[libvirt] [PATCH] virtlogd: Don't stop or restart along with libvirtd

2016-09-20 Thread Andrea Bolognani
Commit 839a060 tied the lifecycle of virtlogd more closely to that of libvirtd. Unfortunately, while starting virtlogd when libvirtd is started is definitely a good idea, restarting virtlogd or shutting it down at any time outside of system poweroff is not. Revert part of that commit by removing t

Re: [libvirt] [PATCH v4 1/8] vsh: Enforce checking for missing help string

2016-09-20 Thread Erik Skultety
On 20/09/16 14:43, Ján Tomko wrote: > On Mon, Sep 19, 2016 at 03:00:26PM +0200, Erik Skultety wrote: >> The intention is to move vshCmddefCheckInternals out of >> vshCmddefOptParse to >> our test suite. First step to do that is to enforce checking for an >> existing >> help string (that also means

Re: [libvirt] xen/libvirt freeze while attching network-device to vm´s - question about provided patches

2016-09-20 Thread Guido.Rossmueller
Hi Jim, thanks for your response ans sorry for my late answer, i´m sorry, i don´t really understand what you are missing in [2], or from where in the log-output you see that an shutdown event is missing. on our test-system the output looks normaly as follow: 2016-09-20 15:00:38 CEST libxl: de

Re: [libvirt] [PATCH v3 2/2] qemu_capabilities: Introduce gluster specific debug capability

2016-09-20 Thread Prasanna Kalever
On Tue, Sep 20, 2016 at 3:36 PM, Peter Krempa wrote: > On Tue, Sep 20, 2016 at 15:23:04 +0530, Prasanna Kumar Kalever wrote: >> Teach qemu driver to detect whether qemu supports this configuration >> factor or not. >> >> Signed-off-by: Prasanna Kumar Kalever >> --- >> src/qemu/qemu_capabilities.

Re: [libvirt] [RFC PATCH] Use disable-modern=on for disk device='lun'

2016-09-20 Thread Daniel P. Berrange
On Tue, Sep 20, 2016 at 02:21:49PM +0200, Ján Tomko wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1365823 > > For virtio-blk, scsi=on has been deprecated in virtio-1, > so no longer works with > with a virtio-blk-pci device with machine types newer than 2.7: > https://bugzilla.redhat.com/s

Re: [libvirt] [PATCH v7 2/5] conf: Introduce {default|chardev}_tls_x509_secret_uuid

2016-09-20 Thread Daniel P. Berrange
On Tue, Sep 20, 2016 at 08:26:55AM -0400, John Ferlan wrote: > > > On 09/19/2016 10:53 AM, Daniel P. Berrange wrote: > > On Mon, Sep 19, 2016 at 10:39:21AM -0400, John Ferlan wrote: > >> Add a new qemu.conf variables to store the UUID for the secret that could > >> be used to present credentials

Re: [libvirt] [PATCH v4 1/8] vsh: Enforce checking for missing help string

2016-09-20 Thread Ján Tomko
On Mon, Sep 19, 2016 at 03:00:26PM +0200, Erik Skultety wrote: The intention is to move vshCmddefCheckInternals out of vshCmddefOptParse to our test suite. First step to do that is to enforce checking for an existing help string (that also means it's non-empty) in a command because a command with

Re: [libvirt] [PATCH v7 2/5] conf: Introduce {default|chardev}_tls_x509_secret_uuid

2016-09-20 Thread John Ferlan
On 09/19/2016 10:53 AM, Daniel P. Berrange wrote: > On Mon, Sep 19, 2016 at 10:39:21AM -0400, John Ferlan wrote: >> Add a new qemu.conf variables to store the UUID for the secret that could >> be used to present credentials to access the TLS chardev. Since this will >> be a server level and it's

[libvirt] [RFC PATCH] Use disable-modern=on for disk device='lun'

2016-09-20 Thread Ján Tomko
https://bugzilla.redhat.com/show_bug.cgi?id=1365823 For virtio-blk, scsi=on has been deprecated in virtio-1, so no longer works with with a virtio-blk-pci device with machine types newer than 2.7: https://bugzilla.redhat.com/show_bug.cgi?id=1245453 http://git.qemu.org/?p=qemu.git;a=commitdiff;h=9

Re: [libvirt] [PATCH v1 0/4] libxl: channels support

2016-09-20 Thread Michal Privoznik
On 20.09.2016 13:57, Joao Martins wrote: > On 09/20/2016 11:54 AM, Michal Privoznik wrote: >> On 20.09.2016 12:43, Joao Martins wrote: >>> On 09/20/2016 05:14 AM, Michal Privoznik wrote: On 20.09.2016 00:04, Jim Fehlig wrote: > On 09/16/2016 05:43 PM, Joao Martins wrote: >> Hey, >>

[libvirt] [PATCH] Add missing 'extern' for VIR_EXPORT_VAR macro

2016-09-20 Thread Daniel P. Berrange
The recent update to gnulib commit 9d7a37ecb2ab516c19164a57b8aeb32016a99d2c Author: Eric Blake Date: Thu Sep 15 15:12:52 2016 -0500 build: update to latest gnulib Pulled in a change that adds -fno-common to the default compiler flags commit bf8e658ffadb95d444f56d222d04c9af955af76

Re: [libvirt] [PATCH v1 0/4] libxl: channels support

2016-09-20 Thread Joao Martins
On 09/20/2016 11:54 AM, Michal Privoznik wrote: > On 20.09.2016 12:43, Joao Martins wrote: >> On 09/20/2016 05:14 AM, Michal Privoznik wrote: >>> On 20.09.2016 00:04, Jim Fehlig wrote: On 09/16/2016 05:43 PM, Joao Martins wrote: > Hey, > > Additionally what does "state" > sign

Re: [libvirt] [PATCH v1 0/4] libxl: channels support

2016-09-20 Thread Michal Privoznik
On 20.09.2016 12:43, Joao Martins wrote: > On 09/20/2016 05:14 AM, Michal Privoznik wrote: >> On 20.09.2016 00:04, Jim Fehlig wrote: >>> On 09/16/2016 05:43 PM, Joao Martins wrote: Hey, Additionally what does "state" signify for virtio case: is it that the guest agent is conne

Re: [libvirt] [PATCH v1 2/4] libxl: channels support

2016-09-20 Thread Joao Martins
On 09/19/2016 11:57 PM, Jim Fehlig wrote: > On 09/16/2016 05:43 PM, Joao Martins wrote: >> And allow libxl to handle channel element which creates a Xen >> console visible to the guest as a low-bandwitdh communication >> channel. If type is PTY we also fetch the tty after boot using >> libxl_channe

Re: [libvirt] [PATCH v1 0/4] libxl: channels support

2016-09-20 Thread Joao Martins
On 09/20/2016 05:14 AM, Michal Privoznik wrote: > On 20.09.2016 00:04, Jim Fehlig wrote: >> On 09/16/2016 05:43 PM, Joao Martins wrote: >>> Hey, >>> >>> Channels have been on xen toolstack since Xen 4.5 and this small series >>> adds support for it, including xenconfig conversion and appropriate te

Re: [libvirt] [PATCH v3 1/2] qemu/gluster: add option for tuning debug logging level

2016-09-20 Thread Peter Krempa
On Tue, Sep 20, 2016 at 15:23:03 +0530, Prasanna Kumar Kalever wrote: > This helps in selecting log level of the gluster gfapi, output to stderr. > The option is 'gluster_debug_level', can be tuned by editing > '/etc/libvirt/qemu.conf' > > Debug levels ranges 0-9, with 9 being the most verbose, an

Re: [libvirt] [PATCH v3 2/2] qemu_capabilities: Introduce gluster specific debug capability

2016-09-20 Thread Peter Krempa
On Tue, Sep 20, 2016 at 15:23:04 +0530, Prasanna Kumar Kalever wrote: > Teach qemu driver to detect whether qemu supports this configuration > factor or not. > > Signed-off-by: Prasanna Kumar Kalever > --- > src/qemu/qemu_capabilities.c | 6 ++ > src/qemu/qemu_capabilities.h | 3 +++ > src

[libvirt] [PATCH v3 1/2] qemu/gluster: add option for tuning debug logging level

2016-09-20 Thread Prasanna Kumar Kalever
This helps in selecting log level of the gluster gfapi, output to stderr. The option is 'gluster_debug_level', can be tuned by editing '/etc/libvirt/qemu.conf' Debug levels ranges 0-9, with 9 being the most verbose, and 0 representing no debugging output. The default is the same as it was before,

[libvirt] [PATCH v3 2/2] qemu_capabilities: Introduce gluster specific debug capability

2016-09-20 Thread Prasanna Kumar Kalever
Teach qemu driver to detect whether qemu supports this configuration factor or not. Signed-off-by: Prasanna Kumar Kalever --- src/qemu/qemu_capabilities.c | 6 ++ src/qemu/qemu_capabilities.h | 3 +++ src/qemu/qemu_command.c | 13 - tests/qemuxml2argvtest.c | 3 ++- 4

[libvirt] [PATCH v3 0/2] qemu/gluster: add option for tuning debug logging level

2016-09-20 Thread Prasanna Kumar Kalever
v3: Add patch 2/2 which address capability checks Changed 'glusterfs_debug_level' to 'gluster_debug_level' agreeing to Peter Made changes in libvirtd_qemu.aug Thanks to Peter & Daniel v2: Modify test cases and syntax check changes as suggested by Peter in v1. Rename qemu_gfapi_debuglevel to gluste

Re: [libvirt] [Qemu-devel] [RFC v2] libvirt vGPU QEMU integration

2016-09-20 Thread Daniel P. Berrange
On Tue, Sep 20, 2016 at 02:05:52AM +0530, Kirti Wankhede wrote: > > Hi libvirt experts, > > Thanks for valuable input on v1 version of RFC. > > Quick brief, VFIO based mediated device framework provides a way to > virtualize their devices without SR-IOV, like NVIDIA vGPU, Intel KVMGT > and IBM's

Re: [libvirt] [PATCH] test: update capability replies for qemu-2.7.0

2016-09-20 Thread Pavel Hrdina
On Tue, Sep 20, 2016 at 10:47:18AM +0200, Andrea Bolognani wrote: > On Tue, 2016-09-20 at 10:44 +0200, Pavel Hrdina wrote: > > Signed-off-by: Pavel Hrdina > > --- > > .../qemucapabilitiesdata/caps_2.7.0.x86_64.replies | 39 > > -- > > 1 file changed, 29 insertions(+), 10 dele

Re: [libvirt] [PATCHv5 00/13] qemu: allow disabling certain virtio revisions

2016-09-20 Thread Cornelia Huck
On Mon, 19 Sep 2016 22:07:13 +0300 "Michael S. Tsirkin" wrote: > On Wed, Sep 07, 2016 at 09:38:04PM +0200, Sascha Silbe wrote: > > Dear Laine, > > > > Laine Stump writes: > > > > > On 09/07/2016 02:35 PM, Sascha Silbe wrote: > > >> "Daniel P. Berrange" writes: > > >> [...] > > >>>

Re: [libvirt] [PATCH] qemu_process: fix a typo

2016-09-20 Thread Andrea Bolognani
On Tue, 2016-09-20 at 15:37 +0800, Chen Hanxiao wrote: > From: Chen Hanxiao > > s/unitl/until > > Signed-off-by: Chen Hanxiao > --- > src/qemu/qemu_process.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c > index cecd

Re: [libvirt] [PATCH] test: update capability replies for qemu-2.7.0

2016-09-20 Thread Andrea Bolognani
On Tue, 2016-09-20 at 10:44 +0200, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > .../qemucapabilitiesdata/caps_2.7.0.x86_64.replies | 39 > -- > 1 file changed, 29 insertions(+), 10 deletions(-) > > diff --git a/tests/qemucapabilitiesdata/caps_2.7.0.x86_64.replie

[libvirt] [PATCH] test: update capability replies for qemu-2.7.0

2016-09-20 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- .../qemucapabilitiesdata/caps_2.7.0.x86_64.replies | 39 -- 1 file changed, 29 insertions(+), 10 deletions(-) diff --git a/tests/qemucapabilitiesdata/caps_2.7.0.x86_64.replies b/tests/qemucapabilitiesdata/caps_2.7.0.x86_64.replies index 7986da

[libvirt] [PATCH V2 3/4] qemu: Add domain support for VCPU halted state

2016-09-20 Thread Viktor Mihajlovski
Adding a field to the domain's private vcpu object to hold the halted state information. Adding two functions in support of the halted state: - qemuDomainGetVcpuHalted: retrieve the halted state from a private vcpu object - qemuDomainRefreshVcpuHalted: obtain the per-vcpu halted states via qemu

[libvirt] [PATCH V2 2/4] qemu: Add monitor support for CPU halted state

2016-09-20 Thread Viktor Mihajlovski
Extended the qemuMonitorCPUInfo with a halted flag. Extract the halted flag for both text and JSON monitor. Signed-off-by: Viktor Mihajlovski Signed-off-by: Boris Fiuczynski --- src/qemu/qemu_monitor.c | 6 +- src/qemu/qemu_monitor.h | 5 + src/qemu/qemu_monitor_json.c | 3 +++

[libvirt] [PATCH V2 4/4] qemu: Ensure reported VCPU state is current in driver API

2016-09-20 Thread Viktor Mihajlovski
Refresh the VCPU halted states in API functions returning domain VCPU state information to make sure it's current. This affects qemuDomainGetVcpus and qemuDomainGetStatsVcpu Signed-off-by: Viktor Mihajlovski Reviewed-by: Bjoern Walk Reviewed-by: Hao QingFeng Signed-off-by: Boris Fiuczynski --

  1   2   >