Re: [libvirt] [PATCH 0/7] Pass the path of compress program (redo)

On 09/21/2016 10:23 PM, Chen Hanxiao wrote: > > At 2016-09-22 05:30:48, "John Ferlan" wrote: >> Rather than try to describe what I was thinking about for the passing >> the compress program directly series from Chen Hanxiao: >> >>

Re: [libvirt] [PATCH 9/9] qemu_hotplug: Support interface type of vhost-user hotplug

On 08/16/2016 11:41 AM, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1366108 > > So far, the hotplug of vhost-user "worked" by pure chance. Well, > qemu would error on our commands, but nevertheless. Now that we > have everything prepare, We should support hotplugging

Re: [libvirt] [PATCH 8/9] qemuBuildHostNetStr: Support VIR_DOMAIN_NET_TYPE_VHOSTUSER

On 08/16/2016 11:41 AM, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1366505 > > So far, this function lacked support for > VIR_DOMAIN_NET_TYPE_VHOSTUSER leaving callers to hack around the > problem by constructing the command line on their own. This is > not ideal as

Re: [libvirt] [PATCH 7/9] qemuBuildVhostuserCommandLine: Unify -netdev creation

On 08/16/2016 11:41 AM, Michal Privoznik wrote: > Currently, what we do for vhost-user network is generate the > following part of command line: > > -netdev type=vhost-user,id=hostnet0,chardev=charnet0 > > There's no need for 'type=' it is the default. Drop it. > > Signed-off-by: Michal

Re: [libvirt] [PATCH 6/9] qemuBuildHostNetStr: Explicitly enumerate net types

On 08/16/2016 11:41 AM, Michal Privoznik wrote: > We tend to prevent using 'default' in switches. And it is for a > good reason - control may end up in paths we wouldn't want for > new values. In this specific case, if qemuBuildHostNetStr is > called over VIR_DOMAIN_NET_TYPE_VHOSTUSER it would

Re: [libvirt] [PATCH 4/9] qemuBuildVhostuserCommandLine: Reuse qemuBuildChrChardevStr

On 08/16/2016 11:41 AM, Michal Privoznik wrote: > There's no need to reinvent the wheel here. We already have a > function to format virDomainChrSourceDefPtr. It's called > qemuBuildChrChardevStr(). Use that instead of some dummy > virBufferAsprintf(). > > Signed-off-by: Michal Privoznik

Re: [libvirt] [PATCH 5/9] qemuBuildHostNetStr: Realign

On 08/16/2016 11:41 AM, Michal Privoznik wrote: > Signed-off-by: Michal Privoznik > --- > src/qemu/qemu_command.c | 64 > - > 1 file changed, 32 insertions(+), 32 deletions(-) > ACK John -- libvir-list mailing list

Re: [libvirt] [PATCH 3/9] qemuBuildChrChardevStr: Introduce @nowait argument

On 08/16/2016 11:41 AM, Michal Privoznik wrote: > This alone makes not much sense. But the aim is to reuse this > function in qemuBuildVhostuserCommandLine() where 'nowait' is not > supported for vhost-user devices. > > Signed-off-by: Michal Privoznik > --- >

Re: [libvirt] [PATCH 2/9] qemuDomain{Attach, Remove}NetDevice: Prefer qemuDomainSupportsNetdev

On 08/16/2016 11:41 AM, Michal Privoznik wrote: > Depending on domain OS type, and interface address type we might > not want to use -netdev even though qemu has the capability. We > should use more advanced check implemented in > qemuDomainSupportsNetdev() function. > > Signed-off-by: Michal

Re: [libvirt] [PATCH 1/9] qemuDomainAttachNetDevice: Explicitly list allowed types for hotplug

On 08/16/2016 11:41 AM, Michal Privoznik wrote: > Instead of blindly claim support for hot-plugging of every claiming > interface type out there we should copy approach we have for > device types: white listing supported types and explicitly error > out on unsupported ones. > For instance,

[libvirt] ANNOUNCE: ruby-libvirt 0.7.0

I'm pleased to release ruby-libvirt 0.7.0. ruby-libvirt is a ruby wrapper around the libvirt API. The changelog between 0.6.0 and 0.7.0 is: * Fix network lease API to allow arguments that libvirt allows * Implement VIRT_STORAGE_POOL_CREATE flags * Implement more VIR_STORAGE_VOL flags *

[libvirt] [PATCH] qemu: Fix improper indention

Commit id 'ce61c164' indented wrong - not sure how I did that... Signed-off-by: John Ferlan --- Pushed under the trivial rule src/qemu/qemu_command.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/src/qemu/qemu_command.c

[libvirt] [PATCH v2 0/4] libxl: channels support

Hey, This v2 from channel series. Since v1 path is now autogenerated as needed, and a few other comments from Jim that were addressed. Difference to qemu driver would be only the autogenerated path being slightly different. Channels have been on xen toolstack since Xen 4.5 and this small series

[libvirt] [PATCH v2 1/4] conf: add xen type for channels

So far only guestfwd and virtio were supported. Add an additional for Xen as libxl channels create Xen console visible to the guest. Signed-off-by: Joao Martins --- docs/schemas/domaincommon.rng | 11 +++ src/conf/domain_conf.c| 18 ++

[libvirt] [PATCH v2 3/4] xenconfig: channels conversion support

Add support for formating/parsing libxl channels. Syntax on xen libxl goes as following: channel=["connection=pty|socket,path=/path/to/socket,name=XXX",...] Signed-off-by: Joao Martins --- Changes since v1: * Move path to UNIX case. --- src/xenconfig/xen_xl.c | 176

[libvirt] [PATCH v2 4/4] xlconfigtest: add test for channel conversion

Signed-off-by: Joao Martins --- tests/xlconfigdata/test-channel-pty.cfg | 13 tests/xlconfigdata/test-channel-pty.xml | 33 +++ tests/xlconfigdata/test-channel-unix.cfg | 13

[libvirt] [PATCH v2 2/4] libxl: channels support

Allow libxl to handle channel element which creates a Xen console visible to the guest as a low-bandwitdh communication channel. If type is PTY we also fetch the tty after boot using libxl_channel_getinfo to fetch the tty path. On socket case, we autogenerate a path if not specified in the XML.

[libvirt] [PATCH] Replacing for (; ; ) with while (1) for better code.

As mentioned in https://libvirt.org/hacking.html, using while (1) is better than for (;;). --- src/libvirt-stream.c| 4 ++-- src/phyp/phyp_driver.c | 2 +- src/qemu/qemu_migration.c | 2 +- src/remote/remote_driver.c | 2 +- src/rpc/virnetclient.c | 6

Re: [libvirt] [RFC v2] libvirt vGPU QEMU integration

> From: Kirti Wankhede [mailto:kwankh...@nvidia.com] > Sent: Wednesday, September 21, 2016 12:23 AM > > > >>> I have > >>> a hard time believing that a given vendor can even allocate unique type > >>> ids for their own devices. Unique type id across vendors is not > >>> practical. So which

Re: [libvirt] Cpu Modeling

Hi! On Thu, Sep 22, 2016 at 02:47:36PM -0400, Jason J. Herne wrote: > Hi Jiri & Eduardo, > > You might remember a discussion with David Hildenbrand of IBM on the Qemu > mailing list regarding a new Qemu<->Libvirt interface for cpu modeling. I am > picking up this work from David and I wanted to

[libvirt] Cpu Modeling

Hi Jiri & Eduardo, You might remember a discussion with David Hildenbrand of IBM on the Qemu mailing list regarding a new Qemu<->Libvirt interface for cpu modeling. I am picking up this work from David and I wanted to confirm that we are still on the same page as to the direction of that

Re: [libvirt] [PATCH] Fix Multiple Typos

On 09/22/2016 06:33 AM, Nitesh Konkar wrote: > Signed-off-by: Nitesh Konkar > --- > src/conf/domain_conf.c | 4 ++-- > src/conf/domain_conf.h | 2 +- > src/conf/storage_conf.c| 2 +- > src/esx/esx_driver.c

Re: [libvirt] [PATCH v2] qemu: enable user-defined cache bypassing while invoking

On 08/26/2016 02:56 AM, fuweiwei wrote: > in the previous version, I mentioned the scenario of long-term pause while > writing external memory checkpoints: > > v1: https://www.redhat.com/archives/libvir-list/2016-August/msg01194.html It would seem the above link has a better explanation as to

[libvirt] [PATCH 7/8] qemuhelptest: regenerate data for qemu-kvm-0.13.0

Signed-off-by: Pavel Hrdina --- tests/qemuhelpdata/qemu-kvm-0.13.0| 1 - tests/qemuhelpdata/qemu-kvm-0.13.0-device | 4 +--- tests/qemuhelptest.c | 3 --- 3 files changed, 1 insertion(+), 7 deletions(-) diff --git

[libvirt] [PATCH 8/8] qemuhelptest: regenerate data for qemu-kvm-1.2.0

Signed-off-by: Pavel Hrdina --- tests/qemuhelpdata/qemu-kvm-1.2.0 | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qemuhelpdata/qemu-kvm-1.2.0 b/tests/qemuhelpdata/qemu-kvm-1.2.0 index 372002a..08c3f93 100644 --- a/tests/qemuhelpdata/qemu-kvm-1.2.0 +++

[libvirt] [PATCH 0/8] cleanup and regenerate data for qemuhelptest

Pavel Hrdina (8): qemuhelptest: remove downstream test data qemuhelptest: regenerate data for qemu-0.12.1 qemuhelptest: regenerate data for qemu-1.0 qemuhelptest: regenerate data for qemu-1.1.0 qemuhelptest: regenerate data for qemu-1.2.0 qemuhelptest: regenerate data for

[libvirt] [PATCH 6/8] qemuhelptest: regenerate data for qemu-kvm-0.12.3

Signed-off-by: Pavel Hrdina --- tests/qemuhelpdata/qemu-kvm-0.12.3| 7 ++-- tests/qemuhelpdata/qemu-kvm-0.12.3-device | 63 +++ tests/qemuhelptest.c | 20 +- 3 files changed, 84 insertions(+), 6 deletions(-)

[libvirt] [PATCH 4/8] qemuhelptest: regenerate data for qemu-1.1.0

Signed-off-by: Pavel Hrdina --- tests/qemuhelpdata/qemu-1.1.0| 1 + tests/qemuhelpdata/qemu-1.1.0-device | 20 ++-- 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/tests/qemuhelpdata/qemu-1.1.0 b/tests/qemuhelpdata/qemu-1.1.0 index

[libvirt] [PATCH 5/8] qemuhelptest: regenerate data for qemu-1.2.0

This patch also removes device data for qemu-1.2.0 as it was removed for qemu-kvm-1.2.0 by commit ae3e29e6e. They are not required because we parse only version from help output and return with error that this qemu is too new to use help parsing. Signed-off-by: Pavel Hrdina

[libvirt] [PATCH 2/8] qemuhelptest: regenerate data for qemu-0.12.1

Signed-off-by: Pavel Hrdina --- tests/qemuhelpdata/qemu-0.12.1| 7 +--- tests/qemuhelpdata/qemu-0.12.1-device | 62 +++ tests/qemuhelptest.c | 18 +- 3 files changed, 80 insertions(+), 7 deletions(-) diff

[libvirt] [PATCH 3/8] qemuhelptest: regenerate data for qemu-1.0

Signed-off-by: Pavel Hrdina --- tests/qemuhelpdata/qemu-1.0| 1 + tests/qemuhelpdata/qemu-1.0-device | 146 ++--- 2 files changed, 74 insertions(+), 73 deletions(-) diff --git a/tests/qemuhelpdata/qemu-1.0

[libvirt] [PATCH 1/8] qemuhelptest: remove downstream test data

Signed-off-by: Pavel Hrdina --- tests/qemuhelpdata/qemu-kvm-0.12.1.2-rhel60| 227 tests/qemuhelpdata/qemu-kvm-0.12.1.2-rhel60-device | 57 - tests/qemuhelpdata/qemu-kvm-0.12.1.2-rhel61| 229

[libvirt] [PATCH 1/2] vz: add serial number to disk devices

vz sdk supports setting serial number only for disk devices. Getting serial upon cdrom(for example) is error however setting is just ignored. Let's check for disk device explicitly for clarity in both cases. Setting serial number for other devices is ignored with an info note just as before. We

[libvirt] [PATCH 0/2] vz: add serial number to disk devices

Only the first patch is really on the subject. The second one is bugfix that is included mainly because it touches the same place (and nice to have to test first patch too...) Nikolay Shirokovskiy (2): vz: add serial number to disk devices vz: set something in disk driver name

[libvirt] [PATCH 2/2] vz: set something in disk driver name

Absent driver name attribute is invalid xml. Which in turn makes unusable 'virsh edit' for example. The value does not make much sense and ignored on input so nobody will hurt. --- src/vz/vz_sdk.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c index

Re: [libvirt] [RFC v2] libvirt vGPU QEMU integration

On Thu, Sep 22, 2016 at 08:19:21AM -0600, Alex Williamson wrote: > On Thu, 22 Sep 2016 09:41:20 +0530 > Kirti Wankhede wrote: > > > > My concern is that a type id seems arbitrary but we're specifying that > > > it be unique. We already have something unique, the

Re: [libvirt] [RFC v2] libvirt vGPU QEMU integration

On Thu, 22 Sep 2016 09:41:20 +0530 Kirti Wankhede wrote: > > My concern is that a type id seems arbitrary but we're specifying that > > it be unique. We already have something unique, the name. So why try > > to make the type id unique as well? A vendor can

Re: [libvirt] [PATCHv2] qemu: agent: Fix QEMU guest agent is not available due to an error

Cc'ed Michal and Nikolay. On Wed, Sep 21, 2016 at 07:01:37AM -0400, John Ferlan wrote: > On 07/07/2016 05:53 AM, Xiubo Li wrote: > > > > src/qemu/qemu_agent.c | 37 - > > src/util/virjson.h| 7 +++ > > 2 files changed, 35 insertions(+), 9

Re: [libvirt] [PATCH 0/9] Couple of migration fixes

On 22.09.2016 15:39, Jiri Denemark wrote: > On Tue, Sep 20, 2016 at 15:54:54 +0200, Michal Privoznik wrote: >> Looks like nobody tried migrations lately. > > This statement sounds a bit too strong for such a narrow use case. > >> I just did and found >> interesting bug. On the destination qemu

Re: [libvirt] [PATCH v2 00/45] Enhance guest CPU configuration code

On Thu, Sep 22, 2016 at 08:48:16 -0400, John Ferlan wrote: > [...] > > ACK series, Pushed, thanks a lot for the review. Jirka -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/9] Couple of migration fixes

On Tue, Sep 20, 2016 at 15:54:54 +0200, Michal Privoznik wrote: > Looks like nobody tried migrations lately. This statement sounds a bit too strong for such a narrow use case. > I just did and found > interesting bug. On the destination qemu binary was at different > path. So I've dumped domain

Re: [libvirt] [PATCH v2 00/45] Enhance guest CPU configuration code

On 09/19/2016 09:30 AM, Jiri Denemark wrote: > Version 2: > - review comments addressed; see individual patches for details > > This patch series does several things: > > - fixes tests to avoid relying on bugs in our code > - adds support for advertising supported CPU modes and models in

Re: [libvirt] [libvirt-php][PATCH 0/2] Couple of example fixes

On Wed, Sep 21, 2016 at 05:33:50PM +0200, Michal Privoznik wrote: Pushed under "I'm the PHP master" rule. LOL, ACK series, then, I guess =D Michal Privoznik (2): examples: Sort domains examples: Die early if getting a screenshot fails examples/index.php | 2 +- examples/libvirt.php | 8

Re: [libvirt] [PATCH] qemu: fix libvirtd crash in migration after vm shutdown

On Thu, Sep 22, 2016 at 11:56:38 +0200, Jiri Denemark wrote: > On Tue, Aug 02, 2016 at 02:20:51 +, weifuqiang wrote: > > [PATCH] qemu: fix libvirtd crash in migration after vm shutdown > > > > > > > > > > > > If we shutdown a guest, then migrate it without the arg XML, libvirtd will > >

Re: [libvirt] [PATCH 6/7] qemu: Support newer ivshmem device variants

On Thu, Sep 22, 2016 at 01:09:20PM +0200, Martin Kletzander wrote: > On Wed, Sep 21, 2016 at 04:26:31PM +0100, Daniel P. Berrange wrote: > > On Wed, Sep 21, 2016 at 05:10:09PM +0200, Martin Kletzander wrote: > > > On Wed, Sep 21, 2016 at 04:01:23PM +0100, Daniel P. Berrange wrote: > > > > I'm not

Re: [libvirt] [PATCH v2 0/3] pass the path of compress prog directly

At 2016-09-22 19:05:33, "John Ferlan" wrote: > >>> >>> BTW: Patch 2 fails syntax-check >>> >> >> I make syntax-check again and passed on a centos7 machine. >> Maybe it's a syntax-check bug? >> > >Don't think so... > > >cppi: src/qemu/qemu_driver.c: line 3269: not properly

Re: [libvirt] [PATCH 6/7] qemu: Support newer ivshmem device variants

On Wed, Sep 21, 2016 at 04:26:31PM +0100, Daniel P. Berrange wrote: On Wed, Sep 21, 2016 at 05:10:09PM +0200, Martin Kletzander wrote: On Wed, Sep 21, 2016 at 04:01:23PM +0100, Daniel P. Berrange wrote: > I'm not a fan of the idea of silently picking a different device > for the guest behind

Re: [libvirt] [PATCH v2 0/3] pass the path of compress prog directly

>> >> BTW: Patch 2 fails syntax-check >> > > I make syntax-check again and passed on a centos7 machine. > Maybe it's a syntax-check bug? > Don't think so... cppi: src/qemu/qemu_driver.c: line 3269: not properly indented maint.mk: incorrect preprocessor indentation cfg.mk:680: recipe for

[libvirt] [PATCH] virsh domdisplay: introduce '--all' for showing all possible graphical display

From: Chen Hanxiao For one VM, it could have more than one graphical display. Such as we coud add both vnc and spice display to a VM. This patch introduces '--all' for showing all possible type of graphical display for a active VM. Signed-off-by: Chen Hanxiao

Re: [libvirt] [PATCH 0/7] Fix some typos.

Thanks for the feedback. I have now sent them as a single patch. On Thu, Sep 22, 2016 at 12:52 PM, Peter Krempa wrote: > On Thu, Sep 22, 2016 at 03:33:39 +0530, Nitesh Konkar wrote: > > *** BLURB HERE *** > > > > Nitesh Konkar (7): > > domain_conf.c:fix a typo > >

[libvirt] [PATCH] Fix Multiple Typos

Signed-off-by: Nitesh Konkar --- src/conf/domain_conf.c | 4 ++-- src/conf/domain_conf.h | 2 +- src/conf/storage_conf.c| 2 +- src/esx/esx_driver.c | 4 ++-- src/interface/interface_backend_udev.c | 2

Re: [libvirt] [PATCH] qemu: fix libvirtd crash in migration after vm shutdown

On Tue, Aug 02, 2016 at 02:20:51 +, weifuqiang wrote: > [PATCH] qemu: fix libvirtd crash in migration after vm shutdown > > > > > > If we shutdown a guest, then migrate it without the arg XML, libvirtd will > get crashed. > > > > The reason is that: > > 1 during shutdown callback,

Re: [libvirt] [PATCH 2/4] daemon: call free callbacks synchronously in event loop impl

On 22.09.2016 11:44, Daniel P. Berrange wrote: > On Thu, Sep 22, 2016 at 11:38:50AM +0300, Nikolay Shirokovskiy wrote: >> Default event loop impl delays deleting registered handles and >> timeouts so that deleting is safe from event handlers. But >> this means deletions after event loop is

Re: [libvirt] [PATCH 2/4] daemon: call free callbacks synchronously in event loop impl

On Thu, Sep 22, 2016 at 11:38:50AM +0300, Nikolay Shirokovskiy wrote: > Default event loop impl delays deleting registered handles and > timeouts so that deleting is safe from event handlers. But > this means deletions after event loop is finished will never > occur and particularly assosiated

[libvirt] [PATCH 0/4] fix some libvirtd cleanup leaks and crashes

Crash situation of last 2 patches can easily simulated, just patch libvirt: diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 30a2830..f6b71d6 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -4515,6 +4515,8 @@ processMonitorEOFEvent(virQEMUDriverPtr driver,

[libvirt] [PATCH 3/4] daemon: keep daemon until all hypervisors drivers are cleaned up

This fix SEGV with next backtrace (shortened a bit): 1 0x7fd3a791b2e6 in virCondWait (c=, m=) at util/virthread.c:154 2 0x7fd3a791bcb0 in virThreadPoolFree (pool=0x7fd38024ee00) at util/virthreadpool.c:266 3 0x7fd38edaa00e in qemuStateCleanup () at qemu/qemu_driver.c:1116 4

[libvirt] [PATCH 4/4] qemu: first wait all workers finish on state cleanup

This fix next crash (bt is shortened a bit): 0 0x77282f2b in virClassIsDerivedFrom (klass=0xdeadbeef, parent=0x5581d650) at util/virobject.c:169 1 0x772835fd in virObjectIsClass (anyobj=0x7fffd024f580, klass=0x5581d650) at util/virobject.c:365 2 0x77283498 in

[libvirt] [PATCH 1/4] daemon: break cyclic deps between admin clients and daemon

Libvirtd daemon cleanup is not correct in case there are admin server clients connected at the moment libvirtd exits. The reason is that there is cyclic dependency: daemon holds references to its network servers, networks servers hold references to its clients, admin server clients hold refs to

[libvirt] [PATCH 2/4] daemon: call free callbacks synchronously in event loop impl

Default event loop impl delays deleting registered handles and timeouts so that deleting is safe from event handlers. But this means deletions after event loop is finished will never occur and particularly assosiated callback objects will not be freed. For this reason network clients that exist at

Re: [libvirt] [PATCH 0/7] Fix some typos.

On Thu, Sep 22, 2016 at 03:33:39 +0530, Nitesh Konkar wrote: > *** BLURB HERE *** > > Nitesh Konkar (7): > domain_conf.c:fix a typo > domain_conf.h:fix a typo > domain_conf.c:fix a typo > storage_conf.c:fix a typo > interface_backend_udev.c:fix a typo > esx_driver.c:fix a typo >