On 28.09.2016 00:53, John Ferlan wrote:
>
>
> On 09/27/2016 04:17 AM, Nikolay Shirokovskiy wrote:
>>
>>
>> On 26.09.2016 23:07, John Ferlan wrote:
>>>
>>>
>>> On 09/07/2016 05:24 AM, Nikolay Shirokovskiy wrote:
---
src/qemu/qemu_domain.h | 1 +
src/qemu/qemu_monitor_json.
On 27.09.2016 01:04, John Ferlan wrote:
>
>
> On 09/07/2016 05:24 AM, Nikolay Shirokovskiy wrote:
>> Add API to start/stop exporting disks for a backup and add qemu
>> implementation.
>>
>> The latter is not complete yet. At least backup disks are not
>> cleaned up and libvirt restart is not ha
Commit 6c504d6a added a note to the virsh man page about the
deprecation of 'cap' and 'weight' settings for the credit
scheduler. To this day, the default scheduler in Xen is credit
and it supports setting 'cap' and 'weight'. Remove the deprecation
notice from the note on the Xen credit scheduler.
On 09/27/2016 03:27 AM, Volo M. wrote:
> Hi Devs,
>
> We're using Centos 7 Xen hypervisors and try to use Libvirt(libxl) for
> managing Xen guest domains.
> We noticed that we can't set cpu weight values for Xen domains with libvirt
> (tested for libvirt v.1.3 and v.2.2) even though its possible to
Due to a copy and paste error, the scheduler 'cap' parameter
was over-writing the 'weight' parameter when preparing the
return parameters in libxlDomainGetSchedulerParametersFlags.
As a result, the scheduler weight was never shown when getting
schedinfo and setting the weight failed as well
virsh
On Fri, Sep 23, 2016 at 03:20:56PM +0200, Martin Kletzander wrote:
> If this reminds you of a commit message from around a year ago, it's
> 41c2aa729f0af084ede95ee9a06219a2dd5fb5df and yes, we're dealing with
> "the same thing" again. Or f309db1f4d51009bad0d32e12efc75530b66836b and
> it's similar.
Joao Martins wrote:
> Hey,
>
> This v3 from channel series with latest comments addressed. Difference to
> qemu driver would be only the autogenerated path being slightly different.
>
> Channels have been on xen toolstack since Xen 4.5 and this small series
> adds support for it, including xencon
On 09/27/2016 04:17 AM, Nikolay Shirokovskiy wrote:
>
>
> On 26.09.2016 23:07, John Ferlan wrote:
>>
>>
>> On 09/07/2016 05:24 AM, Nikolay Shirokovskiy wrote:
>>> ---
>>> src/qemu/qemu_domain.h | 1 +
>>> src/qemu/qemu_monitor_json.c | 17 +
>>> tests/qemumonitorjsontest
On 09/27/2016 01:25 PM, Jiri Denemark wrote:
> The qemucapsprobe helper calls virQEMUCapsNewForBinaryInternal with
> caps == NULL, causing the following crash:
>
> Program received signal SIGSEGV, Segmentation fault.
> #0 0x7788775f in virQEMUCapsInitHostCPUModel
> (qemu
On 09/27/2016 12:53 PM, Ján Tomko wrote:
> On Fri, Sep 23, 2016 at 07:30:54AM -0400, John Ferlan wrote:
>> Let's do some more code reuse - there are 3 other callers that care to
>> check/get the compress program. Each of those though cares whether the
>> requested cfg image is valid and exists. S
On 09/27/2016 12:40 PM, Ján Tomko wrote:
> On Fri, Sep 23, 2016 at 07:30:51AM -0400, John Ferlan wrote:
>> Split out the guts of getCompressionType to perform the same
>> functionality
>> in the new helper program with a subsequent patch goal to be reusable for
>> other callers making similar che
Since nobody complained about my earlier message with the release plan,
I tagged libvirt-2.3.0 candidate release 1 in git and pushed signed tarball
and rpms to the usual place:
ftp://libvirt.org/libvirt/
As usual my limited testing is really not sufficient so please give it a try,
I enjoy t
Signed-off-by: Nitesh Konkar
---
src/libvirt-storage.c | 24
1 file changed, 16 insertions(+), 8 deletions(-)
diff --git a/src/libvirt-storage.c b/src/libvirt-storage.c
index 48996ba..c4f2a03 100644
--- a/src/libvirt-storage.c
+++ b/src/libvirt-storage.c
@@ -233,7 +233,8
The qemucapsprobe helper calls virQEMUCapsNewForBinaryInternal with
caps == NULL, causing the following crash:
Program received signal SIGSEGV, Segmentation fault.
#0 0x7788775f in virQEMUCapsInitHostCPUModel
(qemuCaps=qemuCaps@entry=0x649680, host=host@entry=0x10) at
On Fri, Sep 23, 2016 at 07:30:54AM -0400, John Ferlan wrote:
Let's do some more code reuse - there are 3 other callers that care to
check/get the compress program. Each of those though cares whether the
requested cfg image is valid and exists. So, add a parameter to handle
those cases.
NB: We wo
Until now the test was rather useless since it didn't check the
arguments formatted and didn't use properly configured chardev objects.
Add the expected arguments and instrument the test to validate them.
Modify some test cases to actually add valid data.
Note that the UDP test data is currently
---
src/qemu/qemu_monitor_json.c | 39 +++
1 file changed, 15 insertions(+), 24 deletions(-)
diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c
index e1494df..126927e 100644
--- a/src/qemu/qemu_monitor_json.c
+++ b/src/qemu/qemu_monitor_js
On Fri, Sep 23, 2016 at 07:30:51AM -0400, John Ferlan wrote:
Split out the guts of getCompressionType to perform the same functionality
in the new helper program with a subsequent patch goal to be reusable for
other callers making similar checks/calls to ensure the compression type
is valid and t
Since introduction of chardev hotplug the code was wrong for the UDP
case and basically created a TCP socket instead. Use proper objects and
type for UDP.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1377602
---
src/qemu/qemu_monitor_json.c | 12 ++--
tests/qemumonitorjsontest.c
Most of the time qemumonitorjson test isn't really testing much. Add support
for actually testing chardev hotplug and fix it for the UDP case.
Peter Krempa (6):
conf: Sanitize formatting of UDP chardev source
tests: qemu: Add support for testing aguments on monitor verbatim
tests: qemumonito
The chardev attach test would do all the tests in one virTestRun
instance. If one sub-test failed then the test would report failure
improperly and the error would be hard to debug since the error pointer
was overwritten.
---
tests/qemumonitorjsontest.c | 147 ++
Use much simpler logic to determine parts of the code to print.
---
src/conf/domain_conf.c | 42 --
1 file changed, 16 insertions(+), 26 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index a06da46..3f34540 100644
--- a/src/conf/d
Add code that takes a string and matches it against the data passed as
arguments from qemu. This is a simpler version of
qemuMonitorTestAddItemParams.
---
tests/qemumonitortestutils.c | 112 +++
tests/qemumonitortestutils.h | 6 +++
2 files changed, 118 in
On 23.09.2016 14:56, John Ferlan wrote:
> Modify _virDomainBlockIoTuneInfo and rng schema to support the _length
> options for bps/iops throttling values. Document the new values.
>
> Signed-off-by: John Ferlan
> ---
> docs/formatdomain.html.in | 40 -
> docs
On 23.09.2016 14:56, John Ferlan wrote:
> Add support for a duration/length for the bps/iops and friends.
>
> Modify the API in order to add the "blkdeviotune." specific definitions
> for the iotune throttling duration/length options
>
> total_bytes_sec_max_length
> write_bytes_sec_max_le
On 23.09.2016 14:56, John Ferlan wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1349898
>
> Do a little housekeeping and minor adjustments to existing code, then
> add the various "-length" options for the code.
>
>
> John Ferlan (12):
> docs: Fix typo in libvirt-domain.h parameter desc
Martin Kletzander wrote:
> On Wed, Sep 21, 2016 at 03:29:49PM -0600, Jim Fehlig wrote:
>> libxl events are delivered to libvirt via the libxlDomainEventHandler
>> callback registered with libxl. Documenation in
>> $xensrc/tools/libxl/libxl_event.h states that the callback "may occur
>> on any threa
On 23.09.2016 14:56, John Ferlan wrote:
> Modify _virDomainBlockIoTuneInfo and rng schema to support the _length
> options for bps/iops throttling values. Document the new values.
>
> Signed-off-by: John Ferlan
> ---
> docs/formatdomain.html.in | 40 -
> docs
On Tue, Sep 27, 2016 at 08:25:05 -0400, John Ferlan wrote:
>
>
> On 09/27/2016 07:47 AM, Jiri Denemark wrote:
> > The qemucapsprobe helper calls virQEMUCapsInitHostCPUModel with
> > caps == NULL, causing the following crash:
> >
> > Program received signal SIGSEGV, Segmentation fault.
> >
On 23.09.2016 15:20, Martin Kletzander wrote:
> If this reminds you of a commit message from around a year ago, it's
> 41c2aa729f0af084ede95ee9a06219a2dd5fb5df and yes, we're dealing with
> "the same thing" again. Or f309db1f4d51009bad0d32e12efc75530b66836b and
> it's similar.
>
> There is a logi
On 22.09.2016 12:43, Chen Hanxiao wrote:
> From: Chen Hanxiao
>
> For one VM, it could have more than one graphical display.
> Such as we coud add both vnc and spice display to a VM.
>
> This patch introduces '--all' for showing all
> possible type of graphical display for a active VM.
>
> Sign
Signed-off-by: Jiri Denemark
---
Pushed as trivial.
mingw-libvirt.spec.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/mingw-libvirt.spec.in b/mingw-libvirt.spec.in
index c8476d9..c9bf503 100644
--- a/mingw-libvirt.spec.in
+++ b/mingw-libvirt.spec.in
@@ -210,6 +210,7 @@ rm -rf
$RPM_BUIL
On 27.09.2016 15:11, Michal Privoznik wrote:
> Move out some macros that are shared between multiple source
> files into a separate file called util.h.
>
> Signed-off-by: Michal Privoznik
> ---
> src/Makefile.am | 1 +
> src/libvirt-php.c | 19 +
> src/libvirt-php.h | 39 -
So far there is just one function shared across our code:
get_datetime().
Signed-off-by: Michal Privoznik
---
src/Makefile.am | 2 +-
src/config.m4 | 2 +-
src/libvirt-php.c | 26 --
src/util.c| 41 +
src/util.h
Move out some macros that are shared between multiple source
files into a separate file called util.h.
Signed-off-by: Michal Privoznik
---
src/Makefile.am | 1 +
src/libvirt-php.c | 19 +
src/libvirt-php.h | 39 --
src/sockets.c | 1 +
src/
Signed-off-by: Michal Privoznik
---
src/Makefile.am | 2 +-
src/libvirt-php.c | 6 +-
src/libvirt-php.h | 5 -
src/sockets.c | 1 +
src/sockets.h | 32
src/vncfunc.c | 1 +
6 files changed, 36 insertions(+), 11 deletions(-)
create mode
Each single file in our source code redefines the same DPRINTF
macro. What we want instead is to have the macro shared and also
we might to avoid global variable shared across all the code.
Signed-off-by: Michal Privoznik
---
src/libvirt-php.c | 15 ++-
src/sockets.c | 9 +--
There is no need to have this macro in the header file. It's used
in one place after all.
Signed-off-by: Michal Privoznik
---
src/libvirt-php.h | 3 ---
src/vncfunc.c | 3 +++
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/libvirt-php.h b/src/libvirt-php.h
index 0cd160f..
The point is, libvirt-php.c uses vnc functions implemented in
vncfunc.c, but for some weird historical reasons, it was
vncfunc.c who included libvirt-php.h.
Signed-off-by: Michal Privoznik
---
src/libvirt-php.h | 21 -
src/vncfunc.c | 32 +++-
Instead of forward declaration of some vnc_* functions from
vncfunc.c lets have a separate header file for that purpose.
Signed-off-by: Michal Privoznik
---
src/Makefile.am | 2 +-
src/libvirt-php.c | 3 +--
src/libvirt-php.h | 5 -
src/vncfunc.c | 1 +
src/vncfunc.h | 38 +
In order to bring some order to the source code, lets start with
marking static functions as static.
Signed-off-by: Michal Privoznik
---
src/vncfunc.c | 36
1 file changed, 24 insertions(+), 12 deletions(-)
diff --git a/src/vncfunc.c b/src/vncfunc.c
index 70
There is no need to have this macro in the header file. It's used
in one place after all.
Signed-off-by: Michal Privoznik
---
src/libvirt-php.c | 3 +++
src/libvirt-php.h | 3 ---
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/libvirt-php.c b/src/libvirt-php.c
index 693f911..
And at the same time switch from "header.h" notation to
.
Signed-off-by: Michal Privoznik
---
configure.ac | 1 +
src/libvirt-php.c | 5 +++--
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/configure.ac b/configure.ac
index 8d52862..f232756 100644
--- a/configure.ac
+++ b/co
These are not pushed yet as they might be somewhat controversial.
I'll wait if somebody wants to review them.
The ultimate goal is to, well drop libvirt-php.h completely. It
is needless. But before going there we must distribute the
interesting parts from it around. Therefore I'm introducing some
Just like in the previous commit, socket is offering its
functions to the rest of the code and therefore it should not
include libvirt-php.h.
Signed-off-by: Michal Privoznik
---
src/libvirt-php.h | 5 -
src/sockets.c | 17 -
2 files changed, 16 insertions(+), 6 deletions
Signed-off-by: Jiri Denemark
---
Pushed as trivial.
mingw-libvirt.spec.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/mingw-libvirt.spec.in b/mingw-libvirt.spec.in
index 5c7183f..c8476d9 100644
--- a/mingw-libvirt.spec.in
+++ b/mingw-libvirt.spec.in
@@ -292,6 +292,7 @@ rm -rf
$RPM_BUIL
On Tue, Sep 27, 2016 at 01:47:10PM +0200, Jiri Denemark wrote:
The qemucapsprobe helper calls virQEMUCapsInitHostCPUModel with
caps == NULL, causing the following crash:
Program received signal SIGSEGV, Segmentation fault.
#0 0x7788775f in virQEMUCapsInitHostCPUModel
(qemuC
This is needed in order to migrate a domain with shmem devices as that
is not allowed to migrate.
Signed-off-by: Martin Kletzander
---
src/qemu/qemu_driver.c | 39 +++-
src/qemu/qemu_hotplug.c| 247 -
src/qemu/qemu_hotp
On 09/27/2016 07:47 AM, Jiri Denemark wrote:
> The qemucapsprobe helper calls virQEMUCapsInitHostCPUModel with
> caps == NULL, causing the following crash:
>
> Program received signal SIGSEGV, Segmentation fault.
> #0 0x7788775f in virQEMUCapsInitHostCPUModel
> (qemuCaps
The old ivshmem is deprecated in QEMU, so let's use the better
ivshmem-{plain,doorbell} variants instead.
Signed-off-by: Martin Kletzander
---
docs/schemas/domaincommon.rng | 2 ++
src/conf/domain_conf.c| 4 +++-
src/conf/domain_conf.h| 2 ++
src/qemu/qemu_command.c | 7 +++
Just the default one now, new ones will be added in following commits.
Signed-off-by: Martin Kletzander
---
docs/schemas/domaincommon.rng | 9 +
src/conf/domain_conf.c| 44 +--
src/conf/domain_conf.h
It was never safe anyway and as such shouldn't have been enabled in the
first place. Future patches will allow hot-(un)pluging of some ivshmem
devices as a workaround.
Signed-off-by: Martin Kletzander
---
src/qemu/qemu_migration.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/qe
Signed-off-by: Martin Kletzander
---
src/qemu/qemu_capabilities.c| 4
src/qemu/qemu_capabilities.h| 2 ++
tests/qemucapabilitiesdata/caps_2.6.0-gicv2.aarch64.xml | 2 ++
tests/qemucapabilitiesdata/caps_2.6.0-gicv3.aarch64.xml | 2 ++
te
Due to the switch of parameters in a call to virDomainShmemDefEquals()
no device was found when looking for device with all the information
except address. Also fix the indentation.
Signed-off-by: Martin Kletzander
---
src/conf/domain_conf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletion
We're keeping some things at default and that's not something we want to
do intentionaly. Let's save some sensible defaults upfront then having
problems later. The details for the defaults (of the newer
implementation) can be found in qemu's commit 5400c02b90bb:
http://git.qemu.org/?p=qemu.git
QEMU added support for ivshmem-plain and ivshmem-doorbell. Those are
reworked varians of legacy ivshmem that are compatible from the guest
POV, but not from host's POV and have sane specification and handling.
Details about the newer device type can be found in qemu's commit
5400c02b90bb:
http
In this version we bring back the model, but disable migration for now.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1347049
Martin Kletzander (8):
conf: Fix virDomainShmemDefFind
qemu: Disable migration with ivshmem
conf, qemu: Add support for shmem model
conf, qemu: Add newer
The qemucapsprobe helper calls virQEMUCapsInitHostCPUModel with
caps == NULL, causing the following crash:
Program received signal SIGSEGV, Segmentation fault.
#0 0x7788775f in virQEMUCapsInitHostCPUModel
(qemuCaps=qemuCaps@entry=0x649680, host=host@entry=0x10) at
Signed-off-by: Jiri Denemark
---
Pushed as trivial.
libvirt.spec.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index a389e88..00b95b8 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -1814,6 +1814,7 @@ exit 0
%{_datadir}/libvirt/schemas/basicty
On Tue, Sep 27, 2016 at 09:51:41AM +0100, Daniel P. Berrange wrote:
enum types are unsigned and the qemuGetCompressionProgram
function can return -1 on error. It is therefore inappropriate
to return an enum type. This fixes a build error where the
internal 'ret' variable was used in a comparison
Hi Devs,
We're using Centos 7 Xen hypervisors and try to use Libvirt(libxl) for
managing Xen guest domains.
We noticed that we can't set cpu weight values for Xen domains with libvirt
(tested for libvirt v.1.3 and v.2.2) even though its possible to do with XL
toolkit.
[root@hv1xen ~]# virsh schedi
On 26.09.2016 23:07, John Ferlan wrote:
>
>
> On 09/07/2016 05:24 AM, Nikolay Shirokovskiy wrote:
>> Special error code helps gracefully handle race conditions on
>> blockjob cancelling. Consider for example pull backup. We want
>> to stop it and in the process we cancel blockjob for some of th
enum types are unsigned and the qemuGetCompressionProgram
function can return -1 on error. It is therefore inappropriate
to return an enum type. This fixes a build error where the
internal 'ret' variable was used in a comparison with -1
../../src/qemu/qemu_driver.c: In function 'qemuGetCompression
On 26.09.2016 23:07, John Ferlan wrote:
>
>
> On 09/07/2016 05:24 AM, Nikolay Shirokovskiy wrote:
>> ---
>> src/qemu/qemu_domain.h | 1 +
>> src/qemu/qemu_monitor_json.c | 17 +
>> tests/qemumonitorjsontest.c | 36
>> 3 files changed
CCing Christian
> On Thu, Sep 22, 2016 at 14:47:36 -0400, Jason J. Herne wrote:
> > Testing for runability:
> > - Simply try to start QEMU with KVM, compat machine, CPU model
>
> Yes, if the domain XML explicitly requests a specific CPU model.
> Additionally, we need to make sure a CPU model ch
On 09/27/2016 05:05 AM, Jim Fehlig wrote:
> On 09/26/2016 11:33 AM, Joao Martins wrote:
>> So far only guestfwd and virtio were supported. Add an additional
>> for Xen as libxl channels create Xen console visible to the guest.
>>
>> Signed-off-by: Joao Martins
>> ---
>> Changes since v2:
>> * A
Time flies, I didn't realized we were that close from the end of the month.
So if we want to have 2.3.0 for next Monday I think we should start the freeze
today, possibly tonight.
Does this work ? Sorry for late notice,
Daniel
--
Daniel Veillard | Open Source and Standards, Red Hat
ve
67 matches
Mail list logo
