> >> VIR_FREE() would have to be done at the top of the function; otherwise,
> >> how does the caller distinguish which error occurred when -1 gets
> >> returned and whether it should VIR_FREE itself?
> >>
> >
> > Well, I have to admin that this^^ is a fair argument because there are 3
> > differe
On 13.10.2016 22:58, John Ferlan wrote:
>
>
> On 10/06/2016 09:38 AM, Michal Privoznik wrote:
>> The idea is to have function that does some checking of the
>> arguments at its beginning and then have one big switch for all
>> the interface types it supports. Each one of them generating the
>> co
On 13.10.2016 22:58, John Ferlan wrote:
>
>
> On 10/06/2016 09:38 AM, Michal Privoznik wrote:
>> The idea is to have function that does some checking of the
>> arguments at its beginning and then have one big switch for all
>> the interface types it supports. Each one of them generating the
>> co
On 06.10.2016 21:38, Michal Privoznik wrote:
> v2 of:
>
> https://www.redhat.com/archives/libvir-list/2016-August/msg00806.html
>
> The first patches are mostly code movement and cleanups.
>
> diff to v1:
> - Hopefully all John's review suggestions are worked in now
>
> Michal Privoznik (14):
>
On 13.10.2016 23:33, Dawid Zamirski wrote:
> On Thu, 2016-10-13 at 12:04 +0200, Martin Kletzander wrote:
>> On Wed, Oct 12, 2016 at 04:00:52PM -0400, Dawid Zamirski wrote:
>>>
>>> So after my initial attempts at handling this as suggested (create
>>> vboxDriver struct and initialize in VIR_ONCE_GLO
On 13.10.2016 18:04, Martin Kletzander wrote:
> On Wed, Oct 12, 2016 at 04:00:52PM -0400, Dawid Zamirski wrote:
>> On Tue, 2016-10-11 at 10:58 -0400, Dawid Zamirski wrote:
>>> On Tue, 2016-10-11 at 16:22 +0200, Martin Kletzander wrote:
>>> > On Wed, Sep 28, 2016 at 01:41:35PM -0400, Dawid Zamirski
On 10/12/2016 10:49 AM, Erik Skultety wrote:
> On Wed, Oct 12, 2016 at 09:20:29AM -0400, John Ferlan wrote:
>>
>>
>> On 10/12/2016 06:40 AM, Erik Skultety wrote:
>>> On Tue, Oct 11, 2016 at 05:25:49PM -0400, John Ferlan wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1357416
Rat
On 14.10.2016 10:22, John Ferlan wrote:
>
>
> On 10/13/2016 10:12 PM, Michal Privoznik wrote:
>> Not every system out there has syslog, that's why we check for it
>> in our configure script. However, in 640b58abdf while fixing
>> another issue, some variables and functions are called that are
>>
ping? Tks (I have a follow up series for group that I'd like to see
considered before the end of the release cycle too, but this needs to be
done first).
John
On 10/06/2016 06:38 PM, John Ferlan wrote:
> v1: http://www.redhat.com/archives/libvir-list/2016-September/msg01090.html
>
> Difference
On 10/13/2016 10:12 PM, Michal Privoznik wrote:
> Not every system out there has syslog, that's why we check for it
> in our configure script. However, in 640b58abdf while fixing
> another issue, some variables and functions are called that are
> defined only when syslog.h is present. But these f
Not every system out there has syslog, that's why we check for it
in our configure script. However, in 640b58abdf while fixing
another issue, some variables and functions are called that are
defined only when syslog.h is present. But these function
calls/variables were not guarded by #ifdef-s.
Sig
On Thu, Oct 13, 2016 at 17:23:33 -0400, John Ferlan wrote:
>
>
> On 10/10/2016 11:51 AM, Peter Krempa wrote:
> > The smbios docs allow any string to be passed and libvirt does not
> > really do any validation on them. Allow passing any string.
> >
> > Partially resolves: https://bugzilla.redhat.
On Thu, Oct 13, 2016 at 17:11:54 -0400, John Ferlan wrote:
>
>
> On 10/10/2016 11:51 AM, Peter Krempa wrote:
> > qemuBuildSmbiosBiosStr and qemuBuildSmbiosSystemStr return NULL if
> > there's noting to format on the commandline. Reporting errors from
>
> nothing
>
> > buffer creation doesn't ma
I'm attaching the patch because I've been unable to use send-email properly.
2) is a good point, I wanted to discuss it here. Yes 120 is the minimum
allowed by dnsmasq, erroring out seems fine to me, I'll change the patch
accordingly.
On Thu, Oct 13, 2016 at 7:07 AM, Michal Privoznik
wrote:
> O
On Thu, Oct 13, 2016 at 11:34:43AM +0200, Martin Kletzander wrote:
> On Thu, Oct 13, 2016 at 11:34:16AM +1100, Sam Bobroff wrote:
> >On Wed, Oct 12, 2016 at 10:27:50AM +0200, Martin Kletzander wrote:
> >>On Wed, Oct 12, 2016 at 03:04:53PM +1100, Sam Bobroff wrote:
> >>>At the moment, guests that ar
On 10/12/2016 10:57 PM, Michal Privoznik wrote:
> On 13.10.2016 05:38, John Ferlan wrote:
>>
>>
>> On 10/05/2016 03:30 AM, Michal Privoznik wrote:
>>> Now that our cells in test driver are huge pages aware, we can
>>> implement virNodeAllocPages. Basically there's just one catch. If
>>> users spe
On 10/12/2016 10:30 PM, Michal Privoznik wrote:
> On 13.10.2016 05:12, John Ferlan wrote:
>>
>>
>> On 10/05/2016 03:30 AM, Michal Privoznik wrote:
>>> In d18c7d7124 we have tried to implement virNodeGetFreePages API
>>> to test driver. And for a very limited definition of success we
>>> have succ
On 10/10/2016 11:51 AM, Peter Krempa wrote:
> The smbios docs allow any string to be passed and libvirt does not
> really do any validation on them. Allow passing any string.
>
> Partially resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1373535
> ---
> docs/schemas/domaincommon.rng | 4 +-
On 10/10/2016 11:51 AM, Peter Krempa wrote:
> We pass free-form strings from the users to qemu, thus we need escape
> commas since they are passed to qemu monitor.
>
> Partially resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1373535
> ---
> src/qemu/qemu_command.c | 102
> ++
On 10/13/2016 12:14 PM, Eric Blake wrote:
I think a configure test based on -Werror=format would be
sufficient
What we have now should work for GCC 2.0 and later, whereas
-Werror=format is a much-newer GCC feature and so would be less portable.
if they are using some other compiler,
then ch
On 10/10/2016 11:51 AM, Peter Krempa wrote:
> qemuBuildSmbiosBiosStr and qemuBuildSmbiosSystemStr return NULL if
> there's noting to format on the commandline. Reporting errors from
nothing
> buffer creation doesn't make sense since it would be ignored.
Introduced by 54c0237ccb, so it's been t
This new function can be used to check if e.g. name of XML node
don't contains forbidden chars like "/" or new-line.
---
src/conf/network_conf.c | 2 +-
src/libvirt_private.syms | 1 +
src/util/virstring.c | 9 +
src/util/virstring.h | 1 +
4 files changed, 12 insertions(+), 1 del
New line character in name of network is now forbidden because it
mess virsh output and can be confusing for users.
Validation of name is done in network driver, after parsing XML to avoid
problems with dissappeared network which was already created with
new-line char in name.
Closes-Bug: https://
On 10/10/2016 11:51 AM, Peter Krempa wrote:
> ---
> src/qemu/qemu_command.c | 13 +
> 1 file changed, 9 insertions(+), 4 deletions(-)
>
ACK, trivial
John
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
v2: http://www.redhat.com/archives/libvir-list/2016-October/msg00451.html
Differences in v3:
* function to check string moved from src/util/virxml to src/util/virstring
* validation if name of network contains \n char moved from parsing XML to
functions responsible for create/define new networks
On 10/13/2016 02:07 PM, Andrea Bolognani wrote:
On Tue, 2016-09-20 at 15:14 -0400, Laine Stump wrote:
Real Q35 hardware has an ICH9 chip that includes several integrated
devices at particular addresses (see the file docs/q35-chipset.cfg in
the qemu source). libvirt already attempts to put the fi
On 10/09/2016 11:51 AM, Gema Gomez wrote:
> Hi all,
>
> commit fceeeda2 added support for adding key objects on hotplug based on a
> disk's secinfo for normal drives, but missed out SCSI drives. This patch adds
> the same support for SCSI drives, so that it's possible to hotplug SCSI
> drives
On 10/11/2016 03:15 PM, Marko Myllynen wrote:
> Hi,
>
> I see that recently the last-update field has been added to the balloon
> statistics, this is how it looks like from Python:
>
> [(, {'balloon.rss': 960048L,
> 'balloon.swap_in': 0L, 'balloon.usable': 1676424L, 'balloon.unused':
> 1376188L
On 10/13/2016 01:50 PM, Eric Blake wrote:
> On 10/13/2016 01:23 PM, Paul Eggert wrote:
>> On 10/13/2016 06:36 AM, Eric Blake wrote:
>>> That's a bug in s390's system headers. Gnulib should be taught to work
>>> around it.
>>
>> Although this bug was reported fixed in glibc 2.20; see
>>
>> https://
On 10/13/2016 01:23 PM, Paul Eggert wrote:
> On 10/13/2016 06:36 AM, Eric Blake wrote:
>> That's a bug in s390's system headers. Gnulib should be taught to work
>> around it.
>
> Although this bug was reported fixed in glibc 2.20; see
>
> https://sourceware.org/bugzilla/show_bug.cgi?id=16712
>
On 10/13/2016 01:43 PM, Laine Stump wrote:
On 10/11/2016 05:34 AM, Andrea Bolognani wrote:
On Mon, 2016-10-10 at 15:43 -0400, Laine Stump wrote:
3) Although it is strongly discouraged, it is legal for a pci-bridge
to be directly plugged into pcie-root, and we don't want to
auto-ad
On 10/13/2016 06:36 AM, Eric Blake wrote:
That's a bug in s390's system headers. Gnulib should be taught to work
around it.
Although this bug was reported fixed in glibc 2.20; see
https://sourceware.org/bugzilla/show_bug.cgi?id=16712
the Gnulib manual says the bug is still in glibc 2.24; see
On Tue, 2016-09-20 at 15:14 -0400, Laine Stump wrote:
> Real Q35 hardware has an ICH9 chip that includes several integrated
> devices at particular addresses (see the file docs/q35-chipset.cfg in
> the qemu source). libvirt already attempts to put the first two sets
> of ich9 USB2 controllers it fi
On 10/10/2016 02:14 PM, Andrea Bolognani wrote:
+} else if (flags & VIR_PCI_CONNECT_TYPE_PCI_BRIDGE) {
>+model = VIR_DOMAIN_CONTROLLER_MODEL_DMI_TO_PCI_BRIDGE;
I'm not so clear on this bit: if we're growing the address
set to plug in a pci-bridge, can we just go ahead and assume
a dm
Hi!
So it looks like we face a problem with cross-version
migration when using vhost. It's not new but became more
acute with the advent of vhost user.
For users to be able to migrate between different versions
of the hypervisor the interface exposed to guests
by hypervisor must stay unchanged.
T
On 10/11/2016 05:34 AM, Andrea Bolognani wrote:
On Mon, 2016-10-10 at 15:43 -0400, Laine Stump wrote:
3) Although it is strongly discouraged, it is legal for a pci-bridge
to be directly plugged into pcie-root, and we don't want to
auto-add a dmi-to-pci-bridge if there is already a
On 10/13/2016 11:50 AM, Andrea Bolognani wrote:
On Tue, 2016-09-20 at 15:14 -0400, Laine Stump wrote:
Now the a dmi-to-pci-bridge is automatically added just as it's needed
(when a pci-bridge is being added), we no longer have any need to
force-add one to every single Q35 domain.
---
src/qemu
On Tue, 2016-09-20 at 15:14 -0400, Laine Stump wrote:
> Previously we added a set of EHCI+UHCI controllers to Q35 machines to
> mimic real hardware as closely as possible, but recent discussions
> have pointed out that the nec-usb-xhci (USB3) controller is much more
> virtualization-friendly (uses
On Wed, Oct 12, 2016 at 13:55:49 -0400, Jason J. Herne wrote:
> In order to properly obtain the host cpu model data for virsh
> capabilities on s390 we will need to run a Qemu process. There is no
> precedent for doing this in a cpu connection driver today.
There are two reasons for this:
1) it w
On 10/13/2016 11:49 AM, Michal Privoznik wrote:
> Signed-off-by: Michal Privoznik
> ---
> Changes| 2 +-
> Virt.xs| 1 +
> lib/Sys/Virt/Domain.pm | 4
> 3 files changed, 6 insertions(+), 1 deletion(-)
>
ACK (I have it queued up too, but the 2nd round iotun
On Tue, 2016-09-20 at 15:14 -0400, Laine Stump wrote:
> Now the a dmi-to-pci-bridge is automatically added just as it's needed
> (when a pci-bridge is being added), we no longer have any need to
> force-add one to every single Q35 domain.
> ---
> src/qemu/qemu_domain.c
Signed-off-by: Michal Privoznik
---
Changes| 2 +-
Virt.xs| 1 +
lib/Sys/Virt/Domain.pm | 4
3 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/Changes b/Changes
index 4985100..5831939 100644
--- a/Changes
+++ b/Changes
@@ -2,7 +2,7 @@ Revision hist
The code is entirely correct, but it still managed to trip me
up when I first ran into it because I did not realize right away
that VIR_PCI_CONNECT_TYPES_ENDPOINT was not a single flag, but
rather a mask including both VIR_PCI_CONNECT_TYPE_PCI_DEVICE and
VIR_PCI_CONNECT_TYPE_PCIE_DEVICE.
In order
On Thu, 2016-10-13 at 12:04 +0200, Martin Kletzander wrote:
> On Wed, Oct 12, 2016 at 04:00:52PM -0400, Dawid Zamirski wrote:
> >
> > So after my initial attempts at handling this as suggested (create
> > vboxDriver struct and initialize in VIR_ONCE_GLOBAL_INIT), I've
> > stumbled upon virStateDri
On 10/06/2016 09:38 AM, Michal Privoznik wrote:
> The idea is to have function that does some checking of the
> arguments at its beginning and then have one big switch for all
> the interface types it supports. Each one of them generating the
> corresponding part of the command line.
>
> Signed-
On 10/06/2016 09:38 AM, Michal Privoznik wrote:
> Currently, what we do for vhost-user network is generate the
> following part of command line:
>
> -netdev type=vhost-user,id=hostnet0,chardev=charnet0
>
> There's no need for 'type=' it is the default. Drop it.
>
> Signed-off-by: Michal Privoz
On 10/06/2016 09:38 AM, Michal Privoznik wrote:
> This alone makes not much sense. But the aim is to reuse this
> function in qemuBuildVhostuserCommandLine() where 'nowait' is not
> supported for vhost-user devices.
>
> Signed-off-by: Michal Privoznik
> ---
> src/qemu/qemu_command.c | 35 +
On 10/06/2016 09:38 AM, Michal Privoznik wrote:
> There's no need to reinvent the wheel here. We already have a
> function to format virDomainChrSourceDefPtr. It's called
> qemuBuildChrChardevStr(). Use that instead of some dummy
> virBufferAsprintf().
>
> Signed-off-by: Michal Privoznik
> ---
On 10/06/2016 09:39 AM, Michal Privoznik wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1366108
>
> There are couple of things that needs to be done in order to
s/needs/need/
> allow vhost-user hotplug. Firstly, vhost-user requires a chardev
> which is connected to vhost-user bridge and
On 10/06/2016 09:38 AM, Michal Privoznik wrote:
> The idea is to have function that does some checking of the
> arguments at its beginning and then have one big switch for all
> the interface types it supports. Each one of them generating the
> corresponding part of the command line.
>
> Signed-
On 10/06/2016 09:38 AM, Michal Privoznik wrote:
> Signed-off-by: Michal Privoznik
> ---
> src/qemu/qemu_command.c | 34 +++---
> 1 file changed, 27 insertions(+), 7 deletions(-)
>
ACK
John
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/
On 10/06/2016 09:38 AM, Michal Privoznik wrote:
> Instead of blindly claim support for hot-plugging of every
> interface type out there we should copy approach we have for
> device types: white listing supported types and explicitly error
> out on unsupported ones.
> For instance, trying to hotpl
On 10/06/2016 09:38 AM, Michal Privoznik wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1366505
>
> So far, this function lacked support for
> VIR_DOMAIN_NET_TYPE_VHOSTUSER leaving callers to hack around the
> problem by constructing the command line on their own. This is
> not ideal as it
On 10/06/2016 09:38 AM, Michal Privoznik wrote:
> Instead of various NULL arguments, we can pass proper qemu driver
> config, log manager, and virCommand.
>
> Signed-off-by: Michal Privoznik
> ---
> src/qemu/qemu_command.c | 31 ++-
> 1 file changed, 18 insertions(+)
On 10/06/2016 09:38 AM, Michal Privoznik wrote:
> We tend to prevent using 'default' in switches. And it is for a
> good reason - control may end up in paths we wouldn't want for
> new values. In this specific case, if qemuBuildHostNetStr is
> called over VIR_DOMAIN_NET_TYPE_VHOSTUSER it would pr
On 10/06/2016 09:38 AM, Michal Privoznik wrote:
> The idea is to have function that does some checking at its
> beginning and then have one big switch for all the interface
> types it supports.
>
> Signed-off-by: Michal Privoznik
> ---
> src/qemu/qemu_hotplug.c | 26 --
On 10/06/2016 09:38 AM, Michal Privoznik wrote:
> This function for some weird reason returns integer instead of
> virDomainNetType type. It is important to return the correct type
> so that we know what values we can expect.
>
> Signed-off-by: Michal Privoznik
> ---
> src/bhyve/bhyve_command.
On 10/06/2016 09:38 AM, Michal Privoznik wrote:
> There are couple of formatting issues. No functional change
> though.
>
> Signed-off-by: Michal Privoznik
> ---
> src/conf/domain_conf.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
ACK
John
--
libvir-list mailing list
On 10/07/2016 05:43 AM, Jiri Denemark wrote:
> GCC on s390 complains
>
> util/virconf.c: In function 'virConfGetValueSizeT':
> util/virconf.c:1220:9: error: format '%zu' expects argument of type
> 'size_t', but argument 9 has type 'unsigned int' [-Werror=format=]
>
That's a bug in s390's system
Hi.
On Fri, Oct 07, 2016 at 13:36:21 +0200, Christian Borntraeger wrote:
> On 10/07/2016 12:43 PM, Jiri Denemark wrote:
> > GCC on s390 complains
> >
> > util/virconf.c: In function 'virConfGetValueSizeT':
> > util/virconf.c:1220:9: error: format '%zu' expects argument of type
> > 'size_t', but a
Extended qemuDomainGetStatsVcpu to include the per vcpu halted
indicator if reported by QEMU. The key for new boolean value
has the format "vcpu..halted".
Signed-off-by: Viktor Mihajlovski
Reviewed-by: Bjoern Walk
---
src/qemu/qemu_driver.c | 34 ++
1 file change
As a result of the discussions on
https://www.redhat.com/archives/libvir-list/2016-October/msg00531.html:
In order to be able to report the per VCPU halted condition as returned
by the QEMU monitor this series extends the VCPU-specific domain
statistics with a vcpu.n.halted value.
This is done by
Added description for new vcpu..halted statistics value.
While there, also added a description for vcpu..wait and
clarified the units displayed for time and wait.
Signed-off-by: Viktor Mihajlovski
Reviewed-by: Bjoern Walk
---
tools/virsh.pod | 7 +++
1 file changed, 7 insertions(+)
diff --
Extended the qemuMonitorCPUInfo with a halted flag. Extract the halted
flag for both text and JSON monitor.
Signed-off-by: Viktor Mihajlovski
Signed-off-by: Boris Fiuczynski
---
src/qemu/qemu_monitor.c | 6 +-
src/qemu/qemu_monitor.h | 3 +++
src/qemu/qemu_monitor_json.c | 3 +++
Adding a field to the domain's private vcpu object to hold the halted
state information.
Adding two functions in support of the halted state:
- qemuDomainGetVcpuHalted: retrieve the halted state from a
private vcpu object
- qemuDomainRefreshVcpuHalted: obtain the per-vcpu halted states
via qemu
On 13.10.2016 00:46, John Ferlan wrote:
[...]
Despite fixing user strings in this version to show the word
'running' the enum value [1] is still changed for the new one.
Since the actual value is used by programs and not humans that may
break and I'm not comfortable allowin
Added a brief description of the VCPU states.
Signed-off-by: Viktor Mihajlovski
---
tools/virsh.pod | 49 +
1 file changed, 49 insertions(+)
diff --git a/tools/virsh.pod b/tools/virsh.pod
index 9e3a248..6d4fd07 100644
--- a/tools/virsh.pod
+++ b/t
On 10/10/2016 08:04 AM, Erik Skultety wrote:
> Commit 640b58ab broke the mingw build because it referenced 'current_ident'
> as well as 'openlog' symbols both of which are declared conditionally within
> HAVE_SYSLOG_H directive. This patch fixes the broken build. Additional changes
> like moving
On Wed, Oct 12, 2016 at 04:00:52PM -0400, Dawid Zamirski wrote:
On Tue, 2016-10-11 at 10:58 -0400, Dawid Zamirski wrote:
On Tue, 2016-10-11 at 16:22 +0200, Martin Kletzander wrote:
> On Wed, Sep 28, 2016 at 01:41:35PM -0400, Dawid Zamirski wrote:
>
> The allocation is not guarded by any lock, so
On Thu, Oct 13, 2016 at 11:34:16AM +1100, Sam Bobroff wrote:
On Wed, Oct 12, 2016 at 10:27:50AM +0200, Martin Kletzander wrote:
On Wed, Oct 12, 2016 at 03:04:53PM +1100, Sam Bobroff wrote:
>At the moment, guests that are backed by hugepages in the host are
>only able to use policy to control the
On Thu, Oct 13, 2016 at 10:28:34 +0200, Martin Kletzander wrote:
> Completely new BLURB, just for €99.99, call now!
That's a bargin!
ACK series
signature.asc
Description: Digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Completely new BLURB, just for €99.99, call now!
Martin Kletzander (2):
schema: Allow alias for panic device
conf: Honour flags in virDomainPanicDefParseXML
docs/schemas/domaincommon.rng | 3 +++
src/conf/domain_conf.c| 10 +-
2 files changed, 8 insertions(+), 5 deletions(-
Without them we're keeping even for inactive XML.
Signed-off-by: Martin Kletzander
---
src/conf/domain_conf.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 4fa6976ea63e..cd1384a5c48f 100644
--- a/src/conf/dom
As with all other devices, it's not part of 'address'.
Signed-off-by: Martin Kletzander
---
docs/schemas/domaincommon.rng | 3 +++
1 file changed, 3 insertions(+)
diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
index 6eeb4e9e7df0..3f96456b5c8e 100644
--- a/docs/schema
On Fri, Oct 07, 2016 at 11:22:34AM +0200, Michal Privoznik wrote:
This initially started as a fix of some debug printing in
virCgroupDetect. However it turned out that other places suffer
from the similar problem. While dealing with pids, esp. in cases
where we cannot use pid_t for ABI stability
75 matches
Mail list logo
