[libvirt] [PATCH] Qemu : Do not distinguish a 'hangup' from an 'eof'

An errno=ECONNRESET received on a monitor socket reflects that the guest may have closed the socket. Today, we just mark it as a 'hangup' and do not trigger the eof callback. I've been looking at a slew of such messages in libvirt logs. If the monitor socket indicated an ECONNRESET, it would

Re: [libvirt] [PATCH v2] vsh: Using VSH_REQUIRE_OPTION rather than virReportError

On 10/18/2016 01:33 PM, Kothapally Madhu Pavan wrote: > Correcting the error reporting method by using VSH_REQUIRE_OPTION > instead of virReportError > > Signed-off-by: Kothapally Madhu Pavan > --- > tools/virsh-domain.c |7 +-- > 1 file changed, 1

Re: [libvirt] [PATCH 00/17] Avoid races with udev

On 27.10.2016 04:07, Bjoern Walk wrote: > Michal Privoznik [2016-10-26, 02:52PM +0200]: >> I've came across interesting bug recently. The problem was that >> user tried to start a domain, but qemu was denied access to some >> device. Even though we relabelled it initially. By

Re: [libvirt] [PATCH v2] qemu: report block job errors from qemu to the user

No commit message... This definitely needs one. Also when there's one patch, you don't need a cover letter - instead you put whatever "message" you want to give to reviewers, the pointer to the previous version, changes with the current code, etc. after the "---"

Re: [libvirt] [PATCH] network: fix endless loop when starting network with multiple IPs and no dhcp

On 28.10.2016 08:55, Laine Stump wrote: > (From the "How the Hell did I not see this?" files) > > commit 9065cfaa added the ability to disable DNS services for a > libvirt virtual network. If neither DNS nor DHCP is needed for a > network, then we don't need to start dnsmasq, so code was added to

Re: [libvirt] [Qemu-devel] [libvirt-users] pci-assign fails with read error on config-space file

On Fri, 28 Oct 2016 11:25:55 -0400 Laine Stump wrote: > On 10/28/2016 07:28 AM, Henning Schild wrote: > > Hey, > > > > i am running an unusual setup where i assign pci devices behind the > > back of libvirt. I have two options to do that: > > 1. a wrapper script for qemu that

[libvirt] [PATCH] network: fix endless loop when starting network with multiple IPs and no dhcp

(From the "How the Hell did I not see this?" files) commit 9065cfaa added the ability to disable DNS services for a libvirt virtual network. If neither DNS nor DHCP is needed for a network, then we don't need to start dnsmasq, so code was added to check for this. Unfortunately, it was written

Re: [libvirt] [libvirt-users] pci-assign fails with read error on config-space file

On 10/28/2016 07:28 AM, Henning Schild wrote: Hey, i am running an unusual setup where i assign pci devices behind the back of libvirt. I have two options to do that: 1. a wrapper script for qemu that takes care of suid-root and appends arguments for pci-assign 2. virsh qemu-monitor-command ...

Re: [libvirt] [Qemu-devel] pci-assign fails with read error on config-space file

On 10/28/16 13:28, Henning Schild wrote: > Hey, > > i am running an unusual setup where i assign pci devices behind the > back of libvirt. I have two options to do that: > 1. a wrapper script for qemu that takes care of suid-root and appends > arguments for pci-assign > 2. virsh

Re: [libvirt] [PATCH 04/10] qemu: agent: handle agent connection errors in one place

On 28.10.2016 14:42, John Ferlan wrote: > > > On 10/28/2016 03:37 AM, Nikolay Shirokovskiy wrote: >> >> >> On 27.10.2016 18:51, John Ferlan wrote: >>> >>> >>> On 10/27/2016 07:34 AM, Nikolay Shirokovskiy wrote: On 26.10.2016 22:57, John Ferlan wrote: > > There's no

[libvirt] [PATCH v2 python 1/2] minor clean-up for libvirt_virDomainPin*

All libvirt_virDomainPin* functions do the same thing for convert pycpumap to cpumap, so this patch moves all common logic to new helper - virPyCpuMapToChar. Signed-off-by: Konstantin Neumoin --- libvirt-override.c | 131

[libvirt] [PATCH v2 python 0/2] fix crash in libvirt_virDomainPin*

this small patch set: * move common logic of all libvirt_virDomainPin* functions to new helper in util module. * add check for pycpumap length. Changes since v1: - add new helper in util module. Konstantin Neumoin (2): minor clean-up for libvirt_virDomainPin* add check for pycpumap length

Re: [libvirt] [PATCH 04/10] qemu: agent: handle agent connection errors in one place

On 27.10.2016 18:51, John Ferlan wrote: > > > On 10/27/2016 07:34 AM, Nikolay Shirokovskiy wrote: >> >> >> On 26.10.2016 22:57, John Ferlan wrote: >>> >>> There's no commit message... >> >> This is simple refactoring. >> > > Not really... > > A simple refactor would have kept the -2 logic.