Re: [libvirt] [PATCH] domain_event.c: Fix a typo

On Tue, Nov 01, 2016 at 01:09:32 -0400, Kothapally Madhu Pavan wrote: > Signed-off-by: Kothapally Madhu Pavan > --- > src/conf/domain_event.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/conf/domain_event.c b/src/conf/domain_event.c >

Re: [libvirt] [PATCH] domain_event.c: Fix a typo

On Tue, Nov 01, 2016 at 01:09:32 -0400, Kothapally Madhu Pavan wrote: > Signed-off-by: Kothapally Madhu Pavan > --- > src/conf/domain_event.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/conf/domain_event.c b/src/conf/domain_event.c >

[libvirt] [PATCH] domain_event.c: Fix a typo

Signed-off-by: Kothapally Madhu Pavan --- src/conf/domain_event.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_event.c b/src/conf/domain_event.c index 63ae9e1..f1249ad 100644 --- a/src/conf/domain_event.c +++

Re: [libvirt] [PATCH v3 2/6] virerror: add error for libssh transport

On Wed, Oct 19, 2016 at 14:40:35 +0200, Pino Toscano wrote: > Add a new error domain and number for a new libssh-based transport. > --- > include/libvirt/virterror.h | 2 ++ > src/util/virerror.c | 9 - > 2 files changed, 10 insertions(+), 1 deletion(-) ACK, Peter

Re: [libvirt] [PATCH v3 1/6] virNetSocket: allow to not close FD

On Wed, Oct 19, 2016 at 14:40:34 +0200, Pino Toscano wrote: > Add an internal variable to mark the FD as "not owned" by the > virNetSocket, in case the internal implementation takes the actual > ownership of the descriptor; this avoids a warning when closing the > socket, as the FD would be

Re: [libvirt] [PATCH v2 python 1/2] minor clean-up for libvirt_virDomainPin*

In subject: "Move cpumap conversion code to a common helper" or something more descriptive than "minor clean-up" On Fri, Oct 28, 2016 at 13:41:09 +0300, Konstantin Neumoin wrote: > All libvirt_virDomainPin* functions do the same thing for convert > pycpumap to cpumap, so this patch moves all

Re: [libvirt] [PATCH v2 python 2/2] add check for pycpumap length

In subject: "Don't overrun buffer when converting cpumap" perhaps? That would IMHO explain the patch a bit more when looking at shortlog. On Fri, Oct 28, 2016 at 13:41:10 +0300, Konstantin Neumoin wrote: > If we pass large(more than cpunum) cpu mask to any libvirt_virDomainPin* > function, it

Re: [libvirt] [PATCH v2 python 1/2] minor clean-up for libvirt_virDomainPin*

On Fri, Oct 28, 2016 at 13:41:09 +0300, Konstantin Neumoin wrote: > All libvirt_virDomainPin* functions do the same thing for convert > pycpumap to cpumap, so this patch moves all common logic to new > helper - virPyCpuMapToChar. > > Signed-off-by: Konstantin Neumoin >

[libvirt] VLAN-based direct interface

In my setup, the network interfaces of several KVM-based VMs all communicate with the outside world via a single host interface, which is in turn connected to an external switch that handles all network policy to/from/between VMs. Traffic between the host and the switch is segregated by VLAN ID,

[libvirt] [PATCH 5/6] qemu: Add the group name option to the iotune command line

Add in the block I/O throttling group parameter to the command line if supported. If not supported, fail command creation. Add the xml2argvtest for testing. Signed-off-by: John Ferlan --- src/qemu/qemu_command.c| 13 +

[libvirt] [PATCH 6/6] virsh: Add group name to blkdeviotune output

https://bugzilla.redhat.com/show_bug.cgi?id=1336564 Add the ability to set/display the group_name for block device iotune Signed-off-by: John Ferlan --- tools/virsh-domain.c | 17 + tools/virsh.pod | 5 - 2 files changed, 21 insertions(+), 1

[libvirt] [PATCH 1/6] include: Add new "group_name" definition for iotune throttling

Add the new field to support sharing I/O throttling quota between multiple drives. Signed-off-by: John Ferlan --- include/libvirt/libvirt-domain.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h

[libvirt] [PATCH 2/6] caps: Add new capability for the iotune group name

Add the capability to detect if the qemu binary can support the feature to use throttling.group. Signed-off-by: John Ferlan --- src/qemu/qemu_capabilities.c| 2 ++ src/qemu/qemu_capabilities.h| 1 +

[libvirt] [PATCH 0/6] Add group_name support for

https://bugzilla.redhat.com/show_bug.cgi?id=1336564 Add support for "group" name in . The odd thing about the group name is that support was added in qemu after the _max parameters, but before the _max_length - so when building the command line - that needs to be followed. At least it's far

[libvirt] [PATCH 3/6] qemu: Add support for parsing iotune group setting

Add support to read/parse the iotune group setting for qemu. Signed-off-by: John Ferlan --- include/libvirt/libvirt-domain.h | 8 + src/conf/domain_conf.c | 1 + src/conf/domain_conf.h | 1 + src/qemu/qemu_driver.c | 50

[libvirt] [PATCH 4/6] conf: Add support for blkiotune group_name option

Modify _virDomainBlockIoTuneInfo and rng schema to support the group_name option for iotune throttling. Document the new value. Signed-off-by: John Ferlan --- docs/formatdomain.html.in | 11 docs/schemas/domaincommon.rng |

Re: [libvirt] [PATCH] docs: remove obsolete library.xen file

On 10/31/2016 07:40 AM, Daniel P. Berrange wrote: The library.xen file contains a braindump of thoughts dating from the very first days of libvirt, when it was briefly called libxen. This is not useful and potentially misleading or confusing for people. Signed-off-by: Daniel P. Berrange

Re: [libvirt] [PATCH v4 7/8] qmp: Support abstract classes on device-list-properties

(CCing libvirt people, as I forgot to CC them) On Mon, Oct 31, 2016 at 03:07:23PM +0100, Igor Mammedov wrote: > On Fri, 28 Oct 2016 23:48:06 -0200 > Eduardo Habkost wrote: > > > When an abstract class is used on device-list-properties, we can > > simply return the class

[libvirt] [PATCH v3 01/10] Cleanup switch statements on the hostdev subsystem type

As was suggested in an earlier review comment[1], we can catch some additional code points by cleaning up how we use the hostdev subsystem type in some switch statements. [1] End of https://www.redhat.com/archives/libvir-list/2016-September/msg00399.html Signed-off-by: Eric Farman

[libvirt] [PATCH v3.1 00/10] Implementation of QEMU vhost-scsi

This patch series provides a libvirt implementation of the vhost-scsi interface in QEMU. As near as I can see, this was discussed upstream in July 2014[1], and ended in a desire to replace a vhost-scsi controller in favor of a hostdev element instead[2]. Host setup via targetcli (SCSI LUN(s) are

[libvirt] [PATCH v3 07/10] conf: Wire up the vhost-scsi connection from/to XML

Signed-off-by: Eric Farman --- docs/schemas/domaincommon.rng | 23 src/conf/domain_audit.c | 7 src/conf/domain_conf.c| 81 +-- 3 files changed, 109 insertions(+), 2 deletions(-) diff --git

[libvirt] [PATCH v3 06/10] qemu: Allow hotplug of vhost-scsi device

Adjust the device string that is built for vhost-scsi devices so that it can be invoked from hotplug. >From the QEMU command line, the file descriptors are expect to be numeric only. However, for hotplug, the file descriptors are expected to begin with at least one alphabetic character else this

[libvirt] [PATCH v3 09/10] tests: Introduce basic vhost-scsi test

These tests were cloned from hostdev-scsi-virtio-scsi in both xml2argv and xml2xml Signed-off-by: Eric Farman Reviewed-by: Boris Fiuczynski --- .../qemuxml2argv-hostdev-scsi-vhost-scsi.args | 24 +

[libvirt] [PATCH v3 08/10] security: Include vhost-scsi in security labels

Signed-off-by: Eric Farman --- src/security/security_apparmor.c | 18 - src/security/security_dac.c | 42 ++-- src/security/security_selinux.c | 39 +++-- 3 files changed, 94

[libvirt] [PATCH v3 10/10] docs: Add vhost-scsi

Signed-off-by: Eric Farman --- docs/formatdomain.html.in | 24 1 file changed, 24 insertions(+) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index c70377b..6ef864f 100644 --- a/docs/formatdomain.html.in +++

[libvirt] [PATCH v3 04/10] util: Management routines for scsi_host devices

Signed-off-by: Eric Farman --- src/Makefile.am | 1 + src/libvirt_private.syms | 19 +++ src/util/virhost.c | 301 +++ src/util/virhost.h | 72 src/util/virhostdev.c| 155

[libvirt] [PATCH v3 05/10] qemu: Add vhost-scsi string for -device parameter

Open /dev/vhost-scsi, and record the resulting file descriptor, so that the guest has access to the host device outside of the libvirt daemon. Pass this information, along with data parsed from the XML file, to build a device string for the qemu command line. That device string will be for either

[libvirt] [PATCH v3 02/10] qemu: Introduce vhost-scsi capability

Do all the stuff for the vhost-scsi capability in QEMU, so it's in place for our checks later. Signed-off-by: Eric Farman Reviewed-by: Boris Fiuczynski --- src/qemu/qemu_capabilities.c| 2 ++

[libvirt] [PATCH v3 03/10] Introduce a "scsi_host" hostdev type

We already have a "scsi" hostdev type, which refers to a single LUN that is passed through to a guest. But what of things where multiple LUNs are passed through via a single SCSI HBA, such as with the vhost-scsi target? Create a new hostdev type that will carry this. Signed-off-by: Eric Farman

Re: [libvirt] [PATCH RESEND] qemu_driver: unlink new domain cfg file when rollback

On Mon, Oct 31, 2016 at 09:40:21AM -0400, Laine Stump wrote: On 10/31/2016 06:43 AM, Martin Kletzander wrote: On Fri, Oct 28, 2016 at 04:29:30AM -0700, Michal Privoznik wrote: On 27.10.2016 17:45, Chen Hanxiao wrote: From: Chen Hanxiao If we failed to unlink old dom

Re: [libvirt] [PATCH RESEND] qemu_driver: unlink new domain cfg file when rollback

On 10/31/2016 06:43 AM, Martin Kletzander wrote: On Fri, Oct 28, 2016 at 04:29:30AM -0700, Michal Privoznik wrote: On 27.10.2016 17:45, Chen Hanxiao wrote: From: Chen Hanxiao If we failed to unlink old dom cfg file, we goto rollback. But inside rollback, we fogot to

[libvirt] [PATCH] docs: remove obsolete library.xen file

The library.xen file contains a braindump of thoughts dating from the very first days of libvirt, when it was briefly called libxen. This is not useful and potentially misleading or confusing for people. Signed-off-by: Daniel P. Berrange --- cfg.mk | 2 +-

Re: [libvirt] [PATCH v3 0/9] Implementation of QEMU vhost-scsi

On 10/29/2016 08:33 AM, John Ferlan wrote: On 10/26/2016 05:42 PM, Eric Farman wrote: [Author note: Apologies for an extra release or two in between versions, I was sidetracked by another project. This is probably too close to the impending freeze for 2.4, so I just updated doc to 2.5 in

[libvirt] [PATCH 17/17] docs: add master SVG for libvirt logo

Add the SVG file used to create the PNG logos Signed-off-by: Daniel P. Berrange --- docs/logo.svg | 2153 + 1 file changed, 2153 insertions(+) create mode 100644 docs/logo.svg diff --git a/docs/logo.svg

[libvirt] [PATCH 11/17] docs: rewrite content on front page to be more useful

The front page contains a bunch of content that is either outdated (eg links to libvirt qpid) or not particularly useful (links to vendor hypervisor sites). This rewrites it to be more directly useful to visitors, providing a updated intro to libvirt project, direct links to key pieces of website

[libvirt] [PATCH 09/17] docs: remove related links page

The related links page is either horribly outdated, or duplicating stuff already linked elsewhere. Signed-off-by: Daniel P. Berrange --- docs/relatedlinks.html.in | 88 --- docs/sitemap.html.in | 4 --- 2 files changed, 92

[libvirt] [PATCH 15/17] docs: remove navigation sidebar from pages

A combination of the index page, top nav bar and docs.html page provide links to all pages on the site. The left hand nav bar is thus redundant and can be removed to provide a simpler style for the site. Signed-off-by: Daniel P. Berrange --- docs/Makefile.am | 8 +-

[libvirt] [PATCH 00/17] Redo website layout and branding

The current libvirt website design dates from 2008 and has not changed significantly since. Compared to contemporary open source project websites it looks pretty dated and cluttered. This series incrementally changes the website to have a completely new layout and branding. Since the original

[libvirt] [PATCH 02/17] docs: switch to new website banner

Use a dark banner whose color matches the dark green used in the logo. Introduce a newly rendered version of the header logo derived from new SVG file, instead of old one from (now lost) Adobe Illustrator file. The top banner logo now links to the front page as is common practice for most

[libvirt] [PATCH 16/17] docs: remove outdated or duplicated content

Remove a bunch of pages which are either outdated, have no content, or duplicate content better described elsewhere in the site or wiki. Signed-off-by: Daniel P. Berrange --- docs/archdomain.html.in | 7 -- docs/archnetwork.html.in | 54 --

[libvirt] [PATCH 04/17] docs: add footer to all pages

Add a footer to all pages containing a blurb about the code of conduct, and links to social media sites. Signed-off-by: Daniel P. Berrange --- docs/libvirt.css | 44 docs/page.xsl| 12 2 files changed, 56

[libvirt] [PATCH 06/17] docs: add page describing contribution to libvirt

Add a page that describes what contributions libvirt is looking for and how to get involved. Signed-off-by: Daniel P. Berrange --- docs/contribute.html.in | 140 1 file changed, 140 insertions(+) create mode 100644

[libvirt] [PATCH 08/17] docs: remove todo page

The todo page used to be auto-generated from bugzilla but is no longer used. Signed-off-by: Daniel P. Berrange --- docs/Makefile.am | 35 ++ docs/sitemap.html.in | 4 -- docs/todo.cfg-example | 26 --- docs/todo.pl | 125

[libvirt] [PATCH 12/17] docs: expand downloads page to cover all modules

Previously the download page only covered the main libvirt module and the app dev guide. Expand it to provide direct links to all artifacts published by the project, whether the main library, language bindings, docs, or testing. Tweak the top table styling to better fit in with new branding.

[libvirt] [PATCH 13/17] docs: add some improved styling to contact page

Change the contact page styling to better distinguish the various mailing lists. Signed-off-by: Daniel P. Berrange --- docs/contact.html.in | 4 ++-- docs/libvirt.css | 15 +++ 2 files changed, 17 insertions(+), 2 deletions(-) diff --git

[libvirt] [PATCH 07/17] docs: add three core links in the header bar

Add links to download, communicate and learn in the header bar, as the main jumping off points for navigation. Signed-off-by: Daniel P. Berrange --- docs/libvirt.css | 28 +++- docs/page.xsl| 7 +++ 2 files changed, 34 insertions(+), 1

[libvirt] [PATCH 10/17] Revert "syntax-check: Enforce inside elements"

This reverts commit 1f29f3da065ef12d3ec39c3c673186f8ea6d764e. Assuming is always used to document symbols is way too broad, requiring far too many exemptions to be marked to avoid syntax check rules. Signed-off-by: Daniel P. Berrange --- cfg.mk | 14

[libvirt] [PATCH 05/17] docs: simplify style for headers

Remove the 1px border underneath all headers and make them use black text to simplify visual appearance Signed-off-by: Daniel P. Berrange --- docs/generic.css | 1 - docs/libvirt.css | 4 2 files changed, 5 deletions(-) diff --git a/docs/generic.css b/docs/generic.css

[libvirt] [PATCH 14/17] docs: fill out docs page with useful links

The docs page is currently completely empty. Fill it in with links to the various documentation, categorized as to whether it is targetting people deploying libvirt, application developers using libvirt, or people working on libvirt itself. Signed-off-by: Daniel P. Berrange

Re: [libvirt] [PATCH] vsh: Pass correct values for command line completion

On Fri, Oct 28, 2016 at 05:09:38PM -0400, John Ferlan wrote: > Commit id 'dcfdf341' passes 'opts_need_arg' and 'opts_seen' to > vshCmddefGetData, but that seems to be incorrect as those values > are not initialized properly (something at least one compiler found). > Instead the static

Re: [libvirt] [PATCH RESEND] qemu_driver: unlink new domain cfg file when rollback

On Fri, Oct 28, 2016 at 04:29:30AM -0700, Michal Privoznik wrote: On 27.10.2016 17:45, Chen Hanxiao wrote: From: Chen Hanxiao If we failed to unlink old dom cfg file, we goto rollback. But inside rollback, we fogot to unlink the new dom cfg file. This patch fixes this

Re: [libvirt] [PATCH] fix parsing security labels from virt-aa-helper

On Mon, Oct 31, 2016 at 11:32 AM, Christian Ehrhardt < christian.ehrha...@canonical.com> wrote: > But that turned out to break non apparmor seclabels as well as apparmor > seclabels in xmls without labels. > FYI - For a bit extra info on the case, debugging it and in general more background that

[libvirt] [PATCH] fix parsing security labels from virt-aa-helper

When parsing labels virt-aa-helper does no more pass VIR_DOMAIN_DEF_PARSE_INACTIVE due to dfbc9a83 that tried to mitigate the changes of a89f05ba. For those it had to switch from VIR_DOMAIN_DEF_PARSE_INACTIVE to active since we need the domain id (ctl->def->id) as it is part of the socket path now

Re: [libvirt] [PATCH v3] Fixes virsh save-restore/migration when memory detach not in LIFO

On Fri, Oct 14, 2016 at 08:35:16 -0400, John Ferlan wrote: > > > On 10/04/2016 09:06 AM, Nitesh Konkar wrote: > > Currently the migration stream references the memory > > blocks by name (which is supplied by libvirt) rather > > than by there order. With the current code that is > > assigning

Re: [libvirt] [PATCH v2] qemu: report block job errors from qemu to the user

On 28.10.2016 20:57, John Ferlan wrote: > > No commit message... This definitely needs one. > > Also when there's one patch, you don't need a cover letter - instead you > put whatever "message" you want to give to reviewers, the pointer to the > previous version, changes with the current code,