[libvirt] [PATCH 4/5] qemu-caps: Get host model directly from Qemu when available

2016-11-02 Thread Jason J. Herne
From: "Collin L. Walling" When qmp query-cpu-model-expansion is available probe Qemu for its view of the host model. In kvm environments this can provide a more complete view of the host model because features supported by Qemu and Kvm can be considered.

[libvirt] [PATCH 5/5] s390: qemu: Support cpu host-model mode

2016-11-02 Thread Jason J. Herne
Look up the host model stored in qemuCaps for generation of the -cpu model portion of the Qemu command line. Signed-off-by: Jason J. Herne --- src/qemu/qemu_command.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/qemu/qemu_command.c

[libvirt] [PATCH 2/5] s390: Report blank host model instead of "host"

2016-11-02 Thread Jason J. Herne
From: "Collin L. Walling" On s390 , the host's features are heavily influenced by not only the host hardware but also by hardware microcode level, host OS version, qemu version and kvm version. In this environment it does not make sense to attempt to report exact host

[libvirt] [PATCH 3/5] qemu: qmp query-cpu-model-expansion command

2016-11-02 Thread Jason J. Herne
From: "Collin L. Walling" query-cpu-model-expansion is used to get a list of features for a given cpu model name or to get the model and features of the host hardware/environment as seen by Qemu/kvm. Signed-off-by: Collin L. Walling

[libvirt] [PATCH 1/5] s390: Cpu driver support for getModels, update and compare

2016-11-02 Thread Jason J. Herne
Implement getModels for s390. It returns an empty list. This means libvirt supports all models Qemu knows about. Implement compare for s390. Required to test the guest against the host for guest cpu model runnability checking. We always return IDENTICAL to bypass Libvirt's checking. s390 will

[libvirt] [RFC 0/5] Qemu: s390: Cpu Model Support

2016-11-02 Thread Jason J. Herne
Thanks for all your feedback up to this point. We've made some progress on this and we also have a few questions. Please let us know if we're on the right track or if we're off in the weeds on this. Here is what we have so far. Patch #1 updates s390's cpu driver to support some operations needed

Re: [libvirt] [PATCH] loopback is not always just lo

2016-11-02 Thread Daniel P. Berrange
On Tue, Nov 01, 2016 at 06:15:59PM +0300, Pavel Timofeev wrote: > On BSD family OSes (Free/Net/Open/DragonFlyBSD, Mac OS) and > Solaris loopback interface is called 'lo0' instead of just 'lo'. > > --- > src/network/bridge_driver.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git

Re: [libvirt] [glib 3/5] gconfig: Create objects for all domain device nodes

2016-11-02 Thread Christophe Fergeau
Hey, On Tue, Nov 01, 2016 at 05:46:05PM +0100, Zeeshan Ali wrote: > Currently we can and do get into serious trouble with this kind of code: > > devices = gvir_config_domain_get_devices(domain); > gvir_config_domain_set_devices(domain, domain); > > since the first call above won't return a

Re: [libvirt] [PATCH 3/6] qemu: Add support for parsing iotune group setting

2016-11-02 Thread Erik Skultety
On Mon, Oct 31, 2016 at 05:22:59PM -0400, John Ferlan wrote: > Add support to read/parse the iotune group setting for qemu. > > Signed-off-by: John Ferlan > --- > include/libvirt/libvirt-domain.h | 8 + > src/conf/domain_conf.c | 1 + > src/conf/domain_conf.h

[libvirt] [PATCH] qemu: fix libvirtd crash when querying halted cpus info

2016-11-02 Thread Maxim Nestratov
It was introduced by commit 7a51d9ebb, which started to use monitor commands without job acquiring, which is unsafe and leads to simultaneous access to vm->mon structure by different threads. Crash backtrace is the following (shortened): Program received signal SIGSEGV, Segmentation fault.

Re: [libvirt] [PATCH] qemu: fix libvirtd crash when querying halted cpus info

2016-11-02 Thread Viktor Mihajlovski
On 02.11.2016 16:56, Maxim Nestratov wrote: > It was introduced by commit 7a51d9ebb, which started to use > monitor commands without job acquiring, which is unsafe and leads > to simultaneous access to vm->mon structure by different threads. > > Crash backtrace is the following (shortened): > >

[libvirt] [PATCH v2 05/15] tests: qemucaps: Add QMP introspection data for qemu 2.5.0 on x86

2016-11-02 Thread Peter Krempa
From: Pavel Hrdina Add output of 'query-qmp-schema' to the capabilities test. Signed-off-by: Peter Krempa --- .../qemucapabilitiesdata/caps_2.5.0.x86_64.replies | 7545 1 file changed, 7545 insertions(+) diff --git

[libvirt] [PATCH v2 09/15] tests: qemucaps: Temporarily remove 'query-qmp-schema' from test data

2016-11-02 Thread Peter Krempa
Remove the command from the supported commands list temporarily so that QMP introspection code can be added without breaking tests and having to tweak the test data in the same commit. This will be later reverted and test data will be added. The aarch64 code is special as it calls additional

[libvirt] [PATCH v2 14/15] qemu: conf: add option for tuning debug logging level

2016-11-02 Thread Peter Krempa
From: Prasanna Kumar Kalever This helps in selecting log level of the gluster gfapi, output to stderr. The option is 'gluster_debug_level', can be tuned by editing '/etc/libvirt/qemu.conf' Debug levels ranges 0-9, with 9 being the most verbose, and 0 representing no

[libvirt] [PATCH v2 02/15] qemu: monitor: Add code to retrieve and store QMP schema data

2016-11-02 Thread Peter Krempa
Call 'query-qmp-schema' and store the returned types in a hash table keyed by the 'name' field so that the capabilities code can traverse it. --- src/qemu/qemu_monitor.c | 11 src/qemu/qemu_monitor.h | 2 ++ src/qemu/qemu_monitor_json.c | 67

[libvirt] [PATCH v2 15/15] qemu: command: Add debug option for gluster volumes

2016-11-02 Thread Peter Krempa
From: Prasanna Kumar Kalever Propagate the selected or default level to qemu if it's supported. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1376009 Signed-off-by: Prasanna Kumar Kalever Signed-off-by: Peter Krempa

[libvirt] [PATCH v2 11/15] qemu: capabilities: Detect support for gluster debug setting

2016-11-02 Thread Peter Krempa
From: Prasanna Kumar Kalever Teach qemu driver to detect whether qemu supports specifying debug level for gluster volumes. Signed-off-by: Prasanna Kumar Kalever Signed-off-by: Peter Krempa ---

[libvirt] [PATCH v2 03/15] tests: qemucaps: Update ppc64 replies for qemu 2.6.0 release

2016-11-02 Thread Peter Krempa
From: Andrea Bolognani Sync up to the released version of qemu. Signed-off-by: Peter Krempa --- .../qemucapabilitiesdata/caps_2.6.0.ppc64le.replies | 21 +++-- tests/qemucapabilitiesdata/caps_2.6.0.ppc64le.xml | 4 +++- 2 files

[libvirt] [PATCH v2 10/15] qemu: capabilities: Add support for QMP schema introspection

2016-11-02 Thread Peter Krempa
Allow detecting capabilities according to the qemu QMP schema. This is necessary as sometimes the availability of certain options depends on the presence of a field in the schema. This patch adds support for loading the QMP schema when detecting qemu capabilities and adds a very simple query

[libvirt] [PATCH v2 04/15] tests: qemucaps: Update aarch64 gicv2 replies for qemu 2.6.0 release

2016-11-02 Thread Peter Krempa
From: Andrea Bolognani Sync up to the released version of qemu. Signed-off-by: Peter Krempa --- tests/qemucapabilitiesdata/caps_2.6.0-gicv2.aarch64.replies | 13 - tests/qemucapabilitiesdata/caps_2.6.0-gicv2.aarch64.xml | 2 +- 2 files

[libvirt] [PATCH v2 00/15] qemu: Add QMP introspection and gluster debug support

2016-11-02 Thread Peter Krempa
Now that the release is out, I fixed the few things pointed out. Andrea Bolognani (5): tests: qemucaps: Update ppc64 replies for qemu 2.6.0 release tests: qemucaps: Update aarch64 gicv2 replies for qemu 2.6.0 release tests: qemucaps: Add QMP introspection data for qemu 2.6.0 on ppc64le

[libvirt] [PATCH v2 01/15] util: json: add helper to iterate and steal members of json array

2016-11-02 Thread Peter Krempa
Simplifies cases where JSON array members need to be transferred to a different structure. --- Notes: v2: - iterate from beginning - add option to keep array member in the array without breaking iteration - documented callback return codes src/libvirt_private.syms | 1 +

Re: [libvirt] [PATCH v4 2/6] conf, qemu: Add newer shmem models

2016-11-02 Thread Peter Krempa
On Wed, Nov 02, 2016 at 12:10:21 +0100, Martin Kletzander wrote: > On Wed, Nov 02, 2016 at 10:45:36AM +0100, Peter Krempa wrote: > >On Wed, Oct 26, 2016 at 12:51:33 +0200, Martin Kletzander wrote: > >> The old ivshmem is deprecated in QEMU, so let's use the better > >> ivshmem-{plain,doorbell}

Re: [libvirt] [PATCH v4 6/6] qemu: Add support for hot/cold-(un)plug of shmem devices

2016-11-02 Thread Peter Krempa
On Wed, Oct 26, 2016 at 12:51:37 +0200, Martin Kletzander wrote: > This is needed in order to migrate a domain with shmem devices as that > is not allowed to migrate. > > Signed-off-by: Martin Kletzander > --- > src/qemu/qemu_driver.c | 39 +++-

Re: [libvirt] [PATCH 0/6] Add group_name support for

2016-11-02 Thread Martin Kletzander
On Mon, Oct 31, 2016 at 05:22:56PM -0400, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1336564 Add support for "group" name in . The odd thing about the group name is that support was added in qemu after the _max parameters, but before the _max_length - so when building the

Re: [libvirt] [PATCH] qemu: Reset post-copy capability after migration

2016-11-02 Thread Jiri Denemark
On Wed, Nov 02, 2016 at 15:31:12 +0100, Martin Kletzander wrote: > On Wed, Nov 02, 2016 at 03:01:41PM +0100, Jiri Denemark wrote: > >Unlike other migration capabilities, post-copy is also set on the > >destination host which means it doesn't disappear once domain is > >migrated. As a result of

Re: [libvirt] [PATCH 6/6] virsh: Add group name to blkdeviotune output

2016-11-02 Thread Martin Kletzander
On Mon, Oct 31, 2016 at 05:23:02PM -0400, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1336564 Add the ability to set/display the group_name for block device iotune Signed-off-by: John Ferlan --- tools/virsh-domain.c | 17 + tools/virsh.pod

Re: [libvirt] [PATCH 5/6] qemu: Add the group name option to the iotune command line

2016-11-02 Thread Martin Kletzander
On Mon, Oct 31, 2016 at 05:23:01PM -0400, John Ferlan wrote: Add in the block I/O throttling group parameter to the command line if supported. If not supported, fail command creation. Add the xml2argvtest for testing. Signed-off-by: John Ferlan --- src/qemu/qemu_command.c

Re: [libvirt] [PATCH 4/6] conf: Add support for blkiotune group_name option

2016-11-02 Thread Martin Kletzander
On Mon, Oct 31, 2016 at 05:23:00PM -0400, John Ferlan wrote: Modify _virDomainBlockIoTuneInfo and rng schema to support the group_name option for iotune throttling. Document the new value. Signed-off-by: John Ferlan --- docs/formatdomain.html.in |

Re: [libvirt] [PATCH 3/6] qemu: Add support for parsing iotune group setting

2016-11-02 Thread Martin Kletzander
On Wed, Nov 02, 2016 at 03:24:10PM +0100, Martin Kletzander wrote: On Mon, Oct 31, 2016 at 05:22:59PM -0400, John Ferlan wrote: Add support to read/parse the iotune group setting for qemu. Signed-off-by: John Ferlan --- include/libvirt/libvirt-domain.h | 8 +

Re: [libvirt] [PATCH] qemu: Reset post-copy capability after migration

2016-11-02 Thread Martin Kletzander
On Wed, Nov 02, 2016 at 03:01:41PM +0100, Jiri Denemark wrote: Unlike other migration capabilities, post-copy is also set on the destination host which means it doesn't disappear once domain is migrated. As a result of that other functionality which internally uses migration to a file

Re: [libvirt] [PATCH 3/6] qemu: Add support for parsing iotune group setting

2016-11-02 Thread Martin Kletzander
On Mon, Oct 31, 2016 at 05:22:59PM -0400, John Ferlan wrote: Add support to read/parse the iotune group setting for qemu. Signed-off-by: John Ferlan --- include/libvirt/libvirt-domain.h | 8 + src/conf/domain_conf.c | 1 + src/conf/domain_conf.h | 1

[libvirt] [PATCH v4 6/7] spec: enable libssh transport on Fedora

2016-11-02 Thread Pino Toscano
--- libvirt.spec.in | 10 ++ 1 file changed, 10 insertions(+) diff --git a/libvirt.spec.in b/libvirt.spec.in index 545990c..2297389 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -80,6 +80,7 @@ %define with_firewalld 0%{!?_without_firewalld:0} %define with_libssh2

[libvirt] [PATCH v4 3/7] virnetsocket: improve search for default SSH key

2016-11-02 Thread Pino Toscano
Add a couple of helper functions to check whether one of the default names of SSH keys (as documented in ssh-keygen(1)) exists, and use them to specify a key for the libssh2 transport if none was passed. --- src/rpc/virnetclient.c | 61 +- 1 file

[libvirt] [PATCH v4 5/7] remote: expose a new libssh transport

2016-11-02 Thread Pino Toscano
Implement in virtNetClient and VirNetSocket the needed functions to expose a new libssh transport, providing all the options that the libssh2 transport supports. --- docs/remote.html.in| 35 ++--- src/remote/remote_driver.c | 41 +++ src/rpc/virnetclient.c | 106

[libvirt] [PATCH v4 7/7] docs: fix default value for sshauth option of libssh2/libssh

2016-11-02 Thread Pino Toscano
Both transports include "password" in their default authentication methods. --- docs/remote.html.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/remote.html.in b/docs/remote.html.in index c28a505..9d3c2ec 100644 --- a/docs/remote.html.in +++ b/docs/remote.html.in

[libvirt] [PATCH v4 2/7] virerror: add error for libssh transport

2016-11-02 Thread Pino Toscano
Add a new error domain and number for a new libssh-based transport. --- include/libvirt/virterror.h | 2 ++ src/util/virerror.c | 9 - 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/include/libvirt/virterror.h b/include/libvirt/virterror.h index efe83aa..2efee8f

[libvirt] [PATCH v4 1/7] virNetSocket: allow to not close FD

2016-11-02 Thread Pino Toscano
Add an internal variable to mark the FD as "not owned" by the virNetSocket, in case the internal implementation takes the actual ownership of the descriptor; this avoids a warning when closing the socket, as the FD would be invalid. --- src/rpc/virnetsocket.c | 5 - 1 file changed, 4

[libvirt] [PATCH v4 4/7] libssh_transport: add new libssh-based transport

2016-11-02 Thread Pino Toscano
Implement a new libssh transport, which uses libssh to communicate with remote hosts, and add all the build system stuff (search of libssh, private symbols, etc) to built it. This new transport supports all the common ssh authentication methods, making use of libvirt's auth callbacks for

[libvirt] [PATCH v4 0/7] New libssh transport

2016-11-02 Thread Pino Toscano
Hi, this series introduces a new libssh transport in libvirt, based on the libssh C library. This library supports what libssh2 does, and more: - easier API for known_hosts handling (there's a ticket upstream to request extensions for it, but what is implemented now works well) - potential

[libvirt] [PATCH] qemu: Reset post-copy capability after migration

2016-11-02 Thread Jiri Denemark
Unlike other migration capabilities, post-copy is also set on the destination host which means it doesn't disappear once domain is migrated. As a result of that other functionality which internally uses migration to a file (virDomainManagedSave, virDomainSave, virDomainCoreDump) may fail after

Re: [libvirt] [glib 5/5] gconfig, tests: Add test case for unknown devices

2016-11-02 Thread Daniel P. Berrange
On Tue, Nov 01, 2016 at 05:46:07PM +0100, Zeeshan Ali wrote: > --- > tests/test-gconfig.c | 22 ++ > 1 file changed, 22 insertions(+) > > diff --git a/tests/test-gconfig.c b/tests/test-gconfig.c > index 5389a26..b91f5af 100644 > --- a/tests/test-gconfig.c > +++

Re: [libvirt] [glib 4/5] gconfig, tests: Separate XML loading function

2016-11-02 Thread Daniel P. Berrange
On Tue, Nov 01, 2016 at 05:46:06PM +0100, Zeeshan Ali wrote: > We'll need to load XML from file in another function, that will be added > in a following patch. > --- > tests/test-gconfig.c | 15 +-- > 1 file changed, 13 insertions(+), 2 deletions(-) ACK Regards, Daniel -- |:

Re: [libvirt] [glib 3/5] gconfig: Create objects for all domain device nodes

2016-11-02 Thread Daniel P. Berrange
On Tue, Nov 01, 2016 at 05:46:05PM +0100, Zeeshan Ali wrote: > Currently we can and do get into serious trouble with this kind of code: > > devices = gvir_config_domain_get_devices(domain); > gvir_config_domain_set_devices(domain, domain); > > since the first call above won't return a complete

Re: [libvirt] [glib 2/5] gconfig: DomainDevice now instantiable

2016-11-02 Thread Daniel P. Berrange
On Tue, Nov 01, 2016 at 05:46:04PM +0100, Zeeshan Ali wrote: > We'll need to instatiate DomainDevice baseclass itself for unknown (think > new devices added to libvirt XML) devices in a following patch. This > change makes that possible. > > This doesn't break any API or ABI to the best of my

Re: [libvirt] [glib 1/5] gconfig: Allow schema to be NULL

2016-11-02 Thread Daniel P. Berrange
On Tue, Nov 01, 2016 at 05:46:03PM +0100, Zeeshan Ali wrote: > Validation (if attempted) should just fail in this case instead of > crashing. > --- > libvirt-gconfig/libvirt-gconfig-object.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/libvirt-gconfig/libvirt-gconfig-object.c

Re: [libvirt] [PATCH v4 5/6] qemu: Support newer ivshmem device variants

2016-11-02 Thread Peter Krempa
On Wed, Oct 26, 2016 at 12:51:36 +0200, Martin Kletzander wrote: > QEMU added support for ivshmem-plain and ivshmem-doorbell. Those are > reworked varians of legacy ivshmem that are compatible from the guest > POV, but not from host's POV and have sane specification and handling. > > Details

Re: [libvirt] [PATCH v4 4/6] qemu: Save various defaults for shmem

2016-11-02 Thread Peter Krempa
On Wed, Oct 26, 2016 at 12:51:35 +0200, Martin Kletzander wrote: > We're keeping some things at default and that's not something we want to > do intentionally. Let's save some sensible defaults upfront in order to > avoid having problems later. The details for the defaults (of the newer >

[libvirt] [python PATCH] Post-release version bump to 2.5.0

2016-11-02 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- Pushed as trivial. setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.py b/setup.py index 683dc93..ed11e2e 100755 --- a/setup.py +++ b/setup.py @@ -307,7 +307,7 @@ class my_clean(clean): _c_modules,

Re: [libvirt] [Qemu-devel] pci-assign fails with read error on config-space file

2016-11-02 Thread Henning Schild
Am Wed, 2 Nov 2016 09:54:16 + schrieb "Daniel P. Berrange" : > On Fri, Oct 28, 2016 at 01:28:19PM +0200, Henning Schild wrote: > > Hey, > > > > i am running an unusual setup where i assign pci devices behind the > > back of libvirt. I have two options to do that: > > 1.

Re: [libvirt] [PATCH v4 2/6] conf, qemu: Add newer shmem models

2016-11-02 Thread Martin Kletzander
On Wed, Nov 02, 2016 at 10:45:36AM +0100, Peter Krempa wrote: On Wed, Oct 26, 2016 at 12:51:33 +0200, Martin Kletzander wrote: The old ivshmem is deprecated in QEMU, so let's use the better ivshmem-{plain,doorbell} variants instead. Signed-off-by: Martin Kletzander ---

Re: [libvirt] [PATCH] Fill out more fields for PKG-INFO file

2016-11-02 Thread Martin Kletzander
On Wed, Nov 02, 2016 at 09:46:50AM +, Daniel P. Berrange wrote: Ensure the description and license are set in PKG-INFO, and clarify the summary field. Signed-off-by: Daniel P. Berrange --- setup.py | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) ACK. I

Re: [libvirt] [libvirt-users] pci-assign fails with read error on config-space file

2016-11-02 Thread Henning Schild
Am Fri, 28 Oct 2016 11:25:55 -0400 schrieb Laine Stump : > On 10/28/2016 07:28 AM, Henning Schild wrote: > > Hey, > > > > i am running an unusual setup where i assign pci devices behind the > > back of libvirt. I have two options to do that: > > 1. a wrapper script for qemu that

Re: [libvirt] [PATCH v3 4/6] remote: expose a new libssh transport

2016-11-02 Thread Pino Toscano
On Tuesday, 1 November 2016 13:40:01 CET Peter Krempa wrote: > On Wed, Oct 19, 2016 at 14:40:37 +0200, Pino Toscano wrote: > > Implement in virtNetClient and VirNetSocket the needed functions to > > expose a new libssh transport, providing all the options that the > > libssh2 transport supports. >

Re: [libvirt] [Qemu-devel] pci-assign fails with read error on config-space file

2016-11-02 Thread Daniel P. Berrange
On Fri, Oct 28, 2016 at 01:28:19PM +0200, Henning Schild wrote: > Hey, > > i am running an unusual setup where i assign pci devices behind the > back of libvirt. I have two options to do that: > 1. a wrapper script for qemu that takes care of suid-root and appends > arguments for pci-assign > 2.

[libvirt] [PATCH] Fill out more fields for PKG-INFO file

2016-11-02 Thread Daniel P. Berrange
Ensure the description and license are set in PKG-INFO, and clarify the summary field. Signed-off-by: Daniel P. Berrange --- setup.py | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/setup.py b/setup.py index 683dc93..5ad4101 100755 --- a/setup.py

Re: [libvirt] [PATCH v4 2/6] conf, qemu: Add newer shmem models

2016-11-02 Thread Peter Krempa
On Wed, Oct 26, 2016 at 12:51:33 +0200, Martin Kletzander wrote: > The old ivshmem is deprecated in QEMU, so let's use the better > ivshmem-{plain,doorbell} variants instead. > > Signed-off-by: Martin Kletzander > --- > docs/formatdomain.html.in | 10 +++--- >

Re: [libvirt] [PATCH v4 3/6] qemu: Add capabilities for ivshmem-{plain, doorbell}

2016-11-02 Thread Peter Krempa
On Wed, Oct 26, 2016 at 12:51:34 +0200, Martin Kletzander wrote: > Signed-off-by: Martin Kletzander > --- > src/qemu/qemu_capabilities.c | 5 ++ > src/qemu/qemu_capabilities.h | 4 ++ > .../caps_2.6.0-gicv2.aarch64.xml

Re: [libvirt] [PATCH v3 3/6] libssh_transport: add new libssh-based transport

2016-11-02 Thread Pino Toscano
On Tuesday, 1 November 2016 13:20:28 CET Peter Krempa wrote: > On Wed, Oct 19, 2016 at 14:40:36 +0200, Pino Toscano wrote: > > Implement a new libssh transport, which uses libssh to communicate with > > remote hosts, and add all the build system stuff (search of libssh, > > private symbols, etc)

Re: [libvirt] [PATCH v4 1/6] conf, qemu: Add support for shmem model

2016-11-02 Thread Peter Krempa
On Wed, Oct 26, 2016 at 12:51:32 +0200, Martin Kletzander wrote: > Just the default one now, new ones will be added in following commits. > > Signed-off-by: Martin Kletzander > --- > docs/formatdomain.html.in | 8 + >

Re: [libvirt] [Qemu-devel] pci-assign fails with read error on config-space file

2016-11-02 Thread Henning Schild
Am Fri, 28 Oct 2016 17:22:41 +0200 schrieb Laszlo Ersek : > On 10/28/16 13:28, Henning Schild wrote: > > Hey, > > > > i am running an unusual setup where i assign pci devices behind the > > back of libvirt. I have two options to do that: > > 1. a wrapper script for qemu that

[libvirt] [PATCH v3 2/2] qemu: report drive mirror errors on migration

2016-11-02 Thread Nikolay Shirokovskiy
--- src/qemu/qemu_blockjob.c | 14 +--- src/qemu/qemu_blockjob.h | 3 ++- src/qemu/qemu_driver.c| 4 ++-- src/qemu/qemu_migration.c | 54 +-- 4 files changed, 53 insertions(+), 22 deletions(-) diff --git a/src/qemu/qemu_blockjob.c

[libvirt] [PATCH v3] qemu: report block job errors from qemu to the user

2016-11-02 Thread Nikolay Shirokovskiy
So that you can see nice report on migration: "error: operation failed: migration of disk sda failed: No space left on device" diff from v2: 1. split into 2 patches 2. change formal documentation where it is present accordingly 3. add variable initialization for safety Nikolay Shirokovskiy (2):

[libvirt] [PATCH v3 1/2] qemu: prepare blockjob complete event error usage

2016-11-02 Thread Nikolay Shirokovskiy
This patch pass event error up to the place where we can use it. Error is passed only for sync blockjob event mode as we can't use the error in async mode. In async mode we just pass the event details to the client thru event API but current blockjob event API can not carry extra parameter. ---

[libvirt] [PATCH 8/8] qemu: Ignore CPU usability when accel doesn't match

2016-11-02 Thread Jiri Denemark
CPU model usability differs with domain type (qemu vs. kvm). Thus when querying domain capabilities for a domain type which doesn't match machine accel={kvm|tcg} used when probing QEMU we need to ignore the usability data to avoid giving misleading results to users. Signed-off-by: Jiri Denemark

[libvirt] [PATCH 3/8] qemu: Add flags to virQEMUCapsNewForBinaryInternal

2016-11-02 Thread Jiri Denemark
Currently qmpOnly is the only bool parameter of virQEMUCapsNewForBinaryInternal, but we will need to add more. Let's turn the bool parameter into flags. Signed-off-by: Jiri Denemark --- src/qemu/qemu_capabilities.c | 27 +++ src/qemu/qemu_capspriv.h

[libvirt] [PATCH 5/8] qemu: Store loaded QEMU binary ctime in qemuCaps

2016-11-02 Thread Jiri Denemark
virQEMUCapsLoadCache loads QEMU capabilities from a file, but strangely enough it returns the loaded QEMU binary ctime in qemuctime parameter instead of storing it in qemuCaps. Signed-off-by: Jiri Denemark --- src/qemu/qemu_capabilities.c | 10 +-

[libvirt] [PATCH 2/8] tests: Add QEMU 2.8.0 capabilities data

2016-11-02 Thread Jiri Denemark
Signed-off-by: Jiri Denemark --- tests/domaincapsschemadata/qemu_2.8.0.x86_64.xml | 116 + tests/domaincapstest.c |4 + .../qemucapabilitiesdata/caps_2.8.0.x86_64.replies | 5239

[libvirt] [PATCH 0/8] qemu: Add support for unavailable-features

2016-11-02 Thread Jiri Denemark
QEMU 2.8.0 adds support for unavailable-features in query-cpu-definitions reply. The unavailable-features array lists CPU features which prevent a corresponding CPU model from being usable on current host. It can only be used when all the unavailable features are disabled. Empty array means the

[libvirt] [PATCH 4/8] qemu: Enable KVM when probing capabilities

2016-11-02 Thread Jiri Denemark
CPU related capabilities may differ depending on accelerator used when probing. Let's use KVM if available and fall back to TCG. Signed-off-by: Jiri Denemark --- Notes: Or should we perhaps start probing QEMU in both TCG and KVM mode since some capabilities may

[libvirt] [PATCH 7/8] qemu: Discard caps cache when KVM availability changes

2016-11-02 Thread Jiri Denemark
Since CPU capabilities depend on accelerator used when probing QEMU the cache becomes invalid when KVM becomes available or if it is not available anymore. Signed-off-by: Jiri Denemark --- src/qemu/qemu_capabilities.c | 37 -

[libvirt] [PATCH 6/8] qemu: Unify cached caps validity checks

2016-11-02 Thread Jiri Denemark
Let's keep all run time validation of cached QEMU capabilities in virQEMUCapsIsValid and call it whenever we access the cache. virQEMUCapsInitCached should keep only the checks which do not make sense once the cache is loaded in memory. Signed-off-by: Jiri Denemark ---

[libvirt] [PATCH 1/8] qemu: Add support for unavailable-features

2016-11-02 Thread Jiri Denemark
QEMU 2.8.0 adds support for unavailable-features in query-cpu-definitions reply. The unavailable-features array lists CPU features which prevent a corresponding CPU model from being usable on current host. It can only be used when all the unavailable features are disabled. Empty array means the

Re: [libvirt] [PATCH v2] qemu: report block job errors from qemu to the user

2016-11-02 Thread Nikolay Shirokovskiy
On 31.10.2016 10:10, Nikolay Shirokovskiy wrote: > > > On 28.10.2016 20:57, John Ferlan wrote: >> >> No commit message... This definitely needs one. >> >> Also when there's one patch, you don't need a cover letter - instead you >> put whatever "message" you want to give to reviewers, the

[libvirt] [PATCH] Post-release version bump to 2.5.0

2016-11-02 Thread Jiri Denemark
Signed-off-by: Jiri Denemark --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index dfc536f..9785e66 100644 --- a/configure.ac +++ b/configure.ac @@ -16,7 +16,7 @@ dnl You should have received a copy of the GNU