[libvirt] [PATCH] BlockCopy support rbd external destination file

Currently qemuDomainBlockCopy only support local file. This patch make the rbd external destination file could be passed to qemu driver_mirror. If the external rbd file is not exist, qemuDomainBlockCopy will report an error. Signed-off-by: Liu Qing --- src/qemu/qemu_driver.c

[libvirt] [PATCH v3 02/10] qemu: Introduce vhost-scsi capability

Do all the stuff for the vhost-scsi capability in QEMU, so it's in place for our checks later. Signed-off-by: Eric Farman Reviewed-by: Boris Fiuczynski --- src/qemu/qemu_capabilities.c| 2 ++

[libvirt] [PATCH v3 08/10] security: Include vhost-scsi in security labels

Signed-off-by: Eric Farman --- src/security/security_apparmor.c | 18 - src/security/security_dac.c | 42 ++-- src/security/security_selinux.c | 39 +++-- 3 files changed, 94

[libvirt] [PATCH v3 06/10] qemu: Allow hotplug of vhost-scsi device

Adjust the device string that is built for vhost-scsi devices so that it can be invoked from hotplug. >From the QEMU command line, the file descriptors are expect to be numeric only. However, for hotplug, the file descriptors are expected to begin with at least one alphabetic character else this

[libvirt] [PATCH v3 09/10] tests: Introduce basic vhost-scsi test

These tests were cloned from hostdev-scsi-virtio-scsi in both xml2argv and xml2xml Signed-off-by: Eric Farman Reviewed-by: Boris Fiuczynski --- .../qemuxml2argv-hostdev-scsi-vhost-scsi.args | 24 +

[libvirt] [PATCH v3 04/10] util: Management routines for scsi_host devices

Signed-off-by: Eric Farman --- po/POTFILES.in | 1 + src/Makefile.am | 1 + src/libvirt_private.syms | 19 +++ src/util/virhost.c | 299 +++ src/util/virhost.h | 72

[libvirt] [PATCH v3 03/10] Introduce a "scsi_host" hostdev type

We already have a "scsi" hostdev type, which refers to a single LUN that is passed through to a guest. But what of things where multiple LUNs are passed through via a single SCSI HBA, such as with the vhost-scsi target? Create a new hostdev type that will carry this. Signed-off-by: Eric Farman

[libvirt] [PATCH v3 10/10] docs: Add vhost-scsi

Signed-off-by: Eric Farman --- docs/formatdomain.html.in | 24 1 file changed, 24 insertions(+) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 11b3330..ed96ca4 100644 --- a/docs/formatdomain.html.in +++

[libvirt] [PATCH v3 07/10] conf: Wire up the vhost-scsi connection from/to XML

Signed-off-by: Eric Farman --- docs/schemas/domaincommon.rng | 23 src/conf/domain_audit.c | 7 src/conf/domain_conf.c| 81 +-- 3 files changed, 109 insertions(+), 2 deletions(-) diff --git

[libvirt] [PATCH v3 05/10] qemu: Add vhost-scsi string for -device parameter

Open /dev/vhost-scsi, and record the resulting file descriptor, so that the guest has access to the host device outside of the libvirt daemon. Pass this information, along with data parsed from the XML file, to build a device string for the qemu command line. That device string will be for either

[libvirt] [PATCH v3 01/10] Cleanup switch statements on the hostdev subsystem type

As was suggested in an earlier review comment[1], we can catch some additional code points by cleaning up how we use the hostdev subsystem type in some switch statements. [1] End of https://www.redhat.com/archives/libvir-list/2016-September/msg00399.html Signed-off-by: Eric Farman

[libvirt] [PATCH RESEND v3.2 00/10] Implementation of QEMU vhost-scsi

[NOTE: Resending after a week, and rebased to apply to master after last week's application of commit 22d94ca4] This patch series provides a libvirt implementation of the vhost-scsi interface in QEMU. As near as I can see, this was discussed upstream in July 2014[1], and ended in a desire to

Re: [libvirt] [PATCH v6 09/17] [ACKED] qemu: only force an available legacy-PCI slot on domains with pci-root

On Mon, 2016-11-07 at 14:50 -0500, Laine Stump wrote: > Andrea had the right idea when he disabled the "reserve an extra > unused slot" bit for aarch64/virt. You bet I did! :P > For *any* PCI Express-based > machine, it is pointless since 1) an extra legacy-PCI slot can't be > used for hotplug,

Re: [libvirt] [PATCH v2 00/19] Redo website layout and branding

On Tue, Nov 08, 2016 at 04:11:05PM +0100, Martin Kletzander wrote: > On Tue, Nov 08, 2016 at 01:50:33PM +, Daniel P. Berrange wrote: > > On Tue, Nov 08, 2016 at 02:48:07PM +0100, Martin Kletzander wrote: > > > On Tue, Nov 08, 2016 at 11:50:11AM +, Daniel P. Berrange wrote: > > > > The

Re: [libvirt] [PATCH v6 08/17] qemu: assign nec-xhci (USB3) controller to a PCIe address when appropriate

On Mon, 2016-11-07 at 14:50 -0500, Laine Stump wrote: > The nec-usb-xhci device (which is a USB3 controller) has always > presented itself as a PCI device when plugged into a legacy PCI slot, > and a PCIe device when plugged into a PCIe slot, but libvirt has > always auto-assigned it to a legacy

Re: [libvirt] [PATCH v2 18/19] docs: remove outdated or duplicated content

On 08.11.2016 12:50, Daniel P. Berrange wrote: > Remove a bunch of pages which are either outdated, have no > content, or duplicate content better described elsewhere > in the site or wiki. > > Signed-off-by: Daniel P. Berrange > --- > docs/archdomain.html.in | 7 --

Re: [libvirt] [PATCH v2 00/19] Redo website layout and branding

On Tue, Nov 08, 2016 at 04:11:05PM +0100, Martin Kletzander wrote: > On Tue, Nov 08, 2016 at 01:50:33PM +, Daniel P. Berrange wrote: > > On Tue, Nov 08, 2016 at 02:48:07PM +0100, Martin Kletzander wrote: > > > On Tue, Nov 08, 2016 at 11:50:11AM +, Daniel P. Berrange wrote: > > > > The

Re: [libvirt] [PATCH v2 00/19] Redo website layout and branding

On Tue, Nov 08, 2016 at 01:50:33PM +, Daniel P. Berrange wrote: On Tue, Nov 08, 2016 at 02:48:07PM +0100, Martin Kletzander wrote: On Tue, Nov 08, 2016 at 11:50:11AM +, Daniel P. Berrange wrote: > The current libvirt website design dates from 2008 and > has not changed significantly

Re: [libvirt] [PATCH v6 07/17] qemu: assign e1000e network devices to PCIe slots when appropriate

On Mon, 2016-11-07 at 14:50 -0500, Laine Stump wrote: > The e1000e is an emulated network device based on the Intel 82574, > present in qemu 2.7.0 and later. Among other differences from the > e1000, it presents itself as a PCIe device rather than legacy PCI. In > order to get it assigned to a

Re: [libvirt] [PATCH v2 09/19] docs: add three core links in the header bar

On Tue, Nov 08, 2016 at 03:31:07PM +0100, Kashyap Chamarthy wrote: > On Tue, Nov 08, 2016 at 03:08:57PM +0100, Pavel Hrdina wrote: > > On Tue, Nov 08, 2016 at 11:50:20AM +, Daniel P. Berrange wrote: > > [...] > > > > + > > > + Download > > > + Contribute

Re: [libvirt] [PATCH v2 00/19] Redo website layout and branding

On Tue, Nov 08, 2016 at 03:24:25PM +0100, Michal Privoznik wrote: > On 08.11.2016 12:50, Daniel P. Berrange wrote: > > > > View the new site here > > > > v2: https://berrange.fedorapeople.org/libvirt-new-website-v2/ > > BTW: probably not your fault, but when I enter something into the search >

Re: [libvirt] [PATCH v2 09/19] docs: add three core links in the header bar

On Tue, Nov 08, 2016 at 03:08:57PM +0100, Pavel Hrdina wrote: > On Tue, Nov 08, 2016 at 11:50:20AM +, Daniel P. Berrange wrote: [...] > > + > > + Download > > + Contribute > > + Learn > > This was already pointed out by Martin and I also

Re: [libvirt] [PATCH v6 06/17] qemu: assign virtio devices to PCIe slot when appropriate

On Mon, 2016-11-07 at 14:50 -0500, Laine Stump wrote: > libvirt previously assigned nearly all devices to a "hotpluggable" > legacy PCI slot even on machines with a PCIe root bus (and even though > most such machines don't even support hotplug on legacy PCI slots!) > Forcing all devices onto

Re: [libvirt] [PATCH v2 00/19] Redo website layout and branding

On 08.11.2016 12:50, Daniel P. Berrange wrote: > > View the new site here > > v2: https://berrange.fedorapeople.org/libvirt-new-website-v2/ BTW: probably not your fault, but when I enter something into the search box and hit enter I see some problems with the HTML returned: XML Parsing Error:

Re: [libvirt] [PATCH v2 00/19] Redo website layout and branding

On Tue, Nov 08, 2016 at 03:18:31PM +0100, Pavel Hrdina wrote: > On Tue, Nov 08, 2016 at 02:48:07PM +0100, Martin Kletzander wrote: > > On Tue, Nov 08, 2016 at 11:50:11AM +, Daniel P. Berrange wrote: > > >The current libvirt website design dates from 2008 and > > >has not changed significantly

Re: [libvirt] [PATCH 4/8] qemu: Enable KVM when probing capabilities

On Tue, Nov 08, 2016 at 03:02:31PM +0100, Pavel Hrdina wrote: > On Wed, Nov 02, 2016 at 10:22:33AM +0100, Jiri Denemark wrote: > > CPU related capabilities may differ depending on accelerator used when > > probing. Let's use KVM if available and fall back to TCG. > > > > Signed-off-by: Jiri

Re: [libvirt] [PATCH v2 00/19] Redo website layout and branding

On Tue, Nov 08, 2016 at 02:48:07PM +0100, Martin Kletzander wrote: > On Tue, Nov 08, 2016 at 11:50:11AM +, Daniel P. Berrange wrote: > >The current libvirt website design dates from 2008 and > >has not changed significantly since. Compared to > >contemporary open source project websites it

Re: [libvirt] [PATCH 2/2] qemu: Enable NUMA node tag in pci-root for PPC64

On 11/08/2016 05:59 PM, Daniel P. Berrange wrote: That doesn't really solve the bug above properly - your solution here only works if all the PCI devices (whether emulated or host-assigned) are to be associated with the same guest NUMA node. This is a pretty restrictive setup and so of limited

Re: [libvirt] [PATCH v2 09/19] docs: add three core links in the header bar

On Tue, Nov 08, 2016 at 11:50:20AM +, Daniel P. Berrange wrote: > Add links to download, communicate and learn in the > header bar, as the main jumping off points for > navigation. > > Signed-off-by: Daniel P. Berrange > --- > docs/libvirt.css | 28

Re: [libvirt] [PATCH 4/8] qemu: Enable KVM when probing capabilities

On Wed, Nov 02, 2016 at 10:22:33AM +0100, Jiri Denemark wrote: > CPU related capabilities may differ depending on accelerator used when > probing. Let's use KVM if available and fall back to TCG. > > Signed-off-by: Jiri Denemark > --- > > Notes: > Or should we perhaps

Re: [libvirt] [PATCH v2 00/19] Redo website layout and branding

BTW, this series fails to apply from email, due to long lines in the minimised javascript files. The patches are all available here: https://gitlab.com/berrange/libvirt on the 'website' branch. On Tue, Nov 08, 2016 at 11:50:11AM +, Daniel P. Berrange wrote: > The current libvirt website

Re: [libvirt] [PATCH v2 00/19] Redo website layout and branding

On Tue, Nov 08, 2016 at 02:48:07PM +0100, Martin Kletzander wrote: > On Tue, Nov 08, 2016 at 11:50:11AM +, Daniel P. Berrange wrote: > > The current libvirt website design dates from 2008 and > > has not changed significantly since. Compared to > > contemporary open source project websites it

Re: [libvirt] [PATCH v2 00/19] Redo website layout and branding

On Tue, Nov 08, 2016 at 11:50:11AM +, Daniel P. Berrange wrote: The current libvirt website design dates from 2008 and has not changed significantly since. Compared to contemporary open source project websites it looks pretty dated and cluttered. This series incrementally changes the

Re: [libvirt] [PATCH v2 02/19] docs: add master SVG for libvirt logo

On Tue, Nov 08, 2016 at 02:32:16PM +0100, Martin Kletzander wrote: > On Tue, Nov 08, 2016 at 12:39:40PM +, Daniel P. Berrange wrote: > > On Tue, Nov 08, 2016 at 01:32:54PM +0100, Martin Kletzander wrote: > > > On Tue, Nov 08, 2016 at 11:50:13AM +, Daniel P. Berrange wrote: > > > > Add the

Re: [libvirt] [PATCH v2 02/19] docs: add master SVG for libvirt logo

On Tue, Nov 08, 2016 at 12:39:40PM +, Daniel P. Berrange wrote: On Tue, Nov 08, 2016 at 01:32:54PM +0100, Martin Kletzander wrote: On Tue, Nov 08, 2016 at 11:50:13AM +, Daniel P. Berrange wrote: > Add the SVG files for the libvirt logo, along with corresponding > pre-rendered PNG

Re: [libvirt] [PATCH v2 08/19] docs: add page describing contribution to libvirt

On Tue, Nov 08, 2016 at 11:50:19AM +, Daniel P. Berrange wrote: Add a page that describes what contributions libvirt is looking for and how to get involved. Signed-off-by: Daniel P. Berrange --- docs/contribute.html.in | 140

Re: [libvirt] [PATCH v6 05/17] qemu: set pciConnectFlags to 0 instead of PCI|HOTPLUGGABLE if device isn't PCI

On Mon, 2016-11-07 at 14:50 -0500, Laine Stump wrote: > This patch cleans up the connect flags for certain types/models of > devices that aren't PCI to return 0. In the future that may be used as > an indicator to the caller about whether or not a device needs a PCI > address. For now it's just

Re: [libvirt] [PATCH v2 02/19] docs: add master SVG for libvirt logo

On Tue, Nov 08, 2016 at 01:32:54PM +0100, Martin Kletzander wrote: > On Tue, Nov 08, 2016 at 11:50:13AM +, Daniel P. Berrange wrote: > > Add the SVG files for the libvirt logo, along with corresponding > > pre-rendered PNG bitmaps at key sizes. Also add a README file > > describing how to

Re: [libvirt] [PATCH v2 02/19] docs: add master SVG for libvirt logo

On Tue, Nov 08, 2016 at 11:50:13AM +, Daniel P. Berrange wrote: Add the SVG files for the libvirt logo, along with corresponding pre-rendered PNG bitmaps at key sizes. Also add a README file describing how to modify the logos and their intended usages. Signed-off-by: Daniel P. Berrange

Re: [libvirt] [PATCH 2/2] qemu: Enable NUMA node tag in pci-root for PPC64

On Tue, Nov 08, 2016 at 05:35:38PM +0530, Shivaprasad G Bhat wrote: > This patch addresses the same aspects on PPC the bug 1103314 addressed > on x86. > > PCI expander bus creates multiple primary PCI busses, where each of these > busses can be assigned a specific NUMA affinity, which, on x86 is

[libvirt] [PATCH 2/2] qemu: Enable NUMA node tag in pci-root for PPC64

This patch addresses the same aspects on PPC the bug 1103314 addressed on x86. PCI expander bus creates multiple primary PCI busses, where each of these busses can be assigned a specific NUMA affinity, which, on x86 is advertised through ACPI on a per-bus basis. For SPAPR, a PHB's NUMA

[libvirt] [PATCH 1/2] qemu: capabilitity: Introduce QEMU_CAPS_SPAPR_PCI_HOST_BRIDGE_NUMA_NODE

The patch adds a capability for spapr-pci-host-bridge.numa_node. Signed-off-by: Shivaprasad G Bhat --- src/qemu/qemu_capabilities.c |7 ++ src/qemu/qemu_capabilities.h |1

[libvirt] [PATCH v2 12/19] Revert "syntax-check: Enforce inside elements"

This reverts commit 1f29f3da065ef12d3ec39c3c673186f8ea6d764e. Assuming is always used to document symbols is way too broad, requiring far too many exemptions to be marked to avoid syntax check rules. Signed-off-by: Daniel P. Berrange --- cfg.mk | 14

[libvirt] [PATCH v2 03/19] docs: switch to new website banner

Use a dark banner whose color matches the dark green used in the logo. Introduce a newly rendered version of the header logo derived from new SVG file, instead of old one from (now lost) Adobe Illustrator file. The top banner logo now links to the front page as is common practice for most

[libvirt] [PATCH v2 13/19] docs: rewrite content on front page to be more useful

The front page contains a bunch of content that is either outdated (eg links to libvirt qpid) or not particularly useful (links to vendor hypervisor sites). This rewrites it to be more directly useful to visitors, providing a updated intro to libvirt project, direct links to key pieces of website

[libvirt] [PATCH v2 15/19] docs: add some improved styling to contact page

Change the contact page styling to better distinguish the various mailing lists. Signed-off-by: Daniel P. Berrange --- docs/contact.html.in | 4 ++-- docs/libvirt.css | 15 +++ 2 files changed, 17 insertions(+), 2 deletions(-) diff --git

[libvirt] [PATCH v2 10/19] docs: remove todo page

The todo page used to be auto-generated from bugzilla but is no longer used. Signed-off-by: Daniel P. Berrange --- docs/Makefile.am | 35 ++ docs/sitemap.html.in | 4 -- docs/todo.cfg-example | 26 --- docs/todo.pl | 125

[libvirt] [PATCH v2 18/19] docs: remove outdated or duplicated content

Remove a bunch of pages which are either outdated, have no content, or duplicate content better described elsewhere in the site or wiki. Signed-off-by: Daniel P. Berrange --- docs/archdomain.html.in | 7 -- docs/archnetwork.html.in | 54 --

[libvirt] [PATCH v2 14/19] docs: expand downloads page to cover all modules

Previously the download page only covered the main libvirt module and the app dev guide. Expand it to provide direct links to all artifacts published by the project, whether the main library, language bindings, docs, or testing. Tweak the top table styling to better fit in with new branding.

[libvirt] [PATCH v2 08/19] docs: add page describing contribution to libvirt

Add a page that describes what contributions libvirt is looking for and how to get involved. Signed-off-by: Daniel P. Berrange --- docs/contribute.html.in | 140 1 file changed, 140 insertions(+) create mode 100644

[libvirt] [PATCH v2 17/19] docs: remove navigation sidebar from pages

A combination of the index page, top nav bar and docs.html page provide links to all pages on the site. The left hand nav bar is thus redundant and can be removed to provide a simpler style for the site. Signed-off-by: Daniel P. Berrange --- docs/Makefile.am | 8 +-

[libvirt] [PATCH v2 19/19] docs: add some content to the XML format main page

The XML format main page has never had any content in it, relying on the left navbar to provide links to the XML schema pages. Since the navbar is gone, the page needs to have some content created, otherwise it is useless. Signed-off-by: Daniel P. Berrange ---

[libvirt] [PATCH v2 06/19] docs: add footer to all pages

Add a footer to all pages containing a blurb about the code of conduct, and links to various communication channels / social media / user self-help sites. Signed-off-by: Daniel P. Berrange --- docs/libvirt.css | 46 ++

[libvirt] [PATCH v2 04/19] docs: redo style of front page

Use a large logo banner across the front page. Tile the three lists of links into three panels Signed-off-by: Daniel P. Berrange --- docs/404.html.in| 5 - docs/Makefile.am| 3 --- docs/index.html.in | 20 +--- docs/libvirt.css

[libvirt] [PATCH v2 00/19] Redo website layout and branding

The current libvirt website design dates from 2008 and has not changed significantly since. Compared to contemporary open source project websites it looks pretty dated and cluttered. This series incrementally changes the website to have a completely new layout and branding. Since the original

[libvirt] [PATCH v2 11/19] docs: remove related links page

The related links page is either horribly outdated, or duplicating stuff already linked elsewhere. Signed-off-by: Daniel P. Berrange --- docs/relatedlinks.html.in | 88 --- docs/sitemap.html.in | 4 --- 2 files changed, 92

[libvirt] [PATCH v2 16/19] docs: fill out docs page with useful links

The docs page is currently completely empty. Fill it in with links to the various documentation, categorized as to whether it is targetting people deploying libvirt, application developers using libvirt, or people working on libvirt itself. Signed-off-by: Daniel P. Berrange

[libvirt] [PATCH v2 07/19] docs: simplify style for headers

Remove the 1px border underneath all headers and make them use black text to simplify visual appearance Signed-off-by: Daniel P. Berrange --- docs/generic.css | 1 - docs/libvirt.css | 5 + 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/docs/generic.css

[libvirt] [PATCH v2 09/19] docs: add three core links in the header bar

Add links to download, communicate and learn in the header bar, as the main jumping off points for navigation. Signed-off-by: Daniel P. Berrange --- docs/libvirt.css | 28 +++- docs/page.xsl| 7 +++ 2 files changed, 34 insertions(+), 1

[libvirt] [PATCH v2 05/19] docs: provide new style logos for the apps page

Replace the old "Made with libvirt" logo with links to the new "Libvirt powered" logos, providing various sizes. Signed-off-by: Daniel P. Berrange --- docs/Makefile.am | 1 - docs/apps.html.in | 7 +-- docs/madeWith.png | Bin 4545 -> 0 bytes 3 files changed, 5

[libvirt] [PATCH 0/2] qemu: Enable NUMA node tag in pci-root for PPC64

This patch addresses the same aspects on PPC the bug 1103314 addressed on x86. It sets the target numa node in the pci-root instead of using the pci-expander-bus. The pci-expander-bus is of not much use on PPC, and the approach is to set the value globally for reasons mentioned in Patch 2 commit

Re: [libvirt] [PATCH v6 04/17] qemu: set/use proper pciConnectFlags during hotplug

On Mon, 2016-11-07 at 14:50 -0500, Laine Stump wrote: > Before now, all the qemu hotplug functions assumed that all devices to > be hotplugged were legacy PCI endpoint devices > (VIR_PCI_CONNECT_TYPE_PCI_DEVICE). This worked out "okay", because all > devices *are* legacy PCI endpoint devices on

Re: [libvirt] [PATCH v6 04/17] qemu: set/use proper pciConnectFlags during hotplug

On Mon, 2016-11-07 at 14:50 -0500, Laine Stump wrote: > Before now, all the qemu hotplug functions assumed that all devices to > be hotplugged were legacy PCI endpoint devices > (VIR_PCI_CONNECT_TYPE_PCI_DEVICE). This worked out "okay", because all > devices *are* legacy PCI endpoint devices on

Re: [libvirt] [PATCH v6 03/17] qemu: set/use info->pciConnectFlags when validating/assigning PCI addresses

On Mon, 2016-11-07 at 14:50 -0500, Laine Stump wrote: > Set pciConnectFlags in each device's DeviceInfo and then use those > flags later when validating existing addresses in > qemuDomainCollectPCIAddress() and when assigning new addresses with > qemuDomainPCIAddressReserveNextAddr() (rather than

[libvirt] [PATCH] docs: add note about when lxc: XML namespace was added

Signed-off-by: Daniel P. Berrange --- Pushed as a trivial patch docs/drvlxc.html.in | 4 1 file changed, 4 insertions(+) diff --git a/docs/drvlxc.html.in b/docs/drvlxc.html.in index 3dc9d59..4f86535 100644 --- a/docs/drvlxc.html.in +++ b/docs/drvlxc.html.in @@ -611,6

Re: [libvirt] [PATCH] qemu: Only allow 'raw' format for scsi-block using virtio-scsi

On 07.11.2016 23:58, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1379196 > > Add check in qemuCheckDiskConfig for an invalid combination > of using the 'scsi' bus for a block 'lun' device and any disk > source format other than 'raw'. > > Signed-off-by: John Ferlan

Re: [libvirt] [PATCH] qemu: Only allow 'raw' format for scsi-block using virtio-scsi

On Mon, Nov 07, 2016 at 05:58:40PM -0500, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1379196 > > Add check in qemuCheckDiskConfig for an invalid combination > of using the 'scsi' bus for a block 'lun' device and any disk > source format other than 'raw'. > > Signed-off-by:

Re: [libvirt] [PATCH 2/2] vbox: hookup the 5.1 C API to the unified driver.

On Mon, Nov 07, 2016 at 04:03:43PM -0500, Dawid Zamirski wrote: > > simply follow the same pattern as other versions did. > --- > src/Makefile.am | 1 + > src/vbox/vbox_V5_1.c | 13 + > src/vbox/vbox_common.h| 2 ++ > src/vbox/vbox_storage.c |

Re: [libvirt] [PATCH 1/2] conf: List only online cpus for virsh vcpupin

On Mon, Nov 07, 2016 at 22:39:33 +0530, Nitesh Konkar wrote: > From: nitesh konkar > > Signed-off-by: Nitesh Konkar > --- > src/conf/domain_conf.c | 3 +++ > 1 file changed, 3 insertions(+) See review of 2/2, since this shares all

Re: [libvirt] [PATCH 2/2] conf: List only online cpus for virsh emulatorpin

On Mon, Nov 07, 2016 at 22:39:34 +0530, Nitesh Konkar wrote: > From: nitesh konkar Commit message is missing. > > Signed-off-by: Nitesh Konkar > --- > src/qemu/qemu_driver.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git

Re: [libvirt] [PATCH v6 02/17] qemu: new functions to calculate/set device pciConnectFlags

On Mon, 2016-11-07 at 14:50 -0500, Laine Stump wrote: > The lowest level function of this trio > (qemuDomainDeviceCalculatePCIConnectFlags()) aims to be the single > authority for the virDomainPCIConnectFlags to use for any given device > using a particular arch/machinetype/qemu-binary. > >

Re: [libvirt] [PATCH v6 01/17] qemu: new functions qemuDomainMachineHasPCI[e]Root()

On Mon, 2016-11-07 at 14:50 -0500, Laine Stump wrote: > These functions provide a simple one line method of learning if the > current domain has a pci-root or pcie-root bus. > --- >  src/qemu/qemu_domain.c | 30 ++ >  src/qemu/qemu_domain.h |  2 ++ >  2 files changed, 32

[libvirt] [PATCH] test driver: Deny some operations on inactive domains

Some operations like reboot, save, coreDump, blockStats, ifaceStats make sense iff domain is running. While it is technically possible for our test driver to return success regardless of domain state, we should copy constraints from other drivers and thus deny these operations over inactive

Re: [libvirt] [PATCH] Test driver should error when domain destroy twice

On 07.11.2016 21:09, Félix Bouliane wrote: > Fixes the behavior when destroying a domain more than once. > VIR_ERR_OPERATION_INVALID should be raised when destroying an > already destroyed domain. > --- > src/test/test_driver.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git