[libvirt] [PATCH] libxl: add tunnelled migration support

2016-11-10 Thread Bob Liu
Tunnelled migration doesn't require any extra network connections beside the libvirt daemon. It's capable of strong encryption and the default option of openstack-nova. This patch adds the tunnelled migration(Tunnel3params) support to libxl. On the src side, the data flow is: *

[libvirt] [PATCH 08/14] cputest: Don't use superfluous preferred model

2016-11-10 Thread Jiri Denemark
In some cases preferred model doesn't really do anything since the result remains the same even if it is removed. Signed-off-by: Jiri Denemark --- tests/cputest.c | 13 + ...esult.xml =>

[libvirt] [PATCH 09/14] cputest: Don't use preferred CPU model at all

2016-11-10 Thread Jiri Denemark
Now that all tests pass NULL as the preferred model, we can just drop that test parameter. Signed-off-by: Jiri Denemark --- tests/cputest.c | 69 +++-- 1 file changed, 33 insertions(+), 36 deletions(-) diff --git

[libvirt] [PATCH 14/14] cpu: Drop cpuGuestData

2016-11-10 Thread Jiri Denemark
The API is not used anywhere in the code. Signed-off-by: Jiri Denemark --- src/cpu/cpu.c| 41 - src/cpu/cpu.h| 14 -- src/cpu/cpu_arm.c| 10 -- src/cpu/cpu_ppc64.c | 9

[libvirt] [PATCH 12/14] cpu: Introduce virCPUConvertLegacy API

2016-11-10 Thread Jiri Denemark
PPC driver needs to convert POWERx_v* legacy CPU model names into POWERx to maintain backward compatibility with existing domains. This patch adds a new step into the guest CPU configuration work flow which CPU drivers can use to convert legacy CPU definitions. Signed-off-by: Jiri Denemark

[libvirt] [PATCH 06/14] cputest: Don't use unsupported preferred model

2016-11-10 Thread Jiri Denemark
Using a preferred CPU model which is not in the list of CPU models supported by a hypervisor does not make sense. Signed-off-by: Jiri Denemark --- tests/cputest.c | 2 -- tests/cputestdata/x86-host+guest,models,Penryn-result.xml |

[libvirt] [PATCH 03/14] cpu: Rename cpuDataParse

2016-11-10 Thread Jiri Denemark
The new name is virCPUDataParse. Signed-off-by: Jiri Denemark --- src/cpu/cpu.c| 4 ++-- src/cpu/cpu.h| 8 src/cpu/cpu_x86.c| 4 ++-- src/libvirt_private.syms | 2 +- tests/cputest.c | 2 +- 5 files changed, 10

[libvirt] [PATCH 07/14] cputest: Don't use preferred model with forbidden fallback

2016-11-10 Thread Jiri Denemark
Using a preferred model for guest CPUs with forbidden fallback masks a bug in the code. It would just happily use another CPU model supported by a hypervisor even though it is explicitly forbidden in the CPU XML. This patch temporarily changes the expected result to -2, which is used when the

[libvirt] [PATCH 11/14] cputest: Don't test cpuGuestData

2016-11-10 Thread Jiri Denemark
The API is no longer used anywhere else since it was replaced by a much saner work flow utilizing new APIs that work on virCPUDefPtr directly: virCPUCompare, virCPUUpdate, and virCPUTranslate. Not testing the new work flow caused some bugs to be hidden. This patch reveals them, but doesn't

[libvirt] [PATCH 05/14] cputest: Don't use preferred model for minimum match CPUs

2016-11-10 Thread Jiri Denemark
Guest CPUs with match='minimum' should always be updated to match host CPU model. Trying to get different results by supplying preferred models does not make sense. Signed-off-by: Jiri Denemark --- tests/cputest.c| 2 --

[libvirt] [PATCH 13/14] cpu: Avoid adding to custom CPUs

2016-11-10 Thread Jiri Denemark
Guest CPU definitions with mode='custom' and missing are expected to run on a host CPU from any vendor as long as the required CPU model can be used as a guest CPU on the host. But even though no CPU vendor was explicitly requested we would sometimes force it due to a bug in virCPUUpdate and

[libvirt] [PATCH 10/14] cpu: Make models array in virCPUTranslate constant

2016-11-10 Thread Jiri Denemark
The API doesn't change the array so let's make it constant. Signed-off-by: Jiri Denemark --- src/cpu/cpu.c | 6 +++--- src/cpu/cpu.h | 2 +- src/qemu/qemu_process.c | 3 ++- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/cpu/cpu.c

[libvirt] [PATCH 00/14] Another round of CPU driver changes

2016-11-10 Thread Jiri Denemark
This is another step in revisiting all APIs provided by the cpu driver and making them a bit more sane. As with the previous round(s), the updated APIs will gain virCPU prefix so that they can be easily distinguished from the ones that still need some work. Jiri Denemark (14): cpu: Rename

[libvirt] [PATCH 01/14] cpu: Rename cpuGetModels

2016-11-10 Thread Jiri Denemark
The new name is virCPUGetModels. Signed-off-by: Jiri Denemark --- src/cpu/cpu.c| 4 ++-- src/cpu/cpu.h| 6 +++--- src/cpu/cpu_ppc64.c | 4 ++-- src/cpu/cpu_x86.c| 4 ++-- src/libvirt_private.syms | 2 +-

[libvirt] [PATCH 04/14] cpu: Rename cpuDataFormat

2016-11-10 Thread Jiri Denemark
The new name is virCPUDataFormat. Signed-off-by: Jiri Denemark --- src/cpu/cpu.c | 6 +++--- src/cpu/cpu.h | 8 src/cpu/cpu_x86.c | 4 ++-- src/libvirt_private.syms| 2 +- tests/qemumonitorjsontest.c | 2 +- 5 files

[libvirt] [PATCH 02/14] cpu: Rename and document cpuModelIsAllowed

2016-11-10 Thread Jiri Denemark
The new name is virCPUModelIsAllowed. Signed-off-by: Jiri Denemark --- src/cpu/cpu.c | 21 + src/cpu/cpu.h | 6 +++--- src/cpu/cpu_ppc64.c | 2 +- src/cpu/cpu_x86.c | 2 +- 4 files changed, 22 insertions(+), 9 deletions(-) diff --git

Re: [libvirt] [PATCH] qemu: fix one reboot scenario

2016-11-10 Thread Maxim Nestratov
07-Nov-16 20:15, Michal Privoznik пишет: On 07.11.2016 17:19, Michal Privoznik wrote: On 03.11.2016 19:11, Maxim Nestratov wrote: Both qemuDomainReboot and qemuDomainShutdownFlags do the following if they were called to reboot: 1. use agent and call qemuAgentShutdown 2. then if the above

Re: [libvirt] [PATCH 4/4] qemu: Generate memory device aliases according to slot number

2016-11-10 Thread Peter Krempa
On Thu, Nov 10, 2016 at 08:58:10 -0500, John Ferlan wrote: > > > On 11/03/2016 02:12 AM, Peter Krempa wrote: > > The memory device alias needs to be treated as machine ABI as qemu is > > using it in the migration stream for section labels. To simplify this > > generate the alias from the slot

Re: [libvirt] [PATCH] qemu: Remove erroneously placed comments for numerical ordering

2016-11-10 Thread Peter Krempa
On Thu, Nov 10, 2016 at 10:55:17 -0500, John Ferlan wrote: > Commit id '74bbb8c2ec' seems to have mismerged a bit - adding 240 comments > out of place. Just clean that up. > > Signed-off-by: John Ferlan > --- > > Pushed as trivial Oops. I had a merge conflict in 5

Re: [libvirt] [PATCH 0/2] Allow hotplug of vhost-mq

2016-11-10 Thread Michal Privoznik
On 10.11.2016 14:04, Martin Kletzander wrote: > On Fri, Nov 04, 2016 at 01:28:57PM +0100, Michal Privoznik wrote: >> Basically this is trivial. Everything is prepared and the only >> thing that prevented us from doing this was missing exception in >> one check. Trivial. >> >> Michal Privoznik (2):

[libvirt] [PATCH] qemu: Remove erroneously placed comments for numerical ordering

2016-11-10 Thread John Ferlan
Commit id '74bbb8c2ec' seems to have mismerged a bit - adding 240 comments out of place. Just clean that up. Signed-off-by: John Ferlan --- Pushed as trivial src/qemu/qemu_capabilities.c | 3 +-- src/qemu/qemu_capabilities.h | 2 -- 2 files changed, 1 insertion(+), 4

Re: [libvirt] [PATCH v6 15/17] qemu: initially reserve one open pcie-root-port for hotplug

2016-11-10 Thread Andrea Bolognani
On Mon, 2016-11-07 at 14:50 -0500, Laine Stump wrote: [...] > Instead this patch just reserves one slot for a "future potential" > PCIe device after doing the assignment for actual devices, but only > if the only PCI controller defined prior to starting address > assignment was pcie-root, and only

Re: [libvirt] [PATCH] fix parsing security labels from virt-aa-helper

2016-11-10 Thread Christian Ehrhardt
Sorry, I seem to become a pest more than I'd like to, but my timer on this thread expired again :-) Was the feedback I gave to the questions last week ok to understand the case and maybe reproduce to achieve a ack or do we need to discuss more? ​ -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH 0/6] Add deadline scheduler

2016-11-10 Thread Martin Kletzander
On Mon, Nov 07, 2016 at 10:01:11AM +0100, Martin Polednik wrote: The policy SCHED_DEADLINE is available since kernel 3.14 (and most likely backported to older RT_PREEMPT kernels). It is safer to use than fifo or round robin policies due to only limiting part of cpu time for the RT process,

Re: [libvirt] [PATCH 2/6] util: allow virProcessSetScheduler to set SCHED_DEADLINE

2016-11-10 Thread Martin Kletzander
On Mon, Nov 07, 2016 at 10:01:13AM +0100, Martin Polednik wrote: As sched_deadline is linux specific, it is not set through sched_setscheduler but rather the sched_setattr syscall. Additionally, the scheduler has new set of parameters: runtime, deadline and period. In this part of the series,

Re: [libvirt] [PATCH 3/6] virDomainFormatSchedDef: factor out subset code

2016-11-10 Thread Martin Kletzander
On Mon, Nov 07, 2016 at 10:01:14AM +0100, Martin Polednik wrote: The code within the function is too specific for priority attribute of RT schedulers. To allow addition of schedulers that group by different properties, we factor out the logic to calculate cpu subset. Instead of comparing by

Re: [libvirt] [PATCH 2/4] qemu: process: detect if dimm aliases are broken on reconnect

2016-11-10 Thread Peter Krempa
On Thu, Nov 10, 2016 at 08:56:48 -0500, John Ferlan wrote: > On 11/10/2016 04:11 AM, Peter Krempa wrote: > > On Wed, Nov 09, 2016 at 18:40:28 -0500, John Ferlan wrote: > >> On 11/03/2016 02:12 AM, Peter Krempa wrote: > >>> Detect on reconnect to a running qemu VM whether the alias of a > >>>

Re: [libvirt] [PATCH v6 10/17] qemu: auto-add pcie-root-port/dmi-to-pci-bridge controllers as needed

2016-11-10 Thread Andrea Bolognani
On Wed, 2016-11-09 at 15:23 -0500, Laine Stump wrote: > > > +} else if (flags & VIR_PCI_CONNECT_TYPE_PCI_BRIDGE && > > > +   addrs->buses[0].model == > > > VIR_DOMAIN_CONTROLLER_MODEL_PCIE_ROOT) { > > > +model = VIR_DOMAIN_CONTROLLER_MODEL_DMI_TO_PCI_BRIDGE; > >  > > Mh,

Re: [libvirt] [PATCH 4/4] qemu: Generate memory device aliases according to slot number

2016-11-10 Thread John Ferlan
On 11/03/2016 02:12 AM, Peter Krempa wrote: > The memory device alias needs to be treated as machine ABI as qemu is > using it in the migration stream for section labels. To simplify this > generate the alias from the slot number unless an existing broken > configuration is detected. > > With

Re: [libvirt] [PATCH 2/4] qemu: process: detect if dimm aliases are broken on reconnect

2016-11-10 Thread John Ferlan
On 11/10/2016 04:11 AM, Peter Krempa wrote: > On Wed, Nov 09, 2016 at 18:40:28 -0500, John Ferlan wrote: >> >> >> On 11/03/2016 02:12 AM, Peter Krempa wrote: >>> Detect on reconnect to a running qemu VM whether the alias of a >>> hotpluggable memory device (dimm) does not match the dimm slot

Re: [libvirt] [PATCH 0/2] Allow hotplug of vhost-mq

2016-11-10 Thread Martin Kletzander
On Fri, Nov 04, 2016 at 01:28:57PM +0100, Michal Privoznik wrote: Basically this is trivial. Everything is prepared and the only thing that prevented us from doing this was missing exception in one check. Trivial. Michal Privoznik (2): qemuDomainAttachNetDevice: Don't overwrite error on

Re: [libvirt] [PATCH 2/2] qemu_cgroup: allow access to /dev/dri/render*

2016-11-10 Thread Daniel P. Berrange
On Thu, Nov 10, 2016 at 10:35:46AM +, Marc-André Lureau wrote: > Hi > > What's the status with this patch? If I understand the discussion, it is > needed, but not enough. Now that SELinux has been fixed (both in f24/f25 > now), I can see only the ACL left: setfacl -m u:qemu:rw

Re: [libvirt] [PATCH 2/2] qemu_cgroup: allow access to /dev/dri/render*

2016-11-10 Thread Marc-André Lureau
Hi What's the status with this patch? If I understand the discussion, it is needed, but not enough. Now that SELinux has been fixed (both in f24/f25 now), I can see only the ACL left: setfacl -m u:qemu:rw /dev/dri/renderD128 + this patch allows me to setup a system VM with virgl. (though tbh, I

Re: [libvirt] [PATCH 2/4] qemu: process: detect if dimm aliases are broken on reconnect

2016-11-10 Thread Peter Krempa
On Wed, Nov 09, 2016 at 18:40:28 -0500, John Ferlan wrote: > > > On 11/03/2016 02:12 AM, Peter Krempa wrote: > > Detect on reconnect to a running qemu VM whether the alias of a > > hotpluggable memory device (dimm) does not match the dimm slot number > > where it's connected to. This is

Re: [libvirt] [PATCH] qemu: Make sure shmem memory is shared

2016-11-10 Thread lhuang
I have test this patch, and it works well. After this patch, Libvirt can generate share=yes in ivshmem-plain memory backend command line: # ps aux|grep r7 ... -object memory-backend-file,id=shmmem-shmem0,mem-path=/dev/shm/my_shmem1,size=4194304,share=yes -device

Re: [libvirt] [PATCH] qemu: Make sure shmem memory is shared

2016-11-10 Thread Peter Krempa
On Thu, Nov 10, 2016 at 08:32:33 +0100, Martin Kletzander wrote: > Even though using /dev/shm/asdf as the backend, we still need to make > the mapping shared. The original patch forgot to add that parameter. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1392031 > > Signed-off-by:

Re: [libvirt] [PATCH 1/2 v2] conf: List only online cpus for virsh vcpupin

2016-11-10 Thread Peter Krempa
On Thu, Nov 10, 2016 at 12:30:00 +0530, Nitesh Konkar wrote: > Currently when the vcpu placement is static > and cpuset is not specified, CPU Affinity > under virsh vcpupin shows 0..CPUMAX. This > patchset will result in display of only online > CPU's under CPU Affinity on linux. > >