Re: [libvirt] [PATCH] disk: Fixup error handling path for devmapper when part_separator='yes'

ping? Thanks - John On 12/03/2016 09:06 AM, John Ferlan wrote: > > ping? > > Tks - > > John > > On 11/17/2016 09:55 AM, John Ferlan wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1346566 >> >> If libvirt_parthelper is erroneously told to append the partition >> separator 'p' onto the

Re: [libvirt] [PATCH 0/2] Fix issues getting voldef capacity value

ping? Thanks John On 12/06/2016 06:43 PM, John Ferlan wrote: > Details in each patch - essentially trying to get "more correct" values. > > John Ferlan (2): > storage: Fix virStorageBackendUpdateVolTargetInfo type check > storage: Allow probe of volume capacity for BLOCK type > > src/sto

Re: [libvirt] [PATCH 0/4] Add generic perf event support

On 12/14/2016 08:54 AM, Nitesh Konkar wrote: > > > On Wed, Dec 14, 2016 at 4:12 AM, John Ferlan > wrote: > > > > On 12/13/2016 11:01 AM, Nitesh Konkar wrote: > > Add support and documentation for generic > > perf events like bus_cycles, stalled_cycles_

Re: [libvirt] [Qemu-ppc] [RFC PATCH qemu] spapr_pci: Create PCI-express root bus by default

On Wed, 2016-12-14 at 20:26 +0200, Marcel Apfelbaum wrote: > > > The Root complex includes the PCI bus, some configuration > > > registers if > > > needed, provides access to the configuration space, translates > > > relevant CPU > > > reads/writes to PCI(e) transactions... > > > > Do those config

[libvirt] [PATCH 06/11] storage: Move and rename disk backend label checking

Rather than have the Disk code having to use PARTED to determine if there's something on the device, let's use the virStorageBackendDeviceProbe. and only fallback to the PARTED probing if the BLKID code isn't built in. This will also provide a mechanism for the other current caller (File System Ba

[libvirt] [PATCH 04/11] storage: Add writelabel bool for virStorageBackendDeviceProbe

It's possible that the API could be called from a startup path in order to check whether the label on the device matches what our format is. In order to handle that condition, add a 'writelabel' boolean to the API in order to indicate whether a write or just read is about to happen. This alters tw

[libvirt] [PATCH 07/11] storage: Adjust disk label found to match labels

Currently as long as the disk is formatted using a known parted format type, the algorithm is happy to continue. However, that leaves a scenario whereby a disk formatted using "pc98" could be used by a pool that's defined using "dvh" (or vice versa). Alter the check to be match and different and ad

[libvirt] [PATCH 11/11] storage: Validate the device formats at logical startup

At startup time, rather than blindly trusting the target devices are still properly formatted, let's check to make sure the pool's target devices are all properly formatted before attempting to start the pool. Signed-off-by: John Ferlan --- src/storage/storage_backend_logical.c | 13

[libvirt] [PATCHv2 02/11] storage: Fix implementation of no-overwrite for file system backend

https://bugzilla.redhat.com/show_bug.cgi?id=1363586 Commit id '27758859' introduced the "NO_OVERWRITE" flag check for file system backends; however, the implementation, documentation, and algorithm was inconsistent. For the "flag" description for the API the flag was described as "Do not overwrite

[libvirt] [PATCH 08/11] storage: Clean up logical pool devices on build failure

If the build fails, then we need to ensure that we've run pvremove on any devices which we've run pvcreate on; otherwise, a subsequent build could fail since running pvcreate twice on a device requires special force arguments. Signed-off-by: John Ferlan --- src/storage/storage_backend_logical.c

[libvirt] [PATCH 09/11] storage: Extract logical device initialize into a helper

Make the remaining code a bit cleaner. Signed-off-by: John Ferlan --- src/storage/storage_backend_logical.c | 111 +++--- 1 file changed, 63 insertions(+), 48 deletions(-) diff --git a/src/storage/storage_backend_logical.c b/src/storage/storage_backend_logical.c ind

[libvirt] [PATCH 05/11] storage: For FS pool check for properly formatted target volume

Prior to starting up, let's be sure the target volume device is formatted as we expect; otherwise, inhibit the start. Signed-off-by: John Ferlan --- src/storage/storage_backend_fs.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/storage/storage_backend_fs.

[libvirt] [PATCH 01/11] storage: Introduce virStorageBackendDeviceProbeEmpty

Rename virStorageBackendFileSystemProbe and to virStorageBackendBLKIDProbe and move to the more common storage_backend module. Create a shim virStorageBackendDeviceProbeEmpty which will make the call to the virStorageBackendBLKIDProbeFS and check the return value. Signed-off-by: John Ferlan ---

[libvirt] [PATCH 00/11] Adjust build/start format checking for fs, disk, and logical backends

Two of these patches (2 and 10) are followups to no-overwrite patches previously posted (I left links in the patches for reference). Essentially this series works to unify the probing code from the file system backend using blkid and the parted format reading code from the disk backend in one comm

[libvirt] [PATCH 03/11] storage: Add partition type checks for BLKID probing

A device may be formatted using some sort of disk partition format type. We can check that using the blkid_ API's as well - so alter the logic to allow checking the device for both a filesystem and a disk partition. Signed-off-by: John Ferlan --- src/storage/storage_backend.c | 177 +

[libvirt] [PATCHv3 10/11] storage: Add overwrite flag checking for logical pool

https://bugzilla.redhat.com/show_bug.cgi?id=1373711 Add support and documentation for the [NO_]OVERWRITE flags for the logical backend. Update virsh.pod with a description of the process for usage of the flags and building of the pool's volume group. Signed-off-by: John Ferlan --- v2: http:/

Re: [libvirt] [Qemu-devel] [RFC] qmp: query-device-slots command

On Thu, Dec 15, 2016 at 02:15:51PM -0500, Laine Stump wrote: > On 12/15/2016 05:12 AM, Marcel Apfelbaum wrote: > > On 12/14/2016 10:10 PM, Laine Stump wrote: > > > On 12/14/2016 12:17 PM, Marcel Apfelbaum wrote: > > > > Be aware that 1 slot doesn't necessarily refer to only one device, > > > > we c

Re: [libvirt] [Qemu-devel] [RFC v2] qmp: query-device-slots command

On Thu, Dec 15, 2016 at 01:39:30PM +0100, Markus Armbruster wrote: > Eduardo Habkost writes: > > > This adds a new command to QMP: query-device-slots. It will allow > > management software to query possible slots where devices can be > > plugged. > > > > This implementation of the command will re

Re: [libvirt] [PATCH v2 00/11] Qemu: s390: Cpu Model Support

On 12/15/2016 11:55 AM, Jiri Denemark wrote: On Fri, Dec 09, 2016 at 14:38:29 -0500, Jason J. Herne wrote: This patch set enables cpu model support for s390. The user can now set exact cpu models, query supported models via virsh domcapabilities, and use host-model and host-passthrough modes. Th

Re: [libvirt] [Qemu-devel] [RFC] qmp: query-device-slots command

On 12/15/2016 05:12 AM, Marcel Apfelbaum wrote: On 12/14/2016 10:10 PM, Laine Stump wrote: On 12/14/2016 12:17 PM, Marcel Apfelbaum wrote: Be aware that 1 slot doesn't necessarily refer to only one device, we can have a multi-function device. Is that a fixed thing? I mean, is it always possib

Re: [libvirt] [Qemu-devel] [RFC] qmp: query-device-slots command

On Wed, Dec 14, 2016 at 09:11:10PM +0100, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Wed, Dec 14, 2016 at 04:34:04PM +0100, Markus Armbruster wrote: > >> Eduardo Habkost writes: > >> > >> > On Tue, Dec 13, 2016 at 08:51:34PM +0100, Markus Armbruster wrote: > >> >> Eduardo Habko

Re: [libvirt] [PATCH v2 5/5] network: Add support for local PTR domains

On 12/13/2016 08:52 AM, Jiri Denemark wrote: Similarly to localOnly DNS domain, local PTR domains can be used to tell the DNS server not to forward reverse lookups for unknown IPs which belong to the virtual network. What's here is useful, but the element doesn't fit with the purpose of a PTR

[libvirt] [PATCH v2] [libvirt-ci] Add builders for Fedora 25 and remove builders for Fedora 23

Add builders for Fedora 25 and remove builders for Fedora 23 for ci.centos.org Signed-off-by: Yash Mankad --- projects/libosinfo.yaml | 2 +- projects/libvirt-cim.yaml | 2 +- projects/libvirt-glib.yaml| 2 +- projects/libvirt-perl.yaml| 2 +- projects/libvirt-python.yaml | 2

Re: [libvirt] [PATCH v2 06/11] docs: document cpu host-passthrough migration issue

On 12/15/2016 11:18 AM, Jiri Denemark wrote: On Fri, Dec 09, 2016 at 14:38:35 -0500, Jason J. Herne wrote: Documents in formatdomain.html that when migrating a guest defined with the host-passthrough CPU model from a machine that is running on a newer CPU model than the destination machine's CPU

Re: [libvirt] [Qemu-devel] [RFC v2] qmp: query-device-slots command

On Thu, Dec 15, 2016 at 10:36:17AM +0100, Igor Mammedov wrote: > On Wed, 14 Dec 2016 17:39:08 -0200 > Eduardo Habkost wrote: > > > This adds a new command to QMP: query-device-slots. It will allow > > management software to query possible slots where devices can be > > plugged. > > > > This impl

Re: [libvirt] [PATCH RFC v3 01/15] storage pools: refactoring of basic structs

Hi, John. I needed some time to think over everything that you have written. Thanks a lot. With all this new information we have more freedom for changes and refactoring. I dig through storage_conf.h file once with all ideas you have and tried to use them. It would be easier for me if we agree a

Re: [libvirt] [PATCH v2 00/11] Qemu: s390: Cpu Model Support

On Fri, Dec 09, 2016 at 14:38:29 -0500, Jason J. Herne wrote: > This patch set enables cpu model support for s390. The user can now set exact > cpu models, query supported models via virsh domcapabilities, and use > host-model > and host-passthrough modes. The end result is that migration is safer

Re: [libvirt] [PATCH v2 07/11] tests: qemuxml2argv s390x cpu model

On Fri, Dec 09, 2016 at 14:38:36 -0500, Jason J. Herne wrote: > Test cases for qemu s390x cpu model argument generation. > > Signed-off-by: Jason J. Herne > --- > .../qemuxml2argv-cpu-s390-zEC12.args| 19 +++ > .../qemuxml2argv-cpu-s390-zEC12.xml |

Re: [libvirt] [PATCH v2 11/11] tests: domain capabilities: qemu 2.8 on s390x

On Fri, Dec 09, 2016 at 14:38:40 -0500, Jason J. Herne wrote: > From: "Collin L. Walling" > > Tests the domain capabilities on s390x using the Qemu 2.8 capabilities data. > > Signed-off-by: Collin L. Walling > Signed-off-by: Jason J. Herne > --- > tests/domaincapsschemadata/qemu_2.8.0.s390x.x

Re: [libvirt] [PATCH v2 10/11] tests: qemu capabilites: qemu 2.7 and 2.8 on s390x

On Fri, Dec 09, 2016 at 14:38:39 -0500, Jason J. Herne wrote: > From: "Collin L. Walling" > > Tests Qemu capabilities on s390x before and after the availability of > the query-cpu-model-expansion QMP command. The host CPU is mocked to use > the zEC12.2-base model for these tests, which has a defi

Re: [libvirt] [PATCH v2 09/11] test-data: Qemu caps replies and xml for s390x qemu 2.7 and 2.8

On Fri, Dec 09, 2016 at 14:38:38 -0500, Jason J. Herne wrote: > From: "Collin L. Walling" > > Expected Qemu replies for versions 2.7 and 2.8 from the s390x > Qemu binary. > > Signed-off-by: Collin L. Walling > Signed-off-by: Jason J. Herne > --- > .../qemucapabilitiesdata/caps_2.7.0.s390x.rep

Re: [libvirt] [PATCH v2 06/11] docs: document cpu host-passthrough migration issue

On Fri, Dec 09, 2016 at 14:38:35 -0500, Jason J. Herne wrote: > Documents in formatdomain.html that when migrating a guest > defined with the host-passthrough CPU model from a machine that > is running on a newer CPU model than the destination machine's > CPU model, it is very likely that the guest

Re: [libvirt] [PATCH v2 08/11] tests: qemuxml2argv cpu feature syntax

On Fri, Dec 09, 2016 at 14:38:37 -0500, Jason J. Herne wrote: > Test that libvirt generates the correct cpu feature syntax when > query-cpu-model-expansion is supported and when it is not. > > Signed-off-by: Jason J. Herne > --- > .../qemuxml2argv-cpu-features-post-qcme.args | 19 +

Re: [libvirt] [PATCH v2 05/11] qemu: command: Support new cpu feature argument syntax

On Fri, Dec 09, 2016 at 14:38:34 -0500, Jason J. Herne wrote: > From: "Collin L. Walling" > > Qemu has abandoned the +/-feature syntax in favor of key=value. Some > architectures (s390) do not support +/-feature. So we update libvirt to handle > both formats. > > If we detect a sufficiently new

[libvirt] [PATCH 2/3] qemu: Mark more namespace code linux-only

Some of the functions are not called on non-linux platforms which makes them useless there. Signed-off-by: Michal Privoznik --- src/qemu/qemu_domain.c | 372 + 1 file changed, 191 insertions(+), 181 deletions(-) diff --git a/src/qemu/qemu_domain.c

[libvirt] [PATCH 0/3] Fix build on FreeBSD

Obviously my latest patch set broke some stuff on FreeBSD. Michal Privoznik (3): configure: Link witch -lacl only on linux qemu: Mark more namespace code linux-only virfile: Support bind mount only on linux configure.ac | 2 +- src/qemu/qemu_domain.c | 372 +

[libvirt] [PATCH 1/3] configure: Link witch -lacl only on linux

There's no -lacl on FreeBSD. Signed-off-by: Michal Privoznik --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index cb96df73b..de174be02 100644 --- a/configure.ac +++ b/configure.ac @@ -320,7 +320,7 @@ AC_CHECK_FUNCS([stat stat64 __

[libvirt] [PATCH 3/3] virfile: Support bind mount only on linux

Other systems (despite having sys/mount.h) do not support bind mounts. Signed-off-by: Michal Privoznik --- src/util/virfile.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/util/virfile.c b/src/util/virfile.c index 7c1e4357d..718dcc4a9 100644 --- a/src/util/virfile

Re: [libvirt] [PATCH v2 03/11] qemu: qmp query-cpu-model-expansion command

On 12/15/2016 06:47 AM, Jiri Denemark wrote: On Fri, Dec 09, 2016 at 14:38:32 -0500, Jason J. Herne wrote: diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 0c38b8f..9189a8b 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -4973,6 +4973

Re: [libvirt] [PATCH 04/11] nodedev: Add the ability to create vHBA by parent wwnn/wwpn or fabric_wwn

On 12/13/2016 08:30 PM, John Ferlan wrote: On 12/13/2016 10:58 AM, Boris Fiuczynski wrote: John, I have a concern regarding usage of the parent_fabric_name. As far I have been told there are a lot of fc_host attributes in Linux that are optional and left to the low-level driver to decide if im

Re: [libvirt] [PATCH v2 04/11] qemu-caps: Get host model directly from Qemu when available

On Fri, Dec 09, 2016 at 14:38:33 -0500, Jason J. Herne wrote: > From: "Collin L. Walling" > > When qmp query-cpu-model-expansion is available probe Qemu for its view of the > host model. In kvm environments this can provide a more complete view of the > host model because features supported by Qe

Re: [libvirt] [Qemu-devel] [RFC v2] qmp: query-device-slots command

Eduardo Habkost writes: > This adds a new command to QMP: query-device-slots. It will allow > management software to query possible slots where devices can be > plugged. > > This implementation of the command will return: > > * Multiple PCI slots per bus, in the case of PCI buses; > * One slot pe

Re: [libvirt] [PATCH v2 03/11] qemu: qmp query-cpu-model-expansion command

On Fri, Dec 09, 2016 at 14:38:32 -0500, Jason J. Herne wrote: > From: "Collin L. Walling" > > query-cpu-model-expansion is used to get a list of features for a given cpu > model name or to get the model and features of the host hardware/environment > as seen by Qemu/kvm. > > Signed-off-by: Colli

Re: [libvirt] [PATCH v2 02/11] s390-cpu: Remove nodeData and decode

On Fri, Dec 09, 2016 at 14:38:31 -0500, Jason J. Herne wrote: > On s390 , the host's features are heavily influenced by not only the host > hardware but also by hardware microcode level, host OS version, qemu > version and kvm version. In this environment it does not make sense to > attempt to repo

Re: [libvirt] [PATCH v2 01/11] s390: Cpu driver support for update and compare

On Fri, Dec 09, 2016 at 14:38:30 -0500, Jason J. Herne wrote: > Implement compare for s390. Required to test the guest against the host for > guest cpu model runnability checking. We always return IDENTICAL to bypass > Libvirt's checking. s390 will rely on Qemu to perform the runnability > checkin

Re: [libvirt] [PATCH v1] libxl: reverse defaults on HVM net device attach

On 12/14/2016 08:53 PM, Jim Fehlig wrote: > On 12/14/2016 03:53 AM, Joao Martins wrote: >> libvirt libxl picks its own default with respect to the default NIC >> to use. libxlMakeNic is the one responsible for this and on boot it >> picks LIBXL_NIC_TYPE_VIF_IOEMU for HVM domains such that it acco

Re: [libvirt] [Qemu-devel] [RFC] qmp: query-device-slots command

On 12/14/2016 10:10 PM, Laine Stump wrote: On 12/14/2016 12:17 PM, Marcel Apfelbaum wrote: On 12/13/2016 06:00 PM, Eduardo Habkost wrote: On Tue, Dec 13, 2016 at 04:15:18PM +0200, Marcel Apfelbaum wrote: On 12/13/2016 02:42 PM, Eduardo Habkost wrote: On Tue, Dec 13, 2016 at 12:04:17PM +0100,

Re: [libvirt] [PATCH v2 00/10] admin: Introduce runtime logging APIs

On Fri, Nov 25, 2016 at 02:11:58PM +0100, Erik Skultety wrote: > v1 here > https://www.redhat.com/archives/libvir-list/2016-November/msg9.html > > since v1: > - incorporated notes raised during review > - allowed passing of NULL via the public APIs > * behaves the same way as an empty str

Re: [libvirt] [Qemu-devel] [RFC v2] qmp: query-device-slots command

On Wed, 14 Dec 2016 17:39:08 -0200 Eduardo Habkost wrote: > This adds a new command to QMP: query-device-slots. It will allow > management software to query possible slots where devices can be > plugged. > > This implementation of the command will return: > > * Multiple PCI slots per bus, in th

Re: [libvirt] [PATCH] domain_conf: set ifname for ovs vhostuser ifname

Any comments on this ? On Fri, Dec 09, 2016 at 01:24:52PM +0100, Mehdi Abaakouk wrote: Hi, This is the followup of '[PATCH v3 4/4] domain_conf: autodetect vhostuser ifname'. I have rewritten a better version that shouldn't have the same concern as before. I have isolated the code that detects

Re: [libvirt] [PATCH v3 08/21] qemu: Spawn qemu under mount namespace

On 14.12.2016 18:02, Daniel P. Berrange wrote: > On Mon, Dec 12, 2016 at 05:52:54PM +0100, Michal Privoznik wrote: >> Prime time. When it comes to spawning qemu process and >> relabelling all the devices it's going to touch, there's inherent >> race with other applications in the system (e.g. udev)

[libvirt] [PATCH v5 0/3] gluster: cache glfs connection object per volume

v5: Address review comments from Peter on v4 Dropping Patch 3 from v3 Patch 1: fix transport type in all drivers, possible switch case converts Patch 2: use virObject with src->drv to avoid 'initFlag' for remembering 'virStorageFileInit' status Patch 3: * change virStorageBackendGlusterCac

[libvirt] [PATCH v5 3/3] gluster: cache glfs connection object per volume

Currently, in case if we have 4 extra attached disks, then for each disk we need to call 'glfs_init' (over network) and friends which could be costly. Additionally snapshot(external) scenario will further complex the situation. This patch maintain a cache of glfs objects per volume, hence the all

[libvirt] [PATCH v5 2/3] storage: optimize calls to virStorageFileInit and friends

Currently, each among virStorageFileGetMetadataRecurse, qemuSecurityChownCallback, qemuDomainSnapshotPrepareDiskExternal and qemuDomainSnapshotCreateSingleDiskActive makes calls to virStorageFileInit and friends for simple operations like stat, read headers, chown and etc. This patch 1. optimize/u

[libvirt] [PATCH v5 1/3] util: change the virStorageNetHostDef type

Currently, the Host object looks like struct _virStorageNetHostDef { char *name; char *port; int transport; /* virStorageNetHostTransport */ char *socket; /* path to unix socket */ } We don't actually need a 'name' and 'port' if the transport type is unix domain s

Re: [libvirt] [PATCH 0/2] qemu: fix few image/resource locking problems

On Wed, Dec 14, 2016 at 17:36:31 +0100, Peter Krempa wrote: > The problem from patch 2/2 made me to look at the locking infrastructure in > libvirt. There are a few broken places. This fixes two mistakes but more > patches > will come. > > Peter Krempa (2): > qemu: monitor: Don't resume lockspa