Re: [libvirt] [PATCH 1/5] vz: report "scsi" bus for disks when nothing was set explixitly

2016-12-20 Thread Maxim Nestratov
20-Dec-16 13:20, Nikolay Shirokovskiy пишет: On 09.12.2016 17:36, Maxim Nestratov wrote: This is necessary for to show CTs created out of libvirt correctly. Signed-off-by: Maxim Nestratov --- src/vz/vz_sdk.c | 11 --- 1 file changed, 4 insertions(+), 7

Re: [libvirt] [PATCH v2 0/2] Allow saving QEMU libvirt state to a pipe

2016-12-20 Thread Chen Hanxiao
At 2016-12-15 11:15:13, "Chen Hanxiao" wrote: >This series introduce flag VIR_DOMAIN_SAVE_DIRECT >to enable command 'save' to write to PIPE. > >Base upon patches from Roy Keene >with some fixes. > >Change from original patch: >1) Check whether the

Re: [libvirt] [PATCH 5/5] vz: get disks statistics for CTs

2016-12-20 Thread Nikolay Shirokovskiy
On 09.12.2016 17:36, Maxim Nestratov wrote: > A CT disk statistics is reported with prefix "hdd" and we should use > it to extract data. > > Signed-off-by: Maxim Nestratov > --- > src/vz/vz_driver.c | 10 -- > src/vz/vz_sdk.c| 5 +++-- > src/vz/vz_sdk.h

Re: [libvirt] [PATCH 4/5] vz: report disks either as disks or filesystems depending on original xml

2016-12-20 Thread Nikolay Shirokovskiy
On 09.12.2016 17:36, Maxim Nestratov wrote: > Virtuozzo SDK interface doesn't differ filesystems from disks and sees them > as disks. > Before, we always mistakenly presented disks based on files as filesystems, > which is > not completely correct. Now we are going to show either disks or

Re: [libvirt] [PATCH] apparmor: pass attach_disconnected

2016-12-20 Thread Guido Günther
Hi intrigeri, Hi Christian, thanks for testing! On Mon, Dec 19, 2016 at 02:38:57PM +0100, Christian Ehrhardt wrote: > Ha intrigeri beat me by 3 minutes with feedback :-) > Tested it as well over lunch time, working for me too now: > That said: > Acked-by Christian Ehrhardt

Re: [libvirt] [RFC] phi support in libvirt

2016-12-20 Thread Feng, Shaohe
Thanks. Dolpher. Reply inline. On 2016年12月21日 11:56, Du, Dolpher wrote: Shaohe was dropped from the loop, adding him back. -Original Message- From: He Chen [mailto:he.c...@linux.intel.com] Sent: Friday, December 9, 2016 3:46 PM To: Daniel P. Berrange Cc:

[libvirt] [PATCH v2 1/1] qemu_domain: set default ovs vhostuser ifname

2016-12-20 Thread Mehdi Abaakouk
This change adds a new helper function that return a ifname from the vhostuser unix-socket path but only if the interface is managed by openvswitch This new function is issue to autodetect the ifname for openvswitch managed vhostuser interface. --- src/libvirt_private.syms| 1 +

[libvirt] [PATCH v2 0/1] qemu_domain: set default ovs vhostuser ifname

2016-12-20 Thread Mehdi Abaakouk
Hi, I have fixed the two remarks. ifname is now set in qemuDomainDeviceDefPostParse(). Regards, Mehdi Abaakouk (1): qemu_domain: set default ovs vhostuser ifname src/libvirt_private.syms| 1 + src/qemu/qemu_domain.c | 21 +++--

Re: [libvirt] [PATCH v2] xen: add QED format test

2016-12-20 Thread Jim Fehlig
Cédric Bosdonnat wrote: > Follow up of commit 340bb6b7 to add unit tests for the QED format > support. Also add missing QED case in xenFormatXLDisk() > --- > v2: >* Separated the QED test files into another set ti make this > test conditionnal >* Removed useless #ifdef >

Re: [libvirt] connecting to qemu domain monitor socket outside of libvirt/virsh

2016-12-20 Thread Eric Blake
On 12/20/2016 12:48 PM, Jason Miesionczek wrote: > Hi, > > So I see that when i have a qemu vm running, that i created via libvirt, > there is a socket here: > /var/lib/libvirt/qemu/domain-/monitor.sock > > I am trying to connect to this socket via cli or a completely separate > C/C++

[libvirt] connecting to qemu domain monitor socket outside of libvirt/virsh

2016-12-20 Thread Jason Miesionczek
Hi, So I see that when i have a qemu vm running, that i created via libvirt, there is a socket here: /var/lib/libvirt/qemu/domain-/monitor.sock I am trying to connect to this socket via cli or a completely separate C/C++ application to be able to control the VM, but I can't seem to get it to

Re: [libvirt] [PATCH v2] storage: vz storage pool support

2016-12-20 Thread John Ferlan
On 12/16/2016 06:14 AM, Olga Krishtal wrote: > On 08/12/16 22:56, John Ferlan wrote: Compare that to NFS, which uses mount which is included in well every distro I can think of. That's a big difference. Also let's face it, NFS has been the essential de facto goto tool to access

Re: [libvirt] [PATCH v3 8/8] conf: aggregate multiple pcie-root-ports onto a single slot

2016-12-20 Thread Andrea Bolognani
On Mon, 2016-12-19 at 10:23 -0500, Laine Stump wrote: > Set the VIR_PCI_CONNECT_AGGREGATE_SLOT flag for pcie-root-ports so > that they will be assigned to all the functions on a slot. >  > Some qemu test case outputs had to be adjusted due to the > pcie-root-ports now being put on multiple

Re: [libvirt] [PATCH RFC v3 01/15] storage pools: refactoring of basic structs

2016-12-20 Thread John Ferlan
On 12/15/2016 12:16 PM, Olga Krishtal wrote: > Hi, John. > I needed some time to think over everything that you have written. > Thanks a lot. Yeah - I got too wordy, but this type of change caused me to think about other possible consumers too. > With all this new information we have more

Re: [libvirt] [PATCH] domain_conf: set ifname for ovs vhostuser ifname

2016-12-20 Thread Michal Privoznik
On 09.12.2016 13:24, Mehdi Abaakouk wrote: > This change adds a new helper function that > return a ifname from the vhostuser unix-socket path but only > if the interface is managed by openvswitch > > This new function is issue to autodetect the ifname for openvswitch > managed vhostuser

Re: [libvirt] [PATCH 0/2] qemuDomainDiskChangeSupported: Add missing 'address' check

2016-12-20 Thread Marc Hartmayer
On Tue, Dec 20, 2016 at 11:33 AM +0100, Michal Privoznik wrote: > On 06.12.2016 15:30, Marc Hartmayer wrote: >> Disk->info is not live updatable so add a check for this. Otherwise >> libvirt reports success even though no data was updated. >> >> Marc Hartmayer (2): >>

Re: [libvirt] [PATCH v2 0/2] Detect misconfiguration between disk bus and disk address

2016-12-20 Thread Marc Hartmayer
On Tue, Dec 20, 2016 at 11:54 AM +0100, Michal Privoznik wrote: > On 29.11.2016 13:11, Marc Hartmayer wrote: >> This patch series adds the functionality to detect a misconfiguration >> between disk bus type and disk address type for disks that are using >> the address type

Re: [libvirt] [Qemu-devel] [PATCH for-2.9 15/17] target-i386: Define static "base" CPU model

2016-12-20 Thread David Hildenbrand
Am 16.12.2016 um 17:02 schrieb Jiri Denemark: On Mon, Dec 05, 2016 at 21:57:45 -0200, Eduardo Habkost wrote: On Mon, Dec 05, 2016 at 07:18:47PM +0100, David Hildenbrand wrote: Am 02.12.2016 um 22:18 schrieb Eduardo Habkost: The query-cpu-model-expand QMP command needs at least one static

[libvirt] [PATCH] libxl: define a per-domain logger.

2016-12-20 Thread Cédric Bosdonnat
libxl doesn't provide a way to write one log for each domain. Thus we need to demux the messages. If our logger doesn't know to which domain to attribute a message, then it will write it to the default log file. Starting with Xen 4.9 (commit f9858025 and following), libxl will write the domain ID

Re: [libvirt] [PATCH v3 7/8] conf: aggregate multiple devices on a slot when assigning PCI addresses

2016-12-20 Thread Andrea Bolognani
On Mon, 2016-12-19 at 10:23 -0500, Laine Stump wrote: > If a PCI device has VIR_PCI_CONNECT_AGGREGATE_SLOT set in its > pciConnectFlags, then during address assignment we allow multiple > instances of this type of device to be auto-assigned to multiple > functions on the same device. A slot is

Re: [libvirt] [PATCH v3 6/8] qemu: use virDomainPCIAddressIsMulti() to determine multifunction setting

2016-12-20 Thread Daniel P. Berrange
On Tue, Dec 20, 2016 at 04:19:35PM +0100, Andrea Bolognani wrote: > On Mon, 2016-12-19 at 10:23 -0500, Laine Stump wrote: > > If the multifunction attribute isn't set in the config for the device > > at function 0 of a slot used for multifunction, it would previously > > have been an error. This

Re: [libvirt] [PATCH v3 6/8] qemu: use virDomainPCIAddressIsMulti() to determine multifunction setting

2016-12-20 Thread Andrea Bolognani
On Mon, 2016-12-19 at 10:23 -0500, Laine Stump wrote: > If the multifunction attribute isn't set in the config for the device > at function 0 of a slot used for multifunction, it would previously > have been an error. This patch will instead automatically correct the > omission (but only if it

Re: [libvirt] [PATCH v3 5/8] conf: new function virDomainPCIAddressIsMulti()

2016-12-20 Thread Andrea Bolognani
On Mon, 2016-12-19 at 10:23 -0500, Laine Stump wrote: > This function iterates through all the devices in a domain to > determine if the address it has been given is part of a "multifunction > device" (i.e. multiple devices connected to different functions of the > same slot). [...] > +static int

Re: [libvirt] [PATCH v3 4/8] conf: start search for next unused PCI address at same slot as previous find

2016-12-20 Thread Andrea Bolognani
On Mon, 2016-12-19 at 10:23 -0500, Laine Stump wrote: > There is a very slight time advantage to beginning the search for the > next unused PCI address at the slot *after* the previous find (which > is now used), but if we do that, we will miss allocating the other > functions of the same slot

Re: [libvirt] [PATCH v3 3/8] conf: eliminate repetitive code in virDomainPCIAddressGetNextSlot()

2016-12-20 Thread Andrea Bolognani
On Mon, 2016-12-19 at 10:23 -0500, Laine Stump wrote: > virDomainPCIAddressGetNextSlot() starts searching from the last > allocated address and goes to the end of all the buses, then goes back > to the first bus and searchs from there up to the starting point (in s/searchs/searches/ [...] >

Re: [libvirt] [PATCH 3/5] vz: don't add implicit devices for CTs

2016-12-20 Thread Nikolay Shirokovskiy
On 09.12.2016 17:36, Maxim Nestratov wrote: > Implicit devices like controllers are confusing for CTs as they are faked. > Other devices like video we require to be specified explicitly. I would drop last sentence. prlsdkApplyVideoParams shows that we ignore video params for containers. Let's

Re: [libvirt] [PATCH 43/89] configure: move numad check to its own file

2016-12-20 Thread Jiri Denemark
On Fri, Dec 16, 2016 at 10:11:11 +0100, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > configure.ac | 32 +++ > m4/virt-numad.m4 | 58 > > 2 files changed, 61 insertions(+),

Re: [libvirt] [PATCH 42/89] configure: move DTrace check to its own file

2016-12-20 Thread Jiri Denemark
On Fri, Dec 16, 2016 at 10:11:10 +0100, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > configure.ac | 23 +++ > m4/virt-dtrace.m4 | 45 + > 2 files changed, 48 insertions(+), 20 deletions(-) >

Re: [libvirt] [PATCH 41/89] configure: group all library checks together

2016-12-20 Thread Jiri Denemark
On Fri, Dec 16, 2016 at 10:11:09 +0100, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > configure.ac | 75 > +--- > 1 file changed, 21 insertions(+), 54 deletions(-) ACK Jirka -- libvir-list mailing list

Re: [libvirt] [PATCH 40/89] m4/virt-parted: use LIBVIRT_CHECK_PKG

2016-12-20 Thread Jiri Denemark
On Fri, Dec 16, 2016 at 10:11:08 +0100, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > configure.ac | 4 ++-- > m4/virt-parted.m4 | 23 +-- > 2 files changed, 11 insertions(+), 16 deletions(-) ACK Jirka -- libvir-list mailing list

Re: [libvirt] [PATCH 39/89] configure: move libparted check to its own file

2016-12-20 Thread Jiri Denemark
On Fri, Dec 16, 2016 at 10:11:07 +0100, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > configure.ac | 21 ++--- > m4/virt-parted.m4 | 43 +++ > 2 files changed, 45 insertions(+), 19 deletions(-) > create

Re: [libvirt] [PATCH v3 2/8] conf: eliminate concept of "reserveEntireSlot"

2016-12-20 Thread Andrea Bolognani
On Mon, 2016-12-19 at 10:23 -0500, Laine Stump wrote: > setting reserveEntireSlot really accomplishes nothing - instead of > going to the trouble of computing the value for reserveEntireSlot and > then possibly setting *all* functions of the slot as in-use, we can > just set the in-use bit only

Re: [libvirt] [PATCH 38/89] m4/virt-devmapper: use LIBVIRT_CHECK_(PKG|LIB)

2016-12-20 Thread Jiri Denemark
On Fri, Dec 16, 2016 at 10:11:06 +0100, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > config-post.h| 4 ++-- > configure.ac | 2 +- > m4/virt-devmapper.m4 | 23 ++- > src/util/virutil.c | 4 ++-- > 4 files changed, 11

Re: [libvirt] [PATCH 37/89] configure: move devmapper check to its own file

2016-12-20 Thread Jiri Denemark
On Fri, Dec 16, 2016 at 10:11:05 +0100, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > configure.ac | 20 ++-- > m4/virt-devmapper.m4 | 42 ++ > 2 files changed, 44 insertions(+), 18 deletions(-) >

Re: [libvirt] [PATCH v3 1/8] conf: use struct instead of int for each slot in virDomainPCIAddressBus

2016-12-20 Thread Andrea Bolognani
On Mon, 2016-12-19 at 10:23 -0500, Laine Stump wrote: > When keeping track of which functions of which slots are allocated, we > will need to have more information than just the current bitmap with a > bit for each function that is currently stored for each slot in a > virDomainPCIAddressBus. To

Re: [libvirt] [PATCH 3/3] virsh: Allow display of the physical volume size

2016-12-20 Thread John Ferlan
On 12/20/2016 07:02 AM, Michal Privoznik wrote: > On 13.12.2016 22:07, John Ferlan wrote: >> Add a new qualifier '--physical' to the 'vol-info' command in order to >> dispaly the physical size of the volume. The size can differ from the >> allocation value depending on the volume file time. In

Re: [libvirt] [PATCH 36/89] configure: move pm-utils check to its own file

2016-12-20 Thread Jiri Denemark
On Fri, Dec 16, 2016 at 10:11:04 +0100, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > configure.ac| 18 +++--- > m4/virt-pm-utils.m4 | 45 + > 2 files changed, 48 insertions(+), 15 deletions(-) >

Re: [libvirt] [PATCH 0/2] cgroup: unavailable controller prevents controller disabling

2016-12-20 Thread Boris Fiuczynski
On 12/20/2016 11:21 AM, Michal Privoznik wrote: On 08.12.2016 14:24, Boris Fiuczynski wrote: The problem description is covered in patch one. I added patch two as an optional enhancement removing some complexity and improving readability. If this finds common agreement it should simply be

Re: [libvirt] [PATCH 35/89] configure: move nwfilter check to its own file

2016-12-20 Thread Jiri Denemark
On Fri, Dec 16, 2016 at 10:11:03 +0100, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > configure.ac| 13 + > m4/virt-nwfilter.m4 | 32 > 2 files changed, 33 insertions(+), 12 deletions(-) > create mode 100644

Re: [libvirt] [PATCH 34/89] configure: move version script check to one place

2016-12-20 Thread Jiri Denemark
On Fri, Dec 16, 2016 at 10:11:02 +0100, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > configure.ac | 32 > 1 file changed, 16 insertions(+), 16 deletions(-) ACK Jirka -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH 33/89] configure: move windres check to its own file

2016-12-20 Thread Jiri Denemark
On Fri, Dec 16, 2016 at 10:11:01 +0100, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > configure.ac | 11 ++- > m4/virt-win-windres.m4 | 34 ++ > 2 files changed, 36 insertions(+), 9 deletions(-) > create mode

Re: [libvirt] [PATCH 32/89] configure: move windows symbols check to its own file

2016-12-20 Thread Jiri Denemark
On Fri, Dec 16, 2016 at 10:11:00 +0100, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > configure.ac | 17 + > m4/virt-win-symbols.m4 | 40 > 2 files changed, 41 insertions(+), 16 deletions(-) >

Re: [libvirt] [PATCH 31/89] configure: move MinGW check to its own file

2016-12-20 Thread Jiri Denemark
On Fri, Dec 16, 2016 at 10:10:59 +0100, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > configure.ac | 8 +--- > m4/virt-win-mingw.m4 | 28 > 2 files changed, 29 insertions(+), 7 deletions(-) > create mode 100644

Re: [libvirt] [PATCH 30/89] configure: move Cygwin check to its own file

2016-12-20 Thread Jiri Denemark
On Fri, Dec 16, 2016 at 10:10:58 +0100, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > configure.ac | 12 +--- > m4/virt-win-cygwin.m4 | 32 > 2 files changed, 33 insertions(+), 11 deletions(-) > create mode 100644

Re: [libvirt] [PATCH 29/89] configure: move windows common check to its own file

2016-12-20 Thread Jiri Denemark
On Fri, Dec 16, 2016 at 10:10:57 +0100, Pavel Hrdina wrote: > This renames MSCOM_LIBS to WIN32_EXTRA_LIBS to make it consistent with > WIN32_EXTRA_CFLAGS. > > Signed-off-by: Pavel Hrdina > --- > configure.ac | 30 -- >

Re: [libvirt] [PATCH 28/89] configure: move libnl check to its own file

2016-12-20 Thread Jiri Denemark
On Fri, Dec 16, 2016 at 10:10:56 +0100, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > configure.ac | 60 ++--- > m4/virt-libnl.m4 | 81 > > 2 files changed, 83

Re: [libvirt] [PATCH 27/89] configure: move virtualport check to its own file

2016-12-20 Thread Jiri Denemark
On Fri, Dec 16, 2016 at 10:10:55 +0100, Pavel Hrdina wrote: > This patch moves the virtualport result out of *Driver* section because > it's not a driver. > > Signed-off-by: Pavel Hrdina > --- > configure.ac | 40 +++ >

Re: [libvirt] [PATCH 26/89] configure: move macvtap check to its own file

2016-12-20 Thread Jiri Denemark
On Fri, Dec 16, 2016 at 10:10:54 +0100, Pavel Hrdina wrote: > This patch moves the macvtap result out of *Driver* section because > it's not a driver. > > Signed-off-by: Pavel Hrdina > --- > configure.ac | 32 +++ > m4/virt-macvtap.m4 | 56

Re: [libvirt] [PATCH 0/3] Get the voldef target physical value

2016-12-20 Thread Michal Privoznik
On 13.12.2016 22:07, John Ferlan wrote: > This effort started primarily to address some ideas/thoughts brought > up in https://bugzilla.redhat.com/show_bug.cgi?id=1332019 although as > things were updated, it seems that using storage volume definitions > wouldn't be necessary since the same data

Re: [libvirt] [PATCH 3/3] virsh: Allow display of the physical volume size

2016-12-20 Thread Michal Privoznik
On 13.12.2016 22:07, John Ferlan wrote: > Add a new qualifier '--physical' to the 'vol-info' command in order to > dispaly the physical size of the volume. The size can differ from the > allocation value depending on the volume file time. In particular, qcow2 > volumes will have a physical value

Re: [libvirt] [PATCH 25/89] m4/virt-libpcap: error out if asked for libpcap but it was not found

2016-12-20 Thread Jiri Denemark
On Fri, Dec 16, 2016 at 10:10:53 +0100, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > m4/virt-libpcap.m4 | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) ACK Jirka -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH 24/89] m4/virt-libpcap: remove unreasonable dependency on QEMU

2016-12-20 Thread Jiri Denemark
On Fri, Dec 16, 2016 at 10:10:52 +0100, Pavel Hrdina wrote: > Libpcap is used by nwfilter driver and it could be build without QEMU > driver. > > Signed-off-by: Pavel Hrdina > --- > m4/virt-libpcap.m4 | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git

Re: [libvirt] [PATCH 23/89] configure: move libpcap check to its own file

2016-12-20 Thread Jiri Denemark
On Fri, Dec 16, 2016 at 10:10:51 +0100, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > configure.ac | 42 +++- > m4/virt-libpcap.m4 | 63 > ++ > 2 files changed, 66

[libvirt] Loosing lxc guests when restarting libvirt

2016-12-20 Thread Christian Ehrhardt
Hi, I found an issue in libvirt related to libvirt-lxc, but fail to find the root cause. The TL;DR is: libvirt-lxc guests get killed on libvirt restart due to "internal error: No valid cgroup for machine" It was able to reproduce libvirt 1.3.1, 2.4 and 2.5 as packages in Ubuntu and Debian. I

Re: [libvirt] [PATCH] qemu: Adjust qemuDomainGetBlockInfo data for sparse backed files

2016-12-20 Thread Michal Privoznik
On 13.12.2016 21:58, John Ferlan wrote: > According to commit id '0282ca45a' the 'physical' value should > essentially be the last offset of the image or the host physical > size in bytes of the image container. However, commit id '15fa84ac' > refactored the GetBlockInfo to use the same returned

Re: [libvirt] [PATCH] examples: Resolve sign-compare warnings

2016-12-20 Thread Peter Krempa
On Tue, Dec 20, 2016 at 10:58:15 +0100, Michal Privoznik wrote: > For instance: > > hellolibvirt/hellolibvirt.c: In function 'showDomains': > hellolibvirt/hellolibvirt.c:100:19: warning: comparison between signed and > unsigned integer expressions [-Wsign-compare] I thought we disabled those in

Re: [libvirt] [PATCH v2 0/2] Detect misconfiguration between disk bus and disk address

2016-12-20 Thread Michal Privoznik
On 29.11.2016 13:11, Marc Hartmayer wrote: > This patch series adds the functionality to detect a misconfiguration > between disk bus type and disk address type for disks that are using > the address type virDomainDeviceDriveAddress. It also adds a test for > it. > > A check for other bus types

Re: [libvirt] [PATCH 2/5] vz: don't query boot devices information for VZ, set boot from disk always

2016-12-20 Thread Nikolay Shirokovskiy
On 09.12.2016 17:36, Maxim Nestratov wrote: > Before, boot devices information for CTs was always empty and we > didn't indicate that containers always boot from disk. > > Signed-off-by: Maxim Nestratov > --- > src/vz/vz_sdk.c | 13 + > 1 file changed, 9

Re: [libvirt] [PATCH 2/2] qemu: qemuDomainDiskChangeSupported: Add missing 'address' check

2016-12-20 Thread Michal Privoznik
On 06.12.2016 15:30, Marc Hartmayer wrote: > Disk->info is not live updatable so add a check for this. Otherwise > libvirt reports success even though no data was updated. > > Signed-off-by: Marc Hartmayer > Reviewed-by: Bjoern Walk >

Re: [libvirt] [PATCH 0/2] qemuDomainDiskChangeSupported: Add missing 'address' check

2016-12-20 Thread Michal Privoznik
On 06.12.2016 15:30, Marc Hartmayer wrote: > Disk->info is not live updatable so add a check for this. Otherwise > libvirt reports success even though no data was updated. > > Marc Hartmayer (2): > conf: Make virDomainDeviceInfoAddressIsEqual() public > qemu: qemuDomainDiskChangeSupported:

Re: [libvirt] [PATCH 1/2] cgroup: unavailable controller prevents controller disabling

2016-12-20 Thread Michal Privoznik
On 08.12.2016 14:24, Boris Fiuczynski wrote: > The cgroup controller filtering in virCgroupDetect does not work > properly if the following conditions are met: > 1) the host system does not have a cgroup controller which > libvirt requests (unavailable controller) and > 2) libvirt is configured to

Re: [libvirt] [PATCH 0/2] cgroup: unavailable controller prevents controller disabling

2016-12-20 Thread Michal Privoznik
On 08.12.2016 14:24, Boris Fiuczynski wrote: > The problem description is covered in patch one. > I added patch two as an optional enhancement removing some complexity and > improving readability. If this finds common agreement it should simply be > squashed into the first patch of this series. >

Re: [libvirt] [PATCH 1/5] vz: report "scsi" bus for disks when nothing was set explixitly

2016-12-20 Thread Nikolay Shirokovskiy
On 09.12.2016 17:36, Maxim Nestratov wrote: > This is necessary for to show CTs created out of libvirt correctly. > > Signed-off-by: Maxim Nestratov > --- > src/vz/vz_sdk.c | 11 --- > 1 file changed, 4 insertions(+), 7 deletions(-) > > diff --git

[libvirt] [PATCH] examples: Resolve sign-compare warnings

2016-12-20 Thread Michal Privoznik
For instance: hellolibvirt/hellolibvirt.c: In function 'showDomains': hellolibvirt/hellolibvirt.c:100:19: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < numNames; i++) { ^ Signed-off-by: Michal Privoznik

Re: [libvirt] [PATCH v2 0/2] Detect misconfiguration between disk bus and disk address

2016-12-20 Thread Boris Fiuczynski
Seasonal ping... On 11/29/2016 01:11 PM, Marc Hartmayer wrote: This patch series adds the functionality to detect a misconfiguration between disk bus type and disk address type for disks that are using the address type virDomainDeviceDriveAddress. It also adds a test for it. A check for other

Re: [libvirt] [PATCH 0/2] qemuDomainDiskChangeSupported: Add missing 'address' check

2016-12-20 Thread Boris Fiuczynski
Seasonal ping... On 12/06/2016 03:30 PM, Marc Hartmayer wrote: Disk->info is not live updatable so add a check for this. Otherwise libvirt reports success even though no data was updated. Marc Hartmayer (2): conf: Make virDomainDeviceInfoAddressIsEqual() public qemu:

Re: [libvirt] [PATCH 0/2] cgroup: unavailable controller prevents controller disabling

2016-12-20 Thread Boris Fiuczynski
Seasonal ping... :-) On 12/08/2016 02:24 PM, Boris Fiuczynski wrote: The problem description is covered in patch one. I added patch two as an optional enhancement removing some complexity and improving readability. If this finds common agreement it should simply be squashed into the first patch

Re: [libvirt] [PATCH 22/89] configure: move XDR check to its own file

2016-12-20 Thread Jiri Denemark
On Fri, Dec 16, 2016 at 10:10:50 +0100, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > configure.ac | 40 ++- > m4/virt-xdr.m4 | 60 > ++ > 2 files changed, 62

Re: [libvirt] [PATCH 21/89] configure: move atomic check to its onw file

2016-12-20 Thread Jiri Denemark
On Fri, Dec 16, 2016 at 10:10:49 +0100, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > configure.ac | 55 +-- > m4/virt-atomic.m4 | 77 > +++ > 2 files changed, 78