Re: [libvirt] [PATCH 0/9] Couple of *BSD fixes

2017-01-01 Thread Roman Bogorodskiy
Michal Privoznik wrote: > After Andrea pointed out that FreeBSD build is broken [1], I've > started my freebsd domain and found out couple of problems. Here > are the fixes. > > Oh, I've noticed alternative approaches to patch 6/9 on the list > [2] [3]. None of them have been ACKed though.

Re: [libvirt] [PATCH 7/9] bhyvexml2argvdata: Fix addresses

2017-01-01 Thread Roman Bogorodskiy
Michal Privoznik wrote: > After c07d1c1c4f got merged it uncovered couple of broken domain > XMLs for bhyvexml2argv test. Some disk drives had incompatible > type of address configured. > > Signed-off-by: Michal Privoznik > --- >

Re: [libvirt] [PATCH 6/9] networkxml2conftest: s/lo/lo0/ on non-Linux

2017-01-01 Thread Roman Bogorodskiy
Michal Privoznik wrote: > After 478ddedc12 a bug is fixed where we wrongly presumed loopack > device name on non-Linux systems. It's lo0. However, the fix is > not reflected in the tests which are failing now. > > Signed-off-by: Michal Privoznik > --- >

Re: [libvirt] [PATCH 1/9] tests: Run virmacmaptest iff WITH_YAJL

2017-01-01 Thread Roman Bogorodskiy
Michal Privoznik wrote: > Since the internal implementation relies on a json parser being > available, it make no sense to run this test if there's none > available. > > Signed-off-by: Michal Privoznik > --- > tests/Makefile.am | 11 --- > 1 file changed, 8

Re: [libvirt] [PATCH 3/3] networkxml2conftest: Fix build on BSD

2017-01-01 Thread Roman Bogorodskiy
Martin Kletzander wrote: > On Fri, Dec 30, 2016 at 05:06:40PM +0100, Martin Kletzander wrote: > >On Fri, Dec 30, 2016 at 04:00:21PM +0400, Roman Bogorodskiy wrote: > >> Martin Kletzander wrote: > >> > >>> Yet another way to fix the different loopback naming. This variant > >>> doesn't use