Re: [libvirt] qemu-kvm blocked for more than 120 seconds when "libvirt-guests" is enabled

2017-01-07 Thread Oscar Segarra
Anybody can help with this problem? El 31 dic. 2016 5:25 p. m., "Oscar Segarra" escribió: > Hi, > > I just have two virtual machines in my environment, I want them to > gracefully stop when host is powered off gracefully. > > Nevertheless, system hangs on shutdown: > >

Re: [libvirt] [PATCH 0/2] Fix issues getting voldef capacity value

2017-01-07 Thread John Ferlan
ping ** 2 Thanks John On 12/15/2016 05:36 PM, John Ferlan wrote: > > ping? > > Thanks > > John > > On 12/06/2016 06:43 PM, John Ferlan wrote: >> Details in each patch - essentially trying to get "more correct" values. >> >> John Ferlan (2): >> storage: Fix

Re: [libvirt] [PATCH 00/11] Adjust build/start format checking for fs, disk, and logical backends

2017-01-07 Thread John Ferlan
ping? Thanks - John (couple of bz's sprinkled in here too from previous postings - patch 2 and patch 10 dealing with NO_OVERWRITE) On 12/15/2016 04:42 PM, John Ferlan wrote: > Two of these patches (2 and 10) are followups to no-overwrite patches > previously posted (I left links in the

Re: [libvirt] [PATCH] disk: Fixup error handling path for devmapper when part_separator='yes'

2017-01-07 Thread John Ferlan
ping**3 Thanks John On 12/15/2016 05:35 PM, John Ferlan wrote: > ping? > > Thanks - > > John > > On 12/03/2016 09:06 AM, John Ferlan wrote: >> >> ping? >> >> Tks - >> >> John >> >> On 11/17/2016 09:55 AM, John Ferlan wrote: >>> https://bugzilla.redhat.com/show_bug.cgi?id=1346566 >>> >>> If

Re: [libvirt] [PATCH 6/6] qemu: blockjob: Fix locking of block copy/active block commit

2017-01-07 Thread John Ferlan
On 12/16/2016 11:24 AM, Peter Krempa wrote: > For the blockjobs, where libvirt is able to track the state internally > we can fix locking of images we can remove the appropriate locks. > > Also when doing a pivoting operation we should not acquire the lock on > any of those images since both

Re: [libvirt] [PATCH 5/6] qemu: snapshot: Properly handle image locking

2017-01-07 Thread John Ferlan
On 12/16/2016 11:24 AM, Peter Krempa wrote: > Images that became the backing chain of the current image due to the > snapshot need to be unlocked in the lock manager. Also if qemu was > paused during the snapshot the current top level images need to be > released until qemu is resumed so that

Re: [libvirt] [PATCH 4/6] qemu: snapshot: Refactor snapshot rollback on failure

2017-01-07 Thread John Ferlan
On 12/16/2016 11:24 AM, Peter Krempa wrote: > The code at first changed the definition and then rolled it back in case > of failure. This was ridiculous. Refactor the code so that the image in > the definition is changed only when the snapshot is successful. > > The refactor will also simplify

Re: [libvirt] [PATCH 3/6] qemu: snapshot: Don't redetect backing chain after snapshot

2017-01-07 Thread John Ferlan
On 12/16/2016 11:24 AM, Peter Krempa wrote: > Libvirt is able to properly model what happens to the backing chain > after a snapshot so there's no real need to redetect the data. > Additionally with the _REUSE_EXT flag this might end up in redetecting > wrong data if the user puts wrong backing

Re: [libvirt] [PATCH] virsh: fix a typo

2017-01-07 Thread John Ferlan
On 01/07/2017 03:47 AM, Chen Hanxiao wrote: > From: Chen Hanxiao > > s/rather then/rather than > > Signed-off-by: Chen Hanxiao > --- > tools/virsh.pod | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > ACK - trivial... Now pushed. Tks,

Re: [libvirt] [PATCH 4/6] security_dac: Implement transaction APIs

2017-01-07 Thread John Ferlan
On 12/19/2016 10:57 AM, Michal Privoznik wrote: > Signed-off-by: Michal Privoznik > --- > src/security/security_dac.c | 193 > > 1 file changed, 193 insertions(+) > Might have been nice to add some basic/sparse documentation

Re: [libvirt] [PATCH 3/6] security driver: Introduce transaction APIs

2017-01-07 Thread John Ferlan
On 12/19/2016 10:57 AM, Michal Privoznik wrote: > With our new qemu namespace code in place, the relabelling of > devices is done not as good is it could: a child process is > spawned, it enters the mount namespace of the qemu process and > then runs desired API of the security driver. Extra

Re: [libvirt] [PATCH 2/6] security_dac: Resolve virSecurityDACSetOwnershipInternal const correctness

2017-01-07 Thread John Ferlan
On 12/19/2016 10:57 AM, Michal Privoznik wrote: > The code at the very bottom of the DAC secdriver that calls > chown() should be fine with read-only data. If something needs to > be prepared it should have been done beforehand. > > Signed-off-by: Michal Privoznik > --- >

Re: [libvirt] [PATCH 1/6] security_selinux: s/virSecuritySELinuxSecurity/virSecuritySELinux/

2017-01-07 Thread John Ferlan
On 12/19/2016 10:57 AM, Michal Privoznik wrote: > It doesn't make much sense to have two different prefix for > functions within the same driver. > > Signed-off-by: Michal Privoznik > --- > src/security/security_selinux.c | 26 +- > 1 file changed,

[libvirt] [PATCH] virsh: fix a typo

2017-01-07 Thread Chen Hanxiao
From: Chen Hanxiao s/rather then/rather than Signed-off-by: Chen Hanxiao --- tools/virsh.pod | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index ef91223..e5c94e7 100644 --- a/tools/virsh.pod