[libvirt] [RFC] Vhost-user backends cross-version migration support

2017-02-01 Thread Maxime Coquelin
Hi, Few months ago, Michael reported a problem about migrating VMs relying on vhost-user between hosts supporting different backend versions: - Message-Id: <20161011173526-mutt-send-email-...@kernel.org> - https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg03026.html The goal of this t

Re: [libvirt] [PATCH] qemu: Fix indentation in qemu_interface.h

2017-02-01 Thread Michal Privoznik
On 01/31/2017 05:35 PM, Nitesh Konkar wrote: > Signed-off-by: Nitesh Konkar > --- > src/qemu/qemu_interface.h | 15 --- > 1 file changed, 8 insertions(+), 7 deletions(-) > > diff --git a/src/qemu/qemu_interface.h b/src/qemu/qemu_interface.h > index 66ead2a..a7faa0b 100644 > --- a/src

Re: [libvirt] [RFC] Vhost-user backends cross-version migration support

2017-02-01 Thread Michal Privoznik
On 02/01/2017 09:35 AM, Maxime Coquelin wrote: > Hi, > > Few months ago, Michael reported a problem about migrating VMs relying > on vhost-user between hosts supporting different backend versions: > - Message-Id: <20161011173526-mutt-send-email-...@kernel.org> > - https://lists.gnu.org/archive/

Re: [libvirt] [PATCH] qemu: add host per cpu info to all domain stats

2017-02-01 Thread Peter Krempa
On Wed, Feb 01, 2017 at 09:47:20 +0300, Nikolay Shirokovskiy wrote: > Info provided in virDomainGetCPUStats is now missed in all > domain stats. This patch removes this discrepancy. > > Output example: > > cpu.count=2 > cpu.0.time=536163399467 > cpu.1.time=453846564946 > cpu.0.vtime=53005

Re: [libvirt] [PATCH] qemu: add host per cpu info to all domain stats

2017-02-01 Thread Nikolay Shirokovskiy
On 01.02.2017 12:35, Peter Krempa wrote: > On Wed, Feb 01, 2017 at 09:47:20 +0300, Nikolay Shirokovskiy wrote: >> Info provided in virDomainGetCPUStats is now missed in all >> domain stats. This patch removes this discrepancy. >> >> Output example: >> >> cpu.count=2 >> cpu.0.time=536163399467

Re: [libvirt] [PATCH v3] Add support for Veritas HyperScale (VxHS) block device protocol

2017-02-01 Thread Peter Krempa
On Wed, Jan 25, 2017 at 10:59:59 -0500, John Ferlan wrote: > > > On 01/19/2017 09:21 PM, Ashish Mittal wrote: > > Sample XML for a vxhs vdisk is as follows: > > > > > > > > > > > > > > > > > > eb90327c-8302-4725-9e1b-4e85ed4dc251 > > > >> function='0x0'/> > > > >

Re: [libvirt] [RFC] Vhost-user backends cross-version migration support

2017-02-01 Thread Daniel P. Berrange
On Wed, Feb 01, 2017 at 10:14:54AM +0100, Michal Privoznik wrote: > On 02/01/2017 09:35 AM, Maxime Coquelin wrote: > > Solution 3: Libvirt queries OVS for vhost backend version string: *OK* > > == > > > > > > The idea is to hav

Re: [libvirt] [RFC] Vhost-user backends cross-version migration support

2017-02-01 Thread Maxime Coquelin
On 02/01/2017 10:43 AM, Daniel P. Berrange wrote: On Wed, Feb 01, 2017 at 10:14:54AM +0100, Michal Privoznik wrote: On 02/01/2017 09:35 AM, Maxime Coquelin wrote: Solution 3: Libvirt queries OVS for vhost backend version string: *OK* =

Re: [libvirt] [RFC] Vhost-user backends cross-version migration support

2017-02-01 Thread Daniel P. Berrange
On Wed, Feb 01, 2017 at 12:33:22PM +0100, Maxime Coquelin wrote: > > > On 02/01/2017 10:43 AM, Daniel P. Berrange wrote: > > On Wed, Feb 01, 2017 at 10:14:54AM +0100, Michal Privoznik wrote: > > > On 02/01/2017 09:35 AM, Maxime Coquelin wrote: > > > > > > Solution 3: Libvirt queries OVS for vhos

Re: [libvirt] [PATCH v3] Add support for Veritas HyperScale (VxHS) block device protocol

2017-02-01 Thread John Ferlan
On 02/01/2017 04:39 AM, Peter Krempa wrote: > On Wed, Jan 25, 2017 at 10:59:59 -0500, John Ferlan wrote: >> >> >> On 01/19/2017 09:21 PM, Ashish Mittal wrote: >>> Sample XML for a vxhs vdisk is as follows: >>> >>> >>> >>> >>> >>> >>> >>> >>> eb90327c-8302-4725-9e1b-4e85ed4d

[libvirt] [PATCH] bhyve: fix virtio disk addresses

2017-02-01 Thread Roman Bogorodskiy
Like it usually happens, I fixed one thing and broke another: in 803966c76 address allocation was fixed for SATA disks, but broke that for virtio disks, because it dropped disk address assignment completely. It's not needed for SATA disks anymore, but still needed for the virtio ones. Bring that b

Re: [libvirt] [PATCH v3] Add support for Veritas HyperScale (VxHS) block device protocol

2017-02-01 Thread John Ferlan
On 01/27/2017 08:43 PM, ashish mittal wrote: > Thanks for the review! > > My inputs on some of the comments - > > On Wed, Jan 25, 2017 at 7:59 AM, John Ferlan wrote: >> >> >> On 01/19/2017 09:21 PM, Ashish Mittal wrote: >>> Sample XML for a vxhs vdisk is as follows: >>> >>> >>> >>> >>>

[libvirt] [PATCH v4] bhyve: add e1000 nic support

2017-02-01 Thread Roman Bogorodskiy
Recently e1000 NIC support was added to bhyve; implement that in the bhyve driver: - Add capability check by analyzing output of the 'bhyve -s 0,e1000' command - Modify bhyveBuildNetArgStr() to support e1000 and also pass virConnectPtr so it could call bhyveDriverGetCaps() to check if this

Re: [libvirt] [PATCH v3] Add support for Veritas HyperScale (VxHS) block device protocol

2017-02-01 Thread John Ferlan
[...] Pressed send too soon, sigh. >>> >>> #1. Based on Peter's v2 comments, we don't want to support the >>> older/legacy syntax for VxHS, so it's something that should be removed - >>> although we should check for it being present and fail if found. >>> >> >> I am testing with changed code to r

[libvirt] [PATCH] qemu: turn on virtlockd by default

2017-02-01 Thread Daniel P. Berrange
The virtlockd daemon has existed for years now, but we have never turned it on by default, requiring explicit user opt-in. This leaves users unprotected against accidents out of the box. By turning it on by default, users will at least be protected for mistakes involving local files, and files on

Re: [libvirt] [PATCH] qemu: turn on virtlockd by default

2017-02-01 Thread Peter Krempa
On Wed, Feb 01, 2017 at 16:54:01 +, Daniel Berrange wrote: > The virtlockd daemon has existed for years now, but we have never > turned it on by default, requiring explicit user opt-in. This leaves > users unprotected against accidents out of the box. > > By turning it on by default, users wil

Re: [libvirt] [PATCH] qemu: turn on virtlockd by default

2017-02-01 Thread Daniel P. Berrange
On Wed, Feb 01, 2017 at 07:04:54PM +0100, Peter Krempa wrote: > On Wed, Feb 01, 2017 at 16:54:01 +, Daniel Berrange wrote: > > The virtlockd daemon has existed for years now, but we have never > > turned it on by default, requiring explicit user opt-in. This leaves > > users unprotected against

Re: [libvirt] [RFC] Vhost-user backends cross-version migration support

2017-02-01 Thread Michael S. Tsirkin
On Wed, Feb 01, 2017 at 11:41:19AM +, Daniel P. Berrange wrote: > On Wed, Feb 01, 2017 at 12:33:22PM +0100, Maxime Coquelin wrote: > > > > > > On 02/01/2017 10:43 AM, Daniel P. Berrange wrote: > > > On Wed, Feb 01, 2017 at 10:14:54AM +0100, Michal Privoznik wrote: > > > > On 02/01/2017 09:35

Re: [libvirt] [Xen-devel] [PATCH] libxl: fix dom0 autoballooning with Xen 4.8

2017-02-01 Thread Jim Fehlig
Jim Fehlig wrote: > xen.git commit 57f8b13c changed several of the libxl memory > get/set functions to take 64 bit parameters. The libvirt > libxl driver still uses uint32_t variables for these various > parameters, which is particularly problematic for the > libxl_set_memory_target() function. >

Re: [libvirt] [PATCH] char: drop data written to a disconnected pty

2017-02-01 Thread Paolo Bonzini
On 31/01/2017 14:19, Ed Swierk wrote: > Either way, when a pty is disconnected data will get dropped, whether > by the pty backend (as proposed) or by the serial port device or other > frontend (as currently). > > The only difference from a user's perspective is whether the dropped > data gets w