Re: [libvirt] [PATCH 1/2] qemu: hotplug: Add debug log when dispatching device removal to existing thread

On Fri, Mar 03, 2017 at 16:11:49 +0100, Peter Krempa wrote: > Note that the waiting thread is singalled in the debug logs to simplify s/sing/sign/ as noted by Marc. The double L may be OK depending on which side of the Atlantic Ocean is closer to your heart :-) ACK Jirka -- libvir-list mailing

Re: [libvirt] [RFC PATCH 1/2] qemu: Advertise ACPI support for aarch64 guests

On Wed, 2017-03-08 at 18:57 +0100, Laszlo Ersek wrote: > On 03/08/17 18:12, Daniel P. Berrange wrote: > > The scenario I was actually thinking of was direct kernel boot, > > rather than non-AAVMF impls of UEFI. > >  > > IOW, where you just pass -kernel/-initrd/-dtb to QEMU and no firmware > >

[libvirt] [PATCH for-2.9 v3 0/3] Use non-blacklisted family/model/stepping for Haswell CPU model

I plan to merge this bug fix into 2.9. Changes v2 -> v3: * Rebase to latest master * Don't touch max_x86_cpu_initfn() to reduce risk post hard freeze Changes v1 -> v2: * Coding style fixes * Make series simpler: * Don't use trick: char vendor[static (CPUID_VENDOR_SZ + 1)] because it

[libvirt] [PATCH for-2.9 v3 3/3] i386: Change stepping of Haswell to non-blacklisted value

glibc blacklists TSX on Haswell CPUs with model==60 and stepping < 4. To make the Haswell CPU model more useful, make those guests actually use TSX by changing CPU stepping to 4. References: * glibc commit 2702856bf45c82cf8e69f2064f5aa15c0ceb6359

[libvirt] [PATCH for-2.9 v3 2/3] i386/kvm: Blacklist TSX on known broken hosts

Some Intel CPUs are known to have a broken TSX implementation. A microcode update from Intel disabled TSX on those CPUs, but GET_SUPPORTED_CPUID might be reporting it as supported if the hosts were not updated yet. Manually fixup the GET_SUPPORTED_CPUID data to ensure we will never enable TSX

[libvirt] [PATCH for-2.9 v3 1/3] i386: host_vendor_fms() helper function

Helper function for code that needs to check the host CPU vendor/family/model/stepping values. Signed-off-by: Eduardo Habkost --- Changes v2 -> v3: * Don't touch max_x86_cpu_initfn() to reduce risk post hard freeze Changes v1 -> v2: * Coding style fix (split long lines)

[libvirt] [PATCH 0/4] qemu: ACPI and UEFI fixes

Changes from [RFC]: * Add patches 3 and 4. [RFC] https://www.redhat.com/archives/libvir-list/2017-March/msg00347.html Andrea Bolognani (4): qemu: Advertise ACPI support for aarch64 guests tests: Initialize basic capabilities properly qemu: Enforce ACPI, UEFI requirements tests: Test

[libvirt] [PATCH 2/4] tests: Initialize basic capabilities properly

The capabilities used in test cases should match those used during normal operation for the tests to make any sense. --- src/qemu/qemu_capabilities.c | 2 ++ .../qemuxml2argv-balloon-ccw-deflate.args| 1 -

[libvirt] [PATCH 3/4] qemu: Enforce ACPI, UEFI requirements

Depending on the architecture, requirements for ACPI and UEFI can be different; more specifically, while on x86 UEFI requires ACPI, on aarch64 it's the other way around. Enforce these requirements when building the QEMU command line, and make the error message more accurate by mentioning that the

[libvirt] [PATCH 4/4] tests: Test ACPI, UEFI requirements

Make sure every combination of ACPI and UEFI works, or fails to work, as expected. --- .../qemuxml2argv-aarch64-acpi-nouefi.args | 22 ++ .../qemuxml2argv-aarch64-acpi-nouefi.xml | 27 ++ .../qemuxml2argv-aarch64-acpi-uefi.args|

[libvirt] [PATCH 1/4] qemu: Advertise ACPI support for aarch64 guests

So far, libvirt has assumed that only x86 supports ACPI, but that's inaccurate since aarch64 supports it too. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1429509 --- src/qemu/qemu_capabilities.c | 28 -- .../caps_2.6.0-gicv2.aarch64.xml

[libvirt] [PATCH v3 09/17] qemu: Implement @access for banks

Signed-off-by: Michal Privoznik --- src/qemu/qemu_command.c| 5 +++-- .../qemuxml2argv-memory-hotplug-nvdimm-access.args | 26 ++ tests/qemuxml2argvtest.c | 2 ++ 3 files changed, 31 insertions(+), 2

[libvirt] [PATCH v3 07/17] qemu: Implement NVDIMM

So, majority of the code is just ready as-is. Well, with one slight change: differentiate between dimm and nvdimm in places like device alias generation, generating the command line and so on. Speaking of the command line, we also need to append 'nvdimm=on' to the '-machine' argument so that the

[libvirt] [PATCH v3 17/17] qemu: Namespaces for NVDIMM

Signed-off-by: Michal Privoznik --- src/qemu/qemu_domain.c | 76 + src/qemu/qemu_domain.h | 8 ++ src/qemu/qemu_hotplug.c | 11 +++ 3 files changed, 95 insertions(+) diff --git a/src/qemu/qemu_domain.c

[libvirt] [PATCH v3 15/17] qemu_hotplug: Relabel memdev

Now that we have APIs for relabel memdevs on hotplug, fill in the missing implementation in qemu hotplug code. The qemuSecurity wrappers might look like overkill for now, because qemu namespace code does not deal with the nvdimms yet. Nor does our cgroup code. But hey, there's cgroup_device_acl

[libvirt] [PATCH v3 12/17] security_selinux: Label host side of NVDIMM

When domain is being started up, we ought to relabel the host side of NVDIMM so qemu has access to it. Signed-off-by: Michal Privoznik --- src/security/security_selinux.c | 66 + 1 file changed, 66 insertions(+) diff --git

[libvirt] [PATCH v3 14/17] secdrivers: Implement memdev relabel APIs

Signed-off-by: Michal Privoznik --- src/security/security_dac.c | 3 +++ src/security/security_nop.c | 19 +++ src/security/security_selinux.c | 3 +++ 3 files changed, 25 insertions(+) diff --git a/src/security/security_dac.c

[libvirt] [PATCH v3 16/17] qemu: Allow nvdimm in devices CGroups

Some users might want to pass a blockdev or a chardev as a backend for NVDIMM. In fact, this is expected to be the mostly used configuration. Therefore libvirt should allow the device in devices CGroup then. Signed-off-by: Michal Privoznik --- src/qemu/qemu_cgroup.c | 49

[libvirt] [PATCH v3 03/17] qemuBuildMemoryBackendStr: Pass virDomainMemoryDefPtr

Signed-off-by: Michal Privoznik --- src/qemu/qemu_command.c | 49 ++--- src/qemu/qemu_command.h | 5 + src/qemu/qemu_hotplug.c | 6 ++ 3 files changed, 25 insertions(+), 35 deletions(-) diff --git

[libvirt] [PATCH v3 08/17] conf: Introduce @access to

Now that NVDIMM has found its way into libvirt, users might want to fine tune some settings for each module separately. One such setting is 'share=on|off' for the memory-backend-file object. This setting - just like its name suggest already - enables sharing the nvdimm module with other

[libvirt] [PATCH v3 00/17] Introduce NVDIMM support

NVDIMMs are new type of ultra fast storage that's plugged into DIMM slot and can hold the stored info throughout reboots. After all, NV stands for non-volatile. In virtualization world, this has an awesome advantage - less VM_EXITs on 'disk' IO. https://nvdimm.wiki.kernel.org/ How to test this

[libvirt] [PATCH v3 04/17] qemuBuildMemoryBackendStr: Reorder args and update comment

Frankly, this function is one big mess. A lot of arguments, complicated behaviour. It's really surprising that arguments were in random order (input and output arguments were mixed together), the documentation was outdated, the description of return values was bogus. Signed-off-by: Michal

[libvirt] [PATCH v3 13/17] security: Introduce internal APIs for memdev labelling

These APIs will be used whenever we are hot (un-)plugging a memdev. Signed-off-by: Michal Privoznik --- src/libvirt_private.syms| 2 ++ src/security/security_driver.h | 9 +++ src/security/security_manager.c | 56 +

[libvirt] [PATCH v3 05/17] Introduce NVDIMM memory model

NVDIMM is new type of memory introduced into QEMU 2.6. The idea is that we have a Non-Volatile memory module that keeps the data persistent across domain reboots. At the domain XML level, we already have some representation of 'dimm' modules. Long story short, we have element that lives under .

[libvirt] [PATCH v3 10/17] qemu: Introduce label-size for NVDIMMs

For NVDIMM devices it is optionally possible to specify the size of internal storage for namespaces. Namespaces are a feature that allows users to partition the NVDIMM for different uses. Signed-off-by: Michal Privoznik --- docs/formatdomain.html.in

[libvirt] [PATCH v3 11/17] security_dac: Label host side of NVDIMM

When domain is being started up, we ought to relabel the host side of NVDIMM so qemu has access to it. Signed-off-by: Michal Privoznik --- src/security/security_dac.c | 73 + 1 file changed, 73 insertions(+) diff --git

[libvirt] [PATCH v3 01/17] qemuBuildMemoryBackendStr: Don't overwrite @force

This is an input argument. We should not overwrite it. Signed-off-by: Michal Privoznik --- src/qemu/qemu_command.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 6545a9325..f145cf9d8 100644 ---

[libvirt] [PATCH v3 06/17] qemu: Introduce QEMU_CAPS_DEVICE_NVDIMM

Introduce a qemu capability for -device nvdimm. Signed-off-by: Michal Privoznik --- src/qemu/qemu_capabilities.c | 9 + src/qemu/qemu_capabilities.h | 1 + 2 files changed, 10 insertions(+) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c

[libvirt] [PATCH v3 02/17] qemuBuildMemoryBackendStr: Check for @memAccess properly

Even though this variable contains just values from an enum where zero has the usual meaning, it's enum after all and we should check it as such. Signed-off-by: Michal Privoznik --- src/qemu/qemu_command.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [libvirt] [PATCH 4/6] bhyve: enumerate UEFI firmwares

Daniel P. Berrange wrote: > On Sun, Feb 12, 2017 at 07:12:32PM +0400, Roman Bogorodskiy wrote: > > From: Fabian Freyer > > > > Signed-off-by: Roman Bogorodskiy > > --- > > src/bhyve/bhyve_capabilities.c | 28

Re: [libvirt] [REPOST PATCHv2 2/6] conf: Convert virStoragePoolSourceAdapter to virStorageAdapter

On Sat, Mar 04, 2017 at 10:52:08AM -0500, John Ferlan wrote: Introduce src/conf/storage_adapter_conf.{c,h}. Separate out the parsing/formatting and management into a separate conf module. Move the virStoragePoolSourceAdapter from storage_conf.h and rename to virStorageAdapter. This includes

Re: [libvirt] [REPOST PATCHv2 1/6] tests: Add createVHBAByStoragePool-by-parent to fchosttest

On Sat, Mar 04, 2017 at 10:52:07AM -0500, John Ferlan wrote: Add a new test to fchosttest in order to test creation of our vHBA via the Storage Pool logic. Unlike the real code, we cannot yet use the virVHBA* API's because they (currently) traverse the file system in order to get the parent

Re: [libvirt] [PATCH 4/6] bhyve: enumerate UEFI firmwares

On Sun, Feb 12, 2017 at 07:12:32PM +0400, Roman Bogorodskiy wrote: > From: Fabian Freyer > > Signed-off-by: Roman Bogorodskiy > --- > src/bhyve/bhyve_capabilities.c | 28 > 1 file changed, 28 insertions(+) >

Re: [libvirt] [PATCH v2] Revert "conf: move iothread XML validation from qemu_command"

On Thu, Mar 09, 2017 at 03:09:54PM +0100, Pavel Hrdina wrote: This reverts commit c96bd78e4e71c799dc391566fa9f0652dec55dca. So our code is one big mess and we modify domain definition while building qemu_command line and our hotplug code share only part of the parsing and command line building

Re: [libvirt] Revisiting qemu monitor timeout on VM start

On Thu, Mar 09, 2017 at 09:00:47AM +0100, Michal Privoznik wrote: > On 03/08/2017 10:19 PM, Jim Fehlig wrote: > > Hi All, > > > > Encountering a qemu monitor timeout when starting a VM has been discussed > > here > > before, e.g. > > > >

Re: [libvirt] [PATCH 1/6] bhyve: virBhyveProbeCaps: BHYVE_CAP_LPC_BOOTROM

Fabian Freyer wrote: > On 08.03.2017 18:19, Michal Privoznik wrote: > > ACK, but we really need a better way to detect capabilites. For instance > > now, bhyve binary is executed 4 times just to find out whether it > > supports 4 capabilities. That's just madness. Maybe we can get in touch > >

Re: [libvirt] [PATCH] configure: disable scsi stroage driver on non-Linux

Michal Privoznik wrote: > On 03/05/2017 03:20 PM, Roman Bogorodskiy wrote: > > Even though scsi storage driver builds fine on non-Linux, it > > will not work properly because it relies on Linux procfs, so > > disable that in configure if we're not building for Linux. > > --- > > configure.ac |

Re: [libvirt] [PATCH v2 08/14] security_dac: Label host side of NVDIMM

On 03/07/2017 06:36 PM, John Ferlan wrote: > > > On 02/27/2017 08:19 AM, Michal Privoznik wrote: >> When domain is being started up, we ought to relabel the host >> side of NVDIMM so qemu has access to it. >> >> Signed-off-by: Michal Privoznik >> --- >>

[libvirt] [PATCH v2] Revert "conf: move iothread XML validation from qemu_command"

This reverts commit c96bd78e4e71c799dc391566fa9f0652dec55dca. So our code is one big mess and we modify domain definition while building qemu_command line and our hotplug code share only part of the parsing and command line building code. Let's revert that change because to fix it properly would

Re: [libvirt] [PATCH v2 07/14] qemu: Introduce label-size for NVDIMMs

On 03/07/2017 05:55 PM, John Ferlan wrote: > > > On 02/27/2017 08:19 AM, Michal Privoznik wrote: >> For NVDIMM devices it is optionally possible to specify the size >> of internal storage for namespaces. Namespaces are a feature that >> allows users to partition the NVDIMM for different uses. >>

Re: [libvirt] [PATCH] domain_conf: move iothread check for address type back to qemu_command

On Wed, Mar 08, 2017 at 05:50:11PM +0100, Pavel Hrdina wrote: This partially reverts commit c96bd78e4e. That commit also moved the check that ensures the controller type is virtio-scsi. However, it seems qemuDomainSetSCSIControllerModel which can also possibly set the default model to

[libvirt] [PATCH 1/1] perf: list all supported events when get domain stats

Currently when virDomainListGetStats is called, the stats for those disabled perf events won't be showed in result. This will produce some problems for applications based on libvirt sometime, e.g. the OpenStack bug https://bugs.launchpad.net/ceilometer/+bug/1670948 This patch just show '0' in

Re: [libvirt] [PATCH v2 06/14] qemu: Implement @access for banks

On 03/07/2017 05:31 PM, John Ferlan wrote: > > > On 02/27/2017 08:19 AM, Michal Privoznik wrote: >> Signed-off-by: Michal Privoznik >> --- >> src/qemu/qemu_command.c| 11 +++-- >> src/qemu/qemu_command.h| 1 + >>

Re: [libvirt] [PATCH v2 05/14] conf: Introduce @access to

On 03/07/2017 05:23 PM, John Ferlan wrote: > > > On 02/27/2017 08:19 AM, Michal Privoznik wrote: >> Now that NVDIMM has found its way into libvirt, users might want >> to fine tune some settings for each module separately. One such >> setting is 'share=on|off' for the memory-backend-file object.

Re: [libvirt] [PATCH v3] doc: Correct the default werror policy

On Wed, Mar 08, 2017 at 07:26:08PM +0100, Philipp Hahn wrote: Hello, Am 08.03.2017 um 17:28 schrieb Martin Kletzander: On Wed, Mar 01, 2017 at 08:44:54PM +0100, Philipp Hahn wrote: The documentation is plain wrong about the default write_error policy, as its only implemented by QEMU

Re: [libvirt] [PATCH v2 02/14] Introduce NVDIMM memory model

On 03/07/2017 05:01 PM, John Ferlan wrote: > > > On 02/27/2017 08:19 AM, Michal Privoznik wrote: >> NVDIMM is new type of memory introduced into QEMU 2.6. The idea >> is that we have a Non-Volatile memory module that keeps the data >> persistent across domain reboots. >> >> At the domain XML

Re: [libvirt] [RFC] qemu: monitor: do not report error on shutdown

On Thu, Mar 9, 2017 at 10:54 AM, Christian Ehrhardt < christian.ehrha...@canonical.com> wrote: > In those cases do not report an > internal error like: > "internal error: End of file from qemu monitor" > There is some extra background on the issue that shall be fixed at [1]. According to my

[libvirt] [RFC] qemu: monitor: do not report error on shutdown

If a shutdown is expected because it was triggered via libvirt we can also expect the monitor to close. In those cases do not report an internal error like: "internal error: End of file from qemu monitor" Signed-off-by: Christian Ehrhardt ---

Re: [libvirt] Making containers creation easy

On Thu, Mar 09, 2017 at 09:35:18AM +0100, Michal Privoznik wrote: > On 03/09/2017 09:28 AM, Cedric Bosdonnat wrote: > > Hi Michal, > > > > On Thu, 2017-03-09 at 08:54 +0100, Michal Privoznik wrote: > >> On 03/08/2017 06:16 PM, Cedric Bosdonnat wrote: > >>> Hi all, > >>> > >>> I've worked on

Re: [libvirt] [PATCH v2 0/2] fix migration related graphics listen code bugs

On Thu, Mar 09, 2017 at 10:27:07 +0100, Pavel Hrdina wrote: > Pavel Hrdina (2): > conf: store "autoGenerated" for graphics listen in status XML > conf: properly skip graphics listen element in migratable XML > > src/conf/domain_conf.c | 20 +++- > src/qemu/qemu_domain.c | 3

[libvirt] [PATCH v2 0/2] fix migration related graphics listen code bugs

Pavel Hrdina (2): conf: store "autoGenerated" for graphics listen in status XML conf: properly skip graphics listen element in migratable XML src/conf/domain_conf.c | 20 +++- src/qemu/qemu_domain.c | 3 ++- 2 files changed, 21 insertions(+), 2 deletions(-) -- 2.12.0 --

[libvirt] [PATCH v2 1/2] conf: store "autoGenerated" for graphics listen in status XML

When libvirtd is started we call qemuDomainRecheckInternalPaths to detect whether a domain has VNC socket path generated by libvirt based on option from qemu.conf. However if we are parsing status XML for running domain the existing socket path can be generated also if the config XML uses the new

[libvirt] [PATCH v2 2/2] conf: properly skip graphics listen element in migratable XML

We should skip only if the 'socket' path is specified because if there is no 'socket' path we need to keep that element in migratable XML. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1366088 Signed-off-by: Pavel Hrdina --- Notes: Version 2: - no change

Re: [libvirt] [PATCH v2 00/10] perf: Add software perf events

On Mon, Mar 06, 2017 at 02:55:18PM -0500, John Ferlan wrote: > > > On 02/23/2017 09:55 AM, Nitesh Konkar wrote: > > This patch series adds software perf events. > > The perl and go patches shall follow shortly. > > > > Nitesh Konkar (10): > > perf: add cpu_clock software perf event support >

Re: [libvirt] [PATCH v2 00/10] perf: Add software perf events

On Wed, Mar 8, 2017 at 12:31 AM, John Ferlan wrote: > > > On 03/06/2017 02:55 PM, John Ferlan wrote: > > > > > > On 02/23/2017 09:55 AM, Nitesh Konkar wrote: > >> This patch series adds software perf events. > >> The perl and go patches shall follow shortly. > >> > >> Nitesh

Re: [libvirt] [PATCH 1/2] conf: store "autoGenerated" for graphics listen in status XML

On Mon, Feb 27, 2017 at 17:31:05 +0100, Pavel Hrdina wrote: > When libvirtd is started we call qemuDomainRecheckInternalPaths > to detect whether a domain has VNC socket path generated by libvirt > based on option from qemu.conf. However if we are parsing status XML > for running domain the

Re: [libvirt] [PATCH v2 01/14] qemuBuildMemoryBackendStr: Reorder args and update comment

On 03/07/2017 05:00 PM, John Ferlan wrote: > > > On 02/27/2017 08:19 AM, Michal Privoznik wrote: >> Frankly, this function is one big mess. A lot of arguments, >> complicated behaviour. It's really surprising that arguments were >> in random order (input and output arguments were mixed

Re: [libvirt] [PATCH v2 03/14] qemu: Introduce QEMU_CAPS_DEVICE_NVDIMM

On 03/07/2017 05:01 PM, John Ferlan wrote: > > > On 02/27/2017 08:19 AM, Michal Privoznik wrote: >> Introduce a qemu capability for -device nvdimm. >> >> Signed-off-by: Michal Privoznik >> --- >> src/qemu/qemu_capabilities.c | 9 + >> src/qemu/qemu_capabilities.h |

Re: [libvirt] Making containers creation easy

On 03/09/2017 09:28 AM, Cedric Bosdonnat wrote: > Hi Michal, > > On Thu, 2017-03-09 at 08:54 +0100, Michal Privoznik wrote: >> On 03/08/2017 06:16 PM, Cedric Bosdonnat wrote: >>> Hi all, >>> >>> I've worked on making the containers rootfs creation easy. >>> Here is a wrap-up of my work: >>> >>>

Re: [libvirt] Making containers creation easy

Hi Michal, On Thu, 2017-03-09 at 08:54 +0100, Michal Privoznik wrote: > On 03/08/2017 06:16 PM, Cedric Bosdonnat wrote: > > Hi all, > > > > I've worked on making the containers rootfs creation easy. > > Here is a wrap-up of my work: > > > > http://bosdonnat.fr/system-container-images.html > >

Re: [libvirt] Revisiting qemu monitor timeout on VM start

On 03/08/2017 10:19 PM, Jim Fehlig wrote: > Hi All, > > Encountering a qemu monitor timeout when starting a VM has been discussed here > before, e.g. > > https://www.redhat.com/archives/libvir-list/2014-January/msg00060.html >