Re: [libvirt] [RFC PATCH v2 REBASE 00/18] Introduce vGPU mdev framework to libvirt

2017-03-16 Thread Chen, Xiaoguang
>-Original Message- >From: Erik Skultety [mailto:eskul...@redhat.com] >Sent: Thursday, March 16, 2017 10:41 PM >To: Chen, Xiaoguang >Cc: libvir-list@redhat.com; He, Yongli >Subject: Re: [libvirt] [RFC PATCH v2 REBASE 00/18] Introduce vGPU mdev >framework to libvirt > >> [2] 2005 >> ubun

Re: [libvirt] [RFC PATCH v2 REBASE 00/18] Introduce vGPU mdev framework to libvirt

2017-03-16 Thread Chen, Xiaoguang
>-Original Message- >From: sendmail [mailto:justsendmailnothinge...@gmail.com] On Behalf Of Laine >Stump >Sent: Thursday, March 16, 2017 10:01 PM >To: libvir-list@redhat.com >Cc: Chen, Xiaoguang ; Erik Skultety >; He, Yongli >Subject: Re: [libvirt] [RFC PATCH v2 REBASE 00/18] Introduce v

[libvirt] [PATCH v1 2/2] Add asyncio event loop implementation

2017-03-16 Thread Wojtek Porczyk
This is usable only on python >= 3.4 (or 3.3 with out-of-tree asyncio), however it should be harmless for anyone with older python versions. In simplest case, to have the callbacks queued on the default loop: >>> import libvirt >>> libvirt.virEventRegisterAsyncIOImpl() The function is no

[libvirt] [PATCH v1 1/2] Allow for ff callbacks to be called by custom event implementations

2017-03-16 Thread Wojtek Porczyk
The documentation says: > If the opaque user data requires free'ing when the handle is > unregistered, then a 2nd callback can be supplied for this purpose. > This callback needs to be invoked from a clean stack. If 'ff' > callbacks are invoked directly from the virEventRemoveHandleFunc they > will

[libvirt] [PATCH v1 0/2] libvirt-python: virEventAsyncIOImpl (was: libvirtaio)

2017-03-16 Thread Wojtek Porczyk
Hello, As promised, this is the event loop implementation which dispatches the callbacks via asyncio's event loop. There are two patches: the first one fixes the bug around freeing opaque objects [1][2], and the second one is the actual implementation. Compared to standalone version I did earlie

Re: [libvirt] [PATCH v2 5/5] network: check accept_ra before enabling ipv6 forwarding

2017-03-16 Thread Laine Stump
On 03/15/2017 10:45 AM, Cédric Bosdonnat wrote: > When enabling IPv6 on all interfaces, we may get the host Router > Advertisement routes discarded. To avoid this, the user needs to set > accept_ra to 2 for the interfaces with such routes. > > See https://www.kernel.org/doc/Documentation/networkin

Re: [libvirt] [PATCH v2 4/5] util: add virNetDevGetName() function

2017-03-16 Thread Laine Stump
On 03/15/2017 10:45 AM, Cédric Bosdonnat wrote: > Add a function getting the name of a network interface out of its index. > --- > src/libvirt_private.syms | 1 + > src/util/virnetdev.c | 19 +++ > src/util/virnetdev.h | 2 ++ > 3 files changed, 22 insertions(+) > > diff

Re: [libvirt] [PATCH v2 3/5] bridge_driver.c: more uses of SYSCTL_PATH

2017-03-16 Thread Laine Stump
On 03/15/2017 10:45 AM, Cédric Bosdonnat wrote: > Replace a few occurences of /proc/sys by the corresponding macro > defined a few lines after: SYSCTL_PATH > --- > src/network/bridge_driver.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) ACK. -- libvir-list mailing list libvir

Re: [libvirt] [PATCH v2 2/5] util: add virNetlinkDumpCommand()

2017-03-16 Thread Laine Stump
On 03/15/2017 10:45 AM, Cédric Bosdonnat wrote: > virNetlinkCommand() processes only one response message, while some > netlink commands like routes dumping need to process several ones. "while some netlink commands, like route dumping, need to process several." > Add virNetlinkDumpCommand() as

Re: [libvirt] [PATCH v2 1/5] util: extract the request sending code from virNetlinkCommand()

2017-03-16 Thread Laine Stump
On 03/15/2017 10:45 AM, Cédric Bosdonnat wrote: > Allow to reuse as much as possible from virNetlinkCommand(). This > comment prepares for the introduction of virNetlindDumpCommand() s/Netlind/Netlink/ :-) > only differing by how it handles the responses. > --- > src/util/virnetlink.c | 89 > +

Re: [libvirt] [PATCH v2 3/4] tests: Test generic PCIe Root Ports

2017-03-16 Thread Laine Stump
On 03/16/2017 01:14 PM, Andrea Bolognani wrote: > We want pcie-root-ports to be used when available in QEMU, > but at the same time we need to ensure that hosts running > older QEMU releases keep working and that the user can > override the default at any time. > > Add a comment for the original p

Re: [libvirt] [PATCH v2 4/4] news: Document support for generic PCIe Root Ports

2017-03-16 Thread Laine Stump
On 03/16/2017 01:14 PM, Andrea Bolognani wrote: > --- > Changes from v1: > > * Include model names; > * Reword slightly. > > docs/news.xml | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/docs/news.xml b/docs/news.xml > index 097a09a..3501f89 100644 > --- a/docs/news.xml

Re: [libvirt] [PATCH v2 2/4] qemu: Use generic PCIe Root Ports by default when available

2017-03-16 Thread Laine Stump
On 03/16/2017 01:14 PM, Andrea Bolognani wrote: > ioh3420 is emulated Intel hardware, so it always looked > quite out of place in aarch64/virt guests. Even for x86/q35 > guests, the recently-introduced pcie-root-port is a better > choice because, unlike ioh3420, it doesn't require IO space > (a far

Re: [libvirt] [PATCH v2 1/4] qemu: Add support for generic PCIe Root Ports

2017-03-16 Thread Laine Stump
On 03/16/2017 01:14 PM, Andrea Bolognani wrote: > QEMU 2.9 introduces the pcie-root-port device, which is > a generic version of the existing ioh3420 device. > > Make the new device available to libvirt users. > --- > docs/schemas/domaincommon.rng| 1 + > src/conf/domain_conf

Re: [libvirt] [PATCH 1/1] perf: list all supported events when get domain stats

2017-03-16 Thread John Ferlan
On 03/09/2017 01:06 AM, Qiaowei Ren wrote: > Currently when virDomainListGetStats is called, the stats for those > disabled perf events won't be showed in result. This will produce > some problems for applications based on libvirt sometime, e.g. the > OpenStack bug https://bugs.launchpad.net/ceil

Re: [libvirt] libvirtaio: libvirt-python asyncio event impl

2017-03-16 Thread Daniel P. Berrange
On Thu, Mar 16, 2017 at 06:24:46PM +0100, Wojtek Porczyk wrote: > On Thu, Mar 16, 2017 at 04:38:23PM +, Daniel P. Berrange wrote: > > On Thu, Mar 16, 2017 at 05:30:40PM +0100, Wojtek Porczyk wrote: > > > Hello, libvirt-list, > > > > > > I wrote an event implementation wrapping an asyncio event

Re: [libvirt] limit cpu speed in domain xml

2017-03-16 Thread Daniel P. Berrange
On Thu, Mar 16, 2017 at 08:41:48PM +0300, Vasiliy Tolstov wrote: > Thanks! Next question, does it possible to provide constant speed for vps > in case of cloud service? For example user buy vps with 500mhz or 1ghz and > pay for guaranteed resource? IMHO that's a pretty poor way to provide/allocate

Re: [libvirt] limit cpu speed in domain xml

2017-03-16 Thread Vasiliy Tolstov
16 Мар 2017 г. 13:18 пользователь "Daniel P. Berrange" написал: On Thu, Mar 16, 2017 at 12:14:31AM +0300, Vasiliy Tolstov wrote: > Hi. Does it possible to limit vm cpu speed for example to 1Ghz or 500Mhz ? > I need to simulate some hardware with specific cpu speed and test my > application inside

Re: [libvirt] [RFC] finegrained disk driver options control

2017-03-16 Thread Denis V. Lunev
On 03/16/2017 05:45 PM, Daniel P. Berrange wrote: > On Thu, Mar 16, 2017 at 05:08:57PM +0300, Denis V. Lunev wrote: >> Hello, All! >> >> There is a problem in the current libvirt implementation. domain.xml >> allows to specify only basic set of options, especially in the case >> of QEMU, when there

Re: [libvirt] [GSOC] project libvirt fuzzing

2017-03-16 Thread Daniel P. Berrange
On Tue, Mar 07, 2017 at 12:27:58AM -0500, D L wrote: > On Sun, Mar 5, 2017 at 2:47 AM, Michal Privoznik wrote: > Regarding fuzzing, I think we can try several fuzzing tools to run in > parallel, as different > fuzzers tend to find different kinds of bugs. Thus, AFL (American Fuzz > Lop) [1], > wh

Re: [libvirt] libvirtaio: libvirt-python asyncio event impl

2017-03-16 Thread Wojtek Porczyk
On Thu, Mar 16, 2017 at 04:38:23PM +, Daniel P. Berrange wrote: > On Thu, Mar 16, 2017 at 05:30:40PM +0100, Wojtek Porczyk wrote: > > Hello, libvirt-list, > > > > I wrote an event implementation wrapping an asyncio event loop [1]. > > I would like to contribute it back to libvirt-python, to be

[libvirt] [PATCH v2 4/4] news: Document support for generic PCIe Root Ports

2017-03-16 Thread Andrea Bolognani
--- Changes from v1: * Include model names; * Reword slightly. docs/news.xml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 097a09a..3501f89 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -29,6 +29,16 @@ for QEMUs older than

[libvirt] [PATCH v2 3/4] tests: Test generic PCIe Root Ports

2017-03-16 Thread Andrea Bolognani
We want pcie-root-ports to be used when available in QEMU, but at the same time we need to ensure that hosts running older QEMU releases keep working and that the user can override the default at any time. Add a comment for the original pcie-root-port test cases to make it clear how these new test

[libvirt] [PATCH v2 2/4] qemu: Use generic PCIe Root Ports by default when available

2017-03-16 Thread Andrea Bolognani
ioh3420 is emulated Intel hardware, so it always looked quite out of place in aarch64/virt guests. Even for x86/q35 guests, the recently-introduced pcie-root-port is a better choice because, unlike ioh3420, it doesn't require IO space (a farily constrained resource) to work. If pcie-root-port is a

[libvirt] [PATCH v2 0/4] qemu: Add support for generic PCIe Root Ports

2017-03-16 Thread Andrea Bolognani
Blurby McBlurbface. Andrea Bolognani (4): qemu: Add support for generic PCIe Root Ports qemu: Use generic PCIe Root Ports by default when available tests: Test generic PCIe Root Ports news: Document support for generic PCIe Root Ports docs/news.xml |

[libvirt] [PATCH v2 1/4] qemu: Add support for generic PCIe Root Ports

2017-03-16 Thread Andrea Bolognani
QEMU 2.9 introduces the pcie-root-port device, which is a generic version of the existing ioh3420 device. Make the new device available to libvirt users. --- docs/schemas/domaincommon.rng| 1 + src/conf/domain_conf.c | 4 +++- src/conf/domain_conf.h

Re: [libvirt] [GSOC] project libvirt fuzzing

2017-03-16 Thread Michal Privoznik
On 03/16/2017 09:08 AM, D L wrote: On Tue, Mar 7, 2017 at 4:08 AM, Michal Privoznik wrote: The file has to be stored locally. Libvirt doesn't have an 'url-grabber'. In fact, our APIs expect XML document passed as string (not a filename where it is stored). It's just virsh that allows users t

Re: [libvirt] [RFC] finegrained disk driver options control

2017-03-16 Thread Denis V. Lunev
On 03/16/2017 06:20 PM, Daniel P. Berrange wrote: > On Thu, Mar 16, 2017 at 06:15:27PM +0300, Denis V. Lunev wrote: >> On 03/16/2017 06:08 PM, Daniel P. Berrange wrote: >>> On Thu, Mar 16, 2017 at 06:00:46PM +0300, Denis V. Lunev wrote: On 03/16/2017 05:45 PM, Daniel P. Berrange wrote: > O

Re: [libvirt] [PATCH v2] apparmor: allow /usr/lib/qemu/qemu-bridge-helper

2017-03-16 Thread Daniel P. Berrange
On Thu, Mar 16, 2017 at 05:48:47PM +0100, Guido Günther wrote: > This is where e.g. Debian puts it. > --- > This adds lib64 as Dan suggested and also adds these two dirs to the > second invocations to make things actually work. > > examples/apparmor/usr.sbin.libvirtd | 4 ++-- > 1 file changed, 2

[libvirt] [PATCH v2] apparmor: allow /usr/lib/qemu/qemu-bridge-helper

2017-03-16 Thread Guido Günther
This is where e.g. Debian puts it. --- This adds lib64 as Dan suggested and also adds these two dirs to the second invocations to make things actually work. examples/apparmor/usr.sbin.libvirtd | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/apparmor/usr.sbin.libvi

Re: [libvirt] libvirtaio: libvirt-python asyncio event impl

2017-03-16 Thread Daniel P. Berrange
On Thu, Mar 16, 2017 at 05:30:40PM +0100, Wojtek Porczyk wrote: > Hello, libvirt-list, > > I wrote an event implementation wrapping an asyncio event loop [1]. > I would like to contribute it back to libvirt-python, to be offered > alongside the Default Impl in C. > > [1] https://github.com/woju/l

[libvirt] libvirtaio: libvirt-python asyncio event impl

2017-03-16 Thread Wojtek Porczyk
Hello, libvirt-list, I wrote an event implementation wrapping an asyncio event loop [1]. I would like to contribute it back to libvirt-python, to be offered alongside the Default Impl in C. [1] https://github.com/woju/libvirtaio Also it contains a workaround for a memory leak around the custom l

Re: [libvirt] [RFC] finegrained disk driver options control

2017-03-16 Thread Kevin Wolf
Am 16.03.2017 um 16:52 hat Daniel P. Berrange geschrieben: > On Thu, Mar 16, 2017 at 04:35:36PM +0100, Kevin Wolf wrote: > > Am 16.03.2017 um 16:08 hat Daniel P. Berrange geschrieben: > > > On Thu, Mar 16, 2017 at 06:00:46PM +0300, Denis V. Lunev wrote: > > > > On 03/16/2017 05:45 PM, Daniel P. Ber

Re: [libvirt] [RFC] finegrained disk driver options control

2017-03-16 Thread Denis V. Lunev
On 03/16/2017 06:52 PM, Daniel P. Berrange wrote: > On Thu, Mar 16, 2017 at 04:35:36PM +0100, Kevin Wolf wrote: >> Am 16.03.2017 um 16:08 hat Daniel P. Berrange geschrieben: >>> On Thu, Mar 16, 2017 at 06:00:46PM +0300, Denis V. Lunev wrote: On 03/16/2017 05:45 PM, Daniel P. Berrange wrote: >>

Re: [libvirt] [PATCH] apparmor: allow /usr/lib/qemu/qemu-bridge-helper

2017-03-16 Thread Daniel P. Berrange
On Thu, Mar 16, 2017 at 04:53:28PM +0100, Guido Günther wrote: > This is where e.g. Debian puts it. > --- > examples/apparmor/usr.sbin.libvirtd | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/examples/apparmor/usr.sbin.libvirtd > b/examples/apparmor/usr.sbin.libvirtd > i

[libvirt] [PATCH] apparmor: allow /usr/lib/qemu/qemu-bridge-helper

2017-03-16 Thread Guido Günther
This is where e.g. Debian puts it. --- examples/apparmor/usr.sbin.libvirtd | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/apparmor/usr.sbin.libvirtd b/examples/apparmor/usr.sbin.libvirtd index 8893e75fe..03a80b7e6 100644 --- a/examples/apparmor/usr.sbin.libvirtd +++

Re: [libvirt] [RFC] finegrained disk driver options control

2017-03-16 Thread Daniel P. Berrange
On Thu, Mar 16, 2017 at 04:35:36PM +0100, Kevin Wolf wrote: > Am 16.03.2017 um 16:08 hat Daniel P. Berrange geschrieben: > > On Thu, Mar 16, 2017 at 06:00:46PM +0300, Denis V. Lunev wrote: > > > On 03/16/2017 05:45 PM, Daniel P. Berrange wrote: > > > > On Thu, Mar 16, 2017 at 05:08:57PM +0300, Deni

Re: [libvirt] [Qemu-block] [RFC] finegrained disk driver options control

2017-03-16 Thread Denis V. Lunev
On 03/16/2017 06:29 PM, Alberto Garcia wrote: > On Thu 16 Mar 2017 04:08:50 PM CET, Daniel P. Berrange wrote: >>> OK. How could I change L2 cache size for QCOW2 image? >>> >>> For 1 Tb disk, fragmented in guest, the performance loss is >>> around 10 times. 10 TIMES. 1000%. The customer could not >>

Re: [libvirt] [RFC] finegrained disk driver options control

2017-03-16 Thread Denis V. Lunev
On 03/16/2017 06:35 PM, Kevin Wolf wrote: > Am 16.03.2017 um 16:08 hat Daniel P. Berrange geschrieben: >> On Thu, Mar 16, 2017 at 06:00:46PM +0300, Denis V. Lunev wrote: >>> On 03/16/2017 05:45 PM, Daniel P. Berrange wrote: On Thu, Mar 16, 2017 at 05:08:57PM +0300, Denis V. Lunev wrote: >

Re: [libvirt] libvirt-python bug: custom event loop impl calls ff callback from *Remove(Handle|Timeout)Func

2017-03-16 Thread Wojtek Porczyk
On Fri, Feb 03, 2017 at 02:04:57PM +0100, Martin Kletzander wrote: > Would you mind creating a bug in our bugzilla [1] just so we don't lose > track of this issue? Thank you very much in advance. Sorry for the delay. Here it is: https://bugzilla.redhat.com/show_bug.cgi?id=1433028 -- pozdrawiam

Re: [libvirt] [RFC] finegrained disk driver options control

2017-03-16 Thread Kevin Wolf
Am 16.03.2017 um 16:08 hat Daniel P. Berrange geschrieben: > On Thu, Mar 16, 2017 at 06:00:46PM +0300, Denis V. Lunev wrote: > > On 03/16/2017 05:45 PM, Daniel P. Berrange wrote: > > > On Thu, Mar 16, 2017 at 05:08:57PM +0300, Denis V. Lunev wrote: > > >> Hello, All! > > >> > > >> There is a proble

Re: [libvirt] [Qemu-block] [RFC] finegrained disk driver options control

2017-03-16 Thread Alberto Garcia
On Thu 16 Mar 2017 04:08:50 PM CET, Daniel P. Berrange wrote: >> OK. How could I change L2 cache size for QCOW2 image? >> >> For 1 Tb disk, fragmented in guest, the performance loss is >> around 10 times. 10 TIMES. 1000%. The customer could not >> wait until proper fix in the next QEMU release esp

[libvirt] [PATCH 2/3] qemu: block: Add code to fetch block node data by node name

2017-03-16 Thread Peter Krempa
To allow updating stats based on the node name, add a helper function that will fetch the required data from 'query-named-block-nodes' and return it in hash table for easy lookup. --- src/qemu/qemu_block.c | 46 ++ src/qemu/qemu_block.h | 3 +++ 2 files

[libvirt] [PATCH 0/3] Report block threshold in bulk stats

2017-03-16 Thread Peter Krempa
This is a follow up to: https://www.redhat.com/archives/libvir-list/2017-March/msg00650.html so that management apps can query the current value. The series needs to be applied on top of the block threshold series. For convenience I've pushed it to the same remote repository as the original series

[libvirt] [PATCH 3/3] qemu: stats: Display the block threshold size in bulk stats

2017-03-16 Thread Peter Krempa
Management tools may want to check whether the threshold is still set if they missed an event. Add the data to the bulk stats API where they can also query the current backing size at the same time. --- src/libvirt-domain.c | 4 src/qemu/qemu_driver.c | 51 +

[libvirt] [PATCH 1/3] util: json: Make function to free JSON values in virHash universal

2017-03-16 Thread Peter Krempa
Move the helper that frees JSON entries put into hash tables into the JSON module so that it does not have to be reimplemented. --- src/libvirt_private.syms | 1 + src/qemu/qemu_monitor_json.c | 10 +- src/util/virjson.c | 8 src/util/virjson.h | 1 + 4

Re: [libvirt] [PATCH 3/4] tests: Test generic PCIe Root Ports

2017-03-16 Thread Laine Stump
On 03/16/2017 10:37 AM, Andrea Bolognani wrote: > On Wed, 2017-03-15 at 17:49 -0400, Laine Stump wrote: > [...] >>> @@ -3,7 +3,7 @@ >>> 11dbdcdd-4c3b-482b-8903-9bdb8c0a2774 >>> 2097152 >>> 2097152 >>> - 2 >>> + 2 >> >> You made some other changes to the input XML beyond just the dif

Re: [libvirt] [RFC] finegrained disk driver options control

2017-03-16 Thread Daniel P. Berrange
On Thu, Mar 16, 2017 at 06:15:27PM +0300, Denis V. Lunev wrote: > On 03/16/2017 06:08 PM, Daniel P. Berrange wrote: > > On Thu, Mar 16, 2017 at 06:00:46PM +0300, Denis V. Lunev wrote: > >> On 03/16/2017 05:45 PM, Daniel P. Berrange wrote: > >>> On Thu, Mar 16, 2017 at 05:08:57PM +0300, Denis V. Lun

Re: [libvirt] [PATCH 1/4] qemu: Add support for generic PCIe Root Ports

2017-03-16 Thread Laine Stump
On 03/16/2017 10:18 AM, Andrea Bolognani wrote: > On Wed, 2017-03-15 at 15:18 -0400, Laine Stump wrote: >>> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1408808 >> >> Yes, but kind of no. It makes it available, but still difficult and >> cumbersome to use. I would say it *partially* reso

Re: [libvirt] [RFC] finegrained disk driver options control

2017-03-16 Thread Denis V. Lunev
On 03/16/2017 06:08 PM, Daniel P. Berrange wrote: > On Thu, Mar 16, 2017 at 06:00:46PM +0300, Denis V. Lunev wrote: >> On 03/16/2017 05:45 PM, Daniel P. Berrange wrote: >>> On Thu, Mar 16, 2017 at 05:08:57PM +0300, Denis V. Lunev wrote: Hello, All! There is a problem in the current l

Re: [libvirt] [RFC] finegrained disk driver options control

2017-03-16 Thread Daniel P. Berrange
On Thu, Mar 16, 2017 at 06:00:46PM +0300, Denis V. Lunev wrote: > On 03/16/2017 05:45 PM, Daniel P. Berrange wrote: > > On Thu, Mar 16, 2017 at 05:08:57PM +0300, Denis V. Lunev wrote: > >> Hello, All! > >> > >> There is a problem in the current libvirt implementation. domain.xml > >> allows to spec

Re: [libvirt] [RFC] finegrained disk driver options control

2017-03-16 Thread Denis V. Lunev
On 03/16/2017 05:45 PM, Daniel P. Berrange wrote: > On Thu, Mar 16, 2017 at 05:08:57PM +0300, Denis V. Lunev wrote: >> Hello, All! >> >> There is a problem in the current libvirt implementation. domain.xml >> allows to specify only basic set of options, especially in the case >> of QEMU, when there

Re: [libvirt] [RFC] finegrained disk driver options control

2017-03-16 Thread Daniel P. Berrange
On Thu, Mar 16, 2017 at 05:08:57PM +0300, Denis V. Lunev wrote: > Hello, All! > > There is a problem in the current libvirt implementation. domain.xml > allows to specify only basic set of options, especially in the case > of QEMU, when there are really a lot of tweaks in format drivers. > Most li

Re: [libvirt] [PATCH 4/4] news: Document support for generic PCIe Root Ports

2017-03-16 Thread Andrea Bolognani
On Wed, 2017-03-15 at 17:57 -0400, Laine Stump wrote: [...] > > @@ -17,6 +17,15 @@ > >The virt-host-validate tool now supports bhyve hypervisor > >   > > > > +   > > + > > +  qemu: Introduce support for generic PCIe Root Ports > > + > > + 

Re: [libvirt] [RFC PATCH v2 REBASE 00/18] Introduce vGPU mdev framework to libvirt

2017-03-16 Thread Erik Skultety
> [2] 2005 > ubuntu@z-nuc-11:~/vgpu-meta/libvirt-stage$ > *** > start libvirt-d > 2017-03-09 19:04:57.211+: 2059: info : libvirt version: 3.1.0 > 2017-03-09 19:04:57.211+: 2059: info : hostname: z-nuc-11.maas > 2017-03-09 19:04:57.211+: 20

Re: [libvirt] [PATCH 3/4] tests: Test generic PCIe Root Ports

2017-03-16 Thread Andrea Bolognani
On Wed, 2017-03-15 at 17:49 -0400, Laine Stump wrote: [...] > > @@ -3,7 +3,7 @@ > >11dbdcdd-4c3b-482b-8903-9bdb8c0a2774 > >2097152 > >2097152 > > -  2 > > +  2 >  > You made some other changes to the input XML beyond just the differences > in root ports. Mostly they're innocuous and eas

Re: [libvirt] [PATCH 2/4] qemu: Use generic PCIe Root Ports by default for aarch64/virt

2017-03-16 Thread Andrea Bolognani
On Wed, 2017-03-15 at 15:22 -0400, Laine Stump wrote: > > It was mentioned somewhere, at some point, that we might > > want to switch to generic PCIe Root Ports for x86/q35 > > guests as well. > >  > > It sounds like a good idea to me, and in fact QEMU's sample > > configuration files for x86/q35 (

Re: [libvirt] [PATCH 1/4] qemu: Add support for generic PCIe Root Ports

2017-03-16 Thread Andrea Bolognani
On Wed, 2017-03-15 at 15:18 -0400, Laine Stump wrote: > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1408808 >  > Yes, but kind of no. It makes it available, but still difficult and > cumbersome to use. I would say it *partially* resolves that BZ, with > full resolution coming from the f

[libvirt] [RFC] finegrained disk driver options control

2017-03-16 Thread Denis V. Lunev
Hello, All! There is a problem in the current libvirt implementation. domain.xml allows to specify only basic set of options, especially in the case of QEMU, when there are really a lot of tweaks in format drivers. Most likely these options will never be supported in a good way in libvirt as recog

Re: [libvirt] [RFC PATCH v2 REBASE 00/18] Introduce vGPU mdev framework to libvirt

2017-03-16 Thread Laine Stump
On 03/16/2017 03:17 AM, Chen, Xiaoguang wrote: > the screen call trace while start the VM (same for Ubuntu, Win10 etc) > == > > ubuntu@z-nuc-11:~/vgpu-meta/libvirt-stage$ myvirsh start vgpu-ubuntu > 2017-03-09 19:06:50.483+: 2232: info : lib

[libvirt] [REPOST PATCH 4/4] conf: Use consistent function name prefixes for virstorageobj

2017-03-16 Thread John Ferlan
Use "virStoragePoolObj" as a prefix for any external API in virstorageobj. Also a couple of functions were local to virstorageobj.c, so remove their external defs iin virstorageobj.h. NB: The virStorageVolDef* API's won't change. Signed-off-by: John Ferlan --- src/conf/virstorageobj.c | 29

[libvirt] [REPOST PATCH 3/4] conf: Alter coding style of storage conf function prototypes

2017-03-16 Thread John Ferlan
In an effort to be consistent with the source module, alter the function prototypes to follow the similar style of source with the "type" on one line followed by the function name and arguments on subsequent lines with with argument getting it's own line. Signed-off-by: John Ferlan --- src/conf/

[libvirt] [REPOST PATCH 0/4] Split out storage object into its own module

2017-03-16 Thread John Ferlan
Repost after merging with latest changes of: http://www.redhat.com/archives/libvir-list/2017-March/msg00305.html Continuing down the pile of drivers from my RFC for making a common pool object - we're now at storage... For reference see patch 3 of: http://www.redhat.com/archives/libvir-list/2017

[libvirt] [REPOST PATCH 2/4] conf: Adjust coding style for storage conf sources

2017-03-16 Thread John Ferlan
Alter the format of the code to follow more recent style guidelines of two empty lines between functions, function decls with "[static] type" on one line followed by function name with arguments to functions each on one line. Signed-off-by: John Ferlan --- src/conf/storage_conf.c | 31 +

[libvirt] [REPOST PATCH 1/4] conf: Introduce virstorageobj

2017-03-16 Thread John Ferlan
Move all the StoragePoolObj related API's into their own module virstorageobj from the storage_conf Purely code motion at this point, plus adjustments to cleanly build Signed-off-by: John Ferlan --- po/POTFILES.in| 1 + src/Makefile.am | 3 +- src/conf/storage_

Re: [libvirt] [PATCH v3 14/15] docs: Document the new hostdev and address type 'mdev'

2017-03-16 Thread Erik Skultety
On Thu, Mar 16, 2017 at 12:28:34PM +, Daniel P. Berrange wrote: > On Thu, Mar 16, 2017 at 01:21:18PM +0100, Erik Skultety wrote: > > Signed-off-by: Erik Skultety > > --- > > docs/formatdomain.html.in | 46 > > -- > > 1 file changed, 40 insertions(+

Re: [libvirt] [PATCH v3 14/15] docs: Document the new hostdev and address type 'mdev'

2017-03-16 Thread Daniel P. Berrange
On Thu, Mar 16, 2017 at 01:21:18PM +0100, Erik Skultety wrote: > Signed-off-by: Erik Skultety > --- > docs/formatdomain.html.in | 46 -- > 1 file changed, 40 insertions(+), 6 deletions(-) We need some docs somewhere decsribing how to use the virNodeDev

[libvirt] [PATCH v3 02/15] conf: hostdev: Introduce virDomainHostdevSubsysSCSIClear

2017-03-16 Thread Erik Skultety
Just a tiny wrapper over the SCSI def clearing logic to drop some if-else branches from a switch, mainly because extending the switch in the future would render the current code with branching less readable. Signed-off-by: Erik Skultety --- src/conf/domain_conf.c | 33 ++-

[libvirt] [PATCH v3 13/15] test: Add some test cases for our test suite regarding the mdevs

2017-03-16 Thread Erik Skultety
For now, these only cover the unmanaged, i.e. user pre-created devices. Signed-off-by: Erik Skultety --- ...ml2argv-hostdev-mdev-invalid-target-address.xml | 33 ++ ...muxml2argv-hostdev-mdev-src-address-invalid.xml | 35 +++ .../qemuxml2argv-hostdev-mdev-unmanage

[libvirt] [PATCH v3 12/15] qemu: Format mdevs on qemu command line

2017-03-16 Thread Erik Skultety
Format the mediated devices on the qemu command line as -device vfio-pci,sysfsdev='/path/to/device/in/syfs'. Signed-off-by: Erik Skultety --- src/qemu/qemu_command.c | 45 + src/qemu/qemu_command.h | 5 + 2 files changed, 50 insertions(+) diff --

[libvirt] [PATCH v3 14/15] docs: Document the new hostdev and address type 'mdev'

2017-03-16 Thread Erik Skultety
Signed-off-by: Erik Skultety --- docs/formatdomain.html.in | 46 -- 1 file changed, 40 insertions(+), 6 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index da0ae4aeba..3aa3ccc53a 100644 --- a/docs/formatdomain.html.in

[libvirt] [PATCH v3 03/15] conf: Introduce virDomainHostdevDefPostParse

2017-03-16 Thread Erik Skultety
Just to make the code a bit cleaner, move hostdev specific post parse code to its own function just in case it grows in the future. Signed-off-by: Erik Skultety --- src/conf/domain_conf.c | 75 +++--- 1 file changed, 47 insertions(+), 28 deletions(-)

[libvirt] [PATCH v3 00/15] Introduce vGPU mdev framework to libvirt

2017-03-16 Thread Erik Skultety
since v1: - new attribute model introduced which tells libvirt which device API should be considered when auto-assigning guest address - device_api is properly checked, thus taking the 'model' attribute only as a hint to assign "some" address - new address type 'mdev' is introduced rather than usi

[libvirt] [PATCH v3 08/15] qemu: Assign PCI addresses for mediated devices as well

2017-03-16 Thread Erik Skultety
So far, the official support is for x86_64 arch guests so unless a different device API than vfio-pci is available let's only turn on support for PCI address assignment. Once a different device API is introduced, we can enable another address type easily. Signed-off-by: Erik Skultety --- src/qem

[libvirt] [PATCH v3 06/15] security: Enable labeling of vfio mediated devices

2017-03-16 Thread Erik Skultety
Label the VFIO IOMMU devices under /dev/vfio/ referenced by the symlinks in the sysfs (e.g. /sys/class/mdev_bus//iommu_group) which what qemu actually gets formatted on the command line. This patch updates all of our security drivers. Signed-off-by: Erik Skultety --- src/security/security_apparm

[libvirt] [PATCH v3 15/15] news: Update the NEWS.xml about the new mdev feature

2017-03-16 Thread Erik Skultety
Signed-off-by: Erik Skultety --- docs/news.xml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 097a09a5b3..345e139c0c 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -29,6 +29,16 @@ for QEMUs older than 2.9.0. +

[libvirt] [PATCH v3 09/15] hostdev: Maintain a driver list of active mediated devices

2017-03-16 Thread Erik Skultety
Keep track of the assigned mediated devices the same way we do it for the rest of hostdevs. Methods like 'Prepare', 'Update', and 'ReAttach' are introduced by this patch. Signed-off-by: Erik Skultety --- src/libvirt_private.syms | 3 + src/qemu/qemu_hostdev.c | 56 src/qemu/

[libvirt] [PATCH v3 11/15] qemu: Bump the memory locking limit for mdevs as well

2017-03-16 Thread Erik Skultety
Since mdevs are just another type of VFIO devices, we should increase the memory locking limit the same way we do for VFIO PCI devices. Signed-off-by: Erik Skultety --- src/qemu/qemu_domain.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_domain.c b/sr

[libvirt] [PATCH v3 10/15] qemu: cgroup: Adjust cgroups' logic to allow mediated devices

2017-03-16 Thread Erik Skultety
As goes for all the other hostdev device types, grant the qemu process access to /dev/vfio/. Signed-off-by: Erik Skultety --- src/qemu/qemu_domain.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 11157184b7..da59652dc0 10

[libvirt] [PATCH v3 07/15] conf: Enable cold-plug of a mediated device

2017-03-16 Thread Erik Skultety
This merely introduces virDomainHostdevMatchSubsysMediatedDev method that is supposed to check whether device being cold-plugged does not already exist in the domain configuration. Signed-off-by: Erik Skultety --- src/conf/domain_conf.c | 14 ++ 1 file changed, 14 insertions(+) diff

[libvirt] [PATCH v3 05/15] conf: Add post parse code for mdevs to virDomainHostdevDefPostParse

2017-03-16 Thread Erik Skultety
We need to make sure that if user explicitly provides a guest address for a mdev device, the address type will be matching the device API supported on that specific mediated device and error out with an incorrect XML message. Signed-off-by: Erik Skultety --- src/conf/domain_conf.c | 17 +

[libvirt] [PATCH v3 01/15] conf: hostdev: Enforce enum-in-switch compile-time checks

2017-03-16 Thread Erik Skultety
Enforce virDomainHostdevSubsysType checking during compilation. Again, one of a few spots in our code where we should enforce the typecast to the enum type, thus not forgetting to update *all* switch occurrences dealing with the give enum. Signed-off-by: Erik Skultety --- src/conf/domain_conf.c

[libvirt] [PATCH v3 04/15] conf: Introduce new hostdev device type mdev

2017-03-16 Thread Erik Skultety
A mediated device will be identified by a UUID (with 'model' now being a mandatory attribute to represent the mediated device API) of the user pre-created mediated device. The data necessary to identify a mediated device can be easily extended in the future, e.g. when auto-creation of mediated dev

[libvirt] [PATCH] perf: remote: Compare perf nparams against the correct constant

2017-03-16 Thread Nitesh Konkar
Currently 'virsh perf domain' errors out as the perf nparams is incorrectly compared against REMOTE_DOMAIN_MEMORY_PARAMETERS_MAX instead of REMOTE_DOMAIN_PERF_EVENTS_MAX. Signed-off-by: Nitesh Konkar --- daemon/remote.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/daemon/r

[libvirt] [PATCH v2] qemu: skip QMP probing of CPU definitions when missing

2017-03-16 Thread Guido Günther
This unbreaks emulators that don't support this command such as qemu-system-mips*. Reference: http://bugs.debian.org/854125 --- src/qemu/qemu_capabilities.c| 5 + src/qemu/qemu_capabilities.h| 1 + tests/qemucapabilitiesdata/caps_1.2.2.x

Re: [libvirt] [PATCH] qemucapstest: Update test data for QEMU 2.9.0

2017-03-16 Thread Peter Krempa
On Thu, Mar 16, 2017 at 10:57:49 +0100, Michal Privoznik wrote: > Signed-off-by: Michal Privoznik > --- > .../qemucapabilitiesdata/caps_2.9.0.x86_64.replies | 3254 > +++- > tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml | 11 +- > 2 files changed, 1806 insertions(+), 1459

Re: [libvirt] [PATCH] docs: Document NVDIMM

2017-03-16 Thread Martin Kletzander
On Thu, Mar 16, 2017 at 11:17:15AM +0100, Michal Privoznik wrote: Signed-off-by: Michal Privoznik --- docs/news.xml | 12 1 file changed, 12 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 3500df714..59e954f88 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -17,6 +1

Re: [libvirt] [PATCH] Report what TLS priority string we use for a session

2017-03-16 Thread Daniel P. Berrange
On Thu, Mar 16, 2017 at 11:30:16AM +0100, Michal Privoznik wrote: > On 03/15/2017 07:05 PM, Daniel P. Berrange wrote: > > Signed-off-by: Daniel P. Berrange > > --- > > src/rpc/virnettlscontext.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/src/rpc/virnettlscontext.c b/src/rpc/v

Re: [libvirt] [PATCH] remote: Make Upper limit on list of memory parameters to 64

2017-03-16 Thread Daniel P. Berrange
On Thu, Mar 16, 2017 at 04:23:51PM +0530, Nitesh Konkar wrote: > 'virsh perf domain' errors out as the number of perf > events now exceeds the previous memory parameter limit > of 16. The fix is to set it to 64, as the upper limit > on list of perf events, is also set to the same. This makes no s

[libvirt] [PATCH] remote: Make Upper limit on list of memory parameters to 64

2017-03-16 Thread Nitesh Konkar
'virsh perf domain' errors out as the number of perf events now exceeds the previous memory parameter limit of 16. The fix is to set it to 64, as the upper limit on list of perf events, is also set to the same. Signed-off-by: Nitesh Konkar --- src/remote/remote_protocol.x | 2 +- 1 file changed

Re: [libvirt] [PATCH] Increase default file handle limits for daemons

2017-03-16 Thread Daniel P. Berrange
On Wed, Mar 15, 2017 at 07:34:04PM +0100, Guido Günther wrote: > Hi, > On Wed, Mar 15, 2017 at 04:55:04PM +, Daniel P. Berrange wrote: > > Linux still defaults to a 1024 open file handle limit. This causes > > scalability problems for libvirtd / virtlockd / virtlogd on large > > hosts which mig

Re: [libvirt] [PATCH] Report what TLS priority string we use for a session

2017-03-16 Thread Michal Privoznik
On 03/15/2017 07:05 PM, Daniel P. Berrange wrote: > Signed-off-by: Daniel P. Berrange > --- > src/rpc/virnettlscontext.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/rpc/virnettlscontext.c b/src/rpc/virnettlscontext.c > index 847d457..0d5928e 100644 > --- a/src/rpc/virnettlsconte

Re: [libvirt] limit cpu speed in domain xml

2017-03-16 Thread Daniel P. Berrange
On Thu, Mar 16, 2017 at 12:14:31AM +0300, Vasiliy Tolstov wrote: > Hi. Does it possible to limit vm cpu speed for example to 1Ghz or 500Mhz ? > I need to simulate some hardware with specific cpu speed and test my > application inside this vm , i want to measure results from each test > and need con

[libvirt] [PATCH] docs: Document NVDIMM

2017-03-16 Thread Michal Privoznik
Signed-off-by: Michal Privoznik --- docs/news.xml | 12 1 file changed, 12 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 3500df714..59e954f88 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -17,6 +17,18 @@ The virt-host-validate tool now supports bhyve

Re: [libvirt] [BUG] mlock support breakage

2017-03-16 Thread Luiz Capitulino
On Wed, 15 Mar 2017 08:59:34 +0100 Jiri Denemark wrote: > On Tue, Mar 14, 2017 at 15:54:25 -0400, Luiz Capitulino wrote: > > On Tue, 14 Mar 2017 20:28:12 +0100 > > Andrea Bolognani wrote: > > > > > On Tue, 2017-03-14 at 14:54 -0400, Luiz Capitulino wrote: > > > > > It's unfortunate that the

[libvirt] [PATCH] qemucapstest: Update test data for QEMU 2.9.0

2017-03-16 Thread Michal Privoznik
Signed-off-by: Michal Privoznik --- .../qemucapabilitiesdata/caps_2.9.0.x86_64.replies | 3254 +++- tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml | 11 +- 2 files changed, 1806 insertions(+), 1459 deletions(-) diff --git a/tests/qemucapabilitiesdata/caps_2.9.0.x86_64.repli

Re: [libvirt] [PATCH] libxl: fix typo in debug message

2017-03-16 Thread Guido Günther
On Thu, Mar 16, 2017 at 09:42:02AM +0100, Martin Kletzander wrote: > On Thu, Mar 16, 2017 at 08:40:04AM +0100, Guido Günther wrote: > > --- > > src/libxl/libxl_migration.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > ACK, trivial Pushed. Thanks. -- Guido > > > diff --git a

Re: [libvirt] [PATCH 2/2] qemu: Adaptive timeout for connecting to monitor

2017-03-16 Thread Michal Privoznik
On 03/15/2017 03:28 PM, Jim Fehlig wrote: > Michal Privoznik wrote: >> On 03/15/2017 02:16 AM, Jim Fehlig wrote: >>> On 03/13/2017 06:29 AM, Michal Privoznik wrote: There were couple of reports on the list (e.g. [1]) that guests with huge amounts of RAM are unable to start because libvirt

Re: [libvirt] [PATCH] qemu: allow QMP probing of CPU definitions to fail

2017-03-16 Thread Jiri Denemark
On Thu, Mar 16, 2017 at 09:41:42 +0100, Guido Günther wrote: > This unbreaks emulators that don't support this command such as > qemu-system-mips*. > > Reference: http://bugs.debian.org/854125 > --- > src/qemu/qemu_capabilities.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -

Re: [libvirt] [PATCH] libxl: fix typo in debug message

2017-03-16 Thread Martin Kletzander
On Thu, Mar 16, 2017 at 08:40:04AM +0100, Guido Günther wrote: --- src/libxl/libxl_migration.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ACK, trivial diff --git a/src/libxl/libxl_migration.c b/src/libxl/libxl_migration.c index fb833d1a3..6b5b981f1 100644 --- a/src/libxl/libxl_migr

  1   2   >