Decorate unused arguments of the virNetDevGetMaster() stub
with ATTRIBUTE_UNUSED to fix build on systems where this
stub is used.
---
Pushed as a build-breaker.
src/util/virnetdev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c
i
On 03/22/2017 12:26 PM, Jiri Denemark wrote:
> On Fri, Mar 17, 2017 at 14:39:01 -0400, John Ferlan wrote:
>> https://bugzilla.redhat.com/show_bug.cgi?id=1300769
>>
>> If the migration flags indicate this migration will be using TLS,
>> then while we have connection in the Begin phase check and se
On 03/22/2017 12:26 PM, Jiri Denemark wrote:
> On Fri, Mar 17, 2017 at 14:39:00 -0400, John Ferlan wrote:
>> If the migration flags indicate this migration will be using TLS,
>> then set up the destination during the prepare phase once the target
>> domain has been started to add the TLS objects
On 03/22/2017 08:08 PM, Eric Blake wrote:
> On 03/15/2017 11:37 AM, Peter Krempa wrote:
>> The event is fired when a given block backend node (identified by the
>> node name) experiences a write beyond the bound set via
>> block-set-write-threshold QMP command. This wires up the monitor code to
>>
On 03/15/2017 11:37 AM, Peter Krempa wrote:
> Bind it to qemus BLOCK_WRITE_THRESHOLD event. Look up the disk by
s/qemus/qemu's/
> nodename and construct the string to return.
> ---
> src/qemu/qemu_process.c | 40
> 1 file changed, 40 insertions(+)
>
>
On 03/15/2017 11:37 AM, Peter Krempa wrote:
> The code is currently simple, but if we later add node names, it will be
> necessary to generate the names based on the node name. Add a helper so
> that there's a central point to fix once we add self-generated node
> names.
We'll get there soon enoug
On 03/15/2017 11:37 AM, Peter Krempa wrote:
> Looks up a disk and it's corresponding backing chain element by node
s/it's/its/ (remember, "it's" is only appropriate if "it is" or "it
has" can be used in its place)
> name.
> ---
> src/qemu/qemu_domain.c | 43 +
On 03/15/2017 11:37 AM, Peter Krempa wrote:
> The event is fired when a given block backend node (identified by the
> node name) experiences a write beyond the bound set via
> block-set-write-threshold QMP command. This wires up the monitor code to
> extract the data and allow us receiving the even
On 03/15/2017 11:37 AM, Peter Krempa wrote:
> When using thin provisioning, management tools need to resize the disk
> in certain cases. To avoid having them to poll disk usage introduce an
> event which will be fired when a given offset of the storage is written
> by the hypervisor. Together with
On 03/15/2017 11:37 AM, Peter Krempa wrote:
> 'nodeformat' should be used for strings which describe the storage
> format object, and 'nodebacking' for the actual storage object itself.
> ---
> src/libvirt_private.syms | 1 +
> src/util/virstoragefile.c | 40 +
On 03/22/2017 12:26 PM, Jiri Denemark wrote:
> On Fri, Mar 17, 2017 at 14:38:58 -0400, John Ferlan wrote:
>> Add the fields to support setting tls-creds and tls-hostname during
>> a migration (either source or target). Modify the query migration
>> function to check for the presence and set the f
On 03/15/2017 11:37 AM, Peter Krempa wrote:
> The function has very specific semantics. Split out the part that parses
> the backing store specification string into a separate helper so that it
> can be reused later while keeping the wrapper with existing semantics.
>
> Note that virStorageFilePar
On 03/15/2017 11:37 AM, Peter Krempa wrote:
> It will be useful to set indentation level to 0 after formatting a
> nested structure rather than having to track the depth.
> ---
> src/libvirt_private.syms | 1 +
> src/util/virbuffer.c | 19 +++
> src/util/virbuffer.h | 2 +
On 03/15/2017 11:37 AM, Peter Krempa wrote:
> Our code calls it when starting or re-starting the domain or when
> hotplugging the disk so there's nothing to be detected.
> ---
> src/qemu/qemu_driver.c | 5 -
> 1 file changed, 5 deletions(-)
>
I think I added it here because block jobs have t
On 03/22/2017 12:26 PM, Jiri Denemark wrote:
> On Fri, Mar 17, 2017 at 14:38:56 -0400, John Ferlan wrote:
>> Add a new TLS X.509 certificate type - "migrate". This will handle the
>> creation of a TLS certificate capability (and possibly repository) to
>> be used for migrations. Similar to charde
On Fri, Mar 17, 2017 at 14:39:01 -0400, John Ferlan wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1300769
>
> If the migration flags indicate this migration will be using TLS,
> then while we have connection in the Begin phase check and setup the
> TLS environment that will be used by virMi
On Sat, Mar 18, 2017 at 09:47:04 -0400, John Ferlan wrote:
> Signed-off-by: John Ferlan
> ---
> docs/news.xml | 10 ++
> 1 file changed, 10 insertions(+)
>
> diff --git a/docs/news.xml b/docs/news.xml
> index 3501f89..25d920c 100644
> --- a/docs/news.xml
> +++ b/docs/news.xml
> @@ -39,6
On Fri, Mar 17, 2017 at 14:39:00 -0400, John Ferlan wrote:
> If the migration flags indicate this migration will be using TLS,
> then set up the destination during the prepare phase once the target
> domain has been started to add the TLS objects to perform the migration.
>
> This will create at l
On Fri, Mar 17, 2017 at 14:38:57 -0400, John Ferlan wrote:
> Signed-off-by: John Ferlan
> ---
> include/libvirt/libvirt-domain.h | 8
> src/qemu/qemu_migration.h| 3 ++-
> tools/virsh-domain.c | 7 +++
> 3 files changed, 17 insertions(+), 1 deletion(-)
ACK
Jirka
On Fri, Mar 17, 2017 at 14:38:56 -0400, John Ferlan wrote:
> Add a new TLS X.509 certificate type - "migrate". This will handle the
> creation of a TLS certificate capability (and possibly repository) to
> be used for migrations. Similar to chardev's, credentials will be handled
> via a libvirt sec
On Fri, Mar 17, 2017 at 14:38:58 -0400, John Ferlan wrote:
> Add the fields to support setting tls-creds and tls-hostname during
> a migration (either source or target). Modify the query migration
> function to check for the presence and set the field for future
> consumers to determine which of 3
On Fri, Mar 17, 2017 at 14:38:59 -0400, John Ferlan wrote:
> Add an asyncJob argument for add/delete TLS Objects. A future patch will
> add/delete TLS objects from a migration which may hae a job to join.
s/hae/have/ I guess.
>
> Signed-off-by: John Ferlan
> ---
> src/qemu/qemu_hotplug.c | 24
On Fri, Mar 17, 2017 at 14:38:55 -0400, John Ferlan wrote:
> Create GET_CONFIG_TLS_CERT to set up the TLS for 'chardev' TLS setting.
> Soon to be reused.
>
> Signed-off-by: John Ferlan
> ---
> src/qemu/qemu_conf.c | 39 +--
> 1 file changed, 25 insertions(+),
On 03/22/17 16:38, Laszlo Ersek wrote:
> On 03/22/17 16:28, Peter Krempa wrote:
>> QEMU does not snapshot the pflash drive when doing a 'savevm' thus
>> internal snapshots with OVMF would be incomplete.
>
> Can you please explain it in a bit more detail:
>
> - the above statement is true as long
On 03/22/17 16:28, Peter Krempa wrote:
> QEMU does not snapshot the pflash drive when doing a 'savevm' thus
> internal snapshots with OVMF would be incomplete.
Can you please explain it in a bit more detail:
- the above statement is true as long as we use "raw" for the varstore.
- it would not be
On 03/21/2017 04:03 PM, Laine Stump wrote:
It's been a long-standing problem that when you stop and restart a
libvirt network, the guest tap devices are no longer connected to the
network. Until now the only way to recover from this was to either
shutdown and restart all the affected guests, or t
Signed-off-by: Erik Skultety
---
docs/formatdomain.html.in | 46 --
1 file changed, 40 insertions(+), 6 deletions(-)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index 4a3123e989..1eb6c44b6f 100644
--- a/docs/formatdomain.html.in
Enforce virDomainHostdevSubsysType checking during compilation. Again,
one of a few spots in our code where we should enforce the typecast to
the enum type, thus not forgetting to update *all* switch occurrences
dealing with the give enum.
Signed-off-by: Erik Skultety
---
src/conf/domain_conf.c
Beside creation, disposal, getter, and setter methods the module exports
methods to work with lists of mediated devices.
Signed-off-by: Erik Skultety
---
po/POTFILES.in | 1 +
src/Makefile.am | 1 +
src/libvirt_private.syms | 22 +++
src/util/virmdev.c | 487 +++
Format the mediated devices on the qemu command line as
-device vfio-pci,sysfsdev='/path/to/device/in/syfs'.
Signed-off-by: Erik Skultety
---
src/qemu/qemu_command.c | 45 +
src/qemu/qemu_command.h | 5 +
2 files changed, 50 insertions(+)
diff --
Just to make the code a bit cleaner, move hostdev specific post parse
code to its own function just in case it grows in the future.
Signed-off-by: Erik Skultety
---
src/conf/domain_conf.c | 75 +++---
1 file changed, 47 insertions(+), 28 deletions(-)
QEMU does not snapshot the pflash drive when doing a 'savevm' thus
internal snapshots with OVMF would be incomplete.
Forbid such snapshot so that we can avoid problems.
---
CC: ler...@redhat.com
There might be slight regression potential. While this did not work as expected
I did not encounter an
Since mdevs are just another type of VFIO devices, we should increase
the memory locking limit the same way we do for VFIO PCI devices.
Signed-off-by: Erik Skultety
---
src/qemu/qemu_domain.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/sr
For now, these only cover the unmanaged, i.e. user pre-created devices.
Signed-off-by: Erik Skultety
---
...ml2argv-hostdev-mdev-invalid-target-address.xml | 33 ++
...muxml2argv-hostdev-mdev-src-address-invalid.xml | 35 +++
.../qemuxml2argv-hostdev-mdev-unmanage
A mediated device will be identified by a UUID (with 'model' now being
a mandatory attribute to represent the mediated device API) of
the user pre-created mediated device. The data necessary to identify a
mediated device can be easily extended in the future, e.g. when
auto-creation of mediated dev
This merely introduces virDomainHostdevMatchSubsysMediatedDev method that
is supposed to check whether device being cold-plugged does not already
exist in the domain configuration.
Signed-off-by: Erik Skultety
---
src/conf/domain_conf.c | 14 ++
1 file changed, 14 insertions(+)
diff
Label the VFIO IOMMU devices under /dev/vfio/ referenced by the symlinks
in the sysfs (e.g. /sys/class/mdev_bus//iommu_group) which what
qemu actually gets formatted on the command line. This patch updates all
of our security drivers.
Signed-off-by: Erik Skultety
---
src/security/security_apparm
As goes for all the other hostdev device types, grant the qemu process
access to /dev/vfio/.
Signed-off-by: Erik Skultety
---
src/qemu/qemu_domain.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index c0f060b0a3..d1ac1d641b 10
So far, the official support is for x86_64 arch guests so unless a
different device API than vfio-pci is available let's only turn on
support for PCI address assignment. Once a different device API is
introduced, we can enable another address type easily.
Signed-off-by: Erik Skultety
---
src/qem
Keep track of the assigned mediated devices the same way we do it for
the rest of hostdevs. Methods like 'Prepare', 'Update', and 'ReAttach'
are introduced by this patch.
Signed-off-by: Erik Skultety
---
src/libvirt_private.syms | 3 +
src/qemu/qemu_hostdev.c | 56
src/qemu/
Just a tiny wrapper over the SCSI def clearing logic to drop some
if-else branches from a switch, mainly because extending the switch in
the future would render the current code with branching less readable.
Signed-off-by: Erik Skultety
---
src/conf/domain_conf.c | 33 ++-
since v1:
- new attribute model introduced which tells libvirt which device API
should be considered when auto-assigning guest address
- device_api is properly checked, thus taking the 'model' attribute only as a
hint to assign "some" address
- new address type 'mdev' is introduced rather than usi
On Wed, Mar 22, 2017 at 10:21:13AM -0400, John Ferlan wrote:
Hopefully the quantity doesn't scare anyone off... These are mostly
innocuous, but separated each out to appease the masses.
The first patch fixes a recently uncovered Coverity warning regarding
FORWARD_NULL of the 'formatStr'... Accor
On Wed, Mar 22, 2017 at 4:04 AM, Michal Privoznik
wrote:
> On 03/21/2017 07:04 PM, D L wrote:
> > Yes, I compiled, installed, and used the binaries successfully.
> > Could you confirm the location of bug list is the following, please?
> >
> > https://bugzilla.redhat.com/buglist.cgi?component=libv
On 03/21/2017 04:23 PM, Laine Stump wrote:
The exact family of the socket created for the fd used by ioctl(7)
doesn't matter, it just needs to be a socket and not a file. But for
some reason when macvtap support was added, it used
AF_PACKET/SOCK_DGRAM sockets for its ioctls; we later used the sam
On 03/21/2017 04:23 PM, Laine Stump wrote:
I found these while trying out some other code I decided not to use (I
was going to add more attributes to the element,
virNetDevIfLink, and virNetDevGetLinkInfo(), but then decided not to
for now (in case Michal has a different idea of the meaning of "
On Wed, Mar 22, 2017 at 10:21:18 -0400, John Ferlan wrote:
> Since the code checks and handles a NULL 'numa' parameter, remove the NONNULL
> from the prototype.
>
> Signed-off-by: John Ferlan
> ---
> src/conf/numa_conf.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
ACK
signatur
On Wed, Mar 22, 2017 at 10:21:14 -0400, John Ferlan wrote:
> The qemuDomainSnapshotPrepare should always set a > 0 format value anyway,
> so remove the check.
>
> Found by Coverity.
>
> Signed-off-by: John Ferlan
> ---
> src/qemu/qemu_driver.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deleti
On Wed, Mar 22, 2017 at 03:23:58PM +0100, Pavel Hrdina wrote:
> On Thu, Mar 16, 2017 at 01:21:08PM +0100, Erik Skultety wrote:
> > A mediated device will be identified by a UUID (with 'model' now being
> > a mandatory attribute to represent the mediated device API) of
> > the user pre-created medi
https://bugzilla.redhat.com/show_bug.cgi?id=1434882
Imagine the following scenario:
1) virsh net-start default
2) virsh start myFavouriteDomain
3) virsh net-destroy default
4) virsh destroy myFavouriteDomain
(assuming myFavouriteDomain has an interface from default
network)
Regardless of how un
The first is an improvement, the second is actually a bug fix.
Michal Privoznik (2):
networkUpdateState: Create virMacMap module more frequently
network: Don't crash on domain destroy
src/network/bridge_driver.c | 24 +++-
1 file changed, 11 insertions(+), 13 deletions(-)
The virMacMap module is there for dumping [domain, ] pairs into a file so that libvirt_guest NSS module can use
it. Whenever a interface is allocated from network (e.g. on
domani startup or NIC hotplug), network is notified and so is
virMacMap module subsequently. The module update functions
networ
On Thu, Mar 16, 2017 at 01:21:08PM +0100, Erik Skultety wrote:
> A mediated device will be identified by a UUID (with 'model' now being
> a mandatory attribute to represent the mediated device API) of
> the user pre-created mediated device. The data necessary to identify a
> mediated device can be
On Thu, Mar 16, 2017 at 01:21:09PM +0100, Erik Skultety wrote:
> We need to make sure that if user explicitly provides a guest address
> for a mdev device, the address type will be matching the device API
> supported on that specific mediated device and error out with an
> incorrect XML message.
>
Since the function handles a NULL 'mgr' condition, no need for the NONNULL
Signed-off-by: John Ferlan
---
src/util/virhostdev.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/util/virhostdev.h b/src/util/virhostdev.h
index 7ee0b43..45d1c2e 100644
--- a/src/util/virhostde
Since the code checks and handles a NULL 'net_bandwidth' parameter,
so no need for NONNNULL.
Signed-off-by: John Ferlan
---
src/util/virnetdevbandwidth.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/util/virnetdevbandwidth.h b/src/util/virnetdevbandwidth.h
index bcea
Since the code checks and handles a NULL 'cpus' anyway, so no need
for the NONNULL.
Signed-off-by: John Ferlan
---
src/cpu/cpu.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/cpu/cpu.h b/src/cpu/cpu.h
index 7d6d3e9..d23409a 100644
--- a/src/cpu/cpu.h
+++ b/src/cpu/cpu
The comparison code used STREQ_NULLABLE anyway for both 'drv_name' and
'dom_name', so no need. Add a NULLSTR on the 'dom_name' too.
Signed-off-by: John Ferlan
---
src/util/virhostdev.c | 2 +-
src/util/virhostdev.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/util/v
Since the source code checks 'ifname' for NULL before using, the prototype
doesn't need the NONNULL
Signed-off-by: John Ferlan
---
src/util/virnetdevmacvlan.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/util/virnetdevmacvlan.h b/src/util/virnetdevmacvlan.h
index 9a85a
The 'mon' argument validity is checked in the QEMU_CHECK_MONITOR for the
following functions, so they don't need the NONNULL on their prototype:
qemuMonitorUpdateVideoMemorySize
qemuMonitorUpdateVideoVram64Size
qemuMonitorGetAllBlockStatsInfo
qemuMonitorBlockStatsUpdateCapacity
Signed-off-by: Joh
The API checks each parameter for NULL anyway and would error, so need
to add NONNULL on prototype.
Signed-off-by: John Ferlan
---
src/util/virtypedparam.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/util/virtypedparam.h b/src/util/virtypedparam.h
index 7ab143f..59d
The prototype requires not passing a NULL in the parameter and the callers
all would fail far before this code would fail if 'vm' was NULL, so just
remove the check.
Signed-off-by: John Ferlan
---
src/qemu/qemu_monitor.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/q
Since the code checks 'mgr == NULL' anyway, no need for the prototype
to have the NONNULL arg check. Also add an error message to indicate what
the failure is so that there isn't a failed for some reason error.
Signed-off-by: John Ferlan
---
src/util/virhostdev.c | 5 -
src/util/virhostdev.
The comparison code used STREQ_NULLABLE anyway for both 'drv_name' and
'dom_name', so no need. Add a NULLSTR on the 'dom_name' too.
Signed-off-by: John Ferlan
---
src/util/virhostdev.c | 2 +-
src/util/virhostdev.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/util/v
Rather than returning an int and a *bitmap pointer, just return and
check a NULL bitmap pointer
Signed-off-by: John Ferlan
---
src/util/virbitmap.c | 26 --
src/util/virbitmap.h | 7 +++
tests/testutils.c | 2 +-
tests/virbitmaptest.c | 2 +-
4 files changed,
The prototype requires a NONNULL argument and the only caller passes in
a non-null parameter. Besides the "else if" condition would deref it anyway.
Signed-off-by: John Ferlan
---
src/network/bridge_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/network/bridge_d
Hopefully the quantity doesn't scare anyone off... These are mostly
innocuous, but separated each out to appease the masses.
The first patch fixes a recently uncovered Coverity warning regarding
FORWARD_NULL of the 'formatStr'... According to an IRC response from
pkrempa the format should be set u
The 'ifindex' argument is not a pointer, so no need for NONNULL in prototype
Signed-off-by: John Ferlan
---
src/util/virnetdev.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/util/virnetdev.h b/src/util/virnetdev.h
index 01e9c5b..9c9daf1 100644
--- a/src/util/virnetdev.
Since the code checks and handles NULL parameters, remove the NONNULL
from the prototype.
Also fix the comment in the source to reference the right name.
Signed-off-by: John Ferlan
---
src/conf/netdev_bandwidth_conf.c | 2 +-
src/conf/netdev_bandwidth_conf.h | 3 +--
2 files changed, 2 insertio
The code checks and handles a NULL 'migrate', so no need for NONNULL
Signed-off-by: John Ferlan
---
src/util/virnetdevopenvswitch.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/util/virnetdevopenvswitch.h b/src/util/virnetdevopenvswitch.h
index 4f62be1..021eba9 100644
Since the code checks and handles a NULL 'numa' parameter, remove the NONNULL
from the prototype.
Signed-off-by: John Ferlan
---
src/conf/numa_conf.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/conf/numa_conf.h b/src/conf/numa_conf.h
index 05529ba..b6a5354 100644
Since the code checks and handles a NULL 'node' before proceeding
there's no need for the prototype with the NONNULL(2).
Signed-off-by: John Ferlan
---
src/conf/netdev_bandwidth_conf.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/conf/netdev_bandwidth_conf.h b/src/conf
The code checks and handles a NULL 'str', so just remove the NONNULL.
Update the error message to add the NULLSTR() around 'str' also.
Signed-off-by: John Ferlan
---
src/util/virbitmap.c | 2 +-
src/util/virbitmap.h | 3 +--
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/src/uti
The source code will check for NULL arguments for 'macvtap_macaddr' and
'vmuuid', so no need for the NONNULL in the prototypes. Following the stack
for both arguments to virNetDevVPortProfileOpSetLink also shows called
functions would handle a NULL value.
Additionally, modified the prototype to us
The qemuDomainSnapshotPrepare should always set a > 0 format value anyway,
so remove the check.
Found by Coverity.
Signed-off-by: John Ferlan
---
src/qemu/qemu_driver.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 0e
The called function uses a STRNEQ_NULLABLE anyway for both 'drv_name' and
'dom_name', so no need.
Signed-off-by: John Ferlan
---
src/util/virhostdev.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/util/virhostdev.h b/src/util/virhostdev.h
index 1202136..4ce5c4d 100644
-
Since the code checks and handles a NULL 'path', no need for the NONNULL
Signed-off-by: John Ferlan
---
src/util/virnetdevopenvswitch.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/util/virnetdevopenvswitch.h b/src/util/virnetdevopenvswitch.h
index 021eba9..7380a2d 100
On 03/22/2017 02:55 AM, Peter Krempa wrote:
> On Wed, Mar 15, 2017 at 17:37:12 +0100, Peter Krempa wrote:
>> This is another version of the stuff that I've posted here:
>> https://www.redhat.com/archives/libvir-list/2017-February/msg01391.html
>> which was partially based on the very old discussion
On Wed, 15 Mar 2017 10:11:50 +0100
Andrea Bolognani wrote:
> On Wed, 2017-03-15 at 08:59 +0100, Jiri Denemark wrote:
> > > > Removing all memory locking limits should be something that
> > > > admins very carefully opt-in into, because of the potential
> > > > host DoS consequences. Certainly not
[...]
> +
> +static int
> +virNetDevIPCheckIPv6ForwardingCallback(const struct nlmsghdr *resp,
> + void *opaque)
> +{
> +struct rtmsg *rtmsg = NLMSG_DATA(resp);
> +int accept_ra = -1;
> +struct rtattr *rta;
> +char *ifname = NULL;
> +struc
On 03/15/2017 10:45 AM, Cédric Bosdonnat wrote:
[...]
>
> /**
> * virNetDevGetIndex:
> diff --git a/src/util/virnetdev.h b/src/util/virnetdev.h
> index 236cf83ef..01e9c5b95 100644
> --- a/src/util/virnetdev.h
> +++ b/src/util/virnetdev.h
> @@ -157,6 +157,8 @@ int virNetDevSetNamespace(cons
On Wed, Mar 22, 2017 at 14:13:25 +0530, Prerna wrote:
> I agree. Thanks for pointing out that this is a behavioural change, which
> should not happen.
Please don't top post on technical lists.
>
> I should be doing something like this:
>
> if (virFileReadAllQuiet(path, 1024, &buf) < 0 ) {
>
I looked through what you were suggesting.
I was assuming virNetSocketGetFD()would do a NULL check for the sock arg,
and would return immediately if a different client executed a
virNetServerClientClose() setting client->sock to null.
Since this check is missing, I understand the implicit assumpti
On 03/22/2017 06:46 AM, Roman Bogorodskiy wrote:
Michal Privoznik wrote:
For some drivers the domain's machine type makes no sense. They
just don't use it. A great example is bhyve driver. Therefore it
makes very less sense to report machine in domain capabilities
XML.
Signed-off-by: Michal
I agree. Thanks for pointing out that this is a behavioural change, which
should not happen.
I should be doing something like this:
if (virFileReadAllQuiet(path, 1024, &buf) < 0 ) {
if (errno != ENOENT) {
virReportSystemError(errno,
_("unable to read
Oops, sorry. Dropping the list was not intentional. I didnt realise I had
sent a "reply" in place of "reply-all" .
Adding back :)
I still would argue that having the VM's name narrows down the problem
space. If a client knows what operations have been fired for a VM over the
last time window, it
On Wed, Mar 22, 2017 at 09:14:41 +0100, Peter Krempa wrote:
> On Wed, Mar 22, 2017 at 01:02:18 -0700, Prerna Saxena wrote:
> > Sample from current logs:
> > error : virFileReadAll:1290 : Failed to open file
> > '/sys/class/net/tap3/operstate': No such file or directory
> > error : virNetDevGetLink
On Wed, Mar 22, 2017 at 01:02:18 -0700, Prerna Saxena wrote:
> Sample from current logs:
> error : virFileReadAll:1290 : Failed to open file
> '/sys/class/net/tap3/operstate': No such file or directory
> error : virNetDevGetLinkInfo:1895 : unable to read:
> /sys/class/net/tap3/operstate: No such
On Wed, Mar 22, 2017 at 01:02:19 -0700, Prerna Saxena wrote:
> Current logs:
> error : qemuProcessFindDomainDiskByAlias:411 : internal error: no disk found
> with alias ide0-0-0
>
> There is no way to find which VM was seeing this error.
> Makes debugging very hard, and the message itself is no g
On Wed, Mar 22, 2017 at 01:02:17 -0700, Prerna Saxena wrote:
> While tracing connections from a remote client, it helps to keep track
> of the connection lifecycle. Messages such as the following :
>
> error : virNetSocketReadWire:1574 : End of file while reading data:
> Input/output error
>
> a
On 03/21/2017 07:04 PM, D L wrote:
> Yes, I compiled, installed, and used the binaries successfully.
> Could you confirm the location of bug list is the following, please?
>
> https://bugzilla.redhat.com/buglist.cgi?component=libvirt&product=Virtualization%20Tools
This will fetch all bug there ar
Current logs:
error : qemuProcessFindDomainDiskByAlias:411 : internal error: no disk found
with alias ide0-0-0
There is no way to find which VM was seeing this error.
Makes debugging very hard, and the message itself is no good.
Signed-off-by: Prerna Saxena
---
src/qemu/qemu_process.c | 4 ++--
While tracing connections from a remote client, it helps to keep track
of the connection lifecycle. Messages such as the following :
error : virNetSocketReadWire:1574 : End of file while reading data:
Input/output error
are rather unhelpful. They do not indicate if the client had earlier asked f
Sample from current logs:
error : virFileReadAll:1290 : Failed to open file
'/sys/class/net/tap3/operstate': No such file or directory
error : virNetDevGetLinkInfo:1895 : unable to read:
/sys/class/net/tap3/operstate: No such file or directory
These have no useful data point and are redundant.
Libvirt logs include many snippets for debugging daemon state, but
some of those messages are either missing vital information or end up logging
"errors" for normal operating conditions as well.
This series improves log messages, also adding additional WARN'ings for
connection instantiation and c
On Wed, Mar 15, 2017 at 17:37:12 +0100, Peter Krempa wrote:
> This is another version of the stuff that I've posted here:
> https://www.redhat.com/archives/libvir-list/2017-February/msg01391.html
> which was partially based on the very old discussion at
> https://www.redhat.com/archives/libvir-list
On Tue, Mar 21, 2017 at 17:09:58 +0100, Michal Privoznik wrote:
> On 03/21/2017 04:34 PM, Peter Krempa wrote:
> > On Tue, Mar 21, 2017 at 16:15:35 +0100, Michal Privoznik wrote:
> > > On 03/21/2017 04:39 AM, D L wrote:
> > > > On Thu, Mar 16, 2017 at 1:03 PM, Michal Privoznik
> > > > wrote:
> >
>
97 matches
Mail list logo