Re: [libvirt] [PATCH v2 4/4] docs: Add news article for logical pool-create-as

On 03/27/2017 04:35 PM, Martin Kletzander wrote: > On Mon, Mar 27, 2017 at 01:42:23PM -0400, John Ferlan wrote: >> Signed-off-by: John Ferlan >> --- >> docs/news.xml | 5 + >> 1 file changed, 5 insertions(+) >> >> diff --git a/docs/news.xml b/docs/news.xml >> index

Re: [libvirt] [PATCH 1/2] networkUpdateState: Create virMacMap module more frequently

On 03/22/2017 10:43 AM, Michal Privoznik wrote: > The virMacMap module is there for dumping [domain, MACs>] pairs into a file so that libvirt_guest NSS module can use > it. Whenever a interface is allocated from network (e.g. on > domani startup or NIC hotplug), network is notified and so is

Re: [libvirt] [PATCH v2 3/4] storage: Better describe logical pool creation/definition parameters

On 03/27/2017 05:19 PM, Jiri Denemark wrote: > On Mon, Mar 27, 2017 at 13:42:22 -0400, John Ferlan wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1398087 >> >> Clean up the virsh man page description for --pool-create-as in order >> to better describe how the various arguments are used

Re: [libvirt] [PATCH v2 3/4] storage: Better describe logical pool creation/definition parameters

On Mon, Mar 27, 2017 at 13:42:22 -0400, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1398087 > > Clean up the virsh man page description for --pool-create-as in order > to better describe how the various arguments are used when creating > (or defining) a logical pool. > >

[libvirt] [PATCH] news: Move recent bug fixes into 3.2.0 release

Commits 29f7b5ea6a and 5edf9aaf54 pushed them incorrectly at the end of the file in the bug fixes section for libvirt 2.5.0. Signed-off-by: Jiri Denemark --- Pushed as trivial. docs/news.xml | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-)

[libvirt] [PATCH 2/2] Build vircaps2xmltest and requirements only on Linux

The mock, as well as the test, is only available on Linux. So skip building it everywhere else, especially when it fails on mingw. Signed-off-by: Martin Kletzander --- tests/Makefile.am | 17 ++--- tests/vircaps2xmltest.c | 16 ++-- 2 files

[libvirt] [PATCH 1/2] Use stub for virNetDevGetName on mingw

If if_indextoname is not defined, the whole function using it should not be defined either. Add stub to fix build on mingw. Caused by 5dd607059d8a98e04024305ae4afbd038aadbdcd Signed-off-by: Martin Kletzander --- configure.ac | 7 --- src/util/virnetdev.c | 10

Re: [libvirt] [PATCH v2 4/4] docs: Add news article for logical pool-create-as

On Mon, Mar 27, 2017 at 01:42:23PM -0400, John Ferlan wrote: Signed-off-by: John Ferlan --- docs/news.xml | 5 + 1 file changed, 5 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index a772799..29b3546 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -700,6

[libvirt] [PATCH 0/2] build: Fix build on mingw

Fixes pushed under build-breaker rule. Martin Kletzander (2): Use stub for virNetDevGetName on mingw Build vircaps2xmltest and requirements only on Linux configure.ac| 7 --- src/util/virnetdev.c| 10 ++ tests/Makefile.am | 17 ++---

Re: [libvirt] [PATCH] news: Make changes understandable for users

On Mon, Mar 27, 2017 at 22:25:39 +0200, Martin Kletzander wrote: > When reading release notes, patch summary is not always the best > description of what users can expect in new version. I propose > changing it slightly so that it describes what exactly happens and > when. > > However, we do not

[libvirt] [PATCH] virConfSaveValue: protect against a NULL pointer reference

From: Wim ten Have This patch protects against a NULL pointer dereference leading to a SEGV under xlconfigtest per DO_TEST("channel-pty"); VIR_TEST_OOM=1 VIR_TEST_RANGE=29 ./tests/xlconfigtest Wim ten Have (1): virConfSaveValue: protect against a NULL pointer

[libvirt] [PATCH] news: Make changes understandable for users

When reading release notes, patch summary is not always the best description of what users can expect in new version. I propose changing it slightly so that it describes what exactly happens and when. However, we do not have to add every single code change to the news file, that would be

[libvirt] [PATCH] virConfSaveValue: protect against a NULL pointer reference

From: Wim ten Have Fix xlconfigtest runs build for --enable-test-oom on Xen XL-2-XML Parse channel-pty Program received signal SIGSEGV, Segmentation fault. #0 0x73c2b373 in __strchr_sse2 () from /lib64/libc.so.6 ==> #1 0x77875701 in

[libvirt] [PATCH] xenFormatXLDomainDisks: avoid double free on OOM testing

From: Wim ten Have This patch fixes a double free that exposed under OOM testing xlconfigtest per DO_TEST("new-disk"); VIR_TEST_OOM=1 VIR_TEST_RANGE=5 ./tests/xlconfigtest Wim ten Have (1): xenFormatXLDomainDisks: avoid double free on OOM testing

[libvirt] [PATCH] xenFormatXLDomainDisks: avoid double free on OOM testing

From: Wim ten Have Fix xlconfigtest runs build for --enable-test-oom on Xen XL-2-XML Parse new-disk #0 0x73bd791f in raise () from /lib64/libc.so.6 #1 0x73bd951a in abort () from /lib64/libc.so.6 #2 0x73c1b200 in

Re: [libvirt] [PATCH v2 0/7] Memory locking fixes

On Mon, Mar 27, 2017 at 05:38:52PM +0200, Andrea Bolognani wrote: Changes from [v1]: * exit early from the loop in patch 2; * dropped patch 5/8, as it's no longer needed; * rewrote tests not to generate QEMU command line; About that ^^ there's still something to fix, but if you follow

Re: [libvirt] [PATCH v2 6/7] tests: Introduce QEMU memory locking limit tests

On Mon, Mar 27, 2017 at 05:38:58PM +0200, Andrea Bolognani wrote: These tests cover a number of scenarios where we care about the memory locking limit being set correctly for the guest to work properly. --- +static int +testCompareMemLock(const void *data) +{ +const struct testInfo *info =

Re: [libvirt] [PATCH 0/4] Start refactoring migration cookies

On Mon, Mar 27, 2017 at 14:30:49 -0400, John Ferlan wrote: > > > On 03/24/2017 11:40 AM, Jiri Denemark wrote: > > This series is a first step in refactoring migration cookies. The rest > > will take some time until it's done, but I figured the part which moves > > the code is very fragile and I

Re: [libvirt] [PATCH] news: Add support for setting TSC frequency

On 03/27/2017 02:33 PM, Jiri Denemark wrote: > Signed-off-by: Jiri Denemark > --- > docs/news.xml | 9 + > 1 file changed, 9 insertions(+) > ACK John -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] news: Add support for setting TSC frequency

Signed-off-by: Jiri Denemark --- docs/news.xml | 9 + 1 file changed, 9 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index a77279948..3f3821a16 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -72,6 +72,15 @@ introducing a new host device

Re: [libvirt] [PATCH 0/4] Start refactoring migration cookies

On 03/24/2017 11:40 AM, Jiri Denemark wrote: > This series is a first step in refactoring migration cookies. The rest > will take some time until it's done, but I figured the part which moves > the code is very fragile and I don't really want to keep rebasing it > until the refactoring is

Re: [libvirt] [PATCH 0/4] qemu: Add support for setting TSC frequency to enable migration with invtsc

On Mon, Mar 27, 2017 at 14:11:24 -0400, John Ferlan wrote: > > > On 03/24/2017 09:25 AM, Jiri Denemark wrote: > > QEMU allows for TSC frequency to be explicitly set to enable migration > > with invtsc (migration fails if the destination QEMU cannot set the > > exact same frequency used when

Re: [libvirt] [PATCH] hostdev: Fix build with GCC's static analysis in mdev

On Mon, Mar 27, 2017 at 12:30:23PM -0400, Laine Stump wrote: On 03/27/2017 11:40 AM, John Ferlan wrote: On 03/27/2017 11:30 AM, Martin Kletzander wrote: Similarly to eec3b255d26e7b38bdb0830990569fd91aee661f, fix build with lv_cv_static_analysis=yes. Caused by

Re: [libvirt] [PATCH v2] virmdev: fix build on non-Linux

Roman Bogorodskiy wrote: > - Make virMediatedDeviceNew() stub args match its prototype > - Fix typo: virRerportError -> virReportError > - Move MDEV_SYSFS_DEVICES definition out of the #ifdef __linux__ block >so we don't have to stub virMediatedDeviceGetSysfsPath() > --- > Changes from

Re: [libvirt] [PATCH 0/4] qemu: Add support for setting TSC frequency to enable migration with invtsc

On 03/24/2017 09:25 AM, Jiri Denemark wrote: > QEMU allows for TSC frequency to be explicitly set to enable migration > with invtsc (migration fails if the destination QEMU cannot set the > exact same frequency used when starting the domain on the source host). > > Jiri Denemark (4): > conf:

Re: [libvirt] [PATCH] util: Fix build on FreeBSD

Jiri Denemark wrote: > On Mon, Mar 27, 2017 at 21:58:06 +0400, Roman Bogorodskiy wrote: > > Jiri Denemark wrote: > > > > > Signed-off-by: Jiri Denemark > > > --- > > > Pushed as a trivial build-braker. > > > > > > src/util/virnetdev.c | 2 +- > > > 1 file changed, 1

Re: [libvirt] [PATCH] util: Fix build on FreeBSD

On Mon, Mar 27, 2017 at 21:58:06 +0400, Roman Bogorodskiy wrote: > Jiri Denemark wrote: > > > Signed-off-by: Jiri Denemark > > --- > > Pushed as a trivial build-braker. > > > > src/util/virnetdev.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff

Re: [libvirt] [PATCH] util: Fix build on FreeBSD

Jiri Denemark wrote: > Signed-off-by: Jiri Denemark > --- > Pushed as a trivial build-braker. > > src/util/virnetdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c > index 598d1c61a..486fe4cd1

[libvirt] [PATCH] util: Fix build on FreeBSD

Signed-off-by: Jiri Denemark --- Pushed as a trivial build-braker. src/util/virnetdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c index 598d1c61a..486fe4cd1 100644 --- a/src/util/virnetdev.c +++

Re: [libvirt] [PATCH v2 0/4] storage: Better describe logical pool creation/definition parameters

On 03/27/2017 01:42 PM, John Ferlan wrote: > v1: > https://www.redhat.com/archives/libvir-list/2017-March/msg01227.html > > changes since v1: > > Split things part - added news article > > John Ferlan (4): > conf: Set defaultFormat if no storage source XML present > virsh.pod: Move the

Re: [libvirt] [PATCH] storage: Better describe logical pool creation/definition parameters

On 03/27/2017 11:37 AM, John Ferlan wrote: > > > On 03/26/2017 08:38 PM, Laine Stump wrote: >> On 03/25/2017 08:18 AM, John Ferlan wrote: >>> https://bugzilla.redhat.com/show_bug.cgi?id=1398087 >>> >>> Clean up the virsh man page description for --pool-create-as in order >>> to better describe

[libvirt] [PATCH v2 1/4] conf: Set defaultFormat if no storage source XML present

While parsing if the storage source is not present, then a defaultFormat was not set. This could lead to oddities such as seeing "unknown" format in output for the "logical" pool even though the only format the pool could support would be "lvm2". This does "put a label" on other pool defaults as

[libvirt] [PATCH v2 2/4] virsh.pod: Move the positional --print-xml for pool-{define|create}-as

Move the --print-xml to the end of the qualifiers since it's not properly positionally situated for both --pool-create-as and --pool-define-as and could be miscontrued as being the 3rd positional argument. Signed-off-by: John Ferlan --- tools/virsh.pod | 8 1 file

[libvirt] [PATCH v2 4/4] docs: Add news article for logical pool-create-as

Signed-off-by: John Ferlan --- docs/news.xml | 5 + 1 file changed, 5 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index a772799..29b3546 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -700,6 +700,11 @@ logical: Need to overwrite/clear more than

[libvirt] [PATCH v2 3/4] storage: Better describe logical pool creation/definition parameters

https://bugzilla.redhat.com/show_bug.cgi?id=1398087 Clean up the virsh man page description for --pool-create-as in order to better describe how the various arguments are used when creating (or defining) a logical pool. Also modify the storage pool XML parsing algorithm to check for the

[libvirt] [PATCH v2 0/4] storage: Better describe logical pool creation/definition parameters

v1: https://www.redhat.com/archives/libvir-list/2017-March/msg01227.html changes since v1: Split things part - added news article John Ferlan (4): conf: Set defaultFormat if no storage source XML present virsh.pod: Move the positional --print-xml for pool-{define|create}-as storage:

Re: [libvirt] [PATCH] docs: document bhyve UEFI support

On 03/27/2017 12:33 PM, Roman Bogorodskiy wrote: > - Add a news entry > - Update the driver page with documentation of the new options >and some examples > --- > docs/drvbhyve.html.in | 94 > +++ > docs/news.xml | 13 +++ > 2

Re: [libvirt] [PATCH v2 1/2] daemon: Rework remoteClientFreeFunc cleanup loops into C macro

On 03/27/2017 12:47 PM, John Ferlan wrote: > Rather than 'n' repetitive code segments, let's create a single macro > which will make the code easier to read. > > Signed-off-by: John Ferlan > --- > daemon/remote.c | 126 >

[libvirt] [PATCH v2 2/2] remote: Fix possible use-after-free when sending event message

Based upon an idea and some research by Wang King and xinhua.Cao . Since we're assigning the 'client' to our callback event lookaside list, it's imperative that we grab a reference to the object; otherwise, when the object is unref'd during

[libvirt] [PATCH v2 1/2] daemon: Rework remoteClientFreeFunc cleanup loops into C macro

Rather than 'n' repetitive code segments, let's create a single macro which will make the code easier to read. Signed-off-by: John Ferlan --- daemon/remote.c | 126 +--- 1 file changed, 37 insertions(+), 89 deletions(-)

[libvirt] [PATCH v2 0/2] Fix possible use-after-free when sending event message

v1: https://www.redhat.com/archives/libvir-list/2017-March/msg01228.html Change since v1, add the derefFcn as an argument to the renamed macro (not quite sure how I missed that originally. John Ferlan (2): daemon: Rework remoteClientFreeFunc cleanup loops into C macro remote: Fix possible

Re: [libvirt] [PATCH] hostdev: Fix build with GCC's static analysis in mdev

On 03/27/2017 11:40 AM, John Ferlan wrote: > > > On 03/27/2017 11:30 AM, Martin Kletzander wrote: >> Similarly to eec3b255d26e7b38bdb0830990569fd91aee661f, fix build with >> lv_cv_static_analysis=yes. >> >> Caused by a4a39d90ab4930750bcbcfccffdf6bb6d310b5d5 >> --- >> src/util/virhostdev.c | 4

[libvirt] [PATCH] docs: document bhyve UEFI support

- Add a news entry - Update the driver page with documentation of the new options and some examples --- docs/drvbhyve.html.in | 94 +++ docs/news.xml | 13 +++ 2 files changed, 107 insertions(+) diff --git a/docs/drvbhyve.html.in

Re: [libvirt] [PATCH] netdev: fix build on non-Linux

On 03/27/2017 11:25 AM, Roman Bogorodskiy wrote: > Fix some typos in the source code: > > - Missplaced ")", > - virNetDevVLanPtr -> virNetDevVlanPtr Sigh. Sorry for the mess. Some day I should setup a guest running a *BSD and start doing a build there with each patch. (BTW, this is the top

Re: [libvirt] [PATCH] news: Update after recent commits

On 03/27/2017 11:40 AM, Peter Krempa wrote: > Mention the hyperv notifier and the new API to set block thresholds. > --- > docs/news.xml | 25 + > 1 file changed, 25 insertions(+) > > diff --git a/docs/news.xml b/docs/news.xml > index 814bd93fd..2dbd2335d 100644 > ---

Re: [libvirt] [PATCH 2/2] util: Remove NONNUL from virHostdevReAttachMediatedDevices

On 03/27/2017 11:29 AM, John Ferlan wrote: > Causes build failure when enabling static analysis > > Signed-off-by: John Ferlan > --- > src/util/virhostdev.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/util/virhostdev.h

Re: [libvirt] [PATCH 1/2] news: Add lost in merge

On 03/27/2017 11:29 AM, John Ferlan wrote: > Ensure to insert between items - lost during merge > resolution. > > Signed-off-by: John Ferlan > --- > docs/news.xml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/docs/news.xml b/docs/news.xml > index

Re: [libvirt] [PATCH] netdev: fix build on non-Linux

Ján Tomko wrote: > On Mon, Mar 27, 2017 at 07:25:16PM +0400, Roman Bogorodskiy wrote: > >Fix some typos in the source code: > > > > - Missplaced ")", > > s/Miss/Mis/ Thanks for the correction, I fixed it locally. Now that I have everything building fine with this patch and the virmdev fix I

[libvirt] [PATCH v2] virmdev: fix build on non-Linux

- Make virMediatedDeviceNew() stub args match its prototype - Fix typo: virRerportError -> virReportError - Move MDEV_SYSFS_DEVICES definition out of the #ifdef __linux__ block so we don't have to stub virMediatedDeviceGetSysfsPath() --- Changes from v1: instead of adding a stub for

[libvirt] [PATCH] virmdev: fix build on non-Linux

- Make virMediatedDeviceNew() stub args match its prototype - Fix typo: virRerportError -> virReportError - Move virMediatedDeviceGetSysfsPath() into #ifdef __linux__ block as it uses MDEV_SYSFS_DEVICES, and a stub for it --- I'm not pushing this one too, until I get a completely clean

[libvirt] [PATCH v2 7/7] docs: Improve documentation related to memory locking

--- docs/formatdomain.html.in | 39 ++- 1 file changed, 26 insertions(+), 13 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 4a3123e..180bca0 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@

[libvirt] [PATCH] news: Update after recent commits

Mention the hyperv notifier and the new API to set block thresholds. --- docs/news.xml | 25 + 1 file changed, 25 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 814bd93fd..2dbd2335d 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -70,6 +70,20 @@

[libvirt] [PATCH v2 3/7] qemu: Fix memory locking limit calculation

For guests that use , our only option is to remove the memory locking limit altogether. Partially-resolves: https://bugzilla.redhat.com/1431793 --- src/qemu/qemu_domain.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_domain.c

Re: [libvirt] [PATCH] hostdev: Fix build with GCC's static analysis in mdev

On 03/27/2017 11:30 AM, Martin Kletzander wrote: > Similarly to eec3b255d26e7b38bdb0830990569fd91aee661f, fix build with > lv_cv_static_analysis=yes. > > Caused by a4a39d90ab4930750bcbcfccffdf6bb6d310b5d5 > --- > src/util/virhostdev.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [libvirt] [PATCH] storage: Better describe logical pool creation/definition parameters

On 03/26/2017 08:38 PM, Laine Stump wrote: > On 03/25/2017 08:18 AM, John Ferlan wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1398087 >> >> Clean up the virsh man page description for --pool-create-as in order >> to better describe how the various arguments are used when creating >> (or

[libvirt] [PATCH v2 6/7] tests: Introduce QEMU memory locking limit tests

These tests cover a number of scenarios where we care about the memory locking limit being set correctly for the guest to work properly. --- tests/Makefile.am | 9 ++ .../qemumemlock-pc-hardlimit+hostdev.xml | 20 +++

[libvirt] [PATCH v2 0/7] Memory locking fixes

Changes from [v1]: * exit early from the loop in patch 2; * dropped patch 5/8, as it's no longer needed; * rewrote tests not to generate QEMU command line; * changed documentation slightly. [v1] https://www.redhat.com/archives/libvir-list/2017-March/msg01089.html Andrea Bolognani

[libvirt] [PATCH v2 1/7] Revert "qemu: Forbid without "

This reverts commit c2e60ad0e5124482942164e5fec088157f5e716a. Turns out this check is excessively strict: there are ways other than to raise the memory locking limit for QEMU processes, one prominent example being tweaking /etc/security/limits.conf. Partially-resolves:

Re: [libvirt] [PATCH] network: better validation of devices in hostdev network pool

On 25.03.2017 19:00, Laine Stump wrote: This adds a few validations to the devices listed for a hostdev network: * devices must be listed by PCI address, not by netdev name * listing a device by PCI address is valid only for hostdev networks, not for other types of network (e.g. macvtap

[libvirt] [PATCH v2 2/7] qemu: Remove qemuDomainRequiresMemLock()

Instead of having a separate function, we can simply return zero from the existing qemuDomainGetMemLockLimitBytes() to signal the caller that the memory locking limit doesn't need to be set for the guest. Having a single function instead of two makes it less likely that we will use the wrong

[libvirt] [PATCH v2 4/7] process: Translate "unlimited" correctly

The value we use internally to represent the lack of a memory locking limit, VIR_DOMAIN_MEMORY_PARAM_UNLIMITED, doesn't match the value setrlimit() and prlimit() use for the same purpose, RLIM_INFINITY, so we have to handle the translation ourselves. Partially-resolves:

[libvirt] [PATCH v2 5/7] tests: Introduce virTestCompareToULL()

This will be used later on in the test suite. --- tests/testutils.c | 27 +++ tests/testutils.h | 2 ++ 2 files changed, 29 insertions(+) diff --git a/tests/testutils.c b/tests/testutils.c index 13eff9e..f3feb6d 100644 --- a/tests/testutils.c +++ b/tests/testutils.c @@

[libvirt] [PATCH] hostdev: Fix build with GCC's static analysis in mdev

Similarly to eec3b255d26e7b38bdb0830990569fd91aee661f, fix build with lv_cv_static_analysis=yes. Caused by a4a39d90ab4930750bcbcfccffdf6bb6d310b5d5 --- src/util/virhostdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/virhostdev.c b/src/util/virhostdev.c

Re: [libvirt] [PATCH] Expose Linux symbols only on Linux

On Mon, Mar 27, 2017 at 05:17:57PM +0200, Martin Kletzander wrote: > Signed-off-by: Martin Kletzander > --- > Just to make it a teeny tiny nicer, how about this one as well. I > know the whole file needs way more refactoring and cleaning up, but we > can do that by small

Re: [libvirt] [PATCH] netdev: fix build on non-Linux

On Mon, Mar 27, 2017 at 07:25:16PM +0400, Roman Bogorodskiy wrote: Fix some typos in the source code: - Missplaced ")", s/Miss/Mis/ Jan - virNetDevVLanPtr -> virNetDevVlanPtr --- I'm NOT pushing that under the build breaker rule right now because I also have some other build failures and

[libvirt] [PATCH 1/2] news: Add lost in merge

Ensure to insert between items - lost during merge resolution. Signed-off-by: John Ferlan --- docs/news.xml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 814bd93..3877984 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -51,6

[libvirt] [PATCH 0/2] More simple fixes.

One noted after push w/r/t change in news.xml and the other found after I rebased to current head from recent commit. John Ferlan (2): news: Add lost in merge util: Remove NONNUL from virHostdevReAttachMediatedDevices docs/news.xml | 2 ++ src/util/virhostdev.h | 2 +- 2 files

[libvirt] [PATCH 2/2] util: Remove NONNUL from virHostdevReAttachMediatedDevices

Causes build failure when enabling static analysis Signed-off-by: John Ferlan --- src/util/virhostdev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virhostdev.h b/src/util/virhostdev.h index ff7c7b8..54e1c66 100644 --- a/src/util/virhostdev.h

Re: [libvirt] [PATCH] logical: Need to overwrite/clear more than just first 512 bytes

On 24.03.2017 18:48, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1430679 As it turns out some file headers (e.g. ext4) may be larger/longer than the 512 bytes of zeros being written prior to a pvcreate, so let's write out 2048 bytes similar to how the pvcreate sources would

[libvirt] [PATCH] netdev: fix build on non-Linux

Fix some typos in the source code: - Missplaced ")", - virNetDevVLanPtr -> virNetDevVlanPtr --- I'm NOT pushing that under the build breaker rule right now because I also have some other build failures and syntax-checking failing, so I cannot do a complete test build. src/util/virnetdev.c | 4

[libvirt] [PATCH] Expose Linux symbols only on Linux

Signed-off-by: Martin Kletzander --- Just to make it a teeny tiny nicer, how about this one as well. I know the whole file needs way more refactoring and cleaning up, but we can do that by small pieces. src/libvirt_linux.syms | 3 +++ src/libvirt_private.syms | 2 -- 2

Re: [libvirt] [PATCH 1/4] qemu: Advertise ACPI support for aarch64 guests

On 03/27/2017 10:39 AM, Andrea Bolognani wrote: > On Mon, 2017-03-27 at 10:26 -0400, John Ferlan wrote: > [...] Considering on what's coming in patch 2, this would be better as a virQEMUCapsSetFirmwareCaps? "utility" function... That way the added comments in both places

Re: [libvirt] [PATCH 7/8] tests: Introduce QEMU memory locking limit tests

On Mon, 2017-03-27 at 15:26 +0200, Martin Kletzander wrote: [...] > > +if (!(cmd = qemuProcessCreatePretendCmd(conn, , vm, NULL, 0, > > false, > > +VIR_QEMU_PROCESS_START_COLD))) > > { > > +goto cleanup; > > +} > > + >  > Going through

Re: [libvirt] [PATCH 0/2] Fix syntax check

On Mon, Mar 27, 2017 at 16:54:44 +0200, Jiri Denemark wrote: > Jiri Denemark (2): > build: Fix sc_prohibit_exit_in_tests syntax check > build: Fix syntax check in VPATH > > cfg.mk | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) ACK series, this fixes the build for me.

Re: [libvirt] [PATCH 3/8] qemu: Fix memory locking limit calculation

On Mon, Mar 27, 2017 at 04:24:57PM +0200, Andrea Bolognani wrote: On Mon, 2017-03-27 at 15:42 +0200, Martin Kletzander wrote: > > Are you planning on adding new element to the > > domain XML which would allow setting this number as well? >  > I do. Unless I forget about it again, of course :)  

Re: [libvirt] [PATCH 3/3] virhostcpu: Make only defined symbols available

On Mon, Mar 27, 2017 at 04:21:10PM +0200, Martin Kletzander wrote: > That way you get the error from the compiler before the linker. > > Signed-off-by: Martin Kletzander > --- > src/util/virhostcpu.h | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) ACK Pavel

Re: [libvirt] [PATCH 00/14] Add tests for virCPUUpdateLive API

On Mon, Mar 27, 2017 at 16:11:17 +0200, Pavel Hrdina wrote: > On Fri, Mar 17, 2017 at 05:36:38PM +0100, Jiri Denemark wrote: > > Jiri Denemark (14): > > cpu_conf: Introduce virCPUDefFreeFeatures > > cpu: Introduce virCPUExpandFeatures > > cpu: Drop unused flags from cpuArchDecode > > cpu:

[libvirt] [PATCH 2/2] build: Fix syntax check in VPATH

Matching the beginning of a path in syntax check does not work because each path is enriched with a prefix of the source tree. Signed-off-by: Jiri Denemark --- cfg.mk | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/cfg.mk b/cfg.mk index

[libvirt] [PATCH 1/2] build: Fix sc_prohibit_exit_in_tests syntax check

This check makes sense only in *.c files. Signed-off-by: Jiri Denemark --- cfg.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cfg.mk b/cfg.mk index 36f70bfb9..ceca27f5d 100644 --- a/cfg.mk +++ b/cfg.mk @@ -808,7 +808,7 @@

[libvirt] [PATCH 0/2] Fix syntax check

Jiri Denemark (2): build: Fix sc_prohibit_exit_in_tests syntax check build: Fix syntax check in VPATH cfg.mk | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.12.2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/2] Reject negative storage size

On Mon, Mar 27, 2017 at 02:42:06PM +0200, Ján Tomko wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1436119 Who would even!... Ján Tomko (2): storage: reject negative capacity virsh: reject more negative numbers Some of these are parsing data gotten from libvirt, so it's not

Re: [libvirt] [PATCH 1/3] tests: Properly dereference cpus pointer in virnumamock.c

On Mon, Mar 27, 2017 at 04:21:08PM +0200, Martin Kletzander wrote: > Signed-off-by: Martin Kletzander > --- > tests/virnumamock.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) ACK Pavel signature.asc Description: Digital signature -- libvir-list mailing list

Re: [libvirt] [PATCH 1/4] qemu: Advertise ACPI support for aarch64 guests

On Mon, 2017-03-27 at 10:26 -0400, John Ferlan wrote: [...] > > > Considering on what's coming in patch 2, this would be better as a > > > virQEMUCapsSetFirmwareCaps? "utility" function...  That way the added > > > comments in both places referencing the other place could be dropped. > >  > > HPET

Re: [libvirt] [PATCH 2/3] virhostcpu: Expose virHostCPUGetOnline on non-Linux

On Mon, Mar 27, 2017 at 04:21:09PM +0200, Martin Kletzander wrote: > Previously, this function must've been called only on Linux in order > to fail gracefully. That lead to #ifdef mess in callers, so the > function was redesigned so it failed gracefully on non-existing > files. However that

Re: [libvirt] [PATCH] qemu: command: align disk serial check to schema

On Mon, Mar 27, 2017 at 02:40:27PM +0300, Nikolay Shirokovskiy wrote: Disk serial schema has extra '.+' allowed characters in comparison with check in code. Looks like there is no reason for that as qemu allows any character AFAIK for serial. This discrepancy is originated in 85d15b51 where

[libvirt] [PATCH 3/3] virhostcpu: Make only defined symbols available

That way you get the error from the compiler before the linker. Signed-off-by: Martin Kletzander --- src/util/virhostcpu.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/util/virhostcpu.h b/src/util/virhostcpu.h index a4ce655d6a2e..e9c22eecc9c9

Re: [libvirt] [PATCH 1/4] qemu: Advertise ACPI support for aarch64 guests

On 03/27/2017 09:57 AM, Andrea Bolognani wrote: > On Mon, 2017-03-27 at 08:03 -0400, John Ferlan wrote: > [...] >>> +/* Older QEMU versions reported -no-acpi in the output of -help even >>> + * though it was not supported by the architecture. The issue has since >>> + * been fixed,

[libvirt] [PATCH 2/3] virhostcpu: Expose virHostCPUGetOnline on non-Linux

Previously, this function must've been called only on Linux in order to fail gracefully. That lead to #ifdef mess in callers, so the function was redesigned so it failed gracefully on non-existing files. However that commit forgot to define the function outside the __linux__ ifdef.

[libvirt] [PATCH 0/3] Build and other fixes

So I broke the build on non-Linux. Sorry. But I did that *because* I was considering other platforms in the code. Also there was a bad dereference somewhere. So because it's three patches, I'm rather sending it for review than just pushing it. Martin Kletzander (3): tests: Properly

[libvirt] Question about qemuDomainLogContextNew()

Hi, Dear all I have a question, and need your help. 　　I want to output some log message to "/var/log/libvirt/qemu/instance-xx" when guest kernel crashed, so I add following the code: static int

Re: [libvirt] [PATCH 3/8] qemu: Fix memory locking limit calculation

On Mon, 2017-03-27 at 15:42 +0200, Martin Kletzander wrote: > > > Are you planning on adding new element to the > > > domain XML which would allow setting this number as well? > >  > > I do. Unless I forget about it again, of course :) >  > Well, honestly, then I feel really bad about forcing

[libvirt] [PATCH 1/3] tests: Properly dereference cpus pointer in virnumamock.c

Signed-off-by: Martin Kletzander --- tests/virnumamock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/virnumamock.c b/tests/virnumamock.c index 89e420fa4173..210d15d6adf0 100644 --- a/tests/virnumamock.c +++ b/tests/virnumamock.c @@ -181,7 +181,7

Re: [libvirt] [PATCH v2 4/4] qemu: Log additional data from hyperv crash notifier

On Mon, Mar 27, 2017 at 16:10:55 +0200, Peter Krempa wrote: > The hyperv panic notifier reports additional data in form of 5 registers > that are reported in the crash event from qemu. Log them into the VM log > file and report them as a warning so that admins can see the cause of > crash of their

Re: [libvirt] [PATCH] conf: validate that PCI controller index is < 256

On Mon, Mar 27, 2017 at 09:51:28AM -0400, Laine Stump wrote: On 03/27/2017 03:41 AM, Martin Kletzander wrote: On Sun, Mar 26, 2017 at 08:49:28PM -0400, Laine Stump wrote: This is the maximum for many reasons, for starters because index == bus number, and a controller's bus number is 8 bits.

Re: [libvirt] [PATCH 10/14] cputest: Add "diff" command to cpu-cpuid.py

On Fri, Mar 17, 2017 at 05:36:48PM +0100, Jiri Denemark wrote: > The new command can be used to generate test data for virCPUUpdateLive. > > When "cpu-cpuid.py diff x86-cpuid-Something.json" is run, it reads raw > CPUID data stored in x86-cpuid-Something.xml and CPUID data from QEMU > stored in

Re: [libvirt] [PATCH 00/14] Add tests for virCPUUpdateLive API

On Fri, Mar 17, 2017 at 05:36:38PM +0100, Jiri Denemark wrote: > Jiri Denemark (14): > cpu_conf: Introduce virCPUDefFreeFeatures > cpu: Introduce virCPUExpandFeatures > cpu: Drop unused flags from cpuArchDecode > cpu: Move feature expansion out of cpuBaseline > cpu: Do not pass

[libvirt] [PATCH v2 4/4] qemu: Log additional data from hyperv crash notifier

The hyperv panic notifier reports additional data in form of 5 registers that are reported in the crash event from qemu. Log them into the VM log file and report them as a warning so that admins can see the cause of crash of their windows VMs. Resolves:

Re: [libvirt] [PATCH 1/4] qemu: Advertise ACPI support for aarch64 guests

On Mon, 2017-03-27 at 08:03 -0400, John Ferlan wrote: [...] > > +/* Older QEMU versions reported -no-acpi in the output of -help even > > + * though it was not supported by the architecture. The issue has since > > + * been fixed, but to maintain compatibility with all release we still

Re: [libvirt] [PATCH 4/4] qemu: Log additional data from hyperv crash notifier

On Tue, Mar 21, 2017 at 08:47:50 +0100, Peter Krempa wrote: > The hyperv panic notifier reports additional data in form of 5 registers > that are reported in the crash event from qemu. Log them into the VM log > file and report them as a warning so that admins can see the cause of > crash of their

Re: [libvirt] [PATCH 0/8] Memory locking fixes

On Fri, Mar 24, 2017 at 02:01:34PM -0400, Luiz Capitulino wrote: On Thu, 23 Mar 2017 19:16:39 +0100 Andrea Bolognani wrote: A problem reported recently to the mailing list[1] uncovered some flaws in the way we deal with setting the memory locking limit for QEMU guests.

  1   2   >