On Wed, Apr 05, 2017 at 07:58:36 +0200, Bjoern Walk wrote:
> Daniel P. Berrange [2017-04-04, 07:24PM +0200]:
> > The news.rng file gets picked up by the wildcard match on docs/schemas,
> > and so gets installed into /usr/share/libvirt, along with the schemas
> > for our API objects. This then gene
On Tue, Apr 04, 2017 at 18:24:07 +0100, Daniel Berrange wrote:
> The news.rng file gets picked up by the wildcard match on docs/schemas,
> and so gets installed into /usr/share/libvirt, along with the schemas
> for our API objects. This then generated an RPM build failure, since
> we don't have new
On Tue, Apr 04, 2017 at 04:23:18PM +0100, Daniel P. Berrange wrote:
> On Wed, Mar 29, 2017 at 02:51:10PM +0200, Erik Skultety wrote:
> > This series enables the node device driver to report information about the
> > existing mediated devices on the host. There is no device creation involved
> > yet
Daniel P. Berrange [2017-04-04, 07:24PM +0200]:
The news.rng file gets picked up by the wildcard match on docs/schemas,
and so gets installed into /usr/share/libvirt, along with the schemas
for our API objects. This then generated an RPM build failure, since
we don't have news.rng in the RPM fil
Hi. I know that libvirt devs does not like devs that used internal rpc
of libvirt... I need to create stream to use with upload/download and
as i see it does not created via rpc call, can you suggest me what
files i need to check to understand how virStreamNew works and how to
read write works inte
On Tue, 2017-04-04 at 23:20 +0200, Matthias Bolte wrote:
> 2017-04-04 1:52 GMT+02:00 Dawid Zamirski :
> > ---
> > docs/news.xml | 11 +++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/docs/news.xml b/docs/news.xml
> > index 9c0dcfd..39631c3 100644
> > --- a/docs/news.xml
> > +
---
docs/drvhyperv.html.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/drvhyperv.html.in b/docs/drvhyperv.html.in
index 7acf86f..411895a 100644
--- a/docs/drvhyperv.html.in
+++ b/docs/drvhyperv.html.in
@@ -5,7 +5,7 @@
Microsoft Hyper-V hypervisor driver
basically s/data->/data.common->/
Because the data member of hypervObject is a union, get the data via
the "common" member everywhere - existing driver does not require
special handling for v1 vs v2 separately.
---
src/hyperv/hyperv_driver.c | 76 +++---
sr
---
docs/news.xml | 11 +++
1 file changed, 11 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 9c0dcfd..39631c3 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -37,6 +37,17 @@
+
+
+ The libvirt Hyper-V driver now supports Hyper-V 2
Since this is the last commit that will compile in the series, the
remaining patches should be squashed into this one - they are kept
separate only for code review purposes.
This struct is to be passed to enumerate-and-pull wsman request (to run
"Select" queries) and provides the hypervWmiClassInf
This enables this function to handle "v1" and "v2" WMI requests.
Since this commit and the ones that follow should be squashed on
previous one:
* rename hypervObjectUnified -> hypervObject as we've already broken
compilation here so there's no point in keeping those in parallel
anymore.
* do n
This patch updates the code generator that outputs C headers and code
for WMI classes. It has been updated to handle multiple versions (or
namespaces) of the same class which were introduced with Hyperv 2012+
---
src/hyperv/hyperv_wmi_generator.py | 381 -
1 fil
This function detects hyperv version by issuing a simple query using
"v2" namespace and falling back to "v1".
---
src/hyperv/hyperv_driver.c | 90 +++---
1 file changed, 54 insertions(+), 36 deletions(-)
diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/
Hyper-V 2012+ uses a new "v2" version of Msvm_* WMI classes so we will
store that info in hypervPrivate so that it is easily accessbile in the
driver API callbacks and handled accordingly.
---
src/hyperv/hyperv_private.h | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/sr
This struct is to be used to carry all the information necessary to
issue wsman requests for given WMI class. Those will be defined by the
generator code (as lists) so that they are handy for the driver code to
"extract" needed info depending on which hyper-v we're connected to.
For example:
hyper
Those used to be auto-generated and are hand-written now intead. The
reason being that those are not very useful and better replacements are
in order once the driver itself implements more of the API and common
patterns start to emerge.
---
src/Makefile.am | 2 -
src/hyperv/hyperv
Currently named as hypervObjecUnified to keep code
compilable/functional until all bits are in place.
This struct is a result of unserializing WMI request response.
Therefore, it needs to be able to deal with different "versions" of the
same WMI class. To accomplish this, the "data" member was tur
Adds defintiions for "v2" WMI class variants that are needed by the
driver to handle both hyperv 2008 and 2012+
---
src/hyperv/hyperv_wmi_generator.input | 239 +-
1 file changed, 206 insertions(+), 33 deletions(-)
diff --git a/src/hyperv/hyperv_wmi_generator.input
Changes in v4:
* changed hypervWqlQuery struct to use virBuffer as query member so that
hypervEnumAndPull and free it for us.
* fixed hypervFreeObject that had outdated code in code path that was
compiled away via preprocessor - this fix is in patch 5
* fixed whitespace/spelling and missing com
On Tue, 2017-04-04 at 23:10 +0200, Matthias Bolte wrote:
> 2017-04-04 1:52 GMT+02:00 Dawid Zamirski :
> > This enables this function to handle "v1" and "v2" WMI requests.
> >
> > Since this commit and the ones that follow should be squashed on
> > previous one:
> > * rename hypervObjectUnified ->
2017-04-04 1:52 GMT+02:00 Dawid Zamirski :
> ---
> docs/news.xml | 11 +++
> 1 file changed, 11 insertions(+)
>
> diff --git a/docs/news.xml b/docs/news.xml
> index 9c0dcfd..39631c3 100644
> --- a/docs/news.xml
> +++ b/docs/news.xml
> @@ -37,6 +37,17 @@
>
>
>
> +
>
2017-04-04 1:52 GMT+02:00 Dawid Zamirski :
> This patch updates the code generator that outputs C headers and code
> for WMI classes. It has been updated to handle multiple versions (or
> namespaces) of the same class which were introduced with Hyperv 2012+
> ---
> src/hyperv/hyperv_wmi_generator.
2017-04-04 1:52 GMT+02:00 Dawid Zamirski :
> This enables this function to handle "v1" and "v2" WMI requests.
>
> Since this commit and the ones that follow should be squashed on
> previous one:
> * rename hypervObjectUnified -> hypervObject as we've already broken
> compilation here so there's n
On Tue, Apr 04, 2017 at 03:27:49PM +0100, Daniel P. Berrange wrote:
> I'm going to send a patch series containing this fix & some other
> changes / fixes. Would appreciate if you can confirm my updated
> code still works from your pov.
Thanks! I'll look into this tomorrow.
--
pozdrawiam / best
On Tue, Apr 04, 2017 at 04:10:59PM +0100, Daniel P. Berrange wrote:
On Tue, Mar 28, 2017 at 01:46:31PM +0200, Martin Kletzander wrote:
The attribute (defined as ATTRIBUTE_NONNULL) was added long time
ago (2009), but in 2012 (commit eefb881d4683) it was disabled for
normal build, making it used o
https://bugzilla.redhat.com/show_bug.cgi?id=1420740
If the parent is not a scsi_host, then we can just happily return since
we won't be removing a vport.
Fixes a bug with the following output:
$ virsh pool-destroy host4_hba_pool
error: Failed to destroy pool host4_hba_pool
error: internal error:
There is no async job running when a freshly started libvirtd is trying
to recover from an interrupted incoming migration. While at it, let's
call qemuMigrationResetTLS every time we don't kill the domain. This is
not strictly necessary since TLS is not supported when v2 migration
protocol is used,
The news.rng file gets picked up by the wildcard match on docs/schemas,
and so gets installed into /usr/share/libvirt, along with the schemas
for our API objects. This then generated an RPM build failure, since
we don't have news.rng in the RPM file list
The news.rng schema is not something that u
On 03/31/2017 01:54 PM, Jiri Denemark wrote:
> Because of the changes done in the previous commit, @host is already a
> migratable CPU and there's no need to do any additional filtering.
>
> Signed-off-by: Jiri Denemark
> ---
> src/cpu/cpu_x86.c | 9 +++--
> 1 file changed, 3 insertions(+)
On 03/31/2017 01:54 PM, Jiri Denemark wrote:
> This will allow us to drop feature filtering from virCPUUpdate where it
> was just a hack.
>
> Signed-off-by: Jiri Denemark
> ---
> src/qemu/qemu_capabilities.c | 19 ++-
> src/qemu/qemu_capabilities.h | 3 ++-
> src/qemu/qemu_com
On 03/31/2017 01:54 PM, Jiri Denemark wrote:
> Signed-off-by: Jiri Denemark
> ---
> src/qemu/qemu_capabilities.c | 91
> ++--
> 1 file changed, 71 insertions(+), 20 deletions(-)
>
There's three patches in one here... Adding virQEMUCapsCPUModel, adding
On 03/31/2017 01:54 PM, Jiri Denemark wrote:
> We will need to store two more host CPU models and nested structs look
> better than separate items with long complicated names.
>
> Signed-off-by: Jiri Denemark
> ---
> src/qemu/qemu_capabilities.c | 65
> ++--
On 03/31/2017 01:54 PM, Jiri Denemark wrote:
> The caller can ask for a migratable CPU model by passing true for the
> new parameter.
>
> Signed-off-by: Jiri Denemark
> ---
> src/qemu/qemu_capabilities.c | 36 +---
> src/qemu/qemu_capspriv.h | 3 ++-
> test
On 03/31/2017 01:53 PM, Jiri Denemark wrote:
> Signed-off-by: Jiri Denemark
> ---
> src/qemu/qemu_capabilities.c | 25 ++---
> 1 file changed, 10 insertions(+), 15 deletions(-)
>
ACK,
John
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/
On 03/31/2017 01:53 PM, Jiri Denemark wrote:
> This new internal API makes a copy of virCPUDef while removing all
> features which would block migration. It uses cpu_map.xml as a database
> of such features, which should only be used as a fallback when we cannot
> get the data from a hypervisor.
Fixing make syntax-check broken by commit 4da534c0b9.
Signed-off-by: Boris Fiuczynski
Reviewed-by: Marc Hartmayer
Reviewed-by: Bjoern Walk
---
cfg.mk | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/cfg.mk b/cfg.mk
index 89e03ca..cc174a3 100644
--- a/cfg.mk
+++ b/cfg.mk
On Wed, Mar 29, 2017 at 02:51:10PM +0200, Erik Skultety wrote:
> This series enables the node device driver to report information about the
> existing mediated devices on the host. There is no device creation involved
> yet. The information reported by the node device driver is split into two
> par
On Wed, Mar 29, 2017 at 02:51:18PM +0200, Erik Skultety wrote:
> Start discovering the mediated devices on the host system and format the
> attributes for the child device into the XML. Compared to the parent
> device which reports generic information about the abstract mediated
> devices types, a
On Tue, Apr 04, 2017 at 04:10:59PM +0100, Daniel P. Berrange wrote:
> On Tue, Mar 28, 2017 at 01:46:31PM +0200, Martin Kletzander wrote:
> > The attribute (defined as ATTRIBUTE_NONNULL) was added long time
> > ago (2009), but in 2012 (commit eefb881d4683) it was disabled for
> > normal build, makin
On Tue, Mar 28, 2017 at 01:46:31PM +0200, Martin Kletzander wrote:
> The attribute (defined as ATTRIBUTE_NONNULL) was added long time
> ago (2009), but in 2012 (commit eefb881d4683) it was disabled for
> normal build, making it used only when coverity was building libvirt
> or on special request.
On Wed, Mar 29, 2017 at 02:51:17PM +0200, Erik Skultety wrote:
> The parent device needs to report the generic stuff about the supported
> mediated devices types, like device API, available instances, and
> description which might hold some useful data about supported
> resolutions for the type giv
On Tue, Apr 04, 2017 at 16:09:11 +0200, Andrea Bolognani wrote:
> On Tue, 2017-04-04 at 14:20 +0200, Peter Krempa wrote:
> > Naming, style and other fixes suggested by Andrea in his review. The changes
> > were too invasive so I'll rather repost it.
>
> ACK series if you take care of the comments
This patch series is a followup to Wojtek's v2 posting:
https://www.redhat.com/archives/libvir-list/2017-March/msg00838.html
It contains the fixes I pointed out in v1 / v2, along with a bunch of
updates to the event-test.py example, so we can use it to demonstrate
the asyncio impl. eg i'm using
Use the name 'Poll' instead of 'Pure' for the event loop demo,
since there's now a second pure python loop impl available.
Signed-off-by: Daniel P. Berrange
---
examples/event-test.py | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/examples/ev
The pure python event loop impl has to call
libvirt.virEventInvokeFreeCallback
to free the event opaque data from a clean stack context
Signed-off-by: Daniel P. Berrange
---
examples/event-test.py | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/examples/event-
The event test program '--loop' arg is modified to take the name
of an event loop impl to run. eg 'event-test.py --loop asyncio'
Signed-off-by: Daniel P. Berrange
---
examples/event-test.py | 50 +++---
1 file changed, 35 insertions(+), 15 deletions(-)
From: Wojtek Porczyk
The documentation says:
> If the opaque user data requires free'ing when the handle is
> unregistered, then a 2nd callback can be supplied for this purpose.
> This callback needs to be invoked from a clean stack. If 'ff'
> callbacks are invoked directly from the virEventRemov
From: Wojtek Porczyk
This is usable only on python >= 3.4 (or 3.3 with out-of-tree asyncio),
however it should be harmless for anyone with older python versions.
In simplest case, to have the callbacks queued on the default loop:
>>> import libvirtaio
>>> libvirtaio.virEventRegisterAsyn
Signed-off-by: Daniel P. Berrange
---
examples/event-test.py | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/examples/event-test.py b/examples/event-test.py
index 851c09b..751a140 100755
--- a/examples/event-test.py
+++ b/examples/event-test.py
@@ -651,15 +651,17 @@
In order to test cleanup code paths we must unregister all callbacks
and close the connection on shutdown. Since cleanup happens in the
background, we do a short sleep to allow the main loop to run its
cleanup too.
Signed-off-by: Daniel P. Berrange
---
examples/event-test.py | 95 +++
On Fri, Mar 17, 2017 at 02:35:53PM +0100, Wojtek Porczyk wrote:
> This is usable only on python >= 3.4 (or 3.3 with out-of-tree asyncio),
> however it should be harmless for anyone with older python versions.
>
> In simplest case, to have the callbacks queued on the default loop:
>
> >>> impo
On Wed, Mar 29, 2017 at 02:51:16PM +0200, Erik Skultety wrote:
> Besides updating the capability enum, this patch introduces
> 'virNodeDevCapMdev' structure which will store everything libvirt can
> gather from sysfs about a mediated device. Since we need to report the
> info for both the mediated
On Tue, 2017-04-04 at 14:20 +0200, Peter Krempa wrote:
> Naming, style and other fixes suggested by Andrea in his review. The changes
> were too invasive so I'll rather repost it.
ACK series if you take care of the comments to patch 3/5.
Another respin should not be necessary.
--
Andrea Bolognan
On Tue, 2017-04-04 at 14:20 +0200, Peter Krempa wrote:
[...]
> +struct testGlusterLookupParseData {
Now that the test function has been renamed, the data
struct should be renamed to match as well.
> +const char *srcxml;
> +const char *dstxml;
> +int type;
This should be virStoragePoo
On Tue, Apr 04, 2017 at 02:51:19PM +0100, Daniel P. Berrange wrote:
On Tue, Apr 04, 2017 at 03:46:36PM +0200, Martin Kletzander wrote:
So I just created v3.2-maint with one rather important back-port.
This is what I would've pushed with it, but I'd rather know the
opinions on whether one or both
qemu requires that the topology equals to the maximum vcpu count.
Document this along with the API to set maximum vcpu count and the XML
element.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1426220
---
docs/formatdomain.html.in | 5 -
src/libvirt-domain.c | 3 ++-
tools/virsh.p
On Tue, Apr 04, 2017 at 03:46:36PM +0200, Martin Kletzander wrote:
> So I just created v3.2-maint with one rather important back-port.
> This is what I would've pushed with it, but I'd rather know the
> opinions on whether one or both ideas are stupid. Thanks.
So, the website only publishes news.
Signed-off-by: Martin Kletzander
---
configure.ac | 2 +-
docs/news.xml | 7 +++
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 08051d53aa0a..693791c6015d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -16,7 +16,7 @@ dnl You should have recei
So I just created v3.2-maint with one rather important back-port.
This is what I would've pushed with it, but I'd rather know the
opinions on whether one or both ideas are stupid. Thanks.
Martin Kletzander (2):
Maintenance branch version bump
docs: Add vz driver typo fix to news.xml
config
Signed-off-by: Martin Kletzander
---
docs/news.xml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/docs/news.xml b/docs/news.xml
index 5aeec5fc49ae..cad3f68019a2 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -35,7 +35,9 @@
-
+
+
On Tue, Apr 04, 2017 at 11:59:20AM +0200, Michal Privoznik wrote:
> On 04/04/2017 11:56 AM, Daniel P. Berrange wrote:
> > On Tue, Apr 04, 2017 at 09:42:47AM +0200, Michal Privoznik wrote:
> > > On 04/04/2017 09:27 AM, Jiri Denemark wrote:
> > > > On Tue, Apr 04, 2017 at 09:24:41 +0200, Michal Privo
On Wed, Mar 29, 2017 at 02:51:15PM +0200, Erik Skultety wrote:
> Since we do have this template at hand, why not using it wherever
> possible. Also, just to be grammatically correct, let's use singular,
> aka 'pool' instead of plural in the enumerated list of supported types.
>
> Signed-off-by: Er
On 04.04.2017 15:46, Martin Kletzander wrote:
> On Tue, Apr 04, 2017 at 01:02:21PM +0300, Nikolay Shirokovskiy wrote:
>> ---
>>
>> I guess it should be back ported to 3.2.0 release too. Sorry that
>> we missed this during freeze period.
>>
>
> I'm really sorry for that. I thought I'm building w
On Tue, Apr 04, 2017 at 01:02:21PM +0300, Nikolay Shirokovskiy wrote:
---
I guess it should be back ported to 3.2.0 release too. Sorry that
we missed this during freeze period.
I'm really sorry for that. I thought I'm building with VZ, but the
driver renaming and names are confusing, so I gu
On 04/04/2017 08:29 AM, Jiri Denemark wrote:
> On Tue, Apr 04, 2017 at 07:53:55 -0400, John Ferlan wrote:
>>
>>
>> On 04/04/2017 06:48 AM, Jiri Denemark wrote:
>>> Jumping to "endjob" label from a code after this label is not a very
>>> good idea.
>>>
>>> Signed-off-by: Jiri Denemark
>>> ---
>>>
On Tue, Apr 04, 2017 at 07:53:55 -0400, John Ferlan wrote:
>
>
> On 04/04/2017 06:48 AM, Jiri Denemark wrote:
> > Jumping to "endjob" label from a code after this label is not a very
> > good idea.
> >
> > Signed-off-by: Jiri Denemark
> > ---
> > src/qemu/qemu_migration.c | 4 +---
> > 1 file
For native gluster pools the field denotes a directory inside the
pool. For the actual pool name the field has to be used.
---
src/storage/storage_util.c | 16 ++--
tests/virstorageutildata/gluster-parse-basic-native.xml | 3 ++-
.../virstorageutildata
The native gluster pool source list data differs from the data used for
attaching gluster volumes as netfs pools. Currently the only difference
was the format. Since native pools don't use it and later there will be
more differences add a more deterministic way to switch between the
types instead.
To allow testing of the algorithm, split out the extractor into a
separate helper.
---
src/storage/storage_util.c | 95 +++---
src/storage/storage_util.h | 4 ++
2 files changed, 59 insertions(+), 40 deletions(-)
diff --git a/src/storage/storage_util.c b/s
Naming, style and other fixes suggested by Andrea in his review. The changes
were too invasive so I'll rather repost it.
Peter Krempa (5):
storage: util: Pass pool type to
virStorageBackendFindGlusterPoolSources
storage: util: Split out the gluster volume extraction code into new
funct
Use the relative lookup specifier rather than the global one. Otherwise
only the first name would be looked up. Add a test case to cover the
scenario.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1436574
---
src/storage/storage_util.c | 2 +-
.../gluster-parse-mu
Add a test program called virstorageutiltest and test the gluster pool
detection code.
---
tests/Makefile.am | 16 ++-
.../gluster-parse-basic-native.xml | 6 ++
.../gluster-parse-basic-netfs.xml | 7 ++
.../virstorageutildata/
On Tue, 2017-04-04 at 12:57 +0200, Ján Tomko wrote:
> Introduce STRICT_FRAME_LIMIT_CFLAGS that will be used for
> the library code and RELAXED_FRAME_LIMIT_CFLAGS for daemon code
> and the test code.
>
> Raising the limit for tests allows building them with clang
> with optimizations disabled.
I'd
On Tue, 2017-04-04 at 12:57 +0200, Ján Tomko wrote:
> Similar to commit b202c39 ignore the warning that breaks the build
> with clang:
> util/virnetlink.c:365:52: error: cast from 'char *' to 'struct nlmsghdr *'
> increases required alignment from 1 to 4 [-Werror,-Wcast-align]
> for (msg =
On Tue, 2017-04-04 at 13:50 +0200, Peter Krempa wrote:
> > > +#undef DO_TEST_GLUSTER_LOOKUP_NATIVE
> > > +#undef DO_TEST_GLUSTER_LOOKUP_NETFS
> > > +#undef DO_TEST_GLUSTER_LOOKUP_FULL
> >
> > The #undefs are a bit unnecessary in this context, I'd leave
> > them out.
>
> It's true that it would be
On Fri, Mar 17, 2017 at 02:35:53PM +0100, Wojtek Porczyk wrote:
> +class Callback(object):
> +'''Base class for holding callback
> +
> +:param virEventAsyncIOImpl impl: the implementation in which we run
> +:param cb: the callback itself
> +:param opaque: the opaque tuple passed by
On 04/04/2017 06:48 AM, Jiri Denemark wrote:
> Jumping to "endjob" label from a code after this label is not a very
> good idea.
>
> Signed-off-by: Jiri Denemark
> ---
> src/qemu/qemu_migration.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
D'oh... Not sure if it's too late,
On Fri, Mar 24, 2017 at 09:25:11PM +0100, Wojtek Porczyk wrote:
> On Fri, Mar 17, 2017 at 02:35:15PM +0100, Wojtek Porczyk wrote:
> > This is second attempt at merging libvirtaio, an event loop implementation
> > which dispatches the callbacks via asyncio's event loop.
>
> Hi, libvirt-list,
>
> A
On Mon, Apr 03, 2017 at 17:03:43 +0200, Andrea Bolognani wrote:
> On Thu, 2017-03-30 at 17:12 +0200, Peter Krempa wrote:
[...]
> > +virstorageutiltest_LDADD = \
> > + ../src/libvirt_driver_storage_impl.la \
> > + $(LDADDS) \
> > + $(NULL)
> > +
[...]
> You should also be able to use $(qem
On Tue, Apr 04, 2017 at 12:57:59PM +0200, Ján Tomko wrote:
> Introduce STRICT_FRAME_LIMIT_CFLAGS that will be used for
> the library code and RELAXED_FRAME_LIMIT_CFLAGS for daemon code
> and the test code.
>
> Raising the limit for tests allows building them with clang
> with optimizations disable
On Tue, Apr 04, 2017 at 12:48:31PM +0200, Jiri Denemark wrote:
> Jumping to "endjob" label from a code after this label is not a very
> good idea.
>
> Signed-off-by: Jiri Denemark
> ---
> src/qemu/qemu_migration.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
ACK
Pavel
signature
Introduce STRICT_FRAME_LIMIT_CFLAGS that will be used for
the library code and RELAXED_FRAME_LIMIT_CFLAGS for daemon code
and the test code.
Raising the limit for tests allows building them with clang
with optimizations disabled.
---
daemon/Makefile.am | 3 +++
m4/virt-compile-warnings.m
Hopefully, the split of library/non-library code will let us
tighten the frame limit in the future.
Ján Tomko (2):
util: ignore -Wcast-align in virNetlinkDumpCommand
Split out -Wframe-larger-than warning from WARN_CLFAGS
daemon/Makefile.am | 3 +++
m4/virt-compile-warnings.m4 | 4 ++
Similar to commit b202c39 ignore the warning that breaks the build
with clang:
util/virnetlink.c:365:52: error: cast from 'char *' to 'struct nlmsghdr *'
increases required alignment from 1 to 4 [-Werror,-Wcast-align]
for (msg = resp; NLMSG_OK(msg, len); msg = NLMSG_NEXT(msg, len)) {
Jumping to "endjob" label from a code after this label is not a very
good idea.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_migration.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
index 87d7dcd0c..7f00a3d93 10064
---
I guess it should be back ported to 3.2.0 release too. Sorry that
we missed this during freeze period.
src/vz/vz_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c
index bb1afd0..da83a8f 100644
--- a/src/vz/vz_driver.c
+++ b/s
On Tue, Apr 04, 2017 at 10:52:39 +0100, Daniel Berrange wrote:
> On Tue, Apr 04, 2017 at 09:12:11AM +0200, Peter Krempa wrote:
> > On Tue, Apr 04, 2017 at 09:05:58 +0200, Ján Tomko wrote:
> > > Similar to commit c3c2cc6, use a literal newsline instead of \n
> > > inside the brackets.
> > > ---
> >
On 04/04/2017 11:56 AM, Daniel P. Berrange wrote:
On Tue, Apr 04, 2017 at 09:42:47AM +0200, Michal Privoznik wrote:
On 04/04/2017 09:27 AM, Jiri Denemark wrote:
On Tue, Apr 04, 2017 at 09:24:41 +0200, Michal Privoznik wrote:
The symbol was introduced in the 3.2.0 release (bb09798fbeb5f)
and no
On Tue, Apr 04, 2017 at 09:42:47AM +0200, Michal Privoznik wrote:
> On 04/04/2017 09:27 AM, Jiri Denemark wrote:
> > On Tue, Apr 04, 2017 at 09:24:41 +0200, Michal Privoznik wrote:
> > > The symbol was introduced in the 3.2.0 release (bb09798fbeb5f)
> > > and not 3.1.0 release as its current placem
On Tue, Apr 04, 2017 at 09:27:42AM +0200, Jiri Denemark wrote:
> On Tue, Apr 04, 2017 at 09:24:41 +0200, Michal Privoznik wrote:
> > The symbol was introduced in the 3.2.0 release (bb09798fbeb5f)
> > and not 3.1.0 release as its current placement in the file
> > suggests.
> >
> > Signed-off-by: Mi
On Tue, Apr 04, 2017 at 09:12:11AM +0200, Peter Krempa wrote:
> On Tue, Apr 04, 2017 at 09:05:58 +0200, Ján Tomko wrote:
> > Similar to commit c3c2cc6, use a literal newsline instead of \n
> > inside the brackets.
> > ---
> > Pushed as a build fix.
>
> This is ugly. How about dropping support for
On 04/04/2017 09:27 AM, Jiri Denemark wrote:
On Tue, Apr 04, 2017 at 09:24:41 +0200, Michal Privoznik wrote:
The symbol was introduced in the 3.2.0 release (bb09798fbeb5f)
and not 3.1.0 release as its current placement in the file
suggests.
Signed-off-by: Michal Privoznik
---
src/libvirt_publ
On Tue, Apr 04, 2017 at 09:24:41 +0200, Michal Privoznik wrote:
> The symbol was introduced in the 3.2.0 release (bb09798fbeb5f)
> and not 3.1.0 release as its current placement in the file
> suggests.
>
> Signed-off-by: Michal Privoznik
> ---
> src/libvirt_public.syms | 6 +-
> 1 file chang
On Mon, 2017-04-03 at 17:54 +0100, Daniel P. Berrange wrote:
> >
> >
> >
> > -
> > -
> > -\n[^\n]+\n +
> > -
> > -
> > -
> > +
> > + \n[^\n]+\n +
> > +
> >
> >
> >
>
> FYI
The symbol was introduced in the 3.2.0 release (bb09798fbeb5f)
and not 3.1.0 release as its current placement in the file
suggests.
Signed-off-by: Michal Privoznik
---
src/libvirt_public.syms | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/libvirt_public.syms b/src/l
On Mon, Apr 03, 2017 at 12:53:30PM -0400, John Ferlan wrote:
> There's more, but many are false positives and there's also a couple
> more that I have to think more deeply about...
ACK series
Pavel
signature.asc
Description: Digital signature
--
libvir-list mailing list
libvir-list@redhat.com
h
On Mon, Apr 03, 2017 at 18:24:59 -0400, John Ferlan wrote:
>
>
> On 03/31/2017 07:52 AM, Peter Krempa wrote:
> > Validate that users don't try to disable vcpu 0 and reject attempt to
> > modify a vcpu to the state it is currently in.
> > ---
> > src/qemu/qemu_hotplug.c | 36 +
On Tue, Apr 04, 2017 at 09:05:58 +0200, Ján Tomko wrote:
> Similar to commit c3c2cc6, use a literal newsline instead of \n
> inside the brackets.
> ---
> Pushed as a build fix.
This is ugly. How about dropping support for platforms which can't use
new enough libraries rather than band-aiding the c
Similar to commit c3c2cc6, use a literal newsline instead of \n
inside the brackets.
---
Pushed as a build fix.
docs/schemas/news.rng | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/docs/schemas/news.rng b/docs/schemas/news.rng
index ec4313f..a633e22 100644
--- a/docs/schem
99 matches
Mail list logo
