Hi Cédric,
您好 ：）
I'm sorry that I missed the mail.
But currently I can not reproduce it.
For the error by net-create, it is executed when I set accept_ra to 1.
I have just test on libvirt-3.2.0-4.el7.x86_64, the behavior changes, it
seems like there is no check for accept_ra before start a networ
From: Wim ten Have
When running on a NUMA machine, populate the sibling node
and distance information using data supplied by Xen.
With locality distances information, under Xen, new host
capabilities would like:
263902380
From: Wim ten Have
When running on a NUMA machine, populate the sibling node
and distance information using data supplied by Xen.
Wim ten Have (1):
libxl: report numa sibling distances on host capabilities
src/libxl/libxl_capabilities.c | 19 +--
1 file changed, 17 insertions
On 05/09/2017 07:58 AM, Daniel P. Berrange wrote:
Opps, yes, mixed terminology. You're right - virsh is lacking this
feature. Feel free to send a patch to add a '--io' flag to the
attach-disk command if you want to try fixing this.
That's what my original message contained. :)
--
libvir-list
On 05/09/2017 11:57 AM, Andrea Bolognani wrote:
> On Thu, 2017-05-04 at 20:08 -0400, Cole Robinson wrote:
>> New maint release version numbers of just A.B.C format, not the old
>> A.B.C.D format. Adjust the check that dynamically changes the Source
>> URL for maint releases
>> ---
>> libvirt.spec
ping?
NB: In the virInterfaceObjList patch, I've added a
VIR_FREE(interfaces->objs); to virInterfaceObjListFree. It should be
obvious why...
Tks -
John
On 04/25/2017 06:36 PM, John Ferlan wrote:
> Sensing a theme lately yet?
>
> More adjustments in preparation for having virobject code handle
ping?
Tks -
John
On 04/29/2017 11:36 AM, John Ferlan wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1420740
>
> Testing found an inventive way to cause an error at shutdown by providing the
> parent name for the fc host creation using the "same name" as the HBA. Since
> the code thus assu
On Thu, 2017-05-04 at 20:08 -0400, Cole Robinson wrote:
> New maint release version numbers of just A.B.C format, not the old
> A.B.C.D format. Adjust the check that dynamically changes the Source
> URL for maint releases
> ---
> libvirt.spec.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion
On Thu, 2017-05-04 at 20:08 -0400, Cole Robinson wrote:
> New maint release version numbers of just A.B.C format, not the old
> A.B.C.D format. Adjust the check that dynamically changes the Source
> URL for maint releases
> ---
> libvirt.spec.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion
On Tue, May 09, 2017 at 05:44:14PM +0200, Jiri Denemark wrote:
> Signed-off-by: Jiri Denemark
> ---
> src/conf/cpu_conf.c | 10 ++
> 1 file changed, 10 insertions(+)
>
> diff --git a/src/conf/cpu_conf.c b/src/conf/cpu_conf.c
> index 1b098c476..194f03faf 100644
> --- a/src/conf/cpu_conf.c
On Mon, May 08, 2017 at 15:37:24 +0100, Daniel P. Berrange wrote:
> On Tue, Apr 25, 2017 at 08:48:44PM +0200, Jiri Denemark wrote:
> > This patch introduces
> >
> >
> >
> >
> >
> > sub element of /domain/cpu. Currently only a single element is
> > allowed.
> >
> > Signed-off-by:
Signed-off-by: Jiri Denemark
---
src/conf/cpu_conf.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/src/conf/cpu_conf.c b/src/conf/cpu_conf.c
index 1b098c476..194f03faf 100644
--- a/src/conf/cpu_conf.c
+++ b/src/conf/cpu_conf.c
@@ -915,6 +915,16 @@ virCPUDefIsEqual(virCPUDefPtr s
Create/Use API to "walk" the storage pool object volume list.
Signed-off-by: John Ferlan
---
src/conf/virstorageobj.c | 10 ++
src/conf/virstorageobj.h | 4
src/libvirt_private.syms | 1 +
src/storage/storage_backend_disk.c | 26 +++---
For consistency sake - use @obj as the variable name.
Signed-off-by: John Ferlan
---
src/storage/storage_util.c | 106 ++---
src/storage/storage_util.h | 30 ++---
2 files changed, 68 insertions(+), 68 deletions(-)
diff --git a/src/storage/storag
In preparation for privatizing the object, use the accessors.
Perform some minor code cleanup along the w/r/t spacing, line wraps, etc.
Signed-off-by: John Ferlan
---
src/storage/storage_util.c | 116 -
1 file changed, 63 insertions(+), 53 deletions(-
In preparation for privatizing the object, use the accessors.
Perform some minor code cleanup along the w/r/t spacing, line wraps, etc.
Signed-off-by: John Ferlan
---
src/storage/storage_driver.c | 426 ---
1 file changed, 242 insertions(+), 184 deletions
The virStoragePoolObjDeleteDef already dealt with the configFile - just
add in the autostartLink as well. If there is no autostartLink defined,
then no need to attempt unlink - which also allows removal of one errno
check in moved function.
Signed-off-by: John Ferlan
---
src/conf/virstorageobj.c
A virStoragePoolObjPtr will be an 'obj'.
A virStoragePoolPtr will be a 'pool'.
NB: Also modify the @matchpool to @matchobj.
Signed-off-by: John Ferlan
---
src/conf/virstorageobj.c | 342 +++
src/conf/virstorageobj.h | 20 +--
2 files changed, 180 ins
In preparation for privatizing the object, use the accessors.
Perform some minor code cleanup along the w/r/t spacing, line wraps, etc.
Signed-off-by: John Ferlan
---
src/test/test_driver.c | 186 -
1 file changed, 107 insertions(+), 79 deletions(
Create/use a helper to perform object allocation.
Signed-off-by: John Ferlan
---
src/conf/virstorageobj.c | 34 +++---
1 file changed, 23 insertions(+), 11 deletions(-)
diff --git a/src/conf/virstorageobj.c b/src/conf/virstorageobj.c
index 7d6b311..0079472 100644
---
Rather than have the logic in the storage driver, move it to virstorageobj.
NB: virStoragePoolObjGetAutostart can take liberties with not needing the
same if...else construct. Also pass a NULL for testStoragePoolSetAutostart
to avoid the autostartLink setup using the autostartDir for the test dri
Alter the virStoragePoolObjNumOfVolumes, virStoragePoolObjVolumeGetNames,
and virStoragePoolObjVolumeListExport APIs to take a virStoragePoolObjPtr
instead of the &obj->volumes and obj->def.
Signed-off-by: John Ferlan
---
src/conf/virstorageobj.c | 15 +--
src/conf/virstorageobj.
Rather than have repetitive code - create/use a couple of helpers:
testStoragePoolObjFindActiveByName and testStoragePoolObjFindInactiveByName
This will also allow for the reduction of some cleanup path logic.
Signed-off-by: John Ferlan
---
src/test/test_driver.c | 256 +---
In preparation for making a private object, create accessor API's for
consumer storage functions to use:
virStoragePoolObjGetDef
virStoragePoolObjGetNewDef
virStoragePoolObjStealNewDef
virStoragePoolObjGetConfigFile
virStoragePoolObjSetConfigFile
virStoragePoolObjIsActive
Use the < 0 rather than == -1 (consistently) for virAsprintf errors.
Signed-off-by: John Ferlan
---
src/storage/storage_backend_logical.c | 2 +-
src/storage/storage_backend_rbd.c | 8
src/storage/storage_backend_sheepdog.c | 4 ++--
src/storage/storage_backend_zfs.c | 4 ++--
A virStoragePoolObjPtr will be an 'obj'.
A virStoragePoolPtr will be a 'pool'.
A virStorageVolPtr will be a 'vol'.
A virStorageVolDefPtr will be a 'voldef'.
Signed-off-by: John Ferlan
---
src/storage/storage_driver.c | 1158 +-
src/storage/storage_drive
Rework some of the test driver API's to remove the need to return failure
when testStoragePoolObjFindByName returns NULL rather than going to cleanup.
This removes the need for check for "if (obj)" and in some instances the
need to for a cleanup label and a local ret variable.
Signed-off-by: John
Remove repetitive code, replace with common function.
Signed-off-by: John Ferlan
---
src/test/test_driver.c | 56 +++---
1 file changed, 21 insertions(+), 35 deletions(-)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index 9918df6..460a
Create/use virStoragePoolObjAddVol in order to add volumes onto list.
Create/use virStoragePoolObjRemoveVol in order to remove volumes from list.
Create/use virStoragePoolObjGetVolumesCount to get count of volumes on list.
For the storage driver, the logic alters when the volumes.obj list grows
A virStoragePoolObjPtr will be an 'obj'.
A virStoragePoolPtr will be a 'pool'.
Signed-off-by: John Ferlan
---
src/test/test_driver.c | 443 -
1 file changed, 219 insertions(+), 224 deletions(-)
diff --git a/src/test/test_driver.c b/src/test/test_
Begin the process of making adjustments to the storage pool and volume code
in order to privatize the virStoragePoolObj and virStoragePoolObjList
Didn't want to post 40+ patches at one time... This is the first storage
pile including some test driver cleanups w/r/t storage code.
John Ferlan (19)
Fix some spacing/formatting in the storage pool/vol test driver code.
Signed-off-by: John Ferlan
---
src/test/test_driver.c | 37 +++--
1 file changed, 31 insertions(+), 6 deletions(-)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index 2db3f7d..54
On Tue, May 09, 2017 at 07:51:00AM -0700, Gordon Messmer wrote:
> On 05/09/2017 07:38 AM, Daniel P. Berrange wrote:
> > I think you can use the --iothread flag to "virsh attach-disk" to set
> > this parameter. virsh doesn't set it if not specified, since it tries
> > to avoid making policy decision
On 05/09/2017 07:38 AM, Daniel P. Berrange wrote:
I think you can use the --iothread flag to "virsh attach-disk" to set
this parameter. virsh doesn't set it if not specified, since it tries
to avoid making policy decisions, like virt-manager/virt-install do
That option sets the iothread attrib
On Tue, May 09, 2017 at 07:31:30AM -0700, Gordon Messmer wrote:
> (Apparently I managed to screw up sending that, twice. Long weekend.)
No problem. Your first posting got blocked into the moderator queue
since you weren't a subscriber. One of the list admins then approved
it, not realizing you h
(Apparently I managed to screw up sending that, twice. Long weekend.)
Please consider adding the option of setting the "io" attribute when
attaching disks to guests. Under Red Hat (unsure if this is true under
vanilla libvirt), virt-install and virt-manager both default to
explicitly settin
On Tue, 2017-05-09 at 05:04 -0400, Kothapally Madhu Pavan wrote:
> As POWER9 model is not available in cpu_map.xml virsh capabilities
> donot display the cpu model and vendor details. This patch
> provides those details
> ---
> src/cpu/cpu_map.xml |5 +
> 1 file changed, 5 insertions(+)
A
On Wed, Apr 26, 2017 at 04:55:33PM +0200, Erik Skultety wrote:
> Signed-off-by: Erik Skultety
> ---
> docs/drvnodedev.html.in | 164
> +++-
> 1 file changed, 163 insertions(+), 1 deletion(-)
s/3.3.0/3.4.0/ for the whole patch.
Please add the "mdev" c
On Wed, Apr 26, 2017 at 04:55:31PM +0200, Erik Skultety wrote:
> The parent device needs to report the generic stuff about the supported
> mediated devices types, like device API, available instances, type name,
> etc. Therefore this patch introduces a new nested capability element of
> type 'mdev_
If __lxstat() and __xstat() functions are not available, build fails with:
CC virfilewrapper.o
virfilewrapper.c:180:5: error: no previous prototype for function '__lxstat'
[-Werror,-Wmissing-prototypes]
int __lxstat(int ver, const char *path, struct stat *sb)
^
virfilewrapper.c:208:5:
On Wed, Apr 26, 2017 at 04:55:29PM +0200, Erik Skultety wrote:
> Since there's at least SRIOV and MDEV sub-capabilities to be parsed,
> let's make the code more readable by splitting it to several logical
> blocks.
>
> Signed-off-by: Erik Skultety
> ---
> src/conf/node_device_conf.c | 130
> +++
The code is already prepared to handle the non-existence of it.
Signed-off-by: Martin Kletzander
---
Pushed under the build-breaker rule.
src/util/virhostcpu.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/util/virhostcpu.c b/src/util/virhostcpu.c
index 317c52410
Connect domain XML configuration (introduced in a
previous patch) to bhyve command generation.
Unfortunately, this option was documented just recently and at the time
of writing official online manpages didn't have it updated, so for now
one can refer to:
https://github.com/freebsd/freebsd/blob/
Add support for video driver configuration. In domain xml it looks like
this:
At present, the only supported configuration is 'vgaconf' that looks this way:
It was added with bhyve gop video in mind to allow users control how the
video device is exposed to the guest, spe
Sorry for the strange splitting of this (supposed-to-be) series,
apparently I have something weird happening on my system so
git-send-email authenticates only when sending the first patch :-(
Roman Bogorodskiy
signature.asc
Description: PGP signature
--
libvir-list mailing list
libvir-list@redha
Signed-off-by: Roman Bogorodskiy
---
tests/bhyvexml2xmloutdata/bhyvexml2xmlout-vnc.xml | 41 +++
tests/bhyvexml2xmltest.c | 3 +-
2 files changed, 43 insertions(+), 1 deletion(-)
create mode 100644 tests/bhyvexml2xmloutdata/bhyvexml2xmlout-vnc.xml
d
On Mon, 2017-05-08 at 09:16 +0200, Przemysław Sztoch wrote:
> Dear Michal and Pavel,
>
> We cover about 100 clients who have their own and simple CentOS KVM
> installations.
> Their technical skills are far from writing python scripts. They expect
> simple solutions.
They don't necessarily have
On Wed, 2017-05-03 at 16:05 +0200, Ján Tomko wrote:
> Add a new element with a driver attribute.
>
> Possible values are qemu and kvm. With 'qemu', the I/O
> APIC can be put in the userspace even for KVM domains.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1427005
> ---
> docs/formatdomain.
The metadata libvirt cares about is identical for version 3
as for previous versions, so we merely need list the new
version number.
Signed-off-by: Daniel P. Berrange
---
src/util/virstoragefile.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/util/virstoragefile.c b
On Mon, May 08, 2017 at 10:56:47AM +0100, Daniel P. Berrange wrote:
> A previous commit changed the spec to use librbd1-devel on
> RHEL-7, since this replaces ceph-devel from RHEL-6:
>
> commit 6cfc8834c858849cc74c3082078dc91fb1cbae38
> Author: Peter Krempa
> Date: Thu Mar 5 11:40:54 2015
On Tue, May 09, 2017 at 11:12:24AM +0200, Michal Privoznik wrote:
> On 05/09/2017 11:01 AM, Daniel P. Berrange wrote:
> > On Fri, Mar 31, 2017 at 10:23:33AM +0200, Peter Krempa wrote:
> >> On Fri, Mar 31, 2017 at 03:57:41 -0400, Dan wrote:
> >>> Hi all,
> >>>
> >>> I have seen libxml2 has already b
On 05/09/2017 11:01 AM, Daniel P. Berrange wrote:
> On Fri, Mar 31, 2017 at 10:23:33AM +0200, Peter Krempa wrote:
>> On Fri, Mar 31, 2017 at 03:57:41 -0400, Dan wrote:
>>> Hi all,
>>>
>>> I have seen libxml2 has already been added as a project in oss-fuzz [1].
>>> Any idea about libvirt? While we c
As POWER9 model is not available in cpu_map.xml virsh capabilities
donot display the cpu model and vendor details. This patch
provides those details
---
src/cpu/cpu_map.xml |5 +
1 file changed, 5 insertions(+)
diff --git a/src/cpu/cpu_map.xml b/src/cpu/cpu_map.xml
index 7d5540a..29b5b59
On Fri, Mar 31, 2017 at 10:23:33AM +0200, Peter Krempa wrote:
> On Fri, Mar 31, 2017 at 03:57:41 -0400, Dan wrote:
> > Hi all,
> >
> > I have seen libxml2 has already been added as a project in oss-fuzz [1].
> > Any idea about libvirt? While we could do our own fuzzing of some form, do
> > we want
FYI your replies to messages on the list are almost impossible
to read & understand.
Your email client is sending HTML and badly mangled plain text.
Please make it send plain text only to public mailing lists,
with line wrapping and sensibly trim & quote text you are
replying to.
I can't see any
On 05/05/2017 05:43 PM, John Ferlan wrote:
>
>
> On 04/20/2017 06:01 AM, Michal Privoznik wrote:
>> Whenever server sends a client stream packet (either regular with
>> actual data or stream skip one) it is queued on @st->rx. So the
>> list is a mixture of both types of stream packets. So now tha
On Mon, May 08, 2017 at 09:16:26AM +0200, Przemysław Sztoch wrote:
> Dear Michal and Pavel,
>
> We cover about 100 clients who have their own and simple CentOS KVM
> installations.
> Their technical skills are far from writing python scripts. They expect
> simple solutions.
Libvirt is an librar
Hi Venkat,
Congratulations for being selected! I look forward to count you as
a new regular contributor of the libvirt community.
--
Cedric
On Sat, 2017-05-06 at 09:01 +0530, Venkat Datta wrote:
> Hi Team,
>
> I'm an undergraduate student studying Computer Science at PES University ,
> India .
Signed-off-by: Erik Skultety
---
Pushed as trivial.
configure.ac | 2 +-
docs/news.xml | 8
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 0b564a030..3329b1781 100644
--- a/configure.ac
+++ b/configure.ac
@@ -16,7 +16,7 @@ dnl You shoul
59 matches
Mail list logo
