[libvirt] [PATCH v2] qemu: reduce packet loss rate for vm with macvtap passthrough mode in migration

Before libvirt that calls virNetDevMacVLanCreateWithVPortProfile sets mac address or vlan of a Virtual Function(VF) linked to a macvtap passthrough device of migration destination host in migration start step. If we ping the migrating vm, we get the network does not pass. Because VFs of

[libvirt] [PATCH] qemu: reduce packet loss rate for vm with macvtap passthrough mode in migration

Before libvirt that calls virNetDevMacVLanCreateWithVPortProfile sets mac address or vlan of a Virtual Function(VF) linked to a macvtap passthrough device of migration destination host in migration start step. If we ping the migrating vm, we get the network does not pass. Because VFs of

Re: [libvirt] [PATCH] storage: use 0711 as the default perms for dirs

On 05/11/2017 04:31 AM, Christian Ehrhardt wrote: > From: Serge Hallyn > > There should be no need to make dir based pools world readable. > So use 0711, not 0755, as the default perms for storage dirs. > > Signed-off-by: Christian Ehrhardt

Re: [libvirt] [PATCH v2] Detect VMDK version 3 files

On 05/09/2017 06:58 AM, Daniel P. Berrange wrote: > The metadata libvirt cares about is identical for version 3 > as for previous versions, so we merely need list the new > version number. > > Signed-off-by: Daniel P. Berrange > --- > src/util/virstoragefile.c | 4 ++-- >

Re: [libvirt] [PATCH] Add "io" option to virsh attach-disk sub-command.

Thank you for the guidance. I'll send a new patch ASAP. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] Add "io" option to virsh attach-disk sub-command.

On 05/07/2017 05:44 PM, Gordon Messmer wrote: > --- > tools/virsh-domain.c | 14 +++--- > tools/virsh.pod | 2 ++ > 2 files changed, 13 insertions(+), 3 deletions(-) > Well for some reason I cannot apply this patch using "git am -3"... I think what you should do is rebase to

Re: [libvirt] [PATCH] Add "io" option to virsh attach-disk sub-command.

On 05/09/2017 09:19 AM, Gordon Messmer wrote: On 05/09/2017 07:58 AM, Daniel P. Berrange wrote: Opps, yes, mixed terminology. You're right - virsh is lacking this feature. Feel free to send a patch to add a '--io' flag to the attach-disk command if you want to try fixing this. Following up:

Re: [libvirt] [PATCH 1/2] spec: Support maintenance releases on mingw

On Thu, May 11, 2017 at 06:41:07PM +0200, Andrea Bolognani wrote: > The regular spec file contains code to deal with the fact > that maintenance releases are uploaded to their own > directory: copy it over to the mingw spec file so that it's > possible to build maintenance releases there as well.

[libvirt] [PATCH 2/2] spec: Use HTTPS instead of HTTP

libvirt.org supports HTTPS, so might as well use it. Signed-off-by: Andrea Bolognani --- libvirt.spec.in | 4 ++-- mingw-libvirt.spec.in | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index f069791..ff090b3

[libvirt] [PATCH 0/2] spec: Minor improvements

*** BLURBY MCBLURBFACE *** Andrea Bolognani (2): spec: Support maintenance releases on mingw spec: Use HTTPS instead of HTTP libvirt.spec.in | 4 ++-- mingw-libvirt.spec.in | 8 ++-- 2 files changed, 8 insertions(+), 4 deletions(-) -- 2.7.4 -- libvir-list mailing list

[libvirt] [PATCH 1/2] spec: Support maintenance releases on mingw

The regular spec file contains code to deal with the fact that maintenance releases are uploaded to their own directory: copy it over to the mingw spec file so that it's possible to build maintenance releases there as well. This also switches the source URL from FTP to HTTP for consistency with

[libvirt] [PATCH 2/2] qemu: improve detection of UNIX path generated by libvirt

Currently we consider all UNIX paths with specific prefix as generated by libvirt, but that's a wrong assumption. Let's make the detection better by actually checking whether the whole path matches one of the paths that we generate or generated in the past. Resolves:

[libvirt] [PATCH 1/2] util: introduce virStringMatch

Simply tries to match the provided regex on a string and returns the result. Useful if caller don't care about the matched substring and want to just test if some pattern patches a string. Signed-off-by: Pavel Hrdina --- src/libvirt_private.syms | 1 + src/util/virstring.c

[libvirt] [PATCH 0/2] improve detection of UNIX path generated by libvirt

Pavel Hrdina (2): util: introduce virStringMatch qemu: improve detection of UNIX path generated by libvirt src/libvirt_private.syms | 1 + src/qemu/qemu_domain.c | 78 +++--- src/util/virstring.c

[libvirt] [PATCH 0/2] Fix issue with attempting to use polkit

The "issue" is when using a remote URI and authn when attempting to connect to the local system when a local URI and usage of pkttyagent was "expected" for local authn. The current bug is: https://bugzilla.redhat.com/show_bug.cgi?id=1374126 which was "forked off" from:

[libvirt] [PATCH 2/2] virsh: Don't attempt polkit processing for non local authn/authz

https://bugzilla.redhat.com/show_bug.cgi?id=1374126 Due to how the processing for authentication using polkit works, the virshConnect code must first "attempt" an virConnectOpenAuth and then check for a "special" return error code VIR_ERR_AUTH_UNAVAILABLE in order to attempt to "retry" the

[libvirt] [PATCH 1/2] virsh: Track when create pkttyagent

https://bugzilla.redhat.com/show_bug.cgi?id=1374126 Due to how the processing for authentication using polkit works, the virshConnect code must first "attempt" an virConnectOpenAuth and then check for a "special" return error code VIR_ERR_AUTH_UNAVAILABLE in order to attempt to "retry" the

Re: [libvirt] [PATCH 1/1] Enable Travis CI build status icon

On Thu, May 11, 2017 at 04:24:41PM +0200, Martin Kletzander wrote: > On Thu, May 11, 2017 at 02:35:12PM +0100, Daniel P. Berrange wrote: > > On Thu, May 11, 2017 at 03:30:00PM +0200, Martin Kletzander wrote: > > > On Tue, Apr 18, 2017 at 02:39:28PM -0300, Claudio André wrote: > > > > Using GitHub

Re: [libvirt] [PATCH 1/1] Enable Travis CI build status icon

On Thu, May 11, 2017 at 02:35:12PM +0100, Daniel P. Berrange wrote: On Thu, May 11, 2017 at 03:30:00PM +0200, Martin Kletzander wrote: On Tue, Apr 18, 2017 at 02:39:28PM -0300, Claudio André wrote: > Using GitHub libvirt site, it is possible to show Travis's fancy icon of the current build

Re: [libvirt] [PATCH] qemu: Provide a much clearer message on device hot-plug

On Thu, May 11, 2017 at 15:40:29 +0200, Erik Skultety wrote: > Adjust the current message to make it clear, that it is the hot-plug > operation that is unsupported with the given host device type. > > https://bugzilla.redhat.com/show_bug.cgi?id=1450072 > > Signed-off-by: Erik Skultety

[libvirt] ANNOUNCE: libvirt 2.2.1 maintenance release

libvirt 2.2.1 is now available. This is a maintenance release of libvirt 2.2 with additional bugfixes that have accumulated upstream since the initial release. This release can be downloaded at: http://libvirt.org/sources/stable_updates/libvirt-2.2.1.tar.xz Changes in this version: * spec:

[libvirt] ANNOUNCE: libvirt 1.3.3.3 maintenance release

libvirt 1.3.3.3 is now available. This is a maintenance release of libvirt 1.3.3 with additional bugfixes that have accumulated upstream since the initial release. This release can be downloaded at: http://libvirt.org/sources/stable_updates/libvirt-1.3.3.3.tar.gz Changes in this version: *

[libvirt] ANNOUNCE: libvirt 3.2.1 maintenance release

libvirt 3.2.1 is now available. This is a maintenance release of libvirt 3.2 with additional bugfixes that have accumulated upstream since the initial release. This release can be downloaded at: http://libvirt.org/sources/stable_updates/libvirt-3.2.1.tar.xz Changes in this version: * spec:

Re: [libvirt] [PATCH] tests: stub out virfilewrapper.c on Win32

On Thu, May 11, 2017 at 03:40:37PM +0200, Martin Kletzander wrote: > On Thu, May 11, 2017 at 02:16:11PM +0100, Daniel P. Berrange wrote: > > On Thu, May 11, 2017 at 03:13:03PM +0200, Martin Kletzander wrote: > > > On Thu, May 11, 2017 at 11:46:01AM +0100, Daniel P. Berrange wrote: > > > > The

Re: [libvirt] [PATCH] rpc: improve error message for bounds check

On Thu, May 11, 2017 at 11:25:02AM +0100, Daniel P. Berrange wrote: > If we exceed a fixed limit in RPC code we get a horrible message > like this, if the parameter type is a 'string', because we forgot > to initialize the error message type field: > > $ virsh snapshot-list ostack1 > error:

Re: [libvirt] [PATCH] tests: stub out virfilewrapper.c on Win32

On Thu, May 11, 2017 at 02:16:11PM +0100, Daniel P. Berrange wrote: On Thu, May 11, 2017 at 03:13:03PM +0200, Martin Kletzander wrote: On Thu, May 11, 2017 at 11:46:01AM +0100, Daniel P. Berrange wrote: > The Win32 platform can not do link time overrides in the same way > that we can on POSIX /

[libvirt] [PATCH] qemu: Provide a much clearer message on device hot-plug

Adjust the current message to make it clear, that it is the hot-plug operation that is unsupported with the given host device type. https://bugzilla.redhat.com/show_bug.cgi?id=1450072 Signed-off-by: Erik Skultety --- src/qemu/qemu_hotplug.c | 10 ++ 1 file changed,

Re: [libvirt] [PATCH 1/1] Enable Travis CI build status icon

On Thu, May 11, 2017 at 03:30:00PM +0200, Martin Kletzander wrote: > On Tue, Apr 18, 2017 at 02:39:28PM -0300, Claudio André wrote: > > Using GitHub libvirt site, it is possible to show Travis's fancy icon of > > the current build status. It highlights the QA process. > > I like seeing the icon

Re: [libvirt] [PATCH 1/1] Enable Travis CI build status icon

On Tue, Apr 18, 2017 at 02:39:28PM -0300, Claudio André wrote: Using GitHub libvirt site, it is possible to show Travis's fancy icon of the current build status. It highlights the QA process. I like seeing the icon there. It's very quick reference that serves the purpose. There's no need

[libvirt] [PATCH v1 1/3] conf : Add loadparm boot option for a boot device

Update the per device boot schema to add an optional loadparm parameter. Extend the virDomainDeviceInfo to support loadparm option. Modify the appropriate functions to parse loadparm from boot device xml. Signed-off-by: Farhan Ali Reviewed-by: Bjoern Walk

[libvirt] [PATCH v1 3/3] tests : Testcases for loadparm

Add testcases for loadparm Signed-off-by: Farhan Ali Reviewed-by: Boris Fiuczynski Reviewed-by: Bjoern Walk Reviewed-by: Marc Hartmayer ---

[libvirt] [PATCH v1 2/3] qemu : Add loadparm to qemu command line string

Introduce a new QEMU capability for loadparm and if the capability is supported by QEMU then append the loadparm value to "-machine" string of qemu command line. Signed-off-by: Farhan Ali Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski

[libvirt] [PATCH v1 0/3] Loadparm support

This patch series introduces the support for new s390x 'loadparm' feature. The 'loadparm' can be used to select the boot entry to boot from, for a boot device. Here is a link to the QEMU patches: https://lists.nongnu.org/archive/html/qemu-devel/2017-05/msg00192.html Thanks Farhan Ali Farhan

Re: [libvirt] [PATCH] tests: stub out virfilewrapper.c on Win32

On Thu, May 11, 2017 at 03:13:03PM +0200, Martin Kletzander wrote: > On Thu, May 11, 2017 at 11:46:01AM +0100, Daniel P. Berrange wrote: > > The Win32 platform can not do link time overrides in the same way > > that we can on POSIX / ELF based platforms, so we cannot build > > the virfilewrapper.c

Re: [libvirt] [PATCH] tests: stub out virfilewrapper.c on Win32

On Thu, May 11, 2017 at 11:46:01AM +0100, Daniel P. Berrange wrote: The Win32 platform can not do link time overrides in the same way that we can on POSIX / ELF based platforms, so we cannot build the virfilewrapper.c code reliably. Just stub it out on Win32 so it is a no-op. Tests that use this

Re: [libvirt] [PATCH] rpc: improve error message for bounds check

On 05/11/2017 12:25 PM, Daniel P. Berrange wrote: > If we exceed a fixed limit in RPC code we get a horrible message > like this, if the parameter type is a 'string', because we forgot > to initialize the error message type field: > > $ virsh snapshot-list ostack1 > error: too many remote

[libvirt] Release of libvirt-php-0.5.3

I just did the release of libvirt-php-0.5.3. You can download it here: http://libvirt.org/sources/php/libvirt-php-0.5.3.tar.gz There are 77 patches in this release (nearly 2x as much as in the previous release). There were several bug fixes, style conversions, etc. New features include: - New

Re: [libvirt] [PATCH] remote: increase max storage pools, nwfilters & snapshots to 16384

On Thu, May 11, 2017 at 11:35:36AM +0100, Daniel P. Berrange wrote: > Most other top level objects have already had their limits increased > to 16384. Increase the storage pool, nwfilter & snapshot object > limits to match. For snapshots at least, we have seen hosts which > exceeded the current

Re: [libvirt] [RFE] Raise enumeration limit for virDomain-{ListAllSnapshots, SnapshotListNames}?

On Thu, May 11, 2017 at 12:35:18PM +0200, Kashyap Chamarthy wrote: > I've got a server with multiple guests, and wanted to quickly check how > many of them had snapshots (and in turn, how many snapshots). > > So I quickly wrote the below script to enumerate the snapshots using the >

Re: [libvirt] [PATCH v2 22/38] daemon: Introduce virNetServerProgramSendStreamSkip

On 05/11/2017 02:36 AM, Michal Privoznik wrote: > On 05/10/2017 01:53 PM, Michal Privoznik wrote: >> On 05/05/2017 05:26 PM, John Ferlan wrote: >>> >>> >>> On 04/20/2017 06:01 AM, Michal Privoznik wrote: This is just a helper function that takes in a length value, encodes it into XDR

[libvirt] [PATCH] tests: stub out virfilewrapper.c on Win32

The Win32 platform can not do link time overrides in the same way that we can on POSIX / ELF based platforms, so we cannot build the virfilewrapper.c code reliably. Just stub it out on Win32 so it is a no-op. Tests that use this file are already written to skip on Win32. Signed-off-by: Daniel P.

[libvirt] [PATCH] remote: increase max storage pools, nwfilters & snapshots to 16384

Most other top level objects have already had their limits increased to 16384. Increase the storage pool, nwfilter & snapshot object limits to match. For snapshots at least, we have seen hosts which exceeded the current limit Signed-off-by: Daniel P. Berrange ---

[libvirt] [RFE] Raise enumeration limit for virDomain-{ListAllSnapshots, SnapshotListNames}?

I've got a server with multiple guests, and wanted to quickly check how many of them had snapshots (and in turn, how many snapshots). So I quickly wrote the below script to enumerate the snapshots using the virDomainSnapshotListNames() API, and it turned out, one of the guests had 1329 snaphots

[libvirt] [PATCH] rpc: improve error message for bounds check

If we exceed a fixed limit in RPC code we get a horrible message like this, if the parameter type is a 'string', because we forgot to initialize the error message type field: $ virsh snapshot-list ostack1 error: too many remote undefineds: 1329 > 1024 It would also be useful to know which

Re: [libvirt] CLI management tool

On Thu, May 11, 2017 at 09:17:39AM +0200, Michal Privoznik wrote: > Dear list, > > you might have seen a discussion about virsh, and adding some new > features to it [1]. While the feature was rejected, it got me thinking. > What options do we offer for sysadmins that: > > a) want to stay in

Re: [libvirt] CLI management tool

On Thu, May 11, 2017 at 09:17:39AM +0200, Michal Privoznik wrote: > Dear list, > > you might have seen a discussion about virsh, and adding some new > features to it [1]. While the feature was rejected, it got me thinking. > What options do we offer for sysadmins that: > > a) want to stay in

Re: [libvirt] [PATCH] docs: install html fonts and related

On Thu, May 11, 2017 at 12:01:27PM +0300, Nikolay Shirokovskiy wrote: > --- > docs/Makefile.am | 22 -- > 1 file changed, 20 insertions(+), 2 deletions(-) ACK Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |:

Re: [libvirt] [PATCH] virsh: Add --tls description for the virsh man page

On Wed, May 10, 2017 at 10:14:30AM -0400, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1448806 > > Commit id '6a8d898d' neglected to update the man page. > > Signed-off-by: John Ferlan Reviewed-by: Erik Skultety -- libvir-list

Re: [libvirt] CLI management tool

On Thu, May 11, 2017 at 09:17:39AM +0200, Michal Privoznik wrote: Dear list, you might have seen a discussion about virsh, and adding some new features to it [1]. While the feature was rejected, it got me thinking. What options do we offer for sysadmins that: a) want to stay in command line b)

[libvirt] [PATCH] docs: install html fonts and related

--- docs/Makefile.am | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/docs/Makefile.am b/docs/Makefile.am index 105fe68..7a10a50 100644 --- a/docs/Makefile.am +++ b/docs/Makefile.am @@ -54,6 +54,20 @@ css = \ libvirt.css \ main.css +fonts

Re: [libvirt] [libvirt-php PATCH 0/2] implement a few network API bindings

On 05/10/2017 11:31 PM, Neal Gompa wrote: > On Mon, May 8, 2017 at 11:43 AM, Dawid Zamirski wrote: >> Hello, >> >> The followinig two patches add a few useful API bindings for dealing >> with libvirt networks: >> >> * virConnectListAllNetworks - allows for better control when

Re: [libvirt] [libvirt-php PATCH 0/2] implement a few network API bindings

On 05/08/2017 05:43 PM, Dawid Zamirski wrote: > Hello, > > The followinig two patches add a few useful API bindings for dealing > with libvirt networks: > > * virConnectListAllNetworks - allows for better control when filtering > and returns array of handles to virNetworkPtr which can then be

[libvirt] [PATCH] safer default storage dir permissions

Hi, while cleaning out patchs that we held for a while on top of libvirt I found this patch of Serge (thanks!) which I think would make just as much sense in the upstream project itself. Or in case the discussion might unveil why it might not make sense, that would also be a win for us to adapt.

[libvirt] [PATCH] storage: use 0711 as the default perms for dirs

From: Serge Hallyn There should be no need to make dir based pools world readable. So use 0711, not 0755, as the default perms for storage dirs. Signed-off-by: Christian Ehrhardt --- docs/formatstorage.html.in | 2 +-

Re: [libvirt] src/remote_protocol-structs file

2017-05-11 10:07 GMT+03:00 Michal Privoznik : > Not at all. src/remote_protocol-structs is compared to > src/remote_protocol-structs-t3 (the former is kept within our git, the > latter is generated on the fly) to make sure we don't break our RPC > protocol. > > BTW: you can

Re: [libvirt] [PATCH v2 0/5] Prevent losing IPv6 routes due to forwarding

Hi Cédric, I think I find the machine with a RA route. (It is the original machine in the first mail) # ip a show enp0s25 2: enp0s25: mtu 1500 qdisc pfifo_fast state UP qlen 1000 link/ether 00:24:7e:05:42:32 brd ff:ff:ff:ff:ff:ff inet 10.66.71.67/23 brd

[libvirt] CLI management tool

Dear list, you might have seen a discussion about virsh, and adding some new features to it [1]. While the feature was rejected, it got me thinking. What options do we offer for sysadmins that: a) want to stay in command line b) want higher level mgmt of their domains c) yet want to manage a

Re: [libvirt] src/remote_protocol-structs file

On 05/10/2017 12:41 PM, Vasiliy Tolstov wrote: > Hi. While i'm writing go binding for libvirt rpc api i'm parse > src/remote/remote_protocol.x and generate needed code for go, but as i > see libvirt have src/remote_protocol-structs file. That contains all > needed data in mo simple syntax. But i

Re: [libvirt] [PATCH v2 22/38] daemon: Introduce virNetServerProgramSendStreamSkip

On 05/10/2017 01:53 PM, Michal Privoznik wrote: > On 05/05/2017 05:26 PM, John Ferlan wrote: >> >> >> On 04/20/2017 06:01 AM, Michal Privoznik wrote: >>> This is just a helper function that takes in a length value, >>> encodes it into XDR and sends to client. >> >> would be adjusted w/ @flags