[libvirt] [PATCH v2 1/2] util: Deduplicate code in virNetlinkEventServiceStopAll

Commit 15a71e60 introduced the virNetlinkEventServiceStopAll function, and the code in virNetlinkEventServiceStop is copied to this function. can use virNetlinkEventServiceStop instead. --- src/util/virnetlink.c | 25 +++-- 1 file changed, 3 insertions(+), 22 deletions(-)

[libvirt] [PATCH v2 2/2] util: do not leak handles in stop netlink event service

handles stored in virNetlinkEventSrvPrivatePtr should be freed when stop netlink event service. --- src/util/virnetlink.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/util/virnetlink.c b/src/util/virnetlink.c index fad1e8e..7988312 100644 --- a/src/util/virnetlink.c +++

[libvirt] [PATCH] datatypes: removing unnecessary return statement.

There is a wrong 'return' statement after a 'goto' statement inside the function virConnectCloseCallbackDataRegister(). This commit only removes the 'return'. Signed-off-by: Julio Faracco --- src/datatypes.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/datatypes.c

Re: [libvirt] [PATCH] docs: Update pointer to networking information

On 05/15/2017 08:16 AM, Andrea Bolognani wrote: > Commit 6fb5dd4fd804 removed docs/archnetwork.html.in, but > left behind a pointer to it in docs/formatnetwork.html.in. > > Update it so that it points to the wiki, which contains > more detailed and recent information anyway. > --- >

Re: [libvirt] [PATCH v1 0/3] Loadparm support

On 05/17/2017 09:48 AM, Farhan Ali wrote: > Polite ping :) > Could you please update to top of tree and repost... I know for sure qemu_capabilities have changed. In general things look good to me though... Thanks! John > On 05/11/2017 09:27 AM, Farhan Ali wrote: >> This patch series

Re: [libvirt] [PATCH v4 6/6] docs: Document the mediated devices within the nodedev driver

On 05/15/2017 08:10 AM, Erik Skultety wrote: > Signed-off-by: Erik Skultety > --- > docs/drvnodedev.html.in | 168 > +++- > tools/virsh.pod | 7 +- > 2 files changed, 171 insertions(+), 4 deletions(-) > Reviewed-by:

[libvirt] [PATCH] libxl: add default VNC listen address

If a VNC listen address is not specified in domXML, libxl will default to 127.0.0.1, but this is never reflected in the domXML. If not specified, set the listen address in virDomainGraphicsDef struct to the libxl default when creating the frame buffer device. Resolves:

Re: [libvirt] [PATCH v4 5/6] nodedev: Introduce mdev capability for mediated devices

On 05/15/2017 08:10 AM, Erik Skultety wrote: > Start discovering the mediated devices on the host system and format the > attributes for the mediated device into the XML. Compared to the parent > device which reports generic information about the abstract mediated > devices types, a child device

Re: [libvirt] [PATCH v4 4/6] nodedev: Introduce the mdev capability to a PCI parent device

On 05/15/2017 08:10 AM, Erik Skultety wrote: > The parent device needs to report the generic stuff about the supported > mediated devices types, like device API, available instances, type name, > etc. Therefore this patch introduces a new nested capability element of > type 'mdev_types' with the

Re: [libvirt] [PATCH v4 3/6] nodedev: Introduce new mdev_types and mdev nodedev capabilities

On 05/15/2017 08:10 AM, Erik Skultety wrote: > The reason for introducing two capabilities, one for the device itself > (cap 'mdev') and one for the parent device listing the available types > ('mdev_types'), is that we should be able to do > 'virsh nodedev-list --cap' not only for existing mdev

Re: [libvirt] [PATCH v4 2/6] nodedev: conf: Split PCI sub-capability parsing to separate methods

On 05/15/2017 08:10 AM, Erik Skultety wrote: > Since there's at least SRIOV and MDEV sub-capabilities to be parsed, > let's make the code more readable by splitting it to several logical > blocks. > > Signed-off-by: Erik Skultety > --- > src/conf/node_device_conf.c | 142

Re: [libvirt] [PATCH v4 1/6] mdev: Pass a uuidstr rather than an mdev object to some util functions

On 05/15/2017 08:10 AM, Erik Skultety wrote: > Namely, this patch is about virMediatedDeviceGetIOMMUGroup{Dev,Num} > functions. There's no compelling reason why these functions should take > an object, on the contrary, having to create an object every time one > needs to query the IOMMU group

Re: [libvirt] [PATCH v3 00/31] Implement sparse streams for libvirt

On 05/16/2017 10:03 AM, Michal Privoznik wrote: Don't forget the 32/31 patch which updates the news file... John > v3 of: > > https://www.redhat.com/archives/libvir-list/2017-April/msg00671.html > > All the patches can be found on my github: > >

Re: [libvirt] [PATCH] util: do not leak handles in stop netlink event service

On 05/13/2017 05:59 AM, Wang King wrote: > handles stored in virNetlinkEventSrvPrivatePtr should be freed when > stop netlink event service. > --- > src/util/virnetlink.c | 2 ++ > 1 file changed, 2 insertions(+) > This works and all, but do you you perhaps feel up to the challenge of merging

Re: [libvirt] [PATCH] virsh: add --io when attaching disks to guests

On 05/17/2017 10:51 AM, John Ferlan wrote: Thanks and congrats on your first patch, Thanks for reviewing the patch and shepherding it through the process. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] virsh: add --io when attaching disks to guests

On 05/12/2017 05:27 PM, Gordon Messmer wrote: > virt-install and virt-manager both default to explicitly setting > "io='native'" in the disk "driver" tag. virsh, however, does not and also > does not provide an option to specify that setting at all. As a result, > disks use a different IO

Re: [libvirt] [PATCH v3 29/31] Introduce virStorageVol{Download, Upload}Flags

On 05/17/2017 12:30 PM, Michal Privoznik wrote: > On 05/17/2017 05:42 PM, John Ferlan wrote: >> >> >> On 05/16/2017 10:04 AM, Michal Privoznik wrote: >>> These flags to APIs will tell if caller wants to use sparse >>> stream for storage transfer. At the same time, it's safe to >>> enable them in

Re: [libvirt] [PATCH v3 28/31] gendispatch: Introduce @sparseflag for our calls

On 05/17/2017 05:32 PM, John Ferlan wrote: > > > On 05/16/2017 10:04 AM, Michal Privoznik wrote: >> Now, not all APIs are going to support sparse streams. To some it >> makes no sense at all, e.g. virDomainOpenConsole() or >> virDomainOpenChannel(). To others, we will need a special flag to >>

Re: [libvirt] [PATCH v3 29/31] Introduce virStorageVol{Download, Upload}Flags

On 05/17/2017 05:42 PM, John Ferlan wrote: > > > On 05/16/2017 10:04 AM, Michal Privoznik wrote: >> These flags to APIs will tell if caller wants to use sparse >> stream for storage transfer. At the same time, it's safe to >> enable them in storage driver frontend and rely on our backends >>

Re: [libvirt] [PATCH v2] qemu: Adding 'downscript' feature for QEMU network interfaces.

On 05/17/2017 11:26 AM, Daniel P. Berrange wrote: > On Tue, May 16, 2017 at 06:16:19PM -0400, Laine Stump wrote: >> On 05/05/2017 10:22 AM, Julio Faracco wrote: >>> This commit adds the support for 'downscript' feature: >>> - For QEMU command line with the option: >>> '-net

Re: [libvirt] [PATCH v3 31/31] virsh: Implement sparse stream to vol-upload

On 05/16/2017 10:04 AM, Michal Privoznik wrote: > Similarly to previous commit, implement sparse streams feature > for vol-upload. This is, however, slightly different approach, > because we must implement a function that will tell us whether > we are in a data section or in a hole. But there's

Re: [libvirt] [PATCH v3 30/31] virsh: Implement sparse stream to vol-download

On 05/16/2017 10:04 AM, Michal Privoznik wrote: > The command grew new --sparse switch that does nothing more than s/The command grew new/Add a new/ > enables the sparse streams feature for this command. Among with > the switch new helper function is introduced: virshStreamSkip(). > This is

Re: [libvirt] [PATCH] qemu: driver: Allow passing disk target as top image with block commit

On Wed, May 17, 2017 at 10:37:22 -0500, Eric Blake wrote: > On 05/17/2017 10:20 AM, Peter Krempa wrote: > > Since we allow active layer block commit the users are allowed to commit > > the top of the chain (e.g. vda) into the backing image. The API would > > not accept that parameter, as it tried

Re: [libvirt] [PATCH v3 29/31] Introduce virStorageVol{Download, Upload}Flags

On 05/16/2017 10:04 AM, Michal Privoznik wrote: > These flags to APIs will tell if caller wants to use sparse > stream for storage transfer. At the same time, it's safe to > enable them in storage driver frontend and rely on our backends > checking the flags. This way we can enable specific

Re: [libvirt] [PATCH] qemu: driver: Allow passing disk target as top image with block commit

On 05/17/2017 10:20 AM, Peter Krempa wrote: > Since we allow active layer block commit the users are allowed to commit > the top of the chain (e.g. vda) into the backing image. The API would > not accept that parameter, as it tried to look up the image in the > backing chain. > > Add the ability

Re: [libvirt] [PATCH v3 28/31] gendispatch: Introduce @sparseflag for our calls

On 05/16/2017 10:04 AM, Michal Privoznik wrote: > Now, not all APIs are going to support sparse streams. To some it > makes no sense at all, e.g. virDomainOpenConsole() or > virDomainOpenChannel(). To others, we will need a special flag to > indicate that client wants to enable sparse streams.

Re: [libvirt] [PATCH v2] qemu: Adding 'downscript' feature for QEMU network interfaces.

On Tue, May 16, 2017 at 06:16:19PM -0400, Laine Stump wrote: > On 05/05/2017 10:22 AM, Julio Faracco wrote: > > This commit adds the support for 'downscript' feature: > > - For QEMU command line with the option: > > '-net downscript=/etc/qemu-ifdown,...'. > > > > - For Domains with a network

Re: [libvirt] [PATCH v2] qemu: Adding 'downscript' feature for QEMU network interfaces.

2017-05-16 19:16 GMT-03:00 Laine Stump : > On 05/05/2017 10:22 AM, Julio Faracco wrote: >> This commit adds the support for 'downscript' feature: >> - For QEMU command line with the option: >> '-net downscript=/etc/qemu-ifdown,...'. >> >> - For Domains with a network interface

[libvirt] [PATCH] qemu: driver: Allow passing disk target as top image with block commit

Since we allow active layer block commit the users are allowed to commit the top of the chain (e.g. vda) into the backing image. The API would not accept that parameter, as it tried to look up the image in the backing chain. Add the ability to use the top level image target name explicitly as the

Re: [libvirt] [PATCH 09/10] appmor, virt-aa-helper: Add 9p support

On 15.05.2017 18:13, Guido Günther wrote: > On Mon, May 15, 2017 at 03:23:18PM +0200, Stefan Bader wrote: >> From: Serge Hallyn >> >> Add fowner and fsetid to libvirt-qemu profile and add link >> to 9p file options in virt-aa-helper. >> >> Bug-Ubuntu:

Re: [libvirt] [PATCH v3 27/31] fdstream: Implement sparse stream

On 05/16/2017 10:04 AM, Michal Privoznik wrote: > Basically, what is needed here is to introduce new message type > for the messages passed between the event loop callbacks and the > worker thread that does all the I/O. The idea is that instead of > a queue of read buffers we will have a queue

Re: [libvirt] [PATCH v3 02/31] util: Introduce virFileInData

On 05/17/2017 08:41 AM, Michal Privoznik wrote: > On 05/16/2017 10:55 PM, John Ferlan wrote: >> >> >> On 05/16/2017 10:03 AM, Michal Privoznik wrote: >>> This function takes a FD and determines whether the current >>> position is in data section or in a hole. In addition to that, >>> it also

Re: [libvirt] [PATCH v3 08/31] Introduce virStreamSparseRecvAll

On 05/17/2017 08:40 AM, Michal Privoznik wrote: > On 05/16/2017 11:34 PM, John Ferlan wrote: >> >> >> On 05/16/2017 10:03 AM, Michal Privoznik wrote: >>> This is just a wrapper over new functions that have been just >>> introduced: virStreamRecvFlags(), virStreamRecvHole(). It's very >>> similar

Re: [libvirt] [PATCH v3 26/31] daemonStreamHandleRead: Wire up seekable stream

On 05/16/2017 10:04 AM, Michal Privoznik wrote: > Whenever client is able to receive some data from stream > daemonStreamHandleRead is called. But now the behaviour of this > function needs to be changed a bit. Previously it just read data > from underlying file (of chardev or whatever) and sent

Re: [libvirt] [PATCH v1 0/3] Loadparm support

Polite ping :) On 05/11/2017 09:27 AM, Farhan Ali wrote: This patch series introduces the support for new s390x 'loadparm' feature. The 'loadparm' can be used to select the boot entry to boot from, for a boot device. Here is a link to the QEMU patches:

Re: [libvirt] [PATCH v3 25/31] remote_driver: Implement VIR_STREAM_RECV_STOP_AT_HOLE

The commit message text could use a few words, but I know it's fairly self explanatory... Still something better than nothing. On 05/16/2017 10:04 AM, Michal Privoznik wrote: > Signed-off-by: Michal Privoznik > --- > src/remote/remote_driver.c | 2 +- >

Re: [libvirt] [PATCH v3 24/31] virNetClientStream: Wire up VIR_NET_STREAM_HOLE

On 05/16/2017 10:04 AM, Michal Privoznik wrote: > Whenever server sends a client stream packet (either regular with > actual data or stream skip one) it is queued on @st->rx. So the > list is a mixture of both types of stream packets. So now that we > have all the helpers needed we can wire

Re: [libvirt] [PATCH v3 23/31] remote: Implement virStreamRecvHole

On 05/16/2017 10:04 AM, Michal Privoznik wrote: > Signed-off-by: Michal Privoznik > --- > src/remote/remote_driver.c | 31 +++ > 1 file changed, 31 insertions(+) > Reviewed-by: John Ferlan John -- libvir-list mailing

Re: [libvirt] [PATCH v3 22/31] Introduce virNetClientStreamRecvHole

On 05/16/2017 10:04 AM, Michal Privoznik wrote: > This function will fetch previously processed stream holes and > return their sum. > > Signed-off-by: Michal Privoznik > --- > src/libvirt_remote.syms | 1 + > src/rpc/virnetclientstream.c | 16 >

Re: [libvirt] [PATCH v3 21/31] virNetClientStreamRecvPacket: Introduce @flags argument

On 05/16/2017 10:04 AM, Michal Privoznik wrote: > Signed-off-by: Michal Privoznik > --- > src/remote/remote_driver.c | 3 ++- > src/rpc/virnetclientstream.c | 10 +++--- > src/rpc/virnetclientstream.h | 3 ++- > 3 files changed, 11 insertions(+), 5 deletions(-) >

Re: [libvirt] [PATCH v3 20/31] remote_driver: Implement virStreamSendHole

On 05/16/2017 10:04 AM, Michal Privoznik wrote: > Now that we have RPC wrappers over VIR_NET_STREAM_HOLE we can > start wiring them up. This commit wires up situation when a > client wants to send a hole to daemon. > > To keep stream offsets synchronous, upon successful call on the > daemon

Re: [libvirt] [PATCH v3 05/31] Introduce virStreamSendHole

On 05/16/2017 11:13 PM, John Ferlan wrote: > > > On 05/16/2017 10:03 AM, Michal Privoznik wrote: >> This API is used to tell the other side of the stream to skip >> some bytes in the stream. This can be used to create a sparse >> file on the receiving side of a stream. >> >> It takes @length

Re: [libvirt] [PATCH v3 02/31] util: Introduce virFileInData

On 05/16/2017 10:55 PM, John Ferlan wrote: > > > On 05/16/2017 10:03 AM, Michal Privoznik wrote: >> This function takes a FD and determines whether the current >> position is in data section or in a hole. In addition to that, >> it also determines how much bytes are there remaining till the >>

Re: [libvirt] [PATCH v3 01/31] virfdstream: Use messages instead of pipe

On 05/16/2017 10:26 PM, John Ferlan wrote: > > > On 05/16/2017 10:03 AM, Michal Privoznik wrote: >> One big downside of using the pipe to transfer the data is that >> we can really transfer just bare data. No metadata can be carried >> through unless some formatted messages are introduced. That

Re: [libvirt] [PATCH v3 10/31] Introduce virStreamInData

On 05/17/2017 12:00 AM, John Ferlan wrote: > > > On 05/16/2017 10:03 AM, Michal Privoznik wrote: >> This is just an internal API, that calls corresponding function >> in stream driver. This function will set @data=1 if the >> underlying file is in data section, or @data=0 if it is in a >> hole.

Re: [libvirt] [PATCH v3 07/31] Introduce VIR_STREAM_RECV_STOP_AT_HOLE flag

On 05/16/2017 11:22 PM, John Ferlan wrote: > > > On 05/16/2017 10:03 AM, Michal Privoznik wrote: >> Add a new flag to virStreamRecvFlags in order to handle being able to >> stop reading from the stream so that the consumer can generate a "hole" >> in stream target. Generation of a hole replaces

Re: [libvirt] [PATCH v3 08/31] Introduce virStreamSparseRecvAll

On 05/16/2017 11:34 PM, John Ferlan wrote: > > > On 05/16/2017 10:03 AM, Michal Privoznik wrote: >> This is just a wrapper over new functions that have been just >> introduced: virStreamRecvFlags(), virStreamRecvHole(). It's very >> similar to virStreamRecvAll() except it handles sparse streams

Re: [libvirt] [PATCH v3 11/31] virNetClientStreamNew: Track origin stream

On 05/17/2017 01:13 PM, John Ferlan wrote: > > > On 05/16/2017 10:03 AM, Michal Privoznik wrote: >> Add a virStreamPtr pointer to the _virNetClientStream >> in order to reverse track the parent stream. >> >> Signed-off-by: Michal Privoznik >> --- >>

Re: [libvirt] [PATCH v3 19/31] virnetclientstream: Introduce virNetClientStreamHandleHole

On 05/16/2017 10:03 AM, Michal Privoznik wrote: > This is a function that handles an incoming STREAM_HOLE packet. > Even though it is not wired up yet, it will be soon. At the > beginning do couple of checks whether server plays nicely and > sent us a STREAM_HOLE packed only after we've enabled

Re: [libvirt] [PATCH v3 15/31] Teach wireshark plugin about VIR_NET_STREAM_HOLE

On 05/17/2017 01:44 PM, John Ferlan wrote: > > > On 05/16/2017 10:03 AM, Michal Privoznik wrote: >> Ideally, this would be generated, but to achieve that >> corresponding XDR definitions needed to go into a different .x >> file. But they belong just to the one that they are right now. >> >>

Re: [libvirt] [PATCH] qemu: allow to control host side link status of network device

On Wed, May 17, 2017 at 08:16:58 -0400, Laine Stump wrote: > On 05/17/2017 03:51 AM, Vasiliy Tolstov wrote: > > 2017-05-17 4:25 GMT+03:00 Laine Stump : > >> Oh, and I forgot to point out here (although I did in the original > >> thread last fall) that a toplevel historically only

Re: [libvirt] [PATCH python] Fix virStream.sendAll for Python 3

Great ! Thanks for the merge and your work :) Cheers, Xavier On Wed, May 17, 2017 at 9:12 AM, Martin Kletzander wrote: > On Fri, May 05, 2017 at 04:39:34PM +0200, Xavier Fernandez wrote: > >> In Python 3, if the file is open in binary mode, ``got`` will end up >> being

Re: [libvirt] [PATCH] qemu: allow to control host side link status of network device

On 05/17/2017 03:51 AM, Vasiliy Tolstov wrote: > 2017-05-17 4:25 GMT+03:00 Laine Stump : >> Oh, and I forgot to point out here (although I did in the original >> thread last fall) that a toplevel historically only >> affects the state of the interface in the guest. If it began

Re: [libvirt] [PATCH v3 18/31] daemon: Implement VIR_NET_STREAM_HOLE handling

On 05/16/2017 10:03 AM, Michal Privoznik wrote: > Basically, whenever the new type of stream packet arrives to the > daemon call this function that decodes it and calls > virStreamSendHole(). Otherwise a regular data stream packet has > arrived and therefore continue its processing. > >

Re: [libvirt] [PATCH v3 17/31] virnetclientstream: Introduce virNetClientStreamSendHole

On 05/16/2017 10:03 AM, Michal Privoznik wrote: > While the previous commit implemented a helper for sending a > STREAM_HOLE packet for daemon, this is a client's counterpart. > > Signed-off-by: Michal Privoznik > --- > src/libvirt_remote.syms | 1 + >

Re: [libvirt] [PATCH v3 16/31] daemon: Introduce virNetServerProgramSendStreamHole

On 05/16/2017 10:03 AM, Michal Privoznik wrote: > This is just a helper function that takes in a length value, > encodes it into XDR and sends to client. > > Signed-off-by: Michal Privoznik > --- > src/libvirt_remote.syms | 1 + > src/rpc/virnetserverprogram.c | 35

Re: [libvirt] [PATCH v3 15/31] Teach wireshark plugin about VIR_NET_STREAM_HOLE

On 05/16/2017 10:03 AM, Michal Privoznik wrote: > Ideally, this would be generated, but to achieve that > corresponding XDR definitions needed to go into a different .x > file. But they belong just to the one that they are right now. > > Signed-off-by: Michal Privoznik >

Re: [libvirt] [PATCH v3 14/31] Introduce VIR_NET_STREAM_HOLE message type

On 05/16/2017 10:03 AM, Michal Privoznik wrote: > This is a special type of stream packet, that is bidirectional > and will contain information on how much bytes are both sides > skipping in the stream. and contains information regarding how many bytes each side will be skipping in the stream.

Re: [libvirt] [PATCH v3 13/31] RPC: Introduce virNetStreamHole

On 05/16/2017 10:03 AM, Michal Privoznik wrote: > This is going to be RPC representation for virStreamSendHole. > > Signed-off-by: Michal Privoznik > --- > src/rpc/virnetprotocol.x | 5 + > src/virnetprotocol-structs | 4 > 2 files changed, 9 insertions(+) >

Re: [libvirt] [PATCH v3 12/31] Add new flag to daemonCreateClientStream and virNetClientStreamNew

On 05/16/2017 10:03 AM, Michal Privoznik wrote: > Add a new argument to daemonCreateClientStream in order to allow for > future expansion to mark that a specific stream can be used to skip > data, such as the case with sparsely populated files. The new flag will > be the eventual decision point

Re: [libvirt] [PATCH v3 11/31] virNetClientStreamNew: Track origin stream

On 05/16/2017 10:03 AM, Michal Privoznik wrote: > Add a virStreamPtr pointer to the _virNetClientStream > in order to reverse track the parent stream. > > Signed-off-by: Michal Privoznik > --- > src/remote/remote_driver.c | 6 -- > src/rpc/gendispatch.pl | 2

Re: [libvirt] [PATCH 0/2] Fix issue with attempting to use polkit

ping? Tks - John On 05/11/2017 11:04 AM, John Ferlan wrote: > The "issue" is when using a remote URI and authn when attempting to connect > to the local system when a local URI and usage of pkttyagent was "expected" > for local authn. > > The current bug is: > >

Re: [libvirt] [PATCH] conf: Resolve corner case on fc_host deletion

ping^2 Tks, John On 04/29/2017 11:36 AM, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1420740 > > Testing found an inventive way to cause an error at shutdown by providing the > parent name for the fc host creation using the "same name" as the HBA. Since > the code thus

[libvirt] [V4 RESEND PATCH] Expose resource control capabilites on cache bank

From: Eli Qiao * This patch amends the cache bank capability as follow: For CDP enabled on x86 arch, we will have: ... * Added a new testdata directory `linux-resctrl-cdp` to test CDP enabled case. * Along with vircaps2xmltest

Re: [libvirt] [PATCH] qemu: allow to control host side link status of network device

2017-05-17 4:25 GMT+03:00 Laine Stump : > Oh, and I forgot to point out here (although I did in the original > thread last fall) that a toplevel historically only > affects the state of the interface in the guest. If it began affecting > the state of the tap device in the host as

Re: [libvirt] [PATCH python] Fix virStream.sendAll for Python 3

On Fri, May 05, 2017 at 04:39:34PM +0200, Xavier Fernandez wrote: In Python 3, if the file is open in binary mode, ``got`` will end up being equal to b"" and b"" != "" in Python 3. --- libvirt-override-virStream.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Makes sense, I also