[libvirt] [PATCH 6/7] node_device: introduce new capability FC_RPORT

2017-05-21 Thread Bjoern Walk
Similar to scsi_host and fc_host, there is a relation between a scsi_target and its transport specific fc_remote_port. Let's expose this relation and relevant information behind it. An example for a virsh nodedev-dumpxml: virsh # nodedev-dumpxml scsi_target0_0_0 scsi_target0_0_0

[libvirt] [PATCH 0/7] extend node_device for CCW and fc_remote_port

2017-05-21 Thread Bjoern Walk
Let's introduce two new capabilities to the node_device driver and fix two smaller issues on the way. The first is for CCW devices, most common on the S390 architecture. We expose the relevant cssid, ssid and devno values. The second is for fibre channel-backed SCSI devices, where we introduce th

[libvirt] [PATCH 3/7] node_device: detect CCW devices

2017-05-21 Thread Bjoern Walk
Make CCW devices available to the node_device driver. The devices are already seen by udev so let's implement necessary code for detecting them properly. Topologically, CCW devices are similar to PCI devices, e.g.: +- ccw_0_0_1a2b | +- scsi_host0 | +- s

[libvirt] [PATCH 7/7] docs: update news.xml

2017-05-21 Thread Bjoern Walk
Mention CCW and fc_remote_port capablities in the news.xml file. Reviewed-by: Boris Fiuczynski Signed-off-by: Bjoern Walk --- docs/news.xml | 11 +++ 1 file changed, 11 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 52915ee2e..d8c9794f9 100644 --- a/docs/news.xml +++ b/

[libvirt] [PATCH 1/7] node_device: Use the iterator variable

2017-05-21 Thread Bjoern Walk
From: Marc Hartmayer As the switch statement checks data.type of the iterator variable @cap it must use this variable for the update too. Suggested-by: Bjoern Walk Signed-off-by: Marc Hartmayer --- src/node_device/node_device_driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[libvirt] [PATCH 5/7] util: helper functions for fibre channel devices

2017-05-21 Thread Bjoern Walk
We will need some convenient helper functions for managing sysfs-entries for fibre channel-backed devices. Let's implement them and make them available in the private API. Signed-off-by: Bjoern Walk --- po/POTFILES.in | 1 + src/Makefile.am | 1 + src/libvirt_private.syms |

[libvirt] [PATCH 4/7] virsh: nodedev: ability to filter CCW capabilities

2017-05-21 Thread Bjoern Walk
Now that the node_device driver is aware of CCW devices, let's hook up virsh so that we can filter them properly. Reviewed-by: Boris Fiuczynski Reviewed-by: Marc Hartmayer Signed-off-by: Bjoern Walk --- docs/formatnode.html.in | 12 include/libvirt/libvirt-nodedev.h | 1

[libvirt] [PATCH 2/7] node_device: Unlock obj in case of an error too

2017-05-21 Thread Bjoern Walk
From: Marc Hartmayer Unlock @obj in case of an error too. Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski Signed-off-by: Marc Hartmayer --- src/node_device/node_device_driver.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/node_device/node_device_driver.

Re: [libvirt] [PATCH] util: Don't leak @replay in virSystemdGetMachineNameByPID

2017-05-21 Thread Michal Privoznik
On 05/20/2017 03:31 AM, Wang King wrote: > s/replay/reply/ in $SUBJ > @reply is a DBusMessage object returned by virDBusCallMethod in > get machine object call path, dereference it before calling > virDBusCallMethod again to get machine name. > --- > src/util/virsystemd.c | 3 +++ > 1 file chang

Re: [libvirt] [PATCH] test: fixing variable names for test suite inside configure.ac.

2017-05-21 Thread Michal Privoznik
On 05/20/2017 04:53 PM, Julio Faracco wrote: > Both variables for gcov and oom have wrong names inside configure.ac. > For this reason, the Test Suite configuration is not showing the current > configuration. > > Before patching: > configure:windres: no > configure: > configure: Test suite > c

Re: [libvirt] [PATCH] qemu: allow to control host side link status of network device

2017-05-21 Thread Laine Stump
On 05/15/2017 06:15 PM, Vasiliy Tolstov wrote: > Signed-off-by: Vasiliy Tolstov > --- > docs/formatdomain.html.in | 21 + > docs/schemas/domaincommon.rng | 11 +++ > src/conf/domain_conf.c| 28 > src/conf/domain_conf.h|

Re: [libvirt] [PATCH] qemu: allow to control host side link status of network device

2017-05-21 Thread Laine Stump
On 05/18/2017 04:32 PM, Vasiliy Tolstov wrote: > 2017-05-17 15:28 GMT+03:00 Peter Krempa : >>> >>> Well, *I* think I've given sufficient reasons for having the two link >>> states controlled separately, but since Dan and Peter had questioned its >>> usefulness, we should see whether or not I've swa

Re: [libvirt] [PATCH] Do not release unreserved address in qemuDomainAttachRNGDevice

2017-05-21 Thread John Ferlan
On 05/19/2017 08:16 AM, Ján Tomko wrote: > Only set releaseaddr to true after the address has been > reserved successfully. > > https://bugzilla.redhat.com/show_bug.cgi?id=1452581 > --- > src/qemu/qemu_hotplug.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: John Ferla

[libvirt] [PATCH 09/08] interface: Introduce virInterfaceObjEndAPI

2017-05-21 Thread John Ferlan
For now it'll just call the virInterfaceObjUnlock, but a future adjustment will do something different. The virInterfaceObjUnlock is now private to virinterfaceobj.c with a short term forward reference. Additionally, make virInterfaceObjLock private since it's only used in virinterfaceobj anyway.

[libvirt] [PATCH 10/08] interface: Convert virInterfaceObj to use virObjectLockable

2017-05-21 Thread John Ferlan
Now that we have a bit more control, let's convert our object into a lockable object and let that magic handle the create and lock/unlock. Signed-off-by: John Ferlan --- po/POTFILES.in | 1 - src/conf/virinterfaceobj.c | 110 ++--- 2 files ch

Re: [libvirt] [PATCH 8/8] interface: Introduce virInterfaceObjNew

2017-05-21 Thread John Ferlan
>> >> Also I didn't want the "overhead" of converting it to a virObject only >> to convert it later to the newer object. I mean I could now, but I have >> this goal of making all these driver objects use the same object around >> the same time. Some convert more easily since they already use virOb