Re: [libvirt] [PATCH] CI: show the log in case of failure

Below an example of why it is desirable. Em 25/05/2017 02:19, claudioandre...@gmail.com escreveu: From: Claudio André Disclosure the content of the 'test-suite.log' file (if available) in case of failures inside Travis-CI. This is needed to understand what happened

[libvirt] [PATCH] CI: show the log in case of failure

From: Claudio André Disclosure the content of the 'test-suite.log' file (if available) in case of failures inside Travis-CI. This is needed to understand what happened and to provide hints about the proper fix (if applicable). --- .travis.yml | 8 1 file

[libvirt] [PATCH 1/1] CI: add code coverage analysis

From: Claudio André It builds the code coverage report and uploads the coverage data to a web service in order to allow to track libvirt's code coverage over time. --- .travis.yml | 11 ++- README.md | 1 + 2 files changed, 11 insertions(+), 1 deletion(-)

[libvirt] [PATCH 0/1] Enable code coverage on CI

From: Claudio André *** *** NOTE: In order to add links to demonstrate it working, I'm using a cover letter for only 1 patch. Sorry about this! It is possible to see how it behaves, just access: - https://gist.github.com/claudioandre/60b262ff8c110133c0a94d5f0ce2362c

Re: [libvirt] [PATCH] qemu: Fix memory leak inqemuDomainUpdateMemoryDeviceInfo

Thank you Michal --- Best wishes Yi Wang 原始邮件 发件人： ＜mpriv...@redhat.com＞ 收件人：汪翼10129963 ＜libvir-list@redhat.com＞ 抄送人：刘建军10033482徐熙00121931 日 期 ：2017年05月24日 23:00 主 题 ：Re: [libvirt] [PATCH] qemu: Fix memory leak inqemuDomainUpdateMemoryDeviceInfo On 05/25/2017 04:20 AM, Yi

Re: [libvirt] [PATCH v2] lib: Add note that bulk stats API queries may overrun RPC buffers

On Wed, May 24, 2017 at 05:12:06PM +0200, Michal Privoznik wrote: On 05/24/2017 04:58 PM, Richard W.M. Jones wrote: On Wed, May 24, 2017 at 04:16:45PM +0200, Michal Privoznik wrote: On 05/24/2017 02:47 PM, Richard W.M. Jones wrote: On Wed, May 24, 2017 at 12:49:58PM +0200, Michal Privoznik

Re: [libvirt] [PATCH] Regression: Report correct CPUs present on executing virsh nodecpumap

On Wed, May 24, 2017 at 8:09 PM, Ján Tomko wrote: > On Wed, May 24, 2017 at 07:46:00PM +0530, Nitesh Konkar wrote: > >> Recent changes to virbitmap.c file created a regression >> where on executing the virsh nodecpumap command, the number >> of CPUs present was shown as (last

Re: [libvirt] [PATCH] usb: keep leading zeros of vendor/product id in USB device

On 05/19/2017 03:17 AM, Chen Hanxiao wrote: > From: Chen Hanxiao > > Some vendor id or product id may have leading zeros. > We should show them. > > Signed-off-by: Chen Hanxiao Reviewed-by: Laine Stump ACK and pushed (I modified

Re: [libvirt] [PATCH 04/13] nodedev: Move node_device_linux_sysfs from node_driver to conf

On 05/24/2017 10:35 AM, Daniel P. Berrange wrote: > On Wed, May 24, 2017 at 09:45:09AM -0400, John Ferlan wrote: >> >> >> On 05/23/2017 04:13 AM, Bjoern Walk wrote: >>> John Ferlan [2017-05-19, 09:08AM -0400]: Move the whole file from src/node_device into src/conf and

Re: [libvirt] [PATCH 2/2] virsh: Don't attempt polkit processing for non local authn/authz

On 05/24/2017 10:38 AM, Michal Privoznik wrote: > On 05/11/2017 05:04 PM, John Ferlan wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1374126 >> >> Due to how the processing for authentication using polkit works, the >> virshConnect code must first "attempt" an virConnectOpenAuth and then

Re: [libvirt] [PATCH v2] lib: Add note that bulk stats API queries may overrun RPC buffers

On 05/24/2017 04:58 PM, Richard W.M. Jones wrote: > On Wed, May 24, 2017 at 04:16:45PM +0200, Michal Privoznik wrote: >> On 05/24/2017 02:47 PM, Richard W.M. Jones wrote: >>> >>> On Wed, May 24, 2017 at 12:49:58PM +0200, Michal Privoznik wrote: That's quite exact. I mean the word 'guessing'.

Re: [libvirt] [PATCH v2 3/3] virQEMUDriverDomainABIStability: Check for memoryBacking

On Wed, May 24, 2017 at 04:45:57PM +0200, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1450349 > > Problem is, qemu fails to load guest memory image if these > attribute change on migration/restore from an image. [snip] > diff --git a/src/qemu/qemu_domain.c

Re: [libvirt] [PATCH v2 1/3] virDomainDefCheckABIStabilityFlags: move memtune checks into a separate function

On Wed, May 24, 2017 at 16:45:55 +0200, Michal Privoznik wrote: > The checks are scattered all over the place. Move them into a > single function. > > Signed-off-by: Michal Privoznik > --- > src/conf/domain_conf.c | 74 > -- >

Re: [libvirt] [PATCH 2/2] qemu: format eim on intel-iommu command line

On Thu, 2017-05-18 at 11:09 +0200, Ján Tomko wrote: > This option turns on extended interrupt mode, > which allows more than 255 vCPUs. >  > https://bugzilla.redhat.com/show_bug.cgi?id=1451282 > --- >  src/qemu/qemu_capabilities.c |  2 ++ >  src/qemu/qemu_capabilities.h 

Re: [libvirt] [PATCH] qemu: Fix memory leak in qemuDomainUpdateMemoryDeviceInfo

On 05/25/2017 04:20 AM, Yi Wang wrote: > The @meminfo allocated in qemuMonitorGetMemoryDeviceInfo may be lost when > exit monitor failed. Luckily we can free it according to rc. > > Signed-off-by: Yi Wang > --- > src/qemu/qemu_domain.c | 5 - > 1 file changed, 4

Re: [libvirt] [PATCH v2] lib: Add note that bulk stats API queries may overrun RPC buffers

On Wed, May 24, 2017 at 04:16:45PM +0200, Michal Privoznik wrote: > On 05/24/2017 02:47 PM, Richard W.M. Jones wrote: > > > > On Wed, May 24, 2017 at 12:49:58PM +0200, Michal Privoznik wrote: > >> That's quite exact. I mean the word 'guessing'. We can't really provide > >> reliable way of dealing

Re: [libvirt] [PATCH python] Fix error check for virDomainGetTime method

On 05/24/2017 04:15 PM, Daniel P. Berrange wrote: > The virDomainGetTime returns either a dict or None, but the python > glue layer for checking for '-1'. Thus it failed to raise an > exception on error. > > Signed-off-by: Daniel P. Berrange > --- >

[libvirt] [PATCH v2 3/3] virQEMUDriverDomainABIStability: Check for memoryBacking

https://bugzilla.redhat.com/show_bug.cgi?id=1450349 Problem is, qemu fails to load guest memory image if these attribute change on migration/restore from an image. Signed-off-by: Michal Privoznik --- src/libvirt_private.syms | 6 ++ src/qemu/qemu_conf.c | 2 +-

[libvirt] [PATCH v2 2/3] virDomainXMLOption: Introduce virDomainABIStabilityDomain

While checking for ABI stability, drivers might pose additional checks that are not valid for general case. For instance, qemu driver might check some memory backing attributes because of how qemu works. But those attributes may work well in other drivers. Signed-off-by: Michal Privoznik

[libvirt] [PATCH v2 1/3] virDomainDefCheckABIStabilityFlags: move memtune checks into a separate function

The checks are scattered all over the place. Move them into a single function. Signed-off-by: Michal Privoznik --- src/conf/domain_conf.c | 74 -- 1 file changed, 48 insertions(+), 26 deletions(-) diff --git

Re: [libvirt] [PATCH 1/2] conf: add eim attribute to

On Thu, 2017-05-18 at 11:09 +0200, Ján Tomko wrote: > Add an attribute to control extended interrupt mode. >  > https://bugzilla.redhat.com/show_bug.cgi?id=1451282 [...] > @@ -7436,6 +7436,16 @@ qemu-kvm -net nic,model=? /dev/null >Since 3.4.0 (QEMU/KVM only) >   > 

[libvirt] [PATCH v2 0/3] Check for

Technically this is v2 of: https://www.redhat.com/archives/libvir-list/2017-May/msg00626.html diff to v1: - Patches split and reworked as suggested by Peter in the review Michal Privoznik (3): virDomainDefCheckABIStabilityFlags: move memtune checks into a separate function

Re: [libvirt] [PATCH] Regression: Report correct CPUs present on executing virsh nodecpumap

On Wed, May 24, 2017 at 07:46:00PM +0530, Nitesh Konkar wrote: Recent changes to virbitmap.c file created a regression where on executing the virsh nodecpumap command, the number of CPUs present was shown as (last cpu online id + 1). This patch fixes the issue. Signed-off-by: Nitesh Konkar

Re: [libvirt] [PATCH 1/2] virsh: Track when create pkttyagent

On 05/11/2017 05:04 PM, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1374126 > > Due to how the processing for authentication using polkit works, the > virshConnect code must first "attempt" an virConnectOpenAuth and then > check for a "special" return error code

Re: [libvirt] [PATCH 2/2] virsh: Don't attempt polkit processing for non local authn/authz

On 05/11/2017 05:04 PM, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1374126 > > Due to how the processing for authentication using polkit works, the > virshConnect code must first "attempt" an virConnectOpenAuth and then > check for a "special" return error code

Re: [libvirt] [PATCH 04/13] nodedev: Move node_device_linux_sysfs from node_driver to conf

On Wed, May 24, 2017 at 09:45:09AM -0400, John Ferlan wrote: > > > On 05/23/2017 04:13 AM, Bjoern Walk wrote: > > John Ferlan [2017-05-19, 09:08AM -0400]: > >> Move the whole file from src/node_device into src/conf and rename the > >> API's to have the "virNodeDevice"

Re: [libvirt] [PATCH 1/2] conf: add eim attribute to

On Thu, 2017-05-18 at 11:09 +0200, Ján Tomko wrote: > Add an attribute to control extended interrupt mode. >  > https://bugzilla.redhat.com/show_bug.cgi?id=1451282 [...] > @@ -14184,6 +14184,14 @@ virDomainIOMMUDefParseXML(xmlNodePtr node, >  } >  iommu->caching_mode = val; >  

[libvirt] [PATCH] qemu: Fix memory leak in qemuDomainUpdateMemoryDeviceInfo

The @meminfo allocated in qemuMonitorGetMemoryDeviceInfo may be lost when exit monitor failed. Luckily we can free it according to rc. Signed-off-by: Yi Wang --- src/qemu/qemu_domain.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[libvirt] [PATCH python] Fix error check for virDomainGetTime method

The virDomainGetTime returns either a dict or None, but the python glue layer for checking for '-1'. Thus it failed to raise an exception on error. Signed-off-by: Daniel P. Berrange --- libvirt-override-virDomain.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[libvirt] [PATCH] Regression: Report correct CPUs present on executing virsh nodecpumap

Recent changes to virbitmap.c file created a regression where on executing the virsh nodecpumap command, the number of CPUs present was shown as (last cpu online id + 1). This patch fixes the issue. Signed-off-by: Nitesh Konkar --- src/Makefile.am | 2 ++

Re: [libvirt] [PATCH v2] lib: Add note that bulk stats API queries may overrun RPC buffers

On Wed, May 24, 2017 at 04:09:35PM +0200, Michal Privoznik wrote: On 05/24/2017 02:42 PM, Richard W.M. Jones wrote: On Tue, May 23, 2017 at 05:07:40PM +0200, Michal Privoznik wrote: Because: https://www.redhat.com/archives/libvir-list/2017-May/msg00088.html I don't think this is a reason at

Re: [libvirt] [PATCH v2] lib: Add note that bulk stats API queries may overrun RPC buffers

On 05/24/2017 02:47 PM, Richard W.M. Jones wrote: > > On Wed, May 24, 2017 at 12:49:58PM +0200, Michal Privoznik wrote: >> That's quite exact. I mean the word 'guessing'. We can't really provide >> reliable way of dealing with what you're suggesting (unless we cut the >> limit really small) nor

[libvirt] [PATCH] audit: Fix the output message for shmem

After some discussion on and off the linux-audit mailing list, we should use different fields for the audit messages. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1218603 Signed-off-by: Martin Kletzander --- src/conf/domain_audit.c | 24 +--- 1

Re: [libvirt] [PATCH v2] lib: Add note that bulk stats API queries may overrun RPC buffers

On 05/24/2017 02:42 PM, Richard W.M. Jones wrote: > On Tue, May 23, 2017 at 05:07:40PM +0200, Michal Privoznik wrote: >> Because: >> >> https://www.redhat.com/archives/libvir-list/2017-May/msg00088.html > > I don't think this is a reason at all. > > Libguestfs uses an RPC system which was

Re: [libvirt] [PATCH 0/2] Fix issue with attempting to use polkit

ping^2? One option or the other? Tks - John On 05/17/2017 06:57 AM, John Ferlan wrote: > > ping? > > Tks - > > John > > On 05/11/2017 11:04 AM, John Ferlan wrote: >> The "issue" is when using a remote URI and authn when attempting to connect >> to the local system when a local URI and

Re: [libvirt] [PATCH 00/13] Make the virNodeDeviceObjPtr private

On 05/23/2017 04:26 AM, Bjoern Walk wrote: > John Ferlan [2017-05-19, 09:08AM -0400]: >> All part of the effort I have to have a common object model. This series >> is node device test, driver, and virnodedevobj related. >> >> There's also a couple of bug fixes at the

Re: [libvirt] [PATCH 05/13] nodedev: Use common naming for virnodedeviceobj

On 05/23/2017 04:28 AM, Bjoern Walk wrote: > John Ferlan [2017-05-19, 09:08AM -0400]: >> A virNodeDeviceObjPtr is an @obj >> >> A virNodeDeviceObjListPtr is an @devs >> > > More intuitive for the virNodeDeviceObjListPtr would be @objs, but I > guess the naming scheme is

Re: [libvirt] [PATCH 04/13] nodedev: Move node_device_linux_sysfs from node_driver to conf

On 05/23/2017 04:13 AM, Bjoern Walk wrote: > John Ferlan [2017-05-19, 09:08AM -0400]: >> Move the whole file from src/node_device into src/conf and rename the >> API's to have the "virNodeDevice" prefix. >> >> Signed-off-by: John Ferlan >> --- >>

Re: [libvirt] [PATCH v2] lib: Add note that bulk stats API queries may overrun RPC buffers

On Wed, May 24, 2017 at 01:42:44PM +0100, Richard W.M. Jones wrote: On Tue, May 23, 2017 at 05:07:40PM +0200, Michal Privoznik wrote: Because: https://www.redhat.com/archives/libvir-list/2017-May/msg00088.html I don't think this is a reason at all. Libguestfs uses an RPC system which was

Re: [libvirt] [PATCH] conf: Resolve corner case on fc_host deletion

On 04/29/2017 05:36 PM, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1420740 > > Testing found an inventive way to cause an error at shutdown by providing the > parent name for the fc host creation using the "same name" as the HBA. Since > the code thus assumed the parent host

Re: [libvirt] [PATCH v2] lib: Add note that bulk stats API queries may overrun RPC buffers

On Wed, May 24, 2017 at 12:49:58PM +0200, Michal Privoznik wrote: > That's quite exact. I mean the word 'guessing'. We can't really provide > reliable way of dealing with what you're suggesting (unless we cut the > limit really small) nor we can guarantee atomicity. Therefore I think it > would

Re: [libvirt] [PATCH v2] lib: Add note that bulk stats API queries may overrun RPC buffers

On Tue, May 23, 2017 at 05:07:40PM +0200, Michal Privoznik wrote: > Because: > > https://www.redhat.com/archives/libvir-list/2017-May/msg00088.html I don't think this is a reason at all. Libguestfs uses an RPC system which was modelled on the libvirt one, and has exactly the same problem with

[libvirt] [PATCH] conf: fix build issue caused by shadowing global declaration

Signed-off-by: Pavel Hrdina --- Pushed under build-breaker rule. src/conf/domain_conf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 32234e8a54..d3c6e9c0ab 100644 --- a/src/conf/domain_conf.c

Re: [libvirt] not able install libvirt

On 05/23/2017 04:52 PM, Eric Blake wrote: > [moderator note: re-posting to list with screenshot deleted, in order to > meet list policy size constraints] Thank you Eric. > > hello, > i am am trying to install libvmi tool on my xen hypervisor but some where > is asking to install libvirt

Re: [libvirt] [PATCH v2] lib: Add note that bulk stats API queries may overrun RPC buffers

On 05/24/2017 12:55 PM, Martin Kletzander wrote: > > > No, this has nothing to do with RPC. Let me "pseudocode" this: > > > int > virConnectGetAllDomainStats(virConnectPtr conn, >..., >unsigned int flags) > { >bool legacy = flags &

Re: [libvirt] [PATCH v2] lib: Add note that bulk stats API queries may overrun RPC buffers

On Wed, May 24, 2017 at 12:54:26PM +0200, Peter Krempa wrote: On Wed, May 24, 2017 at 12:49:58 +0200, Michal Privoznik wrote: On 05/24/2017 12:32 PM, Martin Kletzander wrote: > On Tue, May 23, 2017 at 05:29:52PM +0200, Peter Krempa wrote: >> On Tue, May 23, 2017 at 17:19:53 +0200, Martin

Re: [libvirt] [PATCH v2] lib: Add note that bulk stats API queries may overrun RPC buffers

On Tue, May 23, 2017 at 05:29:28PM +0200, Michal Privoznik wrote: On 05/23/2017 05:19 PM, Martin Kletzander wrote: On Tue, May 23, 2017 at 05:07:40PM +0200, Michal Privoznik wrote: On 05/23/2017 04:35 PM, Martin Kletzander wrote: On Tue, May 23, 2017 at 04:23:30PM +0200, Peter Krempa wrote:

Re: [libvirt] [PATCH v2] lib: Add note that bulk stats API queries may overrun RPC buffers

On Wed, May 24, 2017 at 12:49:58 +0200, Michal Privoznik wrote: > On 05/24/2017 12:32 PM, Martin Kletzander wrote: > > On Tue, May 23, 2017 at 05:29:52PM +0200, Peter Krempa wrote: > >> On Tue, May 23, 2017 at 17:19:53 +0200, Martin Kletzander wrote: > >>> On Tue, May 23, 2017 at 05:07:40PM +0200,

Re: [libvirt] [PATCH v2] lib: Add note that bulk stats API queries may overrun RPC buffers

On 05/24/2017 12:32 PM, Martin Kletzander wrote: > On Tue, May 23, 2017 at 05:29:52PM +0200, Peter Krempa wrote: >> On Tue, May 23, 2017 at 17:19:53 +0200, Martin Kletzander wrote: >>> On Tue, May 23, 2017 at 05:07:40PM +0200, Michal Privoznik wrote: >>> > On 05/23/2017 04:35 PM, Martin Kletzander

Re: [libvirt] [PATCH 2/2] qemu: don't relabel chardev source file if virtlogd is used

On Wed, May 24, 2017 at 12:25:51PM +0200, Martin Kletzander wrote: > On Tue, May 23, 2017 at 05:18:01PM +0100, Daniel P. Berrange wrote: > >On Tue, May 23, 2017 at 05:53:46PM +0200, Pavel Hrdina wrote: > >> On Tue, May 23, 2017 at 04:24:13PM +0100, Daniel P. Berrange wrote: > >> > On Tue, May 23,

Re: [libvirt] [PATCH v2] lib: Add note that bulk stats API queries may overrun RPC buffers

On Wed, May 24, 2017 at 12:32:05 +0200, Martin Kletzander wrote: > On Tue, May 23, 2017 at 05:29:52PM +0200, Peter Krempa wrote: > > On Tue, May 23, 2017 at 17:19:53 +0200, Martin Kletzander wrote: > > > On Tue, May 23, 2017 at 05:07:40PM +0200, Michal Privoznik wrote: > > > > On 05/23/2017 04:35

Re: [libvirt] [RFC PATCH 1/2] rpc: Bump maximum message size to 32M

On Tue, May 23, 2017 at 09:38:01 +0200, Martin Kletzander wrote: > On Mon, May 22, 2017 at 06:00:12PM +0200, Peter Krempa wrote: > > While most of the APIs are okay with 16M messages, the bulk stats API > > can run into the limit in big configurations. Before we devise a new > > plan for this,

Re: [libvirt] [PATCH v2] lib: Add note that bulk stats API queries may overrun RPC buffers

On Tue, May 23, 2017 at 05:29:52PM +0200, Peter Krempa wrote: On Tue, May 23, 2017 at 17:19:53 +0200, Martin Kletzander wrote: On Tue, May 23, 2017 at 05:07:40PM +0200, Michal Privoznik wrote: > On 05/23/2017 04:35 PM, Martin Kletzander wrote: > > On Tue, May 23, 2017 at 04:23:30PM +0200, Peter

Re: [libvirt] [PATCH 2/2] qemu: don't relabel chardev source file if virtlogd is used

On Tue, May 23, 2017 at 05:18:01PM +0100, Daniel P. Berrange wrote: On Tue, May 23, 2017 at 05:53:46PM +0200, Pavel Hrdina wrote: On Tue, May 23, 2017 at 04:24:13PM +0100, Daniel P. Berrange wrote: > On Tue, May 23, 2017 at 04:25:01PM +0200, Martin Kletzander wrote: > > On Mon, May 15, 2017 at

Re: [libvirt] [PATCH 1/1] vz: unlock dom until resize operation

On 05/03/2017 04:05 PM, Nikolay Shirokovskiy wrote: > > > On 03.05.2017 14:23, Konstantin Neumoin wrote: >> We have to use waitDomainJob instead of waitJob, because of it >> unlock the domain until job has finished, so domain will be available >> for other clients. >> >> Signed-off-by:

Re: [libvirt] [PATCH 1/1] vz: fix raise in vzDomainBlock

On 05/03/2017 04:10 PM, Nikolay Shirokovskiy wrote: > > > On 03.05.2017 13:44, Konstantin Neumoin wrote: >> Need begin job before lookup disk in config, >> because it can be edited at this moment. > > I would slightly change commit message to something like: > > Put domain access after

Re: [libvirt] [PATCH 1/1] vz: minor cleanup in prlsdkDomainSetUserPassword

On 05/03/2017 04:18 PM, Nikolay Shirokovskiy wrote: > > > On 03.05.2017 13:44, Konstantin Neumoin wrote: >> No need begin job for asynchronous operation. >> >> Signed-off-by: Konstantin Neumoin >> --- >> src/vz/vz_sdk.c | 16 ++-- >> 1 file changed, 2

Re: [libvirt] [libvirt-perl][PATCH 0/7] Implement sparse streams

On 05/23/2017 06:16 PM, Daniel P. Berrange wrote: > On Tue, May 23, 2017 at 05:05:34PM +0200, Michal Privoznik wrote: >> *** BLURB HERE *** >> >> Michal Privoznik (7): >> Fix send_all() callback helper >> Introduce flags to Stream::recv() >> Introduce Stream::recvHole() and

[libvirt] Plans for next release

we are getting close to the end of the month, so in order to ship on time I suggest we enter freeze on Friday (late or w.e.) then plan an RC2 around Tuesday, for a final release on Thursday if everything goes well, hope this works for everybody, there is a few days to push patches in time for