Re: [libvirt] [PATCH v3 3/3] tests : Testcases for loadparm

On 05/23/2017 09:27 AM, Farhan Ali wrote: > Add testcases for loadparm > > Signed-off-by: Farhan Ali > Reviewed-by: Boris Fiuczynski > Reviewed-by: Bjoern Walk > Reviewed-by: Marc Hartmayer

Re: [libvirt] [PATCH v3 2/3] qemu : Add loadparm to qemu command line string

On 05/23/2017 09:27 AM, Farhan Ali wrote: > Introduce a new QEMU capability for loadparm and if the capability is > supported by QEMU then append the loadparm value to "-machine" string > of qemu command line. > > Signed-off-by: Farhan Ali > Reviewed-by: Bjoern Walk

Re: [libvirt] [PATCH v3 1/3] conf : Add loadparm boot option for a boot device

On 05/23/2017 09:27 AM, Farhan Ali wrote: > Update the per device boot schema to add an optional loadparm parameter. > Extend the virDomainDeviceInfo to support loadparm option. > Modify the appropriate functions to parse loadparm from boot device xml. > FWIW: I got confused by the time I got

Re: [libvirt] [PATCH 1/1] CI: add code coverage analysis

Em 25/05/2017 03:49, Martin Kletzander escreveu: On Thu, May 25, 2017 at 01:14:36AM -0300, claudioandre...@gmail.com wrote: From: Claudio André It builds the code coverage report and uploads the coverage data to a web service in order to allow to track libvirt's

Re: [libvirt] [PATCH 1/1] CI: add code coverage analysis

Em 25/05/2017 05:21, Daniel P. Berrange escreveu: On Thu, May 25, 2017 at 01:14:36AM -0300, claudioandre...@gmail.com wrote: @@ -64,7 +65,8 @@ before_install: # the custom PATH is just to pick up OS-X homebrew & its harmless on Linux before_script: - -

Re: [libvirt] [PATCH] CI: show the log in case of failure

Em 25/05/2017 11:15, Martin Kletzander escreveu: I need to investigate why this doesn't work, I don't have that file [...] Just figured that out. The systems in Travis are just so old that the automake there doesn't create the test-suite.log =( The workers available in Travis are really

[libvirt] [PATCH 2/2] lxc: fixing wrong VIR_FREE after a return statement.

There is a VIR_FREE after a return statement. That code section is never executed and for this reason the "tty" variable is not being freed. This commit rearrange the logic. Signed-off-by: Julio Faracco --- src/lxc/lxc_container.c | 2 +- 1 file changed, 1 insertion(+), 1

[libvirt] [PATCH 1/2] configure: fixing acl missing variable.

This commit fixes an acl missing variable. The virt-acl.m4 inside the macro directory does not contain the variable 'with_acl'. So, it is being set as an empty string "with_acl=''". This is causing a missing option during the configuration, even if you have acl libs installed. Signed-off-by:

[libvirt] [PATCH v2 13/14] nodedev: Pass @def by reference to create/assign object

Since the @def is consumed by the assignment function, let's pass by reference instead of value and really consume it. Signed-off-by: John Ferlan --- src/conf/virnodedeviceobj.c| 8 src/conf/virnodedeviceobj.h| 2 +- src/node_device/node_device_hal.c

[libvirt] [PATCH v2 09/14] nodedev: Create helper for finding by name in driver

Create nodeDeviceObjFindByName which will perform the corresponding virNodeDeviceObjFindByName call for various node_device_driver callers rather than having the same repetitive code. Signed-off-by: John Ferlan --- src/node_device/node_device_driver.c | 96

[libvirt] [PATCH v2 12/14] nodedev: Remove privateData from virNodeDeviceObj

It was only ever used in node_device_hal.c which really never used it anyway since the NODE_DEV_UDI was never referenced. Remove free_udi() and @privData as well as the references to obj->privateData & obj->privateFree. Signed-off-by: John Ferlan ---

[libvirt] [PATCH v2 14/14] nodedev: Introduce virNodeDeviceObjNew

Create an allocator for the virNodeDeviceObjPtr - include setting up the mutex, saving the virNodeDeviceDefPtr, and locking the return object. Signed-off-by: John Ferlan --- src/conf/virnodedeviceobj.c | 33 ++--- 1 file changed, 22 insertions(+),

[libvirt] [PATCH v2 04/14] nodedev: Use switch for virNodeDeviceObjHasCap and virNodeDeviceCapMatch

In order to ensure that whenever something is added to virNodeDevCapType that both functions are considered for processing of a new capability, change the if-then-else construct into a switch statement. Signed-off-by: John Ferlan --- src/conf/virnodedeviceobj.c | 80

[libvirt] [PATCH v2 07/14] nodedev: Alter param to nodeDeviceUpdateDriverName

Rather than taking an virNodeDeviceObjPtr and dereffing the obj->def, just pass the def. Also check for an error in the function to have the calling function goto cleanup on error. Signed-off-by: John Ferlan --- src/node_device/node_device_driver.c | 14 -- 1

[libvirt] [PATCH v2 11/14] nodedev: Introduce virNodeDeviceObjGetDef

In preparation for privatizing the virNodeDeviceObj - create an accessor for the @def field and then use it for various callers. Signed-off-by: John Ferlan --- src/conf/virnodedeviceobj.c | 7 + src/conf/virnodedeviceobj.h | 2 ++

[libvirt] [PATCH v2 08/14] nodedev: Alter param to nodeDeviceUpdateCaps

Rather than taking an virNodeDeviceObjPtr and dereffing the obj->def, just pass the def. Signed-off-by: John Ferlan --- src/node_device/node_device_driver.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/node_device/node_device_driver.c

[libvirt] [PATCH v2 03/14] nodedev: Need to check for vport capable scsi_host for vHBA searches

When searching for an NPIV capable fc_host, not only does there need to be an "fc_host" capability with the specified wwnn/wwpn or fabric_wwn, but that scsi_host must be vport capable; otherwise, one could end up picking an exising vHBA/NPIV which wouldn't be good. Currently not a problem since

[libvirt] [PATCH v2 10/14] nodedev: Use consistent names for driver variables

A virNodeDeviceObjPtr is an @obj A virNodeDeviceObjListPtr is a @devs A virNodeDevicePtr is a @device Signed-off-by: John Ferlan --- src/node_device/node_device_driver.c | 70 ++-- src/node_device/node_device_hal.c| 42

[libvirt] [PATCH v2 06/14] nodedev: Cleanup driver code and prototypes

Alter the node_device_driver source and prototypes to follow more recent code style guidelines w/r/t spacing between functions, format of the function, and the prototype definitions. While the new names for nodeDeviceUpdateCaps, nodeDeviceUpdateDriverName, and nodeDeviceGetTime don't follow

[libvirt] [PATCH v2 01/14] test: Adjust cleanup/error paths for nodedev test APIs

- Rather than "goto cleanup;" on failure to virNodeDeviceObjFindByName an @obj, just return directly. This then allows the cleanup: label code to not have to check "if (obj)" before calling virNodeDeviceObjUnlock. This also simplifies some exit logic... - In

[libvirt] [PATCH v2 00/14] Work towards making virNodeDeviceObjPtr private

v1: https://www.redhat.com/archives/libvir-list/2017-May/msg00718.html Changes since v1: * Adjusted the title of cover letter to more appropriately match what's being done. * Added new patch 3 to cover issues I've noted in recent code reviews where additions to virNodeDevCapType may not

[libvirt] [PATCH v2 05/14] nodedev: Use common naming for virnodedeviceobj

A virNodeDeviceObjPtr is an @obj A virNodeDeviceObjListPtr is an @devs Signed-off-by: John Ferlan --- src/conf/virnodedeviceobj.c | 130 ++-- 1 file changed, 65 insertions(+), 65 deletions(-) diff --git a/src/conf/virnodedeviceobj.c

[libvirt] [PATCH v2 02/14] nodedev: Fix locking in virNodeDeviceObjRemove

The current mechanism doesn't lock each element in devs->objs as it's looking at it, rather it keeps locking/unlocking the passed element for which the removal is being attempted. Fix things to lock each element as we're looking at them. Signed-off-by: John Ferlan ---

Re: [libvirt] [PATCH 6/7] node_device: introduce new capability FC_RPORT

On 05/22/2017 02:38 AM, Bjoern Walk wrote: > Similar to scsi_host and fc_host, there is a relation between a > scsi_target and its transport specific fc_remote_port. Let's expose this > relation and relevant information behind it. > > An example for a virsh nodedev-dumpxml: > > virsh #

Re: [libvirt] [PATCH 7/7] docs: update news.xml

On 05/22/2017 02:38 AM, Bjoern Walk wrote: > Mention CCW and fc_remote_port capablities in the news.xml file. > > Reviewed-by: Boris Fiuczynski > Signed-off-by: Bjoern Walk > --- > docs/news.xml | 11 +++ > 1 file changed, 11

Re: [libvirt] [PATCH 5/7] util: helper functions for fibre channel devices

On 05/22/2017 02:38 AM, Bjoern Walk wrote: > We will need some convenient helper functions for managing sysfs-entries > for fibre channel-backed devices. Let's implement them and make them > available in the private API. > > Signed-off-by: Bjoern Walk > --- >

Re: [libvirt] [PATCH 4/7] virsh: nodedev: ability to filter CCW capabilities

On 05/22/2017 02:38 AM, Bjoern Walk wrote: > Now that the node_device driver is aware of CCW devices, let's hook up > virsh so that we can filter them properly. > > Reviewed-by: Boris Fiuczynski > Reviewed-by: Marc Hartmayer >

Re: [libvirt] [PATCH 3/7] node_device: detect CCW devices

On 05/22/2017 02:38 AM, Bjoern Walk wrote: > Make CCW devices available to the node_device driver. The devices are > already seen by udev so let's implement necessary code for detecting > them properly. > > Topologically, CCW devices are similar to PCI devices, e.g.: > > +- ccw_0_0_1a2b >

Re: [libvirt] [PATCH 2/7] node_device: Unlock obj in case of an error too

On 05/22/2017 02:38 AM, Bjoern Walk wrote: > From: Marc Hartmayer > > Unlock @obj in case of an error too. > > Reviewed-by: Bjoern Walk > Reviewed-by: Boris Fiuczynski > Signed-off-by: Marc Hartmayer

Re: [libvirt] [PATCH 1/7] node_device: Use the iterator variable

On 05/22/2017 02:38 AM, Bjoern Walk wrote: > From: Marc Hartmayer > > As the switch statement checks data.type of the iterator variable @cap > it must use this variable for the update too. s/must/can... I can adjust the commit message before pushing though, so no

[libvirt] Remotable Libvirt

Hi Everyone, We are working towards building on the virtualization management functionality in cockpit (http://cockpit-project.org/) and wanted to get some feedback on the best way to integrate with libvirt. As a quick overview, cockpit aims to talk to existing remotable system APIs.

[libvirt] Remotable Libvirt

Hi Everyone, We are working towards building on the virtualization management functionality in cockpit (http://cockpit-project.org/) and wanted to get some feedback on the best way to integrate with libvirt. As a quick overview, cockpit aims to talk to existing remotable system APIs.

Re: [libvirt] RFE: virsh list improvement (--description and --details)

As you wish. I have made python script for my customer: https://github.com/psztoch/virt-report Nevertheless, I think the second version of my patch for the virsh list is simple and traightforward, and falls within the scope of a simple low-level virsh tool. And of course should be merged

[libvirt] [PATCH 11/08] interface: Alter virInterfaceObjListAssignDef @def param

Rather than pass by value, let's pass by reference since the object ends up "owning" the XML definition, let's make that ownership a bit more real. Signed-off-by: John Ferlan --- Since 09 and 10 weren't reviewed yet, I'll add one more. src/conf/virinterfaceobj.c | 12

Re: [libvirt] [virt-tools-list] Problem with firewalls on Arch Linux

On Thu, May 25, 2017 at 09:42:42AM -0400, Cole Robinson wrote: > On 05/25/2017 06:08 AM, Derek Richline wrote: > > Hi all: > > > > I noticed that Virt Manager will not start the network "default" unless > > it detects a running firewalld. Arch Linux only ships with iptables by > > default. Can

[libvirt] [PATCH] node_device: fix memory leak in nodeDeviceSysfsGetSCSIHostCaps

The @tmp is allocated in virVHBAGetConfig in virVHBAIsVportCapable condition, it will lost when virVHBAGetConfig called again. Signed-off-by: Yi Wang --- src/node_device/node_device_linux_sysfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [libvirt] [PATCH] CI: show the log in case of failure

On Thu, May 25, 2017 at 02:35:53PM +0200, Martin Kletzander wrote: On Thu, May 25, 2017 at 02:19:45AM -0300, claudioandre...@gmail.com wrote: From: Claudio André Disclosure the content of the 'test-suite.log' file (if available) in case of failures inside

[libvirt] [PATCH] util: fix memory leak in virSocketAddrFormatFull

The @ipv6_host allocated in virAsprintf may be lost when virAsprintf addrstr failed. Signed-off-by: Yi Wang --- src/util/virsocketaddr.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/util/virsocketaddr.c b/src/util/virsocketaddr.c index

Re: [libvirt] [virt-tools-list] Problem with firewalls on Arch Linux

On 05/25/2017 06:08 AM, Derek Richline wrote: > Hi all: > > I noticed that Virt Manager will not start the network "default" unless > it detects a running firewalld. Arch Linux only ships with iptables by > default. Can Virt-Manager be patched to not check as aggressively for a > firewall (or

Re: [libvirt] [PATCH v2 3/3] virQEMUDriverDomainABIStability: Check for memoryBacking

On Wed, May 24, 2017 at 16:06:56 +0100, Daniel Berrange wrote: > On Wed, May 24, 2017 at 04:45:57PM +0200, Michal Privoznik wrote: > > https://bugzilla.redhat.com/show_bug.cgi?id=1450349 > > > > Problem is, qemu fails to load guest memory image if these > > attribute change on migration/restore

Re: [libvirt] [PATCH v2 2/3] virDomainXMLOption: Introduce virDomainABIStabilityDomain

On Wed, May 24, 2017 at 16:45:56 +0200, Michal Privoznik wrote: > While checking for ABI stability, drivers might pose additional > checks that are not valid for general case. For instance, qemu > driver might check some memory backing attributes because of how > qemu works. But those attributes

Re: [libvirt] [PATCH] CI: show the log in case of failure

On Thu, May 25, 2017 at 02:19:45AM -0300, claudioandre...@gmail.com wrote: From: Claudio André Disclosure the content of the 'test-suite.log' file (if available) in case of failures inside Travis-CI. This is needed to understand what happened and to provide hints

Re: [libvirt] [PATCH v2 RFC 0/4] qemu: replace nested job with interruptible async job state

ping On 02.05.2017 13:06, Nikolay Shirokovskiy wrote: > This is the next version of RFC [1] 'drop nested job concept'. Actually > it is quite different from the first. Patches that accomodate callers to > use functions to enter/exit monitor with without driver and asyncJob arguments > are moved

Re: [libvirt] [PATCH] qemu: Use correct variable in qemuDomainSetBlockIoTune

On Thu, May 25, 2017 at 13:47:56 +0200, Ján Tomko wrote: > On Thu, May 25, 2017 at 01:17:08PM +0200, Peter Krempa wrote: > > 'param' contains the correct element from 'params'. > > > > If the group name would not be the first element libvirtd would crash. > > > > Is there a public bug you could

Re: [libvirt] [PATCH] qemu: Use correct variable in qemuDomainSetBlockIoTune

On Thu, May 25, 2017 at 01:17:08PM +0200, Peter Krempa wrote: 'param' contains the correct element from 'params'. If the group name would not be the first element libvirtd would crash. Is there a public bug you could link here? Introduced in c53bd25b13. --- src/qemu/qemu_driver.c | 2 +- 1

Re: [libvirt] [PATCH] qemu: Use correct variable in qemuDomainSetBlockIoTune

On Thu, May 25, 2017 at 01:17:08PM +0200, Peter Krempa wrote: > 'param' contains the correct element from 'params'. > > If the group name would not be the first element libvirtd would crash. > > Introduced in c53bd25b13. > --- > src/qemu/qemu_driver.c | 2 +- > 1 file changed, 1 insertion(+), 1

[libvirt] [PATCH] qemu: Use correct variable in qemuDomainSetBlockIoTune

'param' contains the correct element from 'params'. If the group name would not be the first element libvirtd would crash. Introduced in c53bd25b13. --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c

[libvirt] [PATCH v3] Regression: Report correct CPUs present on executing virsh nodecpumap

On executing the virsh nodecpumap command, the number of CPUs present was shown as (last cpu online id + 1). This patch fixes the issue by reporting the current number of CPUs present. Signed-off-by: Nitesh Konkar --- src/util/virhostcpu.c | 2 +- 1 file changed, 1

Re: [libvirt] [PATCH v2] Regression: Report correct CPUs present on executing virsh nodecpumap

On Thu, May 25, 2017 at 2:14 PM, Ján Tomko wrote: > On Thu, May 25, 2017 at 02:04:16PM +0530, Nitesh Konkar wrote: > >> On executing the virsh nodecpumap command, the number >> of CPUs present was shown as (last cpu online id + 1). This >> patch fixes the issue by reporting

Re: [libvirt] [PATCH v2] Regression: Report correct CPUs present on executing virsh nodecpumap

On Thu, May 25, 2017 at 02:04:16PM +0530, Nitesh Konkar wrote: On executing the virsh nodecpumap command, the number of CPUs present was shown as (last cpu online id + 1). This patch fixes the issue by reporting the current number of CPUs present. Signed-off-by: Nitesh Konkar

Re: [libvirt] [PATCH v2] Regression: Report correct CPUs present on executing virsh nodecpumap

Yes I did, limited to my knowledge. On Thu, May 25, 2017 at 2:08 PM, Nitesh Konkar < niteshkonkar.libv...@gmail.com> wrote: > Yes I did. > > On Thu, May 25, 2017 at 2:07 PM, Peter Krempa wrote: > >> On Thu, May 25, 2017 at 14:04:16 +0530, Nitesh Konkar wrote: >> > On

Re: [libvirt] [PATCH v2] Regression: Report correct CPUs present on executing virsh nodecpumap

On Thu, May 25, 2017 at 14:04:16 +0530, Nitesh Konkar wrote: > On executing the virsh nodecpumap command, the number > of CPUs present was shown as (last cpu online id + 1). This > patch fixes the issue by reporting the current number of > CPUs present. > > Signed-off-by: Nitesh Konkar

[libvirt] [PATCH v2] Regression: Report correct CPUs present on executing virsh nodecpumap

On executing the virsh nodecpumap command, the number of CPUs present was shown as (last cpu online id + 1). This patch fixes the issue by reporting the current number of CPUs present. Signed-off-by: Nitesh Konkar --- src/util/virhostcpu.c | 2 +- 1 file changed, 1

Re: [libvirt] [PATCH 1/1] CI: add code coverage analysis

On Thu, May 25, 2017 at 01:14:36AM -0300, claudioandre...@gmail.com wrote: > From: Claudio André > > It builds the code coverage report and uploads the coverage data to a web > service in order to allow to track libvirt's code coverage over time. > --- > .travis.yml

Re: [libvirt] [PATCH] Regression: Report correct CPUs present on executing virsh nodecpumap

On Wed, May 24, 2017 at 22:05:54 +0530, Nitesh Konkar wrote: > On Wed, May 24, 2017 at 8:09 PM, Ján Tomko wrote: > > > On Wed, May 24, 2017 at 07:46:00PM +0530, Nitesh Konkar wrote: > > > >> Recent changes to virbitmap.c file created a regression > >> where on executing the

Re: [libvirt] [PATCH] CI: show the log in case of failure

On Thu, May 25, 2017 at 02:19:45AM -0300, claudioandre...@gmail.com wrote: From: Claudio André Disclosure the content of the 'test-suite.log' file (if available) in s/Disclosure/Disclose/ ACK && Pushed. signature.asc Description: Digital signature -- libvir-list

Re: [libvirt] [PATCH 1/1] CI: add code coverage analysis

On Thu, May 25, 2017 at 01:14:36AM -0300, claudioandre...@gmail.com wrote: From: Claudio André It builds the code coverage report and uploads the coverage data to a web service in order to allow to track libvirt's code coverage over time. --- You can add the links

Re: [libvirt] [PATCH] Regression: Report correct CPUs present on executing virsh nodecpumap

On Wed, May 24, 2017 at 22:05:54 +0530, Nitesh Konkar wrote: > On Wed, May 24, 2017 at 8:09 PM, Ján Tomko wrote: > > > On Wed, May 24, 2017 at 07:46:00PM +0530, Nitesh Konkar wrote: > > > >> Recent changes to virbitmap.c file created a regression > >> where on executing the

Re: [libvirt] [PATCH v2] lib: Add note that bulk stats API queries may overrun RPC buffers

On 05/24/2017 09:30 PM, Martin Kletzander wrote: > On Wed, May 24, 2017 at 05:12:06PM +0200, Michal Privoznik wrote: >> On 05/24/2017 04:58 PM, Richard W.M. Jones wrote: >>> On Wed, May 24, 2017 at 04:16:45PM +0200, Michal Privoznik wrote: On 05/24/2017 02:47 PM, Richard W.M. Jones wrote:

[libvirt] [V4 RESEND PATCH] Expose resource control capabilites on cache bank

* This patch amends the cache bank capability as follow: For CDP enabled on x86 arch, we will have: ... * Added a new testdata directory `linux-resctrl-cdp` to test CDP enabled case. * Along with vircaps2xmltest case updated. Signed-off-by: Eli Qiao

Re: [libvirt] [PATCH 2/2] virsh: Don't attempt polkit processing for non local authn/authz

On 05/24/2017 05:45 PM, John Ferlan wrote: > > > On 05/24/2017 10:38 AM, Michal Privoznik wrote: >> On 05/11/2017 05:04 PM, John Ferlan wrote: >>> https://bugzilla.redhat.com/show_bug.cgi?id=1374126 >>> >>> Due to how the processing for authentication using polkit works, the >>> virshConnect