Re: [libvirt] [PATCH v2] virsh: add [--domain DOMAIN] option to domxml-to-native DOMAIN COMMAND

2017-05-29 Thread Peter Krempa
On Mon, May 29, 2017 at 14:08:53 -0400, Daniel Liu wrote: > The option allows someone to run domain-to-native on already existing > domain without the need of supplying their XML. It is basically > wrapper around 'virsh dumpxml | virsh domxml-to-native /dev/stdin'. > Resolves: https://bugzilla.

Re: [libvirt] [libvirt-sandbox PATCH] mkinitrd: Add missing fscrypto module

2017-05-29 Thread Guido Günther
On Mon, May 29, 2017 at 11:42:09AM +0200, Cedric Bosdonnat wrote: > On Sat, 2017-05-27 at 13:04 +0200, Guido Günther wrote: > > --- > >  libvirt-sandbox/libvirt-sandbox-builder-machine.c | 1 + > >  1 file changed, 1 insertion(+) > > > > diff --git a/libvirt-sandbox/libvirt-sandbox-builder-machine.

Re: [libvirt] [libvirt-sandbox PATCH] docker: Don't ignore qemu-img errors

2017-05-29 Thread Guido Günther
On Mon, May 29, 2017 at 11:43:53AM +0200, Cedric Bosdonnat wrote: > On Sat, 2017-05-27 at 18:30 +0200, Guido Günther wrote: > > --- > >  libvirt-sandbox/image/sources/docker.py | 2 +- > >  1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libvirt-sandbox/image/sources/docker.py >

Re: [libvirt] [PATCH] virsh: add --domain option for domain-to-native

2017-05-29 Thread Julio Faracco
It would be nice to include the changes into documentation, wouldn't it? tools/virsh.pod has an entry for example. 2017-05-29 16:40 GMT-03:00 Dan : > On Mon, May 29, 2017 at 08:53:18PM +0200, Martin Kletzander wrote: >> On Mon, May 29, 2017 at 02:25:03PM -0400, Dan wrote: >> > On Tue, May 16, 2017

Re: [libvirt] [PATCH] virsh: add --domain option for domain-to-native

2017-05-29 Thread Dan
On Mon, May 29, 2017 at 08:53:18PM +0200, Martin Kletzander wrote: > On Mon, May 29, 2017 at 02:25:03PM -0400, Dan wrote: > > On Tue, May 16, 2017 at 11:41:55AM +0200, Martin Kletzander wrote: > > > On Mon, May 15, 2017 at 04:29:48AM -0400, Daniel Liu wrote: > > > > Fix bug 835476[1]. > > > > > >

Re: [libvirt] [PATCH] virsh: add --domain option for domain-to-native

2017-05-29 Thread Martin Kletzander
On Mon, May 29, 2017 at 02:25:03PM -0400, Dan wrote: On Tue, May 16, 2017 at 11:41:55AM +0200, Martin Kletzander wrote: On Mon, May 15, 2017 at 04:29:48AM -0400, Daniel Liu wrote: > Fix bug 835476[1]. It's enough to mention it below (as you did). > virsh: add [--domain DOMAIN] option to domxm

Re: [libvirt] [PATCH] virsh: add --domain option for domain-to-native

2017-05-29 Thread Dan
On Tue, May 16, 2017 at 11:41:55AM +0200, Martin Kletzander wrote: > On Mon, May 15, 2017 at 04:29:48AM -0400, Daniel Liu wrote: > > Fix bug 835476[1]. > > It's enough to mention it below (as you did). > > > virsh: add [--domain DOMAIN] option to domxml-to-native DOMAIN COMMAND > > This first l

[libvirt] [PATCH v2] virsh: add [--domain DOMAIN] option to domxml-to-native DOMAIN COMMAND

2017-05-29 Thread Daniel Liu
The option allows someone to run domain-to-native on already existing domain without the need of supplying their XML. It is basically wrapper around 'virsh dumpxml | virsh domxml-to-native /dev/stdin'. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=835476 --- tools/virsh-domain.c | 52 +

[libvirt] [PATCH] qemu: Don't error out if allocation info can't be queried

2017-05-29 Thread Peter Krempa
qemuDomainGetBlockInfo would error out if qemu did not report 'wr_highest_offset'. This usually does not happen, but can happen briefly during active layer block commit. There's no need to report the error, we can simply report that the disk is fully alocated at that point. Resolves: https://bugzi

[libvirt] [PATCH v2 4/4] security: don't relabel chardev source if virtlogd is used as stdio handler

2017-05-29 Thread Pavel Hrdina
In the case that virtlogd is used as stdio handler we pass to QEMU only FD to a PIPE connected to virtlogd instead of the file itself. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1430988 Signed-off-by: Pavel Hrdina --- Notes: new in v2 src/lxc/lxc_process.c| 6 ++---

[libvirt] [PATCH v2 1/4] conf: move seclabel for chardev source to the correct sturcture

2017-05-29 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- Notes: new in v2 src/conf/domain_conf.c | 46 +++-- src/conf/domain_conf.h | 9 src/security/security_dac.c | 26 ++- src/security/security_manager.c | 4 ++-- src/securi

[libvirt] [PATCH v2 3/4] qemu: propagate chardevStdioLogd to qemuBuildChrChardevStr

2017-05-29 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- Notes: new in v2 This is not required to fix the issue by the last patch in the series, however it improves the code that we decide whether to use virtlogd or not by checking the same variable that is updated while preparing the guest start

[libvirt] [PATCH v2 0/4] fix labeling for chardev source path

2017-05-29 Thread Pavel Hrdina
Pavel Hrdina (4): conf: move seclabel for chardev source to the correct sturcture qemu: introduce chardevStdioLogd to qemu private data qemu: propagate chardevStdioLogd to qemuBuildChrChardevStr security: don't relabel chardev source if virtlogd is used as stdio handler src/conf/domai

[libvirt] [PATCH v2 2/4] qemu: introduce chardevStdioLogd to qemu private data

2017-05-29 Thread Pavel Hrdina
In QEMU driver we can use virtlogd as stdio handler for source backend of char devices if current QEMU is new enough and it's enabled in qemu.conf. We should store this information while starting a guest because the config option may change while the guest is running. Signed-off-by: Pavel Hrdina

Re: [libvirt] [PATCH v2] nodedev: Increase the netlink socket buffer size to the one used by udev

2017-05-29 Thread Erik Skultety
On Mon, May 29, 2017 at 02:16:17PM +0200, Michal Privoznik wrote: > On 05/19/2017 03:16 PM, Erik Skultety wrote: > > From: "ning.bo" > > > > When a number of SRIOV VFs (up to 128 on Intel XL710) is created: > > for i in `seq 0 1`; do > > echo 63 > /sys/class/net//device/sriov_numvfs > > done > >

Re: [libvirt] [PATCH] qemu: Fix serial stub console allocation

2017-05-29 Thread Peter Krempa
On Mon, May 29, 2017 at 13:11:09 +0200, Erik Skultety wrote: > When adding the aliased serial stub console, the structure wasn't > properly allocated (VIR_ALLOC instead of virDomainChrDefNew) which then > resulted in SIGSEGV in virDomainChrSourceIsEqual during a serial device > coldplug. > > https

Re: [libvirt] [PATCH v2] nodedev: Increase the netlink socket buffer size to the one used by udev

2017-05-29 Thread Michal Privoznik
On 05/19/2017 03:16 PM, Erik Skultety wrote: > From: "ning.bo" > > When a number of SRIOV VFs (up to 128 on Intel XL710) is created: > for i in `seq 0 1`; do > echo 63 > /sys/class/net//device/sriov_numvfs > done > > libvirtd will then report "udev_monitor_receive_device returned NULL" > error

Re: [libvirt] [PATCH] tools: make setvcpus --maximum imply --config

2017-05-29 Thread Martin Kletzander
On Mon, May 29, 2017 at 02:23:39PM +0800, Chen Hanxiao wrote: Hi, Should we remove this restriction(--maximum MUST be used with --config)? Regards, -Chen It doesn't make much sense to remove it now. There is no hypervisor that allows that and we can remove it in the future. I'm not sayin

Re: [libvirt] [PATCH] CI: also run tests using updated distro(s)

2017-05-29 Thread Martin Kletzander
On Sun, May 28, 2017 at 11:07:41PM -0300, claudioandre...@gmail.com wrote: From: Claudio André It is possible to test libvirt using other distros in Travis via Docker; including (but not limited to) Fedora and Ubuntu. --- Notes: * see it working at: https://travis-ci.org/claudioandre/libvirt/b

[libvirt] [PATCH go-xml] Add support for Node Device with basic testing.

2017-05-29 Thread Vladik Romanovsky
--- node_device.go | 277 node_device_test.go | 111 + 2 files changed, 388 insertions(+) create mode 100644 node_device.go create mode 100644 node_device_test.go diff --git a/node_device.go b/node_device.go new file

[libvirt] [PATCH] qemu: Fix serial stub console allocation

2017-05-29 Thread Erik Skultety
When adding the aliased serial stub console, the structure wasn't properly allocated (VIR_ALLOC instead of virDomainChrDefNew) which then resulted in SIGSEGV in virDomainChrSourceIsEqual during a serial device coldplug. https://bugzilla.redhat.com/show_bug.cgi?id=1434278 Signed-off-by: Erik Skult

Re: [libvirt] [libvirt-sandbox PATCH] docker: Don't ignore qemu-img errors

2017-05-29 Thread Cedric Bosdonnat
On Sat, 2017-05-27 at 18:30 +0200, Guido Günther wrote: > --- >  libvirt-sandbox/image/sources/docker.py | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libvirt-sandbox/image/sources/docker.py > b/libvirt-sandbox/image/sources/docker.py > index 43e9c32..aa5675e 100755 > -

Re: [libvirt] [libvirt-sandbox PATCH] mkinitrd: Add missing fscrypto module

2017-05-29 Thread Cedric Bosdonnat
On Sat, 2017-05-27 at 13:04 +0200, Guido Günther wrote: > --- >  libvirt-sandbox/libvirt-sandbox-builder-machine.c | 1 + >  1 file changed, 1 insertion(+) > > diff --git a/libvirt-sandbox/libvirt-sandbox-builder-machine.c > b/libvirt-sandbox/libvirt-sandbox-builder-machine.c > index bdec490..7204

Re: [libvirt] [PATCH] virCapabilitiesInitCaches: Don't leak @cpus

2017-05-29 Thread Peter Krempa
On Mon, May 29, 2017 at 10:10:26 +0200, Michal Privoznik wrote: > The @cpus is allocated by virFileReadValueBitmap() but never > freed: > > ==21274== 40 (32 direct, 8 indirect) bytes in 1 blocks are definitely lost in > loss record 808 of 1,004 > ==21274==at 0x4C2E080: calloc (vg_replace_mall

[libvirt] [PATCH] virCapabilitiesInitCaches: Don't leak @cpus

2017-05-29 Thread Michal Privoznik
The @cpus is allocated by virFileReadValueBitmap() but never freed: ==21274== 40 (32 direct, 8 indirect) bytes in 1 blocks are definitely lost in loss record 808 of 1,004 ==21274==at 0x4C2E080: calloc (vg_replace_malloc.c:711) ==21274==by 0x54BA561: virAlloc (viralloc.c:144) ==21274==

Re: [libvirt] [PATCH v2] nodedev: Increase the netlink socket buffer size to the one used by udev

2017-05-29 Thread Erik Skultety
On Fri, May 19, 2017 at 03:16:26PM +0200, Erik Skultety wrote: > From: "ning.bo" > Ping? > When a number of SRIOV VFs (up to 128 on Intel XL710) is created: > for i in `seq 0 1`; do > echo 63 > /sys/class/net//device/sriov_numvfs > done > > libvirtd will then report "udev_monitor_receive_devic