[libvirt] [PATCH go-xml] Add support for device sound

2017-05-31 Thread zhenwei.pi
--- domain.go | 11 +++ domain_test.go | 20 2 files changed, 31 insertions(+) diff --git a/domain.go b/domain.go index de47c07..bf0b851 100644 --- a/domain.go +++ b/domain.go @@ -283,6 +283,16 @@ type DomainMemBalloon struct { Address *DomainAddress

Re: [libvirt] Remotable Libvirt

2017-05-31 Thread Cole Robinson
On 05/31/2017 01:00 PM, Richard W.M. Jones wrote: > On Wed, May 31, 2017 at 09:22:41AM -0700, Peter wrote: >> The javascript is always run in the users browser. The dbus calls or >> system commands are sent by the javascript via a websocket to >> cockpit-ws. It then forwards those messages on to

[libvirt] [PATCH V3] CI: also run tests using updated distro(s)

2017-05-31 Thread claudioandre . br
From: Claudio André It is possible to test libvirt using other distros in Travis via Docker; including (but not limited to) Fedora and Ubuntu. --- https://travis-ci.org/claudioandre/libvirt/builds/237995646 .travis.yml| 19 ++--- tests/travis-ci.sh |

Re: [libvirt] Remotable Libvirt

2017-05-31 Thread Richard W.M. Jones
On Wed, May 31, 2017 at 09:22:41AM -0700, Peter wrote: > The javascript is always run in the users browser. The dbus calls or > system commands are sent by the javascript via a websocket to > cockpit-ws. It then forwards those messages on to the correct > cockpit-bridge. Based on the payload the

Re: [libvirt] Remotable Libvirt

2017-05-31 Thread Peter
On 05/31/2017 08:52 AM, Richard W.M. Jones wrote: On Wed, May 31, 2017 at 04:02:42PM +0100, Daniel P. Berrange wrote: On Wed, May 31, 2017 at 03:59:10PM +0100, Richard W.M. Jones wrote: On Thu, May 25, 2017 at 10:26:47AM -0700, Peter wrote: The majority of cockpit is implemented in

Re: [libvirt] [PATCH V2] CI: also run tests using updated distro(s)

2017-05-31 Thread Claudio André
Em 31/05/2017 12:38, Daniel P. Berrange escreveu: On Wed, May 31, 2017 at 12:21:05PM -0300, claudioandre...@gmail.com wrote: From: Claudio André It is possible to test libvirt using other distros in Travis via Docker; including (but not limited to) Fedora and

Re: [libvirt] [PATCH] Add some news items for the 3.4.0 release

2017-05-31 Thread Peter Krempa
On Wed, May 31, 2017 at 17:35:52 +0200, Martin Kletzander wrote: > On Wed, May 31, 2017 at 04:22:07PM +0200, Peter Krempa wrote: > > On Wed, May 31, 2017 at 16:06:48 +0200, Martin Kletzander wrote: > > > Signed-off-by: Martin Kletzander > > > --- > > > I could not be bothered

Re: [libvirt] Remotable Libvirt

2017-05-31 Thread Richard W.M. Jones
On Wed, May 31, 2017 at 04:02:42PM +0100, Daniel P. Berrange wrote: > On Wed, May 31, 2017 at 03:59:10PM +0100, Richard W.M. Jones wrote: > > On Thu, May 25, 2017 at 10:26:47AM -0700, Peter wrote: > > > The majority of cockpit is implemented in > > > javascript. > > > > How about using the

Re: [libvirt] [PATCH] Add some news items for the 3.4.0 release

2017-05-31 Thread Martin Kletzander
On Wed, May 31, 2017 at 05:35:52PM +0200, Martin Kletzander wrote: On Wed, May 31, 2017 at 04:22:07PM +0200, Peter Krempa wrote: On Wed, May 31, 2017 at 16:06:48 +0200, Martin Kletzander wrote: Signed-off-by: Martin Kletzander --- I could not be bothered to split the

Re: [libvirt] [PATCH v2] virsh: add [--domain DOMAIN] option to domxml-to-native DOMAIN COMMAND

2017-05-31 Thread Martin Kletzander
On Wed, May 31, 2017 at 11:27:42AM -0400, Dan wrote: On Tue, May 30, 2017 at 08:45:37AM +0200, Peter Krempa wrote: On Mon, May 29, 2017 at 14:08:53 -0400, Daniel Liu wrote: > The option allows someone to run domain-to-native on already existing > domain without the need of supplying their XML.

Re: [libvirt] [PATCH V2] CI: also run tests using updated distro(s)

2017-05-31 Thread Daniel P. Berrange
On Wed, May 31, 2017 at 12:21:05PM -0300, claudioandre...@gmail.com wrote: > From: Claudio André > > It is possible to test libvirt using other distros in Travis via Docker; > including (but not limited to) Fedora and Ubuntu. > --- > See it in action at >

[libvirt] [PATCH go-xml] Add support for Node Device with basic testing.

2017-05-31 Thread Vladik Romanovsky
--- node_device.go | 168 node_device_test.go | 128 +++ 2 files changed, 296 insertions(+) create mode 100644 node_device.go create mode 100644 node_device_test.go diff --git a/node_device.go

Re: [libvirt] [PATCH] Add some news items for the 3.4.0 release

2017-05-31 Thread Martin Kletzander
On Wed, May 31, 2017 at 04:22:07PM +0200, Peter Krempa wrote: On Wed, May 31, 2017 at 16:06:48 +0200, Martin Kletzander wrote: Signed-off-by: Martin Kletzander --- I could not be bothered to split the patches. Also, please review whatever you know about as this is just a

Re: [libvirt] [PATCH v2] virsh: add [--domain DOMAIN] option to domxml-to-native DOMAIN COMMAND

2017-05-31 Thread Dan
On Tue, May 30, 2017 at 08:45:37AM +0200, Peter Krempa wrote: > On Mon, May 29, 2017 at 14:08:53 -0400, Daniel Liu wrote: > > The option allows someone to run domain-to-native on already existing > > domain without the need of supplying their XML. It is basically > > wrapper around 'virsh

Re: [libvirt] [PATCH] virsh: add --domain option for domain-to-native

2017-05-31 Thread Dan
On Mon, May 29, 2017 at 05:50:46PM -0300, Julio Faracco wrote: > It would be nice to include the changes into documentation, wouldn't it? > tools/virsh.pod has an entry for example. > Many thanks for pointing it out. I modified man page by editing virsh.pod in v3 patch. Dan > 2017-05-29 16:40

[libvirt] [PATCH v4 0/3] Loadparm support

2017-05-31 Thread Farhan Ali
This patch series introduces the support for new s390x 'loadparm' feature. The 'loadparm' can be used to select the boot entry to boot from, for a boot device. Here is a link to the QEMU patches: https://lists.nongnu.org/archive/html/qemu-devel/2017-05/msg00192.html ChangeLog - v3 -> v4

[libvirt] [PATCH v4 1/3] conf : Add loadparm boot option for a boot device

2017-05-31 Thread Farhan Ali
Update the per device boot schema to add an optional loadparm parameter. eg: Extend the virDomainDeviceInfo to support loadparm option. Modify the appropriate functions to parse loadparm from boot device xml. Signed-off-by: Farhan Ali Reviewed-by: Bjoern Walk

[libvirt] [PATCH v4 3/3] news: Update news and libvirt documentation

2017-05-31 Thread Farhan Ali
Update news and libvirt docs for loadparm. Signed-off-by: Farhan Ali --- docs/formatdomain.html.in | 9 +++-- docs/news.xml | 11 +++ 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/docs/formatdomain.html.in

[libvirt] [PATCH V2] CI: also run tests using updated distro(s)

2017-05-31 Thread claudioandre . br
From: Claudio André It is possible to test libvirt using other distros in Travis via Docker; including (but not limited to) Fedora and Ubuntu. --- See it in action at https://travis-ci.org/claudioandre/libvirt/builds/237687907 .travis.yml| 23

Re: [libvirt] [PATCH v2] virsh: add [--domain DOMAIN] option to domxml-to-native DOMAIN COMMAND

2017-05-31 Thread Dan
On Wed, May 31, 2017 at 02:32:51PM +0200, Martin Kletzander wrote: > On Mon, May 29, 2017 at 02:08:53PM -0400, Daniel Liu wrote: > > The option allows someone to run domain-to-native on already existing > > domain without the need of supplying their XML. It is basically > > wrapper around 'virsh

[libvirt] [PATCH v3] virsh: add [--domain DOMAIN] option to domxml-to-native DOMAIN COMMAND

2017-05-31 Thread Daniel Liu
The option allows someone to run domain-to-native on already existing domain without the need of supplying their XML. It is basically wrapper around 'virsh dumpxml | virsh domxml-to-native /dev/stdin'. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=835476 --- tools/virsh-domain.c | 53

Re: [libvirt] [PATCH v3 2/2] virQEMUDriverDomainABIStability: Check for memoryBacking

2017-05-31 Thread Peter Krempa
On Fri, May 26, 2017 at 11:58:45 +0200, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1450349 > > Problem is, qemu fails to load guest memory image if these > attribute change on migration/restore from an image. > > Signed-off-by: Michal Privoznik >

Re: [libvirt] [PATCH v3 1/2] virDomainXMLOption: Introduce virDomainABIStabilityDomain

2017-05-31 Thread Peter Krempa
On Fri, May 26, 2017 at 11:58:44 +0200, Michal Privoznik wrote: > While checking for ABI stability, drivers might pose additional > checks that are not valid for general case. For instance, qemu > driver might check some memory backing attributes because of how > qemu works. But those attributes

Re: [libvirt] Remotable Libvirt

2017-05-31 Thread Daniel P. Berrange
On Wed, May 31, 2017 at 03:59:10PM +0100, Richard W.M. Jones wrote: > On Thu, May 25, 2017 at 10:26:47AM -0700, Peter wrote: > > The majority of cockpit is implemented in > > javascript. > > How about using the gobject libvirt bindings? > > https://libvirt.org/git/?p=libvirt-glib.git;a=summary

Re: [libvirt] [PATCH] CI: also run tests using updated distro(s)

2017-05-31 Thread Claudio André
Em 31/05/2017 04:12, Martin Kletzander escreveu: Without -qq is much worse. We can: 1. collapse as seen above; 2. redirect stdout to /dev/null (I mean, there is no important information here). I prefer (and use) #2. either -qq collapsed or just put it to /dev/null. I don't care which one,

Re: [libvirt] Remotable Libvirt

2017-05-31 Thread Richard W.M. Jones
On Thu, May 25, 2017 at 10:26:47AM -0700, Peter wrote: > The majority of cockpit is implemented in > javascript. How about using the gobject libvirt bindings? https://libvirt.org/git/?p=libvirt-glib.git;a=summary They should be usable from Javascript directly, as in the .js example here:

Re: [libvirt] [PATCH] virsh: ignore readline -Wstrict-prototypes warning

2017-05-31 Thread Ján Tomko
On Fri, May 26, 2017 at 09:49:15PM +0400, Roman Bogorodskiy wrote: When building with clang 4.0.0, virsh build fails like this: gmake[3]: Entering directory '/usr/home/novel/code/libvirt/tools' CC virsh-virsh.o In file included from virsh.c:45: In file included from

Re: [libvirt] [PATCH] virsh: ignore readline -Wstrict-prototypes warning

2017-05-31 Thread Roman Bogorodskiy
Roman Bogorodskiy wrote: > When building with clang 4.0.0, virsh build fails like this: > > gmake[3]: Entering directory '/usr/home/novel/code/libvirt/tools' > CC virsh-virsh.o > In file included from virsh.c:45: > In file included from /usr/local/include/readline/readline.h:31: >

Re: [libvirt] [PATCH] Add some news items for the 3.4.0 release

2017-05-31 Thread Peter Krempa
On Wed, May 31, 2017 at 16:06:48 +0200, Martin Kletzander wrote: > Signed-off-by: Martin Kletzander > --- > I could not be bothered to split the patches. Also, please review > whatever you know about as this is just a compilation of stuff from > the git log. > >

[libvirt] [PATCH] Add some news items for the 3.4.0 release

2017-05-31 Thread Martin Kletzander
Signed-off-by: Martin Kletzander --- I could not be bothered to split the patches. Also, please review whatever you know about as this is just a compilation of stuff from the git log. docs/news.xml | 166 +- 1 file

Re: [libvirt] [PATCH] qemu: mkdir memory_backing_dir on startup

2017-05-31 Thread Peter Krempa
On Wed, May 31, 2017 at 15:17:24 +0200, Michal Privoznik wrote: > On 05/31/2017 03:00 PM, Andrea Bolognani wrote: > > On Sat, 2017-05-27 at 12:45 +0200, Michal Privoznik wrote: > >> In 48d9e6cdcc and friends we've allowed users to back guest > >> memory by a file inside the host. And in order to

Re: [libvirt] [PATCH v4 0/5] Hyperv-method invocation

2017-05-31 Thread Matthias Bolte
2017-05-19 22:57 GMT+02:00 Sri Ramanujam : > Changes from v3: > > * Feedback from code review > * Added 5 minute timeout to hypervInvokeMethod > > Sri Ramanujam (5): > hyperv: Functions to work with invocation parameters. > hyperv: Generate object property type

Re: [libvirt] [PATCH] qemu: mkdir memory_backing_dir on startup

2017-05-31 Thread Michal Privoznik
On 05/31/2017 03:00 PM, Andrea Bolognani wrote: > On Sat, 2017-05-27 at 12:45 +0200, Michal Privoznik wrote: >> In 48d9e6cdcc and friends we've allowed users to back guest >> memory by a file inside the host. And in order to keep things >> manageable the memory_backing_dir variable was introduced

Re: [libvirt] [PATCH 0/2] Two simple sparse streams fixes

2017-05-31 Thread Pino Toscano
On Wednesday, 31 May 2017 13:03:38 CEST Martin Kletzander wrote: > - vol-download --sparse --offset $source_file_size --length 1 >/path/to/source.file destination.file > > - Every now and then (not always) it gets stuck waiting for the > daemon to receive data (see backtrace

Re: [libvirt] [PATCH] qemu: mkdir memory_backing_dir on startup

2017-05-31 Thread Andrea Bolognani
On Sat, 2017-05-27 at 12:45 +0200, Michal Privoznik wrote: > In 48d9e6cdcc and friends we've allowed users to back guest > memory by a file inside the host. And in order to keep things > manageable the memory_backing_dir variable was introduced to > qemu.conf to specify the directory where the

Re: [libvirt] [PATCH go-xml] Add support for Node Device with basic testing.

2017-05-31 Thread Daniel P. Berrange
On Tue, May 30, 2017 at 10:36:22AM -0400, Vladik Romanovsky wrote: > Thanks for the review. > > On Tue, May 30, 2017 at 8:46 AM, Daniel P. Berrange > wrote: > >> +type NodeDevice struct { > >> + Name string `xml:"name"` > >> + Path string

Re: [libvirt] [PATCH go-xml] 1, add support for disk cache and io, and add test case. 2, add support for controller model, and add test case. 3, extend DomainAddress struct for PCI address and target

2017-05-31 Thread Daniel P. Berrange
On Wed, May 31, 2017 at 09:26:01AM +0100, Daniel P. Berrange wrote: > On Wed, May 31, 2017 at 01:32:47PM +0800, ZhenweiPi wrote: > > --- > > > > domain.go | 13 +++-- > > domain_test.go | 56 > > +--- > > 2 files changed, 64

Re: [libvirt] [PATCH v2] virsh: add [--domain DOMAIN] option to domxml-to-native DOMAIN COMMAND

2017-05-31 Thread Martin Kletzander
On Mon, May 29, 2017 at 02:08:53PM -0400, Daniel Liu wrote: The option allows someone to run domain-to-native on already existing domain without the need of supplying their XML. It is basically wrapper around 'virsh dumpxml | virsh domxml-to-native /dev/stdin'. Resolves:

Re: [libvirt] [PATCH] udev: Fix build on older platforms

2017-05-31 Thread Erik Skultety
On Wed, May 31, 2017 at 12:44:37PM +0200, Michal Privoznik wrote: > On 05/31/2017 12:22 PM, Erik Skultety wrote: > > Caused by commit @d1eea6c1 due to the missing symbol on older platforms. > > > > Signed-off-by: Erik Skultety > > --- > > Despite falling under build-breaker

Re: [libvirt] Availability of libvirt-3.4.0 Release Candidate 2

2017-05-31 Thread Erik Skultety
On Wed, May 31, 2017 at 12:53:08PM +0200, Andrea Bolognani wrote: > On Tue, 2017-05-30 at 23:15 +0200, Daniel Veillard wrote: > >   As scheduled, I have tagged it in git and pushed signed tarball and rpms > > to the usual place: > > > >   ftp://libvirt.org/libvirt/ > > > >  no difference in my

[libvirt] [PATCH v2 1/2] virfdstream: Check for thread error more frequently

2017-05-31 Thread Michal Privoznik
When the I/O thread quits (e.g. due to an I/O error, lseek() error, whatever), any subsequent virFDStream API should return error too. Moreover, when invoking stream event callback, we must set the VIR_STREAM_EVENT_ERROR flag so that the callback knows something bad happened. Signed-off-by:

Re: [libvirt] [PATCH 0/2] Two simple sparse streams fixes

2017-05-31 Thread Michal Privoznik
On 05/31/2017 01:03 PM, Martin Kletzander wrote: > On Tue, May 30, 2017 at 12:44:21PM +0200, Michal Privoznik wrote: >> I've been experimenting with sparse streams and found a bug. If you >> try to >> download a volume which doesn't support sparseness here's what happens: >> >> # virsh

Re: [libvirt] [PATCH 0/2] Two simple sparse streams fixes

2017-05-31 Thread Martin Kletzander
On Tue, May 30, 2017 at 12:44:21PM +0200, Michal Privoznik wrote: I've been experimenting with sparse streams and found a bug. If you try to download a volume which doesn't support sparseness here's what happens: # virsh vol-download --sparse

Re: [libvirt] Availability of libvirt-3.4.0 Release Candidate 2

2017-05-31 Thread Daniel Veillard
On Wed, May 31, 2017 at 12:53:08PM +0200, Andrea Bolognani wrote: > On Tue, 2017-05-30 at 23:15 +0200, Daniel Veillard wrote: > >   As scheduled, I have tagged it in git and pushed signed tarball and rpms > > to the usual place: > >  > >   ftp://libvirt.org/libvirt/ > >  > >  no difference in my

Re: [libvirt] Availability of libvirt-3.4.0 Release Candidate 2

2017-05-31 Thread Andrea Bolognani
On Tue, 2017-05-30 at 23:15 +0200, Daniel Veillard wrote: >   As scheduled, I have tagged it in git and pushed signed tarball and rpms > to the usual place: >  >   ftp://libvirt.org/libvirt/ >  >  no difference in my limited testing compared to rc1, looks fine > https://ci.centos.org/view/libvirt/

Re: [libvirt] [PATCH] udev: Fix build on older platforms

2017-05-31 Thread Michal Privoznik
On 05/31/2017 12:22 PM, Erik Skultety wrote: > Caused by commit @d1eea6c1 due to the missing symbol on older platforms. > > Signed-off-by: Erik Skultety > --- > Despite falling under build-breaker category, I'd like to get a proper review, > since I'm not really familiar

Re: [libvirt] [PATCH] udev: Fix build on older platforms

2017-05-31 Thread Daniel P. Berrange
On Wed, May 31, 2017 at 12:22:01PM +0200, Erik Skultety wrote: > Caused by commit @d1eea6c1 due to the missing symbol on older platforms. > > Signed-off-by: Erik Skultety > --- > Despite falling under build-breaker category, I'd like to get a proper review, > since I'm not

[libvirt] [PATCH] udev: Fix build on older platforms

2017-05-31 Thread Erik Skultety
Caused by commit @d1eea6c1 due to the missing symbol on older platforms. Signed-off-by: Erik Skultety --- Despite falling under build-breaker category, I'd like to get a proper review, since I'm not really familiar with autoconf and there might be a better fix. Erik

Re: [libvirt] [PATCH go-xml] 1, add support for disk cache and io, and add test case. 2, add support for controller model, and add test case. 3, extend DomainAddress struct for PCI address and target

2017-05-31 Thread Daniel P. Berrange
On Wed, May 31, 2017 at 01:32:47PM +0800, ZhenweiPi wrote: > --- > > domain.go | 13 +++-- > domain_test.go | 56 +--- > 2 files changed, 64 insertions(+), 5 deletions(-) > > diff --git a/domain.go b/domain.go > index

Re: [libvirt] [PATCH 1/2] virfdstream: Check for thread error more frequently

2017-05-31 Thread Martin Kletzander
On Tue, May 30, 2017 at 12:44:22PM +0200, Michal Privoznik wrote: When the I/O thread quits (e.g. due to an I/O error, lseek() error, whatever), any subsequent virFDStream API should return error too. Moreover, when invoking stream event callback, we must set the VIR_STREAM_EVENT_ERROR flag so

Re: [libvirt] [PATCH] CI: also run tests using updated distro(s)

2017-05-31 Thread Martin Kletzander
On Tue, May 30, 2017 at 03:52:06PM -0300, Claudio André wrote: Em 29/05/2017 08:54, Martin Kletzander escreveu: On Sun, May 28, 2017 at 11:07:41PM -0300, claudioandre...@gmail.com wrote: From: Claudio André 'modprobe -c' fails for some reason. Ahh! Well, it is

Re: [libvirt] [PATCH] qemu: Use iohelper during restore

2017-05-31 Thread Shivaprasad bhat
Hi All, Can someone review the patch please ? Thanks, Shivaprasad On Wed, Mar 15, 2017 at 11:22 AM, Shivaprasad bhat < shivaprasadb...@gmail.com> wrote: > ping.. > > On Fri, Jan 27, 2017 at 4:29 PM, Shivaprasad G Bhat < > sb...@linux.vnet.ibm.com> wrote: > >> Commit afe6e58 & c4caab53 made