Re: [libvirt] [PATCH] qemu: Add AAVMF32 to the list of known UEFIs

2017-06-09 Thread dann frazier
On Wed, Jun 7, 2017 at 12:52 PM, Christian Ehrhardt wrote: > Hi Dann, > there is currently some apparmor upstreaming going on [1]. > You'd want to add a similar line for your new paths as well I think. Good catch Christian - I'll wait for that to land and

Re: [libvirt] [PATCH] qemuDomainBlockCopyCommon: Fix the memory leak

2017-06-09 Thread Andrea Bolognani
Not sure why you decided to CC: me, especially considering that I've never touched the code in question; it's not the first time that's happened, either. Please don't CC: random developers when posting patches. On Fri, 2017-06-09 at 17:12 +0800, Jie Wang wrote: > When take the cleanup branch,

[libvirt] [PATCH] qemuDomainBlockCopyCommon: Fix the memory leak

2017-06-09 Thread Jie Wang
When take the cleanup branch, will leads to the mirror memory leak --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 1e3c7fc..74cc2c4 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c

[libvirt] [PATCH v2] Report more correct information for cache control

2017-06-09 Thread Martin Kletzander
On some platforms the number of bits in the cbm_mask might not be divisible by 4 (and not even by 2), so we need to properly count the bits. Similar file, min_cbm_bits, is properly parsed and used, but if the number is greater than one, we lose the information about granularity when reporting the

Re: [libvirt] [PATCH] qemu: report an error if usb keyboards are unsupported

2017-06-09 Thread Jiri Denemark
On Fri, Jun 09, 2017 at 08:37:35 +0200, Ján Tomko wrote: > Be nicer to the user and report a proper error instead of: > An error occurred, but the cause is unknown > > https://bugzilla.redhat.com/show_bug.cgi?id=1460086 > --- > src/qemu/qemu_command.c | 6 +- > 1 file changed, 5

Re: [libvirt] Need help with running libvirt-test-api

2017-06-09 Thread Kairui Song
Hi, I can confirmed it's a bug introduced by commit e55e0ce9, you can revert it or apply the patch in the attachments. On Fri, Jun 9, 2017 at 12:27 AM, wrote: > Hi All, > I am new to libvirt; to create a virtual machine using libvirt-test-API > framework, I am

[libvirt] [PATCH] qemu: report an error if usb keyboards are unsupported

2017-06-09 Thread Ján Tomko
Be nicer to the user and report a proper error instead of: An error occurred, but the cause is unknown https://bugzilla.redhat.com/show_bug.cgi?id=1460086 --- src/qemu/qemu_command.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_command.c